[SCM] Samba Shared Repository - branch master updated

Volker Lendecke vlendec at samba.org
Wed Apr 9 10:27:03 MDT 2014

The branch, master has been updated
       via  88ba811 s4-wbclient: Fix wbc_sids_to_xids to correctly indicate the length of the SID list
      from  d956608 tdb: consolidate tdb allocation code - re-use dead records at hash top.


- Log -----------------------------------------------------------------
commit 88ba81140eb98494fb48ac29b9450e582ceaf10d
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Apr 9 12:43:54 2014 +1200

    s4-wbclient: Fix wbc_sids_to_xids to correctly indicate the length of the SID list
    This uses the fact that we know the end of the string in p to avoid
    needing a strlen() call.  Otherwise the winbindd validation that the
    extra_data is terminated may fail, if the un-initiliased memory is not
    Andrew Bartlett
    Change-Id: I9b28068e4fbd3754c8d14724af93638d657810dd
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Autobuild-User(master): Volker Lendecke <vl at samba.org>
    Autobuild-Date(master): Wed Apr  9 18:26:40 CEST 2014 on sn-devel-104


Summary of changes:
 source4/libcli/wbclient/wbclient.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Changeset truncated at 500 lines:

diff --git a/source4/libcli/wbclient/wbclient.c b/source4/libcli/wbclient/wbclient.c
index b5183be..6156623 100644
--- a/source4/libcli/wbclient/wbclient.c
+++ b/source4/libcli/wbclient/wbclient.c
@@ -146,7 +146,7 @@ NTSTATUS wbc_sids_to_xids(struct tevent_context *ev, struct id_map *ids,
 	req.pid = getpid();
 	req.extra_data.data = sids;
-	req.extra_len = sidslen;
+	req.extra_len = (p - sids);
 	ret = wb_simple_trans(ev, fd, &req, mem_ctx, &resp, &err);
 	if (ret == -1) {

Samba Shared Repository

More information about the samba-cvs mailing list