[SCM] Samba Shared Repository - branch master updated
Andrew Bartlett
abartlet at samba.org
Wed Apr 2 03:05:04 MDT 2014
The branch, master has been updated
via e1ec1f5 wafsamba: explicitly use allow_warnings=True for SAMBA_PYTHON()
via b7f8ec9 s4:torture/wscript_build: explicitly use allow_warnings=True where needed
via fce5bc4 s4:torture/winbind: explicitly use allow_warnings=True
via 75cca8a s4:torture/smb2: explicitly use allow_warnings=True
via a2c82a7 s4:torture/libnetapi: explicitly use allow_warnings=True
via cea6d7e s4:ntvfs/unixuid: explicitly use allow_warnings=True
via 3f742fc s4:rpc_server: explicitly use allow_warnings=True where needed
via daadf3b s4:kdc: explicitly use allow_warnings=True for MIT_SAMBA
via daf6d0f s4:auth/gensec: explicitly use allow_warnings=True for gssapi and sasl modules
via 6662c2b s4:librpc: explicitly use allow_warnings=True where needed
via bb187cc s4:lib/tls: explicitly use allow_warnings=True
via 835f8b7 s4:lib/registry: explicitly use allow_warnings=True
via 1b16b42 s4:lib/messaging: explicitly use allow_warnings=True
via 19f30c3 s4:lib/events: explicitly use allow_warnings=True
via 7e3e573 s4:lib/com: explicitly use allow_warnings=True
via 7a53e14 s3:wscript_build: explicitly use allow_warnings=True where needed
via f420466 s3:rpc_server: explicitly use allow_warnings=True for RPC_SPOOLSS
via 0f6c31c s3:pam_smbpass: explicitly use allow_warnings=True
via ba07368 s3:modules: explicitly use allow_warnings=True were needed
via 35e9915 auth/kerberos: explicitly use allow_warnings=True
via 5158ae4 lib/socket_wrapper: explicitly use allow_warnings=True
via 09fb085 lib/zlib: explicitly use allow_warnings=True
via ee3adcd lib/popt: explicitly use allow_warnings=True
via 9e0ae16 lib/ldb: explicitly use allow_warnings=True
via f3fcb96 lib/ntdb: explicitly use allow_warnings=True for ntdb-test-helpers
via a939027 lib/ccan: explicitly use allow_warnings=True
via 06b48b0 s4:heimdal_build: explicitly pass allow_warnings=True to CURRENT_CFLAGS()
via 8a1f67b wafsamba: add optional allow_warnings(default=True) to SAMBA_{SUBSYSTEM,LIBRARY,MODULE}()
via 404f025 wafsamba: add an optional allow_warnings(default=True) to CURRENT_CFLAGS()
via 8cdd9f3 wafsamba: split out a conf.ADD_NAMED_CFLAGS() function
via 2f05932 wafsamba: use -Werror=declaration-after-statement if available
via e21aa7b wafsamba: use multiple conf.ADD_CFLAGS() lines for developer CFLAGS
via 0e61696 s4:torture: avoid const warnings in smbtorture.c
via 0aba677 s4:torture/rpc: avoid declaration after code warnings
via e444aca s4:torture/winbind: remove unused variable
via 6199aa5 s4:torture/nbt: remove unused variable
via 79bb815 s4:torture/nbt: avoid str_list related const warnings
via 2812a4a s4:torture/ntp: add missing #include "torture/ntp/proto.h"
via 04f7fc0 s4:torture/nbt: add missing #include "torture/nbt/proto.h"
via aa78d0e s4:torture/unix: add missing #include "torture/unix/proto.h"
via d71d0d4 s4:torture/libnet: add missing #include "torture/libnet/proto.h"
via 8195a71 s4:torture: avoid argv related const warnings
via f2103cc s4:torture/ldap: add includes to avoid compiler warnings
via 2f0f7af s4:torture/local: only pass prefix strings to tdb_add_record() in dbspeed.c
via e794206 s4:torture/local: add missing #include "torture/local/proto.h"
via cdaa33d s4:param/tests: add missing #include "torture/local/proto.h"
via cc1c1f5 s4:librpc/tests: add missing #include "torture/local/proto.h"
via 6788a40 s4:libcli/tests: add missing #include "torture/local/proto.h"
via 9594cf6 s4:lib/tests: add missing #include "torture/local/proto.h"
via 4e54049 lib/tevent/tests: add missing #include "torture/local/proto.h"
via d8ec961 lib/tdr/tests: add missing #include "torture/local/proto.h"
via c19be3b lib/socket_wrapper/tests: add missing #include "torture/local/proto.h"
via 11736a3 lib/nss_wrapper/tests: add missing #include "torture/local/proto.h"
via 8ba775b lib/util/tests: add missing #include "torture/local/proto.h"
via 3f5e05f lib/compression/tests: add missing #include "torture/local/proto.h"
via 2aebf16 auth/tests: add missing #include "torture/local/proto.h"
via ee06cbc s4:dsdb/ldb_modules: avoid invalid pointer type warnings
via cd103d8 s4:dsdb/ldb_modules: avoid str_list related const warnings
via de773f3 s4:dsdb/ldb_modules: avoid declaration after code warnings
via 7377aa1 s4:smb_server/smb: fix invalid pointer type warnings in negprot.c
via 4fa922c s4:smb_server/smb: fix declaration after code warnings in negprot.c
via 816a330 s4:ntvfs/sysdep: add sys_notify_inotify_init() prototype to avoid a warning
via 2b098c1 s4:ntvfs/posix: correctly reset errno on success in pvfs_sys_mkdir()
via 0053603 s4:ntvfs/posix: avoid const warnings in pvfs_resolve_name_handle()
via 1ac4fba s4:ntvfs/common: explicitly check the status of imessaging_send() in notify_send()
via fbc991c s4:auth/ntlm: add auth4_sam_init() prototype to avoid a warning
via e1d5b8a s4:auth: avoid str_list related const warnings
via 876f0e0 s4:auth/gensec: fix declaration after code warning in gensec_tstream.c
via 04c8c65 s4:auth/gensec: include gensec_krb5_util.h in gensec_krb5_util.c
via ba10781 s4:libcli/resolve: avoid some const warnings
via c3699d1 s3:winbindd: avoid argv related const warnings
via b0d09ee s3:utils: explicitly check the return value of fscanf() to avoid unused warnings in smbta-util.c
via bba7f28 s3:utils: check the status of open_socket_out() correctly in smbfilter.c
via 8f9c121 s3:utils: use char packet[] in smbfilter.c to avoid warnings
via c2a26fe s3:utils: avoid argv related const warnings
via 9e97106 s3:torture: avoid compiler warnings in vfstest.c
via 5686c80 s3:torture: check the result of cli_nt_delete_on_close_recv() in test_notify.c
via 70b7ef9 s3:torture: remove unused variables in test_buffersize.c
via 88d0ff7 s3:torture: avoid explicit casting and compiler warnings in pdbtest.c
via 427db65 s3:smbd: let srvstr_pull_req_talloc() take 'const uint8_t *src'
via 0cf9f9d s3:smbd: avoid compiler warnings in smbd_tevent_trace_callback()
via 5964d49 s3:registry: fix invalid pointer type warning in reg_format.c
via 80c57ab s3:lib/netapi/examples: remove unused variables
via 7d3b35c s3:lib/netapi/examples: fix const warnings in netlogon_control2.c
via 59394b3 s3:lib/netapi/examples: fix invalid pointer value warnings in getjoininformation.c
via 18c19d5 s3:lib/netapi: fix some incompatible pointer type warnings in NetGetJoinableOUs_l()
via defe9aa s3:lib/smbconf: fix const warnings in testsuite.c
via fc95672 s3:lib: fix a const warning in client_match()
via 71869a1 libcli/lsarpc: add struct trustAuthInOutBlob; forward declaration
via cd648ec libcli/auth: s/encrypt/do_encrypt
via c851900 examples/libsmbclient: avoid some compiler warnings
via 0b757c9 librpc/idl: remove unused [gensize] from DNS_RPC_RECORD_STRING
via d99c0bb libcli/security: s/remove/remove_ace/
via f03653e lib/util: fix const warnings
via cc2bc23 lib/util: declare smb_panic_default() as _NORETURN_
via 835c95c tdb/wscript: maintain a global list of unit tests
via 2a9d5a3 tdb/test: avoid const warnings by using 'discard_const_p(uint8_t,' instead of '(void *)'
via 6871bf6 tdb/test: remove "
" in diag() arguments
via 71fddde tdb/test: always call fflush() after [f]printf() in tap-interface.h
via e301d1b tdb/tools: avoid const warnings in tdbdump.c
via 80dff80 tdb: don't alter errno on success of tdb_open_ex()
via b8f9169 lib/zlib: make use of conf.CHECK_BUNDLED_SYSTEM()
via cc765ba wafsamba: allow --bundled-libraries=ALL,!popt
via c19e5a0 wafsamba: allow --bundled-libraries=NONE,popt
via ef380bb wafsamba: simplify LIB_MUST_BE_BUNDLED()
via 9a8e35a wafsamba: simplify LIB_MAY_BE_BUNDLED()
via 6ae4121 wafsamba: allow optional 'checkcode' argument to CHECK_BUNDLED_SYSTEM()
via 764706c wafsamba: allow CHECK_BUNDLED_SYSTEM() to check headers without functions
via cec109c wafsamba: simplify CHECK_BUNDLED_SYSTEM_PKG() by just calling CHECK_BUNDLED_SYSTEM()
via 4dea4e3 wafsamba: port optional 'pkg' option from CHECK_BUNDLED_SYSTEM_PKG() to CHECK_BUNDLED_SYSTEM()
via d88f41f wafsamba: require a ';' after STATIC_*_MODULES_PROTO
from 7f2d12c Rename module init functions from samba_init_module
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit e1ec1f5d8df8511b2320cd25676896de170983d1
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:34:51 2014 +0100
wafsamba: explicitly use allow_warnings=True for SAMBA_PYTHON()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Wed Apr 2 11:04:36 CEST 2014 on sn-devel-104
commit b7f8ec97db3ab958135541d8d8d2bf062ad35752
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
s4:torture/wscript_build: explicitly use allow_warnings=True where needed
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit fce5bc4f422c4616dd14f7bb68ab579d140f31b3
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
s4:torture/winbind: explicitly use allow_warnings=True
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 75cca8a3068ab9a32c98c43aa790325b39b90d8b
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
s4:torture/smb2: explicitly use allow_warnings=True
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit a2c82a7d191575b7b7070b6f51cc750558e5b781
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
s4:torture/libnetapi: explicitly use allow_warnings=True
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit cea6d7e4a30e3e656e7702074dad9573f39164e1
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
s4:ntvfs/unixuid: explicitly use allow_warnings=True
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 3f742fc2f2c017d898b33918fb16633ac3f43d1e
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
s4:rpc_server: explicitly use allow_warnings=True where needed
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit daadf3b9287e0855eb2039b11e9a9d68193a9f90
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
s4:kdc: explicitly use allow_warnings=True for MIT_SAMBA
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit daf6d0fb287e567727825f5a619714bd94b03e8b
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
s4:auth/gensec: explicitly use allow_warnings=True for gssapi and sasl modules
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 6662c2b096dbd5fdd0e2eb0a4e328466afa95e70
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
s4:librpc: explicitly use allow_warnings=True where needed
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit bb187cc1e94040ad06d0af507a51284baa297aac
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
s4:lib/tls: explicitly use allow_warnings=True
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 835f8b7e2ec6f5cd3556c7600ea7cfb400bad824
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
s4:lib/registry: explicitly use allow_warnings=True
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 1b16b425d36ca4f2b95124025569b98cccfd7764
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
s4:lib/messaging: explicitly use allow_warnings=True
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 19f30c3834ce7c3f4ef3e6f3038cfb0bca417166
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
s4:lib/events: explicitly use allow_warnings=True
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 7e3e5738e4bcc461aac27d1202b6e1990878f27c
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
s4:lib/com: explicitly use allow_warnings=True
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 7a53e14d3b4307bdb12c7a9fa847a12f41dfb033
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
s3:wscript_build: explicitly use allow_warnings=True where needed
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit f42046692a5326e4cbec89660c4de9b65481803b
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
s3:rpc_server: explicitly use allow_warnings=True for RPC_SPOOLSS
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 0f6c31cf53f2c5e6c30f54e0c218cb1b6cff2a55
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
s3:pam_smbpass: explicitly use allow_warnings=True
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ba07368c68f6204a18eedd8e0af19d43fd33a33f
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
s3:modules: explicitly use allow_warnings=True were needed
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 35e991558982d24aba728ae5c4e4c791f2777831
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
auth/kerberos: explicitly use allow_warnings=True
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 5158ae4dcd9230f46369915a11315b52c785197c
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
lib/socket_wrapper: explicitly use allow_warnings=True
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 09fb085b85b1fe63a2005b9dec81e68110e67d07
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
lib/zlib: explicitly use allow_warnings=True
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ee3adcdff2fa77eef6289c8949608a53531406a3
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
lib/popt: explicitly use allow_warnings=True
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 9e0ae164a94727369050a9bbf840e02e022d216f
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
lib/ldb: explicitly use allow_warnings=True
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit f3fcb9649bb631a9bbe44c62e35fbc83c7b116a7
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
lib/ntdb: explicitly use allow_warnings=True for ntdb-test-helpers
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit a939027c6ee69f02e83c21ce419407373000d206
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
lib/ccan: explicitly use allow_warnings=True
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 06b48b028c329f765b57a996d6004a5542d6f142
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:35:22 2014 +0100
s4:heimdal_build: explicitly pass allow_warnings=True to CURRENT_CFLAGS()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 8a1f67b53b11a11bb472c1d0b0010cd24b3106df
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 19 15:48:34 2014 +0100
wafsamba: add optional allow_warnings(default=True) to SAMBA_{SUBSYSTEM,LIBRARY,MODULE}()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 404f025284f594197562f4a2003fb18898faa885
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 19 15:48:34 2014 +0100
wafsamba: add an optional allow_warnings(default=True) to CURRENT_CFLAGS()
-Werror is now remembered in PICKY_CFLAGS and only added if
allow_warnings is False.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 8cdd9f3a7f5e2576c0676eeef32b44484516e885
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 19 15:48:34 2014 +0100
wafsamba: split out a conf.ADD_NAMED_CFLAGS() function
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 2f059329b0aa617907f25d31c9d65ccaa54e78e9
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Mar 10 16:15:14 2014 +0100
wafsamba: use -Werror=declaration-after-statement if available
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit e21aa7bf098a7f2e9c0d0b5bd73dbfcc73ec494a
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Mar 10 16:15:14 2014 +0100
wafsamba: use multiple conf.ADD_CFLAGS() lines for developer CFLAGS
We first check for warn flags then for error flags.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 0e6169626a2be3e127b6a7f1a7d06ed722e7d9b6
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
s4:torture: avoid const warnings in smbtorture.c
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 0aba6770a16f45c5a4dcf54fba8de457cddddaf6
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
s4:torture/rpc: avoid declaration after code warnings
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit e444aca4b3979f5e4b5258320a31a67eb6814177
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
s4:torture/winbind: remove unused variable
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 6199aa5b55d4c0dadc618318b21bd64a578d9e83
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
s4:torture/nbt: remove unused variable
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 79bb815042a19d30cb772e6341f9fb33e4a409d6
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
s4:torture/nbt: avoid str_list related const warnings
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 2812a4aa06fa64fcde0aed67c7097febd8d4d919
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
s4:torture/ntp: add missing #include "torture/ntp/proto.h"
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 04f7fc0c3069d3792bb659c81a2b84c9cfdd3297
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
s4:torture/nbt: add missing #include "torture/nbt/proto.h"
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit aa78d0ee637296b9a3a689a3ca2cb6957854b729
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
s4:torture/unix: add missing #include "torture/unix/proto.h"
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit d71d0d4a3589c040123d414944348ea85b000448
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
s4:torture/libnet: add missing #include "torture/libnet/proto.h"
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 8195a7155a9b52a7c343a292fcb2012b0ab32b2b
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
s4:torture: avoid argv related const warnings
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit f2103cc7a78b883c867380e2a69a898f2f7c5da1
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
s4:torture/ldap: add includes to avoid compiler warnings
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 2f0f7af39cb72d421122676225b3ff4c4577d076
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
s4:torture/local: only pass prefix strings to tdb_add_record() in dbspeed.c
This way the compiler has a chance to check the format string.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit e794206ed0e313828a6c751695864e96db36ba66
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
s4:torture/local: add missing #include "torture/local/proto.h"
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit cdaa33dd38a469f26289edd801c27ececf9568a3
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
s4:param/tests: add missing #include "torture/local/proto.h"
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit cc1c1f5b10f423e74756a9ecf4ad1d1dc419654e
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
s4:librpc/tests: add missing #include "torture/local/proto.h"
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 6788a4085c14b483f7941240254915eb64b11c18
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
s4:libcli/tests: add missing #include "torture/local/proto.h"
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 9594cf67b1188f9a329b1561d733d26790c16604
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
s4:lib/tests: add missing #include "torture/local/proto.h"
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 4e5404967ecfd865d8554acfde8fa45c94702eb6
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
lib/tevent/tests: add missing #include "torture/local/proto.h"
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit d8ec961b3d5ca035a8e8deae2ff6385a63032b70
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
lib/tdr/tests: add missing #include "torture/local/proto.h"
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit c19be3b18be0dc3782c0a02bcf5ad5fcc9ce52ec
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
lib/socket_wrapper/tests: add missing #include "torture/local/proto.h"
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 11736a37e98e2d53f50db6e196193cc0be07dacf
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
lib/nss_wrapper/tests: add missing #include "torture/local/proto.h"
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 8ba775b0a3e22a83bca092114dbb9f345d6ff89f
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
lib/util/tests: add missing #include "torture/local/proto.h"
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 3f5e05f024da17f3601b39ba32a3fb5e2168a2f5
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
lib/compression/tests: add missing #include "torture/local/proto.h"
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 2aebf16ac1c250efb4992253d2b848e3c4832e14
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
auth/tests: add missing #include "torture/local/proto.h"
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ee06cbce30ccdb057ffc5b3da2d7fb1010a13837
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:29:36 2014 +0100
s4:dsdb/ldb_modules: avoid invalid pointer type warnings
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit cd103d84e64c35ad7098445d3780be3aef396ff1
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:29:36 2014 +0100
s4:dsdb/ldb_modules: avoid str_list related const warnings
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit de773f3785d8fedba605437fbd434a49b9d18b0e
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:29:36 2014 +0100
s4:dsdb/ldb_modules: avoid declaration after code warnings
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 7377aa11f733f2f6d1302f183cc39cf233739769
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
s4:smb_server/smb: fix invalid pointer type warnings in negprot.c
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 4fa922cc0f0ae52af9fc82e1194613350a0be8c6
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:08:17 2014 +0100
s4:smb_server/smb: fix declaration after code warnings in negprot.c
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 816a3309c3cda04b1f25e8956ca9efbe175173f4
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:29:36 2014 +0100
s4:ntvfs/sysdep: add sys_notify_inotify_init() prototype to avoid a warning
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 2b098c15fdf7ae65d87427aaeab170cf6cfea8bc
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:29:36 2014 +0100
s4:ntvfs/posix: correctly reset errno on success in pvfs_sys_mkdir()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 0053603283e032834c99ef78e2471515c14c48be
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:29:36 2014 +0100
s4:ntvfs/posix: avoid const warnings in pvfs_resolve_name_handle()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 1ac4fba4bf03ba4e3db3bc1064716a31ace3ddec
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:29:36 2014 +0100
s4:ntvfs/common: explicitly check the status of imessaging_send() in notify_send()
This avoid an unused warning...
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit fbc991c2e140eb009e37581faa738f1487161d5c
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:29:36 2014 +0100
s4:auth/ntlm: add auth4_sam_init() prototype to avoid a warning
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit e1d5b8a73465a1763760dbf5a992f84749e26426
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 20:16:26 2014 +0100
s4:auth: avoid str_list related const warnings
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 876f0e03de26aea19004b3347dcde5e251eb50ac
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 20:16:26 2014 +0100
s4:auth/gensec: fix declaration after code warning in gensec_tstream.c
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 04c8c65e4cf0d8e8953f63148beef2e2a6569887
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 20:16:26 2014 +0100
s4:auth/gensec: include gensec_krb5_util.h in gensec_krb5_util.c
This avoids missing prototype warnings.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ba107816b5e5ade315bd66e5eba8b54dc97484e4
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:52:36 2014 +0100
s4:libcli/resolve: avoid some const warnings
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit c3699d1c44c75575f94f3d75f54d41c3efa13c89
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 20:16:26 2014 +0100
s3:winbindd: avoid argv related const warnings
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit b0d09ee39c7c35c727e320ecda50cf36e558b68b
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 20:16:26 2014 +0100
s3:utils: explicitly check the return value of fscanf() to avoid unused warnings in smbta-util.c
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit bba7f285f9a6b82a12f5159b8ce830fb40512494
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 20:16:26 2014 +0100
s3:utils: check the status of open_socket_out() correctly in smbfilter.c
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 8f9c12195d3b5e0879d6343aefa4f238cbca30fa
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 20:16:26 2014 +0100
s3:utils: use char packet[] in smbfilter.c to avoid warnings
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit c2a26fe5e78bf5eaa7cc8fe929bb9546dc9c45bd
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 20:16:26 2014 +0100
s3:utils: avoid argv related const warnings
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 9e971068d002758be67a26dbc76fb4be949fb009
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 20:16:26 2014 +0100
s3:torture: avoid compiler warnings in vfstest.c
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 5686c80966f3f58dbe7601c72f07662fd6cedbef
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 20:16:26 2014 +0100
s3:torture: check the result of cli_nt_delete_on_close_recv() in test_notify.c
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 70b7ef957376f1bcf4a223fd62639b3bcddd1003
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 20:16:26 2014 +0100
s3:torture: remove unused variables in test_buffersize.c
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 88d0ff74a0e03ac2e1e83cb62329d08c54b1c538
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 20:16:26 2014 +0100
s3:torture: avoid explicit casting and compiler warnings in pdbtest.c
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 427db654acec8e66e4c272b4e515c584ccb368c7
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 20:16:26 2014 +0100
s3:smbd: let srvstr_pull_req_talloc() take 'const uint8_t *src'
This is the correct thing to do the smb request buffer contains
just bytes (uint8_t).
It also avoids strange casting in the callers.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 0cf9f9d9139b1f1ceac1a8d37ca450da82f09c8c
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 20:16:26 2014 +0100
s3:smbd: avoid compiler warnings in smbd_tevent_trace_callback()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 5964d4969e3b6605593fad20ac000817d0b61a84
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 20:16:26 2014 +0100
s3:registry: fix invalid pointer type warning in reg_format.c
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 80c57ab7970fbf214d3f5c13e8d4b23d5d8846d0
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 20:16:26 2014 +0100
s3:lib/netapi/examples: remove unused variables
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 7d3b35c15504a557474e10236524e78d13980c55
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 20:16:26 2014 +0100
s3:lib/netapi/examples: fix const warnings in netlogon_control2.c
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 59394b36820d1f31354f61ebdc376b7fe080ab1e
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 20:16:26 2014 +0100
s3:lib/netapi/examples: fix invalid pointer value warnings in getjoininformation.c
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 18c19d51d1ae0597ab61e7da755c99df4ff86942
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 20:16:26 2014 +0100
s3:lib/netapi: fix some incompatible pointer type warnings in NetGetJoinableOUs_l()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit defe9aa675b0c36e970147f14a9f0299b9464e5d
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 20:16:26 2014 +0100
s3:lib/smbconf: fix const warnings in testsuite.c
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit fc95672bcb106290f688c6e437a37feb7d5189f5
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 20:16:26 2014 +0100
s3:lib: fix a const warning in client_match()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 71869a177c7609af888a55be5d77ca33407fb252
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:40:52 2014 +0100
libcli/lsarpc: add struct trustAuthInOutBlob; forward declaration
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit cd648ec00f0ee3afd452486c0a2a1f03be148416
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:40:03 2014 +0100
libcli/auth: s/encrypt/do_encrypt
This avoids compiler warnings.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit c8519003a34dc7db44854a3d844d1c7432d52a78
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 27 09:39:20 2014 +0100
examples/libsmbclient: avoid some compiler warnings
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 0b757c9bcfbe1e8db2c3f33f1a57d02d75c3186a
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Mar 10 16:19:43 2014 +0100
librpc/idl: remove unused [gensize] from DNS_RPC_RECORD_STRING
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit d99c0bb1fb559a54df5b152992294fb96d061901
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 08:12:09 2014 +0100
libcli/security: s/remove/remove_ace/
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit f03653e39aa01dea37a237996a2660206b0b01d4
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:38:07 2014 +0100
lib/util: fix const warnings
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit cc2bc23e46028bf58261a86ce3c2db437580611d
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 26 07:37:13 2014 +0100
lib/util: declare smb_panic_default() as _NORETURN_
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 835c95cb77fd7e1ebff7d228fe9ab4c60baa41cd
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 3 10:40:45 2014 +0100
tdb/wscript: maintain a global list of unit tests
This makes sure a new test is also added to 'make test'
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 2a9d5a323912d06fa84a5bc4b3481e8ca080eb56
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 3 11:31:05 2014 +0100
tdb/test: avoid const warnings by using 'discard_const_p(uint8_t,' instead of '(void *)'
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 6871bf689fd26727b284de9abe132b12ffff00ce
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Jan 30 13:20:33 2014 +0100
tdb/test: remove "\n" in diag() arguments
diag() already adds "\n".
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 71fddde83652d8048034532474e3b1cb32b33077
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Jan 30 13:01:08 2014 +0100
tdb/test: always call fflush() after [f]printf() in tap-interface.h
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit e301d1b9606d9323f0a1776d3a0dbce4b6db83a5
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 3 11:30:12 2014 +0100
tdb/tools: avoid const warnings in tdbdump.c
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 80dff80ee960c80e72c87c1f8e8deb7a2ae0b904
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Jan 30 16:07:10 2014 +0100
tdb: don't alter errno on success of tdb_open_ex()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit b8f91696f5464e88acb7fabe8bd9dbe9c4b5bd79
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Mar 14 10:34:00 2014 +0100
lib/zlib: make use of conf.CHECK_BUNDLED_SYSTEM()
This way --bundled-libraries=ALL will use the internal zlib version.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit cc765baa64c51de3c229697a130d691f336ac2f3
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Mar 14 10:48:56 2014 +0100
wafsamba: allow --bundled-libraries=ALL,!popt
This will not bundle 'popt', but everything else.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit c19e5a0386b7656e8b228720f4d565f29efdbc6c
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Mar 14 10:48:56 2014 +0100
wafsamba: allow --bundled-libraries=NONE,popt
This will bundle only 'popt'.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ef380bb2a934f608f64bf8752df12bf00bc2a8fd
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Mar 14 10:48:12 2014 +0100
wafsamba: simplify LIB_MUST_BE_BUNDLED()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 9a8e35a04919093b7423823e8eadd23f311493d2
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Mar 14 10:47:30 2014 +0100
wafsamba: simplify LIB_MAY_BE_BUNDLED()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 6ae4121da56e4a80d71c88984c17e7cc2b9d0f62
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Mar 14 10:19:41 2014 +0100
wafsamba: allow optional 'checkcode' argument to CHECK_BUNDLED_SYSTEM()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 764706c2b083b210917dd3966426851c2767b67e
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Mar 14 10:18:18 2014 +0100
wafsamba: allow CHECK_BUNDLED_SYSTEM() to check headers without functions
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit cec109ccf9ffe3079a9905bad9b2c52abf253a16
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Mar 14 09:55:45 2014 +0100
wafsamba: simplify CHECK_BUNDLED_SYSTEM_PKG() by just calling CHECK_BUNDLED_SYSTEM()
If checkfunctions is not specified they are the same.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 4dea4e310dfa0718fcd0d118fc97880f38714b36
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Mar 14 09:52:51 2014 +0100
wafsamba: port optional 'pkg' option from CHECK_BUNDLED_SYSTEM_PKG() to CHECK_BUNDLED_SYSTEM()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit d88f41f69865898dd814bb4dd3c46b9d153d1375
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Mar 27 09:37:26 2014 +0100
wafsamba: require a ';' after STATIC_*_MODULES_PROTO
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
-----------------------------------------------------------------------
Summary of changes:
auth/credentials/tests/simple.c | 1 +
auth/kerberos/wscript_build | 1 +
buildtools/wafsamba/samba_autoconf.py | 50 +++++++---
buildtools/wafsamba/samba_bundled.py | 104 +++++++++-----------
buildtools/wafsamba/samba_deps.py | 9 +-
buildtools/wafsamba/samba_python.py | 1 +
buildtools/wafsamba/wafsamba.py | 14 ++-
examples/libsmbclient/testacl2.c | 3 +-
examples/libsmbclient/testbrowse.c | 25 +++---
examples/libsmbclient/testctx.c | 5 +-
lib/ccan/wscript | 2 +
lib/compression/testsuite.c | 1 +
lib/ldb/wscript | 3 +
lib/nss_wrapper/testsuite.c | 1 +
lib/ntdb/wscript | 3 +-
lib/popt/wscript | 1 +
lib/socket_wrapper/testsuite.c | 1 +
lib/socket_wrapper/wscript_build | 1 +
lib/tdb/common/open.c | 2 +
lib/tdb/test/external-agent.c | 2 +-
lib/tdb/test/run-3G-file.c | 4 +-
lib/tdb/test/run-check.c | 4 +-
lib/tdb/test/run-corrupt.c | 4 +-
lib/tdb/test/run-die-during-transaction.c | 2 +-
lib/tdb/test/run-endian.c | 6 +-
lib/tdb/test/run-incompatible.c | 6 +-
lib/tdb/test/run-nested-transactions.c | 4 +-
lib/tdb/test/run-nested-traverse.c | 4 +-
lib/tdb/test/run-no-lock-during-traverse.c | 2 +-
lib/tdb/test/run-open-during-transaction.c | 6 +-
lib/tdb/test/run-readonly-check.c | 4 +-
lib/tdb/test/run-rescue.c | 8 +-
lib/tdb/test/run-transaction-expand.c | 2 +-
lib/tdb/test/run-traverse-in-transaction.c | 4 +-
lib/tdb/test/run-wronghash-fail.c | 2 +-
lib/tdb/test/run-zero-append.c | 4 +-
lib/tdb/test/run.c | 4 +-
lib/tdb/test/tap-interface.h | 26 ++++-
lib/tdb/tools/tdbdump.c | 2 +-
lib/tdb/wscript | 77 ++++++---------
lib/tdr/testsuite.c | 1 +
lib/tevent/testsuite.c | 1 +
lib/util/charset/tests/iconv.c | 1 +
lib/util/fault.c | 1 +
lib/util/parmlist.c | 7 +-
lib/util/tests/asn1_tests.c | 1 +
lib/util/tests/data_blob.c | 1 +
lib/util/tests/dlinklist.c | 1 +
lib/util/tests/file.c | 1 +
lib/util/tests/genrand.c | 1 +
lib/util/tests/idtree.c | 1 +
lib/util/tests/parmlist.c | 1 +
lib/util/tests/str.c | 1 +
lib/util/tests/strlist.c | 1 +
lib/util/tests/time.c | 1 +
lib/util/tevent_debug.c | 3 +-
lib/util/util_runcmd.c | 7 +-
lib/util/util_strlist.c | 2 +-
lib/zlib/wscript | 52 +++++-----
libcli/auth/credentials.c | 12 +-
libcli/lsarpc/util_lsarpc.h | 1 +
libcli/security/secdesc.c | 6 +-
librpc/idl/dnsserver.idl | 2 +-
source3/lib/access.c | 2 +-
.../lib/netapi/examples/join/getjoininformation.c | 11 +-
.../netapi/examples/netlogon/netlogon_control2.c | 4 +-
.../lib/netapi/examples/server/server_getinfo.c | 8 --
source3/lib/netapi/examples/share/share_add.c | 5 -
source3/lib/netapi/examples/user/user_modalsset.c | 10 --
source3/lib/netapi/examples/user/user_setinfo.c | 7 --
source3/lib/netapi/joindomain.c | 8 +-
source3/lib/smbconf/testsuite.c | 10 +-
source3/modules/wscript_build | 7 ++
source3/pam_smbpass/wscript_build | 1 +
source3/registry/reg_format.c | 4 +-
source3/rpc_server/wscript_build | 1 +
source3/smbd/message.c | 10 +-
source3/smbd/process.c | 5 +
source3/smbd/proto.h | 2 +-
source3/smbd/reply.c | 20 ++--
source3/smbd/sesssetup.c | 9 +-
source3/torture/pdbtest.c | 5 +-
source3/torture/test_buffersize.c | 1 -
source3/torture/test_notify.c | 4 +
source3/torture/vfstest.c | 36 ++++----
source3/utils/log2pcaphex.c | 4 +-
source3/utils/net.c | 7 +-
source3/utils/nmblookup.c | 4 +-
source3/utils/pdbedit.c | 4 +-
source3/utils/profiles.c | 4 +-
source3/utils/regedit.c | 4 +-
source3/utils/smbcacls.c | 5 +-
source3/utils/smbcquotas.c | 5 +-
source3/utils/smbfilter.c | 7 +-
source3/utils/smbta-util.c | 2 +-
source3/utils/smbtree.c | 7 +-
source3/utils/status.c | 4 +-
source3/winbindd/winbindd.c | 4 +-
source3/winbindd/winbindd_proto.h | 1 -
source3/wscript_build | 24 ++++-
source4/auth/gensec/gensec_krb5_util.c | 1 +
source4/auth/gensec/gensec_tstream.c | 3 +-
source4/auth/gensec/wscript_build | 2 +
source4/auth/ntlm/auth.c | 2 +-
source4/auth/ntlm/auth_sam.c | 1 +
source4/auth/sam.c | 4 +-
source4/dsdb/samdb/ldb_modules/dirsync.c | 5 +-
source4/dsdb/samdb/ldb_modules/operational.c | 2 +-
source4/dsdb/samdb/ldb_modules/partition.c | 3 +-
source4/dsdb/samdb/ldb_modules/samba_dsdb.c | 6 +-
source4/dsdb/samdb/ldb_modules/samldb.c | 1 -
source4/dsdb/samdb/ldb_modules/update_keytab.c | 8 +-
source4/heimdal_build/wscript_build | 4 +-
source4/kdc/wscript_build | 1 +
source4/lib/com/wscript_build | 2 +
source4/lib/events/wscript_build | 1 +
source4/lib/messaging/tests/irpc.c | 1 +
source4/lib/messaging/tests/messaging.c | 2 +-
source4/lib/messaging/wscript_build | 4 +-
source4/lib/registry/wscript_build | 1 +
source4/lib/socket/testsuite.c | 1 +
source4/lib/tls/wscript | 1 +
source4/libcli/resolve/nbtlist.c | 2 +-
source4/libcli/resolve/testsuite.c | 1 +
source4/libcli/resolve/wins.c | 7 +-
source4/libcli/security/tests/sddl.c | 1 +
source4/librpc/tests/binding_string.c | 1 +
source4/librpc/wscript_build | 4 +
source4/ntvfs/common/notify.c | 5 +
source4/ntvfs/posix/pvfs_resolve.c | 7 +-
source4/ntvfs/posix/pvfs_sys.c | 1 +
source4/ntvfs/sysdep/inotify.c | 1 +
source4/ntvfs/unixuid/wscript_build | 1 +
source4/param/tests/loadparm.c | 1 +
source4/param/tests/share.c | 1 +
source4/rpc_server/wscript_build | 3 +
source4/smb_server/smb/negprot.c | 11 +-
source4/torture/gentest.c | 4 +-
source4/torture/ldap/cldapbench.c | 2 +
source4/torture/ldap/ldap_sort.c | 3 +-
source4/torture/ldap/nested_search.c | 2 +
source4/torture/ldap/schema.c | 1 +
source4/torture/ldap/uptodatevector.c | 1 +
source4/torture/libnet/domain.c | 1 +
source4/torture/libnet/libnet_BecomeDC.c | 1 +
source4/torture/libnet/libnet_domain.c | 1 +
source4/torture/libnet/libnet_rpc.c | 1 +
source4/torture/libnetapi/wscript_build | 1 +
source4/torture/local/dbspeed.c | 17 ++--
source4/torture/local/torture.c | 1 +
source4/torture/locktest.c | 4 +-
source4/torture/masktest.c | 4 +-
source4/torture/nbt/dgram.c | 1 +
source4/torture/nbt/wins.c | 13 ++-
source4/torture/nbt/winsreplication.c | 2 -
source4/torture/ntp/ntp_signd.c | 1 +
source4/torture/rpc/drsuapi_cracknames.c | 3 +-
source4/torture/rpc/forest_trust.c | 3 +-
source4/torture/rpc/samsync.c | 14 +--
source4/torture/smb2/wscript_build | 1 +
source4/torture/smbtorture.c | 16 ++-
source4/torture/unix/unix_info2.c | 1 +
source4/torture/unix/whoami.c | 1 +
source4/torture/winbind/winbind.c | 2 +-
source4/torture/winbind/wscript_build | 1 +
source4/torture/wscript_build | 4 +
166 files changed, 562 insertions(+), 415 deletions(-)
Changeset truncated at 500 lines:
diff --git a/auth/credentials/tests/simple.c b/auth/credentials/tests/simple.c
index 6c72275..90633ec 100644
--- a/auth/credentials/tests/simple.c
+++ b/auth/credentials/tests/simple.c
@@ -20,6 +20,7 @@
#include "includes.h"
#include "auth/credentials/credentials.h"
#include "torture/torture.h"
+#include "torture/local/proto.h"
static bool test_init(struct torture_context *tctx)
{
diff --git a/auth/kerberos/wscript_build b/auth/kerberos/wscript_build
index 97b8879..15b4889 100755
--- a/auth/kerberos/wscript_build
+++ b/auth/kerberos/wscript_build
@@ -1,4 +1,5 @@
#!/usr/bin/env python
bld.SAMBA_SUBSYSTEM('KRB5_PAC',
source='gssapi_pac.c kerberos_pac.c',
+ allow_warnings=True,
deps='gssapi_krb5 ndr-krb5pac krb5samba')
diff --git a/buildtools/wafsamba/samba_autoconf.py b/buildtools/wafsamba/samba_autoconf.py
index e726536..316aeda 100644
--- a/buildtools/wafsamba/samba_autoconf.py
+++ b/buildtools/wafsamba/samba_autoconf.py
@@ -643,16 +643,32 @@ def SAMBA_CONFIG_H(conf, path=None):
return
if Options.options.debug:
- conf.ADD_CFLAGS('-g',
- testflags=True)
+ conf.ADD_CFLAGS('-g', testflags=True)
if Options.options.developer:
+ conf.env.DEVELOPER_MODE = True
+
+ conf.ADD_CFLAGS('-g', testflags=True)
+ conf.ADD_CFLAGS('-Wall', testflags=True)
+ conf.ADD_CFLAGS('-Wshadow', testflags=True)
+ conf.ADD_CFLAGS('-Wmissing-prototypes', testflags=True)
+ conf.ADD_CFLAGS('-Wcast-align -Wcast-qual', testflags=True)
+ conf.ADD_CFLAGS('-fno-common', testflags=True)
+
+ conf.ADD_CFLAGS('-Werror=address', testflags=True)
# we add these here to ensure that -Wstrict-prototypes is not set during configure
- conf.ADD_CFLAGS('-Wall -g -Wshadow -Werror=strict-prototypes -Wstrict-prototypes -Werror=pointer-arith -Wpointer-arith -Wcast-align -Werror=write-strings -Wwrite-strings -Werror-implicit-function-declaration -Wformat=2 -Wno-format-y2k -Wmissing-prototypes -fno-common -Werror=address -Wdeclaration-after-statement',
+ conf.ADD_CFLAGS('-Werror=strict-prototypes -Wstrict-prototypes',
+ testflags=True)
+ conf.ADD_CFLAGS('-Werror=write-strings -Wwrite-strings',
+ testflags=True)
+ conf.ADD_CFLAGS('-Werror-implicit-function-declaration',
+ testflags=True)
+ conf.ADD_CFLAGS('-Werror=pointer-arith -Wpointer-arith',
+ testflags=True)
+ conf.ADD_CFLAGS('-Werror=declaration-after-statement -Wdeclaration-after-statement',
testflags=True)
- conf.ADD_CFLAGS('-Wcast-qual', testflags=True)
- conf.env.DEVELOPER_MODE = True
+ conf.ADD_CFLAGS('-Wformat=2 -Wno-format-y2k', testflags=True)
# This check is because for ldb_search(), a NULL format string
# is not an error, but some compilers complain about that.
if CHECK_CFLAGS(conf, ["-Werror=format", "-Wformat=2"], '''
@@ -669,7 +685,7 @@ int main(void) {
conf.env['EXTRA_CFLAGS'].extend(TO_LIST("-Werror=format"))
if Options.options.picky_developer:
- conf.ADD_CFLAGS('-Werror', testflags=True)
+ conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Werror', testflags=True)
if Options.options.fatal_errors:
conf.ADD_CFLAGS('-Wfatal-errors', testflags=True)
@@ -694,7 +710,7 @@ def CONFIG_PATH(conf, name, default):
conf.env[name] = conf.env['PREFIX'] + default
@conf
-def ADD_CFLAGS(conf, flags, testflags=False):
+def ADD_NAMED_CFLAGS(conf, name, flags, testflags=False):
'''add some CFLAGS to the command line
optionally set testflags to ensure all the flags work
'''
@@ -704,9 +720,16 @@ def ADD_CFLAGS(conf, flags, testflags=False):
if CHECK_CFLAGS(conf, f):
ok_flags.append(f)
flags = ok_flags
- if not 'EXTRA_CFLAGS' in conf.env:
- conf.env['EXTRA_CFLAGS'] = []
- conf.env['EXTRA_CFLAGS'].extend(TO_LIST(flags))
+ if not name in conf.env:
+ conf.env[name] = []
+ conf.env[name].extend(TO_LIST(flags))
+
+ at conf
+def ADD_CFLAGS(conf, flags, testflags=False):
+ '''add some CFLAGS to the command line
+ optionally set testflags to ensure all the flags work
+ '''
+ ADD_NAMED_CFLAGS(conf, 'EXTRA_CFLAGS', flags, testflags=testflags)
@conf
def ADD_LDFLAGS(conf, flags, testflags=False):
@@ -736,14 +759,17 @@ def ADD_EXTRA_INCLUDES(conf, includes):
-def CURRENT_CFLAGS(bld, target, cflags, hide_symbols=False):
+def CURRENT_CFLAGS(bld, target, cflags, allow_warnings=True, hide_symbols=False):
'''work out the current flags. local flags are added first'''
+ ret = TO_LIST(cflags)
if not 'EXTRA_CFLAGS' in bld.env:
list = []
else:
list = bld.env['EXTRA_CFLAGS'];
- ret = TO_LIST(cflags)
ret.extend(list)
+ if not allow_warnings and 'PICKY_CFLAGS' in bld.env:
+ list = bld.env['PICKY_CFLAGS'];
+ ret.extend(list)
if hide_symbols and bld.env.HAVE_VISIBILITY_ATTR:
ret.append('-fvisibility=hidden')
return ret
diff --git a/buildtools/wafsamba/samba_bundled.py b/buildtools/wafsamba/samba_bundled.py
index afcf708..23a0f09 100644
--- a/buildtools/wafsamba/samba_bundled.py
+++ b/buildtools/wafsamba/samba_bundled.py
@@ -70,14 +70,23 @@ def minimum_library_version(conf, libname, default):
@conf
def LIB_MAY_BE_BUNDLED(conf, libname):
- return ('NONE' not in conf.env.BUNDLED_LIBS and
- '!%s' % libname not in conf.env.BUNDLED_LIBS)
-
+ if libname in conf.env.BUNDLED_LIBS:
+ return True
+ if '!%s' % libname in conf.env.BUNDLED_LIBS:
+ return False
+ if 'NONE' in conf.env.BUNDLED_LIBS:
+ return False
+ return True
@conf
def LIB_MUST_BE_BUNDLED(conf, libname):
- return ('ALL' in conf.env.BUNDLED_LIBS or
- libname in conf.env.BUNDLED_LIBS)
+ if libname in conf.env.BUNDLED_LIBS:
+ return True
+ if '!%s' % libname in conf.env.BUNDLED_LIBS:
+ return False
+ if 'ALL' in conf.env.BUNDLED_LIBS:
+ return True
+ return False
@conf
def LIB_MUST_BE_PRIVATE(conf, libname):
@@ -102,54 +111,18 @@ def CHECK_BUNDLED_SYSTEM_PKG(conf, libname, minversion='0.0.0',
This only tries using pkg-config
'''
- if conf.LIB_MUST_BE_BUNDLED(libname):
- return False
- found = 'FOUND_SYSTEMLIB_%s' % libname
- if found in conf.env:
- return conf.env[found]
-
- # see if the library should only use a system version if another dependent
- # system version is found. That prevents possible use of mixed library
- # versions
- if onlyif:
- missing = conf.CHECK_PREREQUISITES(onlyif)
- if missing:
- if not conf.LIB_MAY_BE_BUNDLED(libname):
- Logs.error('ERROR: Use of system library %s depends on missing system library/libraries %r' % (libname, missing))
- sys.exit(1)
- conf.env[found] = False
- return False
-
- minversion = minimum_library_version(conf, libname, minversion)
-
- msg = 'Checking for system %s' % libname
- if minversion != '0.0.0':
- msg += ' >= %s' % minversion
-
- if pkg is None:
- pkg = libname
-
- if conf.check_cfg(package=pkg,
- args='"%s >= %s" --cflags --libs' % (pkg, minversion),
- msg=msg, uselib_store=libname.upper()):
- conf.SET_TARGET_TYPE(libname, 'SYSLIB')
- conf.env[found] = True
- if implied_deps:
- conf.SET_SYSLIB_DEPS(libname, implied_deps)
- return True
- conf.env[found] = False
- if not conf.LIB_MAY_BE_BUNDLED(libname):
- Logs.error('ERROR: System library %s of version %s not found, and bundling disabled' % (libname, minversion))
- sys.exit(1)
- return False
-
+ return conf.CHECK_BUNDLED_SYSTEM(libname,
+ minversion=minversion,
+ onlyif=onlyif,
+ implied_deps=implied_deps,
+ pkg=pkg)
@runonce
@conf
def CHECK_BUNDLED_SYSTEM(conf, libname, minversion='0.0.0',
- checkfunctions=None, headers=None,
+ checkfunctions=None, headers=None, checkcode=None,
onlyif=None, implied_deps=None,
- require_headers=True):
+ require_headers=True, pkg=None):
'''check if a library is available as a system library.
this first tries via pkg-config, then if that fails
tries by testing for a specified function in the specified lib
@@ -160,14 +133,25 @@ def CHECK_BUNDLED_SYSTEM(conf, libname, minversion='0.0.0',
if found in conf.env:
return conf.env[found]
- def check_functions_headers():
+ def check_functions_headers_code():
'''helper function for CHECK_BUNDLED_SYSTEM'''
- if checkfunctions is None:
- return True
if require_headers and headers and not conf.CHECK_HEADERS(headers, lib=libname):
return False
- return conf.CHECK_FUNCS_IN(checkfunctions, libname, headers=headers,
- empty_decl=False, set_target=False)
+ if checkfunctions is not None:
+ ok = conf.CHECK_FUNCS_IN(checkfunctions, libname, headers=headers,
+ empty_decl=False, set_target=False)
+ if not ok:
+ return False
+ if checkcode is not None:
+ define='CHECK_BUNDLED_SYSTEM_%s' % libname.upper()
+ ok = conf.CHECK_CODE(checkcode, lib=libname,
+ headers=headers, local_include=False,
+ msg=msg, define=define)
+ conf.CONFIG_RESET(define)
+ if not ok:
+ return False
+ return True
+
# see if the library should only use a system version if another dependent
# system version is found. That prevents possible use of mixed library
@@ -187,18 +171,22 @@ def CHECK_BUNDLED_SYSTEM(conf, libname, minversion='0.0.0',
if minversion != '0.0.0':
msg += ' >= %s' % minversion
+ uselib_store=libname.upper()
+ if pkg is None:
+ pkg = libname
+
# try pkgconfig first
- if (conf.check_cfg(package=libname,
- args='"%s >= %s" --cflags --libs' % (libname, minversion),
- msg=msg) and
- check_functions_headers()):
+ if (conf.check_cfg(package=pkg,
+ args='"%s >= %s" --cflags --libs' % (pkg, minversion),
+ msg=msg, uselib_store=uselib_store) and
+ check_functions_headers_code()):
conf.SET_TARGET_TYPE(libname, 'SYSLIB')
conf.env[found] = True
if implied_deps:
conf.SET_SYSLIB_DEPS(libname, implied_deps)
return True
if checkfunctions is not None:
- if check_functions_headers():
+ if check_functions_headers_code():
conf.env[found] = True
if implied_deps:
conf.SET_SYSLIB_DEPS(libname, implied_deps)
diff --git a/buildtools/wafsamba/samba_deps.py b/buildtools/wafsamba/samba_deps.py
index 74a70cf..c00744e 100644
--- a/buildtools/wafsamba/samba_deps.py
+++ b/buildtools/wafsamba/samba_deps.py
@@ -224,7 +224,8 @@ def add_init_functions(self):
sname = sname.replace('/','_')
cflags.append('-DSTATIC_%s_MODULES=%s' % (sname, sentinel))
if sentinel == 'NULL':
- cflags.append('-DSTATIC_%s_MODULES_PROTO=' % sname)
+ proto = "extern void __%s_dummy_module_proto(void)" % (sname)
+ cflags.append('-DSTATIC_%s_MODULES_PROTO=%s' % (sname, proto))
self.ccflags = cflags
return
@@ -238,12 +239,14 @@ def add_init_functions(self):
if init_fn_list == []:
cflags.append('-DSTATIC_%s_MODULES=%s' % (m, sentinel))
if sentinel == 'NULL':
- cflags.append('-DSTATIC_%s_MODULES_PROTO' % m)
+ proto = "extern void __%s_dummy_module_proto(void)" % (m)
+ cflags.append('-DSTATIC_%s_MODULES_PROTO=%s' % (m, proto))
else:
cflags.append('-DSTATIC_%s_MODULES=%s' % (m, ','.join(init_fn_list) + ',' + sentinel))
proto=''
for f in init_fn_list:
- proto = proto + '_MODULE_PROTO(%s)' % f
+ proto += '_MODULE_PROTO(%s)' % f
+ proto += "extern void __%s_dummy_module_proto(void)" % (m)
cflags.append('-DSTATIC_%s_MODULES_PROTO=%s' % (m, proto))
self.ccflags = cflags
diff --git a/buildtools/wafsamba/samba_python.py b/buildtools/wafsamba/samba_python.py
index aee9547..1ec2f7b 100644
--- a/buildtools/wafsamba/samba_python.py
+++ b/buildtools/wafsamba/samba_python.py
@@ -63,6 +63,7 @@ def SAMBA_PYTHON(bld, name,
target_type='PYTHON',
install_path='${PYTHONARCHDIR}',
allow_undefined_symbols=True,
+ allow_warnings=True,
enabled=enabled)
Build.BuildContext.SAMBA_PYTHON = SAMBA_PYTHON
diff --git a/buildtools/wafsamba/wafsamba.py b/buildtools/wafsamba/wafsamba.py
index aeb9418..8ec4cb8 100644
--- a/buildtools/wafsamba/wafsamba.py
+++ b/buildtools/wafsamba/wafsamba.py
@@ -130,6 +130,7 @@ def SAMBA_LIBRARY(bld, libname, source,
private_library=False,
grouping_library=False,
allow_undefined_symbols=False,
+ allow_warnings=True,
enabled=True):
'''define a Samba library'''
@@ -176,6 +177,7 @@ def SAMBA_LIBRARY(bld, libname, source,
autoproto_extra_source=autoproto_extra_source,
depends_on = depends_on,
hide_symbols = hide_symbols,
+ allow_warnings = allow_warnings,
pyembed = pyembed,
pyext = pyext,
local_include = local_include,
@@ -415,7 +417,8 @@ def SAMBA_MODULE(bld, modname, source,
enabled=True,
pyembed=False,
manpages=None,
- allow_undefined_symbols=False
+ allow_undefined_symbols=False,
+ allow_warnings=True
):
'''define a Samba module.'''
@@ -435,6 +438,7 @@ def SAMBA_MODULE(bld, modname, source,
cflags=cflags,
local_include=local_include,
global_include=global_include,
+ allow_warnings=allow_warnings,
enabled=enabled)
bld.ADD_INIT_FUNCTION(subsystem, modname, init_function)
@@ -481,7 +485,8 @@ def SAMBA_MODULE(bld, modname, source,
install_path="${MODULESDIR}/%s" % subsystem,
pyembed=pyembed,
manpages=manpages,
- allow_undefined_symbols=allow_undefined_symbols
+ allow_undefined_symbols=allow_undefined_symbols,
+ allow_warnings=allow_warnings
)
@@ -513,6 +518,7 @@ def SAMBA_SUBSYSTEM(bld, modname, source,
vars=None,
subdir=None,
hide_symbols=False,
+ allow_warnings=True,
pyext=False,
pyembed=False):
'''define a Samba subsystem'''
@@ -548,7 +554,9 @@ def SAMBA_SUBSYSTEM(bld, modname, source,
features = features,
source = source,
target = modname,
- samba_cflags = CURRENT_CFLAGS(bld, modname, cflags, hide_symbols=hide_symbols),
+ samba_cflags = CURRENT_CFLAGS(bld, modname, cflags,
+ allow_warnings=allow_warnings,
+ hide_symbols=hide_symbols),
depends_on = depends_on,
samba_deps = TO_LIST(deps),
samba_includes = includes,
diff --git a/examples/libsmbclient/testacl2.c b/examples/libsmbclient/testacl2.c
index ef044f8..a74a72d 100644
--- a/examples/libsmbclient/testacl2.c
+++ b/examples/libsmbclient/testacl2.c
@@ -25,6 +25,7 @@ int main(int argc, const char *argv[])
int ret;
const char *debugstr;
char value[1024];
+ SMBCCTX *context;
if (smbc_init(get_auth_data_fn, debug) != 0)
{
@@ -32,7 +33,7 @@ int main(int argc, const char *argv[])
return 1;
}
- SMBCCTX *context = smbc_set_context(NULL);
+ context = smbc_set_context(NULL);
smbc_setOptionFullTimeNames(context, 1);
the_acl = strdup("system.nt_sec_desc.*");
diff --git a/examples/libsmbclient/testbrowse.c b/examples/libsmbclient/testbrowse.c
index 2ae7ca1..0629653 100644
--- a/examples/libsmbclient/testbrowse.c
+++ b/examples/libsmbclient/testbrowse.c
@@ -25,8 +25,7 @@ get_auth_data_with_context_fn(SMBCCTX * context,
char * pPassword,
int maxLenPassword);
-int
-main(int argc, char * argv[])
+int main(int argc, const char *argv[])
{
int debug = 0;
int debug_stderr = 0;
@@ -73,7 +72,7 @@ main(int argc, char * argv[])
setbuf(stdout, NULL);
- pc = poptGetContext("opendir", argc, (const char **)argv, long_options, 0);
+ pc = poptGetContext("opendir", argc, argv, long_options, 0);
poptSetOtherOptionHelp(pc, "");
@@ -100,7 +99,7 @@ main(int argc, char * argv[])
if (context_auth) {
smbc_setFunctionAuthDataWithContext(context,
get_auth_data_with_context_fn);
- smbc_setOptionUserData(context, (void *)"hello world");
+ smbc_setOptionUserData(context, strdup("hello world"));
} else {
smbc_setFunctionAuthData(context, get_auth_data_fn);
}
@@ -126,20 +125,22 @@ main(int argc, char * argv[])
if (scan)
{
- for (;
- iterations == -1 || iterations > 0;
- iterations = (iterations == -1 ? iterations : --iterations))
- {
+ for (; iterations != 0;) {
+ if (iterations > 0) {
+ iterations--;
+ }
+
snprintf(buf, sizeof(buf), "smb://");
browse(buf, scan, 0);
}
}
else
{
- for (;
- iterations == -1 || iterations > 0;
- iterations = (iterations == -1 ? iterations : --iterations))
- {
+ for (; iterations != 0;) {
+ if (iterations > 0) {
+ iterations--;
+ }
+
fputs("url: ", stdout);
p = fgets(buf, sizeof(buf), stdin);
if (! p)
diff --git a/examples/libsmbclient/testctx.c b/examples/libsmbclient/testctx.c
index cec9776..7f27fbd 100644
--- a/examples/libsmbclient/testctx.c
+++ b/examples/libsmbclient/testctx.c
@@ -1,15 +1,16 @@
#include <libsmbclient.h>
#include <stdlib.h>
#include <stdio.h>
+#include <string.h>
-void create_and_destroy_context (void)
+static void create_and_destroy_context (void)
{
int i;
SMBCCTX *ctx;
ctx = smbc_new_context ();
/* Both should do the same thing */
smbc_setOptionDebugToStderr(ctx, 1);
- smbc_option_set(ctx, "debug_to_stderr", 1);
+ smbc_option_set(ctx, strdup("debug_to_stderr"), 1);
smbc_setDebug(ctx, 1);
i = smbc_getDebug(ctx);
if (i != 1) {
diff --git a/lib/ccan/wscript b/lib/ccan/wscript
index 81039d0..1c5f337 100644
--- a/lib/ccan/wscript
+++ b/lib/ccan/wscript
@@ -145,6 +145,7 @@ def configure(conf):
def ccan_module(bld, name, deps=''):
bld.SAMBA_SUBSYSTEM('ccan-%s' % name,
--
Samba Shared Repository
More information about the samba-cvs
mailing list