[SCM] Samba Shared Repository - branch master updated

Volker Lendecke vlendec at samba.org
Mon Sep 9 17:03:02 CEST 2013


The branch, master has been updated
       via  b8100af gencache: Avoid a duplicate call to string_term_tdb_data
      from  8f4069c tevent: Use talloc_pooled_object for tevent_req_create

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit b8100af38441d40d5834af3734432eb5ca4da73b
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Sep 8 13:29:33 2013 +0200

    gencache: Avoid a duplicate call to string_term_tdb_data
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Volker Lendecke <vl at samba.org>
    Autobuild-Date(master): Mon Sep  9 17:02:28 CEST 2013 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/lib/gencache.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/lib/gencache.c b/source3/lib/gencache.c
index 2c5e9ab..835f5e1 100644
--- a/source3/lib/gencache.c
+++ b/source3/lib/gencache.c
@@ -443,21 +443,19 @@ bool gencache_parse(const char *keystr,
 		    void *private_data)
 {
 	struct gencache_parse_state state;
-	TDB_DATA key;
+	TDB_DATA key = string_term_tdb_data(keystr);
 	int ret;
 
 	if (keystr == NULL) {
 		return false;
 	}
-	if (tdb_data_cmp(string_term_tdb_data(keystr),
-			 last_stabilize_key()) == 0) {
+	if (tdb_data_cmp(key, last_stabilize_key()) == 0) {
 		return false;
 	}
 	if (!gencache_init()) {
 		return false;
 	}
 
-	key = string_term_tdb_data(keystr);
 	state.parser = parser;
 	state.private_data = private_data;
 


-- 
Samba Shared Repository


More information about the samba-cvs mailing list