[SCM] Samba Shared Repository - branch master updated
Volker Lendecke
vlendec at samba.org
Wed Nov 20 04:20:04 MST 2013
The branch, master has been updated
via 3f77bf2 testparm: Warnings should not cause failure
from c776204 debug: remove unused sys_adminlog
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 3f77bf2ce318b51547c36f315b34a062ba7afccf
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Nov 5 06:31:29 2013 +1100
testparm: Warnings should not cause failure
Remove the return code of 1 associated with some warnings. Warnings
should not cause failure. If any of these cases should cause a
failure then they should be changed to errors.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Wed Nov 20 12:19:59 CET 2013 on sn-devel-104
-----------------------------------------------------------------------
Summary of changes:
source3/utils/testparm.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/utils/testparm.c b/source3/utils/testparm.c
index 1c13b52..ce85353 100644
--- a/source3/utils/testparm.c
+++ b/source3/utils/testparm.c
@@ -86,7 +86,6 @@ static int do_global_checks(void)
if (strequal(lp_workgroup(), lp_netbios_name())) {
fprintf(stderr, "WARNING: 'workgroup' and 'netbios name' "
"must differ.\n\n");
- ret = 1;
}
if (!directory_exist_stat(lp_lockdir(), &st)) {
@@ -97,7 +96,6 @@ static int do_global_checks(void)
fprintf(stderr, "WARNING: lock directory %s should have "
"permissions 0755 for browsing to work\n\n",
lp_lockdir());
- ret = 1;
}
if (!directory_exist_stat(lp_statedir(), &st)) {
@@ -108,7 +106,6 @@ static int do_global_checks(void)
fprintf(stderr, "WARNING: state directory %s should have "
"permissions 0755 for browsing to work\n\n",
lp_statedir());
- ret = 1;
}
if (!directory_exist_stat(lp_cachedir(), &st)) {
@@ -119,7 +116,6 @@ static int do_global_checks(void)
fprintf(stderr, "WARNING: cache directory %s should have "
"permissions 0755 for browsing to work\n\n",
lp_cachedir());
- ret = 1;
}
if (!directory_exist_stat(lp_piddir(), &st)) {
--
Samba Shared Repository
More information about the samba-cvs
mailing list