[SCM] Samba Shared Repository - branch v4-0-test updated

Karolin Seeger kseeger at samba.org
Wed May 8 03:54:07 MDT 2013


The branch, v4-0-test has been updated
       via  23a75ad winbind: Fix bug 9854 -- NULL pointer dereference
      from  ed22de6 check_parent_exists() can change errno. Ensure we preserve it across calls.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v4-0-test


- Log -----------------------------------------------------------------
commit 23a75adf1f6eabed7c6f7cb4f523e049245eab10
Author: Volker Lendecke <vl at samba.org>
Date:   Tue May 7 12:39:16 2013 +0200

    winbind: Fix bug 9854 -- NULL pointer dereference
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Michael Adam <obnox at samba.org>
    
    Autobuild-User(master): Michael Adam <obnox at samba.org>
    Autobuild-Date(master): Tue May  7 14:49:07 CEST 2013 on sn-devel-104
    (cherry picked from commit 8c1283a89f746a108e8014b6fbc9a58a371950cf)
    
    Autobuild-User(v4-0-test): Karolin Seeger <kseeger at samba.org>
    Autobuild-Date(v4-0-test): Wed May  8 11:53:49 CEST 2013 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/winbindd/winbindd_cache.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/winbindd/winbindd_cache.c b/source3/winbindd/winbindd_cache.c
index 8b2e6a9..f631aea 100644
--- a/source3/winbindd/winbindd_cache.c
+++ b/source3/winbindd/winbindd_cache.c
@@ -944,7 +944,7 @@ static void wcache_save_name_to_sid(struct winbindd_domain *domain,
 	if (!centry)
 		return;
 
-	if (domain_name[0] == '\0') {
+	if ((domain_name == NULL) || (domain_name[0] == '\0')) {
 		struct winbindd_domain *mydomain =
 			find_domain_from_sid_noinit(sid);
 		if (mydomain != NULL) {
@@ -972,7 +972,7 @@ static void wcache_save_sid_to_name(struct winbindd_domain *domain, NTSTATUS sta
 	if (!centry)
 		return;
 
-	if (domain_name[0] == '\0') {
+	if ((domain_name == NULL) || (domain_name[0] == '\0')) {
 		struct winbindd_domain *mydomain =
 			find_domain_from_sid_noinit(sid);
 		if (mydomain != NULL) {
@@ -1806,7 +1806,7 @@ NTSTATUS wcache_name_to_sid(struct winbindd_domain *domain,
 		return NT_STATUS_NO_MEMORY;
 	}
 
-	if (domain_name[0] == '\0') {
+	if ((domain_name == NULL) || (domain_name[0] == '\0')) {
 		domain_name = domain->name;
 	}
 


-- 
Samba Shared Repository


More information about the samba-cvs mailing list