[SCM] Samba Shared Repository - branch v3-6-test updated

Karolin Seeger kseeger at samba.org
Fri Mar 1 08:36:41 MST 2013


The branch, v3-6-test has been updated
       via  eb657c3 winbind: Don't leak centry memory. Reviewed-by: Alexander Bokovoy <ab at samba.org>
       via  30d7a3a winbind: Don't leak memory on return. Reviewed-by: Alexander Bokovoy <ab at samba.org>
      from  180ef28 Fix bug #9039 'map untrusted to domain' treats WORKSTATION as bogus domain.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test


- Log -----------------------------------------------------------------
commit eb657c324f83e94d46f80b9c1b97fa0228c3a47a
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Feb 20 09:51:43 2013 +0100

    winbind: Don't leak centry memory. Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    The last two patches address bug #9684 - Fix two resource leaks in winbindd.

commit 30d7a3ad920456fee2a589b501ba835d13de6c29
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Feb 20 09:41:55 2013 +0100

    winbind: Don't leak memory on return. Reviewed-by: Alexander Bokovoy <ab at samba.org>

-----------------------------------------------------------------------

Summary of changes:
 source3/winbindd/winbindd_cache.c |    1 +
 source3/winbindd/winbindd_cm.c    |    3 +++
 2 files changed, 4 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/winbindd/winbindd_cache.c b/source3/winbindd/winbindd_cache.c
index ea503e1..81b9b17 100644
--- a/source3/winbindd/winbindd_cache.c
+++ b/source3/winbindd/winbindd_cache.c
@@ -2130,6 +2130,7 @@ static NTSTATUS rids_to_names(struct winbindd_domain *domain,
 				} else {
 					/* something's definitely wrong */
 					result = centry->status;
+					centry_free(centry);
 					goto error;
 				}
 
diff --git a/source3/winbindd/winbindd_cm.c b/source3/winbindd/winbindd_cm.c
index 28583fd..9cb3717 100644
--- a/source3/winbindd/winbindd_cm.c
+++ b/source3/winbindd/winbindd_cm.c
@@ -1023,6 +1023,9 @@ static NTSTATUS cm_prepare_connection(const struct winbindd_domain *domain,
 	if ( !(*cli)->domain[0] ) {
 		result = cli_set_domain((*cli), domain->name);
 		if (!NT_STATUS_IS_OK(result)) {
+			SAFE_FREE(ipc_username);
+			SAFE_FREE(ipc_domain);
+			SAFE_FREE(ipc_password);
 			return result;
 		}
 	}


-- 
Samba Shared Repository


More information about the samba-cvs mailing list