[SCM] Samba Shared Repository - branch master updated
Michael Adam
obnox at samba.org
Wed Jun 26 18:03:02 MDT 2013
The branch, master has been updated
via 59462f2 winbindd and nmbd don't set their umask to zero on startup like smbd does.
from 011dc52 sharesec: Document --view-all
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 59462f2e0102481bb9ac8f86e883a6de99259449
Author: Jeremy Allison <jra at samba.org>
Date: Mon Jun 17 17:25:41 2013 -0700
winbindd and nmbd don't set their umask to zero on startup like smbd does.
Fix this - we already control tightly what permissions are
on the files we create. Ensure we don't get surprised.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Thu Jun 27 02:02:24 CEST 2013 on sn-devel-104
-----------------------------------------------------------------------
Summary of changes:
source3/nmbd/nmbd.c | 6 ++++++
source3/winbindd/winbindd.c | 6 ++++++
2 files changed, 12 insertions(+), 0 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/nmbd/nmbd.c b/source3/nmbd/nmbd.c
index 42e2b2f..ec0e7d0 100644
--- a/source3/nmbd/nmbd.c
+++ b/source3/nmbd/nmbd.c
@@ -808,6 +808,12 @@ static bool open_sockets(bool isdaemon, int port)
talloc_enable_null_tracking();
frame = talloc_stackframe();
+ /*
+ * We want total control over the permissions on created files,
+ * so set our umask to 0.
+ */
+ umask(0);
+
setup_logging(argv[0], DEBUG_DEFAULT_STDOUT);
load_case_tables();
diff --git a/source3/winbindd/winbindd.c b/source3/winbindd/winbindd.c
index 141ca5c..953e208 100644
--- a/source3/winbindd/winbindd.c
+++ b/source3/winbindd/winbindd.c
@@ -1336,6 +1336,12 @@ int main(int argc, char **argv, char **envp)
talloc_enable_null_tracking();
frame = talloc_stackframe();
+ /*
+ * We want total control over the permissions on created files,
+ * so set our umask to 0.
+ */
+ umask(0);
+
setup_logging("winbindd", DEBUG_DEFAULT_STDOUT);
/* glibc (?) likes to print "User defined signal 1" and exit if a
--
Samba Shared Repository
More information about the samba-cvs
mailing list