[SCM] Samba Shared Repository - branch v4-1-stable created
Stefan Metzmacher
metze at samba.org
Thu Jun 13 02:41:21 MDT 2013
The branch, v4-1-stable has been created
at 5c488cfb79873287e769622fd5da43b7a735e29c (commit)
- Log -----------------------------------------------------------------
commit 5c488cfb79873287e769622fd5da43b7a735e29c
Author: Christof Schmitt <christof.schmitt at us.ibm.com>
Date: Wed Jun 12 14:49:53 2013 -0700
Initialize the file descriptor in the files_struct before trying to close it. Otherwise, if one of the SETXATTR calls had failed, the close() call will return EBADF.
Signed-off-by: Christof Schmitt <christof.schmitt at us.ibm.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Richard Sharpe <rsharpe at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Jun 13 01:43:18 CEST 2013 on sn-devel-104
commit d6ce1402a964858bf40b23f34df01f1f01839d3a
Author: Andreas Schneider <asn at samba.org>
Date: Wed Jun 12 13:55:13 2013 +0200
tevent: Link the tutorial on the mainpage.
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Wed Jun 12 19:54:30 CEST 2013 on sn-devel-104
commit 1bce2510ca9a2eec20f2a32499f0839b768f7c4a
Author: David Koňař <konar.david at gmail.com>
Date: Wed Jun 12 13:54:36 2013 +0200
tevent: Add tevent tutorial files.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 7bad9d1fcd7ad78d060d95953ee6aaff5339bba6
Author: Andreas Schneider <asn at samba.org>
Date: Wed Jun 12 10:07:22 2013 +0200
s3-libads: Print the debug string of a failed call with LDAP_OTHER.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Wed Jun 12 13:46:57 CEST 2013 on sn-devel-104
commit ee156ef23511713a29095f4ab5d7750a36ba850c
Author: Andreas Schneider <asn at samba.org>
Date: Wed Jun 12 10:08:44 2013 +0200
krb5wrap: Move mask to the right position.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 68f8f4ec4dbbdb20c4c51a6059535b5ef669373f
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri May 31 14:14:54 2013 +1000
dsdb-tests ldap.py: Add test for usn behaviour on certain changes
This probes when the usn is updated, and when it is not.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Wed Jun 12 11:54:01 CEST 2013 on sn-devel-104
commit 51298d33dd28e034967db38312e0129935a27a66
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri May 31 11:15:51 2013 +1000
dsdb-tests ldap.py: Fix quoting of print statements
While python didn't mind (oddly) it really confused my editor.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 96980f7c04cc4226ed109654025b8254921f8d58
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri May 31 14:16:02 2013 +1000
dsdb: Fix behaviour for when to update the USN when there is no change
This handles deletions and replacements with no value, or with an
exactly specified value, as well as modifies.
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit e461ff530046199b7e647b81d6dfb2746f68b0d7
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jun 10 12:22:40 2013 +1000
dsdb: Allow dsdb_find_dn_by_guid to show deleted DNs
This helps us in the KCC as we need to return the deleted DN for the GUID
in DsReplicaGetInfo calls (tested for deleted servers against Windows 2008R2).
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit eec29db7c237c70732f94e33147c960fa8df39fb
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jun 10 11:43:18 2013 +1000
python samba-tool drs: Correctly print KCC references to deleted servers
Tested against Windows 2008R2, presumably before the KCC ran.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 3e66cb7d771e9f2156f4183485736cca7d5609f9
Author: Partha Sarathi <parthasarathi.bl at gmail.com>
Date: Fri Jun 7 16:30:07 2013 -0700
Fix bug #9932 - Currently the maximum number of aces in an SD is limited to 1000, but Microsoft supports around 1800.
Issue description: I was trying to add maximum number of aces on Microsoft
share, where I was able to add nearly 1800 aces on a file/folder SD. But Samba
does not support adding 1800 aces to SD instead it limited to 1000.
Expected behavior: Ideally SAMBA should also support as like Windows to compare
with Windows standard. Set to 2000 until we add EA limits in the server.
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Wed Jun 12 02:52:36 CEST 2013 on sn-devel-104
commit e2a08e54dd008fceb5d8aabcf02ab4e389286f03
Author: Volker Lendecke <vl at samba.org>
Date: Tue Jun 11 21:07:26 2013 +0200
smbd: Remove an unused variable
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Jun 12 01:00:44 CEST 2013 on sn-devel-104
commit ecff2b25340daf38c326c2b9431568fee53ff78e
Author: Volker Lendecke <vl at samba.org>
Date: Tue Jun 11 20:53:05 2013 +0200
librpc: Fix some "ignored asprint result" warnings
While there, it removes some alloc/free calls
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 1b740e5033d4adf4e3412bc2be7d9d4ff77ae271
Author: Volker Lendecke <vl at samba.org>
Date: Tue Jun 11 20:37:11 2013 +0200
smbd: Fix a const warning
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit fc5e584536ad0c695b414698351e171dfae85fc6
Author: Volker Lendecke <vl at samba.org>
Date: Tue Jun 11 20:35:55 2013 +0200
smbd: Fix a const warning
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 606622c10186d6197860c9b20385d9d84840da58
Author: Volker Lendecke <vl at samba.org>
Date: Tue Jun 11 20:34:00 2013 +0200
smbd: Remove unused code
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 4cd0e38fe0fa3432326fafd4baa845ec2483bb70
Author: Volker Lendecke <vl at samba.org>
Date: Tue Jun 11 19:41:30 2013 +0200
lib: Remove an unused variable
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Jun 11 21:52:09 CEST 2013 on sn-devel-104
commit 61f59d84ae41fd2101cce91287ec54efd207cf28
Author: Volker Lendecke <vl at samba.org>
Date: Tue Jun 11 19:27:17 2013 +0200
winreg3: Fix a const warning
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 9c95110b67ee5f9b40340861b5bb91e770398c3e
Author: David Disseldorp <ddiss at samba.org>
Date: Tue Jun 11 14:20:53 2013 +0200
libsmb: add ABI/smbclient-0.2.1.sigs
Required following ABI vnum bump for smbc_get/setPort changes.
Signed-off-by: David Disseldorp <ddiss at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 2252d781234b963f24a7827a1228f85ba9f6d7da
Author: Jeremy Allison <jra at samba.org>
Date: Tue Apr 16 14:53:09 2013 -0700
Add smbc_getPort(), smbc_setPort(). Bump the .so minor number.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 47471c82d0d5a024a0c64eab68adae1d482bd972
Author: Jeremy Allison <jra at samba.org>
Date: Tue Apr 16 14:13:57 2013 -0700
Plumb the 'port' parameter into the connect code.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit ccb5c2d6930eeb7672af33833adb195d0c525547
Author: Jeremy Allison <jra at samba.org>
Date: Tue Apr 16 14:11:08 2013 -0700
Add the port argument to SMBC_server().
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit da6c84aff0b4b01ae1bf3d31cbc4e8e176168a9a
Author: Jeremy Allison <jra at samba.org>
Date: Tue Apr 16 12:22:11 2013 -0700
Add port argument to SMBC_attr_server(). Does nothing as yet.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 534cf516ed17d90bbd851fd8e190811a055aa5f0
Author: Jeremy Allison <jra at samba.org>
Date: Tue Apr 16 12:09:41 2013 -0700
Add the ability to parse out the port to SMBC_parse_path().
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit c0cbf5936f0385ab93315cc366a0aa16c0ebd237
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jun 3 10:38:29 2013 +1000
Remove remaining references to "password level" in the tree
Reviewed-by: Simo Sorce <idra at samba.org>
Autobuild-User(master): Simo Sorce <idra at samba.org>
Autobuild-Date(master): Tue Jun 11 16:25:54 CEST 2013 on sn-devel-104
commit 3f73002f2d5f8a27820e09b024f561fda1560184
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jun 3 10:27:41 2013 +1000
docs: Do not encourage unix passwords, and remove reference to password level
Reviewed-by: Simo Sorce <idra at samba.org>
commit 26279a969879bfbd943dfda03c511ed7e14057ba
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jun 3 10:02:39 2013 +1000
auth: Remove "password level"
We now only lowercase the password, we do not attempt to find another case
combination that the password might be in.
This option is already depricated, so it is now time to remove it.
Andrew Bartlett
Reviewed-by: Simo Sorce <idra at samba.org>
commit 3fba9ba7ea85e33faac2718d2463c5d0cd2d85f4
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Jun 10 10:46:41 2013 +0200
dsdb: reset schema->{classes,attributes}_to_remove_size to 0
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Jun 11 11:40:39 CEST 2013 on sn-devel-104
commit d2f847149d3d1310c829169564704b45ac43e978
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Jun 10 10:45:25 2013 +0200
dsdb: use the correct talloc parent in dsdb_repl_merge_working_schema()
schema->{classes,attributes} are the DLIST pointer not an array.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 5263f0a626dac3ac1fc48ece2324438279f187f0
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Jun 5 20:44:17 2013 +1000
Revert "s4-dsdb: Remove strcasecmp() fallback in replmd_ldb_message_element_attid_sort"
This reverts commit d799b25dd3ed0f72ee03949225ba241c5538d7d6.
Sometimes the schema just isn't right. A segfault is not the correct
answer in those cases.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 424a990e34278fae4888b00affb530ed1fbcb354
Author: Björn Baumbach <bb at sernet.de>
Date: Wed Jun 5 15:01:14 2013 +0200
s4-dfs_server: check for netbios aliases in ad_get_referrals
Without this patch ad_get_referrals checks for netbios, dns names
and ip, but not for netbios aliases set by netbios aliases option,
whether the requested name is our dns name.
Pair-programmed-with: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Björn Baumbach <bb at sernet.de>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Jun 11 01:12:08 CEST 2013 on sn-devel-104
commit 2a65e8befef004fd18d17853a1b72155752346c8
Author: Jeremy Allison <jra at samba.org>
Date: Fri May 24 10:33:38 2013 -0700
Optimization on POSIX platforms that have fstatat.
Tests show significant speedup in directory listings
by using fstatat instead of a full pathname walk.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Mon Jun 10 20:14:12 CEST 2013 on sn-devel-104
commit da2cf8a947b5beda3e32cb5d9c5b0899a3bf5f61
Author: Jeremy Allison <jra at samba.org>
Date: Fri Jun 7 17:53:45 2013 -0700
Check for fstatat.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 7f760ed84b4b34937b3a65577f971cc95f452e0f
Author: Matthias Dieter Wallnöfer <mdw at samba.org>
Date: Sat Jun 8 23:45:43 2013 +0200
s4:samldb LDB module - MS-SAMR 3.1.1.8.10 "userAccountControl"
"UF_LOCKOUT" and "UF_PASSWORD_EXPIRED" are never stored but rather are
used for special semantics.
"UF_LOCKOUT" performs an account lockout and "UF_PASSWORD_EXPIRED"
forces password expiration.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon Jun 10 07:32:35 CEST 2013 on sn-devel-104
commit 2f7d9fddf7102d76b182fbd50ccaf18cb5a10014
Author: Matthias Dieter Wallnöfer <mdw at samba.org>
Date: Sun Jun 9 10:46:06 2013 +0200
s4:samr RPC server - dcesrv_samr_SetUserInfo() - password expiration
Also on level 26 this has to be handled the same as on levels 21, 23, 25.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 036af07e863b09c6e84965ef288324cbac93de69
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Jun 8 18:10:36 2013 +1000
.gitignore: Tidy up after removal of the autoconf build
Reviewed-By: Jelmer Vernooij <jelmer at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon Jun 10 04:42:46 CEST 2013 on sn-devel-104
commit 3cd640dc5dee24b244f13c17b80675000d39c8ce
Author: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
Date: Thu Jul 12 11:18:46 2012 +0200
tdb: Fix typos.
Reviewed-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Fri Jun 7 15:18:47 CEST 2013 on sn-devel-104
commit d273bdf18c7693792d395f3ad89a128941d15cf0
Author: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
Date: Thu Jul 12 11:08:04 2012 +0200
Add "repack" command to tdbtool documentation.
The original commit 'Add "repack" command to tdbtool.' only added
the documentation to docs-xml/manpages-3/tdbtool.8.xml and forgot
about lib/tdb/manpages/tdbtool.8.xml .
Reviewed-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 56055f788cd9cec0256e79d0db0b53885d7a18b0
Author: Volker Lendecke <vl at samba.org>
Date: Tue Jun 4 12:29:32 2013 +0200
Revert "dbwrap: dbwrap_fetch_locked_timeout()."
This reverts commit f6eb187fdab6b8088bb065e418fe604c4eba7751.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Rusty Russell <rusty at rustcorp.com.au>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Thu Jun 6 14:26:26 CEST 2013 on sn-devel-104
commit a8b0fba9fb6da247c355b3d4303604ae6a675a9c
Author: Volker Lendecke <vl at samba.org>
Date: Tue Jun 4 11:39:06 2013 +0200
docs: Fix a typo
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Karolin Seeger <kseeger at samba.org>
Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
Autobuild-Date(master): Thu Jun 6 11:47:22 CEST 2013 on sn-devel-104
commit 7d8354c719fa620a580f6d7d322ca80185c50c7e
Author: Christof Schmitt <christof.schmitt at us.ibm.com>
Date: Wed Jun 5 17:08:03 2013 -0700
smbd: Change logging when SET_OFFLINE is not supported
A client can send a request to set the OFFLINE attribute. In the default
code this is not supported and triggers a log message each time. Change
this to only log with level 0 when an actual errors occurs, and log
ENOTSUP with level 10.
Signed-off-by: Christof Schmitt <christof.schmitt at us.ibm.com>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu Jun 6 04:30:26 CEST 2013 on sn-devel-104
commit 1a6eac2c37f4d80033e450731bd36a9af4b2bd1d
Author: Matthias Dieter Wallnöfer <mdw at samba.org>
Date: Wed May 29 22:17:35 2013 +0200
s4:samldb LDB module - permit "userAccountControl" modifications without acct. type
Obviously this defaults to UF_NORMAL_ACCOUNT. Some background can be found in
MS-SAMR section 3.1.1.8.10.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Wed Jun 5 03:26:25 CEST 2013 on sn-devel-104
commit 62ee2a5caf8b8e7750a650c7ebc9729beda48a89
Author: Matthias Dieter Wallnöfer <mdw at samba.org>
Date: Sat Apr 21 17:20:24 2012 +0200
s4:samldb LDB module - "userAccountControl" = 0 means UF_NORMAL_ACCOUNT on add
Windows Server 2008 has changed semantics in comparison to Server 2003.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ad383ac8887eb5d44c2f2396e25a167c66b02ae6
Author: Michael Adam <obnox at samba.org>
Date: Wed May 22 20:16:50 2013 +0200
s3:smbd: explain parameters in call to SMB_VFS_DURABLE_RECONNECT()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Jun 4 21:58:16 CEST 2013 on sn-devel-104
commit 63ac88d40206e3080494e3a4f99858ce5cd6f393
Author: Michael Adam <obnox at samba.org>
Date: Wed May 22 19:53:12 2013 +0200
s3:smbd: remove code duplication in smb2_create_send()
Move the calls to smb2srv_open_recreate() from the parsing of
the create blobs (DHNC and DH2C) to a central place in the
open execution phase.
This is also where it should be called: in the durable reconnect
part, right before the call to SMB_VFS_DURABLE_RECONNECT()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e6beae4471491c5bfcabeb720c5e92183e78e886
Author: Michael Adam <obnox at samba.org>
Date: Wed May 22 20:26:49 2013 +0200
s3:smbd: remove old comment about scavenger timer from vfs_default_durable_reconnect()
scavenger functionality belongs to the smb layer (and is meanwhile
implemented there).
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d1feccb35e987545f4ae8e3f4eb0b4fc741e7e7e
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Jun 4 10:48:20 2013 +0200
tdb: change version to tdb-1.2.12
* internal code cleanups
* crash fix for pytdb
* fix for 4GB overflow detection
See http://permalink.gmane.org/gmane.network.samba.internals/42906 for
an example of what happens.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Jun 4 16:07:55 CEST 2013 on sn-devel-104
commit 55add52f42f389f396ab9a08f08ada203fffee14
Author: Peng Haitao <penght at cn.fujitsu.com>
Date: Mon May 27 17:59:54 2013 +0800
smbcquotas.c: fix a bug of -t
'r' should be replaced with 't'.
Signed-off-by: Peng Haitao <penght at cn.fujitsu.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Tue Jun 4 13:06:52 CEST 2013 on sn-devel-104
commit 097a8c723925d3e35606215cb16be28a37b0112e
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri May 31 16:04:26 2013 +0200
s4:winbind: don't leak libnet_context into the main event context
This needs to be a talloc child of struct wbsrv_domain
otherwise the cleanup of a broken connection doesn't work.
The following command can trigger the leak on a domain controller.
root at dc:~/samba# ls -l /var/lib/samba/sysvol/samba.private/
total 16
drwxrwx---+ 5 root 3000000 4096 May 14 14:46 Policies
drwxrwx---+ 2 root 3000000 4096 May 14 11:45 scripts
gid 3000000 belongs to Builtin\Administrators.
The code triggers a ncacn_np: connection to the local smbd
and complains that domain BUILTIN is not available:
[2013/05/29 17:28:03, 2] ../source4/winbind/wb_init_domain.c:376(init_domain_recv_queryinfo)
Expected domain name BUILTIN, DC dc.samba.private said SAMBA
In that case the connection was not closed, which is fixed by this commit.
Using ncalrpc: for all local SIDs and serving the BUILTIN domain is
a project for another day...
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue Jun 4 11:05:09 CEST 2013 on sn-devel-104
commit b2380081e23c68d515bd0c257d56ba4a593f991b
Author: Christian Ambach <ambi at samba.org>
Date: Mon Jun 3 16:18:03 2013 +0200
s3:lib/ctdb_packet use sys_send in packet_fd_write
use the signal safe variant here to prevent spurious errors when running
with CTDB and a signal comes in
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Christian Ambach <ambi at samba.org>
Autobuild-Date(master): Mon Jun 3 20:01:22 CEST 2013 on sn-devel-104
commit 8a6743e4edcdff1c7860d150720483f19f3b33bb
Author: David Disseldorp <ddiss at samba.org>
Date: Mon Jun 3 13:00:31 2013 +0200
Bug 8997: change libreplace GPL source to LGPL
libreplace currently includes socket.c and getifaddrs.c both of which
are GPL licensed.
Although not required, talloc and tdb build alongside this source,
leading to some ambiguity regarding their LGPL licences.
The following copyright holders have agreed to the GPL->LGPL change:
lib/replace/getifaddrs.c
Copyright (C) Andrew Tridgell 1998
Copyright (C) Jeremy Allison 2007
Copyright (C) Jelmer Vernooij <jelmer at samba.org> 2007
lib/replace/test/getifaddrs.c
lib/replace/socket.c
* Copyright (C) Michael Adam <obnox at samba.org> 2008
Signed-off-by: David Disseldorp <ddiss at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon Jun 3 18:06:18 CEST 2013 on sn-devel-104
commit b475ef008b1a2d2095c9b2276a55e9fbd38a5ca5
Author: David Disseldorp <ddiss at samba.org>
Date: Wed May 29 10:43:35 2013 +0200
torture: support printer publish pending responses
Windows (tested against 2k8r2) returns WERR_IO_PENDING and
DSPRINT_PENDING when a publish or unpublish is requested via
setprinter(level=7). Modify the AD printer publishing test to support
these responses.
Signed-off-by: David Disseldorp <ddiss at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Mon Jun 3 16:06:15 CEST 2013 on sn-devel-104
commit 56b02461626a0d49c47ff5e909b60d10b93afecf
Author: David Disseldorp <ddiss at samba.org>
Date: Wed May 29 10:43:34 2013 +0200
torture: add AD printer publishing test
This test publishes and unpublishes a printer using setprinter(level=7).
Printer info2.attributes and info7.action flags are check at each point
to ensure MS-RPRN conformance.
Signed-off-by: David Disseldorp <ddiss at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 002d1a44672c9b3247a68a86899ce6644b696a48
Author: David Disseldorp <ddiss at samba.org>
Date: Wed May 29 10:43:33 2013 +0200
Fix bug 9900: is_printer_published GUID retrieval
Samba currently always responds to GetPrinter(level = 7) requests with
DSPRINT_UNPUBLISH, regardless of the AD publish status tracked via the
PRINTER_ATTRIBUTE_PUBLISHED flag. This is due to erroneous "objectGUID"
unmarshalling in is_printer_published().
This change splits "objectGUID" retrieval into a separate function, and
adds a pull_reg_sz() call to correctly unmarshall the GUID.
Signed-off-by: David Disseldorp <ddiss at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit f9b6b09e4e4e15257ce0a21caa46e26e119667d4
Author: David Disseldorp <ddiss at samba.org>
Date: Wed May 29 10:43:32 2013 +0200
printing: explicitly clear PUBLISHED attribute
Currently nt_printer_publish(DSPRINT_UNPUBLISH) flips (via xor) the
info2->attributes PRINTER_ATTRIBUTE_PUBLISHED flag, rather than
explicitly clearing it.
Signed-off-by: David Disseldorp <ddiss at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 1f269fcc6e2bb46b765d547eb1add2bc52272c47
Author: Volker Lendecke <vl at samba.org>
Date: Thu May 30 16:23:17 2013 +0200
tdb: Add another overflow check to tdb_expand_adjust
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Rusty Russell <rusty at rustcorp.com.au>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Mon Jun 3 14:08:54 CEST 2013 on sn-devel-104
commit d9b4f19e73f241a1ccf64f04c3cc28d481550bb7
Author: Volker Lendecke <vl at samba.org>
Date: Thu May 30 15:54:58 2013 +0200
tdb: Make tdb_recovery_allocate overflow-safe
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Rusty Russell <rusty at rustcorp.com.au>
commit 8b215df4454883b3733733af4f49f87eb0a2a46a
Author: Volker Lendecke <vl at samba.org>
Date: Thu May 30 15:24:27 2013 +0200
tdb: Make tdb_recovery_size overflow-safe
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Rusty Russell <rusty at rustcorp.com.au>
commit 7ae09a9695bcc5fad606441db3ab6e413b9d48ce
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue May 28 13:04:29 2013 +0200
tdb: add proper OOM/ENOSPC handling to tdb_expand()
Failing to do so will result in corrupt tdbs: We will overwrite
the hash chain pointers with 0x42424242.
Pair-Programmed-With: Volker Lendecke <vl at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Rusty Russell <rusty at rustcorp.com.au>
commit 854c5f0aac03c7c6d7e1b37997dcdc848fec1499
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue May 28 13:01:27 2013 +0200
tdb: add overflow detection to tdb_expand_adjust()
We round up at maximun to a new size of 4GB,
but still return at least the given size.
The caller has to deal with ENOSPC itself.
Pair-Programmed-With: Volker Lendecke <vl at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Rusty Russell <rusty at rustcorp.com.au>
commit e19d46f7e31a32e2b5ae3ec05e13f32b8ac2109d
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue May 28 12:59:32 2013 +0200
tdb: add overflow/ENOSPC handling to tdb_expand_file()
Pair-Programmed-With: Volker Lendecke <vl at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Rusty Russell <rusty at rustcorp.com.au>
commit a07ba17e0c91d726416db946e6f65b064b2d17ec
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue May 28 12:56:57 2013 +0200
tdb: add a 'new_size' helper variable to tdb_expand_file()
Pair-Programmed-With: Volker Lendecke <vl at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Rusty Russell <rusty at rustcorp.com.au>
commit 4483bf143ddfee9ec07aed8f124559b00f757d9a
Author: Volker Lendecke <vl at samba.org>
Date: Thu May 30 14:52:59 2013 +0200
tdb: Add overflow-checking tdb_add_off_t
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Rusty Russell <rusty at rustcorp.com.au>
commit 42b0b275059f9c98b9bf417f2048fdc973449def
Author: Michael Wood <esiotrot at gmail.com>
Date: Sat Jun 1 10:37:37 2013 +0200
param_table: Remove misleading allow dns updates options.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sat Jun 1 12:46:32 CEST 2013 on sn-devel-104
commit 5528551ea39686194837a8083c85b71dedbe6f0e
Author: Michael Wood <esiotrot at gmail.com>
Date: Sat Jun 1 10:35:56 2013 +0200
docs: Avoid mentioning a possibly misleading option.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 7c4c896eacdeda27559f3bf47861392adeb3e10a
Author: Michael Wood <esiotrot at gmail.com>
Date: Sat Jun 1 10:34:20 2013 +0200
WHATSNEW: Fix 4.0 default for allow dns updates.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 0de1675e5d3854c5110ed34029be1e59d17991da
Author: Kai Blin <kai at samba.org>
Date: Sat Jun 1 10:24:12 2013 +0200
libcli: Remove uneeded debug message
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 8b24c43b382740106474e26dec59e1419ba77306
Author: Kai Blin <kai at samba.org>
Date: Sat Jun 1 10:24:11 2013 +0200
dns: Delete dnsNode objects when they are empty
If an update leaves the dnsNode without any entries, the dnsNode object
should be deleted. Thanks to Günter Kukkukk for his excellent debugging
work on this one.
This should fix bug #9559
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 553d63f0ead74ea101b2169bdad4af80caa16e2b
Author: Guenter Kukkukk <kukks at samba.org>
Date: Thu May 30 02:19:32 2013 +0200
s4-dns: set TTL value in the NS server part of the SOA record
noticed this when using samba-tool to create a new zone
Signed-off-by: Guenter Kukkukk <kukks at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu May 30 09:41:20 CEST 2013 on sn-devel-104
commit 09aaa991ef765405108c09c2059bbae2d897363e
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed May 29 10:25:25 2013 +0200
build-htmlman-nogit: Run build-htmlman-nogit with bash.
On debian/ubuntu, the "dash" which is sh, does not
provide pushd/popd...
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu May 30 04:48:06 CEST 2013 on sn-devel-104
commit fa3cca3fb0ab957604a29feda734f5bc7db7afdc
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed May 29 10:23:49 2013 +0200
build-htmlman-git: Run build-htmlman-git with bash.
On debian/ubuntu, the "dash" which is sh, does not
provide pushd/popd...
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 737dd2a9fd91a27affd61087639cdc1df21b1cc0
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed May 29 10:21:23 2013 +0200
build-htmlman-nogit: manpages-3 has been moved to manpages.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ce8bbdd9fc45bda5fb8900a83cc1a2e16a21af06
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed May 29 10:20:39 2013 +0200
build-htmlman-git: manpages-3 has been moved to manpages.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 0c67a29976310ace5cb9966fdd9971bba24c62b6
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed May 29 10:19:10 2013 +0200
docs-xml/.gitignore: manpages-3 has been moved to manpages.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 0b8b6fdc96f59895536d16de43a1494c5eef5c67
Author: Anand Avati <avati at redhat.com>
Date: Wed May 29 07:21:46 2013 -0400
vfs_glusterfs: Samba VFS module for glusterfs
Implement a Samba VFS plugin for glusterfs based on gluster's gfapi.
This is a "bottom" vfs plugin (not something to be stacked on top of
another module), and translates (most) calls into closest actions
on gfapi.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Simo Sorce <idra at samba.org>
Signed-off-by: Anand Avati <avati at redhat.com>
commit 05578dcdbfa1734ae7bafb70859a76f4cd2a023d
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon May 27 12:37:20 2013 +1000
samba-tool/dns: Set secure zone update flag after creating new zone
Windows DC ignores the secure update flag while creating new zone. Windows
performs another operation to set the secure update flag.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
commit c22eb103d865ed50a6c3ca89750245b92e17b493
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon May 27 12:26:36 2013 +1000
samba-tool/dns: Pass on additional flags when creating zones
Windows DCs require additional flags to be set when creating zones.
This fixes bug #9599.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
commit 612fbc18c3bf5307bd71ef533a5b6a13c7ef78b6
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Dec 6 16:11:18 2012 +1100
s4-dns: Support update of SOA records
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
commit de2788acd1ee2136b673c5d1ddf5bab335b4675f
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Dec 6 16:06:35 2012 +1100
s4-rpc: dnsserver: When updating SOA record, use the specified serial
This makes sure that when updating SOA record, the serial is set to the value
sent by client. For all other records, serial is incremented.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
commit cc103a8187317047347a679e42b076de7d69d181
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Dec 6 16:05:26 2012 +1100
s4-rpc: dnsserver: dns_name_equal() returns boolean
Remove the remaining check for return value after strcmp() was changed to
dns_name_equal().
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit b5c3ec0abc22145841b9b528cb55ec381e9c0d06
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Dec 6 16:04:32 2012 +1100
s4-rpc: dnsserver: Fix removal of trailing '.' in soa mname
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 3f24d694e7e2190d30a17bc13a79a36b49711531
Author: Michael Adam <obnox at samba.org>
Date: Tue May 28 12:19:34 2013 +0200
build: Add missing new line to replaced python shebang line. (Fix bug #9909)
When configuring with a non-standard python specified in
the PYTHON environment variable, the shebang lines in various
python tools like samba-tool and samba_dnsupdate get replaced.
This replace line for the shebang was missing a newline
which joined the shebang line with the following line,
rendereing those scripts with a nonempty second line unusuable,
for example samba_dnsupdate.
This patch fixes this bug which is bug #9909 on bugzilla.
Pair-Programmed-With: Karolin Seeger <kseeger at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Wed May 29 13:21:51 CEST 2013 on sn-devel-104
commit 886f062e72f8ad9cddfe5fab4b2b1a36be0ea30b
Author: Günther Deschner <gd at samba.org>
Date: Mon May 27 14:15:08 2013 +0200
s4-torture: Always compile backupkey ndr testsuite.
This removes another incorrect AD_DC_BUILD_IS_ENABLED check ifdef check. The ndr
test is not at all heimdal specific.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
Autobuild-User(master): Alexander Bokovoy <ab at samba.org>
Autobuild-Date(master): Wed May 29 11:29:51 CEST 2013 on sn-devel-104
commit b48ceef1d3031ec72018dc9bad1cf0dcb9864a56
Author: David Disseldorp <ddiss at samba.org>
Date: Tue May 28 15:11:45 2013 +0200
waf: build PIEs if supported by the compiler
Currently waf performs a mandatory check for compiler PIE support,
unless --without-pie is specified.
This change makes Waf only perform the mandatory check if --with-pie is
specified. If neither --with-pie nor --without-pie are specified, then
PIEs are only built if compiler support is available.
Signed-off-by: David Disseldorp <ddiss at samba.org>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit d86fda9b18be15a33d1a8850eedda352fdb91285
Author: Michael Adam <obnox at samba.org>
Date: Tue May 28 22:24:26 2013 +0200
autobuild: remove remnants of removed samba3 targets
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Wed May 29 09:35:16 CEST 2013 on sn-devel-104
commit 89edff08db367417f3032563df3ea1b546553c83
Author: Michael Adam <obnox at samba.org>
Date: Tue May 21 16:50:49 2013 +0200
net: use smbconf_create_set_share() in "net conf import"
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue May 28 20:01:12 CEST 2013 on sn-devel-104
commit caf83bcb76f52b0628f6d59e95396d16b5e3c66e
Author: David Disseldorp <ddiss at samba.org>
Date: Thu May 16 11:55:04 2013 +0200
libsmbconf: add smbconf_create_set_share
This call creates a new share definition, using the parameters provided
with a smbconf_service structure.
Such an interface allows for simple cloning of services with:
smbconf_get_share(conf_ctx, mem_ctx, base_sharename, &base_service_def);
base_service_def->name = clone_sharename;
smbconf_create_set_share(conf_ctx, base_service_def);
Pair-Programmed-With: Michael Adam <obnox at samba.org>
Signed-off-by: David Disseldorp <ddiss at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit 57634fd87d7176a1f92281ad1b3e9a565b54cfc7
Author: Michael Adam <obnox at samba.org>
Date: Mon May 20 23:30:14 2013 +0200
libsmbconf: fix documentation of transaction calls.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 277831eaf140c06bb25a3549434bc4acd4f533ec
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu May 16 17:51:56 2013 +1000
dsdb-repl_meta_data: Move TODO comment about conflicts and missing parents
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue May 28 18:11:00 CEST 2013 on sn-devel-104
commit 2d38009852487ab3572b66817ed0492333b5ec7d
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu May 16 15:24:25 2013 +1000
torture: Add tests of rename behaviour to replica_sync.py
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 6960f8e4c3d683103580aa91605f951bc227dbed
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu May 16 15:19:20 2013 +1000
dsdb-repl_meta_data: Handle renames better, considering only the RDN as given, and then the parent as given
This ignores the full DN as given, because the parent compents might be out of date.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 54e092bb31001879f4d7a49e36a226c27b4d9843
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu May 16 13:52:51 2013 +1000
dsdb-linked_attributes: Do not crash if the target GUID can not be found
Note that we must not give an error when we cannot find the object
that should hold the backlink, there really isn't anything we can do
in this case.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 3bd686c5ad4756af1033ac14ba09a40156cc6d47
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Tue May 28 16:53:56 2013 +0930
tdb: fix logging of offets and lengths.
We can have offsets > 2G, so use unsigned values. Fixes other prints to be
native types rather than casts, too.
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue May 28 11:22:14 CEST 2013 on sn-devel-104
commit 5a633dd6bb5be817c6b421df0c098e3428a20773
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Dec 6 16:10:42 2012 +1100
s4-dns: Print/Set minimumTTL value in SOA record
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue May 28 08:47:56 CEST 2013 on sn-devel-104
commit 667651132b9136e1ad9d7dc5f44dd86c66907e70
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu May 23 09:37:10 2013 +1000
build: Remove unused mkbuildoptions.awk
This is not used by the waf build.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit dd72d85e928a9f52113235daaab1e71ea916aa0d
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 17:05:11 2013 +1000
build: Remove unused tool for config.h comparison
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 4c4520ac3794f917c831255d6598945712bcfb5c
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 16:23:23 2013 +1000
build: Remove feature tests for variables now always provided
These #ifdef statements were added in replacement for #if (_SAMBA_BUILD_ >= 4)
in fbe7ed79b0f056a9a8f44a9b42e887441d2f00d5
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit dc6b03ffa55968708576cb527f1b52a37d8e5317
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 16:16:31 2013 +1000
build: Remove unused credentials_samba3.c
This file was only used by the autoconf build system.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 26d36befa8347eb093850cc8853fd9939555d458
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 16:13:21 2013 +1000
selftest: VFSLIBDIR is not needed, the waf build knows where to find modules automatically
This is why was relinks on install, because it is fixing these
internal variables up.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit cbddf9e2efd856a25c6405f6893ad3a9cda1b181
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 14:22:36 2013 +1000
build: Remove autoconf build system from examples/VFS
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit f073401abf9a0f91715854d885fad96332d001b5
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 13:48:35 2013 +1000
passdb-machine_account_secrets: Remove #if SAMBA_BUILD_ == 4 now we only have the waf build
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 2c70b0edcfbc009b5cdc27454d3703fbf20a50bd
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 13:47:50 2013 +1000
nsswitch: Remove #if SAMBA_BUILD_ >= 4 now we only have the waf build
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 922fe921ce3df0ea7c3b44f07a076301fcbe06fa
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 13:46:16 2013 +1000
lib/util/modules.c: Remove #if SAMBA_BUILD_ == 3 now we only have the waf build
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 2bede9d0d6f92046dffe9bcd282fdd791339b10c
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 13:44:59 2013 +1000
param: Remove _SAMBA_BUILD_ checks from now the autoconf build is gone
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit ae144978bc7141e66426eccf08450a6408eda359
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 12:47:59 2013 +1000
docs: Document removal of the autoconf build system
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 11aab8a348af6ae825756f199ff592beb51f241c
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 12:39:59 2013 +1000
build: Remove unused preproc-dummy.c
This was used by autogen.sh
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 53c61a3a18666e3c01130380bd62fa579c1e4458
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 12:37:54 2013 +1000
build: Remove unused linkmodules.sh script
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 69c09e7a34de7fd31960d240d34dabdeddb37222
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 12:37:34 2013 +1000
build: Remove unused revert.sh script
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 26ff1f2167c8f326c3ea17bc69ee927d58b5baf8
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 12:37:14 2013 +1000
build: Remove unused uninstall*.sh scripts
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit d98f1075443b7feedab0212e75366d502b20e17a
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 12:36:34 2013 +1000
build: Remove unused install*.sh scripts
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 167b8bddad24421a2e8fcf0e7647ef3296b1665c
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 12:35:15 2013 +1000
build: Remove unused build_idl.sh
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit c5bde695683be4af68cf8eb876f88a307bf2fcd3
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 12:32:55 2013 +1000
Remove lib/netapi autoconf build system, this is now build with waf
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 87049bf32fa069916800316366cc577116b9d703
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 12:30:10 2013 +1000
build: Remove unused build_idl.sh
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit af443d0017125209cce61fbab88b2385bf1df9df
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 12:27:33 2013 +1000
Remove now-unused s3-selftest.sh wrapper
This is now always invokes via waf.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 8bcaa145f23e606f4b850fe7147192a6fec11c2d
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 12:26:35 2013 +1000
Remove stub ldb_version.h and source3/include/autoconf as no longer needed
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 8b2590c311ad24f809a5b27d2a408b6e9338db1d
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 12:25:45 2013 +1000
build: Remove autoconf directory no longer needed
This was only needed to avoid autoconf and waf builds colliding.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 0b5c23b5220faaf7d04e70773a0f74746486068b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 12:24:16 2013 +1000
build: Remove unused script/mkversion.sh
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit a768e6b0f89a1395dbce1dde73c001c2bde1fc99
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 12:23:56 2013 +1000
build: Remove unused install-sh
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit cd4b413cb0574c459c1c24cf07f8d6b44f5fc077
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 12:23:20 2013 +1000
build: Remove autoconf build system
We are now confident that that waf build system meets enough of our needs
that we will work to improve it, rather than maintain two build systems.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 97cceb5f8b9fc68cb8942092e92fde2b965883e4
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 14:23:31 2013 +1000
build: No longer run autogen.sh during tarball creation
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit fb67cea6803650e0696fc45a2a8475728dbb18f0
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 14:35:08 2013 +1000
autobuild: Remove samba3 and samba3-ctdb targets to allow autoconf removal for 4.1
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 4e76a77f622f1fa30a8ae1e011d87fc9754e1b85
Author: David Disseldorp <ddiss at samba.org>
Date: Mon May 27 17:57:01 2013 +0200
waf: build position independent executables
This patch re-instates support for building Position Independent
Executables using the '-fPIE' and '-pie' compiler and linker flags
respectively.
PIE builds are enabled by default, and can be explicitly disabled using
the '--without-pie' configure argument.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue May 28 02:56:36 CEST 2013 on sn-devel-104
commit d47c1245788505cfaca9a25c855a2503c83e4315
Author: David Disseldorp <ddiss at samba.org>
Date: Mon May 27 17:57:00 2013 +0200
waf: add --with[out]-pie configure arguments
The arguments do not currently have any effect.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 1754b52204563a722920805b76e6c571d0268434
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun May 26 21:05:12 2013 +1000
build: Install smbtar in waf build
Reviewed-by: Kai Blin <kai at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon May 27 12:55:05 CEST 2013 on sn-devel-104
commit 4ae3cdcd7151237a858f668357d08ab6916bdb3b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun May 26 20:29:19 2013 +1000
docs: Remove all references to testprns
Based on debian patch documentation2.patch by Christian Perrier <bubulle at debian.org>.
This tool no longer exists in Samba.
Andrew Bartlett
Reviewed-by: Kai Blin <kai at samba.org>
commit 99c1c2b8d399c662596d9942aa6af9fb0db00086
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu May 23 07:34:15 2013 +1000
build: Remove duplicate call to bld.SYMBOL_CHECK()
This was missed when we merged the two waf systems.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon May 27 10:30:06 CEST 2013 on sn-devel-104
commit e78e156d95ba19fec663b83f31aaca13d19cfd7b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu May 23 09:51:36 2013 +1000
build: Remove mkinstalldirs
This is not used in the waf build.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 940a6a62058a6bbd5f32ac1e1eba11b37d411401
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu May 23 13:17:19 2013 +1000
lib/replace: Remove unused install-sh
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon May 27 05:51:04 CEST 2013 on sn-devel-104
commit 792633006002ef62bf35a0279cad7fbd60520077
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu May 23 09:51:03 2013 +1000
build: Remove unused expand-includes.pl
We no longer have makefiles with includes.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit a153eb0d2198a774f7c046f9e96c73d55405877e
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu May 23 09:38:47 2013 +1000
build: Remove old create-tarball release script
Releases are now done via "waf dist" and script/librelease.sh.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 8903103bd691c3927a644ed9162d6412df9ffeea
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu May 23 09:33:19 2013 +1000
build: Do not always regenerate the version.h file
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit cbb833d78e48953b3a04c0463f68c5370f2d4187
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 07:37:33 2013 +1000
smbd: Fix build on platforms that will not support var = {} initialisation
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit d41ec68601cfca67874f78d2f64784904d1530da
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 00:13:52 2013 +1000
examples: Remove browser and DC settings from example smb.conf
These examples just encourage folks to set browing values that are not needed.
The domain logons setting is already covered by the server role at the
top of the file and logon script is not special enough to be in the
default smb.conf.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 02ee9e4d8a2befe3fa27bc8be211c80a99767f34
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 00:12:23 2013 +1000
examples: Remove password server from example smb.conf
This should discourage folks from setting it when they do not really need it.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 8a06c3dd79af0165c8701a465c3f8483ada89a83
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 00:11:32 2013 +1000
examples: Remove default printing form example smb.conf
These settings are all defaults, and just work for most systems. Users on other platforms
can read man smb.conf, rather than cluttering up this file.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 2a110aaecad5439534eacfc91b607a3c3653e81d
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 00:10:39 2013 +1000
examples: Move example smb.conf over to "server role"
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 2a4eaa3241fc4ccb79359ea4e4d511754a84d46b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 00:14:29 2013 +1000
build: Rework BSD_STYLE_STATVFS check to match autoconf build
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit c6673b96a59e38031da6654580250bbc58766cfd
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun May 26 23:11:03 2013 +1000
build: Remove binaries and libraries build groups
Build groups are used in Samba to ensure that even if the dependency
chain for a target is not perfect, that it builds reliably. This
matters most in the early build stages, where we are building the asn1
compiler and autogenerating files.
Once we get to the main stage, dependencies between C files, libraries
and binaries are much clearer, because the C compiler and linker takes
these as inputs anyway.
Groups were added to our waf build for stability during early
development, as dependency information was first imported from the
previous autoconf/perl based build system.
I don't think we need this distinction in the main build of C files
into .o, and when linking these into binaries, because the invocation
of these tools is very well defined, and we will find any missing
inputs very quickly.
As such, I've removed the libraries and binaries targets,
consolidating them with 'main'
By making this change, a build of smbtorture only on a clean tree
drops from 3778 to 2489 targets, and much of the expensive linker
stage is skipped. The time for a null build of smbtorture only also
drops from 4.673s to as low as 2.499s on my laptop.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit dfe73e7885a40de8c24d1231365a16f7aa3d5073
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon May 27 08:27:44 2013 +1000
build: Build all of samba in autoconf make test
The test system actually depends on far more than smbtorture these days
and this was masked by the build groups. Rather than try and specify
everything that could be used, just build the lot (which is what was
essentially being done anyway).
This prepares for the removal of the libraries and binaries build
groups, to assist in improving waf performance for single-binary builds.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 8bf311288be718d6dd87b5a79550f2282c7396d5
Author: Michael Adam <obnox at samba.org>
Date: Wed Apr 24 15:49:46 2013 +0200
s4:idmap: break account_type check lines for readability in idmap_sid_to_xid()
Also makes code obey README.Coding, regarding line-length.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Mon May 27 00:05:19 CEST 2013 on sn-devel-104
commit 9c7015ecaacff859c7ba94ccadd49b4e9a5cd002
Author: Kai Blin <kai at samba.org>
Date: Sat May 25 14:05:22 2013 +0200
idl: Add DNS HINFO record support
Not sure if we need this, bug samba.org specifies it, so this can cause ANY queries
against samba.org to fail.
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Sun May 26 20:05:38 CEST 2013 on sn-devel-104
commit 96ed585f09efdad2b5e6ab7918966b1453154d71
Author: Kai Blin <kai at samba.org>
Date: Sat May 25 14:05:21 2013 +0200
idl: Add DNS RP record support as per RFC 1183
Not sure if we need this, but samba.org specifies it, so this could cause ANY
queries against samba.org to fail.
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit df43027bd8c127a44304f7130bf61adfcdf73eed
Author: Kai Blin <kai at samba.org>
Date: Sat May 25 13:21:33 2013 +0200
dns: Support larger queries when asking forwarder
This should fix bug #9632
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 5bcebb54da8eed535e5f7034ed1f7a95456f19b1
Author: Kai Blin <kai at samba.org>
Date: Sat May 25 13:21:32 2013 +0200
idl: Add support for parsing OPT records
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit c134171e39cbe5e788f075add32a4841451ab4de
Author: Christof Schmitt <christof.schmitt at us.ibm.com>
Date: Fri May 24 12:40:49 2013 -0700
winbind: Print error code on connection error in ping_dc
For debugging, it is useful to include the error code in the message.
Signed-off-by: Christof Schmitt <christof.schmitt at us.ibm.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Sat May 25 23:11:23 CEST 2013 on sn-devel-104
commit 92254d09e0ee5a7d9d0cd91fe1803f54e64d9a5f
Author: Vadim Zhukov <persgray at gmail.com>
Date: Sat May 25 15:19:24 2013 +0100
pidl: Recent Perl warns about "defined(@var)" constructs.
Signed-off-by: Jelmer Vernooij <jelmer at samba.org>
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Sat May 25 18:10:53 CEST 2013 on sn-devel-104
commit 39d7982625ba05befa7bc2430a79d44984eb410e
Author: Anand Avati <avati at redhat.com>
Date: Fri May 24 12:23:06 2013 -0700
building RPMs on RHEL fail because of a typo.
Signed-off-by: Anand Avati <avati at redhat.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Simo Sorce <idra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sat May 25 01:04:37 CEST 2013 on sn-devel-104
commit e24fe5705e3c4d33705ebb584ea2009bb4a1a82c
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri May 17 23:18:55 2013 +0200
libnet-vampire: make use of dsdb_repl_resolve_working_schema()
Pair-Programmed-With: Matthieu Patou <mat at matws.net>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu May 23 14:18:03 CEST 2013 on sn-devel-104
commit 24fb281ea7983a42ba94b664530170e2401523f7
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri May 17 23:18:41 2013 +0200
dsdb-repl: merge the logic from libnet_vampire_cb_apply_schema()
This way libnet_vampire_cb_apply_schema() is able to use
dsdb_repl_resolve_working_schema().
Pair-Programmed-With: Matthieu Patou <mat at matws.net>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 9af430ec0be46d0a616faee3552600219bc57097
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri May 17 23:02:03 2013 +0200
dsdb-repl: split out dsdb_repl_resolve_working_schema
This can be reused later in other places.
Pair-Programmed-With: Matthieu Patou <mat at matws.net>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit d36e9118cbf9deb01c6ee9af6790ce35bb3b936a
Author: Matthieu Patou <mat at matws.net>
Date: Thu Apr 18 22:03:23 2013 -0700
selftest: Improve test coverage of DRS (bug #8680)
Pair-Programmed-With: Andrew Bartlett <abartlet at samba.org>
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 640c2ff57518a5711e795e6cc9f48ae29d379a01
Author: Matthieu Patou <mat at matws.net>
Date: Sun Jan 27 15:43:07 2013 -0800
dsdb-drs: when replicating schema object checks ask for removal of previous version if exists (bug #8680)
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit c7d4b87512eabbff5172716a755a3cd61fe5476b
Author: Matthieu Patou <mat at matws.net>
Date: Sun Oct 7 21:46:38 2012 -0700
libnet-vampire: add attributes and classes from the replicated schema to the bootstrap schema (bug #8680)
Replicated schema might have attributes and auxilary classes on some
critical classes (ie. top, user, computer ) that are not in the bootstrap
schema. Without those new attributes and classes, bootstrap schema is
unable to translate those critical classes in the schema constructed
from the replicated data. Without thoses classes new schema is useless
and can't be indexed properly.
In order to overcome this problem, we put all new attributes and classes
definitions into the bootstrap schema so that foundations classes can be
translated.
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Matthieu Patou <mat at matws.net>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit fe85bc1fb9ab2f891a9fd46bd8e00325622d39cf
Author: Matthieu Patou <mat at matws.net>
Date: Sat Jan 26 23:42:10 2013 -0800
dsdb-schema: make deduplication of class and schema possible (bug #8680)
When a class or an attribute is replicated it might already exists in
the existing schema, so while replicating the new version of this object
we want to get rid of the old version of the object is the current
validating schema so that we don't end up having duplicates.
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Matthieu Patou <mat at matws.net>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit c524be17815e92ce9fcdd0565e76b026e483cc9d
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu May 23 08:46:31 2013 +0200
dsdb-schema: schema_fill_possible_inferiors() should rebuild everthing
commit cd7f3fd07215a7b8372b6b623faed02ae1310cb1 reverted the change
of commit c2853f55fc603d4875bb1e50a1cbf409df0421ea.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit bea2af9369d596d513ae3909f9c6a1f356f7c827
Author: Richard Sharpe <realrichardsharpe at gmail.com>
Date: Wed May 22 20:05:17 2013 -0700
Revert my accidental commit.
Signed-off-by: Richard Sharpe <rsharpe at samba.org>
Autobuild-User(master): Richard Sharpe <sharpe at samba.org>
Autobuild-Date(master): Thu May 23 06:53:17 CEST 2013 on sn-devel-104
commit 9ddfd7d8784e6f546628f48990b69ee2850be52d
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 17:23:30 2013 +1000
lib/replace: Set BROKEN_STRNLEN and BROKEN_STRNDUP on all AIX
The background is in https://bugzilla.samba.org/show_bug.cgi?id=1097
and wider reports are at
http://stackoverflow.com/questions/2091460/strndup-call-is-currupting-stack-frames
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu May 23 03:52:10 CEST 2013 on sn-devel-104
commit e896f3c5bf5dee3c771985cd9dd2eb376481c22b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue May 21 20:44:26 2013 +1000
docs: Fix small errors in TOSHARG-Compiling
Reviewed-by: Jeremy Allison <jra at samba.org>
commit f632150e1b5a8d8a32753f43f7433b392f3a2136
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue May 21 20:50:30 2013 +1000
docs: Remove TOSHARG-HighAvailability which is made obsolete by CTDB
This is mostly a lament on why this is hard, and while CTDB is still
hard, this document tries to imply it is almost impossible, and makes
no mention of the solution.
Andrew Bartlett
Reviewed-by: Jeremy Allison <jra at samba.org>
commit fa8e760882ea389f8c94d6dfdc7386b0295974d1
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue May 21 17:49:55 2013 +1000
docs: Remove out of date and unmaintained Speed page from the HOWTO
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 7174b2e18ece47b6c662020b38b279dfdf88a929
Author: Peng Haitao <penght at cn.fujitsu.com>
Date: Wed May 22 14:03:13 2013 -0700
When message-type is drvupgrade, MSG_DEBUG should be replaced with MSG_PRINTER_DRVUPGRADE.
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 9a9949f92f90bd4305607350dea2672473397752
Author: Peng Haitao <penght at cn.fujitsu.com>
Date: Wed May 22 14:02:29 2013 -0700
When '--policies-reset' is success, the exit code should be 0.
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 30a224367595f9e2506e41053fc9c7cb96a90928
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 22 00:14:19 2013 +1000
build: Update md5.h detection in waf and autoconf to use sys/md5.h and -lmd
This brings the two build systems in sync, without using md5.h (which is a problem name)
Tested on FreeBSD
Andrew Bartlett
Reviewed-by: Richard Sharpe <rsharpe at samba.org>
Autobuild-User(master): Richard Sharpe <sharpe at samba.org>
Autobuild-Date(master): Wed May 22 10:06:40 CEST 2013 on sn-devel-104
commit 27df444d0b92a8acb4d830b3b62f04835b57f0e8
Author: Richard Sharpe <realrichardsharpe at gmail.com>
Date: Sat May 11 09:47:23 2013 -0700
Make sure that if an smbd is exiting because of an error we let the user know.
Signed-off-by: Richard Sharpe <realrichardsharpe at gmail.com>
commit f80d56a1a0d62c5a1cdbe78ec3214b9f53e28946
Author: Günther Deschner <gd at samba.org>
Date: Fri May 17 11:23:22 2013 +0200
s4-torture: No need to disable rpc.spoolss.win test when compiled with MIT kerberos.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Mon May 20 20:35:33 CEST 2013 on sn-devel-104
commit 8b7788c5d8ecbac3b8a41cdbb4fec7f0e73a9b76
Author: Günther Deschner <gd at samba.org>
Date: Fri Feb 1 14:53:12 2013 +0100
selftest: mark the spoolss add print processor tests as knownfail for now.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 00ee6a648b6290d6d3ddcb35fe5aa4c797222684
Author: Günther Deschner <gd at samba.org>
Date: Fri Feb 1 14:07:50 2013 +0100
s4-torture: add simple tests for spoolss_{Add|Delete}PrintProcessor.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit fdf94747599e1461873fb2a5466f1e55d904333f
Author: Günther Deschner <gd at samba.org>
Date: Fri Feb 1 14:07:07 2013 +0100
doserr: add mapping for WERR_PRINT_PROCESSOR_ALREADY_INSTALLED.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 9744bf519b1fcdab59ba7d55b2b664a6b44b30bd
Author: Günther Deschner <gd at samba.org>
Date: Fri Feb 1 02:34:11 2013 +0100
spoolss: fill in IDL for spoolss_DeletePrintProcessor.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit e8797a3ecc03cbbdbc51c3952ac72fd663d5849c
Author: Günther Deschner <gd at samba.org>
Date: Thu Jan 31 22:06:20 2013 +0100
s4-torture: also deal with "Microsoft XPS Document Writer v4" as default driver.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit cc153fe86f780d4aefe40999064b294b612e92d6
Author: Günther Deschner <gd at samba.org>
Date: Thu Jan 31 14:56:17 2013 +0100
s4-torture: add ndr test for spoolss_RpcSetJobNamedProperty.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit c568a2e5c58d01fdd27156e84b361e49c4666fb1
Author: Günther Deschner <gd at samba.org>
Date: Tue Jan 22 10:17:27 2013 +0100
s4-torture: add ndr test for spoolss_GetCorePrinterDrivers.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit c51866eadf6159a6fa76af28be3b9a724ed28b46
Author: Günther Deschner <gd at samba.org>
Date: Thu Jan 31 20:44:54 2013 +0100
s4-torture: add simple test for spoolss_RpcSendRecvBidiData.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit aa1e5f29af2a4560eecaac08ed62c2e63d3c8504
Author: Günther Deschner <gd at samba.org>
Date: Mon Jan 21 22:09:22 2013 +0100
s4-torture: add test for spoolss_RpcEnumJobNamedProperties.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 3d567f6a962a59cb69b702e7ed2c968246c26566
Author: Günther Deschner <gd at samba.org>
Date: Sun Feb 24 14:06:59 2013 +0100
spoolss: add spoolss_MonitorContainer IDL.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 1aafc844a721746b4feddbd2d547463a43821a2f
Author: Günther Deschner <gd at samba.org>
Date: Thu Jan 24 23:31:19 2013 +0100
spoolss: make RPC_PrintNamedProperty public
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit cc38511903dbf34eeb358759f00341f60688acdb
Author: Günther Deschner <gd at samba.org>
Date: Mon Jan 21 21:37:12 2013 +0100
spoolss: fill in IDL for JobNamedProperty calls.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit ec29957e884d345009edac18ad362ba91de39f9c
Author: Günther Deschner <gd at samba.org>
Date: Sat Jan 19 00:20:42 2013 +0100
spoolss: make more container objects public for iremotewinspool.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 5a5ed68d0a92b36ddad9160deaf58314c13b2b49
Author: Günther Deschner <gd at samba.org>
Date: Sat Jan 19 00:47:42 2013 +0100
spoolss: add idl for spoolss_RpcSendRecvBidiData.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit b072bb76dbdd96ee676c2bfbbffe58a187ef25ac
Author: Günther Deschner <gd at samba.org>
Date: Tue Feb 5 16:10:34 2013 +0100
s4-torture: add missing NTSTATUS checks in test_AddJob().
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 69d9e3ef870fdd643bdc6fb4c893fa26d06fb2cf
Author: Günther Deschner <gd at samba.org>
Date: Wed Jan 30 20:05:51 2013 +0100
spoolss: add [ms_union] to spoolss.idl where appropriate.
Normally we would activate [ms_union] for the entire interface but given the
fact we use this IDL file also for custom-marshalled structures we would
generate union arm alignment also for the custom-marshalled unions where they
are inappropriate. Thus, only enable [ms_union] only for unions that are part of
the MS-RPRN IDL.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 229108e26645e121fa5ec06911f573dce8198c07
Author: Günther Deschner <gd at samba.org>
Date: Wed Jan 30 15:55:18 2013 +0100
spoolss: fix string types in spoolss_JTEXP.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 393ad20577c7fa66928ecb34bc8b323feb881ea5
Author: Günther Deschner <gd at samba.org>
Date: Tue Jan 29 21:57:58 2013 +0100
spoolss: Fix two size elements in the devmode private spoolss_JTEXP struct.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit d7708fd360c1fa1e3111fd4df266b52c96cca196
Author: Volker Lendecke <vl at samba.org>
Date: Mon May 20 14:26:08 2013 +0200
talloc: Fix a typo
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Kai Blin <kai at samba.org>
Autobuild-User(master): Kai Blin <kai at samba.org>
Autobuild-Date(master): Mon May 20 18:48:49 CEST 2013 on sn-devel-104
commit 96f972460ca458e86edbd97c682bfa462e01a242
Author: Matthieu Patou <mat at matws.net>
Date: Tue Jan 1 20:57:25 2013 -0800
ldb_tdb: Warn when reindexing is done
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon May 20 15:47:33 CEST 2013 on sn-devel-104
commit 74fa70cdece0aabf86f8d70e4b48268d48879b9e
Author: Matthieu Patou <mat at samba.org>
Date: Fri May 17 17:14:29 2013 +0200
smbtorture: Show the list of cracknames we expect to have and the result
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 6c4cf59fba463943fa4dfb9afe0a217d8a2b0b23
Author: Matthieu Patou <mat at matws.net>
Date: Fri May 17 07:21:57 2013 -0700
smbtorture: fix a warning due to a set but unused var
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit d42a31d68f3154651f31618f74e2df77084f12f3
Author: Matthieu Patou <mat at matws.net>
Date: Fri May 17 07:19:22 2013 -0700
smbtorture: fix crash when the returning a crackname with an empty name
when a valid one was expected
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit d5b440fa897ace7bef4d02a7ad1af556819139a6
Author: Matthieu Patou <mat at matws.net>
Date: Fri May 17 05:26:46 2013 -0700
Fix warning by setting the variable from GUID to const GUID
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 373448804ba02378ab0957b0f80a6dd28910a261
Author: Matthieu Patou <mat at matws.net>
Date: Fri May 17 05:24:08 2013 -0700
Fix more unused vars
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 4cc3d065bca7ffe2b8bae58c8e2c4387add3ad52
Author: Matthieu Patou <mat at matws.net>
Date: Fri May 17 05:22:33 2013 -0700
Fix a warning about a set but unused variable by actually using it
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 972417131d8c23855d728f35fc7680c2dedb21b7
Author: Matthieu Patou <mat at matws.net>
Date: Fri May 17 05:22:15 2013 -0700
Fix warnings about set but unused variables
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit bfce9690bf6e6592d32dd41642a33cbe3c027b81
Author: Matthieu Patou <mat at matws.net>
Date: Fri May 17 05:17:41 2013 -0700
Fix a warning about a shadowed variable by renaming the shadowing var
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit e1b71f1c133fd43935135a44cdbbb7e912ff4279
Author: Matthieu Patou <mat at matws.net>
Date: Fri May 17 04:50:20 2013 -0700
buildtools: Fix compilation warnings
STATIC_%s_MODULES_PROTO is defined on the compilation command line by
-DSTATIC_<something>_MODULES_PROTO which the compiler seems to turn into
define STATIC_<something>_MODULES_PROTO 1 thus yielding a warning due to
unused var
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 61989aee31c6dbf5646579c4d774c5b1d7a7f74c
Author: Matthieu Patou <mat at matws.net>
Date: Tue Jan 22 00:09:11 2013 -0800
operational: remove double loops
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit cd7f3fd07215a7b8372b6b623faed02ae1310cb1
Author: Matthieu Patou <mat at matws.net>
Date: Mon Jan 21 22:27:10 2013 -0800
dsdb-schema: remove looping on all schema classes for system_possible_inferrior
The logic to populate possible inferriors and system possible inferriors
is the same so instead of looping twice we do both attributes (depending
on the type of the class) in the same loop
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 61a2ad3c020424cead067cbdc89ea6f25708fde4
Author: Kai Blin <kai at samba.org>
Date: Fri May 17 14:16:26 2013 +0200
swat: Remove swat.
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Kai Blin <kai at samba.org>
Autobuild-Date(master): Sat May 18 16:32:38 CEST 2013 on sn-devel-104
commit a3a3086a2a35021bcf4dd4d3bcaeb51eb1b44a19
Author: Kai Blin <kai at samba.org>
Date: Fri Jan 18 18:36:45 2013 +0100
dns: Also print packet information for DBGC_DNS
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Kai Blin <kai at samba.org>
Autobuild-Date(master): Sat May 18 12:48:15 CEST 2013 on sn-devel-104
commit 0f5e9d29f607f9d910641632dfcd20ef800b0bc4
Author: Kai Blin <kai at samba.org>
Date: Fri Jan 18 18:35:15 2013 +0100
librpc: Add NDR_PRINT_DEBUGC to ndr print to a debug class
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 30cba0d201fc91cff30b6ea2bd11979930650169
Author: Kai Blin <kai at samba.org>
Date: Fri Jan 18 09:44:02 2013 +0100
debug: Add ability to dump_data per debug class
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 1c9ef675d1a44fb9b0d599f96391abf1e21981c1
Author: Volker Lendecke <vl at samba.org>
Date: Fri May 17 15:14:58 2013 +0200
smbd: Fix a ISO C90 forbids mixed declarations and code warning
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Matthieu Patou <mat at matws.net>
Autobuild-User(master): Matthieu Patou <mat at samba.org>
Autobuild-Date(master): Sat May 18 01:40:04 CEST 2013 on sn-devel-104
commit 2fda6c47f4aa46dbb42028732207a94821881c67
Author: Vadim Zhukov <persgray at gmail.com>
Date: Fri May 17 12:43:08 2013 +0400
More generic check for OpenBSD platform
OpenBSD versioning is different from many other
projects, and, say, 5.0 does not differ from 4.9 more than from 5.1. So the
right approach will be to check that platform name starts with "openbsd"
instead. This is also the thing OpenBSD developers do when patching other
software, so this patch is consistent with already existing practicies.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=9888
Reviewed-by: Lars Müller <lars at samba.org>
Reviewed-by: Björn Jacke <bj at sernet.de>
Autobuild-User(master): Björn Jacke <bj at sernet.de>
Autobuild-Date(master): Fri May 17 17:58:16 CEST 2013 on sn-devel-104
commit c3057f69a274f0d8e0e66183bd5e8be7703b6750
Author: Björn Jacke <bj at sernet.de>
Date: Wed May 15 15:52:25 2013 +0200
docs: mention AD prerequirements for using idmap_ad
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 2314f47cd4c9a1815da02394f7ed00819f6c2c66
Author: Björn Jacke <bj at sernet.de>
Date: Wed May 15 13:34:33 2013 +0200
doc: some fixes for vfs_full_audit man page
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 1a7e181fb84757e1aa189310fee272d85f1c3bd5
Author: Matthias Dieter Wallnöfer <mdw at samba.org>
Date: Fri May 17 10:31:28 2013 +0200
s4:dsdb python tests - set the executable flag
Reviewed-by: Matthieu Patou <mat at samba.org>
Autobuild-User(master): Matthias Dieter Wallnöfer <mdw at samba.org>
Autobuild-Date(master): Fri May 17 15:11:29 CEST 2013 on sn-devel-104
commit c29447f2b8705630a24d3d73f76661af296a4c4d
Author: Christian Ambach <ambi at samba.org>
Date: Thu May 16 15:07:44 2013 +0200
s3:lib/ctdb_conn make sure we are root before connecting to CTDB
CTDB socket is only reachable for root, make sure we are root when trying to connect to it
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Christian Ambach <ambi at samba.org>
Autobuild-Date(master): Fri May 17 13:16:37 CEST 2013 on sn-devel-104
commit d67e614a07cbf143293436d380aba9a022c0e31b
Author: Volker Lendecke <vl at samba.org>
Date: Thu May 16 16:11:54 2013 +0200
lib: Add before/after hooks to async_connect
This will facilitiate [un]become_root for smbd to connect safely to ctdbd.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 272a58afff69f52704bcc9a62947853b638420d5
Author: Christian Ambach <ambi at samba.org>
Date: Tue May 7 09:08:07 2013 +0200
waf: build vfs_aixacl2 module by default on AIX
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 162ec83f68efc89c46630f6842700bca8f16b201
Author: Christian Ambach <ambi at samba.org>
Date: Tue May 7 09:06:50 2013 +0200
waf: only use -fstack-protector when both compiler and linker support it
otherwise build with xlc on AIX fails because the compiler silently ignores the parameter
but the linker does not like it
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 355f78fe9e8ba09179693597104915f3b6963139
Author: Björn Jacke <bj at sernet.de>
Date: Thu May 16 16:19:22 2013 +0200
docs/rpcdaemon: some formating fixes
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Fri May 17 10:34:18 CEST 2013 on sn-devel-104
commit 3f3576d64275dbf4964458dab39252ae4da9ba06
Author: Matthieu Patou <mat at matws.net>
Date: Fri Jan 11 20:05:39 2013 -0800
drsuapi: Debug more clearly why NC is bad in updateRefs
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Fri May 17 04:17:14 CEST 2013 on sn-devel-104
commit 1a7bd5e12c519f8d14120f21198038dae1e5c914
Author: Christian Ambach <ambi at samba.org>
Date: Thu May 16 15:06:49 2013 +0200
nsswitch: fix some typos
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Fri May 17 01:09:33 CEST 2013 on sn-devel-104
commit 9910b8050ccb073fe47c26eeeeb60955d9f2d043
Author: Christian Ambach <ambi at samba.org>
Date: Tue May 14 21:02:15 2013 +0200
s3:lib/dbwrap add missing curly braces
violation of README.Coding
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit bdc3e9acaf1b03af0e523f60b3260c6fdc62523c
Author: Christian Ambach <ambi at samba.org>
Date: Tue Apr 23 11:20:42 2013 +0200
s3:include remove non-blank line endings
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 2ed6b0818a68ac07bd9c4270522aa8e2098ec140
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu May 16 10:32:50 2013 +1000
auth: Ensure auth_sam is not used on the AD DC
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Thu May 16 22:51:26 CEST 2013 on sn-devel-104
commit 9b24f6523e8c78879ada3e6d2927ebbb21dabfdc
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon May 13 14:06:14 2013 +1200
dsdb: Expand on what the error finding the ntSecurityDescriptor was in acl_read
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 60d1c2d5288b01bd9a99f90bb0a9d0ff3c873412
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon May 13 14:05:28 2013 +1200
autobuild.py add ntdb to the samba-libs task, to ensure it works as an external library
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 73628e9cd9005478cdb225f01917eb54270a3c05
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Apr 2 16:10:03 2013 +1100
rpc_server-drsuapi: Include the failing DN when unable to convert DB objects to DRS
This is a very serious situation (it should not happen) so getting information on the
objects that this happens for would be very helpful.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 11e716ae0736067272868b997367e94ebf1cdf3b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Apr 2 15:36:47 2013 +1100
dsdb-schema: Print clear debug message when we find a OID in our local DB we cannot convert
We need to work out why we are unable to make a mapping for an OID in our database, because
we should not have been able to add it without such a mapping.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 25402e06bcdf98e346fdbbfa7e8740504329b42f
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Mar 26 11:51:38 2013 +1100
dsdb-repl: Allow the name attribute (and name-based schema lookups) to be skipped in dsdb_repl_make_working_schema()
This allows us to use a schema that may only be valid for attributeID based lookups, during the schema load.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 34820602715cc8936179091e188993f7a42808ac
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Apr 14 14:36:08 2013 +1000
python-samba-tool domain classicupgrade: Use transactions when adding users/groups/members
This should make things a bit faster when importing very large numbers of users
as we will not constantly rewrite the indicies on disk.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit ef895fe9e4e4043bd4ce1db5007fd2016f0b8673
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Apr 14 13:32:05 2013 +1000
samba-tool dbcheck: Use dsdb.DS_GUID_DELETED_OBJECTS_CONTAINER rather than the literal value
This is better practice.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 9c5756c077896e6a3ff8e610acf706f203e4dede
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Apr 11 18:13:16 2013 +1000
python-samba-tool domain classicupgrade: Correct message about re-promoting BDCs
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 1165776d861e8e4f2fe26dcaf1e9dabdcc0a4179
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Apr 11 17:21:33 2013 +1000
pdb_ldap: Do not skip accounts without a sambaAcctFlags value
We allow this to mean a sambaAcctFlags value of zero in other parts of the code
and by allowing these users to show up in a search, we can read and correct them
during the classicupgrade, rather than not know they exist at all.
Most parts of the code do not look for ACB_NORMAL, which is why
these users appear to work.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 2c047198caccea30e8583dda869d513913fe1702
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Apr 11 09:33:16 2013 +1000
python-samba-tool domain classicupgrade: Actually Skip domain trust accounts
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 2e1f14355c162dde0190ac2cb105a34607134e02
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Apr 11 09:32:13 2013 +1000
python-samba-tool domain classicupgrade: Skip machine accounts that do not end in $
These accounts will not work anyway, as all the domain member lookup code in netlogon expects the $.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 20445415307ae3d6524995d0128862dcbc119684
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 8 12:59:05 2013 +1200
build: Do not set PATH in install_with_python now we set $PYTHON
This will ensure that the scripts get rewritten to use this specific python, as it
will not be found in the path by the waf scripts.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 10f6926aaa6a8c49b29e183d12f6f767072ecff7
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu May 2 16:29:21 2013 +1200
s3-rpc_server: Ensure we are root when starting and usiing gensec
This fixes bug 9465.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 9430310dc3adaf98dbff494a1056e02f8750c41d
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Apr 29 10:00:04 2013 +1000
gensec: Make the no-hostname status message much less scary
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 768c3bb16ae8aac2d96d4fa0d8a7593fc9be6ca8
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Apr 26 16:44:00 2013 +1000
build: Blacklist the release-4-0-0 provision as well
This reduces the size of the published tarball while ensuring we test with it
during autobuild.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 46e98cf20b04f3668e96fb597a414d0b39d5b1ed
Author: Kai Blin <kai at samba.org>
Date: Thu May 16 12:13:22 2013 +0200
dns: Fix allocation of txt_record in txt record tests
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-By: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Thu May 16 15:39:15 CEST 2013 on sn-devel-104
commit 223cf7fb3026daa1d383a2e5796cbfe8beecaac2
Author: Kai Blin <kai at samba.org>
Date: Mon Jan 14 00:56:48 2013 +0100
dns: more debug debug options in the tests
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-By: Amitay Isaacs <amitay at gmail.com>
commit 4364a3faf64fc9a022bc8870e2817573b94a4d0c
Author: Kai Blin <kai at samba.org>
Date: Mon Dec 10 05:50:05 2012 +1000
dns: Add support for MX queries
Due to an oversight, the internal DNS server supports MX record updates,
but not MX record queries. Add support for MX queries and tests.
This should fix bug #9485
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-By: Amitay Isaacs <amitay at gmail.com>
commit 2e9cf99bcef81d5e0b25221956a79e5f2fee1bf0
Author: Kai Blin <kai at samba.org>
Date: Mon Jan 14 00:55:37 2013 +0100
dns: Also add a print-out for the out_packet
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-By: Amitay Isaacs <amitay at gmail.com>
commit f31bda67157c66bd9d7d108395610b514a54f28b
Author: Kai Blin <kai at samba.org>
Date: Mon Jan 14 01:14:29 2013 +0100
dns: Use new DNS debugclass in DNS server
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-By: Amitay Isaacs <amitay at gmail.com>
commit 4b010997486b059b90be1f69783a451f400d7df7
Author: Kai Blin <kai at samba.org>
Date: Mon Jan 14 01:13:47 2013 +0100
debug: Add debugclass for DNS server
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-By: Amitay Isaacs <amitay at gmail.com>
commit 51533eedd7fa162bf8113f1f551064c01741e40e
Author: Volker Lendecke <vl at samba.org>
Date: Tue May 7 10:17:26 2013 +0200
winbind4: Fix bug 9832 -- talloc use after free
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu May 16 13:37:41 CEST 2013 on sn-devel-104
commit 7ff3cbdabf8be6c323e1b5e9d68e0370d32f574e
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed May 15 18:24:42 2013 +0200
source4/winbind/wb_samba3_cmd.c: Fix typo in comment.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu May 16 07:49:24 CEST 2013 on sn-devel-104
commit b07d97d7f5ab61da1cc5d228561230705ab32052
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed May 15 18:23:49 2013 +0200
source4/dsdb/schema/schema_convert_to_ol.c: Fix typo in comment.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 7a06a93fdf7544dfa013a5f20d4eb6017ea345ee
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed May 15 18:22:39 2013 +0200
source4/dsdb/samdb/ldb_modules/local_password.c: Fix typo in comment.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 30be42073a636da389789ee20e1e25b8b4079e0a
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed May 15 18:21:52 2013 +0200
source4/auth/kerberos/kerberos-notes.txt: Fix typo.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit bf26c7ef402ed231e05e4ced169ff1c6b00ced00
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed May 15 18:20:42 2013 +0200
source4/TODO: Fix typo.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8673d0d16b68bf403b18aa29f502b36c9bbc2ab1
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed May 15 18:19:36 2013 +0200
source3/utils/ntlm_auth.c: Fix typo in debug message.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit dcbe45b945ce16b58173c78ac22958d51f53c890
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed May 15 18:18:07 2013 +0200
source3/modules/vfs_catia.c: Fix typo in comment.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c2ab0ad8d05cf3002b1efd200960eff9a91ec3f4
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed May 15 18:16:51 2013 +0200
source3/libsmb/ntlmssp.c: Fix typo.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 948ef97f08dc329c75a5061f86a653d227e654c1
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed May 15 18:16:03 2013 +0200
samba_tool/base.py: Fix typo.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 86a58b01e0cd2f05b3767789bedd27d185421d52
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed May 15 18:15:18 2013 +0200
netcmd/group.py: Fix typo.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 618fd8e4de6c1a7847798c05bf0e82a7e5ac07e0
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed May 15 18:13:44 2013 +0200
Wireshark/Conformance.pm: Fix typo.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6175c277ec74f1ced5715e577201ec44bbcc467a
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed May 15 18:12:52 2013 +0200
pidl/TODO: Fix typo.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b82d3346feb4ab8f18711b95157d0c6030ed318b
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed May 15 18:11:10 2013 +0200
lib/testtools/testtools/tests/test_testresult.py: Fix typos.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 70aec093a9008502934749dfabc378345b55d3ff
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed May 15 18:09:51 2013 +0200
lib/subunit/README: Fix typo.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8961ca8c367e23e2934940c516c49a6a7dd5086b
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed May 15 18:08:51 2013 +0200
docs-xml: Fix typo in vfs_smb_traffic_analyzer.8.xml.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 26b6e280822f7a351a37cad98004fa0b49208df6
Author: Volker Lendecke <vl at samba.org>
Date: Sat May 11 10:36:12 2013 +0200
gensec: Make gensec_security_oids_from_ops static
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed May 15 20:05:34 CEST 2013 on sn-devel-104
commit 85220eaa9cbd574d29cc7cab54854c5e29778ff1
Author: Volker Lendecke <vl at samba.org>
Date: Sat May 11 10:35:59 2013 +0200
gensec: Make gensec_security_by_sasl_list static
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit eb6ebe689faa08a941bd22929ab2e3f932deee85
Author: Volker Lendecke <vl at samba.org>
Date: Sat May 11 10:35:33 2013 +0200
gensec: Make gensec_interface_version public
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit fbb12b574df69a1cda0a3f201f21279650ddc4c4
Author: Matthieu Patou <mat at matws.net>
Date: Tue May 14 06:20:18 2013 -0700
samba-tool/tests: Force the gecos of the user to a fixed value.
When --gecos is not specified samba-tool user add will try to read the
gecos field from a getpw call. And if user's GECOS is empty (like the
build user on sn-devel-104) then the test will fail because we can't add
an empty gecos.
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Wed May 15 16:19:23 CEST 2013 on sn-devel-104
commit 54f4536980d86faf532708c92890dd9e8b09667a
Author: Matthieu Patou <mat at matws.net>
Date: Wed May 15 04:46:33 2013 -0700
dsdb-drepl: create a new schedulable event for running pending operations
So instead of running dreplsrv_periodic_schedule when receiving a
DRS_REPLICA_SYNC request which will force the DC to look for changes
with all the DC it usually replicate to, we reduce it to the DC
specified in the DRS_REPLICA_SYNC request. It will allow also to do have the
correct options as set by the client who send the DRS_REPLICA_SYNC.
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 8c3fa009ca6e80bf6e8f9daf786b3ec490c735af
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Apr 29 12:27:25 2013 +0200
lib/param: remove unused 'printer_admin'
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue May 14 21:45:19 CEST 2013 on sn-devel-104
commit 0ffd074690529a1833e29829b552b3cf6ebcd914
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Apr 30 08:39:00 2013 +0200
doc-xml/smbdotconf: fix server [min|max] protocol documentation
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 8a878ec74bd24180aa73cfb39ff4a6c3e72d9d0b
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue May 7 14:15:35 2013 +0200
talloc: only provide the --enable-talloc-compat1 in standalone build
The compat library is already only built in standalone build,
so we need the configure option also only in the standalone build.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f08205be7003f6c0a15fd5fd99d01951164ad15c
Author: Björn Jacke <bj at sernet.de>
Date: Tue May 14 16:51:28 2013 +0200
winbind/idmap_ad: be verbose about the user that we fail to map
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 5868accc71e15e27aef6fb74036a3f1f439200b8
Author: Volker Lendecke <vl at samba.org>
Date: Tue May 14 15:43:10 2013 +0200
vfs_gpfs: slightly simplify connect()
DISCONNECT can be arbitrarily complex, TALLOC_FREE of a simple struct
is easier.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Tue May 14 18:11:29 CEST 2013 on sn-devel-104
commit 6c5158e3de26cd6e911f740a1c36789d77ea1c70
Author: Shekhar Amlekar <samlekar at in.ibm.com>
Date: Tue May 7 17:58:16 2013 +0530
s3:rpc_server/srvsvc check access before doing work
Before doing the (potentially) costly enumerations,
check if the user has necessary privileges first
Signed-off-by: Shekhar Amlekar <samlekar at in.ibm.com>
Reviewed-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Christian Ambach <ambi at samba.org>
Autobuild-Date(master): Tue May 14 16:22:24 CEST 2013 on sn-devel-104
commit 1cd20441a76bde78196124b925a67183614103d8
Author: Volker Lendecke <vl at samba.org>
Date: Sat May 11 10:51:22 2013 +0200
torture: Remove some unused code
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 11f467d0bd8e2264f311d82f3299443b99526bb3
Author: Christian Ambach <ambi at samba.org>
Date: Sat May 11 00:45:15 2013 +0200
tdb: include information about hash function being used in tdbtool info output
makes it possible to easily determine if the tdb under examination
uses jenkins hash or not
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 7d8a1b1e0496a15872feedff06da8d762ded4246
Author: Volker Lendecke <vl at samba.org>
Date: Tue May 14 10:52:33 2013 +0200
smbd: Remove a pointless variable
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Tue May 14 13:19:44 CEST 2013 on sn-devel-104
commit 3fda85276b9a3b3df6c5f1341dd586606deacfb1
Author: Matthieu Patou <mat at matws.net>
Date: Mon May 6 00:58:28 2013 -0700
selftests-drs: make our generated class subclass of classschema
Without this change objectclass=["top", "classSchema", "Foobar"] will
not be sorted correctly and will generated an error saying that class
Foobar is unreleated to classSchema (which is not true). It's mimicing what
other classes of the default schema are doing (ie. contact)
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue May 14 07:07:19 CEST 2013 on sn-devel-104
commit 33b54799a61eb6873eaeea2e7853f1314d8e6eee
Author: Matthieu Patou <mat at matws.net>
Date: Mon May 13 09:16:24 2013 -0700
Export PROMOTED_DC related variable
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 2bdf2c56cc1f7635441cf3b13d94941157b047f8
Author: Matthieu Patou <mat at matws.net>
Date: Mon May 6 01:09:05 2013 -0700
dsdb: make the name of non related class more obvious
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit fde1757f800ee661aa3e5133fed7c910dcb4163e
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue May 14 09:23:33 2013 +1200
build: Add missing dep from vfs_nfs4acl_xattr to NDR_NFS4ACL
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Tue May 14 01:23:17 CEST 2013 on sn-devel-104
commit 09d3f577c803dc22531eb9d74d08b16eedbe84f0
Author: Volker Lendecke <vl at samba.org>
Date: Sun May 12 12:47:39 2013 +0200
lib: Fix CID 241650 Sizeof not portable
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ira Cooper <ira at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Sun May 12 17:44:55 CEST 2013 on sn-devel-104
commit 7027c6aca96ce4eb4b6a4207f206d7b85eae7c56
Author: Volker Lendecke <vl at samba.org>
Date: Sun May 12 12:44:41 2013 +0200
pthreadpool: Fix CID 710828 Sizeof not portable
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ira Cooper <ira at samba.org>
commit 8b3d4eff9342de812d0d27759beeff5e4e7532d1
Author: Volker Lendecke <vl at samba.org>
Date: Sun May 12 12:33:49 2013 +0200
dbwrap: Fix CID 1002092 Uninitialized scalar variable
We don't set saved_errno in the ret==0 case.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ira Cooper <ira at samba.org>
commit 3b3b5b02555572e48a751ea19ef9dd771a3862da
Author: Björn Baumbach <bb at sernet.de>
Date: Wed May 8 10:27:26 2013 +0200
docs: smb.conf: fix max read/write/trans default values (bug #9871)
Commit 6d128aac119d948f0ecb0dcf6b400b4eb4027fe6 has increased the limit:
"s3:smb2_server increase defaults for read/write/trans sizes to 1MB"
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri May 10 23:14:50 CEST 2013 on sn-devel-104
commit 392b01f53c73e10c596a435040225766a188cda1
Author: Christian Ambach <ambi at samba.org>
Date: Mon May 6 19:00:29 2013 +0200
s4:torture fix a build break on AIX
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu May 9 08:05:12 CEST 2013 on sn-devel-104
commit e0ca7c4cff49f39559531aafb892fdf95ddfc2ce
Author: Christian Ambach <ambi at samba.org>
Date: Mon May 6 16:56:09 2013 +0000
s3:modules/vfs_aixacl2 fix compile errors
fix various compile errors that were introduced with latest ACL changes
Signed-off-by: Christian Ambach <ambi at samba.org>
Pair-Programmed-With: Alexander Werth <alexander.werth at de.ibm.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c1c9b99054f28f9c10f79a2bbc95be9864270705
Author: Jeremy Allison <jra at samba.org>
Date: Tue May 7 14:04:24 2013 -0700
Fix missing TALLOC_FREE of stackframes.
Signed-off-by: Jeremy Allison <jra at samba.org>
commit fb1847f41cf3d7ef45d8df9a61720305aea965d9
Author: Jeremy Allison <jra at samba.org>
Date: Tue May 7 13:58:26 2013 -0700
Tidy up old bool usage. False -> false, True -> true.
Signed-off-by: Jeremy Allison <jra at samba.org>
commit 00cb6354cfe007e4c0c25a508ce5008f9a69e5d2
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Apr 28 18:20:04 2013 +1000
vfs: Allow CREATOR GROUP to be used with vfs_zfsacl
The solaris acl() code requires that both ACE_GROUP|ACE_IDENTIFIER_GROUP be
set to indicate the @group permissions.
Otherwise, it would return Invalid Paramter to clients.
Andrew Bartlett
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6fa3f7d0f4f5de8b6ef85fa729e0a572b831a738
Author: Alexander Werth <alexander.werth at de.ibm.com>
Date: Sun Apr 28 19:06:59 2013 +0200
s4-smbtorture: Run tests for nfs4:modes simple and special.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 381812e9f62a7cf66cdd9e08460890b149e4773e
Author: Alexander Werth <alexander.werth at de.ibm.com>
Date: Fri May 3 05:46:25 2013 +0200
s3: Update vfs_gpfs man page with new nfs4:mode help text.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit dae5f1943e321f3ba9c8b25a0d49a7323eeae25d
Author: Alexander Werth <alexander.werth at de.ibm.com>
Date: Thu May 2 17:45:23 2013 +0200
s3: Update README.nfs4acls.txt
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a9f75bd3b7e86090eb95ae3d9c3dce787befcfc1
Author: Alexander Werth <alexander.werth at de.ibm.com>
Date: Thu May 2 16:53:35 2013 +0200
s3: Use mode bits in some cases in mode simple.
Non inheriting ACL entries will show mode bits.
With this an file owner change does affect the effective ACL because
the special owner acl will now refer to the new owner.
This could be fixed by updating the ACL on a file owner change.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit ec138b2f8218a9b13dac06c66d208bf27f0cb78b
Author: Alexander Werth <alexander.werth at de.ibm.com>
Date: Thu May 2 16:50:55 2013 +0200
s3: Add changes that keep nfs4:mode special behavior.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 877f833af4a03116daa76e6317a0675b24be972c
Author: Alexander Werth <alexander.werth at de.ibm.com>
Date: Thu May 10 14:19:41 2012 +0200
s3: Mapping of cifs creator owner to nfs owner@ ace.
This is ignored in nfs4mode special for compatibility.
Also ensure that we drop non inheriting creator owner
aces since these don't contribute to who can access
a file.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 83774a8bc23e59837181bc155d90b162008c6407
Author: Alexander Werth <alexander.werth at de.ibm.com>
Date: Wed Apr 25 15:10:20 2012 +0200
s3: Mapping of special entries to creator owner in mode simple.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 4a3bf4dd9b0034d910d12642ddb52f99fda44628
Author: Alexander Werth <alexander.werth at de.ibm.com>
Date: Thu Jul 26 17:29:12 2012 +0200
s3: Add params parameter to smbacl4_nfs42win function.
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 7978fe25846ef2d61dc694dcb96085fbda6d038f
Author: Alexander Werth <alexander.werth at de.ibm.com>
Date: Thu Jul 26 17:11:03 2012 +0200
s3: Change smbacl4_get_vfs_params to use connection_struct instead of fsp.
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit be0e2692461831dada5f5a497189a81e409e88f0
Author: Alexander Werth <alexander.werth at de.ibm.com>
Date: Mon Apr 15 16:08:46 2013 +0200
s3: Move up declaration of params struct and related function.
We need the parameters earlier in the code so we move up
the declaration of the params struct. Since reading the
parameters is closely related the definition of the function
smbacl4_get_vfs_params has also been moved up.
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 9018aa82c7c8cf02950bb03e9075d1243f65c6e0
Author: Alexander Werth <alexander.werth at de.ibm.com>
Date: Thu Apr 18 14:12:34 2013 +0200
s4-smbtorture: Set result message when failing the inheritance test.
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 97eb8f73e5d106781344895d3bb02767b0ac5c94
Author: Alexander Werth <alexander.werth at de.ibm.com>
Date: Tue Apr 16 14:11:27 2013 +0200
vfs: Add inheritance emulation to vfs_nfs4acl_xattr.
Recursively inherit ACL from parent directory if no acl xattr is
found on the current file.
Use a default ACL if a non-inheriting ACL is encountered.
With this the nfs4acl_xattr.dynamic test passes.
But the nfs4acl_xattr.inheritance test results in an error because
of warnings that cause the test to pass a failed result.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit fe8a1fcda792ee38faaadf1da2905b62302ce3e1
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Apr 14 20:04:45 2013 +1000
selftest: Run raw.acls test against the nfs4acl_xattr module
This is the first time we have tested the NFSv4 ACL mapping code.
Sadly most tests fail but these can be fixed from here.
This at least shows that the code does not segfault.
Andrew Bartlett
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 7874a431541e10a1846fe3732568496b2b753de1
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Apr 14 19:51:42 2013 +1000
librpc: Add special owner/group/other constants to nfs4acl.idl
As per nfs4acl-0.9/lib/nfs4acl.c (the package where this structure is originally defined)
Andrew Bartlett
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a0d16850393f59fef4883fb5fa6c97ec4b2af2c2
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed May 8 18:30:30 2013 +1200
build: Add vfs_nfs4acl to the autoconf build
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 76969abba0453b232274520182c0c2cdfab93428
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Apr 14 20:06:57 2013 +1000
vfs: Add new VFS module vfs_nfs4acl_xattr to use nfs4acl.idl
This uses the xattr format used by the patches at http://users.suse.com/~agruen/nfs4acl/
Andrew Bartlett
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5d517f41664920faa5863cbf36b5953ad4700ebd
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Apr 14 19:22:37 2013 +1000
vfs: Remove unused security_info argument in vfz_zfsacl.c
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 188d0f097572955f643d926edf40e6841b874c1e
Author: Alexander Werth <alexander.werth at de.ibm.com>
Date: Mon Apr 15 16:35:36 2013 +0200
vfs: Fix compile of vfs_gpfs.c.
Since the smb4acl is now correctly allocated on mem_ctx and not
the talloc stack frame we can free the stack frame correctly.
And the chmod emulation code now needs the vfs handle since
that is now required by the callback function to set the smb4acl.
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a65568750be92439de26dd2ecb88c09468264fe7
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Apr 14 18:13:42 2013 +1000
vfs: Allocate SMB4ACL_T on an explict memory context
This ensures the caller knows exactly what the memory lifetime of this
returned object is. This makes the NFSv4 ACL code consistent with the
POSIX and NT ACL code, to avoid supprising developers who have worked
on those other parts of the ACL code.
Most of this patch is adding a memory context to the callers and passing it in.
Andrew Bartlett
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 67bb7d93ba8fccd030bd8d01536f3222c85134b7
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Apr 14 17:31:42 2013 +1000
vfs: Add vfs_handle_struct argument to smb_set_nt_acl_nfs4 and the callback
This allows the callback to call xattr based storage functions that need this argument.
Andrew Bartlett
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d87b81fa303ee297685f4eb5599010901ed68145
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Apr 12 20:24:44 2013 +1000
build: Move nfs4acl to the top level
This is to create IDL-stored NFSv4 ACLs, just as we use for posix ACLs
to permit better testing.
Andrew Bartlett
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 41f1c3969a3f381379ca665b2d992070c8e50227
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed May 8 10:21:15 2013 +0200
pidl:NDR/Parser: correctly set $ndr->[relative_highest_]offset for relative_short pointers
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed May 8 20:49:55 CEST 2013 on sn-devel-104
commit 5732c6840350f18dd779d5a088bc825a9d1b4069
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed May 8 10:18:54 2013 +0200
Revert "Remove a bunch of "unused variable _relative_save_offset" warnings."
This reverts commit fa5898b6de797431d5ae9d2ce6dcddcb35a60b66.
This is the wrong fix for the warnings, the correct fix will follow.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit fa5898b6de797431d5ae9d2ce6dcddcb35a60b66
Author: Jeremy Allison <jra at samba.org>
Date: Tue May 7 17:07:10 2013 -0700
Remove a bunch of "unused variable _relative_save_offset" warnings.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
Autobuild-User(master): Richard Sharpe <sharpe at samba.org>
Autobuild-Date(master): Wed May 8 07:47:45 CEST 2013 on sn-devel-104
commit 76bffc27a3f9ad6ac6b8ff8e21f801012835b73d
Author: Richard Sharpe <realrichardsharpe at gmail.com>
Date: Thu May 2 14:36:05 2013 -0700
Tests processing an oplock break within a compound SMB2 request.
Signed-off-by: Richard Sharpe <realrichardsharpe at gmail.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Richard Sharpe <sharpe at samba.org>
Autobuild-Date(master): Tue May 7 19:45:36 CEST 2013 on sn-devel-104
commit cbff4885508e050bcb91c0faccb26941de5c1e1d
Author: Jeremy Allison <jra at samba.org>
Date: Thu May 2 14:16:22 2013 -0700
Remove the compound_related_in_progress state from the smb2 global state.
And also remove the restriction that we can't read a new
request whilst we're in this state.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe at samba.org>
commit 10cbcfd167a4d7b1a22f9b42b684a66e424cbede
Author: Jeremy Allison <jra at samba.org>
Date: Thu May 2 13:55:53 2013 -0700
The core of the fix to allow opens to go async inside a compound request.
This is only allowed for opens that cause an oplock break, otherwise it
is not allowed. See [MS-SMB2].pdf note <194> on Section 3.3.5.2.7.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
commit 1102e73832f78ca5decc928d6c3649d4fe68eab7
Author: Jeremy Allison <jra at samba.org>
Date: Thu May 2 13:08:16 2013 -0700
Move a variable into the area of code where it's used.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
commit a026fc6b699719309a27d4646d06fe1a45b0d158
Author: Jeremy Allison <jra at samba.org>
Date: Thu May 2 12:34:54 2013 -0700
Ensure we don't try and cancel anything that is in a compound-related request.
Too hard to deal with splitting off the replies.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
commit 4111fcfd4f570d39d46a0d414546ca62c7b609be
Author: Jeremy Allison <jra at samba.org>
Date: Thu May 2 11:12:47 2013 -0700
Only do the 1 second delay for sharing violations for SMB1, not SMB2.
Match Windows behavior.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
commit 637887c0795241872974c09838829b49d5994b10
Author: Volker Lendecke <vl at samba.org>
Date: Tue May 7 15:07:34 2013 +0200
Makefile: Fix bug 9868 - Don't know how to make LIBNDR_PREG_OBJ.
Thanks to Lucs for finding the issue
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Tue May 7 17:57:57 CEST 2013 on sn-devel-104
commit 8c1283a89f746a108e8014b6fbc9a58a371950cf
Author: Volker Lendecke <vl at samba.org>
Date: Tue May 7 12:39:16 2013 +0200
winbind: Fix bug 9854 -- NULL pointer dereference
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue May 7 14:49:07 CEST 2013 on sn-devel-104
commit 8ca4b7597d91355c4885b8ab89b0996c98f5c805
Author: Jeremy Allison <jra at samba.org>
Date: Mon May 6 14:10:58 2013 -0700
Fix up the man pages to explain that "store dos attributes" overrides them.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue May 7 01:24:54 CEST 2013 on sn-devel-104
commit d25ba3f5a6266c2787ab2cc6b17e0d3cde2e33a9
Author: Jeremy Allison <jra at samba.org>
Date: Mon May 6 14:10:15 2013 -0700
Allow "store dos attributes" to override the other "map XXX" parameters.
Makes us consistent with what is described in the man pages.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 9f36d0c447b2107798e560ce257026318952c5e2
Author: Michael Adam <obnox at samba.org>
Date: Mon May 6 13:16:49 2013 +0200
build: default --with-regedit to "auto" instead of "yes"
This means we don't build regedit when there is no ncurses
and this is not an error for the overall build.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Kai Blin <kai at samba.org>
Autobuild-User(master): Kai Blin <kai at samba.org>
Autobuild-Date(master): Mon May 6 20:11:09 CEST 2013 on sn-devel-104
commit 431eeef9311a8e172dc782bc91492c94cc5fcde7
Author: Michael Adam <obnox at samba.org>
Date: Mon May 6 14:14:02 2013 +0200
build: fix --with-regedit to properly honour the yes/no/auto scheme
I.e. fail configure when ncurses support is not found but
regedit build was requested.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Kai Blin <kai at samba.org>
commit 356b825838cd97cc43aaa4b108267d1bd5f16ca1
Author: Michael Adam <obnox at samba.org>
Date: Mon May 6 13:19:24 2013 +0200
build: simplify ncurses checks: --with-regedit does not take a path list
--with-regedit is defined using SAMBA3_ADD_OPTION(), and can hence
take the values "yes", "no", and "auto". So it is not possible to
hand in paths to look for ncurses-config via this option.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Kai Blin <kai at samba.org>
commit 8d34f2fe1e219a0be28bc6b8ce9f93620d39a5b2
Author: Michael Adam <obnox at samba.org>
Date: Fri Apr 26 01:06:58 2013 +0200
docs: update the description of the formulas in the idmap_autorid manpage
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
Autobuild-User(master): Christian Ambach <ambi at samba.org>
Autobuild-Date(master): Mon May 6 18:23:56 CEST 2013 on sn-devel-104
commit 7bc9563c96c0b91628ec501f8226c1adc24d083d
Author: Michael Adam <obnox at samba.org>
Date: Fri Apr 26 00:52:49 2013 +0200
s3:idmap:autorid: add a comment block explaining the calculations
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 9c6594dadbdd800470d4b217f1351fbba87989ba
Author: Michael Adam <obnox at samba.org>
Date: Thu Apr 25 20:24:36 2013 +0200
s3:idmap:autorid: simplify the id->sid calculation
To make it more intutive.
rid = reduced_rid + domain_range_index * range_size
where
reduced_rid = (id - id_low) % range_size
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 7b9a567b8943e0c3d0b6fa97bea72f1b89aea4ab
Author: Michael Adam <obnox at samba.org>
Date: Thu Apr 25 20:12:39 2013 +0200
s3:idmap:autorid: calculate the range's low_id in idmap_autorid_get_domainrange()
This way, the calculation needs to be don only in one central place and
the formulas get simpler.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 30a27ba428f346ff2fd56f9727ce0f1fb18a5a41
Author: Michael Adam <obnox at samba.org>
Date: Thu Apr 25 19:47:00 2013 +0200
s3:idmap:autorid: make calculation in idmap_autorid_sid_to_id much more obvious
This is my attempt to make the sid->unix-id calculation much more obvious.
Especially with the introduction of the multi-range support an the originally
named "multiplier", the calculation
id = low_id + range_size * domain_number + rid - range_size * multiplier
was rather opaque to me.
What really happens here is this:
The rid is split into a reduced_rid part that is < rangesize and
a multiple of rangesize. This is given by the formula
rid = rid % range_size + (rid / range_size) * range_size
We define
reduced_rid := rid % range_size
and
domain_range_index := rid / range_size ( == the original multiplier)
and the original formula is equivalent to:
id = reduced_rid + low_id + range_number * range_size;
and reads
id = reduced_rid + range_minvalue
if we set range_minvalue := low_id + range_number * range_size.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit a0ea6c2536b6b07f2fee799518b5f84da36e53ba
Author: Michael Adam <obnox at samba.org>
Date: Thu Apr 25 19:18:27 2013 +0200
s3:idmap:autorid: rename range.multiplier to domain_range_index
The name multiplier is very confusing (at least for me).
This is an index that is used to reference the various
per-domain ranges.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 196aa1dea76b894ebdcf4322bb52edeac57d68ce
Author: Michael Adam <obnox at samba.org>
Date: Thu Apr 25 19:13:45 2013 +0200
s3:idmap:autorid: rename autorid_range_config.sid to domsid, along with instances
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 2a258747b6ec67e9e5d4aa97ffeeabeab0e94d6c
Author: Michael Adam <obnox at samba.org>
Date: Thu Apr 25 19:04:56 2013 +0200
s3:idmap:autorid: rename autorid_domain_config --> autorid_range_config and instances to "range"
This describes it better with the new support for multiple ranges for domains.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 11b9b7d051575ff5b398c240bd33dadac9c4ed81
Author: Michael Adam <obnox at samba.org>
Date: Thu Apr 25 13:56:03 2013 +0200
s3:idmap:autorid: rename domainnum to rangenum
Now ranges don't correspond to domains any more, but
multiple ranges are associated to a domain. So the name
is misleading.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 5190e4da2b51fdfa6df452a23127add5059cc4ac
Author: Abhidnya Joshi <achirmul at in.ibm.com>
Date: Tue Apr 16 16:41:45 2013 +0530
docs-xml: manpage update for autorid multirange support
Signed-off-by: Abhidnya Joshi <achirmul at in.ibm.com>
Reviewed-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit b384c55bf3fa230a945f36c493427f2341051cd1
Author: Abhidnya Joshi <achirmul at in.ibm.com>
Date: Wed Apr 10 16:26:07 2013 +0530
s3:winbindd/autorid multiple range support
when a mapping request for a RID comes in that is larger
than the rangesize, allocate an extension range to be able
to map this one
This is especially important for large installations which
might have large RIDs being used in a trusted domain that
the administrator was not aware of when planning for autorid
usage and so those objects could not be mapped up to now.
As it is not possible to change the rangesize after the first
start of autorid, this would lead to big trouble.
Signed-off-by: Abhidnya Joshi <achirmul at in.ibm.com>
Reviewed-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e0a0280c4fcf85f28b488d3868be38123910271c
Author: Christian Ambach <ambi at samba.org>
Date: Tue Apr 16 12:39:55 2013 +0200
s3:utils fix wrong usage of PRIu64 in sscanf
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 24ce31a33ff15b11e5c5024b911637a46bbd59ea
Author: Christian Ambach <ambi at samba.org>
Date: Tue Apr 16 12:39:39 2013 +0200
s3:lib fix wrong usage of PRIu64 in sscanf
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit a4cc41d4d0ef42915694e10cd819462523b92a3b
Author: Christian Ambach <ambi at samba.org>
Date: Tue Apr 16 10:56:29 2013 +0200
lib/replace: add SCNx macros
we already have PRI*, but the corresponding SCN* were missing
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit d68e676cacdcd346f0555c80a3389f50079d2e4f
Author: Christian Ambach <ambi at samba.org>
Date: Tue Apr 9 23:10:16 2013 +0200
lib/replace: prefer inttypes.h over stdint.h
according to C99 7.8, inttypes.h should include stdint.h so prefer inttypes.h
and fall back to stdint.h (and our own definitions of PRI*) only when inttypes.h
could not be found
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit bbf62213efb0b77388aff1f5feb852414e1128a2
Author: Matthieu Patou <mat at matws.net>
Date: Sun May 5 15:37:58 2013 -0700
selftest: do not run doc tests if we don't build manpages
if XSLTPROC_MANPAGES is not set then manpages won't be built so there is
no sense trying to test it.
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon May 6 12:53:37 CEST 2013 on sn-devel-104
commit fffbdf01fa6a74e6da70815607a1c22b9b6ebcdb
Author: Matthieu Patou <mat at matws.net>
Date: Sun May 5 15:37:00 2013 -0700
selftest: Output error when samba_tool user command fails
It should help to debug why is it failing on some hosts in the build
farm (ie. sn-devel)
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 1160b699cb73cc466163504ebb7299912f10cd9b
Author: Matthieu Patou <mat at matws.net>
Date: Sun May 5 15:05:37 2013 -0700
configure: print a message when docbook.xsl is missing localy
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 99c95fc98309a7aa08cfc37c4de5105d90696b7a
Author: Matthieu Patou <mat at matws.net>
Date: Sun May 5 14:53:40 2013 -0700
libsmb: call directly tevent_req_simple_finish_ntstatus
The CC compiler on openindiana is not pleased with a void function doing
a return of another void function.
It should help the build of openindiana on the buildfarm
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Mon May 6 08:35:10 CEST 2013 on sn-devel-104
commit bf332392e15e4a2b8799101e3ddae194dca36d13
Author: Jeremy Allison <jra at samba.org>
Date: Fri May 3 10:06:39 2013 -0700
Fix warnings and one compile error caused by newer gcc 4.7.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Sun May 5 19:01:38 CEST 2013 on sn-devel-104
commit 0a2910152aaafa1c7d484f8a0ade869d7962d4e3
Author: Volker Lendecke <vl at samba.org>
Date: Fri May 3 10:28:59 2013 +0000
idmap: Store negative cache entries if the backend fails
This changes the behaviour for out-of-range queries: The tdb backend
(probably all backends) returns NT_STATUS_NONE_MAPPED and does not set the
map.status value to ID_UNMAPPED. This means that we did an early error
exit, not setting a negative cache value. This makes smbd ask winbind
over and over again for out-of-range gids, which can be a performance
problem in certain scenarios.
The new code makes us fall through to the code setting the negative
cache entry in all cases.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Fri May 3 14:48:35 CEST 2013 on sn-devel-104
commit 1966e28d157da3ef561a6e760eb4736e917fdd81
Author: Volker Lendecke <vl at samba.org>
Date: Fri May 3 10:24:17 2013 +0000
idmap: Print error from idmap_backends_unixid_to_sid
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 5f82641553e33bc236b6c8a4f5cfc1cf3b722eea
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 25 14:24:08 2013 +0200
libsmb: Use sizeof instead of explicit numbers
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Apr 30 16:02:19 CEST 2013 on sn-devel-104
commit b8c1e30a6f2213c0dbb43a55bd5e1f498a610cab
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 25 14:19:36 2013 +0200
libsmb: Use smb2_lease_push in smb2_create_send
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit a8edad3743a60b9521b2cd759e22e6350c41cc06
Author: Volker Lendecke <vl at samba.org>
Date: Wed Apr 17 17:04:38 2013 +0200
libcli: Add smb2_lease marshalling
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 96a8f6e0fb9042fe125c9552dfb4c3f6d19cb225
Author: Volker Lendecke <vl at samba.org>
Date: Wed Apr 17 16:48:21 2013 +0200
libsmb: Move "struct smb2_lease" to common
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 7e807934e6550308efed814a20ce6d6dabbad557
Author: Anand Avati <avati at redhat.com>
Date: Mon Apr 29 15:21:00 2013 -0700
check_parent_exists() can change errno. Ensure we preserve it across calls.
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Tue Apr 30 11:00:11 CEST 2013 on sn-devel-104
commit c672ef11b1ed663b6366f321d3628acf05b3d0fe
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 29 18:40:08 2013 +0200
winbind4: Fix bug 9832 -- talloc use after free
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 08d7caedf0f549d6ca61dc939d94fc267d7d54d4
Author: Andreas Schneider <asn at samba.org>
Date: Fri Oct 26 19:52:08 2012 +0200
regedit: Use color only when available.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Mon Apr 29 15:02:19 CEST 2013 on sn-devel-104
commit 92b6fc0edebe5df103c305f2d5226ba37ad632e4
Author: Andreas Schneider <asn at samba.org>
Date: Fri Oct 26 19:21:50 2012 +0200
regedit: Improve the while loop.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 7b970e930ef97cef28c1d4b0a576d8f9bb4464e8
Author: Andreas Schneider <asn at samba.org>
Date: Fri Oct 26 18:46:29 2012 +0200
regedit: Remove talloc leak report.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 68d4e8dfc75fa788eae44e7f23ec866450792837
Author: C. Davis <cd.rattan at gmail.com>
Date: Sun Aug 19 20:09:53 2012 -0700
regedit: Mark string values if they contain unprintable chars.
Also, edit the values in bin mode to avoid screen glitches.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 8508b411b2ff69f59aa133ebd97e489d7c6c1626
Author: C. Davis <cd.rattan at gmail.com>
Date: Sun Aug 19 20:02:51 2012 -0700
regedit: Add an edit binary command.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 8ea38ce970d7539c25d4da08065d6bfa999f3e96
Author: C. Davis <cd.rattan at gmail.com>
Date: Sun Aug 19 19:11:16 2012 -0700
regedit: Handle zero-length buffers better with hexedit.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit ad15a83357dccc9a41ade1642cca24a0b7de92df
Author: C. Davis <cd.rattan at gmail.com>
Date: Sun Aug 19 18:29:06 2012 -0700
regedit: Load values on startup.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 1208167c77a58154c612dc2bd1655bd70ae994e8
Author: C. Davis <cd.rattan at gmail.com>
Date: Sun Aug 19 00:18:22 2012 -0700
regedit: Simplify the editor dialog input loop.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit d7d75fd311e6c8ebd799160411efe2a3ab3500c9
Author: C. Davis <cd.rattan at gmail.com>
Date: Sat Aug 18 23:44:59 2012 -0700
regedit: Fix white space and wrap long lines.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 384a593309d22c8d16315d362b8b6a8cfb425707
Author: C. Davis <cd.rattan at gmail.com>
Date: Fri Aug 17 19:03:12 2012 -0700
regedit: Add missing copyright headers to hexedit code.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 8982bf841d24ea0f5cf8d08b09ebf7ad8a4cdc3b
Author: C. Davis <cd.rattan at gmail.com>
Date: Fri Aug 17 03:06:20 2012 -0700
regedit: Enable using tab to cycle thru dialog buttons.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e8d6a33c830bf34733450c9d9a9cf792f1136c1a
Author: C. Davis <cd.rattan at gmail.com>
Date: Fri Aug 17 02:15:20 2012 -0700
regedit: Restore cursor position when user tabs to a field.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 9d0ccd1b4896396b0a83d6e767b145bcc3ab111f
Author: C. Davis <cd.rattan at gmail.com>
Date: Wed Aug 15 21:05:01 2012 -0700
regedit: Add a general help section.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e279aaff8df4fa1183e0427400eed79f9d9baf4a
Author: C. Davis <cd.rattan at gmail.com>
Date: Wed Aug 15 20:50:00 2012 -0700
regedit: Print help on left side of screen instead of the right.
This is little bit easier to read to my eye.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 2b6afa6aa426238d6a6d2d04cb7829e82b2b8bd0
Author: C. Davis <cd.rattan at gmail.com>
Date: Sun Aug 12 22:39:21 2012 -0700
regedit: Reduce magic numbers in edit dialog, clean up edit dialog creation.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e9645db344d4a8fcdca0eb447b273fff539d85df
Author: C. Davis <cd.rattan at gmail.com>
Date: Sun Aug 12 22:38:06 2012 -0700
regedit: Add help msgs for key and value sections at bottom of screen.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 77edcd4dbfee304ed39da134da0752d693250f98
Author: C. Davis <cd.rattan at gmail.com>
Date: Sat Aug 11 23:29:13 2012 -0700
regedit: Prefer copywin() over prefresh() for displaying path.
copywin() works better with panels, dialogs, etc.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit dc119eb9b2881c0f3cf92a0c77fe71411a6a1a13
Author: C. Davis <cd.rattan at gmail.com>
Date: Sat Aug 11 23:22:06 2012 -0700
regedit: Cut off the front of the path when screen width is too small.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 485af4a785e16b9a219363be50e996e50bca8f77
Author: C. Davis <cd.rattan at gmail.com>
Date: Sat Aug 11 22:10:51 2012 -0700
regedit: Uese a pad for path label.
This makes it easier scale the label on resize.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit a857475501591b6761d15ed933a9927abed23555
Author: C. Davis <cd.rattan at gmail.com>
Date: Sat Aug 11 15:00:55 2012 -0700
regedit: Improve padding for value summary.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 05dde2188fd81af17f1714aac35973df4b170354
Author: C. Davis <cd.rattan at gmail.com>
Date: Fri Aug 10 21:56:58 2012 -0700
regedit: Update dialog position on screen resize.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 58f9e368c8366bba103ae9214638cc4c99fe4caf
Author: C. Davis <cd.rattan at gmail.com>
Date: Fri Aug 10 20:05:20 2012 -0700
regedit: Handle term resizes.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 560003fcd98eb109dd8391c7975aae4ef277604b
Author: C. Davis <cd.rattan at gmail.com>
Date: Fri Aug 10 13:16:20 2012 -0700
regedit: Create subkeys.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 3344f5e3d568d607bdf354ed74dc473a612fbf9d
Author: C. Davis <cd.rattan at gmail.com>
Date: Thu Aug 9 18:14:42 2012 -0700
regedit: Delete and add keys.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 6ef5ee250c3b906d56413b213e1f18fe1ff3579f
Author: C. Davis <cd.rattan at gmail.com>
Date: Wed Aug 8 20:44:58 2012 -0700
regedit: Edit binary values with hexedit.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit ec6fb5d1ce75fa3746f473727f2533e629bdb136
Author: C. Davis <cd.rattan at gmail.com>
Date: Wed Aug 8 20:16:05 2012 -0700
regedit: Initialize hexedit buf with data if available.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 7c60ec12dec39ec63bf8246d478d9335a6451fb4
Author: C. Davis <cd.rattan at gmail.com>
Date: Wed Aug 8 20:06:13 2012 -0700
regedit:hexedit: make sure cursor is updated on physical screen.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f723fc9619fa7cf69888680731b4329832659ff4
Author: C. Davis <cd.rattan at gmail.com>
Date: Wed Aug 8 17:49:06 2012 -0700
regedit: Add an input dialog.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e4ed97f9b36a562815fe370c2b0b60105d7f5eba
Author: C. Davis <cd.rattan at gmail.com>
Date: Wed Aug 8 15:36:01 2012 -0700
regedit: Simplify notice dialogs, don't overwrite existing values.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 5cfbf7316c16c0205ff87f7980e05a2ab1671709
Author: C. Davis <cd.rattan at gmail.com>
Date: Wed Aug 8 14:37:20 2012 -0700
regedit: Don't pass empty value names to new_item().
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 360f31d52b30ef14e8a584f62ff61cc55c95ed53
Author: C. Davis <cd.rattan at gmail.com>
Date: Wed Aug 8 14:16:41 2012 -0700
regedit: Really delete value.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 3b6da775d30edcc44655d4eccca00dc71a1835bb
Author: C. Davis <cd.rattan at gmail.com>
Date: Wed Aug 8 12:09:03 2012 -0700
regedit: Add new value type selection dialog.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit af60882af4f34556b101d6735095014304620b2d
Author: C. Davis <cd.rattan at gmail.com>
Date: Tue Aug 7 23:41:50 2012 -0700
regedit: Save contents of value editor.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 14364997c75a7ea2b9f698f97421ed7227a3a5d7
Author: C. Davis <cd.rattan at gmail.com>
Date: Tue Aug 7 19:19:28 2012 -0700
regedit: Value editor changes.
* Handle tab and back-tab for navigating among sections of the
editor dialog.
* Read in REG_MULTI_SZ values into a multi-line form field.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit a43a9497b444c7a13437cf0701df009ef9ae8425
Author: C. Davis <cd.rattan at gmail.com>
Date: Mon Aug 6 19:18:56 2012 -0700
regedit: Don't refresh treeview and value list.
This is handled by update_panels() and doupdate() now.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit db5295a7dc61056092b43523409fd11b147e031d
Author: C. Davis <cd.rattan at gmail.com>
Date: Mon Aug 6 19:11:13 2012 -0700
regedit: Some work on dialogs.
* Make dialogs modal with a separate getch() loop to avoid extra
complexity keeping track of dialogs and getting the result.
* Start work on the value editor dialog.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 3c14ab13b19fd11f728d61b7f467b09c4e06fc02
Author: C. Davis <cd.rattan at gmail.com>
Date: Mon Aug 6 19:06:15 2012 -0700
regedit: Import hex editor.
This was tested separately editing files. It needs to be
connected to regedit's value editor.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit bdc40f909f5387698664d3e77dc530d2c2b68a93
Author: C. Davis <cd.rattan at gmail.com>
Date: Mon Aug 6 12:29:11 2012 -0700
regedit: Link to ncurses form library
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 4a87a7ab61ae965cef6a8ffe2d017d1e877cce74
Author: Andreas Schneider <asn at samba.org>
Date: Thu Aug 2 12:41:49 2012 +0200
regedit: Don't panic if we can't open the file.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 86f88ee7b074fc8193a445e0c8ece58c3058b6c3
Author: Andreas Schneider <asn at samba.org>
Date: Thu Aug 2 11:29:10 2012 +0200
waf: Create a better wscript for finding ncurses.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 5e0f4be8e2123ccf9f6beece95b187cd2676ff24
Author: C. Davis <cd.rattan at gmail.com>
Date: Fri Jul 27 18:39:54 2012 -0700
regedit: Improve calculation for centering dialogs.
Add some sanity checks to avoid crashing.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 6155abcf82f0bb03e62f7fc4b1df3f7260337bc3
Author: C. Davis <cd.rattan at gmail.com>
Date: Fri Jul 27 03:37:22 2012 -0700
regedit: Introduce dialog windows.
Link to ncurses "panels" library to support popup dialog
windows, and begin working on a small dialog library.
Right now, it is useful for "yes/no" confirmation popups,
but later it'll be used for more complex forms for editing
values.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 4267ec59feca258792e62aa2525b246599478fa8
Author: C. Davis <cd.rattan at gmail.com>
Date: Thu Jul 26 01:56:31 2012 -0700
regedit: Take into account that getch() may return a '\n' instead of KEY_ENTER.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 19b9a7063be9a0f74e7bb350542f9665e8ac060b
Author: C. Davis <cd.rattan at gmail.com>
Date: Tue Jul 24 04:12:56 2012 -0700
regedit: Use tab key to switch between key and value sections.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 0fb6cc01f32410cdc4ce0f5d69c886cd40f0256e
Author: C. Davis <cd.rattan at gmail.com>
Date: Tue Jul 24 03:10:45 2012 -0700
regedit: Don't overwrite the '/' when printing path.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 6d82438c63b4655f86985035ffd13b9507f6012b
Author: C. Davis <cd.rattan at gmail.com>
Date: Fri Jul 20 03:53:42 2012 -0700
regedit: Print value summary, fix heap corruption and path printing.
Added code to summarize value data. Also fixed a few bugs,
including some heap corruption found with valgrind.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e75057a906b6a7e275622ee1a97675d70ab61912
Author: C. Davis <cd.rattan at gmail.com>
Date: Wed Jul 18 02:31:41 2012 -0700
regedit: List values for the selected key.
Next step is to format a preview for the data and show that
next to the data type.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f751b36979aecca2189b1258fb8b454039c88cc6
Author: C. Davis <cd.rattan at gmail.com>
Date: Fri Jul 13 17:16:51 2012 -0700
regedit: Print the registry path.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 632cefa1da3e0ecda5932420cc551d40faa245af
Author: C. Davis <cd.rattan at gmail.com>
Date: Fri Jul 13 17:07:44 2012 -0700
regedit: Make all hives browsable.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 89d3067c22406d943555fcc7c41e7d57ddfbb152
Author: Michael Adam <obnox at samba.org>
Date: Fri Jul 13 10:57:02 2012 +0200
regedit: load the configuration after processing the command line
this way the "-s" parameter can change the config file to be loaded...
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit d3633c08cd5e997d329ff42930d320a8eb4ac7f2
Author: C. Davis <cd.rattan at gmail.com>
Date: Thu Jul 12 21:11:55 2012 -0700
regedit: Setup a test tree view of HKLM.
Expand on the former test by allowing the user to walk HKLM
with the tree view. Subkeys are loaded dynamically in memory
as the user walks the hierarchy with tree_node_load_children().
One issue with this at the moment is detecting if the
in-memory copy of the hierarchy is out of date.
TODO: figure out when to reload out of date portions of the
hierarchy (probably by checking last_modified_time).
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit c99675b813c9e7020f670542750320b9145b3096
Author: C. Davis <cd.rattan at gmail.com>
Date: Tue Jul 10 06:23:33 2012 -0700
regedit: Initial import of treeview code
Reviewed-by: Andreas Schneider <asn at samba.org>
commit dc0029c9463612d9fce6e19f04cf5d9aeed1b2d6
Author: C. Davis <cd.rattan at gmail.com>
Date: Tue Jul 10 06:16:35 2012 -0700
regedit: First crack at linking to ncurses.
First attempt of editing build scripts to link to ncurses
libraries. It seems to work, though checks may need to be
expanded upon.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 6c881e285b4a130bddd15f7d740e4c64a33e0de3
Author: C. Davis <cd.rattan at gmail.com>
Date: Fri Jul 6 03:08:17 2012 -0700
regedit: Add regedit main source file
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 44f7d1b67337684f2d65b32042900c200c5ae209
Author: C. Davis <cd.rattan at gmail.com>
Date: Fri Jul 6 02:57:55 2012 -0700
Support s3 local access with the s4 libregistry framework
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 1ac6bb1491e034f00be517d65a695b182f6a3f2a
Author: C. Davis <cd.rattan at gmail.com>
Date: Fri Jul 6 02:42:53 2012 -0700
s3: Wrap calls to the s3 registry API.
To use Samba 4's libregistry in the registry editor, some
compatibility issues with Samba 3 need to be addressed.
"struct registry_key" is defined differently in source3 and
source4, and so this wrapper is used to isolate conflicting
types and avoid headaches compiling the code.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 251767cde9a146d8122d76e257ab232c05ad452a
Author: Jeremy Allison <jra at samba.org>
Date: Fri Apr 26 10:47:41 2013 -0700
Fix bug #9822 - Samba crashing during Win8 sync.
When refactoring the dptr desctructor in the
fix for bug:
9778 (Samba directory code uses dirfd() without vectoring through a VFS call)
I removed the code to NULL out the struct smb_Dir *
pointer inside the fsp struct by mistake.
Re-add the NULLing out of that pointer when
closing a directory pointer associated with
an open file.
Reporter confirms it fixes the crash.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Sat Apr 27 20:44:55 CEST 2013 on sn-devel-104
commit b7765fe63fa04e09ac67285d0e17e37b06bcff8b
Author: Volker Lendecke <vl at samba.org>
Date: Wed Apr 17 13:41:54 2013 +0200
torture: Only test leases if supported
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
Autobuild-User(master): Richard Sharpe <sharpe at samba.org>
Autobuild-Date(master): Sat Apr 27 18:09:37 CEST 2013 on sn-devel-104
commit 27e9115eb01f02d5d07d2cf35887f99ff8d823b8
Author: Volker Lendecke <vl at samba.org>
Date: Wed Apr 17 12:34:14 2013 +0200
torture: Use ZERO_STRUCTPN instead of explicit deref
Signed-off-by: Volker Lendecke <vl at samba.org>
commit 5185460067229a342ddf3951ecc968017c2ed4df
Author: Jeremy Allison <jra at samba.org>
Date: Thu Apr 25 14:06:03 2013 -0700
Check for WRITE_ACCESS on the file before overriding an EACCESS.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Sat Apr 27 15:57:17 CEST 2013 on sn-devel-104
commit 77e3099483489ef4d59087dc6542fe7f7b589224
Author: Jeremy Allison <jra at samba.org>
Date: Thu Apr 25 14:02:24 2013 -0700
Ensure we don't try the open_file_fchmod() if we can't write to the file.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit a91aac4a5f0bd2077be267e49d1fc4f0321bb39c
Author: Jeremy Allison <jra at samba.org>
Date: Thu Apr 25 14:00:42 2013 -0700
Remove indentation around code wrapped by unneeded CAN_WRITE.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 0d88b37fc63023eeb749080713449b124e346e9e
Author: Jeremy Allison <jra at samba.org>
Date: Thu Apr 25 13:59:22 2013 -0700
Add early return in file_set_dosmode() on a read only share.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 8283fd0e0090ed12b0b12d5acb550642d621b026
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 26 15:13:14 2013 +0200
smbd: Do not fetch the record in defer_open_done
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sat Apr 27 02:06:10 CEST 2013 on sn-devel-104
commit e13021e3af7c95c59b5997a6728d2dbd5fd27b8f
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 26 15:12:05 2013 +0200
dbwrap: Allow dbwrap_record_watch_recv to not lock the record
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a7e803485d0255fa7fa92970ee535e1e2c9a29a1
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 26 15:05:50 2013 +0200
smbd: We don't use DEFERRED_OPEN_ENTRY anymore
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8da5a0f1e33a85281610700b58b534bc985894f0
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 26 14:29:42 2013 +0200
smbd: Remove unused smb2_deferred_open_timer
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 78d4bdc0b837340d39f7f99044ac12be919f8662
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 14:12:38 2013 +0200
smbd: Obsolete MSG_SMB_OPEN_RETRY
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit f52a3c3cd1ef2d6373819a7ba8c724fa9ca374f5
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 14:09:12 2013 +0200
smbd: Remove the unused fsp->pending_break_messages array
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3e7923d7afe7e47883dd7f7ec4e6a57490232105
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 14:06:59 2013 +0200
smbd: Remove unused reply_to_oplock_break_requests
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 234edb525d95ff03d15b9b2db88b3e7479ca0290
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 14:03:08 2013 +0200
smbd: Obsolete MSG_SMB_BREAK_RESPONSE
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 4e4376164bafbd3a883b6ce8033dcd714f971d51
Author: Volker Lendecke <vl at samba.org>
Date: Wed Apr 10 16:57:32 2013 +0200
smbd: Ignore OPEN_RETRY and BREAK_RESPONSE
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit afe9446985663ac47036aa79d1b07de8b46cbd3e
Author: Volker Lendecke <vl at samba.org>
Date: Thu Nov 29 16:10:22 2012 +0100
smbd: Use dbwrap_record_watch_send for defer_open
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b1574ebb0b0b119659ae06a8ef42e8ae161e0988
Author: David Disseldorp <ddiss at samba.org>
Date: Thu Apr 25 16:41:17 2013 +0200
bug 9830: fix panic in nt_printer_publish_ads
Check for ads_find_machine_acct() errors, to ensure a NULL LDAPMessage
pointer doesn't get passed to ldap_get_dn().
Signed-off-by: David Disseldorp <ddiss at samba.org>
Reviewed-By: Günther Deschner <gd at samba.org>
Autobuild-User(master): Günther Deschner <gd at samba.org>
Autobuild-Date(master): Thu Apr 25 19:01:55 CEST 2013 on sn-devel-104
commit 727c611fe3c903d905871a46909ed1e7639add15
Author: Sam Lang <sam.lang at inktank.com>
Date: Mon Apr 22 10:23:16 2013 -0500
source4/libcli: Only set ctemp set on success
If open fails ctemp.out.name probably won't be valid and strdup
will cause a segv. Only set the path if open succeeds.
Signed-off-by: Sam Lang <sam.lang at inktank.com>
Reviewed-by: Volker Lendecke <Volker.Lendecke at SerNet.DE>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Apr 24 23:58:44 CEST 2013 on sn-devel-104
commit 301a1f919202c90c629a4926ebdf054b9f2fe1e8
Author: Sam Lang <sam.lang at inktank.com>
Date: Wed Apr 24 12:52:57 2013 -0700
Implements a vfs module for cephfs, a distributed file system
with posix semantics, built on the ceph distributed object
storage layer. The ceph vfs module interfaces to the libcephfs
userspace API, and is primarily a lightweight wrapper around
libcephfs, translating error codes and parameters as necessary.
Signed-off-by: Sam Lang <sam.lang at inktank.com>
Reviewed-by: Volker Lendecke <Volker.Lendecke at SerNet.DE>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 4b97a19e584cb216194c5eca1270ef1926fc9006
Author: Andreas Schneider <asn at samba.org>
Date: Wed Apr 24 15:27:21 2013 +0200
BUG 9817: Fix 'map untrusted to domain' with NTLMv2.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Wed Apr 24 17:14:48 CEST 2013 on sn-devel-104
commit 19242b2916b55d2f1d97855e038395d5c87ca421
Author: Christian Ambach <ambi at samba.org>
Date: Mon Apr 22 13:56:24 2013 +0200
docs-xml: document dbwrap_tool exists
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Mon Apr 22 18:43:42 CEST 2013 on sn-devel-104
commit 26515c5d473c12f638e7405a5df3b1e24cd82ec8
Author: Christian Ambach <ambi at samba.org>
Date: Mon Apr 22 13:51:52 2013 +0200
s3:utils/dbwrap_tool add exists operation
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 5512a43a93833d3d6f1721d69c894db0e2c77ef8
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 19 16:17:13 2013 +0200
docs: Fix bug 9809 -- missing entry in specfile
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Karolin Seeger <kseeger at samba.org>
Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
Autobuild-Date(master): Mon Apr 22 11:35:52 CEST 2013 on sn-devel-104
commit 5727bfa410f55d6dcaaff90b8da704fb10366ac0
Author: Jeremy Allison <jra at samba.org>
Date: Wed Apr 17 14:42:20 2013 -0700
Fix bug in old create temp SMB request. Only use VFS functions.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Sat Apr 20 21:13:36 CEST 2013 on sn-devel-104
commit 95f7fc83b251efefcc2a603b936b55e2f0308a72
Author: Jeremy Allison <jra at samba.org>
Date: Mon Apr 8 10:49:03 2013 -0700
Ensure the RECVFILE path in vfs_pwrite_data() operates on a blocking socket.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sat Apr 20 01:04:05 CEST 2013 on sn-devel-104
commit 1ed710c2ffc91d8b33b87e572a6075e0126b5826
Author: Jeremy Allison <jra at samba.org>
Date: Mon Apr 8 10:32:10 2013 -0700
Ensure the RECVFILE path in vfs_write_data() operates on a blocking socket.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze at samba.org>
commit 1b46db7b24a4f064706c2c7e712452135a3fed34
Author: Jeremy Allison <jra at samba.org>
Date: Mon Apr 8 10:16:48 2013 -0700
Ensure drain_socket() operates on a blocking socket.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze at samba.org>
commit 1a7cec37e725c9f29fd71788e15623d904b41c8a
Author: Jeremy Allison <jra at samba.org>
Date: Mon Apr 1 11:16:01 2013 -0700
Add the internals of is_smb2_recvfile_write.
This turns on the real receivefile detection, and completes
the receivefile code path changes.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze at samba.org>
commit 53b87f2fbabe3a2dcb5df6f6c494ef332bea81e7
Author: Jeremy Allison <jra at samba.org>
Date: Mon Apr 1 13:24:07 2013 -0700
The guts of the receivefile code changes.
If an incoming PDU might qualify, only read
SMBD_SMB2_SHORT_RECEIVEFILE_WRITE_LEN = (SMB2_HEADER + SMB2_WRITE_BODY_LEN)
bytes rather than the whole PDU.
Next time we're called, use is_smb2_recvfile_write() to decide if
this is an SMB2_WRITE that fit the receivefile criteria, otherwise
just read the rest of the PDU.
If we did do a short receivefile read, set up the smb2_req->smb1req->unread_bytes
value to show what bytes remain in the TCP buffers.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze at samba.org>
commit fdcaf0fa360b9590114605d24af545b1d42b9fd5
Author: Jeremy Allison <jra at samba.org>
Date: Mon Apr 1 13:19:01 2013 -0700
Add stub static function that will turn on/off receivefile code path.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze at samba.org>
commit 4b91097002d73ae5dd2d4ac225f8e9eecca11e49
Author: Jeremy Allison <jra at samba.org>
Date: Mon Apr 1 13:17:09 2013 -0700
Add extra fields into struct smbd_smb2_request_read_state to support receivefile.
Initialize min_recv_size with the size that will trigger the
receivefile write path.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze at samba.org>
commit 36d4b9d208c0025f054ad8ae4062ca3c81e345d5
Author: Jeremy Allison <jra at samba.org>
Date: Mon Apr 1 13:14:13 2013 -0700
Add macro SMBD_SMB2_SHORT_RECEIVEFILE_WRITE_LEN.
This is the 'short' length we'll read in the SMB2_WRITE receivefile
code path.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze at samba.org>
commit 61da7f00b3f3daebb82e6a5d987883e0897dc4e9
Author: Jeremy Allison <jra at samba.org>
Date: Mon Apr 1 13:12:55 2013 -0700
Add utility function get_min_receive_file_size().
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze at samba.org>
commit 63739440f128229a6a99d0653562d3735ae909fb
Author: Jeremy Allison <jra at samba.org>
Date: Tue Mar 19 12:36:52 2013 -0700
Allow smbd_smb2_request_error_ex() to cope with unread bytes on error.
Drain the socket if a RECVFILE write failed.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze at samba.org>
commit a36d7633bd3608b71f610fc9df2ad9c66bfdd9c6
Author: Jeremy Allison <jra at samba.org>
Date: Tue Mar 19 12:24:17 2013 -0700
Add function smbd_smb2_unread_bytes().
Returns number of bytes left to read for recvfile. Will be
used in SMB_2_WRITE_FILE code path.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze at samba.org>
commit ec9fc986da8279f15338b7682c629bfdfc36d016
Author: Jeremy Allison <jra at samba.org>
Date: Tue Mar 19 12:16:32 2013 -0700
If we already have an smb1req attached to the struct smbd_smb2_request, don't recreate it.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze at samba.org>
commit 9791c1a24822d8b46bf7dd231b615d281b58540b
Author: Jeremy Allison <jra at samba.org>
Date: Mon Mar 18 12:00:25 2013 -0700
Ensure we don't do an SMB2 aio write if RECVFILE is active.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze at samba.org>
commit 8543a7b9b3b1efe2911b32c5f7c1cd3db85681b1
Author: Amitay Isaacs <amitay at gmail.com>
Date: Sat Apr 20 00:46:19 2013 +1000
samba-tool/dns: Fix a typo in ttl variable name
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit aad5eeb9b4f67b03988ceefb7888cb63ecefcf30
Author: Matthieu Patou <mat at matws.net>
Date: Sat Jan 26 14:42:57 2013 -0800
fileserver: raise the debug level for share connection from non IPC to 2
So that logs of make test are not spamed, the code dates from 1999 maybe
at that moment we wanted to have some warning I think nodays it's pretty
stable.
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d51b498017d612d9787b17b38ac0931ee0a90de0
Author: Christian Ambach <ambi at samba.org>
Date: Fri Apr 19 11:10:45 2013 +0200
s3:locking add NDR debug in share_mode_forall
Reviewed-by: Volker Lendecke <vl at samba.org>
Signed-off-by: Christian Ambach <ambi at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Fri Apr 19 15:06:33 CEST 2013 on sn-devel-104
commit 63f78c36b4edfb8e4a06d13f7cd5e1b719c85cef
Author: Christian Ambach <ambi at samba.org>
Date: Fri Apr 19 11:21:06 2013 +0200
s3:rpc_server increase a debug level
those messages are not worth level 0 or 1 and potentially
clutter the system logs
Reviewed-by: Volker Lendecke <vl at samba.org>
Signed-off-by: Christian Ambach <ambi at samba.org>
commit 47f8e210436d89f00eca52d4784a544ab25b9ac8
Author: Christian Ambach <ambi at samba.org>
Date: Fri Apr 19 11:20:38 2013 +0200
s3:registry increase a debug level
do not clutter the logs
Reviewed-by: Volker Lendecke <vl at samba.org>
Signed-off-by: Christian Ambach <ambi at samba.org>
commit 165b7aa58690cbc6a288b70e5690bf2e93f3ca62
Author: Christian Ambach <ambi at samba.org>
Date: Fri Apr 19 10:04:08 2013 +0200
s3:smbd stop working on a dead client socket
when the client has already disconnected, exit server as done
in other paths in smbd_process
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 58275be0eb68d01a238f0fedf4c92b63f7d10b53
Author: Christian Ambach <ambi at samba.org>
Date: Mon Apr 8 18:09:05 2013 +0200
s3:smbd increase a loglevel
do not complain too loudly if the socket has already gone
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit de1c833b3a06ce2f7599ef58b26b473ed00ae55f
Author: Christian Ambach <ambi at samba.org>
Date: Thu Apr 18 17:09:32 2013 +0200
s3:smbstatus do not print orphaned share entries
Pair-Programmed-With: Volker Lendecke <vl at samba.org>
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 5aa9e552ec70ffbd48495e0d7c28517e726487bf
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 19 12:36:08 2013 +0200
smbd: Fix signing when the async echo handler kicks in
This was introduced as a copy&paste error in 5e0258fc932c
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 77f7a46e180596fa081f4069edea9efd23e3f0c5
Author: Matthieu Patou <mat at matws.net>
Date: Thu Apr 11 22:30:27 2013 -0700
s4:dsdb: Fix warnings about not set / set but unused / shadowed variables
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Fri Apr 19 13:15:40 CEST 2013 on sn-devel-104
commit 31714c97845fff11b2997c86b5fc3a3bff8ed710
Author: Michael Adam <obnox at samba.org>
Date: Thu Apr 18 23:45:24 2013 +0200
s3:smbd:smb2:scavenger: fix format error for debugging open_persistent_id in scavenger_timer()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Apr 19 01:36:15 CEST 2013 on sn-devel-104
commit 79fe1381a3a78ad2316343fc8c1c27360b46ebbf
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 22:19:25 2013 +0200
talloc: Simplify _talloc_free_poolmem a bit
Early returns are easier to understand than "else if"
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Apr 18 22:50:42 CEST 2013 on sn-devel-104
commit a796e48b1dfe96b194f3a3a0d70e25c3ab92690d
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 22:12:50 2013 +0200
talloc: Do an early return
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit ccf33dd0547f32104041c8611626f3e02e22cbe9
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 22:11:44 2013 +0200
talloc: Avoid some "else" by doing early returns
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d3928b0c8af01f7751191b81a72590ca35751a8c
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 21:44:38 2013 +0200
talloc: Fix nonblank line endings
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 33c690746b0bd0e24da6d07f926a3139a5e48099
Author: Volker Lendecke <vl at samba.org>
Date: Wed Apr 17 17:19:59 2013 +0200
selftest: S3 does not do leases yet
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Thu Apr 18 16:59:39 CEST 2013 on sn-devel-104
commit d496ccdb905c3897bcacef7f4d56010eb523c965
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Oct 31 09:07:19 2012 +0100
s4:torture/smb2: add v2 lease requests
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 3c9846cafde28fb8d40ae81cafb03f2e2ec8d9e2
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Oct 31 09:06:48 2012 +0100
s4:torture/smb2: add smb2_lease_v2_create_share() helper
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 6c81893b342786d5f63aaa89e855e9378def50c3
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Oct 31 08:37:13 2012 +0100
s4:libcli/smb2: add support for SMB2 LEASES v2
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit f367d07f521b26cfb5813dd679a4e4883b69752f
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Oct 31 08:19:52 2012 +0100
libcli/smb: add SMB2_LEASE_FLAG_* defines
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 1bfc7e863e76124c287228b772c331bc5c9f8616
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Nov 1 16:20:35 2012 +0100
s4:torture/smb2: add NTCREATEX_SHARE_ACCESS_DELETE in smb2_generic_create_share()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 87685b30d7ab52193c54abacdab0b442bcc51a47
Author: Gregor Beck <gbeck at sernet.de>
Date: Wed Apr 3 09:27:26 2013 +0200
s4:torture:smb2 delete temp memory context in test_durable_open_oplock_disconnect
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Thu Apr 18 15:10:31 CEST 2013 on sn-devel-104
commit 2ef02e4f5a5772c1b598fa0df6e5cf0a10d2e060
Author: Michael Adam <obnox at samba.org>
Date: Thu Jan 17 22:17:42 2013 +0100
s4:torture:smb2:durable_v2: remove an unused variable
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit c2ef5182e32fafeb3e279d9fc3a2a409e4aa0543
Author: Gregor Beck <gbeck at sernet.de>
Date: Wed Mar 20 10:01:43 2013 +0100
s3:smbd: call scavenger_schedule_disconnected() from close normal file for durable handles
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 1ed22ba4b7998c1fc29476e931bd463f2bc1ba7e
Author: Gregor Beck <gbeck at sernet.de>
Date: Thu Feb 7 15:26:37 2013 +0100
s3:smbd: add a scavenger process for disconnected durable handles
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f608bedfca4118b7e3606802df40e266bcc099d8
Author: Gregor Beck <gbeck at sernet.de>
Date: Wed Mar 13 11:35:37 2013 +0100
s3:locking: add function share_mode_cleanup_disconnected()
For a given file, clean share mode entries for a given persistent file id.
Pair-Programmed-With: Michael Adam <obnox at samba.org>
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit 0ac0b35dad796d10cf04ab77a53a926420cc0589
Author: Gregor Beck <gbeck at sernet.de>
Date: Wed Mar 20 10:22:06 2013 +0100
s3:locking: improve debug output of parse_share_modes()
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 3d3e7e837a339dfc1aaf4d7fc52f95f3f6a80173
Author: Gregor Beck <gbeck at sernet.de>
Date: Tue Mar 12 15:10:51 2013 +0100
s3:locking: no need to make a file_id passed by value a constant
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit ee81a6e7d0263d263f7d4e7bd5bd9c4156cae8cf
Author: Gregor Beck <gbeck at sernet.de>
Date: Wed Mar 13 14:47:18 2013 +0100
s3:locking:brlock: add function brl_cleanup_disconnected()
For a given file, clean up brl entries belonging to a given persistent file id.
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 6ee1555df2e69aead00ee231c990020cc4bf04bc
Author: Michael Adam <obnox at samba.org>
Date: Fri Apr 12 11:13:57 2013 +0200
s3:locking:brlock: explain the lockdb_clean semantic better in brl_reconnect_disconnected()
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit f08bda22dc7a5038fab77ad7dd090a6f72d94c7f
Author: Gregor Beck <gbeck at sernet.de>
Date: Tue Mar 5 14:49:28 2013 +0100
s3:locking:brlock: let validate_lock_entries keep entries for disconnected servers in traverses
We should not remove locks of disconnected opens just like that.
When getting the byte range lock record for a newly connected file
handle, we still do the clean up, because in that situation,
disconnected entries are not valid any more.
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit fe0bf0b6d67a49a30969f922ee65f0af88a952a1
Author: Michael Adam <obnox at samba.org>
Date: Fri Apr 12 11:05:29 2013 +0200
s3:locking:brlock: improve the comment for the brl self cleaning code
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 02cc5a5c6a6b6b2b796abe573a671853d945b22f
Author: Gregor Beck <gbeck at sernet.de>
Date: Tue Mar 5 14:02:10 2013 +0100
s3:locking:brlock: use serverids_exist to validate_lock_entries
...instead of checking each server-id separately which can
be expensive in a cluster.
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 941e84dcfe985559e5e75318e7b5dd9d50fcc47b
Author: Gregor Beck <gbeck at sernet.de>
Date: Tue Mar 12 14:36:32 2013 +0100
s3:smbXsrv_open: add function smbXsrv_open_cleanup()
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 9d47dc8958f7fcab77460495bd1ae940122dddd8
Author: Gregor Beck <gbeck at sernet.de>
Date: Tue Mar 12 13:43:30 2013 +0100
s3:smbXsrv_open: factor out smbXsrv_open_global_parse_record
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 49cd31e39d70c090c448df5a9b6c50ca83e06f9b
Author: Gregor Beck <gbeck at sernet.de>
Date: Thu Mar 28 10:28:21 2013 +0100
s3:net registry check: use tdb_data_string()
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 037f57e12fb7b87e0c5c035ae85cb698bca64f4d
Author: Gregor Beck <gbeck at sernet.de>
Date: Wed Mar 20 09:56:54 2013 +0100
util_tdb: add function tdb_data_string()
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 450ebe97d1c36a8041e3567c0b1fe94822909ea2
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Apr 15 11:28:47 2013 +0200
s3:winbindd: avoid usage of procid_self()
metze
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit beb9a27180e5570337381d03fac55bbe6d1637e0
Author: Michael Adam <obnox at samba.org>
Date: Thu Apr 18 13:11:03 2013 +0200
s3:smbd:smb2: fix setting of scavenge timeout when reconnecting durable handles
The bug fixed with this commit led to reconnected durable handles
having a disconnect timeout of 0 msec. This fix re-establishes the
original timeout for the reconnected handle.
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit bb7c6a0bd0d194e62d2c861edaff1dd6a0e071f6
Author: David Disseldorp <ddiss at samba.org>
Date: Thu Apr 18 10:32:44 2013 +0200
netcmd/dns: fix typo
Fix provided by Tobias Florek.
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Thu Apr 18 12:40:33 CEST 2013 on sn-devel-104
commit 406450d44e9c7a31b9db9cdb16c0b404f133d006
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:56:59 2013 +0200
smbd: Remove NTSTATUS based create_synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Apr 18 02:52:40 CEST 2013 on sn-devel-104
commit cc0b8351a445243bdefd4b98a31548b2c51e43b8
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:55:53 2013 +0200
smbd: Convert create_file_unixpath to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 940ad94906129cf5f65125961470a3a5f41ea78f
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:54:46 2013 +0200
smbd: Convert is_visible_file to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 59cfbc7925ee93ef963780085fa9c2c0e08e7421
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:53:32 2013 +0200
smbd: Convert dptr_create to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 235a309fc17f029912cbd0608b36a080435ae4b9
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:51:59 2013 +0200
smbd: Convert print_spool_open to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit ea519ec5cefba1079e3f67a2b9b58c8f0ca35948
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:50:51 2013 +0200
smbd: Convert driver_unlink_internals to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 2b97eb13ff7d97ddd7a4400a8073ea7b00119103
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:49:54 2013 +0200
vfstest: Convert cmd_set_nt_acl to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6f7d9b24d0bf8265c007c2c9745acdabd2e41990
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:49:09 2013 +0200
vfstest: Convert cmd_utime to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6624095d6747432e1e19ee54902a804dcb2c0129
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:48:05 2013 +0200
vfstest: Convert cmd_lstat to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 7d5403037ad6d14c912c19a6970ebea9a43c942b
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:47:17 2013 +0200
vfstest: Convert cmd_stat to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a6985e6e678e2ca8867097671192cf3a94e772e1
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:46:24 2013 +0200
vfstest: Convert cmd_rename to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 434885a4ac4ba1c75326c847a484e65f7dd16153
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:44:35 2013 +0200
vfstest: Convert cmd_pathfunc to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 1f6b0af7e7da0b5fb2d2e52f070caffe643113d2
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:43:38 2013 +0200
vfstest: Convert cmd_open to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0cb056472dc38010ea12aed167ea664c7c5c912a
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:42:38 2013 +0200
vfs: Convert dirsort_opendir to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 730c57bf5217057bcf72f12b94f5501bea75ca1c
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:41:26 2013 +0200
vfs: Convert vfs_scannedonly to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d70de0776b9d30f72032900d5f58624998784850
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:36:30 2013 +0200
smbd: Convert set_create_timespec_ea to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit fb211c39dbdb026c4294ccfb42e0c648c4464a27
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:30:50 2013 +0200
smbd: Convert unix_mode to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit af40d236ea851cab4ad34928fcabf556a153327e
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:28:47 2013 +0200
smbd: Convert rmdir_internals to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit f5873c987ca86824863683fcd0f6736880eed4c1
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:27:35 2013 +0200
smbd: Convert recursive_rmdir to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 39470c80562fe5b7db41b09e890495f4eba4c709
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:25:41 2013 +0200
smbd: Convert delete_all_streams to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 421eeef732a63711b3e922bd63f9ac59110659f1
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:23:44 2013 +0200
smbd: Convert open_streams_for_delete to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 66beff7dd0483a5bb7591d7e5e85e5de96b5dbe7
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:22:43 2013 +0200
smbd: Convert msg_file_was_renamed to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 39c5a77b0a03916477309332913cd5a346c46472
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:21:09 2013 +0200
smbd: Convert change_dir_owner_to_parent to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d003f2ff8064c5655e13a523e7b2b93b2f56cf60
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:12:40 2013 +0200
smbd: Convert change_dir_owner_to_parent to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c9a220bdaf963fa8a4ede9a3b9eb52b6c10d718e
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:11:43 2013 +0200
smbd: Convert change_file_owner_to_parent to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 81e9c0102d1aae9b794addd7e35f9a888d5d66a2
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:10:28 2013 +0200
smbd: Convert make_connection_snum to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 10d8d7d0bdea0e472c76241936cbfa70f1a60af8
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:09:32 2013 +0200
smbd: Convert rename_internals_fsp to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 862c561ffc3dcb45d80d5fdc314854687e98f525
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:08:15 2013 +0200
smbd: Convert remove_msdfs_link to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 576df8742828c676997021cc8a58c2b7168cb0a9
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:06:57 2013 +0200
smbd: Convert create_msdfs_link to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 01b8f34e49e4d95935b6c520cbd833b34c6ce792
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:05:20 2013 +0200
smbd: Convert can_delete_file_in_directory to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e3a7f707686973af04afd1022820a4aabdae95ac
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:03:44 2013 +0200
smbd: Convert file_new to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 2d76ce3fc0d5fdf7a77512e1d110ca15a1711ba0
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:02:19 2013 +0200
smbd: Convert open_dir_with_privilege to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit fe798621314aaba110fb59567ab8a10eac83266e
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:00:14 2013 +0200
smbd: Convert open_np_file to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit fa3f2fd83b73b7d7e4fd35894a0fc13d8af1f2be
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 10:55:16 2013 +0200
smbd: Convert smb_file_rename_information to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 419dd4f84475b7f2c290b2682124cea4bc46e8c5
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 10:54:22 2013 +0200
smbd: Convert smb_file_rename_information to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 9cf8d693de5142aa19507bb6dd73c1266e0df00a
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 10:53:16 2013 +0200
smbd: Convert smb2_file_rename_information to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 381bd97f1307e827ff19721808ba303f292a8d4f
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 10:50:53 2013 +0200
smbd: Convert smb_set_file_dosmode to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit edb7293020737b7dc6aeaf98654f58a8d4c34227
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 10:49:46 2013 +0200
smbd: Convert call_trans2qfilepathinfo to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit aa523408b4ba20e70403f819981e4881bdfeaae5
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 10:39:45 2013 +0200
smbd: Convert posix_sys_acl_blob_get_file to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 1dc29208f3b9bf7733bdfe19262ab533f813d9fb
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 12:14:32 2013 +0200
pysmbd: Convert py_smbd_unlink to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 204d971d892e0aec8a5c0eb8b97b6a9675905bfe
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 12:06:51 2013 +0200
pysmbd: Convert set_nt_acl_conn to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 1675bf379c67f695c3826479f0d69109f82da3d4
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:49:19 2013 +0200
smbd: Convert filename_convert_internal to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0b147201bd24cc71ed32376961bdfef4b8729dce
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:47:41 2013 +0200
smbd: Convert vfs_lstat_smb_fname to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 9041f3d6d3bf9ff068687402b6275004b8c18e95
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:46:15 2013 +0200
smbd: Convert vfs_stat_smb_fname to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit bde53d8c5b6c6cee51f18bf50a1cdbe01e2e99cc
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:44:38 2013 +0200
smbd: Convert check_reduced_name_with_privilege to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e0866753ce23d7edb9ca14f825a01f201127f7bb
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:43:24 2013 +0200
smbd: Convert vfs_GetWd to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 75911f94b860bcc7186390f5372ede3f6f92024e
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:41:20 2013 +0200
smbd: Convert vfs_default_durable_reconnect to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 97d006ff7d442d718cea95cea4a95404c2da2d9b
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:39:46 2013 +0200
vfs: Convert non_posix_sys_acl_blob_get_file_helper to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3d05622c560d2b481c28fa834f3fa2fde288fcce
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:38:28 2013 +0200
vfs: Convert vfswrap_fs_capabilities to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a61307489c93e925ed99f0e2409984a794d74fce
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:37:10 2013 +0200
vfs: Convert streams_depot_streaminfo to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 952d348f872a24e31370ef3dbd176a17bf4d72b5
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:36:11 2013 +0200
vfs: Convert collect_one_stream to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 83e6ff1511289bc07f9a7e3786efb245363a5646
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:34:37 2013 +0200
vfs: Convert streams_depot_rmdir to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 87d92093afd0b22bd826eae95881e9714a6dd12e
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:33:38 2013 +0200
vfs: Convert streams_depot_unlink to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 1729d786928957c37062f19582c52871c12b90b6
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:31:37 2013 +0200
vfs: Convert streams_depot_open to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3794574bc159a0c657a1732a6c2d1b47f8166511
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:28:16 2013 +0200
vfs: Convert stream_smb_fname to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 987ebb15918a10fd17bf784a054499111d4ad4e5
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:26:27 2013 +0200
vfs: Convert stream_dir to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 441467c26621f245a7f71f4280e2c44afb30118f
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:22:23 2013 +0200
vfs: Convert fake_acls_sys_acl_delete_def_file to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 63f3980a88e033e118160fc92f95f0bf9bd2fbb2
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:19:26 2013 +0200
vfs: Convert vfs_gpfs_chmod to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 58bb3ae99d0ccb469676117245b2ffff4abfa333
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:18:10 2013 +0200
vfs: Convert gpfsacl_emu_chmod to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 19e88da1dcbc553d443b4c224d186ccda09672b6
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:17:00 2013 +0200
vfs: Convert recycle_unlink to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3dafdd3c0b9523f65205254b5ad98e8959580f93
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:15:41 2013 +0200
vfs: Convert streams_xattr_streaminfo to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit bef6c7615c4b2af90fc44b650016f9a1947c1889
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:14:39 2013 +0200
vfs: Convert streams_xattr_open to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit ec5ac9080b50c8a45c19ddab9069ac6e1e707809
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:13:32 2013 +0200
vfs: Convert streams_xattr_fstat to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 7d57b8adf27f82d25a9d26eae6d652c9f763fdfa
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:09:25 2013 +0200
vfs: Convert xattr_tdb_get_file_id to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 9b499996c4d7bdd963f14242ee727adbe14e3aa7
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:07:56 2013 +0200
lib: Make create_synthetic_smb_fname_split use synthetic_smb_fname_split
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8087e701ccddc5ea8835292605007cced674a43b
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:06:45 2013 +0200
lib: Add synthetic_smb_fname_split
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 133cde309381d9e127c8d78167b486dd7cbb0920
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:01:15 2013 +0200
lib: Remove unused copy_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5774989336570e89b0976842eb9ea2657f8fc3ed
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 11:00:31 2013 +0200
lib: Make create_synthetic_smb_fname use synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c1ad69556c5ba4477a7c369e369c30def0288d55
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 10:56:53 2013 +0200
vfs: Convert hpuxacl_sys_acl_set_file to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 855ca77f8247b2ee028b3d26a1f1f917204f882f
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 12 10:55:54 2013 +0200
vfs: Convert afsacl_get_nt_acl to synthetic_smb_fname
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 766f04cebd08d5b7056171945a79b7a8cb4de198
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 17:01:22 2013 +0200
lib: Add synthetic_smb_fname
The interface of create_synthetic_smb_fname is just silly
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit f50dedb8fb2c654d3e5dccba24fdf79a96525061
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 16:46:37 2013 +0200
smbd: Make copy_smb_filename static
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b8dd1749e30615d26107b99baa264c6d334a8f9d
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 16:34:15 2013 +0200
smbd: Convert call_trans2setfilepathinfo to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 9a42fe2d6de50117ea4b0d57819e32d389e787fb
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 16:30:38 2013 +0200
smbd: Convert smb_set_file_unix_basic to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 82bf92d08a3e1e208a7e944fa7ada0a56585ad4a
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 16:28:53 2013 +0200
smbd: Convert smb_set_file_size to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e2e45bd9cd6fa9a48fe8be15da4406dfcc55057a
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 16:27:48 2013 +0200
smbd: Convert call_trans2qfilepathinfo to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0831de71e761e2f764d9ad091b39ce76bc3b67da
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 16:26:45 2013 +0200
smbd: Convert fsp_set_smb_fname to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 1f39074b8338855033ffc1484e56ede6a86f6c1a
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 16:25:10 2013 +0200
smbd: Convert copy_file to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a062fb813e7e85cf9d493126e14dd62abb8f87e1
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 16:23:53 2013 +0200
smbd: Convert rename_internals_fsp to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 10f45a16b20204d79e1f6a24724da01137f30e60
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 16:22:38 2013 +0200
smbd: Convert smbd_dirptr_get_entry to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 988a341d25bf76e80c8ad73c668200869fae6774
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 16:20:29 2013 +0200
smbd: Convert smbd_smb2_close to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit fecf225068e1f6127f55db63a32b8f29bdae51ff
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 16:18:39 2013 +0200
vfs: Convert cap_ntimes to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit acf70b9e068e862be40fe69d5b74da6d8728c987
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 16:17:42 2013 +0200
vfs: Convert cap_unlink to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 4d3184e96c5fc2e77df83556cfa9ed6a13448b72
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 16:16:58 2013 +0200
vfs: Convert cap_rename to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit fb7afce2d36bc0b13b4918675ba0a9360b1f5d02
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 16:14:05 2013 +0200
vfs: Convert alloc_get_client_smb_fname to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e49718111e4b2586136d60bb312ef35e58b6e48c
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 16:12:13 2013 +0200
vfs: Convert catia_ntimes to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 7d274641726d1572243968b708a102bb9a15a15c
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 16:11:26 2013 +0200
vfs: Convert catia_unlink to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit db4bbc0c4f8e57396cf81432876df59d238363d5
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 16:10:22 2013 +0200
vfs: Convert catia_rename to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6fffea81acd4a991aed57bdc126338b9ae8e4863
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 15:40:10 2013 +0200
vfs: Convert recycle_do_touch to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 79e005072e2c466af95013992eb89e19993e2d39
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 15:38:41 2013 +0200
vfs: Convert recycle_get_file_size to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 36bfe54c3b9c2ac54c6ff3b19d8eee57f03627fe
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 15:37:38 2013 +0200
vfs: Convert recycle_file_exists to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 9b875f62448dda0ff2283d7a4729542ccf6335ab
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 15:36:18 2013 +0200
vfs: Convert streams_xattr_unlink to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 2c733b2ffb72b972e2b176d3b32b1e5c6c1b3bad
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 15:35:02 2013 +0200
vfs: Convert xattr_tdb_unlink to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e0e5953494e08849e59b570c77c286a08d7d15bd
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 15:33:44 2013 +0200
vfs: Convert shadow_copy2_ntimes to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 33037d80d5f6bf551809c05abea75f0a7d2ddf17
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 15:32:39 2013 +0200
vfs: Convert shadow_copy2_unlink to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 19ee0708538a2358584de2a5498a470c5a168ec3
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 15:31:27 2013 +0200
vfs: Convert posix_eadb_unlink to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0221f8bb90d80589d65f48ac43ce0cb301ac509f
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 15:29:55 2013 +0200
vfs: Convert unlink_acl_tdb to cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8de3c04de346c120ca5ac396008d71eae708071f
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 15:26:34 2013 +0200
lib: Convert copy_smb_filename to use cp_smb_filename
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e1f4942a07ef20f3540a47dd08a7a64dbd469398
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 11 15:24:55 2013 +0200
lib: Add cp_smb_filename
The interface of copy_smb_filename is just silly ;-)
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0fa404c7d5c8de826d31958613b3e97587f0835d
Author: David Disseldorp <ddiss at samba.org>
Date: Wed Apr 17 10:39:12 2013 -0700
Bug 9807 - wbinfo: fix segfault in wbinfo_pam_logon
wbinfo_pam_logon() incorrectly assumes that wbcLogonUser() always
returns an allocated wbcAuthErrorInfo struct on failure.
Signed-off-by: David Disseldorp <ddiss at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Apr 17 21:29:29 CEST 2013 on sn-devel-104
commit f340795144348533912dc0a2c33286b48213f790
Author: Jeremy Allison <jra at samba.org>
Date: Mon Apr 15 16:54:20 2013 -0700
Cleanup. Remove unused function dptr_DirCacheAdd(). Make DirCacheAdd() static.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at suse.de>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Tue Apr 16 12:05:13 CEST 2013 on sn-devel-104
commit b08c0b317cb8064aac5cc32774a52243aa4af973
Author: Richard Sharpe <realrichardsharpe at gmail.com>
Date: Thu Apr 4 17:15:30 2013 -0700
Add a test that shows the difference between Windows and Samba with respect to DeleteOnClose.
Signed-off-by: Richard Sharpe <realrichardsharpe at gmail.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Apr 16 00:46:54 CEST 2013 on sn-devel-104
commit 0f9eb25183e6ed5a2f4ec8e385bc5f985f2087e5
Author: Volker Lendecke <vl at samba.org>
Date: Mon Apr 15 11:15:23 2013 +0200
smbd: Fix an error return in change_dir_owner_to_parent
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
Autobuild-User(master): Richard Sharpe <sharpe at samba.org>
Autobuild-Date(master): Mon Apr 15 18:05:06 CEST 2013 on sn-devel-104
commit f67ae788cf8a678af0e309c8527f2b25c98b557b
Author: Guenter Kukkukk <kukks at samba.org>
Date: Sun Apr 14 19:39:02 2013 +0200
samba-tool - MX records cannot be deleted (part2)
I missed this one, also a wrong compare of MX vs. SRV record
Signed-off-by: Guenter Kukkukk <kukks at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sun Apr 14 22:43:07 CEST 2013 on sn-devel-104
commit 3434140c0959d9608f9a4636df2060d00ac9b518
Author: Guenter Kukkukk <kukks at samba.org>
Date: Sun Apr 14 06:17:28 2013 +0200
samba-tool - MX records cannot be deleted (error in called C-program)
Only matching UNION-members should be compared. MX vs. SRV record
Signed-off-by: Guenter Kukkukk <kukks at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sun Apr 14 08:46:07 CEST 2013 on sn-devel-104
commit 41333f92d0c78e44a524f2248f5ae641ad59abf3
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Thu Apr 11 17:12:16 2013 +0930
ntdb: remove --disable-ntdb.
Remove DISABLE_NTDB option, and --disable-ntdb from waf build. This just
means that it will always get built: it isn't used by default yet.
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sat Apr 13 02:01:02 CEST 2013 on sn-devel-104
commit ed6a4e04e1f8a0ca952e37577bfdc9731d6ef93d
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Thu Apr 11 17:12:15 2013 +0930
source4/cluster and source4/ntvfs: convert to dbwrap, add ntdb option.
This makes the code use dbwrap_local_open(), so it can handle
NTDB.
brlock.tdb, notify.tdb and openfiles.tdb can now be brlock.ntdb,
notify.ntdb and openfiles.ntdb, if 'use ntdb' is set.
Cc: Andrew Bartlett <abartlet at samba.org>
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c5bd2ae338c0b67304ee253e3b5139b50cc1d0e5
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Thu Apr 11 17:12:14 2013 +0930
Samba3-HOWTO: mention NTDB.
Not sure if we're keeping this up-to-date, but try to document which
databases can be NTDB now.
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b4b56ee6ad990d99d9fd04591702167ca3b911ce
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Thu Apr 11 17:12:13 2013 +0930
schannel_store.tdb: make it schannel_store.ntdb if 'use ntdb'.
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 00c9e83d92ab1cc0635485386d28f445ea561ce3
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Thu Apr 11 17:12:12 2013 +0930
libcli/auth: convert to dbwrap.
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b45e3f557a00ba78f0d10b2253c99d5710de25c8
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Thu Apr 11 17:12:11 2013 +0930
secrets: use lpcfg_private_db_path() convenience helper.
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit ccfd929d964ae111cfac33acaf6c3bcc039724c1
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Thu Apr 11 17:12:10 2013 +0930
lib/param: lpcfg_private_db_path()
This wrapper avoids testing lpcfg_use_ntdb() everywhere.
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 1cf46d2e35c3c290a3d7d1c57d622a2abf2643e6
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Thu Apr 11 17:12:09 2013 +0930
source4/scripting/python/samba/samba3: handle ntdb files.
Upgrading old Samba 3 instances seems like a place where we don't have
to read ntdb files, but Andrew Bartlett points out that you can run a
Samba 4.0 and even a 4.1 'classic' domain and desire to migrate that
to the AD DC.
So make this upgrade code generic: if it finds an ntdb file, read
that, otherwise read the tdb file.
Cc: Jelmer Vernooij <jelmer at samba.org>
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5b15d107951d353eb4f055a62cf48a8226e8e6a6
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Thu Apr 11 17:12:08 2013 +0930
autoconf: build in NTDB.
I previously added -DDISABLE_NTDB to FLAGS, but lib/param/util.c
doesn't seem to be compiled with that flag, so it's really not a good
solution.
So instead, compile in ntdb for the autoconf build. This means:
1) Add -DHAVE_CCAN to cflags.
2) Remove pyntdb from autoconf objects (which is what tdb does)
3) Remove -DDISABLE_NTDB
4) Add ntdb utility objects
5) Link in ntdb everywhere we link in tdb.
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 7a4dd845958f1411daa8031ca242987001ab2f26
Author: Jeremy Allison <jra at samba.org>
Date: Wed Apr 10 16:30:10 2013 -0700
Remove dependency on detection of HAVE_DIRFD for use of fdopendir().
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Fri Apr 12 16:21:10 CEST 2013 on sn-devel-104
commit 0fe894fb89f4867e266bb04670a58101311e0234
Author: Jeremy Allison <jra at samba.org>
Date: Wed Apr 10 16:29:03 2013 -0700
Remove the "Ugly hack" that was the second use of dirfd().
The destructor does all the resource deallocation needed.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit ea14c9443178da9ae6ccbe71e573156396f6f699
Author: Jeremy Allison <jra at samba.org>
Date: Wed Apr 10 16:24:15 2013 -0700
In the struct smb_Dir destructor, use the fsp back pointer to release resources.
Removes one use of dirfd().
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit e89ec641fc98ffd7f7193deb3728b0a284a093eb
Author: Jeremy Allison <jra at samba.org>
Date: Wed Apr 10 16:21:39 2013 -0700
Maintain a back-pointer to the fsp in struct smb_Dir when opening with FDOPENDIR.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 237ec2fbac4c69f642eab481813350fb9568ebaf
Author: Volker Lendecke <vl at samba.org>
Date: Tue Apr 9 12:15:02 2013 +0200
libsmbclient: Use async cli_full_connection in python connection setup
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Apr 12 03:07:10 CEST 2013 on sn-devel-104
commit cd2cc97df214a284c55fc5bf43d17aab10808d95
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 5 14:55:26 2013 +0200
libsmbclient: Make cli_full_connection async
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5daf6476fa431bea2815f1e7afbfea3688d39d19
Author: Volker Lendecke <vl at samba.org>
Date: Sat Apr 6 10:57:41 2013 +0200
libsmbclient: Make cli_tree_connect async
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6d1dc76952febd2b07dda0ec344c16c9464d27a8
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 5 15:29:14 2013 +0200
libsmbclient: Make cli_raw_tcon async
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c38dfebe5f5ef582a17833e12af95f25614de5ee
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 5 15:09:02 2013 +0200
libsmbclient: Streamline cli_openx a bit
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 906d173ca43a407752b2ee14fa45c28444a5a98f
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 5 15:08:22 2013 +0200
libsmbclient: Use tevent_req_poll_ntstatus in cli_openx
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6bed164c1553d9b031c7d1b85e642540adcafc1c
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 5 15:02:51 2013 +0200
libsmbclient: Streamline cli_tcon_andx a bit
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 80097ac12234b3a7be077a2699d79f0f3dec53f6
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 5 14:58:02 2013 +0200
libsmbclient: Use tevent_req_poll_ntstatus in cli_tcon_andx
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 47a1de356eb686cee60c4d1bd22d655b257fd041
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 5 12:42:01 2013 +0200
libsmbclient: Make cli_start_connection async
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 82b3069c30f01c45e11f25001a990dab9fef82f6
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 4 16:56:43 2013 +0200
libsmbclient: Remove unused cli_connect_sock
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 48053b77f90d9d158b67c1c67046c4b626530324
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 4 16:55:48 2013 +0200
libsmbclient: Add async cli_connect_nb
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a7c02f9a6ec82361b8999141224d74ed31bad630
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 4 15:01:25 2013 +0200
libsmbclient: Avoid a talloc_strdup in cli_connect_nb
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3b3dacf20dc0230be686fc05a65bd699c62a58ec
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 4 14:36:51 2013 +0200
libsmbclient: Make cli_connect_sock async
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 9879c88e913ae446ba977baeeeabb298309f5948
Author: Volker Lendecke <vl at samba.org>
Date: Tue Apr 2 13:39:05 2013 +0200
libsmbclient: Remove unused sync wrappers
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0e1e0a6e4153a585e13bebf617e264523bb13454
Author: Volker Lendecke <vl at samba.org>
Date: Tue Apr 2 13:37:30 2013 +0200
libsmbclient: Add async cli_session_setup
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit dc796331caab6dec1d4fc9883e6dfc4317105d24
Author: Volker Lendecke <vl at samba.org>
Date: Tue Apr 2 12:50:43 2013 +0200
libsmbclient: Remove unused cli_session_setup_ntlmssp()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 26359c25ef1c31b350d82588d628aa8a6b6bd911
Author: Volker Lendecke <vl at samba.org>
Date: Sat Mar 9 13:07:57 2013 +0100
libsmbclient: Add async cli_session_setup_ntlmssp
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e2e0449a587ed98b67bfc7382fa1f46347987ce7
Author: Volker Lendecke <vl at samba.org>
Date: Sat Mar 9 09:53:42 2013 +0100
libsmbclient: Factor out cli_session_setup_get_account
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0008d9e1c5151fe841b11651e7bb62c1feb93769
Author: Volker Lendecke <vl at samba.org>
Date: Fri Mar 8 19:41:07 2013 +0100
libsmbclient: Slightly simplify cli_session_setup_spnego
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 4627699e4f03f771e15657be90944a082fb8d740
Author: Volker Lendecke <vl at samba.org>
Date: Fri Mar 8 17:21:13 2013 +0100
libsmbclient: Factor out cli_session_setup_get_principal
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 54316ea3394f39f54add55ec554cce795ef1463f
Author: Volker Lendecke <vl at samba.org>
Date: Fri Mar 8 15:55:51 2013 +0100
libsmbclient: Avoid a data copy
spnego_parse_negTokenInit does a asn_load of that blob, which does a data copy
itself. So we don't have to had it a copy as well.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit fbda7826b88cf34f445dea73916e2ac958a94cdb
Author: Volker Lendecke <vl at samba.org>
Date: Fri Mar 8 17:40:54 2013 +0100
libsmbclient: Fix a leak on talloc_tos()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8956c0d53bd4e34ec4a93ac5bc1c72ad44e4b004
Author: Jeremy Allison <jra at samba.org>
Date: Tue Apr 9 16:56:24 2013 -0700
Ensure we test the dirsort module in make test.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Apr 11 21:17:21 CEST 2013 on sn-devel-104
commit 33478058c78e4c4a384cad2fbe8198b4a4aed101
Author: Jeremy Allison <jra at samba.org>
Date: Tue Apr 9 11:02:58 2013 -0700
Remove unneeded initializations (we already talloc_zero).
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 353718c3f9fa49f6c3b5d6de2afd79fbfade4295
Author: Jeremy Allison <jra at samba.org>
Date: Tue Apr 9 10:50:55 2013 -0700
Remove the use of dirfd inside the vfs_dirsort.c.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 6ae58dd153e3a53af52d896fff83ec76f40984d6
Author: Jeremy Allison <jra at samba.org>
Date: Tue Apr 9 10:43:53 2013 -0700
Convert mtime from a time_t to a struct timespec.
In preparation for removing the dirfd and using fsp_stat()
and VFS_STAT functions.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 770512e3bd785a977351ba82ab08c556573c79dd
Author: Jeremy Allison <jra at samba.org>
Date: Tue Apr 9 10:38:24 2013 -0700
Check SMB_VFS_NEXT_OPENDIR return in dirsort_opendir().
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 7e437a39abaee1133ea4c30e75ef53eb47ca64b6
Author: Jeremy Allison <jra at samba.org>
Date: Tue Apr 9 10:29:47 2013 -0700
Clean error paths in opendir and fd_opendir by only setting handle data on success.
Pass extra struct dirsort_privates * to open_and_sort_dir() function
to avoid it having to re-read the handle data.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit cdcb6319127883d724508da3f6140a1e2aca75af
Author: Jeremy Allison <jra at samba.org>
Date: Mon Apr 8 16:40:35 2013 -0700
Protect open_and_sort_dir() from the directory changing size.
Otherwise there could be an error between initial count, allocation
and re-read.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 53d980bb0e70e40a07092c07d5fbd59fc8957f49
Author: Jeremy Allison <jra at samba.org>
Date: Mon Apr 8 16:38:03 2013 -0700
Use an index i rather than re-using a state variable.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit b30697f6388600d1557a96ff3ff3a3548ee99d69
Author: Jeremy Allison <jra at samba.org>
Date: Mon Apr 8 16:31:53 2013 -0700
Protect against early error in SMB_VFS_NEXT_READDIR.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit c55eb371144d0ab91b1254b85f2b2a3d4aab8b68
Author: Jeremy Allison <jra at samba.org>
Date: Mon Apr 8 15:11:28 2013 -0700
Change source3/modules/vfs_dirsort.c from MALLOC -> TALLOC.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit f7756137e8f8a7591c9d95482ca1fca3f6484a51
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Apr 5 12:01:17 2013 +1100
scripting-provision: Do not enforce domain != realm if we are joining an existing domain
This will allow us users to join existing oddly named domains without
objection from provision.
Andrew Bartlett
Reviewed-by: Matthieu Patou <mat at matws.net>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu Apr 11 10:41:02 CEST 2013 on sn-devel-104
commit 7955bf473f63e31566e29299b03d44d9b450d1ae
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Apr 8 17:25:27 2013 +1000
build: Raise minimum python version to 2.5.0 for samba build
RHEL5 has a python26 package for a modern python, and was the main reason we
kept python 2.5 support.
However, this support never actually worked for AD DC installations,
as samba-tool uses a feature only in 2.5 and above. Very few folks
noticed and those were on RHEL5, and moving to 2.5 allows us to remove
some other workarounds.
Andrew Bartlett
Reviewed-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit afd291b1dee44b2400bed119bccfc0b722d8cc9c
Author: Jean Raby <jraby at inverse.ca>
Date: Wed Apr 10 21:33:34 2013 -0400
Avoid leaking temp file if an exception is raised
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu Apr 11 06:06:03 CEST 2013 on sn-devel-104
commit 8aae8b5bad167ac732b7f8949dfb40aebb2f26a9
Author: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
Date: Thu Apr 4 13:29:01 2013 +0200
s3:smbd: do not access data behind req->buf+req->buflen in srvstr_pull_req_talloc()
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Wed Apr 10 02:03:13 CEST 2013 on sn-devel-104
commit a70e9db0f325e9be85983c172f0cc68992b0f593
Author: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
Date: Thu Apr 4 13:24:36 2013 +0200
s3:smbd: convert srvstr_pull_req_talloc() into a function
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 98f9e5edd35d6fb54dea74f799b017967b0a13fd
Author: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
Date: Thu Apr 4 12:59:36 2013 +0200
s3:smbd: do not access data behind req->buf+req->buflen in srvstr_get_path_req_wcard()
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e7e37b3b90100f762a45f2f3c047e14e3619c216
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Apr 5 15:23:20 2013 +1100
python-samba-tool domain classicupgrade: Make failure to connect directly to the LDAP backend fatal
This is better than failing just a little further down the stack with a useless error
about use-before-set.
Andrew Bartlett
Reviewed-by: Michael Adam <obnox at samba.org>
commit 45a596fbe9ed2b198956d58784999df780f6dd65
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Apr 8 08:33:55 2013 +1000
build: Remove extra space in shebang
Reviewed-by: Michael Adam <obnox at samba.org>
commit 58e3c5323e343dcab1c528c6b6a44925b76cb297
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Apr 8 15:57:45 2013 +1000
build: Replace #!/usr/bin/env python with passed in PYTHON=
This means that if we were forced to use a specific python for the build, we
will put that binary into the top of samba-tool, so it continues to work
after the install.
Andrew Bartlett
Reviewed-by: Michael Adam <obnox at samba.org>
commit 69b3d1944501f65427fbd12e4ddd3b66e67deedd
Author: Volker Lendecke <vl at samba.org>
Date: Tue Apr 9 21:18:34 2013 +0200
vfs_fake_perms: Fix bug 9775, segfault for "artificial" conn_structs
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Apr 10 00:12:06 CEST 2013 on sn-devel-104
commit ce2fb2d019b6f8304b81e2d4d68bdac31edcf025
Author: Volker Lendecke <vl at samba.org>
Date: Tue Apr 9 21:07:23 2013 +0200
vfs_fake_perms: Slightly streamline code
Don't initialize a variable directly set
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 60c2953a9d5fa12494a8a767c30913398affe453
Author: Volker Lendecke <vl at samba.org>
Date: Tue Apr 9 21:07:23 2013 +0200
vfs_fake_perms: Slightly streamline code
Do an early error return
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a308db6587c866826a280a60b841f0a3926c1078
Author: Alexander Bokovoy <ab at samba.org>
Date: Wed Apr 3 16:52:45 2013 +0300
s3-netlogon: enumerate UPN suffixes from PASSDB when available
Optionally append list of UPN suffixes if PDB module returns non-empty one.
Refactor fill_forest_trust_array() in source3 to allow reuse of the code between
_netr_DsRGetForestTrustInformation() and _netr_GetForestTrustInformation()
Implement a special case of _netr_DsRGetForestTrustInformation in smbd
when trusted_domain_name is NULL (covered by test_DsrEnumerateDomainTrusts()
in rpc.netlogon torture tests, see comment in source4/torture/rpc/netlogon.c).
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Tue Apr 9 22:19:34 CEST 2013 on sn-devel-104
commit 5952755755fb0ea7f942bb564ca1cfdca5730113
Author: Alexander Bokovoy <ab at samba.org>
Date: Wed Apr 3 16:37:00 2013 +0300
PASSDB: add support to set and enumerate UPN suffixes associated with our forest
Samba PDC may manage a forest containing DNS domains in addition to the primary one.
Information about them is advertised via netr_DsRGetForestTrustInformation when
trusted_domain_name is NULL, according to MS-NRPC and MS-LSAD, and
via netr_GetForestTrustInformation.
This changeset only expands PASSDB API; how suffixes are maintained is left
to specific PDB modules. Set function is added so that suffixes could be
managed through 'net' and other Samba utilities, if possible.
One possible implementation is available for ipasam module in FreeIPA:
http://git.fedorahosted.org/cgit/freeipa.git/commit/?id=cc56723151c9ebf58d891e85617319d861af14a4
Reviewed-by: Andreas Schneider <asn at samba.org>
commit b752417f2d6c478524f0fbf0fda1a5d0401b6f9e
Author: Alexander Bokovoy <ab at samba.org>
Date: Wed Apr 3 16:01:34 2013 +0300
s3-waf: filter out ldapsam internal init functions
pdb_ldapsam_init* functions (init and init_common) are used in
pdb_ipa.c and pdb_nds.c which are always linked together with
pdb_ldap.c where pdb_ldapsam_init* functions reside.
Tested with both ldapsam integrated (into libpdb) and as
a separate module.
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 6058bc9bb6ac315fbe7cb18e1d07a846f7849e22
Author: Alexander Bokovoy <ab at samba.org>
Date: Wed Apr 3 15:52:06 2013 +0300
wafsamba: fix samba_abi for default catch-all case
Only filter out the symbol when positive match was not found and there is
negative match.
ABI signature file generator worked incorrectly for cases when mixture of
positive and negative matches were provided. This resulted in generating empty
signature file for libpdb since there was no catch-all positive match anymore.
Commit 9ba44cc610426fb558b49aa9680b5bdf55c29082 removed explicit '*' positive
match and corresponding vscript generator adds '*' by default if global match
list is empty, so this commit introduces feature parity into signature
generator.
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 28da1af476853e6b49765bd04a496163e8ebd448
Author: Volker Lendecke <vl at samba.org>
Date: Tue Apr 9 16:37:29 2013 +0200
winbindd: Avoid a fd leak when we can not fork
Signed-off-by: Volker Lendecke <vl at samba.org>
Signed-off-by: Jim McDonough <jmcd at samba.org>
Autobuild-User(master): Jim McDonough <jmcd at samba.org>
Autobuild-Date(master): Tue Apr 9 20:27:27 CEST 2013 on sn-devel-104
commit f61ee7238b8430572fb266521dad3ee000d1f252
Author: Volker Lendecke <vl at samba.org>
Date: Tue Apr 9 14:29:11 2013 +0200
pylibsmb: Avoid a segfault if no credentials are passed to libsmb.Conn()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
Autobuild-User(master): Richard Sharpe <sharpe at samba.org>
Autobuild-Date(master): Tue Apr 9 18:30:06 CEST 2013 on sn-devel-104
commit 045c446b5a3ffc7e56d46ac4aa4acae9d27d9f49
Author: Andreas Schneider <asn at samba.org>
Date: Thu Apr 4 12:18:25 2013 +0200
BUG 9766: Cache name_to_sid/sid_to_name correctly.
If there is no domain_name specified we still need to set to for
caching else we will not find the entry later if we lookup the entry
with the domain_name.
Reviewed-by: Guenther Deschner <gd at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Signed-off-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Günther Deschner <gd at samba.org>
Autobuild-Date(master): Tue Apr 9 16:32:44 CEST 2013 on sn-devel-104
commit b7c0330b7429ce1b9cda8b1c2446b3a21cbd29db
Author: Andreas Schneider <asn at samba.org>
Date: Fri Apr 5 14:07:37 2013 +0200
BUG 9139: Fix the username map optimization.
If we successfully map a user. We call
set_last_from_to(user_in, unixname);
in the while loop reading the map file. After a successfull map we don't
stop and continue the loop to check all other mappings in the username
mapfile. But when we hit the end of the file and leave the loop we call:
set_last_from_to(user_in, user_in);
This overwrites the successful mapping, and the next time we call
map_username() we skip the username and no mapping is done.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 243278a2c5ec29c153fa7d66678452a97e6edbc0
Author: Volker Lendecke <vl at samba.org>
Date: Fri Apr 5 16:44:08 2013 +0200
doc: Document performance impact of "hide unxx" parameters
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Fri Apr 5 18:40:58 CEST 2013 on sn-devel-104
commit ca0d38596d711e70a1d58657024aabd8c131512b
Author: Stef Walter <stefw at gnome.org>
Date: Thu Apr 4 15:55:10 2013 +0200
getpass: Don't fail if stdin is not a tty
We don't need to manipulate the tty state (such as turning off
echo) when prompting for passwords if we're not reading from a tty.
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
Autobuild-User(master): Alexander Bokovoy <ab at samba.org>
Autobuild-Date(master): Fri Apr 5 07:34:37 CEST 2013 on sn-devel-104
commit 7f366d745c1d4e833470d853ec484459157616e7
Author: Volker Lendecke <vl at samba.org>
Date: Thu Apr 4 10:23:02 2013 +0200
tevent: Only set poll_ev->delete=false if it was true
Might not be noticable, but I thought it would be an obvious tiny
optimization. Possibly the compiler already does this.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Thu Apr 4 18:32:39 CEST 2013 on sn-devel-104
commit a7f067c244401d37057a7ed7c00ba4ffc76f2b5a
Author: Andreas Schneider <asn at samba.org>
Date: Wed Apr 3 15:46:00 2013 +0200
BUG 9699: Fix adding case sensitive spn.
We should be able to define the case of the spn cause it is important
for some services like nfs. 'net ads keytab add "nfs"' should not
result in an uppercase spn.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Apr 3 23:57:32 CEST 2013 on sn-devel-104
commit 5dad084ab176820af8d661f681e0659596d067cb
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Tue Apr 2 17:00:01 2013 +1030
ccan: fix HAVE_BSWAP_64 for autoconf.
Autoconf defines HAVE_BSWAP_64_DECL, we want HAVE_BSWAP_64.
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b5d5b9a40eb13f89a552e29096deed52229c147e
Author: Volker Lendecke <vl at samba.org>
Date: Wed Apr 3 13:24:53 2013 +0200
libsmbclient: Fix cli_session_setup_guest_send
This worked fine so far, but for the wrong reason: We only ever called
this through the sync wrapper. The tevent_req_nterror in the NT_STATUS_OK
case does not call tevent_req_finish. So the tevent_loop_poll did call
into the core send/receive smb code. This is a fix for the case when
smb1cli_req_chain_submit fails for some reason.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Wed Apr 3 18:39:30 CEST 2013 on sn-devel-104
commit ed76e65172ba1a21ef21b3c0267ed5ef1aa8aa9b
Author: David Disseldorp <ddiss at samba.org>
Date: Wed Apr 3 14:01:00 2013 +0200
ntvfs: support setfileinfo with FULL_EA_INFORMATION
Use existing unmarshall and set helper functions. This allows the
smb2.setinfo.setinfo test to run against the ntvfs file server.
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Wed Apr 3 16:14:33 CEST 2013 on sn-devel-104
commit 79038397aa8786c92401312973185c7b14e8fa66
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Mar 22 09:39:42 2013 +0100
s3:wscript: change --with-dmapi to default=auto to match the autoconf build
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Wed Apr 3 11:45:12 CEST 2013 on sn-devel-104
commit 81cc940c994424d351ac282383df4d1a57d6b614
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Mar 22 09:37:09 2013 +0100
wafsamba: display the default value in help for SAMBA3_ADD_OPTION
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 0d75c902254c6e27964c631459ef8e9b379b77fc
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Mar 22 09:30:05 2013 +0100
s3:modules: fix the build of vfs_notify_fam (bug #9545)
This adds the --with-fam option and configure checks.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 821171e422133d64e7c07b4d610984c33cd23244
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Mar 28 11:04:31 2013 +0100
s3:lib/server_mutex: open mutex.tdb with CLEAR_IF_FIRST
/var/lock/samba is typically on tpmfs.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 54529fd354275cfb4ece407f95ef34675b202ea3
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Mar 28 11:00:27 2013 +0100
s3:lib/gencache: place gencache.tdb into /var/cache/samba
/var/lock/samba is located on tmpfs on newer systems,
but we want to keep things like the server affinity cache
across reboots.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit b986a3a9c988c6ec29c0e0a2f8609d5132e952f4
Author: Jeremy Allison <jra at samba.org>
Date: Thu Mar 28 08:55:11 2013 -0700
Ensure EA value is allocated on the right context.
Ensure we free on error condition (tidyup, not a leak).
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at suse.de>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Tue Apr 2 21:54:33 CEST 2013 on sn-devel-104
commit 9b94de161f30bb34c666c0cf0cc94250e6a7b863
Author: Jeremy Allison <jra at samba.org>
Date: Wed Mar 27 11:54:34 2013 -0700
Final fix for bug #9130 - Certain xattrs cause Windows error 0x800700FF
The spec lies when it says that NextEntryOffset is the only value
considered when finding the next EA. We were adding 4 more extra
pad bytes than needed (i.e. if the next entry already was on a 4
byte boundary, then we were adding 4 additional pad bytes).
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at suse.de>
commit 43becd6f305bd5d21d886027d38a92d4dff22d75
Author: Jeremy Allison <jra at samba.org>
Date: Tue Mar 26 16:46:51 2013 -0700
Ensure we don't return uninitialized memory in the pad bytes.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at suse.de>
commit 7bee3ef68490bb38942d717e03e203d00be32f9f
Author: Jeremy Allison <jra at samba.org>
Date: Tue Mar 26 13:26:49 2013 -0700
Add a test to show that zero-length EA's are never returned over SMB2.
Zero length EA's only delete an EA, never store. Proves we should
never return zero-length EA's even if they have been set on the
POSIX side.
ntvfs server doesn't implement the FULL_EA_INFORMATION setinfo
call, so add to selftest/knownfail.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at suse.de>
commit b96bc9fa260c397887ba6199181f3b8bca7046a6
Author: Jeremy Allison <jra at samba.org>
Date: Tue Mar 26 16:38:00 2013 -0700
Fix bug #9130 - Certain xattrs cause Windows error 0x800700FF
Ensure ntvfs server never returns zero length EA's.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at suse.de>
commit 875bedddddc51df59f85ae7bbd7db52fbfb5ffef
Author: Jeremy Allison <jra at samba.org>
Date: Tue Mar 26 16:37:22 2013 -0700
Fix bug #9130 - Certain xattrs cause Windows error 0x800700FF
Ensure we never return any zero-length EA's.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at suse.de>
commit 15fa043b7d362ee197835c0a72a936684c774472
Author: Jeremy Allison <jra at samba.org>
Date: Tue Mar 26 15:54:31 2013 -0700
Change estimate_ea_size() to correctly estimate the EA size over SMB2.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at suse.de>
commit d9e7c8219fd8b3d770301a87bc1cd62b07b989ca
Author: Jeremy Allison <jra at samba.org>
Date: Tue Mar 26 15:46:06 2013 -0700
Modify fill_ea_chained_buffer() to be able to do size calculation only, no marshalling.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at suse.de>
commit 1e8bcce52f233722fad5c25f2467b86d97cadfa0
Author: Jeremy Allison <jra at samba.org>
Date: Fri Mar 29 10:07:20 2013 -0700
Ensure we can never return an uninitialized EA list.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at suse.de>
commit 50e0060091e008ad93fcfbb68cbbb81da5dec067
Author: Richard Sharpe <realrichardsharpe at gmail.com>
Date: Tue Apr 2 06:48:03 2013 -0700
Add a comment about why we are removing the INHERITED bit so people understand.
Signed-off-by: Richard Sharpe <realrichardsharpe at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Tue Apr 2 20:05:13 CEST 2013 on sn-devel-104
commit 5e9195756e7f0355a022b00f9d1cbfd8e761e006
Author: Andreas Schneider <asn at samba.org>
Date: Tue Apr 2 13:08:19 2013 +0200
BUG 9758: Don't leak the epm_Map policy handle.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
Autobuild-User(master): Alexander Bokovoy <ab at samba.org>
Autobuild-Date(master): Tue Apr 2 17:16:56 CEST 2013 on sn-devel-104
commit 257d2ef527b257b2228fc9bbfddfb3c604b79fb4
Author: Andreas Schneider <asn at samba.org>
Date: Tue Apr 2 13:09:13 2013 +0200
epm: Increase debug level for already registered endpoints.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 5530cc4816534d64d50403c266616633db8202cc
Author: Jeremy Allison <jra at samba.org>
Date: Mon Apr 1 20:11:26 2013 -0700
Fix bad SMB2 opcode reading in server.
SMB2 opcodes are 16-bit values. We should *never*
be reading them with IVAL(inhdr, SMB2_HDR_OPCODE),
it should always be SVAL(inhdr, SMB2_HDR_OPCODE).
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
Autobuild-User(master): Richard Sharpe <sharpe at samba.org>
Autobuild-Date(master): Tue Apr 2 07:28:48 CEST 2013 on sn-devel-104
commit 7fd926fcdcb92a8e1e2b0c29371f2eb2ae4057df
Author: Richard Sharpe <realrichardsharpe at gmail.com>
Date: Wed Mar 27 19:36:43 2013 -0700
Make sure that we only propogate the INHERITED flag when we are allowed to.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Mar 28 19:43:41 CET 2013 on sn-devel-104
commit ffe14d99083fe5344fa7678e7ad780d930398427
Author: Jeremy Allison <jra at samba.org>
Date: Mon Mar 25 09:54:50 2013 -0700
Optimization suggested by Volker. Don't do a stat system call on normal read path.
Only do it if we need it in the sendfile() path.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Thu Mar 28 17:51:22 CET 2013 on sn-devel-104
commit adbe6cba005a2060b0f641e91b500574f4637a36
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Mar 27 08:43:18 2013 +0100
libcli/auth: avoid using transactions a chainlock is enough
We're just writting a single record into a CLEAR_IF_FIRST|TDB_NOSYNC
tdb.
We just need to make sure we lock the record between reading and writting.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Thu Mar 28 14:52:14 CET 2013 on sn-devel-104
commit 40d783c397ea21d03d1ea7130a438dd8c0d817f1
Author: Richard Sharpe <realrichardsharpe at gmail.com>
Date: Tue Mar 26 20:17:11 2013 -0700
Call smb_panic when we try to exit the server uncleanly. This gives us the normal traceback and memory dump, but also runs the normal panic action.
Signed-off-by: Richard Sharpe <realrichardsharpe at gmail.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Mar 27 22:58:37 CET 2013 on sn-devel-104
commit 1dcd75df4941d7032a66d3fbb86ac76964444a3f
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Mar 15 13:00:55 2013 +1100
auth/ntlmssp: Avoid use-after-free of user_info after logon failure at log level 5
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e8657887a9c1deadbd4e98c8b66cd46bdf36402a
Author: Volker Lendecke <vl at samba.org>
Date: Wed Mar 27 10:23:50 2013 +0100
dbwrap: Add a comment explaining a restriction
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Wed Mar 27 13:40:15 CET 2013 on sn-devel-104
commit e3f5e474c826940ebaf43256cb06a50309ba3ef5
Author: Volker Lendecke <vl at samba.org>
Date: Wed Oct 31 13:13:50 2012 +0100
smbd: Remove an optimization that became unnecessary
After we only collect nonlocal vnns in idx_state.vnns now, at this point
we *know* we have something to send to a remote node. The previous code
avoided the call to notify_push_remote_blob with an if-statement that
has now become unnecessary.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Mar 26 13:16:39 CET 2013 on sn-devel-104
commit 07ae7e22f789a67bbd5e9536e1227a1c394990f9
Author: Volker Lendecke <vl at samba.org>
Date: Wed Oct 31 13:11:19 2012 +0100
smbd: We don't collect our own vnn anymore
notify_trigger_index_parser will not anymore add ourselves into the vnn
list that it collects.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit ebb027b738d0addd3ee5c205c5370b01859aee71
Author: Volker Lendecke <vl at samba.org>
Date: Wed Oct 31 13:10:12 2012 +0100
smbd: Slightly simplify notify_trigger
We have a good chance that we did not collect any remote vnns. This
avoids trying to walk the remote vnns altogether.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit eb885d1fdd6a2be603061aeef63790c92ca9ba56
Author: Volker Lendecke <vl at samba.org>
Date: Wed Oct 31 13:08:18 2012 +0100
smbd: Slightly simplify notify_trigger
This straightens the for-loop walking the path components slightly
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 032da72e2b81685f292622cfd2ced14af257849d
Author: Volker Lendecke <vl at samba.org>
Date: Wed Oct 31 13:02:19 2012 +0100
smbd: Avoid some talloc_realloc in notify_internal
For the nonclustered case we will only ever have one vnn in notify_index.tdb.
For this case, without this patch we did talloc_realloc when collecting vnns to
be able to do the memcpy instead of explicit copy with a for-loop. This new
code will partition the new vnns we see when parsing a notify_index.tdb record
into ourselves and all foreign vnns, only really collecting the foreign ones in
an array.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit c2b26a43ffae22c9dff7929c48531fec9e6ed922
Author: Volker Lendecke <vl at samba.org>
Date: Sat Nov 24 14:42:06 2012 +0000
dbwrap-ctdb: Avoid a talloc_stackframe()
We have only a single allocation in this routine, so I think we can live
without a stackframe.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit d147194466560488cda9f6e5e993c985cea02289
Author: Volker Lendecke <vl at samba.org>
Date: Sat Nov 24 14:15:38 2012 +0000
ctdb-conn: remove ctdbd_fetch
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 1409895d9e271744060d3f1ef2c71da5b5151f6a
Author: Volker Lendecke <vl at samba.org>
Date: Sat Nov 24 14:14:37 2012 +0000
dbwrap-ctdb: Use ctdbd_parse in db_ctdb_parse_record
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit abe4046643735cf0bc5bcdfe330dd946ab221808
Author: Volker Lendecke <vl at samba.org>
Date: Fri Nov 23 17:54:57 2012 +0100
ctdb-conn: Add ctdbd_parse
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit c8c0bf74805c61b1379dab1d4529df0004872bb4
Author: Volker Lendecke <vl at samba.org>
Date: Mon Mar 18 14:39:04 2013 +0100
tdb: Fix blank line endings
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit a92c08e18bca2f1db671dc5e2d0db4adbf39752d
Author: Volker Lendecke <vl at samba.org>
Date: Mon Mar 18 10:53:49 2013 +0100
tdb: Little format change
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit d4ebeeb78865c6a20a85437b82a1302921f3d1fe
Author: Volker Lendecke <vl at samba.org>
Date: Mon Mar 25 14:52:24 2013 +0100
smbd: Avoid sending 0-sized keys to dbwrap
Start the notification one level below /. Sharing and notifying / for changes
is broken at this moment anyway. When sharing / and someone wants to get
notified for changes under /usr, we store "//usr" as the notify_index key. So
this patch does not break anything that is not broken today, and it avoids a
bogus call to dbwrap_parse_records.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit bbb4068c933ecc043025633a13c62bf04eaf6d49
Author: Volker Lendecke <vl at samba.org>
Date: Sat Nov 24 14:51:02 2012 +0000
dbwrap: Use tdb_null in db_ctdb_delete
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
Autobuild-User(master): Christian Ambach <ambi at samba.org>
Autobuild-Date(master): Mon Mar 25 19:42:30 CET 2013 on sn-devel-104
commit 30adf0cdbae6d9aaf2e72513d9c33267248f20c0
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Mar 22 21:58:25 2013 +1100
scripting: Fill the ProvisionNames hash with strings, not ldb.MessageElement or Dn
This avoids the need to fix it up again in samba_upgradedns.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Mon Mar 25 13:25:30 CET 2013 on sn-devel-104
commit 5d42260eecfd4f26cc82637ce1bc989083c9eb9d
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Mar 22 21:36:49 2013 +1100
samba-tool ldapcmp: Remove the GUID -> name mappings
These mappings are very convenient, however because they are not
one-to-one, they lead to differences being reported when none exist,
dependent only on the order the schema searches return results in.
Sadly the time saved by the names is offset by the time wasted chasing
the 'differences' that don't exist.
This in turn fixes some tests that were previously knownfail
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 1589e46d11f29551f3598876b62e29fcbad06580
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Mar 22 17:12:43 2013 +1100
selftest: Add tests for samba-tool dbcheck --reset-well-known-acls
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 874a93bc1c437543474a6c574b0065b7b953ad38
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Mar 22 22:16:03 2013 +1100
scripting: Modify samba.descriptor.get_diff_sds() to cope with a missing reference owner
This allows the reference SD not to have an owner specified, and still
have the comparison with a database SD that does have an owner pass.
(And the same for owning group).
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 4789a3072a4241841c096115dbdb0c3259968e68
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Feb 11 14:49:01 2013 +1100
samba-tool dbcheck: Allow dbcheck to correct an nTSecurityDescriptor without an owner or group
This is done by making a modification to the SD, which triggers it to be
filled in if we have the correct session_info established on the DB.
However, we normally want dbcheck running as system, so we wrap
the session_info set around this operation only.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 810f8b48d925ea15f3439c4b228741d8fddaccd8
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Feb 11 14:49:01 2013 +1100
samba-tool dbcheck: Add --reset-well-known-acls
This will allow an upgrade from Samba 4.0.0 without needing to run
samba_upgradeprovision, which for now is not the preferred upgrade
tool.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 9040e2684161ce75738e9da0fee191aa34858607
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Mar 22 16:19:27 2013 +1100
scripting: Move get_diff_sds from samba.upgradehelpers to samba.descriptor
This helps avoid a dependency loop when we use get_diff_sds in dbcheck.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit a113ddbf881c5905bbf7072638c7ba8843eeb85e
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Mar 22 11:15:38 2013 +1100
scripting: Modify samba.descriptor.get_wellknown_sds() use samdb calls only
We need this routine not to use the names context as this is tied to
provision, and we end up in a circular dependency if we use that in
dbcheck.
Andrew Bartlett
commit 352aff8ed7e06c14b7a00a56b31c79ffddf71dd4
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Mar 21 13:34:26 2013 +1100
scripting: Move samba.provision.descriptor to samba.descriptor
This will allow dbcheck to import it, without a cirucular dependency via
samba.provision importing dbcheck.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit e81a97dd6fc2da701f2cbf42513311a7a44adad3
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Mar 21 12:49:46 2013 +1100
scripting: Make samba.provision.descriptor.get_wellknown_sds() return ldb.Dn objects
As we look to use this function in more places, it does not make sense to constantly create
Dn objects from the strings.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 6df17fe799968ca7e2f92ce9e294e3962ac8cbaf
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Mar 20 14:50:55 2013 +1100
scripting: Fix documentation comment on upgradehelpers.py:get_clean_sd
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 3da89b01faebba669434b07db344c203a4521ca2
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Mar 20 14:12:26 2013 +1100
scripting: Move the list of well known SDs to samba.provision.descriptor
This will allow us to call this from dbcheck.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit afe9343880ee27cf9fe937c6379c469435ef20d6
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Mar 22 13:47:46 2013 +1100
build: Do not pass CPP="" to pidl, skip the env variable entirely
This will cause pidl to use $CC -E instead.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 7dc6dfd90c5182ed85042b22d4864d3e9b007531
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Mar 22 13:06:43 2013 +1100
build: Remove the forced use of only the first part of the compiler string
This corrects parts of 378295c3fe813c70815a14c7de608e4a859bd6cc and
301d59caf2ee6f49e108b748b0e38221dec9bb96. This is seen if CC="ccache
gcc" and CPP isn't used for some reason.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit d27f00cd4cd14b7729861121ed221e3cf2ecf9ba
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Mar 20 12:46:22 2013 +1100
vfs-btrfs: Fix build on 32 bit platforms by using long long types
Reviewed-by: Rusty Russell <rusty at rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Autobuild-User(master): Rusty Russell <rusty at rustcorp.com.au>
Autobuild-Date(master): Sun Mar 24 06:17:55 CET 2013 on sn-devel-104
commit c202dc9705cf87542094ee1930e5dab9923c605b
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Sun Mar 24 13:58:02 2013 +1030
Revert "vfs_btrfs: fix compile on 32-bit platforms."
This reverts commit fd6d0361d6fef5f8175967ddbae4a2b1d79dfcad.
Unreviewed, and Andrew has a better fix.
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
commit 068e0e2b38fb109eb1d1306c6d74bfa86ec0c4b8
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Sat Mar 23 17:27:57 2013 +1030
ntdb: don't call open hook when re-opening an existing database.
In particular, the Samba dbwrap wrapper can do this for schannel_store,
with the openhook set to clear the database if it can get the lock
(which, being in the same process, it can).
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Autobuild-User(master): Rusty Russell <rusty at rustcorp.com.au>
Autobuild-Date(master): Sat Mar 23 09:39:50 CET 2013 on sn-devel-104
commit fd6d0361d6fef5f8175967ddbae4a2b1d79dfcad
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Sat Mar 23 17:26:57 2013 +1030
vfs_btrfs: fix compile on 32-bit platforms.
uint64_t are not unsigned longs on 32-bit platforms:
[3265/3996] Compiling source3/modules/vfs_btrfs.c
../source3/modules/vfs_btrfs.c: In function ‘btrfs_copy_chunk_send’:
../source3/modules/vfs_btrfs.c:118:3: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘uint64_t’ [-Werror=format]
../source3/modules/vfs_btrfs.c:118:3: error: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘int64_t’ [-Werror=format]
../source3/modules/vfs_btrfs.c:118:3: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘uint64_t’ [-Werror=format]
../source3/modules/vfs_btrfs.c:118:3: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 7 has type ‘uint64_t’ [-Werror=format]
../source3/modules/vfs_btrfs.c: In function ‘btrfs_copy_chunk_recv’:
../source3/modules/vfs_btrfs.c:180:2: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘off_t’ [-Werror=format]
cc1: some warnings being treated as errors
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
commit 12ebb1ba1599dd30db9376a64530667656b803b8
Author: Volker Lendecke <vl at samba.org>
Date: Thu Mar 21 22:00:06 2013 +0100
smbd: Tune "dir" a bit.
for i in $(seq 1 20000) ; do echo dir ; done | smbclient //127.0.0.1/tmp -U%
without and with this patch:
$ time bin/smbd -d0 -i
smbd version 4.1.0pre1-GIT-1f139ae started.
Copyright Andrew Tridgell and the Samba Team 1992-2013
Beendet
real 0m28.342s
user 0m10.249s
sys 0m10.513s
$ time bin/smbd -d0 -i
smbd version 4.1.0pre1-GIT-1f139ae started.
Copyright Andrew Tridgell and the Samba Team 1992-2013
Beendet
real 0m27.348s
user 0m9.089s
sys 0m10.853s
The "real" timestamp is irrelevant, this also contains the time between
starting smbd and the smbclient job. It's the "user" time. The result that this
patch improves the time spent in user space by 10% is consistent.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Mar 22 22:10:57 CET 2013 on sn-devel-104
commit 84dad60672aa5fdc0ff20f5fb8471d5209174063
Author: Jeremy Allison <jra at samba.org>
Date: Thu Mar 21 13:47:07 2013 -0700
Fix bug #9733 - smbcontrol close-share is not working.
As part of forcibly disconnecting a client from a share,
smbd must atomically call reload_services() to ensure that
the entry in the ServicePtrs[] array corresponding to
that share is removed if the share was removed from
the smb.conf or registry entries.
Otherwise the ServicePtrs[] array entry for the share
remains active and the client races to auto-reconnect to
the share before a second message to reload the smb.conf
file can be sent.
This has to be done as part of the close-share message
processing, as removing the share from the smb.conf file
first, then telling the smbd to reload followed by the
forcible disconnect message doesn't work as in this
sequence of events when the reload message is received
the client is still connected to the share, so the
ServicePtrs[] entry is still left active.
The forcible-disconnect + service reload has to be done
together as an atomic operation in order for this to work.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Fri Mar 22 20:10:11 CET 2013 on sn-devel-104
commit 566a2e6828bb5d6ea3a35e24938675a296bbe95b
Author: Jeremy Allison <jra at samba.org>
Date: Fri Mar 8 13:44:08 2013 -0800
Fix tevent testsuite issue on Solaris.
On Solaris/Nexenta/Illumos once a pipe is full it will not be reported
as writable until PIPE_BUF (actually on Solaris 4096, which is less than
PIPE_BUF) bytes have been read from it.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Fri Mar 22 18:16:45 CET 2013 on sn-devel-104
commit c3ee49a09944cec9ee1e41c32dd31bdc170f610c
Author: Jeremy Allison <jra at samba.org>
Date: Fri Mar 8 10:09:01 2013 -0800
Solaris/Illumos/Nexenta creates pipes that are bi-directional by default.
Ensure the test code will pass against such a system (allow writes/reads
going both ways).
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 9624ca4f884444da3810c89c97942faef3360df4
Author: Andreas Schneider <asn at samba.org>
Date: Fri Mar 22 14:15:57 2013 +0100
BUG 9735: Fix winbind seperator in upn to username conversion.
Reviewed-by: Günther Deschner <gd at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Fri Mar 22 16:18:06 CET 2013 on sn-devel-104
commit 1f139ae2d162ebb045ce4eabb76a138baedfe44a
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Mar 18 11:52:50 2013 +0000
s3:waf fix build on AIX
AIX acl code needs to be built by default on AIX,
otherwise smbd will fail to start because of missing symbols
This fixes Bug 9557 - build succeeds, but binaries don't run
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
Autobuild-User(master): Christian Ambach <ambi at samba.org>
Autobuild-Date(master): Thu Mar 21 16:31:19 CET 2013 on sn-devel-104
commit 599a699adec1f8f0a432d9c34f378d48930ca29b
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Mar 20 08:49:20 2013 +0100
s4:torture: let raw.read accept larger reads than 0x10000
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Mar 20 21:53:20 CET 2013 on sn-devel-104
commit c9066b057a6aa3cc1960124c9f2519413a2b57da
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Mar 19 17:11:03 2013 +0100
s4:torture: raw.read fix large reads against windows
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit df618e33ac011c018374af8da021c7b5f1cc1427
Author: Jeremy Allison <jra at samba.org>
Date: Wed Mar 13 15:45:12 2013 -0700
s3:selftest: Add LARGE_READX test into our make test infrastructure.
Tested against non-encrypted and encrypted connections.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit d9afb2b14df642de5d9225d10cc20cac7fd5133f
Author: Jeremy Allison <jra at samba.org>
Date: Wed Mar 13 15:43:21 2013 -0700
s3:torture: Add new LARGE_READX test to investigate large SMBreadX behavior.
Signed-off-by: Jeremy Allison <jra at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 5a05e687ce724ea808cdb1e6627b9c67804eb879
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Mar 18 19:50:38 2013 +0100
s4:smb_server: fix large read_andx requests
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit fd88520497b4043e9d81656f7cb56a7b25245c2a
Author: Jeremy Allison <jra at samba.org>
Date: Fri Mar 15 11:57:48 2013 -0700
s3:smbd: Add functions calc_max_read_pdu()/calc_read_size() to work out the length we should return.
LARGE_READX test shows it's always safe to return a short read.
Windows does so. Do the calculations to return what will fit
in a read depending on what the client negotiated.
Signed-off-by: Jeremy Allison <jra at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 21707defe06e1db18a6645b0b56db4178e3df5f6
Author: Jeremy Allison <jra at samba.org>
Date: Fri Mar 15 11:53:04 2013 -0700
s3:smbd: Remove server_will_accept_large_read() and erroneous comment.
We're going to replace this with a function that calculates
the max PDU to return on a read and supports short reads.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 36f6a8abb2ad0c7d0551679cc61a29fa2dc16d80
Author: Jeremy Allison <jra at samba.org>
Date: Mon Mar 18 15:05:24 2013 -0700
s3:smbd: Fix off-by 4 error in wrap protection code in create_outbuf()
Subtract 4 from smb_size (39) here as the length
of the SMB reply following the 4 byte type+length
field can be up to 0xFFFFFF bytes.
Signed-off-by: Jeremy Allison <jra at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit b80111adb3a30ff386b3c45fcf962c417256bb59
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Mar 18 12:36:30 2013 +0100
s3:smbd: add some const to req_is_in_chain()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit be98c1c889166a5f2b83e1e29d7dcbbaf6baab8f
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Mar 19 13:24:46 2013 +0100
s3:smbd: remove silly (SMB_OFF_T_BITS == 64) checks
configure will abort if sizeof(off_t) is not 8.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d24b8afb79f75b1db9301b79862be484a4932979
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Mar 18 10:10:25 2013 +0100
s3:smbd: keep global_client_caps and max_send from the first successful session setup
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 40c3db9b6a584a6c243fd02b12269d54e7425fea
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Mar 18 09:33:00 2013 +0100
s3:libsmb: let cli_read_andx_create() accept any length
It's up to the server to decide the allowed length.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 1111d46cc52e868cf4894909b71f1574196e2887
Author: Jeremy Allison <jra at samba.org>
Date: Wed Mar 13 15:23:52 2013 -0700
libcli/smb: smb1cli_inbuf_parse_chain() and smb1cli_conn_dispatch_incoming() should use smb_len_tcp.
They have to cope with large READX call replies that have
a length greater than smb_len_nbt() can handle.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 53d348dff082f9c18e06f99ec646127467f339e7
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Mar 18 15:02:55 2013 +0100
libcli/smb: defer failing for missing NEGOTIATE_SECURITY_SIGNATURES_ENABLED
Windows servers take a look at the FLAGS2_SMB_SECURITY_SIGNATURES_REQUIRED
flag during a session setup and turn on signing if the client requires it.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b041dc9451e210acc82a82b75e02e4166d8973d5
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Mar 19 09:03:38 2013 +0100
s3:libsmb: make use of SMB_CAP_LEGACY_CLIENT_MASK instead of SMB_CAP_CLIENT_MASK
This should allow smbclient to keep using large reads against older Samba versions
(<= 3.6.x) and other servers that may also require this.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3d7a4db6bc5cd42432393bf69622c435e67e811f
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Mar 19 09:02:52 2013 +0100
libcli/smb: add SMB_CAP_LEGACY_CLIENT_MASK define
Older Samba releases (<= 3.6.x)
expect the client to send CAP_LARGE_READX
in order to let the client use large reads.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit f7564cae4cdd1e2629404c5a1229978451584257
Author: Gregor Beck <gbeck at sernet.de>
Date: Wed Mar 20 13:00:26 2013 +0100
s3:registry accept windows like long hivenames
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Reviewed-by: Christian Ambach <ambi at samba.org>
Autobuild-User(master): Christian Ambach <ambi at samba.org>
Autobuild-Date(master): Wed Mar 20 17:08:52 CET 2013 on sn-devel-104
commit 4490e72426bc55a5680df84fce344aa509219219
Author: Christian Ambach <ambi at samba.org>
Date: Thu Mar 14 23:19:25 2013 +0100
s3:include bump profile memory area version number
forgot to bump this earlier when removing the counters for setdir
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 05a7a10c88be99d864eacd6f9d37a340022f01f6
Author: Volker Lendecke <vl at samba.org>
Date: Mon Mar 18 09:36:17 2013 +0100
wkssvc: Fix bug 9727, NULL pointer dereference
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Mon Mar 18 11:39:27 CET 2013 on sn-devel-104
commit 96d731c79befdee297eb0e72a3488547f6361ab4
Author: Ricky Nance <ricky.nance at weaubleau.k12.mo.us>
Date: Mon Mar 11 14:47:19 2013 -0500
samba-tool group list: add more info to samba-tool group list
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sun Mar 17 12:56:47 CET 2013 on sn-devel-104
commit 1d15fc75a33b7368049876368f4b70c188bbd55e
Author: Jeremy Allison <jra at samba.org>
Date: Fri Mar 15 15:05:31 2013 -0700
Fix bug #9724 - is_encrypted_packet() function incorrectly used inside server.
The is_encrypted_packet() function should only be used on the raw received data
to determine if a packet came in encrypted. Once we're inside the SMB1
processing code in smbd/reply.c we should be looking at the
smb1request->encrypted field to determine if a packet was really encrypted or
not.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Sat Mar 16 12:44:44 CET 2013 on sn-devel-104
commit fd8b258fa20496c3e6360248503f59704d206742
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Mar 15 10:14:35 2013 +1100
examples/libsmbclient: Cast mode_t to unsigned int for GNU/Solaris build
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Mar 15 20:22:08 CET 2013 on sn-devel-104
commit 88e6342936cd82324e6bfed665e81831260a654d
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Mar 15 10:06:10 2013 +1100
s3-lsad: Cast getpid() result to unsigned int for GNU/Solaris build
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6a5cae96788640ddce89a047bbc63b4dbc94ca89
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Mar 15 10:02:53 2013 +1100
s3-epmd: Cast getpid() result to unsigned int for GNU/Solaris build
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 1ccfaa413a887dd573dc03c78fcc621e629d9582
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Mar 15 09:59:31 2013 +1100
vfs_smb_traffic_analyzer: Cast mode_t to unsigned int for GNU/Solaris build
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 174a99f4864745cd995e5983cb95b8c7091d0725
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Mar 15 09:52:13 2013 +1100
dbwrap: Cast getpid() result to unsigned int for GNU/Solaris build
Reviewed-by: Jeremy Allison <jra at samba.org>
commit cdc062273ce580877fd47e3f328d24c624dfbc0f
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Mar 14 21:17:54 2013 +1100
spoolssd: Cast getpid() result to unsigned int for GNU/Solaris build
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 1fba1406449880384bb585a0eda6e9be60a868fe
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Mar 14 21:15:18 2013 +1100
s3-smbd/process.c: Cast pid_t result to int for GNU/Solaris build
Reviewed-by: Jeremy Allison <jra at samba.org>
commit bf7da085b125ca9b18bdca22e05a9a6613771e3d
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Mar 14 20:36:34 2013 +1100
s3-lib/server_prefork: Cast pid_t result to unsigned int for GNU/Solaris build
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 21f18d0205bc7aca4166e8436083c16540f95781
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Mar 14 20:18:46 2013 +1100
s4-ntvfs: Cast getpid() result to unsigned int for GNU/Solaris build
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 7ea026e332192ebba4c634c93fed6e02bfb7f89e
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Mar 14 20:14:19 2013 +1100
lib/util: Cast mode_t result to unsigned int for GNU/Solaris build
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 346407443e6210da9c7335df7b898d96ff74c0e3
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Mar 14 19:55:29 2013 +1100
ntdb: Cast getpid() result to unsigned int for GNU/Solaris build
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 29dfc94ca312523c5682235f642fb49030abd995
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Mar 14 19:26:44 2013 +1100
ccan: Cast getpid() result to unsigned int for GNU/Solaris build
Reviewed-by: Jeremy Allison <jra at samba.org>
commit fa6992eae51fb1456f345b99926717254eae8de3
Author: Andreas Schneider <asn at samba.org>
Date: Thu Mar 14 11:19:51 2013 +0100
torture: Update ndr README.
Reviewed-by: Günther Deschner <gd at samba.org>
Autobuild-User(master): Günther Deschner <gd at samba.org>
Autobuild-Date(master): Fri Mar 15 13:51:51 CET 2013 on sn-devel-104
commit 56328c0ccbb8b9ff7726d0ff2262841a1ba8e0d3
Author: Andreas Schneider <asn at samba.org>
Date: Thu Mar 14 07:29:20 2013 +0100
torture: Add ntprinting latin1 test.
Reviewed-by: Günther Deschner <gd at samba.org>
commit beea48d7e7d0aced70b185f289d610135290d182
Author: Andreas Schneider <asn at samba.org>
Date: Tue Mar 12 18:42:02 2013 +0100
s3-net: Add encoding=<CP> to 'net printing dump'.
Reviewed-by: Günther Deschner <gd at samba.org>
commit 90068bb460c5229f0e146d2118c48d5086c3eb9a
Author: Andreas Schneider <asn at samba.org>
Date: Tue Mar 12 11:39:08 2013 +0100
s3-net: Add encoding=<CP> to 'net printing migrate'.
This allows you to convert printing tdb's which are in e.g. in latin1 to
convert to UTF-8 and import them into the registry.
Reviewed-by: Günther Deschner <gd at samba.org>
commit c8abc6f13879c6aad9dbde4f464f707e28083ff1
Author: Andreas Schneider <asn at samba.org>
Date: Tue Mar 12 15:17:54 2013 +0100
ndr: Pass down string_flags in ndr_pull_ntprinting_printer().
Reviewed-by: Günther Deschner <gd at samba.org>
commit b6e276af309dc57cb244786643cb43d09deacbb0
Author: Andreas Schneider <asn at samba.org>
Date: Mon Mar 11 15:47:00 2013 +0100
idl: Add flags for strings in ntprinting idl.
Reviewed-by: Günther Deschner <gd at samba.org>
commit cc09762cb8fd229d99d57f91f4ab7839b5c6ae80
Author: Andreas Schneider <asn at samba.org>
Date: Mon Mar 11 15:45:15 2013 +0100
ndr: Add ndr_ntprinting_string_flags() function.
It defaults to utf8string.
Reviewed-by: Günther Deschner <gd at samba.org>
commit a42527e51b97737fd7c56872bb80a7a782cdf11e
Author: Andreas Schneider <asn at samba.org>
Date: Tue Mar 12 11:36:38 2013 +0100
pidl: Add skip option to elements.
This option allows to skip struct elements in pull and push function.
This can be used to pass flags to the structure e.g. for string values.
Reviewed-by: Günther Deschner <gd at samba.org>
commit c044e930d34cd8539ced485f1ed8ead91279c3be
Author: Volker Lendecke <vl at samba.org>
Date: Wed Mar 13 13:33:58 2013 +0100
smbd: Fix a typo
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Thu Mar 14 14:46:02 CET 2013 on sn-devel-104
commit ccb39a3fd2144417aea0190ecc7fe3ed165c7cc8
Author: Ira Cooper <ira at samba.org>
Date: Wed Mar 13 13:36:11 2013 +0000
tsocket: ENOMEM can be retried on illumos/Solaris.
The writev system call can return -1 and errno ENOMEM, as a
retriable condition.
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Mar 13 23:50:05 CET 2013 on sn-devel-104
commit 156fa6cd0add0c040288b5c9dc4390ad1abf656a
Author: Guenter Kukkukk <kukks at samba.org>
Date: Wed Mar 13 05:46:07 2013 +0100
vfstest: update the manual page
many added commands were missing.
The "-c" multiple command parameter option delimiter is not the
colon (anymore) - the semicolon is used.
Signed-off-by: Guenter Kukkukk <kukks at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Wed Mar 13 08:27:54 CET 2013 on sn-devel-104
commit 41edcf849a592d0d358621fdffbab82befa76e02
Author: Guenter Kukkukk <kukks at samba.org>
Date: Tue Mar 12 01:44:59 2013 +0100
vfs_catia: testcase - add missing pieces
Signed-off-by: Guenter Kukkukk <kukks at samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe at samba.org>
Autobuild-User(master): Richard Sharpe <sharpe at samba.org>
Autobuild-Date(master): Tue Mar 12 07:36:13 CET 2013 on sn-devel-104
commit 396647340f233e30277d6d6081465b7b6d855181
Author: Guenter Kukkukk <kukks at samba.org>
Date: Mon Mar 11 05:34:27 2013 +0100
vfs_catia: testcase - implement vfstest additions
Signed-off-by: Guenter Kukkukk <kukks at samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
commit e10c81553b1691ae1b7c260719d724beed61bb48
Author: Guenter Kukkukk <kukks at samba.org>
Date: Sun Mar 10 05:43:24 2013 +0100
vfs_catia: write a testcase - add a translate command to vfstest
first approach
Signed-off-by: Guenter Kukkukk <kukks at samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
commit b40c4b069a600af86c1f20ee09cbf5052c1552bf
Author: Guenter Kukkukk <kukks at samba.org>
Date: Tue Mar 12 04:51:03 2013 +0100
vfstest: fix the "-c" multiple-command option
Signed-off-by: Guenter Kukkukk <kukks at samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
commit 389197e7c31e8d6616e6503181c088940ddb5986
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Feb 28 00:03:19 2013 +1100
scripting: No longer install samba_upgradeprovision
This tool is an important part of the toolkit a Samba Team member can
use to assist a user with the upgrade of a very old Samba 4.0 AD DC
installation.
However, like all powerful tools, it has sharp edges, and these need
to have more protection added before we recommend the tool be used.
The WHATSNEW already indicated that this tool should not be used but a
large number of users have run it, and due to lack of testing in the
past, some have run into bugs.
While this tool can be run in debug modes, by default it simply fixes
the database following a series of internal rule. This does a good
job much of the time, but does not request permission in the way that
dbcheck does, and will create extra objects for things like the DNS
partitions.
By removing this from the installed binaries, we provide another
signal that it should not be used right now, until these matters are
fixed and some clear documentation on how to safely use the tool can
be written.
Andrew Bartlett
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Mar 12 02:51:23 CET 2013 on sn-devel-104
commit fb924d02ec05f7106beeeb409becbc39e00ddac9
Author: Christian Ambach <ambi at samba.org>
Date: Mon Mar 11 22:23:27 2013 +0100
s3: remove some dead code (for setdir command)
set dir seems to have been a special SMB command used by Pathworks clients
the supporting code for it was already removed in 2007, so just remove all
remnants related to it (smb.conf parameter, documentation, ...)
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Mar 12 01:03:37 CET 2013 on sn-devel-104
commit 58e385a5ac37c072a4eef3baa7926b799a732e94
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Mar 10 20:25:53 2013 +1100
Revert "Ensure the masks don't conflict with the ACL checks."
This reverts commit 78594909b8b22bd07978922b1c85dfd6f6456963 which was
needed by 7622aa16adeb00bf161a6dd07664c37125391272.
This change masked bug #9462 which was fixed by
2013bb9b4dbed747921df2591068e2765428f57d. The issue was that the
defaults for the substituted parameters did not match the old
parameter. Changing the values in our test suite hid the issue, but
did not fix the issue.
(Additional change in the revert is to correct the expected ACL value
in posixacl.py due to changed implied inherited permissions).
Andrew Bartlett
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Mon Mar 11 19:46:24 CET 2013 on sn-devel-104
commit fc496ef323c908a6b621198d9dc8076f6857385e
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Mar 8 16:15:37 2013 +1100
smbd:posix_acls Remove incorrectly added lp_create_mask() and lp_dir_mask() calls
When 6adc7dad96b8c7366da042f0d93b28c1ecb092eb removed the calls to
lp_security_mask/lp_force_security_mode/lp_dir_security_mask/lp_force_dir_security_mode
these calls were replaced with lp_create_mask() and lp_dir_mask()
The issue is that while lp_security_mask() and lp_dir_security_mask defaulted to
0777, the replacement calls did not. This changes behaviour, and incorrectly
prevents a posix mode being specified by the client from being applied to
the disk in the non-ACL enabled case.
Andrew Bartlett
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 287b5f6c0f40d3e3d09bc2ce80f5fee02cbae40f
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Mar 8 16:49:21 2013 +1100
param: Remove incorrectly added defaults in AD DC allowing WORLD WRITABLE files
These defaults were incorrectly added in
fc5caffbc139d63cab1ec105884863f73772586f in what turns out to be an
incorrect fix for bug #9462, which was in turn introduced by the
swapping of security mask (default 0777) for create mask (0755) in
6adc7dad96b8c7366da042f0d93b28c1ecb092eb.
While the permissions on sysvol and netlogon (the default shares) were
fixed by provision, any additional shares that did not yet have an
explit ACL set would create world-writable files by default.
Administrators will need to manually correct the file permissions on
any additional shares that were created after installation of the AD
DC.
Andrew Bartlett
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sun Mar 10 12:00:31 CET 2013 on sn-devel-104
commit 6ac0bdc4513bb5a7bf9ecf0cd0986f6122f96dba
Author: Christof Schmitt <christof.schmitt at us.ibm.com>
Date: Thu Feb 21 12:33:23 2013 -0700
Add testcase for idmap_rfc2307 module
Create a new test environment with 'idmap config DOMAIN : backend =
rfc2307'. A new test script adds LDAP records and queries them again for
the mapped uid and gid.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sat Mar 9 08:18:43 CET 2013 on sn-devel-104
commit 8241dafdb832808f0b88a7d83095105e7d532fa4
Author: Christof Schmitt <christof.schmitt at us.ibm.com>
Date: Thu Feb 21 12:33:19 2013 -0700
packaging(RHEL-CTDB): Add idmap_rfc2307 module
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit b75515248a641c1b1e1e3dad40eb323280658129
Author: Christof Schmitt <christof.schmitt at us.ibm.com>
Date: Thu Feb 21 12:33:13 2013 -0700
s3-net: Allow setting the ldap password for idmap_rfc2307
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 30b2f74ffc8f7c38e132eddede7884c5195b634a
Author: Christof Schmitt <christof.schmitt at us.ibm.com>
Date: Thu Feb 21 12:32:54 2013 -0700
s3-docs: Add manpage for idmap_rfc2307 module
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 6aa739a21903d9013d6fbb45b9581f84a192b4d5
Author: Christof Schmitt <christof.schmitt at us.ibm.com>
Date: Thu Feb 21 12:32:37 2013 -0700
s3-winbindd: Add new module idmap_rfc2307
This module allows querying id mappings from LDAP servers as described
in RFC 2307. The LDAP records can be queried from an Active Directory
Server or from a stand-alone LDAP server.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ad1fbe29fbeea48381c7bedd78f7a45d07ad14d5
Author: Christof Schmitt <christof.schmitt at us.ibm.com>
Date: Thu Feb 21 12:31:41 2013 -0700
s3-winbindd: Move connection to AD server from idmap_ad
Having this in a common place allows reuse by other idmap modules.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit baf9b78d47079b81cf33682ee481cf6e30ed89e9
Author: Christof Schmitt <christof.schmitt at us.ibm.com>
Date: Thu Feb 21 12:31:37 2013 -0700
s3-winbindd: Use common helper function for connecting to ADS
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 0c4e467c1cc661552bfd6745825e2106ec8279d7
Author: Christof Schmitt <christof.schmitt at us.ibm.com>
Date: Thu Feb 21 12:31:28 2013 -0700
s3-winbindd: Move code for verifying ADS connection to common helper function
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit c07c167edb71568ab18f016346e60803d1195d42
Author: Christof Schmitt <christof.schmitt at us.ibm.com>
Date: Thu Feb 21 12:31:19 2013 -0700
s3-winbindd: Move idmap_fetch_secret to idmap_utils.c for reuse
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 86d09ce779fdc9d6ebbbe44b25656808ab37ee14
Author: Christof Schmitt <christof.schmitt at us.ibm.com>
Date: Thu Feb 21 12:30:48 2013 -0700
s3-winbindd: Move common code for LDAP id mapping to idmap_utils
idmap_ad and idmap_ldap use the same helper functions and the same
maximum query size. Move the code to idmap_utils so that it can be
shared by every module issuing LDAP queries.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 666a5630ef3b03640089a0b6e81bf578b91b88ab
Author: Stefan Gohmann <gohmann at univention.de>
Date: Fri Mar 8 20:57:31 2013 +0100
s4-dns: dlz_bind9: Check result to avoid segfault
We saw this issue in a customer environment with many CNF objects. I
wasn't able to reproduce it, but I got the following core dump:
(gdb) directory samba4-4.0.0~rc6/source4/dns_server/
Source directories searched: /root/samba4-4.0.0~rc6/source4/dns_server:$cdir:$cwd
(gdb) bt
#0 0xb4b0bc13 in dlz_lookup_types (state=0x9648e48, zone=0xb659b9a8 "xxxxxx.xxxxx.de", name=0xb659bda8 "client9173", lookup=0xb6db7588, types=0x0) at ../source4/dns_server/dlz_bind9.c:830
#1 0xb4b0bdb8 in dlz_lookup (zone=0xb659b9a8 "xxxxxx.xxxxx.de", name=0xb659bda8 "client9173", dbdata=0x9648e48, lookup=0xb6db7588) at ../source4/dns_server/dlz_bind9.c:875
#2 0x080b43d8 in dlopen_dlz_lookup ()
#3 0xb7701755 in findnode () from /usr/lib/libdns.so.81
#4 0xb7701d22 in find () from /usr/lib/libdns.so.81
#5 0xb7639e5f in dns_db_find () from /usr/lib/libdns.so.81
#6 0x08075476 in query_find ()
#7 0x0807acb9 in ns_query_start ()
#8 0x08060712 in client_request ()
#9 0xb743022b in run () from /usr/lib/libisc.so.81
#10 0xb7216955 in start_thread () from /lib/i686/cmov/libpthread.so.0
#11 0xb706c1de in clone () from /lib/i686/cmov/libc.so.6
(gdb) f 0
#0 0xb4b0bc13 in dlz_lookup_types (state=0x9648e48, zone=0xb659b9a8 "xxxxxx.xxxxx.de", name=0xb659bda8 "client9173", lookup=0xb6db7588, types=0x0) at ../source4/dns_server/dlz_bind9.c:830
830 el = ldb_msg_find_element(res->msgs[0], "dnsRecord");
(gdb) p res->msgs
$1 = (struct ldb_message **) 0x0
(gdb) p res->count
$2 = 0
(gdb)
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 83e4ff9a4ed06bd60a902a3b2f385ab69356b35b
Author: David Disseldorp <ddiss at samba.org>
Date: Fri Mar 8 11:47:56 2013 +0100
doc: add vfs_btrfs man page
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 15ce3a9c2f2aedcd4896235238a4ffdf23aa9178
Author: David Disseldorp <ddiss at samba.org>
Date: Fri Mar 8 11:47:55 2013 +0100
s3-vfs: add vfs_btrfs module
Currently it only plumbs itself into the copy_chunk call path,
translating such requests into BTRFS_IOC_CLONE_RANGE calls.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 11d128632357c9ae89d67aaf23c429fae83a1b29
Author: Richard Sharpe <realrichardsharpe at gmail.com>
Date: Thu Mar 7 17:36:37 2013 -0800
Correct the name of the nss_winbind module for FreeBSD by creating a symlink
from the FreeBSD required name to the built module.
Signed-off-by: Timur Bakeyev <timur at FreeBSD.org>
Reviewed-by: Andrew Bartlett <abartlett at samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
Autobuild-User(master): Richard Sharpe <sharpe at samba.org>
Autobuild-Date(master): Fri Mar 8 05:04:04 CET 2013 on sn-devel-104
commit 5372571fde68dcc7ccd0d3fa754bdfa148e7ca48
Author: Michael Adam <obnox at samba.org>
Date: Mon Mar 4 12:52:26 2013 +0100
s3:idmap: fix a debug message and lower its level
It is not an error to be logged at level 1 when a
domain has no explicitly configured idmap backend.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Fri Mar 8 03:16:54 CET 2013 on sn-devel-104
commit 93d57dfbaf01c23fe8de5e9c8f076718b4cf566f
Author: Guenter Kukkukk <kukks at samba.org>
Date: Fri Mar 1 00:58:05 2013 +0100
vfs_catia: add my copyright
Signed-off-by: Guenter Kukkukk <kukks at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Mar 7 22:24:47 CET 2013 on sn-devel-104
commit 4b4f8f3a2994f282bd3bd75d4f1fb83c82169e9a
Author: Guenter Kukkukk <kukks at samba.org>
Date: Fri Mar 1 00:36:08 2013 +0100
vfs_catia: add a sample for filename mapping to the manual page
Signed-off-by: Guenter Kukkukk <kukks at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5f38125c147c329da1e4e853b99022f1a3e77ba2
Author: Guenter Kukkukk <kukks at samba.org>
Date: Thu Feb 28 06:12:36 2013 +0100
vfs_catia: fix the completely outdated manual page
The complete rework around 3.5.0 was not even mentioned somewhere.
(i was not able to find any info about that major change)
Signed-off-by: Guenter Kukkukk <kukks at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit f7a63dc3ae784254a289348139d279f87b819ee1
Author: Guenter Kukkukk <kukks at samba.org>
Date: Wed Feb 27 05:50:52 2013 +0100
vfs_catia: fix the translation to "vfs_translate_to_windows"
THANKS to an IRC user (Raimund ?) who asked for a char mapping possibility.
I suggested vfs_catia - but it did not work!
Hopefully now it will. :-)
Signed-off-by: Guenter Kukkukk <kukks at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit bb680efb0a40ecfe86206acef379e5f9e09ea5bf
Author: Guenter Kukkukk <kukks at samba.org>
Date: Wed Feb 27 05:34:05 2013 +0100
vfs_catia: add debug class for that module
Signed-off-by: Guenter Kukkukk <kukks at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 33a72968e566f47a3dcb5e8d752d47847d464337
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Feb 28 23:30:16 2013 +1100
docs: Add documentation for osName and osVer
This was previously documented only in the online help.
Andrew Bartlett
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Mar 7 01:36:01 CET 2013 on sn-devel-104
commit c66632046d62786dd19c8978847bfc6470da4e89
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Feb 28 22:59:48 2013 +1100
net ads join: Add support for specifying the machine account password
This allows a predictable password to be specified, just like --machinepass does on samba-tool domain join.
Andrew Bartlett
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 166288b162e7b658b48bc908c71f635928edc5b5
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Feb 28 22:57:45 2013 +1100
selftest: Fix specification of --machinepass to actually set a unique password
Because perl does not assert on dereferencing an invalid hash key
we did not notice that the passwords were being set to machine, not
machineloCalMemberPass.
Andrew Bartlett
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 7fa4795607f018590caa26b5eca5abb68922c039
Author: Ira Cooper <ira at samba.org>
Date: Wed Mar 6 00:54:43 2013 +0000
waf: add -fstack-protector to LDFLAGS if detected.
If we compile with -fstack-protector, we should link
with it.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Wed Mar 6 04:06:04 CET 2013 on sn-devel-104
commit 511e575e29a62c5d7dece91e41dd965e9546147c
Author: Scott Lovenberg <scott.lovenberg at gmail.com>
Date: Mon Mar 4 19:09:12 2013 -0500
Documentation: Add a warning to "socket options"
Add a warning to the "socket options" section of the
smb.conf man page that changing socket options can be
dangerous to performance. Hopefully this will cut down on
users reporting poor performance after changing socket
options.
Signed-off-by: Scott Lovenberg <scott.lovenberg at gmail.com>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 90cbfc96d118d6b55c47392d8ae421434dea8225
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 25 17:34:21 2013 +0100
Make sure to set umask() before calling mkstemp().
Reviewed-by: David Disseldorp <ddiss at samba.org>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Wed Mar 6 01:16:34 CET 2013 on sn-devel-104
commit 7a50f089e0ae70ec7652575e11fbf87a9f6a86e7
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 25 17:16:45 2013 +0100
s4-libregistry: Improve NULL handling of name.
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 17424588c5d7b7dd1cda5eb6ca0d7d13524b963a
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 25 15:48:20 2013 +0100
dsdb: Check for pointers before we deference them.
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit ceb1d8b84a6bd7084447e4cc75bd6821d6fdbe34
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 25 15:41:23 2013 +0100
gensec: recv_handler can't be NULL at that point.
We probably want to segfault here if it is NULL.
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit cab969d5ec67b1b3afbd4be2ff3a0d3cec45fd45
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 25 15:13:19 2013 +0100
s4-libregistry: Fix path check and improve while loops.
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 2aca90b9a00e0727d640c235ef71a9a8b0c5fdca
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 25 15:01:18 2013 +0100
s4-libregistry: Make sure we don't dereference a NULL pointer.
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 1e4f4f6d921961c02398e51b97c6ff0c0bdf561d
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 25 14:58:45 2013 +0100
s4-client: Make sure entry is a valid string.
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 69f22e17d7cfe305de757f613c18cb0a2c303756
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 25 14:55:48 2013 +0100
winbind: Fix no memory check in _wbint_PingDc().
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 157943fdfb47e6b72cb5596d6685152d0de328a7
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 25 14:52:23 2013 +0100
krb5_wrap: Make sure we don't dereference a NULL pointer.
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit f06a0352e551ea125675659923c909d6d4c473fd
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 25 10:41:18 2013 +0100
s3-daemons: Set the comment field of the daemons.
PR_SET_NAME sets the comm field of a process. This way we can give
processes a name and they are easier to identify.
$ ps afx -o pid,comm
29447 smbd
29452 \_ epmd
29453 \_ lsasd-master
29455 | \_ lsasd-child
29457 | \_ lsasd-child
29459 | \_ lsasd-child
29461 | \_ lsasd-child
29463 | \_ lsasd-child
29454 \_ spoolssd-master
29456 \_ lpqd
29458 \_ spoolssd-child
29460 \_ spoolssd-child
29462 \_ spoolssd-child
29465 \_ spoolssd-child
29466 \_ spoolssd-child
29467 \_ spoolssd-child
29468 \_ spoolssd-child
29469 \_ spoolssd-child
29470 \_ spoolssd-child
29471 \_ spoolssd-child
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit f9fb3faaef4c15b7c4c3748b0e93fa3061b573c3
Author: Andreas Schneider <asn at samba.org>
Date: Tue Mar 5 15:54:44 2013 +0100
lib: Add prctl_set_comment to utils.
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit def575bc29ee399fc93320b0f3716bc15740863d
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 25 10:02:35 2013 +0100
waf: Correctly check for prctl in just one place.
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 3c134bcf86a156b8b0292e6a8108050273038b29
Author: Andreas Schneider <asn at samba.org>
Date: Thu Feb 21 12:14:55 2013 +0100
winbind: Fix samba3.winbind.struct test.
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 659dd65f8f5c352a4cd17e072929a8cc0b6e4d34
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 25 09:31:12 2013 +0100
winbind: Correctly use names in the domain struct.
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 14bae61ba36814ea5eca7c51cf1cc039e9e6803f
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 18 16:36:22 2013 +0100
winbind: Use talloc for allocating domain, dns, forest and dc name.
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit e8e3a68729074c9dafb9a41df0ffa3a49c260772
Author: Guenter Kukkukk <kukks at samba.org>
Date: Tue Mar 5 20:08:49 2013 +0100
Fix the build: net_serverid.c has 3 wrong format strings for 64bit vars
On two of my opensuse machines i get 3 errors, e.g.:
../source3/utils/net_serverid.c:333:3: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘uint64_t’ [-Werror=format]
cc1: some warnings being treated as errors
Signed-off-by: Guenter Kukkukk <kukks at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Mar 5 22:49:03 CET 2013 on sn-devel-104
commit 0796a17aa6915be039d6f71ae2575ef525ffb6db
Author: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
Date: Tue Feb 26 12:32:32 2013 +0100
s3:lib/charcnv fix typo in pull_ascii_base_talloc()
Signed-off-by: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
Reviewed-by: Christian Ambach <ambi at samba.org>
Autobuild-User(master): Christian Ambach <ambi at samba.org>
Autobuild-Date(master): Tue Mar 5 15:56:56 CET 2013 on sn-devel-104
commit 9755541ed156d71df98607375ee3b925266c3c74
Author: Christian Ambach <ambi at samba.org>
Date: Tue Mar 5 11:44:03 2013 +0100
s3:libnet increase timeout for machine password change
DCs might run password filter modules that can delay the setting of
the machine password for a significant amount of time
use the same timeout as in the other paths of domain join
(e.g. rpccli_netlogon_set_trust_password)
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 68698b4e64831d2fdf762b5f8577ff404f10a3cb
Author: Volker Lendecke <vl at samba.org>
Date: Mon Mar 4 13:06:05 2013 +0100
tdb: Slightly simplify tdb_expand_file
The "else" keywords are not necessary here, we return in the preceding
if clause
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Mar 5 14:00:47 CET 2013 on sn-devel-104
commit 70e1b6185e3fb35fdc72eeb529ffb4b50122dc40
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Mar 4 14:06:14 2013 +1100
tsocket_bsd: Attempt to increase the SO_SNDBUF if we get EMSGSIZE in sendto()
This matches what was done for lib/socket/socket_unix.c in
c692bb02b039ae8fef6ba968fd13b36ad7d62a72.
(and is based on that patch by Landon Fuller <landonf at bikemonkey.org>)
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Mon Mar 4 11:15:35 CET 2013 on sn-devel-104
commit 50b42d1c5bb19e3a5050d7d23ac96e273d3974ee
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Mar 4 14:07:38 2013 +1100
s4-lib/socket: Return the original EMSGSIZE when sendto() and setsockopt() both fail
This ensures that should we be unable to increase the socket size, we return an
error that the application layer above might expect and be able to make
as reasonable response to (such as switching to a stream-based transport).
This fixes up c692bb02b039ae8fef6ba968fd13b36ad7d62a72.
As suggested by metze in https://bugzilla.samba.org/show_bug.cgi?id=9697#c4
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit b9b637569960ae7eef5ee12436624af34a718a9a
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Feb 17 22:45:59 2013 +1100
selftest: Remove output directories to save disk space
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit d5d88bd82b1cb51da09cf3b3dec40f180f5ed29f
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Feb 18 15:56:18 2013 +1100
samba_upgradeprovision: Do not reset every DN when changing an SD
SD propogation is handled by an LDB module, we do not need to touch each
and every DN to make it happen.
Now that we do not need to put this via a hash, the dnToRecalculate
list is changed to be a list of Dn objects, not strings so that:
if dn in listWellknown
is handled using a schema comparison (avoiding different case forms
tripping it up).
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 0f247dce00fd26230cdb0566ce4f51a2ea8cfc2b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Feb 18 15:15:52 2013 +1100
samba_upgradeprovision: do not maintain dnNotToRecalculate as a list
We only need a boolean indication, not the actual values.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 9bc32bfd65700c816ebb2a3004ad568327218f86
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Feb 18 15:05:00 2013 +1100
samba_upgradeprovision: only run rebuild_sd in --full mode
This is a potentially destructive routine, and should not be run by default.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 81cda856faf2a5efd38965fd4c3b1f5551ad94d9
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Feb 18 13:00:31 2013 +1100
samba_upgradeprovision: Remove alwaysRecalculate, this is too dangerous
I am unclear on why this was added, but the idea that we ever always reset data
in the directory is not reasonable to me, so I am removing it.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 09b82d5fdc05a1f440aa96a690c202d4b0df134b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Feb 18 12:28:23 2013 +1100
samba_upgradeprovision: Remove unused checkKeepAttributeOldMtd
lastProvisionUSNs is never None, instead the code requries the administrator to populate this
attribute in the directory.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 9b8d5bba507615aee95a46fd9ae75aa782fd7e66
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Feb 17 22:44:56 2013 +1100
samba_upgradeprovision: Remove inherited ACEs before comparing the SDs
This avoids changing an SD when it is not really required.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 5074b98714c9e038cc31872111508c1d92562841
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Feb 17 22:03:18 2013 +1100
scripting: Rework samba.upgradehelpers.get_diff_sddls to be get_diff_sds
This moves the SDDL conversion inside the get_diff_sds function and prepares
for removing inherited ACEs from the SD before comparison.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 787a6aacc3003731784b29fd92c683036c8730a7
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Feb 16 21:58:57 2013 +1100
samba_upgradeprovision: Remove auto-detection of pre-alpha9 databases
These are incredibly rare, and administrators running such databases
not only ask the Samba Team for help personally, they can read --help.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 9d6af4938f7bc80b10202d7055c2c32a483bbb5f
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Feb 16 13:12:53 2013 +1100
selftest: Rename samba4.blackbox.upgradeprovision.py to samba4.blackbox.upgradeprovision.current
This name matches the other upgradeprovision tests for older saved provisions.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 08f0562240155a871bd2a78d217db660e8ee3c91
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Feb 16 01:07:27 2013 +1100
selftest: Run dbcheck and improved upgrdeprovision tests against release-4-0-0
The improved upgradeprovision tests now call ldapcmp to verify the
changes made do actually bring the database in line with a fresh
provision.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit d7936ee20c20635d62657cb821ff6dc4eb5fe33c
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Feb 16 01:08:20 2013 +1100
selftest: Add ldapcmp to ensure upgradeprovision of a fresh DB is a no-op
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit f1f36ad3517cd0e6bceb4b0cc37721a15be4d588
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Feb 16 01:05:56 2013 +1100
selftest: Add in a provision from 4.0.0 to run tests against
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 72f73ebaff8d75fc39770ec785964b0d3c9738cc
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Feb 14 15:01:10 2013 +1100
selftest: Do an ldapcmp run against the upgraded domain
This checks (with a set of known issues marked in the --filter attribute) that the upgraded
domain matches a fresh provision.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 24c4d818d14c3931cf0cbff3070685fe409e66c6
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Feb 14 15:00:01 2013 +1100
samba-tool ldapcmp: Add support for checking DNSDOMAIN and DNSFOREST by default
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit f508435d23445a8b3076f89cbe042e2da1ac0701
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Feb 11 08:25:41 2013 +1100
samba-tool dbcheck: fix msDS-HasInstantiatedNCs attributes to match instanceType on our ntdsDSA
This value is only a link to the local value of intanceType on our server, so only fix it for our server.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 97389c3ec24526837e91fcfcaf7439491fcdb214
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Mar 1 17:29:09 2013 +1100
scripting: Correct parsing of binary DN
The DN is of the form B:8:01020304:DC=samba,DC=example,DC=com. We need
to account for the case where the 8 is actually (say) 16, and so not just
one character.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit 0180a027cbc9725ae13023ddfdb8079f147864c5
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Feb 16 09:36:07 2013 +1100
subunit: Add a sh macro for skipping a test
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit c692bb02b039ae8fef6ba968fd13b36ad7d62a72
Author: Landon Fuller <landonf at bikemonkey.org>
Date: Sat Mar 2 14:08:47 2013 -0500
Handle EMSGSIZE on UNIX domain sockets.
On some systems (eg, FreeBSD) the default SO_SNDBUF for UNIX
domain sockets is to small, and EMSGSIZE is returned. Other
systems provide a larger default send buffer, but there is
still no guarantee that the buffer will be sized appropriately.
This patch modifies the sendto() path to attempt to resize
the SO_SNDBUF dynamically upon an EMSGSIZE failure, and then
retry the send.
This fixes local DCE/RPC errors on FreeBSD, eg:
https://lists.samba.org/archive/samba-technical/2013-January/089881.html
Signed-Off-By: Landon Fuller <landonf at bikemonkey.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sat Mar 2 23:34:03 CET 2013 on sn-devel-104
commit 606f5d6cc6b018259ba0306fe3b55e21b4b70fdb
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Feb 14 14:59:28 2013 +1100
samba-tool ldapcmp: Add --skip-missing-dn to not error on DNs present in one DB but not the other
This is needed to compare some parts of the database, particularly in --two mode, which
are just never going to have exactly the same DNs.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 161fa15697fab9effbe1db9640cece847dcf63cd
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Feb 12 09:20:03 2013 +1100
samba-tool domain classicupgrade: Fix typo in error path for multiple account flags
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 669c302f2d78ab4bbd35982373ae079246c8979d
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Jan 15 21:53:30 2013 +1100
samba-tool domain classicupgrade: Print a better error when the ldap backend PW was not found
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 68f13f5d7e80f2041e140a12fc2f7139561c83ce
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Feb 11 14:50:49 2013 +1100
samba-tool dbcheck: fix comment on err_wrong_sd
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 2cfbfa6337675d13a9abc4c0426886beeff3134f
Author: Landon Fuller <landonf at bikemonkey.org>
Date: Sat Feb 23 22:32:25 2013 -0500
Remove incomplete check for IPv6 link-local addresses.
This has been superceded by a check for link-local
addresses in get_interfaces()
Signed-Off-By: Landon Fuller <landonf at bikemonkey.org>
Reviewed-By: Richard Sharpe <realrichardsharpe at gmail.com>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sat Mar 2 08:38:54 CET 2013 on sn-devel-104
commit 87afc3aee1ea593069322a49355dd8780d99e123
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Dec 28 15:37:14 2012 +0100
Move python modules from source4/scripting/python/ to python/.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sat Mar 2 03:57:34 CET 2013 on sn-devel-104
commit 80fce353e740c793619005ac102ab07fb5e7d280
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Mar 2 10:58:50 2013 +1100
build: Change bin/default/python -> bin/python symlink to bin/default/python_modules
This avoids a collision with the new top level python directory.
Andrew Bartlett
commit 2d13532cb3ad3a3deaee1f158408478284bc595a
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Mar 2 08:28:11 2013 +1100
build: Rename samba_python waf node to avoid duplicate name
This makes it clearer when debuging build issues.
Andrew Bartlett
commit f9eb05509bdab08a350440eba47de38522f17036
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 30 09:43:23 2012 +0100
tevent: change version to 0.9.18
This release contains a lot of fixes:
- Adding new timer events is now faster, if there's
a large number of timer events.
- sigprocmask does not work on FreeBSD to stop further signals in a signal
handler.
- TEVENT_NUM_SIGNALS is calculated by configure in order
to support realtime signals on freebsd.
- ./configure --disable-python was fixed for the standalone build.
- Several crash bugs in the poll backend are fixed.
- The poll backend removes deleted events from the
cached pollfd array now.
- The poll doesn't pass pollfd.events == 0 to poll()
and maintains a list of disabled events,
instead of consuming 100% cpu and/or triggering
the callers handler.
- The poll backend detects POLLNVAL and reports EBADF
instead of consuming 100% cpu.
- The select backend supports separate handlers
for TEVENT_FD_READ and TEVENT_FD_WRITE.
- The poll and select backends are now doing fair
queuing of fd events.
- The epoll has better error checking
and supports separate handlers
for TEVENT_FD_READ and TEVENT_FD_WRITE.
- The standard backend was rewritten to be a tiny
wrapper on top of epoll with a fallback to poll,
which means that it doesn't use select directly anymore.
- TEVENT_TRACE_BEFORE_LOOP_ONCE and TEVENT_TRACE_AFTER_LOOP_ONCE
are added in order to allow the application to hook in
before and after the loop_once() backend function is called.
The TEVENT_HAS_LOOP_ONCE_TRACE_POINTS define can be used to
detect the new feature.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sat Mar 2 02:15:44 CET 2013 on sn-devel-104
commit 35385a3e28850d0915e8cf2883871ae2101526f1
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Feb 22 12:45:39 2013 +0100
tevent: optimize adding new zero timer events
Such events were used before we had immediate events.
It's likely that there're a lot of this events
and we need to add new ones in fifo order.
The tricky part is that tevent_common_add_timer()
should not use the optimization as it's used
by broken Samba versions, which don't use
tevent_common_loop_timer_delay() in source3/lib/events.c.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit afd4198bf1ee5877a660d42e615e06d895690161
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Feb 22 12:45:39 2013 +0100
tevent: optimize adding new timer events
As new timestamps typically get higher:-)
it's better to traverse the existing list from
the tail.
This is not completely optimal, but it should be better
than before.
A second optimization could be done for zero timestamps,
we would just remember the last_zero_timer,
but that would change the internal ABI.
Normally thatshould not be a poblem, but the Samba's
source3/lib/events.c abuses tevent_internal.h
from the current source tree, even if an external tevent.h
is used. The other problem is that it makes use of
tevent_common_add_timer() without using
tevent_common_loop_timer_delay().
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e5ae80378af00c5c0158413bd1f1a8aca27fab04
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Mar 1 09:25:32 2013 +0100
tevent: add a debug message in tevent_common_loop_timer_delay()
We should debug a message before and after running the handler.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3ed0f7d9924b6f70c56b98adb7c98032a255fc55
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 27 16:43:44 2013 +0100
tevent: add test_event_fd2()
This test fills the socket kernel buffers
and verifies that we don't report TEVENT_FD_WRITE
if the buffer is full.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit cf3ee4eb53829b7825c56d1d6581b46158d258d1
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Feb 22 21:48:44 2013 +0100
tevent: add test_event_fd1()
This test verifies that TEVENT_FD_* flags are handled correctly.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 2c9d84b226e1a2f04bb03f5b00bceb77099bdeab
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 28 10:12:42 2013 +0100
tevent: use better names for the subtests
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 04b1fa4112a3c76e84d640ab6c4808c7e971eec9
Author: Jeremy Allison <jra at samba.org>
Date: Thu Feb 14 14:16:31 2013 -0800
tevent: Regression test to ensure that a tevent backend can cope with separate read/write events on a single fd.
This tests the multiplex fd changes to the epoll backend to
ensure they work correctly.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 23640472bc6592a8bf03cccc7134b1c71b64a55a
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Mar 1 14:30:54 2013 +0100
tevent: use DEBUG_ERROR for the fallback message in epoll_panic()
A Samba autobuild passed without a fallback, so this is
really an error.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 4fcc94d852fcc19c304be50edc07914ea2f8d0c8
Author: Jeremy Allison <jra at samba.org>
Date: Thu Feb 14 13:52:41 2013 -0800
tevent: If epoll_ctl(..EPOLL_CTL_ADD,..) failes with EEXIST, merge the two fde's into one epoll event.
Signed-off-by: Jeremy Allison <jra at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 16a072ec1cddd75f6df656f69935ad55f71f4a28
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 20 11:50:56 2013 +0100
tevent: preferr the write handler if there're two possible handlers registered with epoll
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit fa4f1713f9802ff06007b43afd90357da0f98f73
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 20 14:49:17 2013 +0100
tevent: In epoll_event_loop() ensure we trigger the right handler for a multiplexed fde event.
Signed-off-by: Jeremy Allison <jra at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 4057ef2e11df6f7065f9691d0f388aea56faae45
Author: Jeremy Allison <jra at samba.org>
Date: Thu Feb 14 15:53:38 2013 -0800
tevent: Add utility function epoll_handle_hup_or_err()
We'll use this to handle the EPOLL_ADDITIONAL_FD_FLAG_GOT_ERROR
and EPOLL_ADDITIONAL_FD_FLAG_REPORT_ERROR flags with multiplexed
events in the event loop.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 8b1a43ece8f056d7063a3d7accc5894f380bd018
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 20 17:17:31 2013 +0100
tevent: handle EPOLL_ADDITIONAL_FD_FLAG_HAS_MPX in epoll_update_event()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a347d55f506541e18b95cf3e7c1e83f2c665ee91
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 20 18:01:57 2013 +0100
tevent: handle multiplexed fde's in epoll_event_fd_destructor()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6703c5b49ff8f1957a16b1bab5a0e0d18bf1af75
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Mar 1 13:57:05 2013 +0100
tevent: Fix epoll_mod_event() to cope with modifying a multiplexed fde event.
Signed-off-by: Jeremy Allison <jra at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 15ca40fb7ad1668013eb5ebef4479058d33df992
Author: Jeremy Allison <jra at samba.org>
Date: Fri Feb 15 10:16:44 2013 -0800
tevent: Fix up epoll_del_event to cope with deleting a multiplexed fde event.
Signed-off-by: Jeremy Allison <jra at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 809593e7f55c1d17c616f60d69ec5904e531ea2f
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 20 17:14:52 2013 +0100
tevent: handle multiplexed fde's in epoll_add_event()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e4b496cc096e1caabdaee646c162f0ba8cfac39c
Author: Jeremy Allison <jra at samba.org>
Date: Thu Feb 14 13:50:56 2013 -0800
tevent: Start to fix the epoll backend to support 2 fd events on the same fd correctly.
Add a utility function epoll_add_multiplex_fd() and
a new flag EPOLL_ADDITIONAL_FD_FLAG_HAS_MPX.
This will be called by epoll_add_event() to merge two
fde events with the same file descriptor.
Signed-off-by: Jeremy Allison <jra at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 7ef688c1dd797b1d108afe02c4b803bab01988ab
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 20 13:33:19 2013 +0100
tevent: ignore EBADF from epoll_ctl() and disable the event
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 2721f0dc5b35aa4961d801c2377a951cd63ecee1
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 20 17:38:10 2013 +0100
tevent: unify handling of HAS_EVENT and REPORT_ERROR in epoll_{add,mod,del}_event()
epoll_{add,mod,del}_event() are only called via epoll_update_event()
and epoll_update_event() should not remove REPORT_ERROR itself.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit ec9615c4fcbe15de1b0c16ccc6a52fa3ffb65b48
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 20 11:26:00 2013 +0100
tevent: always go through epoll_update_event()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 07e0427115f030b9b573b2d8a3a91b71b9b89eb6
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 20 12:55:11 2013 +0100
tevent: s/epoll_change_event/epoll_update_event
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 056dcc7a8a9b0cac0b28ef6712eccf46e45c2474
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 20 17:15:52 2013 +0100
tevent: the content of event is ignored by EPOLL_CTL_DEL
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 2b3b06b9b428b72cf7f5f400c043abaca47850de
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Feb 15 10:31:36 2013 +0100
tevent: call epoll_panic() if EPOLL_CTL_DEL failed
Only ENOENT is ignored as it is no error.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 31db8a08be445b252ba27b07106ca5b2e73cc325
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 20 13:12:27 2013 +0100
tevent: use helper variables to hold the epoll_ctl() result
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b2114eb3b01a6259265391fbc41f0492bc26596e
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 20 13:07:34 2013 +0100
tevent: remove unused if (epoll_ev->epoll_fd == -1) return; checks
We'll never leave epoll_check_reopen() with epoll_fd == -1.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5b9218a3c267cb51a389af14e88f5b4a0d3a77ea
Author: Stefan Metzmacher <metze at samba.org>
Date: Sun Feb 17 16:41:41 2013 +0100
tevent: add std_event_loop_wait()
We also need to fallback in tevent_loop_wait()
otherwise we might miss events in the poll->fresh list.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3fc93164fb83e396e2b757672d65269509fa7148
Author: Stefan Metzmacher <metze at samba.org>
Date: Sun Feb 17 16:40:20 2013 +0100
tevent: don't call TALLOC_FREE(ev->additional_data) in std_fallback_to_poll()
The epoll backend has done the cleanup already.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 73dabddbdce99c5bc19a4be814f88da581e6d372
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Feb 15 16:33:56 2013 +0100
tevent: avoid any operation on epoll_ev after a epoll_panic()
This calls TALLOC_FREE(ev->additional_data), which is epoll_ev
within epoll_panic() before calling the fallback handler.
In order to notice that a epoll_panic() happened, a caller can
register a pointer to a bool variable under epoll_ev->panic_state.
As epoll_check_reopen() can fail due to a epoll_panic(),
we need to force the replay flag if we have called any event handler.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 2b05c9621784da8e5aa793cd2110dde768084968
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Feb 15 12:10:26 2013 +0100
tevent: add epoll_{create,ctl}_panic_fallback() for testing
This makes sure we only do random panics if a fallback handler
is registered.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8764ec80bbcba93e862c069766c00944e5187ed5
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 21 15:44:30 2013 +0100
tevent: use DLIST_DEMOTE() before calling on fde handler after select() and poll()
This makes sure we don't preferr events which are at the beginning
of the list.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b31767bf27bafd3ae20ba3f26dd5001051b9f2b6
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 28 14:43:55 2013 +0100
tevent: debug a FATAL message on EBADF from the select backend
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5ca69148844e2f8940b571aef0812e85e08b7cc5
Author: Jeremy Allison <jra at samba.org>
Date: Wed Feb 27 10:18:44 2013 -0800
tevent: Fix multiple handler on the same fd bug in the tevent select backend.
When we're deciding what handlers to call in the select backend,
we didn't take into account the fact that the same fd may have
been added into the read FD_SET and the write FD_SET but with
different handlers.
We must match on both the file descriptor and the flags requested
before calling the handler.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit b53c704a34abca0ad69ae9a0dbb0db6a0a71043b
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Mar 1 16:43:35 2013 +0100
tevent: revalidate fde->flags after poll()
This is important to avoid races between threads if the poll_mt
backend is used.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6952d761d2b9ebb2457916d9dfa3f070c0f62228
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Feb 22 21:45:11 2013 +0100
tevent: ignore POLLNVAL from poll() and disable the event
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit de0204ccae514b26524893b51414c6c772a35a55
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 21 15:41:17 2013 +0100
tevent: traverse the ev->fd_event list instead of the poll_ev->fds array
That has the same complexity but simplifies the code.
It also seems to fix a real problem, which was found
by the following test failure in Samba's autobuild,
while removing the epoll support from the "standard" backend.
[402/1555 in 19m8s] samba3.raw.composite(plugin_s4_dc)
smbtorture 4.1.0pre1-DEVELOPERBUILD
Using seed 1361531675
Testing savefile
Testing parallel fetchfile with 10 ops
waiting for completion
maximum runtime exceeded for smbtorture - terminating
UNEXPECTED(error): samba3.raw.composite.fetchfile (subunit.RemotedTestCase)(plugin_s4_dc)
REASON: _StringException: _StringException: was started but never finished!
UNEXPECTED(error): samba3.raw.composite.fetchfile(plugin_s4_dc) (subunit.RemotedTestCase)
REASON: was started but never finished!
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit f45abeae40495460e29347ebc3c73b9ffece847d
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 28 17:07:28 2013 +0100
tevent: maintain a list of disabled events in the poll backend
We need to avoid passing pollfd.events == 0, to poll(),
as it will report POLLERR and POLLHUP events, but our caller
does not expect the event handler to be called.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit ef8130fdbf50384dca3669ab27de4863490d5cb1
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 28 17:04:00 2013 +0100
tevent: merge poll_fresh_fde_destructor() into poll_event_fd_destructor()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit f75fd905f72fff28cc2d8f5fc4e3240b039d3446
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 28 17:02:45 2013 +0100
tevent: use tevent_poll_event_add_fd_internal() in poll_event_add_fd()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8e3ef659f876573bd7abb7d0e707369157232125
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 21 14:41:24 2013 +0100
tevent: make sure we cleanup the array passed to poll() after deleting an event
If we don't cleanup the array passed to poll after an
event was deleted, we may pass a bad file descriptor to poll().
This was found by the following test failure in Samba's
autobuild, while removing the epoll support from
the "standard" backend.
[48/1555 in 4m37s] samba3.smbtorture_s3.plain(s3dc).LOCK4
UNEXPECTED(failure): samba3.smbtorture_s3.plain(s3dc).LOCK4.smbtorture(s3dc)
REASON: _StringException: _StringException: using seed 1361530718
host=127.0.0.2 share=tmp user=metze myname=sn-devel-104
Running LOCK4
starting locktest4
Failed to create file: NT_STATUS_INVALID_HANDLE
finished locktest4
TEST LOCK4 FAILED!
LOCK4 took 190.492 secs
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d5b341d873bc326843d80dd15d3cd3ef465234ae
Author: Stefan Metzmacher <metze at samba.org>
Date: Sun Feb 17 23:21:28 2013 +0100
tevent: don't skip a fd event if the previous one was deleted during poll()
In a threaded environment it can happen that an tevent_fd is talloc_free'ed
while the main thread sleeps in the poll() syscall.
In such a case poll_event_fd_destructor() would set poll_ev->fdes[i] = NULL.
We then skip the removed event, but before we also skipped the one
that was located at the end of the array. We moved it to possition
'i', but the next loop uses 'i=i+1'.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit f86df3e364f55be5f320463e3c1b89ee3a49115e
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Feb 15 11:24:59 2013 +0100
tevent: remember the errno from select(), poll() and epoll_wait()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 883d20a9bf7444e6338e13d6efbcbc257e1d78b7
Author: Michael Adam <obnox at samba.org>
Date: Tue Feb 26 15:54:57 2013 +0100
tevent: add trace points BEFORE_LOOP_ONCE and AFTER_LOOP_ONCE
The define TEVENT_HAS_LOOP_ONCE_TRACE_POINTS can be used to
detect the new feature, without writing configure tests.
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit 5f284bec47971ea25df5461dfb3fbed731c243a8
Author: Stefan Metzmacher <metze at samba.org>
Date: Sun Feb 17 16:36:25 2013 +0100
tevent: fix compiler warning in tevent_context_init_byname()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit dea5115a3d92f1ea91d354849f382a08957c8ba9
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Feb 22 21:48:11 2013 +0100
tevent: fix some compiler warnings in testsuite.c
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5c31b152d26dc726b24cf6e8d6d09d1c7b5aa86f
Author: Michael Adam <obnox at samba.org>
Date: Tue Feb 26 15:51:38 2013 +0100
tevent: fix a comment typo in tevent_epoll.c
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 4a7142ec04de94ae91119a39bd9e48adeab7368b
Author: Galen.Liu <galen.gang.liu at gmail.com>
Date: Mon Feb 4 07:43:01 2013 +0100
tevent: fix --disable-python cause configure fails (bug #8718)
When we disable python, it will cause build fail!
so, the patch will fix it.
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d5f92571083c82347f58a415db828b064e377522
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Feb 22 14:26:16 2013 +0100
tevent: define TEVENT_NUM_SIGNALS based on configure checks
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 602cd7f6c6744c2468fb3350eb80ac15f5b9400c
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Feb 22 14:53:07 2013 +0100
lib/replace: add AC_CHECK_VALUEOF() macro
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 87f255821b75accb0d91ac11cdf059f91bf6ecd4
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Feb 22 14:20:07 2013 +0100
wafsamba: add CHECK_VALUEOF() helper
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d9a69e6dbf61cffd6be473a460f6671573aa8564
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Mar 1 09:27:29 2013 +0100
s3:lib/events: make use of tevent_common_loop_timer_delay()
This is critical as we also use tevent_common_add_timer().
And if the common code does internal changes, it may affects
both tevent_common_add_timer() and tevent_common_loop_timer_delay()
together!
Without this we rely on a specific behavior and version of
tevent.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8ac431a22e45611d4bbded67c4c8bd864c343a8f
Author: Timur Bakeyev <timur at FreeBSD.org>
Date: Wed Feb 27 16:25:07 2013 -0800
Fix bug # 9666 - Broken filtering of link-local addresses.
This patch should address the problem with Link Local addresses
on FreeBSD and Linux.
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Richard Sharpe <rsharpe at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Feb 28 20:56:57 CET 2013 on sn-devel-104
commit 61f34e2d25058452ab16f9d7ec5fc2776ab135eb
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 21 08:29:18 2013 +0100
s3:pylibsmb: make sure we get tevent debug messages
Pair-Programmed-With: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Thu Feb 28 14:34:24 CET 2013 on sn-devel-104
commit 64d98c532357c71f27bd84539b3f7a14fd0f952b
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 21 08:39:05 2013 +0100
s3:lib/events: make use of samba_tevent_set_debug()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 1b75475ade962f7a61db0fc1aacca9d9daa48861
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 21 08:35:50 2013 +0100
s4:lib/events: make use of samba_tevent_set_debug()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 6b948cf54b75ac44c4857e8da8f7db251e00b67b
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 21 09:00:56 2013 +0100
lib/util: add samba_tevent_set_debug()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 6205262d38a4f7c5f97f1cb4025914ee18abd74d
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 21 08:23:42 2013 +0100
lib/util: allow samba_tevent_debug() to take a name as context
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit bf0dcc918dc63939fb3d0b9ce9339b432b98cb74
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 21 08:32:35 2013 +0100
auth/pycredentials: make use of samba_tevent_context_init()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 8ec4d9cb00b818045f040b0a3f60946543d35f75
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 21 08:31:41 2013 +0100
s4:pyregistry: make use of samba_tevent_context_init()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 5aee3a45e4c398473ba6e8e61ed34df839674a40
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 21 08:30:51 2013 +0100
s4:pygensec: make use of samba_tevent_context_init()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 2fb69f51c47c8859485011879afb11650835ecbe
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 28 10:54:21 2013 +0100
s3:lib/events: add missing TEVENT_TRACE_BEFORE/AFTER_WAIT handling
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f14ba6460a08794074bf1395a6d3886aee2fcb57
Author: Michael Adam <obnox at samba.org>
Date: Wed Feb 27 01:28:51 2013 +0100
s4:winbindd: fix spacing and line length in cmd_getpwnam_recv_domain()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Feb 28 03:54:41 CET 2013 on sn-devel-104
commit 7d01f1036971ecb4151871be30f7b6f39316adf6
Author: Michael Adam <obnox at samba.org>
Date: Tue Feb 26 09:39:17 2013 +0100
s3:smbd: fix missing space in debug message in initial_break_processing()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 1da22ab994822acacf9a0378c68b15cd32535390
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Feb 8 09:12:20 2013 +1100
build: Do not force a specific perl from ${PERL} when running pod2man
pod2man should have the right #!/usr/bin/perl line already, and forcing it may
cause us to use the wrong perl.
Essentially treat this like any other system binary, rather than forcing
it to use the first perl we found.
This essentially reverts e80f576db66ad04592ac436ed74ceb9b96452060.
Current SLES11 does not seem to have the issue this was added to
address.
Andrew Bartlett
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Thu Feb 28 02:14:25 CET 2013 on sn-devel-104
commit 3630ea12034ac17c1498ee2f81eb4788c0305782
Author: Daniel Kobras <d.kobras at science-computing.de>
Date: Fri Feb 22 16:24:26 2013 -0800
Fix bug #9039 'map untrusted to domain' treats WORKSTATION as bogus domain.
s3: never try to map global SAM name
Do not treat the global SAM name as a BOGUS domain, and exempt
local users from mapping, instead. This change reinstates the
exact mapping behaviour of Samba 3.2 if parameter 'map untrusted
to domain' is set.
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit a125ebe9a5f3b9801b99bdffd12d565fc6fdcf07
Author: Richard Sharpe <realrichardsharpe at gmail.com>
Date: Tue Feb 26 20:22:05 2013 -0800
Make sure that domain joins work correctly when the DC disallows NTLM auth.
Signed-Off-By: Richard Sharpe <realrichardsharpe at gmail.com>
Reviewed-By: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Feb 27 21:49:25 CET 2013 on sn-devel-104
commit bb0e4cbc3c30137245ca6b6cf9d74812ad17cee1
Author: Michael Adam <obnox at samba.org>
Date: Wed Feb 27 01:04:46 2013 +0100
s4:winbindd: do not drop the workgroup name in the getgrgid call
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Wed Feb 27 05:44:39 CET 2013 on sn-devel-104
commit ecd0b10d2f1de986303f8aab2915c20c2f025244
Author: Michael Adam <obnox at samba.org>
Date: Wed Feb 27 00:45:55 2013 +0100
s4:winbindd: do not drop the workgroup name in the getgrnam and getgrent calls.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 3e5acc155bb7be5c531a4a35b16e040f71f628ac
Author: Richard Sharpe <rsharpe at samba.org>
Date: Sat Feb 23 08:41:27 2013 -0800
Fix bug #9674 - Samba denies owner Read Control when there is a DENY entry while W2K08 does not.
Signed-off-by: Richard Sharpe <rsharpe at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sat Feb 23 19:28:15 CET 2013 on sn-devel-104
commit 36da56ec51ecf03458fd85741ae248b49cf0d592
Author: Alexander Bokovoy <ab at samba.org>
Date: Fri Feb 22 12:07:19 2013 +0200
Make systemctl reference indirect in packaging/NetworkManager/30-winbind-systemd
Some distributions have clever dependency generators when building packages
and generate dependencies for each executable called out in shell scripts.
The end result is that a package built out of samba would contain explicit dependency
to systemd even though it is usable without systemd.
Making systemctl reference indirect avoids explicit dependency.
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Alexander Bokovoy <ab at samba.org>
Autobuild-Date(master): Fri Feb 22 18:18:20 CET 2013 on sn-devel-104
commit 92b087182c047cd457bbe04d6306c50451698d61
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 10:52:37 2013 +0100
s3-rpc_server: Make sure that fd is really closed on error.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 3ca727b2f98ca942040d5a6c54fe61bb268d75d9
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 10:48:05 2013 +0100
lib-util: Don't leak file descriptor on error.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit c647169e2850cf6f8ea8705d7008e3ce4d24f454
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 10:45:06 2013 +0100
s3-vfs: Don't leak file descriptor on error.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 62136067712aad9cff8c757b2bfb228ebbecfd76
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 10:42:54 2013 +0100
s4-lib: Don't leak plugin handle on error.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 6e8a975e8e33670803e9166a942bd986e695f4fc
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 10:38:13 2013 +0100
s3-libsmb: Don't leak memory on error.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 32a107cfcc04aa05b4db525fcc0dd7550264dff3
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 10:36:52 2013 +0100
ndrdump: Don't leak plugin handle on error.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 312355ad59001fcc1eaa30344d69fc8c91acebc8
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 10:25:55 2013 +0100
smbpasswd: Don't leak memory.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 3a3baa442ed77dbc0688d25571bc0edb5c367bcb
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 10:23:45 2013 +0100
smbget: Fix file descriptor leak.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit aa6cc31ef9b1789b3e81222204f30ba01d69803a
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 10:22:00 2013 +0100
s4-policy: Fix memory leaks in push_recursive().
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 82e9ff81cf6a9945cad799ae35279e16837b8033
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 10:09:20 2013 +0100
s4-cifsdd: Don't leak memory.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit f4d1e8c1e2920560c9db49cd3511f0edbd577c8b
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 10:10:15 2013 +0100
s4-registry: Don't leak file descriptor.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 66ee744ccbb0a57e651d76881328554dffab8bcd
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 10:03:13 2013 +0100
s4-registry: Don't leak memory on error.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit b055798c5660e48f88b74478b89ce88aae9ed019
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 09:51:43 2013 +0100
winbind: Don't leak centry memory.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit cf8be08968f2aae3769140aee00ecac542ff1884
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 09:48:59 2013 +0100
s4-client: Don't leak memory.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit d5a210a26f289bba92192187fa543ed70bdf8387
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 09:47:19 2013 +0100
s3-torture: Don't leak memory.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 301a3cb4afadab6232a34086339696abd0dcbe0c
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 09:43:44 2013 +0100
wbinfo: Fix several memory leaks.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit d555f6d789ede9879f2b5d07d5c00199622ffe5a
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 09:41:55 2013 +0100
winbind: Don't leak memory on return.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit b229d1dcb324c3da9d0865bd72a07e9e1b8b0c53
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 09:31:17 2013 +0100
s3-smbd: Don't leak subcntarr array.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 6ac1435ab3389d36497ece61a2461d9ccc7b4560
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 09:26:02 2013 +0100
torture: Don't leak file resource handle in spoolss test.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit aab2e176dc8f67424cf8b4475a8bd38c79ad999a
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 09:16:25 2013 +0100
s3-vfs: Don't leak file descriptor.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 6b2b125ab910530610b5e3e4b72f6733bd1f174f
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 09:15:26 2013 +0100
s3-param: Don't leak file descriptor.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit f573826f18e590dd53a0795b670e6f30a3f5cd68
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 09:11:48 2013 +0100
s3-lsasd: Don't leak file descriptors.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit c013df3ae52d57b1206f156a2fc529f52cf39531
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 09:06:51 2013 +0100
s3-spoolss: Don't leak memory.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit b70d1168cf511c83eaa6a2761d3924935513d233
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 09:03:17 2013 +0100
s3-net: Don't leak username.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit b91a20f704363374bc37aaa75e5d2c80f7997017
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 09:23:37 2013 +0100
s4-client: Don't leak file descriptor.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 34ad9756d73bc4203281ab39ff68489aab1b44e9
Author: Andreas Schneider <asn at samba.org>
Date: Wed Feb 20 08:58:02 2013 +0100
s4-client: Don't leak resource handle.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit e762858a054f865780e9f05f7896452a525890f4
Author: Andreas Schneider <asn at samba.org>
Date: Tue Feb 19 18:19:12 2013 +0100
torture: Make sure we don't overrun the buffer.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 1d24fa6919a4ff7588c20f1a0365fbfcfd404203
Author: Andreas Schneider <asn at samba.org>
Date: Tue Feb 19 16:02:01 2013 +0100
torture: Fix memcmp of short buffer.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit aff301d9ebc4f5c1be059838a8a6ef6b38129f88
Author: Andreas Schneider <asn at samba.org>
Date: Tue Feb 19 09:32:30 2013 +0100
torture: Fix array access in spoolss test.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit b510e5e6c4332356067331c7afff47f7dbf587fc
Author: Andreas Schneider <asn at samba.org>
Date: Tue Feb 19 09:23:53 2013 +0100
pdb: Fix array overrun by one.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 5207d456f1132041a07c9b3c48bfa7a9112a698f
Author: Andreas Schneider <asn at samba.org>
Date: Tue Feb 19 09:00:51 2013 +0100
s4-libcli: Check return value of smbcli_request_setup().
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 9e6e9c7707506709de2b0e765647783f471b412a
Author: Andreas Schneider <asn at samba.org>
Date: Tue Feb 19 08:58:00 2013 +0100
pyauth: Check return value of lpcfg_from_py_object().
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit a9e6240441583688388885cf48c5d3df09263784
Author: Andreas Schneider <asn at samba.org>
Date: Tue Feb 19 08:56:22 2013 +0100
ndrdump: Check return value of ndr_pull_init_blob().
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 318ecbc2085d2eaee9d24a77c1c3496185af2bdd
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 18 18:00:38 2013 +0100
s4-libcli: Check return code of smbcli_request_setup().
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit e50874606f235cf9d8cf159997b97fcb6ad74ce2
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 18 17:32:28 2013 +0100
librpc: Add NULL check for ndr functions for epm bindings.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit f4761c90fa0f2161e3d799b69d569cd2e38fe10c
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 18 17:30:19 2013 +0100
s3-tldap: Make sure we don't deref a null pointer.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit a3ac48d07fa101743a023c31046495125498e5a1
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 18 17:26:14 2013 +0100
s4-libcli: Add null check for ndr functions in rap.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 52530f5c61994766fd4c85017fcf5287b2d16837
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 18 17:21:31 2013 +0100
nmbd: Fix request data data processing.
answers->rdata is an array and will never be NULL.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 742296d3c375630f76ced9970cff95d7bc1b2547
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 18 17:17:19 2013 +0100
torture: Fix samsync domain_name checks.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 48a453996ac161d7c7a7cb15a047e57cbdbb1e87
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 18 17:11:15 2013 +0100
libsmb: Fix possible null pointer dereference.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 8bfbb81bcd5a70280f49fbe3ab67ccf035fdeade
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 18 17:08:21 2013 +0100
ndr: Comparing an array to null is always true.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 03cf4bedf0bb9729fcf70f321647cf780e002a48
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 18 16:24:38 2013 +0100
winbind: Correctly cast name to messaging_send_buf().
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit de14fd942aaaa4e18bae7fc7cb109d9a60b12648
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 18 15:48:24 2013 +0100
winbind: Use uint8_t type and use const where needed.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 2b890679a61efa676473c11ebbf7d31f4aeeb3b2
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 18 15:46:52 2013 +0100
messages: Use uint8_t type.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 45671747f0b4a569581773ce497ab4dd31e7710d
Author: Andreas Schneider <asn at samba.org>
Date: Mon Feb 18 15:44:20 2013 +0100
winbind: Make domain_name const in wcache_ndr_key().
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 240a55249d00c1e73400b480d4bc924edae94022
Author: Björn Jacke <bj at sernet.de>
Date: Tue Feb 19 19:09:25 2013 +0100
build: use -fstack-protector if available
Signed-off-by: Bjoern Jacke <bj at sernet.de>
Reviewed-by: Matthieu Patou <mat at samba.org>
Autobuild-User(master): Björn Jacke <bj at sernet.de>
Autobuild-Date(master): Fri Feb 22 15:38:21 CET 2013 on sn-devel-104
commit d537d64ab88ed3526425a71730acc0a36f7aab63
Author: Björn Jacke <bj at sernet.de>
Date: Tue Feb 19 19:07:34 2013 +0100
Revert "wafbuild: use -Wstack-protector if available"
This reverts commit e6643fbf48afccd0acedb65fbe24d3ce84d44c40.
Signed-off-by: Bjoern Jacke <bj at sernet.de>
Reviewed-by: Matthieu Patou <mat at samba.org>
commit ac9620b942d6d51a1c35c4177c3f241351fc1ebd
Author: Björn Jacke <bj at sernet.de>
Date: Wed Feb 20 17:06:49 2013 +0100
build/autoconf: put ld check variable in quotes
Signed-off-by: Bjoern Jacke <bj at sernet.de>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit e4d85fa73d3ce1f397fdd416af6b8c903a473824
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Feb 11 14:46:43 2013 +1100
dsdb-descriptor: Avoid segfault copying an SD without an owner or group
This is an unusual SD, but it does exist is some very old upgraded databases.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Fri Feb 22 11:06:17 CET 2013 on sn-devel-104
commit 87db2331fc855473d8b3cad1c4149807823aa3c4
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Feb 11 14:45:57 2013 +1100
dsdb-descriptor: Spell out security descriptor flags as constants
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit a166a3484a68dc5328ee1d3e65221c30c081204b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Jan 16 08:52:41 2013 +1100
torture-drs: Fix comment in replica_sync test
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 59e8321324fe6b652724e71ba1df9da80f30cc67
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Feb 7 19:35:15 2013 +1100
torture-drs: Make the samba4.drs.repl_schema.python emit failures, not errors on add failure
This then allows this particular failure to be masked with a knownfail.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit c89df544239dbaedbb7f231f4556aff8e4a3f288
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Feb 15 13:32:06 2013 +1100
ldb: Add missing dependency on replace for ldb
This brings in rep_timegm() on Solaris for example.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 613f49ab8bf0bdcc7cd1e2c39bd624586a87cff3
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Feb 19 11:44:19 2013 +1100
build: Remove includes.h dep in winbind client libraries
Our LGPL winbind client libs do not link against our server-side code, and
should not use the server-side includes.h.
This removes a build-time dep on talloc that was brought in via includes.h as
this code also does not use talloc.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit f2c7f2c93d54c77753e2a1b0663813e9778172a4
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Feb 19 11:15:20 2013 +1100
build: Remove unused includes.h reference to avoid build-time talloc dep
talloc is not a dependency of this library, but is required by includes.h.
By not including includes.h, we avoid needing to add an otherwise false talloc dep.
(this comes up if talloc.h is not installed as a system package).
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 46ab33dc6753c135effedc204f3028a7e2bc2b1b
Author: Björn Jacke <bj at sernet.de>
Date: Wed Feb 20 19:57:24 2013 +0100
build:autoconf: fix output of syslog-facility check
thanks to Thomas Bork for reporting!
Signed-off-by: Bjoern Jacke <bj at sernet.de>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu Feb 21 00:00:06 CET 2013 on sn-devel-104
commit 3d29bb2d37b02909ecb500e864f3c13e06957a86
Author: Christian Ambach <ambi at samba.org>
Date: Wed Feb 20 16:59:05 2013 +0100
s3:rpc_client fix a crash
state->cli->dc does not have to be set (e.g. when running
net rpc join against an older Samba PDC), so check it before dereferencing it
This fixes Bug 9669 - net rpc join crashes against a Samba 3.0.33 PDC
Bug: https://bugzilla.samba.org/show_bug.cgi?id=9669
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Christian Ambach <ambi at samba.org>
Autobuild-Date(master): Wed Feb 20 19:00:52 CET 2013 on sn-devel-104
commit 2f4b21bb57c4f96c5f5b57a69d022c142d8088d5
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Wed Feb 20 14:59:42 2013 +1030
ntdb: switch between secrets.tdb and secrets.ntdb depending on 'use ntdb'
Since we open with dbwrap, it auto-converts old tdbs (which it will
rename to secrets.tdb.bak once it's done).
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Rusty Russell <rusty at rustcorp.com.au>
Autobuild-Date(master): Wed Feb 20 07:09:19 CET 2013 on sn-devel-104
commit 3c9c3029f2bcf10ef614dd9f923d02232db3ac8d
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Wed Feb 20 14:59:42 2013 +1030
param: 'use ntdb' flag (off by default).
For simplicity, we use this in the caller to choose between filenames.
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit e201033e84b54b13acc751db2b67cff159e12a0e
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Wed Feb 20 14:59:42 2013 +1030
tdb_wrap: prevent tdbs called ".ntdb" or without extensions.
This is another belt-and-braces check in case someone decides to turn
on the fancy new .ntdb extension, and we haven't converted it to ntdb.
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 53aac0bc9384db68c5ff469b07ae757ca1051cec
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Wed Feb 20 14:59:42 2013 +1030
dbwrap_local_open: never open the .tdb if there is an .ntdb
This provides an extra safety check that everyone is using one or the
other: you can't create a tdb file if there's an ntdb file.
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit f3c0d1d7fe71be7e8b2d1a9780586f8654b46469
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Wed Feb 20 14:59:42 2013 +1030
dbwrap_local_open: open NTDB if extension is .ntdb
This switches dbwrap_local_open() based on the extension of the
database name, so it handles both TDB and NTDB files.
Moreover, if asked to open a .ntdb, and there's no ntdb file but
there's a .tdb file, it converts that then moves it to .tdb.bak before
opening, and turn the .tdb file into a dangling symlink to make sure
it's never accidentally re-created or used:
$ ls -l secrets.tdb
lrwxrwxrwx 1 rusty rusty 23 Feb 11 11:31 secrets.tdb -> This is now in an NTDB
This provides transparent upgrade if people decide to use NTDB on a
database. Downgrade would be manual, eg:
ntdbdump foo.ntdb | tdbrestore foo.tdb && mv foo.ntdb foo.ntdb.bak
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 48a42708aead320bfbcee16ae76d095c014802de
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Wed Feb 20 14:59:42 2013 +1030
source3: explicitly disable NTDB support.
The next patch make dbwrap_local_open() call the ntdb backend for ntdb
files, but we don't want to add ntdb support to the old autoconf
build. It's cleaner to use the existing DISABLE_NTDB flag rather than
test for _SAMBA_BUILD_ in dbwrap_local_open.c.
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 63a6381a26171f069cdc7465ca753f0b3c5d26f2
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Wed Feb 20 14:58:59 2013 +1030
dbwrap: dbwrap_ntdb.c
This is a dbwrap backend for ntdb. It's a fairly straight conversion from
the tdb version.
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 3d82f786ecdd6747e90fe480a15de8c3fcea5f7b
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Sun Feb 17 20:56:34 2013 +1030
ntdb: fix database corruption when transaction doesn't change anything.
ntdb's transaction code has an optimization which tdb's doesnt: it
only writes the parts of blocks whose contents have changed. This
means we can actually have a transaction which turns out to need no
recovery region.
This breaks the recovery setup logic, which sets the current recovery
size to 0 if there's no recovery area, and assumes that we'll always
create a new recovery area since the recovery will always need > 0
bytes.
In fact, if we really haven't changed anything, we can skip the
transaction commit altogether: since this happens at least once with
Samba, it's worth doing.
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 85b6329b91f402da474547410e82438ea2554775
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Feb 15 14:29:51 2013 +0100
s3:selftest: generate ${SELFTESTPREFIX}/subunit with the raw output
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Wed Feb 20 01:33:50 CET 2013 on sn-devel-104
commit f3aa372bcb51bc08724f4ebe211b8c499f22cf30
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Feb 15 14:23:50 2013 +0100
s3:torture: call fault_setup() to get usage backtraces
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e29830a60fe7df82ba5f87e6f4e6359e025134d8
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 11:04:18 2013 +0100
s3:include: avoid TEVENT_COMPAT_DEFINES
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 95eeb9f08be84f92799ce0916a5dfa2dafd4b5f6
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:57:54 2013 +0100
s3:lib: s/event_add_timed/tevent_add_timer
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 01b8b1b88789a1f309a06d8db2983fd540feef9b
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:57:54 2013 +0100
s3:nmbd: s/event_add_timed/tevent_add_timer
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit cf1336e356001c3a83de063c501264fe37bf38c6
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:57:54 2013 +0100
s3:modules: s/event_add_timed/tevent_add_timer
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 98660d54a86fc29ee34094aa486b12ddf27e3906
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:57:54 2013 +0100
s3:rpc_server: s/event_add_timed/tevent_add_timer
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit fdf9da96c5ebe3fde8ec9fe6fba70cc8427f51d0
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:57:54 2013 +0100
s3:winbindd: s/event_add_timed/tevent_add_timer
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit cdb97fd9ec107617083c8d9ea068e1c0555443e8
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:53:02 2013 +0100
s3:lib: s/event_add_fd/tevent_add_fd and s/EVENT_FD_/TEVENT_FD_
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit abf8e166b8a23b256fada0f317cf552cc4f53ec1
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:53:02 2013 +0100
s3:printing: s/event_add_fd/tevent_add_fd and s/EVENT_FD_/TEVENT_FD_
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e5f6250ae26ba103b1682ae933b61732247795e8
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:53:02 2013 +0100
s3:smbd: s/event_add_fd/tevent_add_fd and s/EVENT_FD_/TEVENT_FD_
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 64145e7958204f2b2c444e8e904b533dd2108290
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:53:02 2013 +0100
s3:modules: s/event_add_fd/tevent_add_fd and s/EVENT_FD_/TEVENT_FD_
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit c0858030ba25d23b06a9dcf90b303f9325b7ac3e
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:24:12 2013 +0100
s3:lib: s/struct fd_event/struct tevent_fd
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 9ececaae5c13216ce9e29eebb0fad0d7a0e2ab90
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:24:12 2013 +0100
s3:modules: s/struct fd_event/struct tevent_fd
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit b7a925f56bb03aa80b043bb355203670edd75628
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:24:12 2013 +0100
s3:printing: s/struct fd_event/struct tevent_fd
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit a0d96b53e7730c5e0b4986342fa73ab81b7869ef
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:24:12 2013 +0100
s3:smbd: s/struct fd_event/struct tevent_fd
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 59b8f803d74c45e2477c533b5b380afb011f8ebe
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:18:29 2013 +0100
s3:lib: s/struct timed_event/struct tevent_timer
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 39660e6d88b54aee668e3f78bba83f036f1ff95c
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:18:29 2013 +0100
s3:nmbd: s/struct timed_event/struct tevent_timer
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 80421ee9752ed06e12721ef2a28b08e1c311e31e
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:18:29 2013 +0100
s3:modules: s/struct timed_event/struct tevent_timer
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 7f41a62e75ab9a07e93c4de2597a7ff9c47f506d
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:18:29 2013 +0100
s3:rpc_server: s/struct timed_event/struct tevent_timer
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 2672c37a8fbc9ff4e5b74e9a5ae55a3e08beed43
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:18:57 2013 +0100
s3:smbd: s/EVENT_FD/TEVENT_FD
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit ae1cb5ca04eb46d1112868bc80b459eb2a168920
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:18:29 2013 +0100
s3:smbd: s/struct timed_event/struct tevent_timer
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 3ae2ed4504c81e197fab5804e9cde7ebeb34d5c2
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:17:40 2013 +0100
s3:winbindd: s/struct timed_event/struct tevent_timer
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 804b18f38eabf07f2f01d44ea534fa9805443213
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:16:48 2013 +0100
s3:lib/events: s/EVENT_FD/TEVENT_FD
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 935a40f4f20048204fb7baf2f208e7e44f2485e7
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 10:00:26 2013 +0100
s3:lib: s/struct event_context/struct tevent_context
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit d0bca41f481fbaa4b25190bbb58fe119ca5ccec9
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:59:58 2013 +0100
s3:libsmb: s/struct event_context/struct tevent_context
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 00b1ef8853a0ad3bf967f98d5a9a570109abb82e
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:59:08 2013 +0100
s3:modules: s/struct event_context/struct tevent_context
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 5743277ed6297ce77afcdb7b336c8929c83af8a3
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:58:40 2013 +0100
s3:nmbd: s/struct event_context/struct tevent_context
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 99367d413ac00d631fe0e559473395feee6cfc5a
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:58:10 2013 +0100
s3:printing: s/struct event_context/struct tevent_context
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit cf1f993c057cf296edfd5c28b2f9cd84862340d0
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:57:48 2013 +0100
s3:rpc_server: s/struct event_context/struct tevent_context
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f9d0473d024bc7b6efc4619c7c77b5bf992f6d54
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:57:22 2013 +0100
s3:rpc_client: s/struct event_context/struct tevent_context
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 415e8e0513017207c9c87ec968f22ed43bdb220b
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:56:41 2013 +0100
s3:smbd: s/struct event_context/struct tevent_context
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 5c72385f3d4ba5f5747d9d5895286dfacbb2ba7a
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:55:58 2013 +0100
s3:torture: s/struct event_context/struct tevent_context
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit b946b457991b34e89292a4dcd54f34a5c1de52d6
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:55:02 2013 +0100
s3:winbindd: s/struct event_context/struct tevent_context
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 36f4547401a67acf19d2fc1037beb6d89ae86b84
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:21:53 2013 +0100
s3:includes: remove event_context_init() define for s3_tevent_context_init()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 5a2aaafee7f040baaec24467f09a4a8b7e95c1d7
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:12:26 2013 +0100
s3:winbindd: make use of samba_tevent_context_init()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit b538c3188971621dd55011e6050b5af281403bf7
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:17:45 2013 +0100
s3:rpc_client: make use of samba_tevent_context_init()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 60fa4c7305b4c766fe05a06025bce9ab1ff02902
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:11:19 2013 +0100
s3:torture: make use of samba_tevent_context_init()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 22dd9e7c792c4decf4fcbe3b1ed2ea1f165c2af6
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:11:52 2013 +0100
s3:utils: make use of samba_tevent_context_init()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e8bda0017c5f8770dc3dce238ea3cefb1f4dd73f
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:17:22 2013 +0100
s3:libnet: make use of samba_tevent_context_init()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f3915cf0ec9ac51f541cafcb367221a3dac3aec8
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:10:34 2013 +0100
s3:lib: make use of samba_tevent_context_init()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 3cad605ee9454ae6000349340073124a8df80896
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:09:57 2013 +0100
s3:libads: make use of samba_tevent_context_init()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit c8dda78e35294ad56f088c86201430442df2efce
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:08:19 2013 +0100
s3:libsmb: make use of samba_tevent_context_init()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 7fb720502f6488b5b4e29a00f4b34a6486159349
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:13:23 2013 +0100
s4:lib/com: make use of samba_tevent_context_init()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 5d2574edd24464c0b38c6f2e80382b01a82e00d0
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:12:58 2013 +0100
s4:auth/kerberos: make use of samba_tevent_context_init()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 3d5bb24a7b6e772ebc15e1d6063d9a8fd97d9ce7
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:09:31 2013 +0100
librpc/rpc: make use of samba_tevent_context_init()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 4ea37dd52105c7faff633d172f96972bd79305f5
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:07:11 2013 +0100
libcli/smb: make use of samba_tevent_context_init()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f40c93afcbda48ebe109896fb115377a276b4457
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 09:06:29 2013 +0100
libcli/cldap: make use of samba_tevent_context_init()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f7aa60175ad7a3517db32f45f06dfbf6486dff69
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 18 08:54:51 2013 +0100
lib/util: add samba_tevent_context_init()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit ff8ba0628f6f13a5be1df94e5ac2e83008b7c69c
Author: Björn Jacke <bj at sernet.de>
Date: Tue Feb 19 15:30:34 2013 +0100
build/autoconf: fix check for GNU ld version
we need to look for the version once in the stdout and once in the stderr
output. Some version of ld output to stdout, some output to stderr. redirecting
stderr to stdout messes the output up in our case, that's why we have to do two
runs. See also bug #7825.
Signed-off-by: Bjoern Jacke <bj at sernet.de>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Björn Jacke <bj at sernet.de>
Autobuild-Date(master): Tue Feb 19 20:56:12 CET 2013 on sn-devel-104
commit 432dde0223d884b7de1a9d3c0655304efbcf1f88
Author: Christian Ambach <ambi at samba.org>
Date: Mon Feb 18 17:34:25 2013 +0100
s3:build fix the build with --fake-kaserver
this fixes Bug 9643 - Build in source3 of bin/net fails when configure option
--with-fake-kaserver is used
Bug: https://bugzilla.samba.org/show_bug.cgi?id=9643
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Tue Feb 19 19:15:19 CET 2013 on sn-devel-104
commit e7f66f37a62ad954e8b0a048905f0e6688b70849
Author: Christian Ambach <ambi at samba.org>
Date: Mon Feb 18 16:55:30 2013 +0100
s3:lib/afs fix the build
Fix Bug 9644 - Compile of source3/lib/afs.c fails
Bug: https://bugzilla.samba.org/show_bug.cgi?id=9644
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit a7fdd4f7c2e64eedf12cb46c3435edbec772a4ab
Author: Volker Lendecke <vl at samba.org>
Date: Tue Feb 19 12:23:36 2013 +0100
tdb: Slightly simplify transaction_write
realloc(NULL, ...) is equivalent to malloc. We are already using this
realloc property for tdb->lockrecs. It should not make any difference
in speed, it just makes for a little simpler code.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Feb 19 17:30:13 CET 2013 on sn-devel-104
commit fcb345f5d6be9659a0f8a5afe62a937010a33d5c
Author: Volker Lendecke <vl at samba.org>
Date: Sat Feb 16 22:08:52 2013 +0100
tdb: Make tdb_release_transaction_locks use tdb_allrecord_unlock
The transaction code uses tdb_alrecord_lock/upgrade, so it should also
use the tdb_allrecord_unlock function just for symmetry reasons
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 5929e38b6cdbd4f9721293a19f079ceae1af76b0
Author: Volker Lendecke <vl at samba.org>
Date: Sat Feb 16 22:07:41 2013 +0100
tdb: Don't segfault if tdb_open_ex for check failed
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 3534e4e8d5bebfaaaef5886dcea219a7e4047fc7
Author: Volker Lendecke <vl at samba.org>
Date: Sat Feb 16 16:49:56 2013 +0100
tdb: Factor out the retry loop from tdb_allrecord_upgrade
For the mutex code we will have to lock the hashchain and the record
lock area independently. So we will have to call the loop twice. And,
it's a small refactoring for the better anyway I think.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 1f93f0836484ccc1abe335f5bd2cfd35df0b7631
Author: Volker Lendecke <vl at samba.org>
Date: Sat Feb 16 14:17:57 2013 +0100
tdb: Simplify fcntl_lock() a bit
All arguments but the cmd are the same. To me this looks a bit better
and saves some bytes in the object code.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 542400a966039178effd6c8da932ed3a8d749131
Author: Volker Lendecke <vl at samba.org>
Date: Sat Feb 16 13:39:28 2013 +0100
tdb: Use tdb_null in freelistcheck
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 68559b787e7c9a83e055493bde638ec02e1097d1
Author: Volker Lendecke <vl at samba.org>
Date: Thu Feb 14 16:10:31 2013 +0100
tdb: Enhance lock tracking a bit
lock-tracking.c mirrors the in-kernel fcntl structures to detect
unexpected use of fcntl calls. During my mutex work I changed our fcntl
use so that we unlock the allrecord_lock in two pieces: The range covering
the hash locks and the range covering the data area for the individual
traverse record locks. Splitting locks is not covered by lock-tracking.c.
This patch extends lock-tracking.c with this little piece. It's still
far from complete to track the full range of fcntl semantics. It is not
strictly needed right now, but it does not hurt either.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 31e4d6d2c7779e2f688352f5947e6bbd2a1cfc60
Author: Michael Adam <obnox at samba.org>
Date: Tue Feb 19 13:27:10 2013 +0100
s3:smbd: preserve file type mode bits in file_set_dosmode()
When translating between dos modes and unix modes, these bits were dropped from
the stat->st_ex_mode field.
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Feb 19 15:45:31 CET 2013 on sn-devel-104
commit f211b57dd28e5aab69480f9e9764864922f988e4
Author: Michael Adam <obnox at samba.org>
Date: Wed Feb 13 09:46:33 2013 +0100
gencache: fix an extra newline in a DEBUG message in gencache_set_data_blob()
by using timestring() instead of ctime()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 86d78dfa838e8f4432d0ba73828b1f9bfc7877b8
Author: Michael Adam <obnox at samba.org>
Date: Wed Feb 13 09:45:09 2013 +0100
gencache: fix an extra newline in a DEBUG message in gencache_iterate_fn()
by using timestring() instead of ctime()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit f7525abf3bc561a2b783523ef82520954c4e9d84
Author: Michael Adam <obnox at samba.org>
Date: Wed Feb 13 09:43:19 2013 +0100
gencache: fix an extra newline in a DEBUG message in gencache_iterate_blobs_fn()
by using timestring() instead of ctime()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 762dd3cf29788a9f8ab66fd96ad2b9cc20f621f3
Author: Michael Adam <obnox at samba.org>
Date: Wed Feb 13 16:51:54 2013 +0100
lib/util/time: strip a potential trailing newline in the asctime case.
If strftime() is not available, asctime() is used, and this usually
appends a newline character to the result. This is not desired for
timestamp().
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 4d3928a8f494661764f4a3367b2f1b94772dedf9
Author: Michael Adam <obnox at samba.org>
Date: Mon Feb 11 13:41:12 2013 +0100
gencache: unify a DEBUG message in gencache_set_data_blob()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 56ee82e8a04a631ec4cee4e3f9a30f9104ca43c7
Author: Michael Adam <obnox at samba.org>
Date: Mon Feb 11 13:42:58 2013 +0100
gencache: unify a DEBUG message in gencache_iterate_fn()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit ddf2aa3340168361ba1680c05f07becaf4b25012
Author: Michael Adam <obnox at samba.org>
Date: Mon Feb 11 13:42:28 2013 +0100
gencache: unify a DEBUG message in gencache_iterate_blobs_fn()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 7e36b1b8cbca1b3bcf3081928a453de581cf1977
Author: Michael Adam <obnox at samba.org>
Date: Mon Feb 11 13:43:32 2013 +0100
gencache: unify a DEBUG message in gencache_del()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit c1d58f222fec4b23a1e37a4e911a648afa4fdb74
Author: Michael Adam <obnox at samba.org>
Date: Thu Oct 25 05:35:50 2012 -0400
packaging(RHEL-CTDB): remove unpackaged manpages (samba and samba-tool)
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit ed28246c2501ad1163aa979d41eba9fbf52010f5
Author: Michael Adam <obnox at samba.org>
Date: Thu Oct 25 05:34:23 2012 -0400
packaging(RHEL-CTDB): package the fake-acls vfs module
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 5ab77259746ef3811a64f6c7880ae2263d512c16
Author: Gregor Beck <gbeck at sernet.de>
Date: Thu Dec 13 13:00:28 2012 +0100
s3:net: new implementation of "servid wipedbs" with smbXsrv_*
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Feb 19 13:56:57 CET 2013 on sn-devel-104
commit d8dd0ecc484ccc0c3450c3e96725e56e8bf1a9ef
Author: Gregor Beck <gbeck at sernet.de>
Date: Thu Jan 10 11:09:09 2013 +0100
lib/util_tdb: factor out tdb_data_talloc_copy()
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit d23f19ab00314d773edb07a45e754365db378668
Author: Gregor Beck <gbeck at sernet.de>
Date: Wed Dec 12 16:06:50 2012 +0100
s3:smbXsrv_open: add smbXsrv_open_global_traverse()
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 60721a378240cb08e3f2ac0a1de14df5c9130010
Author: Gregor Beck <gbeck at sernet.de>
Date: Thu Dec 13 15:27:07 2012 +0100
s3:smbXsrv_tcon: pass record in smbXsrv_tcon_global_traverse()
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 93e22bb1c401b423b0242e6923b8e7944f793b3f
Author: Gregor Beck <gbeck at sernet.de>
Date: Thu Dec 13 15:26:49 2012 +0100
s3:smbXsrv_session: pass record in smbXsrv_session_global_traverse()
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit bdb80aeb11d5458e281483a5cdc57f5481979cc9
Author: Michael Adam <obnox at samba.org>
Date: Mon Feb 18 23:21:24 2013 +0100
s3:smbd:smb2: fix segfault (access after free) in durable disconnect code
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Feb 19 11:12:01 CET 2013 on sn-devel-104
commit 2cf83f7c645e4b216cf6f23857fd72ec0e6ca7a6
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Feb 17 18:15:52 2013 +1100
samba_upgradeprovision: Use tdb_util.tdb_copy not shutil.copy2
This is really important, because copying a file will both ignore
locks held by another process and break any locks we hold (due to
POSIX brain-damage regarding multiple fds on one file in a process).
By leaving this to tdbbackup in a child, both of these issues are avoided.
Andrew Bartlett
Reviewed-by: Matthieu Patou <mat at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue Feb 19 07:48:18 CET 2013 on sn-devel-104
commit 3c51e18a0cd1cb4b54cd29e312abd7cc2c0fbc98
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Feb 17 18:41:00 2013 +1100
samba_upgradeprovision: Do not update privileges.ldb any more (unchanged since 2009)
This update was only a total oblitoration of the existing database
and not a merge, and the shutil.copy would both disregard and break
locks on the database that are held at this point.
Andrew Bartlett
Reviewed-by: Matthieu Patou <mat at samba.org>
commit 396df64ef6f2c66c35989ecda3e564d5578fe9f3
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Feb 17 18:14:06 2013 +1100
scripting: Make tdb_copy a common util function in samba.tdb_util
This will allow samba_upgradeprovision to also call it.
Andrew Bartlett
Reviewed-by: Matthieu Patou <mat at samba.org>
commit 2c2759e408d9c45c2aee0c2578f45edd246afec3
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Feb 17 17:57:42 2013 +1100
scripting: Make tdb_copy use the python subprocess module
This makes the code more robust to spaces in the file names (etc).
Andrew Bartlett
Reviewed-by: Matthieu Patou <mat at samba.org>
commit 06780ae82281fb62a08d0c3604d2e679976756c2
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Feb 16 08:51:51 2013 +1100
samba_upgradeprovision: Remove options to fix FS ACLs
samba-tool ntacl sysvolreset handles this better, and makes this tool
much less confusing internally.
Andrew Bartlett
Reviewed-by: Matthieu Patou <mat at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue Feb 19 06:06:41 CET 2013 on sn-devel-104
commit cfebce3c56474ac914474b57ed94f93418b0564b
Author: Michael Adam <obnox at samba.org>
Date: Tue Feb 12 17:44:51 2013 +0100
s3:smbd: add debugging to close code (regarding disconnect of a durable)
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Mon Feb 18 17:42:45 CET 2013 on sn-devel-104
commit 295444266d33863e3a8b7c8ffa5d193123db6132
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 13 14:11:57 2013 +0100
s4:torture: fix segfault in test_durable_open_open2_oplock()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 2f8a033bf2563d547e42be5603074223078595f9
Author: Michael Adam <obnox at samba.org>
Date: Wed Feb 13 15:05:40 2013 +0100
s4:torture:smb2: fix segfault on error condition in the durable-open.delete_on_close2 test
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 1d3bd45d6177c8af653dbacac934eb2061acf35e
Author: Michael Adam <obnox at samba.org>
Date: Wed Feb 13 15:04:10 2013 +0100
s4:torture:smb2: fix segfault on error condition in the durable-open.delete_on_close1 test
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 98b0e909b7b65bee694743617476d4d36fe595a3
Author: Michael Adam <obnox at samba.org>
Date: Wed Feb 13 15:03:00 2013 +0100
s4:torture:smb2: fix segfault on error condition in the durable-open.reopen4 test
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 10fcbc6869dc2803e1c2dd3183c6781f4233550d
Author: Michael Adam <obnox at samba.org>
Date: Wed Feb 13 15:01:47 2013 +0100
s4:torture:smb2: fix segfault on error condition in the durable-open.reopen3 test
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit cb9b8975e5a9c032f7c4227c3eafb1ed6ada5e19
Author: Michael Adam <obnox at samba.org>
Date: Wed Feb 13 15:00:26 2013 +0100
s4:torture:smb2: fix segfault on error condition in the durable-open.reopen2a test
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 6385f750f19a00a6ba16a0aec9bb91ab1cfcb2be
Author: Michael Adam <obnox at samba.org>
Date: Wed Feb 13 14:58:29 2013 +0100
s4:torture:smb2: fix segfault on error condition in durable-open.reopen2 test
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 6240a7d11e910027b42ac1d31ca13264e90d2266
Author: Michael Adam <obnox at samba.org>
Date: Tue Feb 12 21:51:06 2013 +0100
s4:torture:smb2:durable: make test functions static
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 42bf98d54c36abd5f532a4510cdd4066fe82143d
Author: Michael Adam <obnox at samba.org>
Date: Tue Feb 12 17:45:23 2013 +0100
s4:torture: add a durable-open-disconnect test (suite)
this opens a durable, disconnects it and exits
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit f0e6a9be00e441e50f0087c543e1b7c9012d126f
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 13 08:26:43 2013 -0500
s3:smbd: use smbXsrv_open_close() instead of smbXsrv_open_update()
This makes sure we store the correct disconnect_time for disconnected
durable handles.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 8adbd1cf75492869f7fd1935eb211a070ef924cc
Author: Karolin Seeger <kseeger at samba.org>
Date: Mon Feb 18 10:25:09 2013 +0100
srv_epmapper.c: Fix typo.
priviledge -> privilege
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon Feb 18 13:57:40 CET 2013 on sn-devel-104
commit 240df6c7b05e3c5c7be80d7607824147f360d64e
Author: Karolin Seeger <kseeger at samba.org>
Date: Mon Feb 18 10:05:23 2013 +0100
wb_samba3_cmd.c: Fix typo in comment.
redundent -> redundant
Signed-off-by: Karolin Seeger <kseeger at samba.org>
commit b22b22dccac6d3bdf7f02d9fe037a472df7956fd
Author: Karolin Seeger <kseeger at samba.org>
Date: Mon Feb 18 10:04:42 2013 +0100
brlock_tdb.c: Fix typo in comment.
redundent -> redundant
Signed-off-by: Karolin Seeger <kseeger at samba.org>
commit 75ca814f1efe435da018f7604865fda7ac59f712
Author: Karolin Seeger <kseeger at samba.org>
Date: Mon Feb 18 10:03:51 2013 +0100
srv_netlog_nt.c: Fix typo in comment.
redundent -> redundant
Signed-off-by: Karolin Seeger <kseeger at samba.org>
commit 6eb59eb388ac7b98f7f7812e45ad4c8d333f03e8
Author: Karolin Seeger <kseeger at samba.org>
Date: Mon Feb 18 10:02:51 2013 +0100
brlock.c: Fix typo in comment.
redundent -> redundant
Signed-off-by: Karolin Seeger <kseeger at samba.org>
commit 38cb1410f5107f42ddea9cbf9555adb273b35b18
Author: Karolin Seeger <kseeger at samba.org>
Date: Mon Feb 18 10:01:21 2013 +0100
vfs_gpfs: Fix typos in comments.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
commit 2ed035b5a064e21f57c89adc9c947ffa7721c600
Author: Karolin Seeger <kseeger at samba.org>
Date: Mon Feb 18 09:59:52 2013 +0100
fault.c: Fix typo in comment.
redundent -> redundant
Signed-off-by: Karolin Seeger <kseeger at samba.org>
commit 68b2e30ae62d8a563cb7ee35e10c45fe0266c612
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed Feb 6 09:08:15 2013 +0100
docs: Fix typo.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
commit dcc94f093317ffa2bbbc776fb82657088eb63305
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Feb 6 20:58:18 2013 +1100
s4-nbt: Ensure source4/ nbt client and server honour 'disable netbios'
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sun Feb 17 11:25:34 CET 2013 on sn-devel-104
commit 6dfb35f3ff7ad2d2089c0a3e5eab342384e45e4c
Author: Landon Fuller <landonf at bikemonkey.org>
Date: Sat Feb 16 22:57:40 2013 -0500
Fallback to the internal resolver on EAI_FAIL.
On Linux, non-RFC 1034-complaint names (such as gc._msdsc.example.org)
will result in the resolver returning the non-POSIX EAI_NODATA. In that
case, the case statement here would fall back on the internal resolver,
allowing resolution to complete successfully.
On FreeBSD, the libc resolver uses the same validation code, but
the POSIX result of EAI_FAIL is returned instead of EAI_NODATA. Since
there was no case for this error code, no fallback to the internal
resolver would occur. This led to replication failing on FreeBSD.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sun Feb 17 07:06:36 CET 2013 on sn-devel-104
commit 05235d5b444558f6d06ef12ea7d74850800425cf
Author: Volker Lendecke <vl at samba.org>
Date: Sat Feb 16 13:26:36 2013 +0100
tdb: Fix a typo
Signed-off-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Simo Sorce <idra at samba.org>
Autobuild-Date(master): Sat Feb 16 17:13:32 CET 2013 on sn-devel-104
commit 10b96e3ffe1ccec4e6866b61ddd93e04a7863bbf
Author: Richard Sharpe <realrichardsharpe at gmail.com>
Date: Thu Feb 14 16:04:24 2013 -0800
Fix the maxfids test so that it does not fork lots of processes and so that it works for all cases of maxfids.
Signed-off-by: Richard Sharpe <realrichardsharpe at gmail.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Feb 15 07:09:59 CET 2013 on sn-devel-104
commit daada849209df893ef9b42ea2be5de77d2d4125f
Author: Jeremy Allison <jra at samba.org>
Date: Mon Feb 11 11:42:08 2013 -0800
tevent: Remove the previous "standard" tevent backend implementation.
This was a horrible hybrid of duplicated epoll and select()
code.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Feb 14 22:40:30 CET 2013 on sn-devel-104
commit 16f57076b1b527c65da42e1fab6119c67bcd7f47
Author: Jeremy Allison <jra at samba.org>
Date: Mon Feb 11 11:40:49 2013 -0800
tevent: Add in the new implementation of "standard" tevent backend.
Falls back cleanly from epoll -> poll, or uses poll if
epoll not available.
Signed-off-by: Jeremy Allison <jra at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 203f85c25eb9238eae8e4dc5b55b549294b0fa03
Author: Jeremy Allison <jra at samba.org>
Date: Mon Feb 11 11:20:28 2013 -0800
tevent: Add a private function tevent_poll_event_add_fd_internal().
Not yet used, but will be called by the "standard"
fallback from epoll -> poll backends.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 5fe459f5d7c0e6b5eeeb1aa2c8248e174a31008f
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 14 09:30:31 2013 +0100
tevent: make use of tevent_find_ops_byname() in tevent_context_init_byname()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit b5556a79e39be0bc9945cbac4e603b045ab55505
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 14 09:29:57 2013 +0100
tevent: make sure tevent_backend_init() only runs once
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit aceeb585cb6170e42cadae17791b8314083c278c
Author: Jeremy Allison <jra at samba.org>
Date: Mon Feb 11 10:56:58 2013 -0800
tevent: Add a utility function tevent_find_ops_byname().
Returns an event ops struct given a string name. Not
yet used, but will be part of the new "standard" fallback
code.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 1ee428d5cad6910521ce77322614183fa2c7916e
Author: Jeremy Allison <jra at samba.org>
Date: Mon Feb 11 10:53:15 2013 -0800
tevent: Add in the same tevent_re_initialise() fix Metze put in the tevent_poll backend.
We might be called during tevent_re_initialise()
which means we need to free our old additional_data.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 06fb88b449806d6de7ca20c73778dd6545a38cf7
Author: Jeremy Allison <jra at samba.org>
Date: Mon Feb 11 10:52:30 2013 -0800
tevent: Add in some test code to allow the panic fallback path to be tested.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 6f9819229b3d60cb898a0f9bfc67793b6c40fc2c
Author: Jeremy Allison <jra at samba.org>
Date: Mon Feb 11 10:48:02 2013 -0800
tevent: Plumb in the panic fallback code into the epoll_panic() runtime call.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 04ba47e491d84f58562b57f937be632e75c204aa
Author: Jeremy Allison <jra at samba.org>
Date: Mon Feb 11 10:43:39 2013 -0800
tevent: Add an internal function tevent_epoll_set_panic_fallback().
Can be set externally, allows us to fallback if epoll
fails at runtime.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit e4ef2ecf023c63ee28e40a1b60ecc6091a126001
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Feb 14 10:58:55 2013 +0100
tevent: pass 'bool replay' to epoll_panic()
A fallback panic handler will need to know if
there was an error while waiting for events
(replay=true) or if the error happened on modify
(replay=false).
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit 129da06d2d9c9d1cedc5e4de492744b29adc1684
Author: Jeremy Allison <jra at samba.org>
Date: Mon Feb 11 10:38:01 2013 -0800
tevent: Ensure we return after every call to epoll_panic().
Currently we can't return from this, but the new fallback
code will change this.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit c36f8c14008e55b2be2e93c0987eb6971d45855f
Author: Jeremy Allison <jra at samba.org>
Date: Mon Feb 11 10:36:52 2013 -0800
tevent: Preparing to fix "standard" backend fallback. Initialize standard after epoll.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 736e3b1335dde1ea20914841d1e178e453b42249
Author: Samba-JP oota <ribbon at samba.gr.jp>
Date: Thu Feb 14 22:55:51 2013 +0900
docs: fix typo in serverrole.xml
Reviewed-by: David Disseldorp <ddiss at samba.org>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Thu Feb 14 18:43:57 CET 2013 on sn-devel-104
commit 9c812604995836a51693f620459f415996e00159
Author: Andreas Schneider <asn at samba.org>
Date: Thu Feb 14 12:34:01 2013 +0100
waf: Make sure we link against samba-util.
libcmdline-credentials.so needs samba_getpass() from libsamba-util.so,
so we need to link against it.
Reviewed-by: Andrew Bartlet <abartlet at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Thu Feb 14 16:56:29 CET 2013 on sn-devel-104
commit 19c68f80251f443016e505c5cf87f697fb552e8c
Author: Michael Adam <obnox at samba.org>
Date: Mon Feb 11 22:52:55 2013 +0100
s3:idmap_autorid: fix freeing of non-talloced memory (uninitialized pointer) (bug #9653)
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Wed Feb 13 09:51:53 CET 2013 on sn-devel-104
commit a64a617e103983e2423cca2e8e09009d2e571b2b
Author: Richard Sharpe <realrichardsharpe at gmail.com>
Date: Wed Feb 6 13:02:13 2013 -0800
Add a herald with version string to smbtorture
Signed-off-by: Richard Sharpe <realrichardsharpe at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Richard Sharpe <sharpe at samba.org>
Autobuild-Date(master): Wed Feb 13 08:03:21 CET 2013 on sn-devel-104
commit fa3924f9ea656c279d430212b4b2a667bf5227f8
Author: Jeremy Allison <jra at samba.org>
Date: Tue Feb 12 10:48:09 2013 -0800
Fix bug 9519 - Samba returns unexpected error on SMB posix open.
Explicitly ignore bare O_EXCL flags instead of returning INVALID_PARAMETER.
That's what the Linux kernel does.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Jeff Layton <jlayton at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Feb 12 22:59:21 CET 2013 on sn-devel-104
commit efd60aeff7aac308d85b767cdf394dd866cce078
Author: Guenter Kukkukk <kukks at samba.org>
Date: Tue Feb 12 05:37:09 2013 +0100
Fix some cut-and-paste and spelling in debug messages
Signed-off-by: Guenter Kukkukk <kukks at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue Feb 12 07:28:27 CET 2013 on sn-devel-104
commit f25debf2fbf988c7b3415b86ccc5880319517bdd
Author: Jeremy Allison <jra at samba.org>
Date: Fri Feb 8 17:08:28 2013 -0800
Fix bug #9642 - vfs_afsacl.c won't build.
Add missing mem_ctx argument.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Mon Feb 11 20:24:00 CET 2013 on sn-devel-104
commit c932b139c8d1fc0b6a357623fe4011edabb45422
Author: Richard Sharpe <realrichardsharpe at gmail.com>
Date: Fri Feb 8 19:56:56 2013 -0800
Improve the configure tests for aio_suspend to get rid of warnings. Timur provided the wscript method, I added the configure.in correction.
Signed-off-by: Timur Bakeyev <timur at freebsd.org>
Signed-off-by: Richard Sharpe <realrichardsharpe at gmail.com>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sat Feb 9 09:24:06 CET 2013 on sn-devel-104
commit 233b32b771188a6b9ee730a2a202023370e80746
Author: Ira Cooper <ira at samba.org>
Date: Wed Feb 6 13:35:25 2013 +0000
s3: Make SMB2_GETINFO multi-volume aware.
Not all shares are a single volume. Some actually
expose multiple volumes under a single share. In these
cases showing the amount of space free as the space free
at the base of the directory heirarchy is wrong.
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Feb 8 21:44:37 CET 2013 on sn-devel-104
commit beb6c13e9a8c317bca240e875d9e3bcd940a02fb
Author: Volker Lendecke <vl at samba.org>
Date: Mon Feb 4 15:52:49 2013 +0100
winbind: Fix an incompatible pointer type warning
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Fri Feb 8 15:27:51 CET 2013 on sn-devel-104
commit c03d5c5740f9d1894a971110029e8f567d300d8a
Author: Volker Lendecke <vl at samba.org>
Date: Fri Jan 11 15:32:39 2013 +0100
dbwrap: Prevent transactions on non-persistent dbs
dbwrap_ctdb does not allow this anyway. This patch will avoid suprises
when going non-clustered to clustered. Not everybody is developing
against a clustered environment :-)
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit dc2e47508d7075cf6507e0dea03da6999ef9097e
Author: Volker Lendecke <vl at samba.org>
Date: Fri Jan 11 17:29:01 2013 +0100
torture: We use transactions for CLEAR_IF_FIRST db
This does not work in the ctdb case
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 554ba5ebbf1d2e520883cfad6f8a2ed6eb9b2b0f
Author: Matthieu Patou <mat at matws.net>
Date: Tue Jan 8 00:09:32 2013 -0800
ldb: Add more data test data for one level test cases
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Fri Feb 8 06:46:40 CET 2013 on sn-devel-104
commit 9206eaaf5dbacade3ccc79d5900d4b242730b2f3
Author: Matthieu Patou <mat at matws.net>
Date: Tue Jan 8 00:28:03 2013 -0800
ldb: Add tests for the python api
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 2dc9c072cbb9b857bf52e229573d92c9a70bdcf6
Author: Matthieu Patou <mat at matws.net>
Date: Thu Dec 27 18:29:49 2012 -0800
dsdb-operational: rework the loop for attribute removal
Instead of doing ldb_in_list size(operational_remove) * (attrs_user +
attr_searched) * number of entries times to get the list of attributes to remove we construct this
list before the search and then use it for every entries.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 13b481594585cdb079dcf9b8cf892f5094f44a16
Author: Matthieu Patou <mat at matws.net>
Date: Sat Dec 29 21:48:46 2012 -0800
ldb: Add more tests related to onelevel search
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 057896a090870ecec56ad0d2f960e55cef561e9e
Author: Matthieu Patou <mat at matws.net>
Date: Thu Dec 13 02:18:34 2012 -0800
ldb: use strncmp instead of strcmp when comparing the val part
val part of a DN's component is DATA_BLOB and nothing insure that it
will be finished by a '\0'
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 87cbd9414bab2f0a71d71b2c145c11ee71acd573
Author: Matthieu Patou <mat at matws.net>
Date: Sat Dec 29 16:42:28 2012 -0800
ldb: make test output more readable
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 75f422fe1df7dd04aa46d5c77cbeb43d101c3ad6
Author: Matthieu Patou <mat at matws.net>
Date: Mon Dec 17 01:45:30 2012 -0800
ldb-tdb: Document ltdb_index_add1 for more clarity
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 1e4e51f4c913a3821d7ecbd0842280240917ae38
Author: Matthieu Patou <mat at matws.net>
Date: Wed Dec 26 21:41:52 2012 -0800
ldb-tdb: Fix a wrong parameter in ltdb_store
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 2470b0fe5f3facf7bb41acbdb3028e2d5daaf8da
Author: Matthieu Patou <mat at matws.net>
Date: Sun Jan 6 22:17:26 2013 -0800
ldb_tdb: raise level of full index scan message so that it starts to be really visible
We don't want to have to set log level to 4 or 5 AND set the environment
variable to be able to see those log messages
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 1c0d3486a485cf01338dd5eff49ce847628d1b83
Author: Matthieu Patou <mat at matws.net>
Date: Wed Jan 23 11:33:30 2013 -0800
dsdb-repl: make message more clearer
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 7222ee0a245d340b526b8220d53c9ffd8c0c4dfa
Author: Matthieu Patou <mat at matws.net>
Date: Sat Jan 26 01:53:41 2013 -0800
replmetadata: raise msg level for conflict resolution so that we don't polute logs
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit fdca2f6ff47a389cb6300d3ea8327f8486de3c2a
Author: Matthieu Patou <mat at matws.net>
Date: Sat Jan 26 01:53:28 2013 -0800
dsdb-repl: do not ask to add ref when doing getncchange for an exop
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 123954d94ee783bd241c89fa53fc902312176875
Author: Matthieu Patou <mat at matws.net>
Date: Mon Dec 24 10:01:30 2012 -0800
dsdb-cracknames: Fix potential double free and memory leaks
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 64eba0a8421bf4648f79085dd23b3e55d5a322df
Author: David Disseldorp <ddiss at samba.org>
Date: Mon Feb 4 19:04:39 2013 +0100
BUG 9633: Recursive mget should continue on EPERM.
Regression introduced by 14ff2e8de9bd8d0064762234555260f5eea643fe.
When downloading files recursively, smbclient halts if it encounters
a folder to which it does not have permission to traverse.
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Thu Feb 7 15:50:36 CET 2013 on sn-devel-104
commit 62e6ea408a20197420eadb133df6ba233c7874b4
Author: Sumit Bose <sbose at redhat.com>
Date: Mon Feb 4 13:15:18 2013 +0100
s3-rpc_server: Fix password encoding in _netr_ServerGetTrustInfo().
Reviewed-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 823a25f6a47c311ab33874be8a889ffbaf8db527
Author: Günther Deschner <gd at samba.org>
Date: Tue Dec 11 09:29:37 2012 +0100
s3-rpc_server: Dont wipe out ref pointers in _netr_ServerGetTrustInfo().
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit ff496ef29fe0eb8db929ba014abf5f8eeed86b33
Author: Alexander Bokovoy <ab at samba.org>
Date: Wed Feb 6 12:22:12 2013 +0200
autoconf: rename pdb_ldap module to pdb_ldapsam
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Alexander Bokovoy <ab at samba.org>
Autobuild-Date(master): Wed Feb 6 13:32:53 CET 2013 on sn-devel-104
commit e721e7132e7bb32850ff8b2af654b8f3ebf955fe
Author: Alexander Bokovoy <ab at samba.org>
Date: Wed Feb 6 10:43:16 2013 +0200
source3/wscript: support 'pdb_ldap' module in configure
While PASSDB module ldapsam is called pdb_ldapsam internally,
support specifying 'pdb_ldap' during configure step.
This should make transition to pdb_ldapsam transparent to distributions.
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 1b582c4bf8ad46034eb30c758b085dc210e8096a
Author: Andreas Schneider <asn at samba.org>
Date: Mon Jan 28 16:16:42 2013 +0100
Rename pdb_ldap to pdb_ldapsam
This patch moves pdb_ldap to pdb_ldapsam unconditionally
and makes possible to load ldapsam.so dynamically
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 6ba7ab5c14801aecae96373d5a9db7ab82957526
Author: Alexander Bokovoy <ab at samba.org>
Date: Wed Feb 6 10:17:57 2013 +0200
PIDL: fix parsing linemarkers in preprocessor output
When PIDL calls out to C preprocessor to expand IDL files
and parse the output, it filters out linemarkers and line control
information as described in http://gcc.gnu.org/onlinedocs/cpp/Preprocessor-Output.html
and http://gcc.gnu.org/onlinedocs/cpp/Line-Control.html#Line-Control
With gcc 4.8 stdc-predef.h is included automatically and linemarker for the
file has extended flags that PIDL couldn't parse ('system header that needs to
be extern "C" protected for C++')
Thanks to Jakub Jelinek <jakub at redhat.com> for explanation of the linemarker format.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=906517
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 1aa1d658c8f60ab890772e2c0044e2f939db79c4
Author: Samba-JP oota <ribbon at samba.gr.jp>
Date: Wed Feb 6 09:04:16 2013 +0100
docs: Add missing ")".
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Karolin Seeger <kseeger at samba.org>
Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
Autobuild-Date(master): Wed Feb 6 10:47:11 CET 2013 on sn-devel-104
commit 6c2d6ada42779b1c7015ddf3cf0dc420c4558be1
Author: Christian Ambach <ambi at samba.org>
Date: Tue Jan 29 17:19:17 2013 +0100
s3:auth small optimization in create_token_from_sid
save some calls to lp_idmap_default_range(), calling it
once is enough
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Feb 5 19:14:25 CET 2013 on sn-devel-104
commit deea99ac36a431befae3af39b7e160ce2d7ba5dc
Author: Michael Adam <obnox at samba.org>
Date: Wed Jan 30 15:50:52 2013 +0100
s3:net: reduce indentation in net idmap delete for symmetry and consistency
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 50e3592ace69a919b3196420e56f09ce435302ea
Author: Michael Adam <obnox at samba.org>
Date: Wed Jan 30 15:46:47 2013 +0100
s3:net: introduce a talloc stackframe for net idmap delete
this simplifies the freeing at the end
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 8473764234bfec2f21b87ec69c213af4365749b4
Author: Christian Ambach <ambi at samba.org>
Date: Fri Dec 7 13:43:57 2012 +0100
s3:net_idmap_delete do not lock two records at the same time
the lock order check will prohibit this and as we are running inside
a transaction there is no need to lock the records before deleting them
Pair-Programmed-With: Michael Adam <obnox at samba.org>
Signed-off-by: Christian Ambach <ambi at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit 9aa79c11f07624d10f49a6840e93e84739997ffe
Author: Michael Adam <obnox at samba.org>
Date: Tue Jan 29 13:34:26 2013 +0100
s3:net idmap: use lp_idmap_default_backend() now that we have it.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit c37a4939026622e3751e9188a3079def89171153
Author: Michael Adam <obnox at samba.org>
Date: Tue Jan 29 13:26:11 2013 +0100
s3:param: add new lp_idmap_default_backend()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 321401e7d1c812d70aa44350de0386a12d9c25f4
Author: Michael Adam <obnox at samba.org>
Date: Tue Jan 29 13:24:20 2013 +0100
s3:param: introduce new lp_idmap_backend() that takes the domain
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 4198e800d809cd0b7be5a0214a22b9a31b906cc4
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 28 15:41:13 2013 +0100
s3:param: add a comment
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 085b9767a6886aa04b8cfbee8077b411e466bfec
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 28 14:35:53 2013 +0100
s3:param: remove unused function lp_idmap_backend()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit cef05fbe8dc210ba257d2d018878d0b351009c02
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 28 14:29:21 2013 +0100
s3:net idmap: remove call to lp_idmap_backend() - this is useless.
The variable behind lp_idmap_backend() is never set.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 600ba80246aaa6cb9499a49f48e92a2657fdc918
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 28 14:21:44 2013 +0100
s3:param: remove unused functions lp_idmap_uid() and lp_idmap_gid()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 4e52fa7b7346c3afdaeb87c2af69ee71cb3cd1fb
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 28 16:45:30 2013 +0100
s3:auth: use new lp_idmap_default_range() instead of lp_idmap_gid() in create_token_from_sid()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 58b302d76a83880744d637f95b4aa7f80c040ea8
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 28 16:35:50 2013 +0100
s3:param: add utility function lp_idmap_default_range()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 1342bdd55c9759bc23f93298b34ed8d587816e6b
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 28 16:31:23 2013 +0100
s3:param: add a utility function lp_idmap_range() to get the configured range for a given domain.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit e7b39fba5e46f01e43250a758c69e3067400a0d3
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 28 14:18:48 2013 +0100
s3:param: remove an old comment (that is not up-to date any more)
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 72cd5d5ff664dc46afb3dd6a5ea45a28ef7b8591
Author: Volker Lendecke <vl at samba.org>
Date: Thu Dec 20 16:36:02 2012 +0100
tdb: Remove "header" from tdb_context
header.hash_size was the only thing we ever referenced outside of
tdb_open_ex and its direct callees. So this shrinks the tdb_context by
164 bytes.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Feb 5 13:18:28 CET 2013 on sn-devel-104
commit 71247ec4bdefb3a1b16619f7ea7404bcbafb5b60
Author: Volker Lendecke <vl at samba.org>
Date: Thu Dec 20 16:14:23 2012 +0100
tdb: Pass argument "header" to check_header_hash
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 1436107b0769c88e7eb50057b5f05ad5b8573990
Author: Volker Lendecke <vl at samba.org>
Date: Thu Dec 20 16:14:23 2012 +0100
tdb: Pass argument "header" to tdb_new_database
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit dc6c40b193e125e8810cf95129fc99f7d4f6db27
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 4 11:41:39 2013 +0100
samba-tool/domain provision: add support for utf-8 passwords for --adminpass
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Mon Feb 4 18:54:32 CET 2013 on sn-devel-104
commit 2e7bc87fa54148655ce13a59bd3274fb6285a579
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 4 13:35:48 2013 +0100
samba-tool/user setpassword: fix help message
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit d60be8167b7264dadae7d4735ee5977233d4cea9
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 4 11:41:39 2013 +0100
s4:scripting/python: add support for utf-8 passwords from the command line
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit ff65500f2b4f00dad25e342b51373f700d888c6b
Author: Michael Adam <obnox at samba.org>
Date: Mon Feb 4 13:10:34 2013 +0100
s3:dbrwap_ctdb: ZERO_STRUCT(rec) just to be sure in traverse_persistent_callback_read()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 394985454970e1eeb9b871bb359fa9f5edc9747b
Author: Michael Adam <obnox at samba.org>
Date: Mon Feb 4 13:09:46 2013 +0100
s3:dbwrap_ctdb: ZERO_STRUCT(rec) just to be sure in traverse_read_callback()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit a09f3a35519d5be2a7d37dc2a283f84f6eb4e8cc
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Feb 1 02:48:00 2013 -0500
s3:dbwrap_ctdb: add "db_context" to "db_record"
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 25bdab9c6140a04dfb33e5b4118f45e8d8489d86
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Feb 1 03:14:16 2013 -0500
s3:dbwrap_ctdb: setup result->name in db_open_ctdb()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 29aeaab1d9bf2441f4a3a9f4a8554fa9af2bd5c2
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Feb 1 03:13:35 2013 -0500
lib/dbwrap: talloc_strdup() name in db_open_file()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 65f2bba559a33edb3c352d552aebb259e5e008eb
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 4 08:45:48 2013 +0100
lib/util: improve check_password_quality() to handle utf8
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e5ca813ffb4398faeefc96c224d3b2677e576c7a
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 4 09:19:54 2013 +0100
dsdb/util: rework samdb_check_password() to support utf8
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 54cc3b1f42eba19170e611b0ee0ea464ea4ac604
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 4 09:47:31 2013 +0100
dsdb/password_hash: rename variable 'stat' to 'vstat'
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 6eccfc74cd9a16e96a2b6214b943f5b2f9adfe65
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Feb 4 09:18:59 2013 +0100
dsdb/password_hash: make sure that io->n.cleartext_utf8.data is a null terminated string
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 9292e5b74310632e1f0b4b2b76a9ef4ccae6874e
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Feb 1 13:14:05 2013 +0100
s3: use generate_random_password() instead of generate_random_str()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit c5d991e5102069ec712fe609c031a10ee8b0f389
Author: David Disseldorp <ddiss at samba.org>
Date: Sun Feb 3 17:06:37 2013 +0100
Revert "selftest: skip smb2.ioctl tests on ntvfs"
This reverts commit cf27c2fbb6e7422cb962f4c63a53515321c65a70.
The following concerns were raised with regard to the relocation of
tests from selftest/knownfail to selftest/skip.
Andrew Bartlett <abartlet at samba.org> wrote:
Unless there is some entirely undesirable side-effect, this patch throws
away valuable testing, because it removes the test of the testsuite for
failure (ie, does the test work!), and it removes the documentation of
the difference between the servers (if someone did add some this to the
ntvfs server, it would never be tested).
It also removes a test that if this unimplemented functionality is
called, that we don't crash and die.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Mon Feb 4 15:57:29 CET 2013 on sn-devel-104
commit 4c1527b1ce26759dbb7470b23f9f83a391d99b30
Author: Christian Ambach <ambi at samba.org>
Date: Tue Jan 8 17:10:27 2013 +0100
s3:modules remove gpfs_getacl_alloc
last caller has gone
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon Feb 4 14:10:08 CET 2013 on sn-devel-104
commit 18bfcac810bed431d0ca33ad02508fd87df1c626
Author: Christian Ambach <ambi at samba.org>
Date: Tue Jan 8 17:10:10 2013 +0100
s3:modules use vfs_gpfs_getacl in gpfsacl_get_posix_acl
as preparation to remove gpfs_getacl_alloc()
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 5388773d4baf902d8dd70d046cacc5a15fa790d7
Author: Christian Ambach <ambi at samba.org>
Date: Tue Jan 8 17:07:09 2013 +0100
s3:modules use vfs_gpfs_getacl in gpfsacl_set_nt_acl_internal
as preparation to remove gpfs_getacl_alloc()
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 16940d8a8ecb46a6de9cf5c83da7d2f54030777b
Author: Christian Ambach <ambi at samba.org>
Date: Tue Jan 8 16:54:16 2013 +0100
s3:modules use vfs_gpfs_getacl in gpfs_get_nfs4_acl
as preparation to remove gpfs_getacl_alloc()
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 940b7ec78c50c41a399bee2775cd008618baf8f8
Author: Christian Ambach <ambi at samba.org>
Date: Fri Nov 16 22:58:06 2012 +0100
s3:torture/vfstest add memreport option
this will run a talloc_report_full on the talloc stackframe after each command
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 8e571fd385334bc12ee5c5bdfd32b31ad2c4b4b8
Author: Christian Ambach <ambi at samba.org>
Date: Thu Nov 15 15:25:52 2012 +0100
s3:torture/vfstest implement sys_acl_blob_get_fd
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit de676555ab882bd110a2649555645d58abe2bfeb
Author: Christian Ambach <ambi at samba.org>
Date: Thu Nov 15 15:19:07 2012 +0100
s3:torture/vfstest implement sys_acl_blob_get_file
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 06219913abc4f1c3912b377b4a9521a11ad45886
Author: Christian Ambach <ambi at samba.org>
Date: Tue Oct 30 13:44:40 2012 +0100
s3:vfs_gpfs use non_posix_sys_acl_blob_get_*_helper
use the helper functions to return the blob based on the
raw GPFS ACL blob (if it is a NFSv4 ACL). If not, fall back
to the POSIX ACL code
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit f1ff845720604fc32788a59ec9a1a128135efe35
Author: Christian Ambach <ambi at samba.org>
Date: Mon Nov 5 19:26:57 2012 +0100
s3:vfs_gpfs add a generic vfs_gpfs_getacl function
in contrast to gpfs_getacl_alloc which always puts the
ACL on talloc_tos(), this one allows to specify the memory
context and if the caller is interested in the raw ACL blob
or a structured version
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit d9075e19ca8c788824208ee1d77ad5861fe778ed
Author: Christian Ambach <ambi at samba.org>
Date: Tue Jan 8 15:15:02 2013 +0100
s3:modules/vfs_gpfs add GPFS_GETACL_NATIVE define
this is not in the official GPFS header file, but can be found
in the GPL'd kernel module sources
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit b4be8d5073c0476f1220569f7151f267a5c39635
Author: Christian Ambach <ambi at samba.org>
Date: Tue Oct 30 13:43:59 2012 +0100
s3:modules/non_posix_acls: only stat if we do not have it cached
most probably we already have the stat() information
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 7cd91ca0c4acdb8ae1e5d5319d9d934d74ff4c74
Author: Christian Ambach <ambi at samba.org>
Date: Tue Oct 30 10:47:22 2012 +0100
s3:autoconf add non_posix_acls to NFS4ACL_OBJ
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ea6ac284cb974b0443000aa75b36d20d0d6814d8
Author: Christian Ambach <ambi at samba.org>
Date: Tue Oct 30 10:45:23 2012 +0100
s3:autoconf introduce NFS4ACL_OBJ
use a definition instead of listing it separately
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit d7ad24a3e7e498ec1e4cff1093f85116846397f6
Author: Christian Ambach <ambi at samba.org>
Date: Tue Jan 8 17:56:50 2013 +0100
s3-waf:modules add non_posix_acls dependency to vfs_gpfs
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 2a2dbf825972bfa16ae5dbe93e458de348571684
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 24 22:39:59 2012 +1100
vfs: Add helper function for non posix ACL modules
This handles the stat, and fills in the pre-supplied blob into a
wrapper sturcture that can then be returned to vfs_acl_common for
hashing.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit e650a5fd61d7925888e3abf0a561af5a9a23f00b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 24 17:06:33 2012 +1100
idl: Provide a common wrapper for the data to hash for a non-POSIX ACL
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit a133a989c319bfba18ea8b204716d8e362e28f80
Author: Christian Ambach <ambi at samba.org>
Date: Wed Jan 30 11:00:48 2013 +0100
selftest: add a test that demonstrates how new ACL blob code helps
this test shows that a change to POSIX ACL->SD mapping behavior does not invalidate the stored SD
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit f0e49b015bfcb021aea61615185d9da57538c68d
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 24 17:03:41 2012 +1100
vfs_acl_common: Do not fetch the underlying NT ACL unless we need it
This avoids asking for the posix ACL on disk twice, and avoids running
a good deal of mapping code if it is not needed.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 4e8c8952ad8f4d1d658b947da2f1264bfeff8fdf
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jan 21 12:45:14 2013 +1100
vfs: Whitespace fix only to get_nt_acl_internal indentation
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 25526ed3f590e4fa90c237a37f08bb23f449dd8c
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 16:36:47 2012 +1100
vfs: Implement an improved vfs_acl_common that uses the hash of the system ACL
Where supported by the system ACL backend, this avoids hashing the
result of the ACL mapping, instead hashing the original ACL,
linearlised.
For maximum robustness, the hash of the NT and system ACL are stored,
along with the time and a description of the system ACL. This variety
of extra metadata may assist some future implementation in determining
which hash to validate.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 6a5f65b0e971f068ebae5b2f93a6dfccfaa93b26
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jan 21 12:43:00 2013 +1100
vfs: Add helper function hash_blob_sha256 to vfs_acl_common.c
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 5a8e04963f611b21570b9bdfc3b74e18254df2d1
Author: Volker Lendecke <vl at samba.org>
Date: Sun Feb 3 12:30:10 2013 +0100
Fix typo in warning message
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-By: Ira Cooper <ira at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Mon Feb 4 11:48:25 CET 2013 on sn-devel-104
commit 570a4b3e22dbddb3f1dc095cc1fe1b6a1f3af069
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Feb 1 15:50:08 2013 +0100
tevent_poll: add poll_event_loop_wait()
We can't use tevent_common_loop_wait() because new fd events
will be added to the poll_ev->fresh list instead of
ev->fd_events.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sun Feb 3 06:40:09 CET 2013 on sn-devel-104
commit e79ad7cff196fd6d9250420d83551fd3ac665b19
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Feb 1 15:27:10 2013 +0100
tevent_poll: fix the usage of tevent_re_initialise()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit dd9f0c9b6d4141bc3f40cec1567bfb28b572207c
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Feb 1 15:56:34 2013 +0100
tevent_poll: call tevent_common_fd_destructor() from poll_fresh_fde_destructor()
We need to trigger the fde->close_fn().
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 1cfc76f72ae454b13dbaeca22df06cb6f78f078f
Author: Volker Lendecke <vl at samba.org>
Date: Thu Jan 31 16:34:41 2013 +0100
tevent_poll: Avoid a crash in poll_event_set_fd_flags
The event context might have been freed before the fde
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 611fcca641a22a2a23b26752105af99cf338d6a1
Author: Volker Lendecke <vl at samba.org>
Date: Thu Jan 31 16:34:41 2013 +0100
tevent_poll: Avoid a crash in poll_fresh_fde_destructor
The event context might have been freed before the fde
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0cf62a92f26ef9c7d3c5a5d256adc72d66335319
Author: Volker Lendecke <vl at samba.org>
Date: Thu Jan 31 16:31:45 2013 +0100
tevent_poll: NULL out fde->event_ctx for "fresh" poll fdes
This is done in tevent_common_context_destructor for the non-fresh
fdes already
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3ce58cbcf3d9653ee6b0002f52a29ab922beab4e
Author: Volker Lendecke <vl at samba.org>
Date: Thu Jan 31 16:28:08 2013 +0100
tevent_poll: Use the poll_event_context_destructor always
This is in preparation for the next patch to NULL out the event_ctx
pointers in the poll_ev->fresh list
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e3309852f717e716181df584716aa17945326565
Author: Volker Lendecke <vl at samba.org>
Date: Thu Jan 31 16:25:23 2013 +0100
tevent_poll: Re-order routines
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d944e2cae15cf1fc2e7601fecd213dec17e5132a
Author: Volker Lendecke <vl at samba.org>
Date: Thu Jan 31 14:33:15 2013 +0100
tevent_poll: Fix a crash in the poll backend
If tevent_add_fd is immediately followed by tevent_fd_set_flags, the poll
backend crashes. This was introduced when the poll backend was prepared
for the multi-threaded python extension.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 499008021051e5b01e4c1c151403b18a9dcbcf24
Author: Günther Deschner <gd at samba.org>
Date: Fri Feb 1 17:41:00 2013 +0100
krb5pac: make sure to correctly store the highest relative pointer offset.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Günther Deschner <gd at samba.org>
Autobuild-Date(master): Fri Feb 1 21:19:28 CET 2013 on sn-devel-104
commit 87157f04d1ffcee9f12a9529869a3338af82d99a
Author: Günther Deschner <gd at samba.org>
Date: Thu Dec 13 12:31:54 2012 +0100
s3-net: mention optional impersonation principal for PAC retrieval.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 3c31fe7600145662f8bdba98c8f13cbaac58685e
Author: Günther Deschner <gd at samba.org>
Date: Fri Feb 1 17:45:02 2013 +0100
s4-torture: make sure to deal with the highest relative pointer offset correctly.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 732e8ab64d3c082dd142e4cbf07ebaec54549216
Author: Günther Deschner <gd at samba.org>
Date: Fri Feb 1 17:44:16 2013 +0100
ndrdump: make sure to deal with the highest relative pointer offset correctly.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 009cf6e9ceaef91805a8a7573090d051f8f74a92
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Jan 31 13:39:42 2013 +0100
s3:auth: wbcAuthenticateEx gives unix times (bug #9625)
We also need to convert last_logon, last_logoff and acct_expiry
from unix time to nt time.
Otherwise a windows member server will reject clients
using CAP_DYNAMIC_REAUTH or smb2) with STATUS_NETWORK_SESSION_EXPIRED,
if the logoff and kickoff time is expired.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Fri Feb 1 18:42:42 CET 2013 on sn-devel-104
commit cf27c2fbb6e7422cb962f4c63a53515321c65a70
Author: David Disseldorp <ddiss at samba.org>
Date: Thu Jan 31 17:48:25 2013 +0100
selftest: skip smb2.ioctl tests on ntvfs
Rather than filtering via knownfail.
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Thu Jan 31 19:39:25 CET 2013 on sn-devel-104
commit dc929ca57fb1b23d74d898cfb76737601656961f
Author: Volker Lendecke <vl at samba.org>
Date: Thu Jan 31 15:46:43 2013 +0100
tevent: Fix a comment typo
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ira Cooper <ira at samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
Autobuild-User(master): Richard Sharpe <sharpe at samba.org>
Autobuild-Date(master): Thu Jan 31 17:52:39 CET 2013 on sn-devel-104
commit 48d954b90e6aa14721d236180df959a038416672
Author: Jeremy Allison <jra at samba.org>
Date: Mon Jan 28 16:52:11 2013 -0800
Fix the compound tests to correctly pass against Windows when run with --signing=required.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.org>
Autobuild-User(master): Richard Sharpe <sharpe at samba.org>
Autobuild-Date(master): Thu Jan 31 03:53:55 CET 2013 on sn-devel-104
commit 1624d83fdeb675ee4032f5d3cabcf86d5b05a3cb
Author: Jeremy Allison <jra at samba.org>
Date: Mon Jan 28 16:51:25 2013 -0800
Add new function smbXcli_session_copy(), to be used when creating compound SMB2 requests.
Copies the signing state needed to make client compound requests work
on signed connections.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
commit 7b0b1d6d48d31a729f0ad176a8b53f8c3a8d2d16
Author: Volker Lendecke <vl at samba.org>
Date: Wed Jan 30 15:53:27 2013 +0100
smbd: Fix a typo
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
Autobuild-User(master): Christian Ambach <ambi at samba.org>
Autobuild-Date(master): Wed Jan 30 18:21:19 CET 2013 on sn-devel-104
commit fa064140edf13c16085acf061d781fa06abfce3b
Author: Volker Lendecke <vl at samba.org>
Date: Tue Jan 15 13:17:00 2013 +0100
smbd: Fix a typo
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 394622ef8c916cf361f8596dba4664dc8d6bfc9e
Author: Michael Adam <obnox at samba.org>
Date: Tue Jan 22 18:08:25 2013 +0100
s3:winbindd: change getpwsid() to return a passwd struct for a group sid id-mapped with ID_TYPE_BOTH
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Jan 29 23:46:19 CET 2013 on sn-devel-104
commit b7095e9818bba8c43065cc1b1f29551203dc098b
Author: Michael Adam <obnox at samba.org>
Date: Tue Jan 22 17:39:44 2013 +0100
s3:winbindd: check the correct variable for talloc success in rpc_query_user()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 40e3df7c37a15b28f170699ff9b8102416a9107f
Author: Michael Adam <obnox at samba.org>
Date: Fri Dec 7 00:55:18 2012 +0100
s3:winbindd:getgrnam: also produce a group struct for a user with ID_TYPE_BOTH
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit d2360fe56c860fa20051f6373eb2fcc3e4def6b6
Author: Michael Adam <obnox at samba.org>
Date: Thu Dec 6 22:02:32 2012 +0100
s3:winbindd: create group structs for gids that are coming from a user sid id-mapped with ID_TYPE_BOTH
This "fake" group contains exctly one member, namely the user that the sid is
actually belonging to.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 729e2c36301620ccc61b1d97205fb3f482efbe15
Author: Michael Adam <obnox at samba.org>
Date: Thu Dec 6 18:06:49 2012 +0100
s3:winbindd: factor add_wbint_Principal_to_dict() out of wb_group_members_done()
for later reuse
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 3680cc4a11ef5476457b580f8422d0ab82451173
Author: Michael Adam <obnox at samba.org>
Date: Fri Dec 7 16:13:19 2012 +0100
s3:winbindd: fix a cut'n'paste comment typo in wb_fill_pwent
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit c0f47d43ecf8b603dc7a05822933c5a9a1d23c7c
Author: Michael Adam <obnox at samba.org>
Date: Fri Dec 7 01:12:11 2012 +0100
s3:winbindd: rename winbindd_getgrnam_lookupsid_done to winbindd_getgrnam_lookupname_done
That's what it is.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit bab61a21595070d29fc5822d1ec6747db641d26a
Author: Christian Ambach <ambi at samba.org>
Date: Fri Dec 7 12:33:38 2012 +0100
s3:utils/net remove aclmapset command
this was made for the nfs4:sidmap code that has been removed, so
this subcommand can also go away
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Jan 29 15:37:18 CET 2013 on sn-devel-104
commit 3a4ed4803f2b911e58420531548cb5658cb9fb74
Author: Christian Ambach <ambi at samba.org>
Date: Thu Nov 29 21:40:15 2012 +0100
s3:net_idmap_dump support dumping autorid backend
- remember the type of idmapping database (tdb or autorid)
this allows to make rest of the code (e.g. dump) know which database-style it will encounter
- add a seperate dump function for autorid
- default to TDB if db-file is given on the command-line
Pair-Programmed-With: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
Signed-off-by: Christian Ambach <ambi at samba.org>
Signed-off-by: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 580008f307e0883a11be6b1ece8342642760f41e
Author: Christian Ambach <ambi at samba.org>
Date: Tue Dec 4 15:11:50 2012 +0100
s3:net_idmap_dump add missing braces
see README.Coding
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e0bd87ecc41dc4f61f7f545cd485f371eb75e8b0
Author: Christian Ambach <ambi at samba.org>
Date: Mon Dec 3 14:15:40 2012 +0100
s3:net_idmap_dump remove obsolete support for tdb:idmap2.tdb parameter
this one got removed from idmap_tdb2 a while ago
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 65268f482d9103aff8a6e239c9b8cc53d07f760a
Author: Christian Ambach <ambi at samba.org>
Date: Thu Nov 29 21:39:54 2012 +0100
s3:net_idmap_dump deal with idmap config * : backend config style
this is the new config style since Samba 3.6 and should be detected by net idmap dump
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e104e5a8192e9d9a2637035bec343de3c35ca21e
Author: Jeremy Allison <jra at samba.org>
Date: Thu Jan 24 16:20:14 2013 -0800
Regression test for bug #9571 - Unlink after open causes smbd to panic
Replicates the protocol activity that triggers the crash.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Mon Jan 28 15:33:17 CET 2013 on sn-devel-104
commit 578909ae19d7ec9dacb960626bd1985a2915365b
Author: Pavel Shilovsky <piastry at etersoft.ru>
Date: Wed Jan 16 15:02:26 2013 +0400
Fix bug #9571 - Unlink after open causes smbd to panic.
s3:smbd: fix wrong lock order in posix unlink
Signed-off-by: Pavel Shilovsky <piastry at etersoft.ru>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 34854ae58fb0fdeec7f27d1d6264b2035778ea6b
Author: Jeremy Allison <jra at samba.org>
Date: Fri Jan 25 10:21:48 2013 -0800
Fix bug #9588 - ACLs are not inherited to directories for DFS shares.
We can return with NT_STATUS_OK in an error code path. This
has a really strange effect in that it prevents the ACL editor
in Windows XP from recursively changing ACE entries on sub-directories
after a change in a DFS-root share (we end up returning a path
that looks like: \\IPV4\share1\xptest/testdir with a mixture
of Windows and POSIX pathname separators).
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Mon Jan 28 13:48:13 CET 2013 on sn-devel-104
commit 155fdc405ada674146afe577aa7228f6144d34b1
Author: Volker Lendecke <vl at samba.org>
Date: Sun Jan 27 17:24:49 2013 +0100
smbcontrol: Fix undefined serverid_traverse_read warning
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Mon Jan 28 11:51:12 CET 2013 on sn-devel-104
commit dd9ed7bef4040e2f87baa3bf7133675aca995980
Author: Volker Lendecke <vl at samba.org>
Date: Sun Jan 27 17:24:31 2013 +0100
smbcontrol: Fix the build with libunwind
Reviewed-by: Andreas Schneider <asn at samba.org>
commit bb3238b46f0ffaf0bc8c0e16bdcc1cf5d2cad197
Author: Stefan Metzmacher <metze at samba.org>
Date: Sun Jan 27 11:09:39 2013 +0100
s4:service_task: add missing imessaging_cleanup() to task_server_terminate()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Sun Jan 27 15:50:30 CET 2013 on sn-devel-104
commit 431692df422c3cac71ca12b7e89296172dfcf684
Author: Stefan Metzmacher <metze at samba.org>
Date: Sun Jan 27 11:01:07 2013 +0100
s4:service_task: prevent a segfault if task->msg_ctx is not initialized yet
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 7e7cd07c405f8b66f5979047cb1a50e1e7a55edd
Author: Stefan Metzmacher <metze at samba.org>
Date: Sun Jan 27 12:15:50 2013 +0100
selftest: rename 'promoted_vampire_dc' to 'promoted_dc'
Unix domain socket are limited to 104 characters on Linux.
Using something like this fails as it uses more than 104 characters:
'/memdisk/autobuild/flakey/b232141/samba/bin/ab/promoted_vampire_dc/private/smbd.tmp/msg/msg.482379.2147483647'
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 0f8ef5a2c83e0496ef79c3d6f8b1188fdd1943a0
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Jan 22 23:39:15 2013 +1100
selftest: Add test of upgradeprovision using the old alpha13 tree
This ensures that upgradeprovision works as expected on a known good old database.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sun Jan 27 11:55:54 CET 2013 on sn-devel-104
commit 58d6d884cf8a8de5a1fa2dfd4a0cbacdff0d2483
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Jan 25 09:36:47 2013 +0100
samba_upgradeprovision: detect dns_backend for the reference provision
If we have a DomainDnsZone partition, we use BIND9_DLZ as backend
and fix errors in the ForestDnsZone and DomainDnsZone partitions.
Note: this should work fine also for SAMBA_INTERNAL.
If the current setup doesn't use dns specific partitions (e.g. alpha13 setups)
we pass dns_backend=BIND9_FLATFILE.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit b855df254de40d9de0b7f9042564f6d521ab1c5d
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Jan 25 09:36:47 2013 +0100
provision: setup names.dns_backend
If we have a DomainDnsZone partition:
- we use BIND9_DLZ as backend if a dns-<netbiosname> account is available
- otherwise, we use SAMBA_INTERNAL
else:
- we use BIND9_FLATFILE if a dns or dns-<netbiosname> account is available
- otherwise, we use NONE
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 4752731c2eb4abeb0b5da3e33aa3096786301a19
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Dec 13 12:56:37 2012 +0100
samba_upgradeprovision: fix the nTSecurityDescriptor on more containers (bug #9481)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 5cf98823cc804906833f7ea763f99de0147b0fee
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 23 16:27:17 2013 +0100
provision: fix nTSecurityDescriptor of containers in the DnsZones (bug #9481)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit a477649e568577875be577c70a6b25cbeea6985a
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 23 16:27:17 2013 +0100
provision: fix nTSecurityDescriptor attributes of CN=*,${CONFIGDN} (bug #9481)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 1de5c2f78544385d2fe270d766fc1ca6726d71fb
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 23 16:27:17 2013 +0100
provision: fix nTSecurityDescriptor of CN={LostAndFound,System},${DOMAINDN} (bug #9481)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 4775f9ab345072e63d671e83ae2c054fd2f80c3b
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 23 15:45:33 2013 +0100
provision: setup names.name_map['DnsAdmins']
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit e0712a70f5a437eb60df3cebedbbe1c6c08bd6ae
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 23 15:43:54 2013 +0100
provision: introduce names.name_map = {}
This will be used to translated names in SDDL values,
which are not wellknown, e.g. 'DnsAdmins'.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ebb73f1c5d577c1d32c5c0519dcf3fb25c578c45
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 23 15:55:31 2013 +0100
provision: add get_dns_{forest,domain}_microsoft_dns_descriptor()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit d00fb6aff2f54b470304d3d77a53328bcbb16851
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 23 15:39:07 2013 +0100
provision: add get_config_ntds_quotas_descriptor()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 1207cbd123375f0ff1bfc51403af5d611a621091
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 23 10:51:10 2013 +0100
provision: add get_{config,domain}_delete_protected*_descriptor()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 8880c2d0d356e7208ca859e17caf208952af0e17
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 23 15:53:00 2013 +0100
schema.py: add optional name_map={} to get_schema_descriptor()
This is not used, but makes the prototype compatible with the
other get_*_descriptor() functions.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 27a99c6236ab270a592b4e3242f92f8923a3d7e4
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 23 15:51:37 2013 +0100
provision: add optional name_map={} argument to get_*_descriptor()
This will allow subsitute non-wellkown names in the SDDL,
e.g. 'DnsAdmins'.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit d4653e99b8be35b6d86605a1c4c624d5db2294b1
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 23 09:05:36 2013 +0100
provision: import/export get_dns_partition_descriptor()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit b54b58e75d3c1a3080e81c61156b75ef1d241b71
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 23 08:56:00 2013 +0100
provision: setup names.dns{forest,domain}dn
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit f51248339ae7ba9843e477493a69b0c4f647935a
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 23 15:24:11 2013 +0100
samba_upgradeprovision: fix resetting of 'nTSecurityDescriptor' on schema objects
Without this schema_data_modify() will reject updates to schema objects
by default.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit b5cafa3b84e6cca5ca83fbcc0963def7d0c286d5
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 23 15:23:13 2013 +0100
samba_upgradeprovision: don't reset 'whenCreated' when resetting 'nTSecurityDescriptor'
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ec466aa35656764c8a8af724cda692f2302a0c04
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Jan 19 09:41:00 2013 +0100
dbckecker: fix nTSecurityDescriptor values from before 4.0.0rc6 (bug #9481)
They inherited effective ACE for the wrong object classes.
For SACL ACEs the problem was also present in 4.0.0.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 38655a89cf902d0ea6657415e2f546c7622e279d
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Jan 24 22:59:26 2013 +0100
dsdb-descriptor: get_default_group() should always return the DAG sid (bug #9481)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit cd5cb843b4d698ed2fedf635a020ff978ae40558
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Jan 24 13:07:32 2013 +0100
tests/sec_descriptor: the default owner behavior depends on domainControllerFunctionality (bug #9481)
Not on the domainFunctionality.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 2413962d53c7923a453fc7579b24b90bc23173df
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Jan 22 15:38:07 2013 +0100
libcli/security: calculate INHERIT_ONLY correcty for AUDIT and ALARM aces (bug #9481)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit b9f1c8887ed1c8c29259021d4f2b9a549caa4061
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Jan 25 23:00:12 2013 +1100
s4-process_single: Use pid,task_id as cluster_id in process_single just like process_prefork
This avoids two different process single task servers (eg the drepl
server) sharing the same server id. The task id starts at 2^31 to
avoid collision with the fd based scheme for connections.
Fix-bug: https://bugzilla.samba.org/show_bug.cgi?id=9598
Reported-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Sat Jan 26 16:13:05 CET 2013 on sn-devel-104
commit a321dd3aafa0f6ec8b39cd4fc64146dfbf24ce65
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Jan 26 09:09:23 2013 +1100
pymessaging: Pass around the server_id struct to python callbacks rather than the tuple
This is not used currently, but may avoid going to and from the python types when we do not need to.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit a3054323d3fa1dadff1675e7f8ec672a991d8e56
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Jan 26 08:58:46 2013 +1100
pymessaging: Use correct unsigned types for server ID tuple elememnts
This is needed if we start using the top bits of these values.
Andrew Bartlett
Reviewed-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 1d1ea72574cfa22ee6207d0e9787d0271db3b5c2
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Jan 26 09:35:21 2013 +1100
ldb: Ensure to decrement the transaction_active whenever we delete a transaction
This is in the error path for prepare_commit, which rarely fails, but
when it does we need to ensure that when a new transaction is opened,
that it really starts a new transaction.
We bump the version to recognise critical fix for the AD DC
Without this fix, a single invalid inbound replicated link disables
all subsequent replication as we operate without a transaction (which
is refused by ldb_tdb).
Andrew Bartlett
Reviewed-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 1ea6fabcde6cbd57aed06926193ac68f5887e96b
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Jan 24 14:21:51 2013 +0100
ldb: fix a warning by converting from TDB_DATA to struct ldb_val
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit d79485a566e3c59ce53c3ee205aa6c78f149f5d8
Author: Jeremy Allison <jra at samba.org>
Date: Thu Jan 24 12:33:53 2013 -0800
Regression test for bug #9587 - archive flag is always set on directories.
Ensure we get the correct attributes on files
and directories after a rename.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Fri Jan 25 13:42:40 CET 2013 on sn-devel-104
commit 3d46a077dd0999cc0c6032379147811c8bb660fb
Author: Jeremy Allison <jra at samba.org>
Date: Thu Jan 24 11:02:30 2013 -0800
Fix bug #9587 - archive flag is always set on directories.
Creating a directory to a Samba share sets the attributes to 'D' only
(correct) - only when creating a new file should the 'A' attribute
be set.
However, doing a rename of that directory sets the 'A' attribute in error.
This should only be done on a file rename. smbclient regression test to follow.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit c5db4eb9104f1a95220273ee2b0290d157053922
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Jan 25 13:15:51 2013 +1100
bug9598: s4-process_single: Use pid,fd as cluster_id in process_single just like process_prefork
This avoids two different process single servers (say LDAP and the RPC server) sharing the same
server id.
Fix-bug: https://bugzilla.samba.org/show_bug.cgi?id=9598
Reported-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Matthieu Patou <mat at matws.net>
Signed-off-by: Andrew Bartlett <abartlett at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Fri Jan 25 12:00:04 CET 2013 on sn-devel-104
commit da35cd7bd230b2299f9566f4775bd98fda3024f8
Author: Volker Lendecke <vl at samba.org>
Date: Thu Jan 24 16:39:05 2013 +0100
Avoid a very small memleak on talloc_tos()
"fname" did leak on talloc_tos(). Not really a bad memleak, but as I
just came across it I thought I might just fix it
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Jan 25 00:54:01 CET 2013 on sn-devel-104
commit 996a10cdea4a1ea23bc86c8bc57c4ca02e285b17
Author: Jeremy Allison <jra at samba.org>
Date: Wed Jan 23 09:57:50 2013 -0800
Fix bug #9572 - File corruption during SMB1 read by Mac OSX 10.8.2 clients.
Accept a large read if we told the client we have UNIX extensions
and the client sent a non-zero upper 16-bit size.
Do the non-zero upper 16-bit size check first to save a function
call in what is a hot path.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Jan 24 21:01:51 CET 2013 on sn-devel-104
commit 033197958ec97140d5632ab875f24350257963dd
Author: Jeremy Allison <jra at samba.org>
Date: Tue Jan 22 12:38:28 2013 -0800
Revert "s3:smbd: SMB ReadX with size > 0xffff should only possible for samba clients."
Part of fix for bug #9572 - File corruption during SMB1 read by Mac OSX 10.8.2 clients
This reverts commit f8c26c16b82989e002b839fc9eba6386fc036f6a.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 000e6ba14ab1c63278c2a9b10fe271c08f578ccf
Author: Günther Deschner <gd at samba.org>
Date: Wed Jan 23 10:33:21 2013 +0100
s4-torture: add some basic tests for PlayGDIScriptOnPrinterIC.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Thu Jan 24 19:20:52 CET 2013 on sn-devel-104
commit 21aa7fe633d2360d529e93b5599988eabff1d7d1
Author: Günther Deschner <gd at samba.org>
Date: Wed Jan 23 09:31:01 2013 +0100
s3-rpcclient: add cmd_spoolss_play_gdi_script_on_printer_ic.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 0364658632f8a68537bd3e7c99ecca4c5c968455
Author: Günther Deschner <gd at samba.org>
Date: Thu Jan 24 17:10:17 2013 +0100
spoolss: add UNIVERSAL_FONT_ID_ctr for debugging.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit d99b1ee79c6c772e2dfe7152edc7343c806dab6e
Author: Günther Deschner <gd at samba.org>
Date: Wed Jan 23 11:11:26 2013 +0100
spoolss: Add UNIVERSAL_FONT_ID.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit a270e20b198696c754182fa0c58fd3c4d338e955
Author: Günther Deschner <gd at samba.org>
Date: Wed Jan 23 09:01:05 2013 +0100
spoolss: fill in spoolss_PlayGDIScriptOnPrinterIC IDL.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit aab232cb2ea91b3a6c636f4ea47ca9f872848f3f
Author: Günther Deschner <gd at samba.org>
Date: Tue Jan 22 15:57:22 2013 +0100
s3-rpcclient: decode OsVersion{Ex} binary blobs when displaying printerdata.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit ce1a9ae8abc3e4d49374b5b02c6ec55d2df63f72
Author: Günther Deschner <gd at samba.org>
Date: Sat Jan 19 01:37:29 2013 +0100
s3-spoolss: Make it easier to manipulate the returned OSVersion at runtime.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 11fba102082239c5d70b6314b19dab72b49478ed
Author: Günther Deschner <gd at samba.org>
Date: Fri Jan 18 22:22:13 2013 +0100
spoolss: make spoolss deal with ndr64 StartDocPrinter by using proper container object.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 6bcd3dda2825a8791e7284b3229aa518416e8544
Author: Günther Deschner <gd at samba.org>
Date: Fri Jan 18 13:43:05 2013 +0100
spoolss: add more spoolss_DriverAttributes values.
The level5 driver does return only one of these flags with a different value,
will get fixed later.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 875a1721ae014cbb580d9596344675e890cf9964
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Jan 24 11:52:37 2013 +0100
docs: ldbsearch.1.xml: Correct meta data.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Karolin
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Thu Jan 24 16:09:37 CET 2013 on sn-devel-104
commit 99e2a63a0c64de4c3c26e66984a6c542052e97ba
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Jan 24 11:52:15 2013 +0100
docs: ldbrename.1.xml: Correct meta data.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Karolin
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 25cc400c64958e2e2e2e812a0d34064f1957d0c4
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Jan 24 11:51:49 2013 +0100
docs: ldbmodify.1.xml: Correct meta data.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Karolin
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit f585052d888a3bb4f9c81d9a9512eca7f7867c98
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Jan 24 11:51:28 2013 +0100
docs: ldbedit.1.xml: Correct meta data.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Karolin
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 918057bd11e9ed1457cf0119f4c0c1f9c418c566
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Jan 24 11:50:55 2013 +0100
docs: ldbdel.1.xml: Correct meta data.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Karolin
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 1d4346d4b7c7afc4f578afb3b8d0e08e36812b39
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Jan 24 11:50:26 2013 +0100
docs: ldbadd.1.xml: Correct meta data.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Karolin
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 7d56b9401129c18a948bbd0bb4fea547d4b3a7c4
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Jan 24 11:50:00 2013 +0100
docs: ldb.3.xml: Correct meta data.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Karolin
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit df004b5014b92b987f907047d2ca9f567e3d0ac1
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Jan 22 14:45:14 2013 +1100
gensec: Allow login without a PAC by default (bug #9581)
The sense of this test was inverted. We only want to take the ACCESS_DENIED error
if gensec:require_pac=true.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 497febfe36354c4aff3696cd32c6c7e8fee55af8
Author: Jeremy Allison <jra at samba.org>
Date: Wed Jan 23 14:39:09 2013 -0800
Fix bug #9586 - smbd[29175]: disk_free: sys_popen() failed" message logged in /var/log/message many times.
Ensure when reading lines from an interruptible
pipe source we ignore EINTR.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Thu Jan 24 10:45:48 CET 2013 on sn-devel-104
commit 1915b17d09485b9491caf3410b0c5186f6c2c616
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Jan 17 17:19:03 2013 +0100
dsdb-acl: remove unused variable
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Wed Jan 23 20:04:09 CET 2013 on sn-devel-104
commit f9868b7ffd44a76155dbac1dc4b12f2d89af5380
Author: Volker Lendecke <vl at samba.org>
Date: Tue Jan 22 13:14:41 2013 +0100
smbd: Fix a NULL vs false return error
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 3d1abb93280fbfe01ed899fa4685290ce3960ed8
Author: Andreas Schneider <asn at samba.org>
Date: Tue Jan 22 09:55:02 2013 +0100
waf: Fix pdb_ldap which cannot be built as a module.
The module has two init functions, pdb_ldap_init() and
pdb_ldapsam_init(). As a shared module only one can be found until we
create a symlink.
Reviewed-by: Günther Deschner <gd at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Wed Jan 23 10:51:59 CET 2013 on sn-devel-104
commit 38a52f71255541fd5d57e6e4fbc1acbe780a10cb
Author: Andreas Schneider <asn at samba.org>
Date: Tue Jan 22 10:04:07 2013 +0100
ldap: Remove obsolete convertSambaAccount script.
We removed ldapsam_compat support which used sambaAccount already some
time ago. See commit 02c239c6d35f47f13143c66baffbd303373b8028.
Reviewed-by: Günther Deschner <gd at samba.org>
commit 988350ccefbe8f22eb1814e071386ef2dfe6d6dd
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jan 21 10:45:10 2013 +1100
libcli/auth: fix void function cannot return value error
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Jan 22 22:32:31 CET 2013 on sn-devel-104
commit d56b4560b585c613b65b05a9224c9e11f5038318
Author: Günther Deschner <gd at samba.org>
Date: Tue Jan 22 11:54:19 2013 +0100
s3-winbind: fix the build of idmap_ldap.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Günther Deschner <gd at samba.org>
Autobuild-Date(master): Tue Jan 22 14:43:40 CET 2013 on sn-devel-104
commit 9aca52877a3f6f59887098ebb8e664922c8c7aad
Author: Matthieu Patou <mat at matws.net>
Date: Thu Jan 3 14:33:45 2013 -0800
Tests: Fix the display of test vars in screen --testenv
The form bash -c echo "important stuff blabla bla" && LD_LIBARY_PATH bash
is not working in screen when it's working in xterm and the in_screen
script already wrap all the command within a bash shell so there is no
need to re-force bash as the echo will execute in a bash shell
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue Jan 22 13:03:52 CET 2013 on sn-devel-104
commit b1e231384a9245a191ef5e004544d7cafe17e036
Author: Matthieu Patou <mat at matws.net>
Date: Sun Oct 14 01:01:08 2012 -0700
libcli-acl: add documentation
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 65396adaad18821568f727a223c38c36a2b16291
Author: Matthieu Patou <mat at matws.net>
Date: Sun Oct 14 01:04:51 2012 -0700
drsuapi: Add documentation
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit d7bbd182b33441a0a4e91c00a31de29b2b09f59a
Author: Matthieu Patou <mat at matws.net>
Date: Mon Oct 15 22:15:17 2012 -0700
drepl-notify: change misleading message
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 0a4a4ba3f6b9748e3fccb546b284de565de2c8b5
Author: Matthieu Patou <mat at matws.net>
Date: Mon Oct 29 22:12:33 2012 -0700
devel-script: add options for RODC and partial replica for replicate flags
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue Jan 22 00:12:17 CET 2013 on sn-devel-104
commit fa591a6d3cf9182b6d49621c83a6c3fbfeab1ee7
Author: Matthieu Patou <mat at matws.net>
Date: Mon Oct 29 21:43:14 2012 -0700
devel-scripts: ask with WRIT_REP by default
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 0755b835cc4e474f752de1b8cc56a9a6da14a3cd
Author: Matthieu Patou <mat at matws.net>
Date: Tue Oct 23 22:12:08 2012 -0700
devel-getncchange: try to find the dest_dsa automatically
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 7822952a11707ff8aaa415adef62082c158c2398
Author: Matthieu Patou <mat at matws.net>
Date: Sat Oct 13 15:02:57 2012 -0700
security: Add documentation
Names seems to be a bit cryptic and misleading (at least for me).
So documenting them should remove at least partially this problem.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit c0638dae6cbf8915e6a436d575562fc131ba772a
Author: Matthieu Patou <mat at matws.net>
Date: Sat Oct 13 15:28:08 2012 -0700
libcli-security: Add documentation for object_tree_modify_access
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 3b7977419726a8630de828b634d669625ee358dd
Author: Matthieu Patou <mat at matws.net>
Date: Tue Oct 23 22:09:20 2012 -0700
dbcheck: look in hasMasterNCs as well for determining the instance type of a NC
Forest of level 2000 don't hve the msDS-hasMasterNCs parameter
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit abc0030f780b775bf7656b572ee754ebd8079b5d
Author: Matthieu Patou <mat at matws.net>
Date: Sat Dec 29 16:43:44 2012 -0800
dsdb: Fix warning about unused var
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Mon Jan 21 17:51:16 CET 2013 on sn-devel-104
commit c52408f461fb3515cde17eebb458b566fd0a049c
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Jan 2 09:27:51 2013 +1100
dsdb: Explain ordering constraints on the ACL module as well.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 8f078cdf247476fad511bb6d7e00c8654fd26e85
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Dec 29 15:13:54 2012 +1100
dsdb: Ensure "authenticated users" is processed for group memberships
This change moves the addition of "Authenticated Users" from the very end of the
token processing to the start. The reason is that we need to see if
"Authenticated Users" is a member of other builtin groups, just as we
would for any other SID. This picks up the "Pre-Windows 2000 Compatible Access"
group, which is in turn often used in ACLs on LDAP objects.
Without this change, the eventual token does not contain S-1-5-32-554
and users other than "Administrator" are unable to read uidNumber
(in particular).
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit d36c03056fb85dfedbafd3a59497e35db63ade17
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Jan 3 21:30:12 2013 +1100
libcli/security: remove useless if (root->num_of_children > 0) statements
The for loop does this implicitly when comparing for (i = 0; i < root->num_of_children; i++)
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 853ecd418afe15973d3e8844ad0e01d3d54536d5
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Jan 15 19:03:00 2013 +0100
libcli/security: add init_mask to existing children in insert_in_object_tree
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 5b4e3de2bb25eeb85d72a886386c853cea3e9468
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Jan 3 20:40:32 2013 +1100
libcli/security: handle node initialisation in one spot in insert_in_object_tree()
This removes special-case for initalising the children array in
insert_in_object_tree(). talloc_realloc() handles the intial allocate
case perfectly well, so there is no need to have this duplicated.
This also restores having just one place were the rest of the elements
are intialised, to ensure uniform behaviour.
To do this, we have to rework insert_in_object_tree to have only one
output variable, both because having both root and new_node as output
variables was too confusing, and because otherwise the two pointers
were being allowed to point at the same memory.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit a359aef0837781c42bf9dbcdd069796c72cc94c7
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 16 09:49:20 2013 +0100
libcli/security: avoid usage of dom_sid_parse_talloc() in sec_access_check_ds()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit a3fffde368fa0c6594f7fd5309e0b20d3fa7c68e
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 16 10:05:56 2013 +0100
libcli/security: simplify get_ace_object_type()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit b0f731fc3b96edf91216829bd0dc63bb4269f458
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 16 09:46:48 2013 +0100
libcli/security: fix formating in access_check.c
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 10a90ce8422ac4ff4461b13a3dd03bbcd9bd2258
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 16 09:43:44 2013 +0100
libcli/security: fix whitespaces in access_check.c
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 0ebb93708eb377e29eaaf4400c65399d18c229b6
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Jan 17 16:22:09 2013 +0100
dsdb-acl: the SEC_ADS_DELETE_CHILD checks need objectclass->schemaIDGUID
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 8f8d97f9fe05b2de1403676a148ab7b90a83812b
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Jan 17 16:21:10 2013 +0100
dsdb-acl: make use of acl_check_access_on_objectclass() for the object in acl_delete()
We should only use dsdb_module_check_access_on_dn() on the parent.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 8aa855573067418c84f71aa3a20e5f472343851d
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 16 16:43:14 2013 +0100
dsdb-acl: make use of acl_check_access_on_{attribute,objectclass} in acl_rename()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 8d31e42eed71e9686b03c496eeff1ff96a6742ea
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 16 16:41:51 2013 +0100
dsdb-acl: make use of acl_check_access_on_attribute() in acl_modify()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 8e47e64f5d73441b6eb13d59001d52ec77c1c7d5
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 16 16:36:07 2013 +0100
dsdb-acl: remove unused acl_check_access_on_class()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 34f1a52689f4cc64fb63118e685a4442e3fe187a
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 16 16:35:33 2013 +0100
dsdb-acl: use acl_check_access_on_objectclass() instead of acl_check_access_on_class()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 6a4063f30273ff184364f276c5206c3507f37644
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Jan 2 15:01:23 2013 +1100
dsdb-acl: Use the structural objectClass in acl_check_access_on_attribute()
This commit enters the GUID into the object tree so that that access
rights assigned to the structural objectClass are also available, as
well as rights assigned to the attribute property groups.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit e8cc59eb781006c6193249128a1ffc4bcba8f28a
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Jan 2 15:01:00 2013 +1100
dsdb-acl: Pass the structural objectClass into acl_check_access_on_attribute
This will, when the GUID is entered into the object tree (not in this
commit) ensure that access rights assigned to the structural
objectClass are also available, as well as rights assigned to the
attribute property groups.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 93944ea90069df5379993f5c186ffd68e166f1c4
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Jan 2 14:55:36 2013 +1100
dsdb-acl: Remove unused get_oc_guid_from_message()
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit a1b421e8cca24a5831f4c6d77714cf54faf8c48e
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Jan 2 15:01:00 2013 +1100
dsdb-acl: ask for the objectClass attribute if it's not in the scope of the clients search
This will be used later.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 6ab41506857814d69d897471a14002d98fb4c172
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Jan 2 09:26:15 2013 +1100
dsdb-acl: use dsdb_get_structural_oc_from_msg() rather than class_schemaid_guid_by_lDAPDisplayName
This uses dsdb_get_last_structural_objectclass(), which encodes this ordering
knowledge in one place in the code, rather than using this uncommented
magic expression:
(char *)oc_el->values[oc_el->num_values-1].data
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 730433984c9f3dd30ee0b07dc22af56b4d3a062f
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Jan 2 14:54:20 2013 +1100
dsdb-acl: Use dsdb_get_structural_oc_from_msg() in acl_rename()
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 6d7e53aaac8c95f86e1eb8593880ae1c09d973d4
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Jan 2 14:53:02 2013 +1100
dsdb-acl: Use dsdb_get_structural_oc_from_msg() in acl_modify()
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 097fae2d1d6ae04a7bfc795803f200b6f703a904
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 16 16:34:56 2013 +0100
dsdb-acl: add acl_check_access_on_objectclass() helper
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 74bfec026921fcfc430fb7cfaee44ed75f135a99
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Jan 2 14:52:21 2013 +1100
dsdb-acl: Add helper function dsdb_get_structural_oc_from_msg()
This will eventually replace get_oc_guid_from_message(), returning the full dsdb_class.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 2685a4ed6681b1a20fb26087867737ecbf8fad73
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 16 11:45:46 2013 +0100
dsdb-acl: attr is not optional to acl_check_access_on_attribute()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit d695b8abc7a2e4f7e1853d0c61fe0c03fc786111
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 16 16:39:35 2013 +0100
dsdb-acl: dsdb_attribute_by_lDAPDisplayName() is needed for all attributes
"clearTextPassword" is the only exception.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ddfb8fe89c493c485250d59868312614c79a9cc1
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Jan 18 09:17:25 2013 +0100
dsdb-acl: introduce a 'el' helper variable to acl_modify()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 71b856a3f08fbd095833c27c59d7ed382be70d2a
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Jan 18 09:17:25 2013 +0100
dsdb-acl: introduce a 'msg' helper variable to acl_modify()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit c2853f55fc603d4875bb1e50a1cbf409df0421ea
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Jan 17 14:41:39 2013 +0100
dsdb-schema: make sure we build [system]PossibleInferiors completely
Otherwise callers like dsdb_schema_copy_shallow() will corrupt the
talloc hierarchie.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 1f673bf9209405dfa2593859bbc45d1c6dc2a960
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Jan 17 14:40:24 2013 +0100
dsdb-schema: make sure use clean caches in schema_inferiors.c
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit c4b9ee255814b8121d13e33cd9b0cd7c093d736c
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Jan 17 14:14:37 2013 +0100
dsdb-schema: make schema_subclasses_order_recurse() static
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 58fadf2f48a2a409b4ee98fdc0166c7f801a7629
Author: Günther Deschner <gd at samba.org>
Date: Fri Jan 18 00:22:31 2013 +0100
BUG 9474: Downgrade v4 printer driver requests to v3.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Mon Jan 21 16:11:02 CET 2013 on sn-devel-104
commit c38fb0b106b62e42a5b75b1c78386bb8912c7d7e
Author: Andreas Schneider <asn at samba.org>
Date: Fri Jan 18 18:04:17 2013 +0100
BUG 9574: Fix a possible null pointer dereference in spoolss.
If the the client enumerates the printers and didn't specify a
servername we have a null pointer dereference, so the process serving
the connection crashes.
Reviewed-by: David Disseldorp <ddiss at samba.org>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Mon Jan 21 13:30:11 CET 2013 on sn-devel-104
commit f70d0ac7390fdd0f305f0ee1133fd9611ca3333a
Author: Matthieu Patou <mat at matws.net>
Date: Thu Jan 3 14:34:31 2013 -0800
Tests: remove redondent testsuites in provision
Removed provision are already tested somewhere else.
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Matthieu Patou <mat at samba.org>
Autobuild-Date(master): Mon Jan 21 09:59:43 CET 2013 on sn-devel-104
commit 95fc53a37b9c75cbc1d13432887de095ff779a1e
Author: Matthieu Patou <mat at matws.net>
Date: Thu Jan 3 14:34:13 2013 -0800
Tests: avoid adding python options that are functions in the env
This fix errors when running test --testenv --screen
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit e1ab7b68043c1f459541838c2b839bc7cb117c19
Author: Matthieu Patou <mat at matws.net>
Date: Tue Jan 1 13:40:44 2013 -0800
Tests: rewrite ldap_schema to specify attributes
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 853360b8e558f39218fc150ead367255f3a010b2
Author: Jeremy Allison <jra at samba.org>
Date: Fri Jan 18 13:57:16 2013 -0800
Fix warnings with mismatched sizes in arguments to DEBUG statements.
This can cause compile errors on 32-bit systems.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Sat Jan 19 12:14:13 CET 2013 on sn-devel-104
commit 80a6fe84271d15cc22caa3d08768ab5559ef9ed7
Author: Jeremy Allison <jra at samba.org>
Date: Wed Jan 16 16:12:29 2013 -0800
Remove some unused variables.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit dda48146a2781fe685eeb9dc5194d142ee5ca0ef
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Nov 19 23:25:45 2012 +1100
heimdal_build: Try again to sort out the strerror_r mess
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit d90b709ebb22fb40cbd46bdddd28d9ec1be7b0ce
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Jan 18 13:39:13 2013 +1100
printing: Free talloc_stackframe() on all exit paths
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 63a7d3817fae3ec190a7919521cc0f5dbdea3b64
Author: Ira Cooper <ira at samba.org>
Date: Wed Jan 16 11:33:31 2013 -0800
nsswitch: Fix two bitfield constants being the same.
WBFLAG_PAM_AUTH_PAC and WBFLAG_BIG_NTLMV2_BLOB
are the same causing errors in NTLMv2 authentication.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Jan 18 22:13:09 CET 2013 on sn-devel-104
commit d814cfac017039ae8fc0d1311b15cc03f4c8b2ba
Author: Jeremy Allison <jra at samba.org>
Date: Wed Jan 16 11:31:32 2013 -0800
Sort winbind request flags. Ira saw we have a duplicate.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed by: Ira Cooper <ira at wakeful.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit a8fe624948f06e76aeb147ce0e47326f2d753f93
Author: Volker Lendecke <vl at samba.org>
Date: Thu Jan 17 15:22:32 2013 +0100
smbtorture: Satisfy a linker dependency
Reviewed by: Jeremy Allison <jra at samba.org>
commit 15596a8d9c5a578fa98e110350d15265c90e8f03
Author: Volker Lendecke <vl at samba.org>
Date: Thu Jan 17 14:34:35 2013 +0100
winbind: Handle child requests in a tevent_fd
This enables the use of standard tevent_loop_once in the child, which
now also uses epoll where available.
Reviewed by: Jeremy Allison <jra at samba.org>
commit 5e755643772d4615410599961859102f7c679d1c
Author: Volker Lendecke <vl at samba.org>
Date: Thu Jan 17 13:49:08 2013 +0100
winbind: Introduce "struct child_handler_state"
This will make the next patch simpler. child_handler_state contains the
information that the handler for the parent fde needs to pass to
process_child_request
Reviewed by: Jeremy Allison <jra at samba.org>
commit 3e830e44d3eb23325fbda6f2053e58926ee2136e
Author: Volker Lendecke <vl at samba.org>
Date: Wed Jan 16 12:00:00 2013 +0100
winbind: Use standard tevent_context_init
This makes winbind use epoll instead of poll
Reviewed by: Jeremy Allison <jra at samba.org>
commit 4f9cffbae6a60268140eba5e457ac7e86cac6246
Author: David Disseldorp <ddiss at samba.org>
Date: Thu Jan 17 13:21:25 2013 +0100
BUG 9378: Add extra attributes for AD printer publishing.
Currently attempting to publish a printer in AD fails with "Object class
violation", due to a number of missing attributes in the LDAP request.
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Fri Jan 18 17:27:35 CET 2013 on sn-devel-104
commit 12a08d8ae254d5cb0651cb6016ab7e1859f47d82
Author: David Disseldorp <ddiss at samba.org>
Date: Fri Jan 18 11:48:20 2013 +0100
printing: Remove invalid free from error path.
Reviewed-by: Andreas Schneider <asn at samba.org>
commit f0852a3483424d1242390011a65c427d3dbd80f2
Author: Jeremy Allison <jra at samba.org>
Date: Wed Jan 16 16:30:04 2013 -0800
Remove locking across the lifetime of the copychunk call.
Previous commit handles this around each read/write call.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Fri Jan 18 01:47:01 CET 2013 on sn-devel-104
commit f2d028ef552adf13eed10b7db47e35bfa89a9c02
Author: Jeremy Allison <jra at samba.org>
Date: Wed Jan 16 16:29:11 2013 -0800
Move copychunk locking to be local to the read/write calls.
Eliminates the need to hold locks across the
entire lifetime of the call.
Next commit will remove these.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit d562e9006a341ade6f38ee129598dd2e1dc3a493
Author: Jeremy Allison <jra at samba.org>
Date: Wed Jan 16 12:58:17 2013 -0800
Add additional copychunk checks.
For printer, ipc$ connections, and directory handles.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit d6e10f00666b9baa17927067e58361ab39901fa1
Author: Jeremy Allison <jra at samba.org>
Date: Wed Jan 16 12:51:32 2013 -0800
Move handle checking code to copychunk_check_handles().
Planning to add extra checks to ensure we don't attempt
copychunk on printer or IPC$ handles.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 7a21f605c14a43807e4887fd92df61a341132a43
Author: Volker Lendecke <vl at samba.org>
Date: Thu Jan 17 22:14:33 2013 +0100
tevent: Fix a comment
liboop.org is now in a language I don't understand. But it does definitely not
contain a library.
Reviewed by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Jan 18 00:05:37 CET 2013 on sn-devel-104
commit d34cd6d061ce53c305e146420c4b4451fe35df6f
Author: Andreas Schneider <asn at samba.org>
Date: Thu Jan 17 17:18:04 2013 +0100
printing: Create default architecture directories on init.
Reviewed-by: Guenther Deschner <gd at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Thu Jan 17 20:36:17 CET 2013 on sn-devel-104
commit 79fa78e2851009bc992d5b1bb447cb91d8b68900
Author: Günther Deschner <gd at samba.org>
Date: Thu Jan 17 16:09:15 2013 +0100
s3-spoolss: use configurable spoolss architecture in compose_spoolss_server_path().
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Thu Jan 17 18:53:47 CET 2013 on sn-devel-104
commit 3b94b64481a811482dbd01fd55c145a89f2c8c96
Author: Günther Deschner <gd at samba.org>
Date: Wed Jan 16 13:41:28 2013 +0100
spoolss: make spoolss deal with ndr64 SetForm by using proper container object.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit 8304fe73f69ea7de57bd2d331038c4664553a9bd
Author: Günther Deschner <gd at samba.org>
Date: Wed Jan 16 01:15:49 2013 +0100
spoolss: make spoolss deal with ndr64 AddForm by using proper container object.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit be8c81bfa3c6a2727eab589a71c6215ca76e3d3a
Author: Günther Deschner <gd at samba.org>
Date: Wed Jan 16 00:06:03 2013 +0100
s4-torture: add ndr64 spoolss_SetPrinter ndr test.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit e8feca012e7b2ff29de58cef80c7511f33989a84
Author: Günther Deschner <gd at samba.org>
Date: Wed Jan 16 00:04:41 2013 +0100
spoolss: make spoolss deal with ndr64 ULONG_PTR of devmode_ptr and secdesc_ptr.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit e1d50a6b24012b42f9987b439a4b94cd8db79999
Author: Matthieu Patou <mat at matws.net>
Date: Thu Dec 27 00:01:49 2012 -0800
dsdb-operational: Avoid doing the ldb_attr_cmp if bypass flag is not set
Most of the time this flag is not set and so we can avoid the strcasecmp
in ldb_attr_cmp()
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Thu Jan 17 17:10:32 CET 2013 on sn-devel-104
commit a0faf16ae9aefc4963b2583970509b1b23e27ce1
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Nov 17 13:49:00 2012 +1100
torture: Fix fsmo test to use correct -H samba-tool syntax
However, the test still does not pass.
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 18d7e5df0eb8fb593e66daf25d142584f44b5b87
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Jan 15 09:56:46 2013 +1100
dsdb: Do not hold the transaction over the IRPC call to perform a role transfer
This avoids one samba process locking out another from the DB.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit b40d134bc1866dd7e5b5e7dfc5bf01f6d55b1c1f
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Jan 13 13:03:13 2013 +1100
selftest: also skip raw.search as it also spins
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 316fd085ad2b587b82d817358240f84ae054a543
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Nov 20 14:59:17 2012 +1100
drs-fsmo: Improve handling of FSMO role takeover.
This needs to be more async, and give less scary errors.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 6a1025551eb5b343ec996ae0c642d542162e8910
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Jan 8 15:55:36 2013 +0100
dsdb-acl: calculate sDRightsEffective based on "nTSecurityDescriptor"
acl_check_access_on_attribute should never be called with attr=NULL
because we don't check access on an attribute in that case
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Matthieu Patou <mat at matws.net>
Autobuild-User(master): Matthieu Patou <mat at samba.org>
Autobuild-Date(master): Thu Jan 17 11:21:10 CET 2013 on sn-devel-104
commit ccf577da14194f5f3377226bcdb7e69b62a94851
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Jan 8 15:54:47 2013 +0100
dsdb-acl: add helper variable 'ldb' in acl_sDRightsEffective
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Matthieu Patou <mat at matws.net>
commit 629ce2a1ba392f2e8b632752c583843777471378
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Jan 4 16:03:42 2013 +0100
libcli/security: don't look at the inherited type in get_ace_object_type()
The inherited_type is only used to decide if aces should be inherited
effectively or not (INHERIT_ONLY) for the specified object.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Matthieu Patou <mat at matws.net>
commit 70460605c6132ffbc6be825c24f188674c0ac979
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Jan 17 08:51:23 2013 +0100
dsdb-acl: fix the order of special and system checks
First we check for a special dn, then for system access.
All allocations happen after this checks in order to avoid
allocations we won't use.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Matthieu Patou <mat at matws.net>
commit a0c59b4da1c5d8637c92e65c7cf54bb82bc8fca5
Author: Matthieu Patou <mat at matws.net>
Date: Sun Dec 30 02:27:25 2012 -0800
dsdb-acl: Do not apply ACL on special DNs to hide attributes that the user shouldn't see
This fix frequent reindexing when using python script with a
user that is not system.
The reindexing is caused by ACL module hidding (removing) attributes in
the search request for all attributes in dn=@ATTRIBUTES and because
dsdb_schema_set_indices_and_attributes checks that the list of
attributes that it just calculated from the schema is the same as the
list written in @ATTRIBUTES, if not the list is replaced and a
reindexing is triggered.
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 961a1fbbbccb7fbb14634ec230985f3fd000b050
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Jan 17 08:37:58 2013 +0100
dsdb-acl: talloc_free the private context when we pass to the next module
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Matthieu Patou <mat at matws.net>
commit 947985b259ac05e95d65be19c67f384579a797ce
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Jan 17 08:37:12 2013 +0100
dsdb-acl: don't call dsdb_user_password_support() if we don't use the result
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Matthieu Patou <mat at matws.net>
commit 8e63a72ec1e9ea9efcbcdf156274afaed9a4b2ea
Author: David Disseldorp <ddiss at samba.org>
Date: Tue Jan 15 17:23:12 2013 +0100
smb2_ioctl: copychunk request max output validation
Check that the copychunk ioctl request maximum output specified by the
client is large enough to hold copychunk response data.
Reviewed by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Jan 17 00:59:44 CET 2013 on sn-devel-104
commit bf07c33dac37442b8f5b49e68653f8ef629ff679
Author: David Disseldorp <ddiss at samba.org>
Date: Tue Jan 15 17:23:11 2013 +0100
smb2_ioctl: track copychunk response output state
Treat the response data independent to the status.
Reviewed by: Jeremy Allison <jra at samba.org>
commit cb323281c1f2b66f2b42527cda722e57ca1f1f23
Author: David Disseldorp <ddiss at samba.org>
Date: Tue Jan 15 17:23:10 2013 +0100
smb2_ioctl: copychunk CHECK_READ and CHECK_WRITE
[MS-SMB2] 3.3.5.15.6 Handling a Server-Side Data Copy Request, specifies
that the copychunk destination file handle be granted FILE_WRITE_DATA
and FILE_READ_DATA access.
FILE_READ_DATA access must also be granted on the copychunk source file,
which may be done implicitly with execute permission.
Reviewed by: Jeremy Allison <jra at samba.org>
commit 456724f05d79733fe805a3209231c565d69d2be3
Author: David Disseldorp <ddiss at samba.org>
Date: Tue Jan 15 17:23:09 2013 +0100
torture: copychunk test suite improvements
Allow for large files in test_setup_copy_chunk():
Write test data in 1M IOs, rather than attempting to do the whole
thing in one go.
Add copychunk bad resume key test:
Send a copy chunk request with an intentionally bogus resume key
(source key handle).
Add copychunk src=dest test:
Test copychunk requests where the source and destination handles refer
to the same file.
Add copychunk src=dest overlap test.
Add desired access args to test_setup_copy_chunk().
Add copychunk_bad_access test:
Open the copychunk source and destination files with differing
desired_access values. Confirm copychunk response matches 2k8 and 2k12
behaviour.
Add copy_chunk_src_exceed test:
Attempts to copy more data than is present in the copychunk source
file.
Add copy_chunk_src_exceed_multi test:
Test whether the first chunk in a multi-chunk copychunk request is
written to disk, where the second chunk is invalid due to src file
overrun.
Add copy_chunk_sparse_dest test:
Issue a request where the target offset exceeds the file size, resulting
in a sparse region.
Add copy_chunk_max_output_sz test.
Reviewed by: Jeremy Allison <jra at samba.org>
commit c3cc51e8a2f31565c3bac219ea3a78ab4287bcd5
Author: David Disseldorp <ddiss at samba.org>
Date: Tue Jan 15 17:23:08 2013 +0100
smb2_ioctl: only pass through to VFS on a valid fsp
A null fsp is dereferenced on VFS call.
Reviewed by: Jeremy Allison <jra at samba.org>
commit bfe765367e1425fc3ae98e6b8183e6ac5476e97b
Author: David Disseldorp <ddiss at samba.org>
Date: Tue Jan 15 17:23:07 2013 +0100
torture: replace ioctl failure returns with helper calls
Also change test_ioctl_get_shadow_copy() to use torture_skip(), and
clean up test output.
Reviewed by: Jeremy Allison <jra at samba.org>
commit 42a5a6c0f61f0c863bac1bf65e7045f1ce086409
Author: David Disseldorp <ddiss at samba.org>
Date: Tue Jan 15 17:23:06 2013 +0100
torture: add locking tests for copychunk
Reviewed by: Jeremy Allison <jra at samba.org>
commit a7c2f13d7a5646f2a63ce33e8155ce79d10ef696
Author: David Disseldorp <ddiss at samba.org>
Date: Tue Jan 15 17:23:05 2013 +0100
smb2_ioctl: perform locking around copychunk requests
For each chunk in a copychunk request, take a read and write lock on
the source and destination files respectively.
Also change the resume key format to use a combination of the persistent
and volatile handles. Thanks to Metze for his help on this.
Reviewed by: Jeremy Allison <jra at samba.org>
commit 7ca8663e313a55fd6157cf20eb02c2ac8be94a00
Author: David Disseldorp <ddiss at samba.org>
Date: Tue Jan 15 17:23:04 2013 +0100
smbd: split out file_fsp_get from file_fsp_smb2
Obtain the files_struct from smb2req, persistent_id and
volatile_id.
Reviewed by: Jeremy Allison <jra at samba.org>
commit 3619b1a7b2b5a2bfe6fdb13ecb4650ae575ab3e8
Author: David Disseldorp <ddiss at suse.de>
Date: Tue Jan 15 17:23:03 2013 +0100
torture: skip FSCTL_SRV_ENUM_SNAPS test when not supported
If FSCTL_SRV_ENUM_SNAPS fails with NT_STATUS_NOT_SUPPORTED then skip the
test, this means we can run the full ioctl test suite as part of
autobuild.
Reviewed by: Jeremy Allison <jra at samba.org>
commit bc59ebf5231b44220598dfdf44c9a2cfcc538711
Author: David Disseldorp <ddiss at samba.org>
Date: Tue Jan 15 17:23:02 2013 +0100
selftest: enable samba3.smb2.ioctl tests against s3fs
These tests are now expected to pass with copy-chunk support now
implemented.
This effectively reverts 632b1042aed94a71d810613fcdbbfecf615a25fa.
Reviewed by: Jeremy Allison <jra at samba.org>
commit 65983aac12e5ecb12157b39c7bec464388716f27
Author: David Disseldorp <ddiss at suse.de>
Date: Tue Jan 15 17:23:01 2013 +0100
smb2_ioctl: remove ioctl error response assumptions
MS-SMB2 3.3.4.4 documents cases where a ntstatus indicating an error
should not be considered a failure. In such a case the output data
buffer should be sent to the client rather than an error response
packet.
Add a new fsctl copy_chunk test to confirm field limits are sent back
in response to an oversize chunk request.
Reviewed by: Jeremy Allison <jra at samba.org>
commit e38d9f71d90e6b20a027d91d4768d91378728621
Author: David Disseldorp <ddiss at samba.org>
Date: Tue Jan 15 17:23:00 2013 +0100
smb2_ioctl: add support for FSCTL_SRV_COPYCHUNK
SMB2 clients can issue FSCTL_SRV_COPYCHUNK requests in order to copy
data between files on the server side only, rather than reading data
then writing back from the client. FSCTL_SRV_COPYCHUNK is used by
default for Explorer SMB2 file copies on Windows Server 2012.
2.2.32.1 SRV_COPYCHUNK_RESPONSE in [MS-SMB2] describes the requirement
for the server to provide maximum copychunk request size limits in ioctl
responses carrying STATUS_INVALID_PARAMETER.
Reviewed by: Jeremy Allison <jra at samba.org>
commit ef00eb90e56dfac2d823582cec92abf1fa9905f1
Author: David Disseldorp <ddiss at suse.de>
Date: Tue Jan 15 17:22:59 2013 +0100
s3-vfs: add copy_chunk vfs hooks
copy_chunk copies n bytes from a source file at a specific offset to a
destination file at a given offset. This interface will be used in
handling smb2 FSCTL_SRV_COPYCHUNK ioctl requests.
Use a pread/pwrite loop in vfs_default, so that requests referring to
the same src and dest file are possible.
Provide send and receive hooks for copy chunk VFS interface, allowing
asynchronous behaviour.
Check whether the request source offset + length exceeds the current
size. Return STATUS_INVALID_VIEW_SIZE under such a condition, matching
Windows server behaviour.
Reviewed by: Jeremy Allison <jra at samba.org>
commit 2bde9636888067210dc38523b6fafaa0b179ec3b
Author: David Disseldorp <ddiss at suse.de>
Date: Tue Jan 15 17:22:58 2013 +0100
smb2_ioctl: add FSCTL_SRV_REQUEST_RESUME_KEY support
Use existing ioctl IDL infrastructure for marshalling. Support for this
ioctl is a prerequisite for FSCTL_SRV_COPYCHUNK handling.
The client-opaque resume key is constructed using the server side
dev/inode file identifier.
Reviewed by: Jeremy Allison <jra at samba.org>
commit 14bd6c8b0954ad58ac4e3e157835594c26bfa97a
Author: David Disseldorp <ddiss at suse.de>
Date: Tue Jan 15 17:22:57 2013 +0100
smb2_ioctl: split ioctl handler code on device type
Add per device type ioctl handler source files for FSCTL_DFS,
FSCTL_FILESYSTEM, FSCTL_NAMED_PIPE and FSCTL_NETWORK_FILESYSTEM.
Reviewed by: Jeremy Allison <jra at samba.org>
commit 958b21c28dacad38cd64e79ca7d77cd8acc20dd0
Author: David Disseldorp <ddiss at samba.org>
Date: Tue Jan 15 17:22:56 2013 +0100
smb2_ioctl: split ioctl handlers into separate funtions
Reviewed by: Jeremy Allison <jra at samba.org>
commit 9ba44cc610426fb558b49aa9680b5bdf55c29082
Author: Michael Adam <obnox at samba.org>
Date: Tue Jan 15 15:35:09 2013 +0100
build(waf): fix the abi_match for the pdb library
The global wildcard match is automatically added by the parsing code
if the global match list is empty. Specifying an explicit '*' as the only
global match lets the parsing code add a second '*' to the local list,
which is an error tolerated on my linux by ld (the GNU linker), but
not by the stricter GNU ELF linker "gold".
Pair-Programmed-With: Gregor Beck <gbeck at sernet.de>
Signed-off-by: Gregor Beck <gbeck at sernet.de>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Alexander Bokovoy <ab at samba.org>
Autobuild-User(master): Alexander Bokovoy <ab at samba.org>
Autobuild-Date(master): Wed Jan 16 21:31:00 CET 2013 on sn-devel-104
commit 46b6afc69baf89ba346e4418452b2d5a49b3e322
Author: Günther Deschner <gd at samba.org>
Date: Tue Jan 15 17:05:10 2013 +0100
s4-torture: add ndr64 spoolss openprinterex to ndr test.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Wed Jan 16 13:26:53 CET 2013 on sn-devel-104
commit 6cdf59d716eb41c8ce67ff55aa661eaa09fa2e1b
Author: Günther Deschner <gd at samba.org>
Date: Tue Jan 15 17:04:08 2013 +0100
s4-torture: allow to do ndr tests with flags, not only ndr_flags.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit a4dcf7b94d8f2d8180bb5b390f49e89e2c956a88
Author: Günther Deschner <gd at samba.org>
Date: Mon Jan 14 17:26:31 2013 +0100
spoolss: Make OpenPrinterEx work with NDR64 by using UserInfo Container.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 6bb7bf9ebb0671be19419ba54955dd929494c8e8
Author: Volker Lendecke <vl at samba.org>
Date: Tue Jan 15 11:22:49 2013 +0100
test: dbwrap_tool requires --persistent for the registry now
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Jan 15 16:31:35 CET 2013 on sn-devel-104
commit 7f65434559ca241a3b8c2cb7969f63f6512a9ff7
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 14 17:22:05 2013 +0100
docs: document the "--persistent" option in dbwrap_tool(1)
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 770b1aafa0e6557d9de2aace26dae4191eb01568
Author: Michael Adam <obnox at samba.org>
Date: Wed Jan 2 01:12:58 2013 +0100
s3:dbwrap_tool: add --persistent switch and mode for non-persistent DBs
This changes the default for dbwrap_tool to open a DB as non-persistent.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 11850e4605bc50e0b4aa07f8c46154fc01504646
Author: Michael Adam <obnox at samba.org>
Date: Wed Jan 2 01:02:56 2013 +0100
dbwrap: add dbwrap_is_persistent()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit d67911bafc0d098e67c8ad8d9b4bc49f184ff832
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 14 17:15:08 2013 +0100
docs: document the command line options in dbwrap_tool(1)
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit f3f878f7a06e067bcc973014b2ef6b6830273de7
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 14 17:55:51 2013 +0100
docs: use the popt.common.samba.client entity in samba-tool(8)
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit cdc18f92cca2f14a6e59aa50f2c2a9f076ea9faa
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 14 17:23:37 2013 +0100
docs: use the entities popt.common.samba.server and stdarg.help in samba(8)
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 2d30e5deaf731839402b47751683d2c0e32d2bc7
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 14 17:08:30 2013 +0100
docs: add popt.common.samba.server and popt.common.samba.client entities
These are comprised by the popt.common.samba entity and the stdarg.server.debug
or the stdarg.client.debut entity, respectively.
The difference is only in the default value of the debug level setting.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 2ab3a96d262f60d26a8cd16dded3296889ab7f3f
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 14 17:12:51 2013 +0100
docs: fix the stdarg.configfile entity to print a "=" sign after the long option
This makes the appearance equal to the other options like --debuglevel or
--log-basename.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit e3db3db784085bb2fedbf3063154b7cd77630e59
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 14 17:06:03 2013 +0100
docs: use the stdarg.option entity in the popt.common.samba entity
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit c9b95eb205abbdb77960eb0419937512358f7e64
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 14 17:05:05 2013 +0100
docs: add an entity stdarg.option for the "--option" command line parameter
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit d61d2af3727a19cc4ddc88ec2faa8aafff9c7422
Author: Björn Baumbach <bb at sernet.de>
Date: Thu Dec 20 10:01:43 2012 +0100
wafsamba: use additional xml catalog file (bug #9512)
Add additional "/usr/local/share/xml/catalog" catalog file
platforms (used by freebsd).
Fix manual page build on freebsd.
Signed-off-by: Björn Baumbach <bb at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 07660ac01acf4fd4b03436dd0f597a246948a590
Author: Björn Baumbach <bb at sernet.de>
Date: Tue Oct 16 10:14:55 2012 +0200
smb.conf(5): client min protocol: add hint at list of available protocols
And fix the format.
Signed-off-by: Björn Baumbach <bb at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit d6ec1ef6cc679c94a6a83fad11711bae27db6ff7
Author: Björn Baumbach <bb at sernet.de>
Date: Tue Dec 11 13:46:38 2012 +0100
smb.conf(5): server min protocol: add hint at list of available protocols
And fix the format.
Signed-off-by: Björn Baumbach <bb at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 41955b711f48ee2c8fe70a7e9967a2a96adf8a3d
Author: Björn Baumbach <bb at sernet.de>
Date: Mon Dec 10 11:52:08 2012 +0100
build(waf)-libreplace: remove redundant check for flistea function
Signed-off-by: Björn Baumbach <bb at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit cabc89a1e72fc95300d4b6f8d480a7d666221b8b
Author: Björn Baumbach <bb at sernet.de>
Date: Tue Dec 4 10:54:05 2012 +0100
ntlm_auth(1): fix many format issues and and make examples visible
"<example>" is no child of "<para>". So these examples were not visible.
Using a varlist instead may be not the best way but it does look nice.
Signed-off-by: Björn Baumbach <bb at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit b7a091ecf48963e2a0d1757d0faf131ad8d940fa
Author: Björn Baumbach <bb at sernet.de>
Date: Mon Oct 15 17:20:07 2012 +0200
build(waf): docs-xml: build new dbwrap_tool.8 manual page
Signed-off-by: Björn Baumbach <bb at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 8d6104f02d9ab879efe7867fec53cbe5cc408ded
Author: Björn Baumbach <bb at sernet.de>
Date: Mon Oct 15 17:17:29 2012 +0200
docs-xml: add dbwrap_tool.1 manual page
Signed-off-by: Björn Baumbach <bb at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 065c0ec16259f8d57baec5dfe4e6eb9bdea0002a
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Jan 10 09:30:38 2013 +1100
dsdb: Add test for modification of two attributes, one permitted, one denied (bug #9554 - CVE-2013-0172)
Reviewed-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 8bafe0871526cd5d5e7fdbe123ab661379f64cb1)
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Jan 15 14:03:47 CET 2013 on sn-devel-104
commit b7b91c85945fab87e55cd8fd65a5b4c50a61d03b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Jan 9 16:59:18 2013 +1100
dsdb-acl: Run sec_access_check_ds on each attribute proposed to modify (bug #9554 - CVE-2013-0172)
This seems inefficient, but is needed for correctness. The
alternative might be to have the sec_access_check_ds code confirm that
*all* of the nodes in the object tree have been cleared to
node->remaining_bits == 0.
Otherwise, I fear that write access to one attribute will become write
access to all attributes.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit d776fd807e0c9a62f428ce666ff812655f98bc47)
commit b26668c606057fb30b20efd912284c3e79d547ff
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Jan 3 20:39:23 2013 +1100
libcli/security: Ensure to fill in remaining_access for the initial case (bug #9554 - CVE-2013-0172)
It is critically important that we initialise this element as otherwise
all access is permitted.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit a75805490d96a85786287f5d0522dd7671d6816e)
commit 8f8ca589d2aa7f9deaae6a05cb5ab73da95372bf
Author: Jeremy Allison <jra at samba.org>
Date: Mon Jan 14 15:22:11 2013 -0800
tevent: Fix bug 9550 - sigprocmask does not work on FreeBSD to stop further signals in a signal handler
Mask off signals the correct way from the signal handler.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Jan 15 12:13:43 CET 2013 on sn-devel-104
commit 0258138e207c8f3e8bb05a47599aa04b4e9567cf
Author: Jeremy Allison <jra at samba.org>
Date: Mon Jan 14 15:21:52 2013 -0800
lib/replace: Include sys/ucontext.h if available.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit fe6e323addb967b392bfd406c499a6f67fcdc152
Author: Jeremy Allison <jra at samba.org>
Date: Mon Jan 14 15:21:35 2013 -0800
lib/replace: Add ucontext configure autoconf checks.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 7fe400de4c189c8bdf0cc8afdebde2f21680fac2
Author: Jeremy Allison <jra at samba.org>
Date: Mon Jan 14 15:21:12 2013 -0800
lib/replace: Add ucontext configure waf checks.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit e54252ceec213644a8d812e6374476639f764643
Author: Jeremy Allison <jra at samba.org>
Date: Mon Jan 14 15:06:12 2013 -0800
lib/replace: Add missing check for sys/wait.h
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit a82db92a8a68f6e33e20fd2b55401225d91345cf
Author: Volker Lendecke <vl at samba.org>
Date: Mon Jan 14 21:37:52 2013 +0100
smbd: Fix bug 9544, part 2
Plug in async pwrite
Reviewed by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Jan 15 00:55:51 CET 2013 on sn-devel-104
commit 215427202ad993ad48d0ea4c47ac4435fc4610fb
Author: Volker Lendecke <vl at samba.org>
Date: Mon Jan 14 21:36:51 2013 +0100
smbd: Fix bug 9544, part 1
Adapt the sync function names
Reviewed by: Jeremy Allison <jra at samba.org>
commit 0bafce02f80af8c7d1fb0c6b210353925a3f4c39
Author: Volker Lendecke <vl at samba.org>
Date: Mon Jan 14 21:14:20 2013 +0100
smbd: Always compile vfs_commit
There's no reason not to
Reviewed by: Jeremy Allison <jra at samba.org>
commit 584402a71a4dd4bc821a58087814a1f3c110bb65
Author: Volker Lendecke <vl at samba.org>
Date: Mon Jan 7 12:53:27 2013 -0800
configure: Fix bug 9546, aio_suspend detection on FreeBSD
NULL is not defined without some includes
Reviewed by: Jeremy Allison <jra at samba.org>
commit e0bfb59803184c44cfc354b99ba3d8d7bbfc72b9
Author: Volker Lendecke <vl at samba.org>
Date: Sat Jan 12 16:08:07 2013 +0100
Fix bug 9548: Correctly detect O_DIRECT
Reviewed by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Mon Jan 14 21:16:23 CET 2013 on sn-devel-104
commit d87ad906df96ac82924ccaf1a127b20c745f1dca
Author: Volker Lendecke <vl at samba.org>
Date: Fri Jan 11 10:36:04 2013 +0100
samr: Make use of posix_openpt
Reviewed by: Jeremy Allison <jra at samba.org>
commit bef944166ab5b5e6dcceaeb4655b20bd7f2fc4d2
Author: Volker Lendecke <vl at samba.org>
Date: Fri Jan 11 10:31:42 2013 +0100
samr: Split up an assignment from an if condition
Reviewed by: Jeremy Allison <jra at samba.org>
commit 813bd0353fda0eb6d7c78392d5abd3002115da96
Author: Stephen Gallagher <sgallagh at redhat.com>
Date: Wed Jan 2 11:22:16 2013 -0500
ldb: Move doxygen comments for ldb_connect to the right place
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Mon Jan 14 16:21:02 CET 2013 on sn-devel-104
commit 95c891cf44143e12b2f90047f3fefe6d23c598fd
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Jan 11 16:42:41 2013 +1100
dsdb: Make linked_attributes module GUID based for renames
This ensures that when we have the backlink out of sync with the forward link (perhaps due
to another operation that has put the backlink handling in an end-of-transaction
TODO list in repl_meta_data) that we do not error out, we just cope as well as we can.
The GUID is the unique identifier, not the DN.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Sat Jan 12 12:52:28 CET 2013 on sn-devel-104
commit a8c745a28c3278e9fbee6f802dc340fe660f27ca
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Jan 11 08:26:07 2013 +1100
selftest: skip base.dir2 tests as they just spin on modern ext4
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit bdc172aca541046fd03b2b0cd69e054fe03d3a89
Author: Arvid Requate <requate at univention.de>
Date: Fri Jan 11 14:17:06 2013 +0100
s4-resolve: Fix parsing of IPv6/AAAA in dns_lookup (bug #9555)
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 8ae1c4636ebfbdb8d77a04dbad6edb52dfb671fc
Author: Volker Lendecke <vl at samba.org>
Date: Fri Jan 11 14:51:42 2013 +0100
winbind: Fix some missing NULL checks
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Fri Jan 11 18:55:41 CET 2013 on sn-devel-104
commit 54e01f68e7a6869a203bfdbdcc6c0294835b841f
Author: Volker Lendecke <vl at samba.org>
Date: Fri Jan 11 14:02:52 2013 +0100
winbind: Fix error check in unpack_tdc_domains
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit aea49ed37afe49d12fbb6303f6ea5e7f984b2fda
Author: Volker Lendecke <vl at samba.org>
Date: Fri Jan 11 17:04:39 2013 +0100
dbwrap: Use INCOMPATIBLE_HASH for dbwrap_watchers.tdb
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit edbc26bca84ee77b5a9571ba8dc9416c0db25906
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Dec 28 10:05:40 2012 +1100
scripting/samba_upgradedns: Only look for IPv4/IPv6 addresses if we actually them
This allows the script to be used to create/remove the samba-specific dns-SERVER account
when we do not need to create the in-directory partition.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Thu Jan 10 20:56:50 CET 2013 on sn-devel-104
commit 051a1a9c6417c2cbffa7d091ae477a6c7922d363
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Dec 22 09:28:05 2012 +1100
samba-tool classicupgrade: Do not print the admin password during upgrade
This changes the code to only set and show a new password if no admin
user is found during the upgrade.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Thu Jan 10 16:55:23 CET 2013 on sn-devel-104
commit 5e0fcb04a48d96669ed4376bfa17f679e3582236
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Dec 26 20:48:12 2012 +1100
s4-idmap: Remove requirement that posixAccount or posixGroup be set for rfc2307
This change matches the source3/idmap/idmap_ad.c code, and allows this
feature to work with only the setting of the UID/GID in Active
Directory Users and Computers.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit c9d2ca585e198b1006bbf7f1a3c988c1188b66cb
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Dec 28 12:36:06 2012 +1100
selftest: Add test for rfc2307 mapping handling
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 5812eb3c1deac51891f01338b4771b1e397dc24d
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Jan 3 21:31:22 2013 +1100
dsdb-acl: give error string if we can not obtain the schema
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 99d872ee9261a299add4718c38234dfe9f7658fc
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Aug 23 15:18:13 2012 +1000
s4-dbcheck: Allow forcing an override of an old @MODULES record
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 213e7260a83d4349132e8c159798b476cec3f814
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Jan 10 12:00:03 2013 +1100
build: Set LD_LIBRARY_PATH in install_with_python.sh
This ensures that the python install finishes correctly.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Thu Jan 10 14:00:13 CET 2013 on sn-devel-104
commit 5a1deec38a7ff7287b31a47ae61769c66e10de17
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Jan 10 09:00:37 2013 +1100
build: Make install_with_python.sh more portable
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 8e84c33a6094288ec2c8964588c679a71742e855
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Jan 10 08:51:34 2013 +1100
build: In install_with_python.sh force using the python from the install we just made
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 7acacdfc05d3162b2879b6ac80d0809b5af96f1e
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Jan 10 08:50:53 2013 +1100
build: Make install_with_python.sh executable
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 489ad498ab14340eb99f35a8814418db9db788a5
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Dec 20 18:36:40 2012 +1100
swat: move russian swat files alongside ja and tr
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit b9fbce20613952ead92dde3981a57f6d825c0584
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Dec 13 10:33:04 2012 +1100
passdb: Add discard_const_p() to pdb_samba_dsdb
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 26bae894f2ae898c51535dda14060ecf4786c6ec
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Jan 5 14:53:13 2013 +1100
vfs: Fix compilation of solaris ACL module
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 9dfd0a0dc980b521905399e0b409cb81fbbe6b37
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Jan 9 09:39:59 2013 +1100
build: Remove bashism from SAMBAMANPAGES rule
In sh, you must assign the variable, then export it.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 313da9dc7d8cb16f943ea7bde1c1d7bf8f02c0f0
Author: Björn Baumbach <bb at sernet.de>
Date: Tue Dec 11 13:39:11 2012 +0100
smb.conf(5): update list of available protocols (bug #9552)
Update protocol listing in variable substitution list.
Signed-off-by: Bjoern Baumbach <bb at sernet.de>
Reviewed by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Jan 9 21:22:18 CET 2013 on sn-devel-104
commit 3a7c2777ee0de37d758fe81d67d6836a8354825e
Author: Andreas Schneider <asn at samba.org>
Date: Wed Jan 9 09:02:54 2013 +0100
s3-lib: Use new strict directory create function in create_pipe_sock().
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Wed Jan 9 10:55:23 CET 2013 on sn-devel-104
commit 1aa0503401d41fec48d4d4e30d8bbcbd847ff807
Author: Andreas Schneider <asn at samba.org>
Date: Tue Jan 8 14:21:23 2013 +0100
Use the new directory_create_or_exist_strict() function.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 6039388fc1f3671bb60db06211814f7edfc62285
Author: Andreas Schneider <asn at samba.org>
Date: Tue Jan 8 14:21:00 2013 +0100
util: Add a strict directory_create_or_exist function.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 5d721de7fdc250c6cb423c553134dd687590c1a0
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Dec 13 10:44:07 2012 +0100
s3:smb2_negprot: set the 'remote_proto' value
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 4d1fd0b7daa089bd8863f0efcaf258bf30192c29
Author: Björn Baumbach <bb at sernet.de>
Date: Thu Dec 20 15:57:43 2012 +0100
samba_dnsupdate: set KRB5_CONFIG for nsupdate command
Let nslookup use krb5.conf, which is set in our KRB5_CONFIG.
Signed-off-by: Björn Baumbach <bb at sernet.de>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 8d9a77f8646cd26371dc2ec1d3ed52730ac19eb9
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Jan 4 13:27:26 2013 +0100
s4:lib/messaging: terminate the irpc_servers_byname() result with server_id_set_disconnected() (bug #9540)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 2cc6f9ce7f8068440ef527b0aebd3ad5ad105a9d
Author: Matthieu Patou <mat at matws.net>
Date: Mon Dec 31 15:38:50 2012 -0800
libnet-vampire: reports Exops as they rather than sync on some partitions
Instead of showing:
Partition[CN=RODC,OU=Domain Controllers,DC=samba,DC=example,DC=com]
objects[1] linked_values[8]
Report a exop based on CN=RODC,OU=Domain Controllers,DC=samba,DC=example,DC=com
as
Exop on CN=RODC,OU=Domain Controllers,DC=samba,DC=example,DC=com, ...
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Matthieu Patou <mat at samba.org>
Autobuild-Date(master): Wed Jan 9 09:01:30 CET 2013 on sn-devel-104
commit 09b00108069f16a6a654b88b4d87fbd3f566f2f0
Author: Matthieu Patou <mat at matws.net>
Date: Tue Jan 1 20:56:16 2013 -0800
script: Add a script to display testsuite runtime sorted
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
commit 0c86126d166c8f75bd3593fce077f26bca51f8aa
Author: Matthieu Patou <mat at matws.net>
Date: Mon Dec 31 02:12:23 2012 -0800
libnet: set the invocation_id earlier in order to avoid annoying messages
At that moment we have all the information to set the invocation id so
let's set it, it will avoid useless messages about missing invocation
id.
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
commit 411440d2d9085fe9db0e3c26c025c6b94d02c00f
Author: Jesper Larsen <jesper.larsen at ixonos.com>
Date: Fri Jan 4 13:03:58 2013 +0100
replace: Fix compilation of rep_mkstemp
Commit 1fbc185 removed the variable 'p'.
Use the equivalent variable 'template' instead.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Wed Jan 9 07:18:33 CET 2013 on sn-devel-104
commit 0615f68096569d00b1f262529024ad40136d445e
Author: Ira Cooper <ira at samba.org>
Date: Thu Dec 27 19:57:14 2012 +0000
s3: Fix vfs_zfsacl to compile.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 1002cc9a669836d6cddaac350715a2b107bec01e
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Dec 20 23:05:55 2012 +1100
selftest: show that Samba honours "write list" and valid users
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit fcdd6092b10a4b4406af47b989dcf1a9d693580e
Author: Jeremy Allison <jra at samba.org>
Date: Tue Jan 8 11:02:16 2013 -0800
Fixup the change_to_user_by_session() case as called from become_user_by_session()
Use inside source3/printing/nt_printing.c:get_correct_cversion().
Allow check_user_ok() to be called with vuid==UID_FIELD_INVALID.
All this should do is throw away one entry in the vuid cache.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 296c0c34f198dfc7a8f13f26e54fbc980f667784
Author: Volker Lendecke <vl at samba.org>
Date: Sun Jan 6 14:50:33 2013 +0100
smbd: Remove some ()
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 38b34cc3e529e185dd3b3d9f79ae74d1c9fac435
Author: Volker Lendecke <vl at samba.org>
Date: Sun Jan 6 14:41:24 2013 +0100
smbd: Simplify an if-expression
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 17708821ffc2d0cb771e8c5cb6415b87e20d6a0a
Author: Volker Lendecke <vl at samba.org>
Date: Sun Jan 6 14:39:07 2013 +0100
smbd: Fix a typo
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit b668c9077ba9005988146e8b1ee853ce8a6f33a4
Author: Jeremy Allison <jra at samba.org>
Date: Fri Jan 4 14:42:23 2013 -0800
Move create_share_access_mask() from smbd/service.c to smbd/uid.c.
Make it static. Only called from uid.c now.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 86d1e1db8e2747e30c89627cda123fde1e84f579
Author: Jeremy Allison <jra at samba.org>
Date: Fri Jan 4 14:40:05 2013 -0800
Fix bug #9518 - conn->share_access appears not be be reset between users.
Ensure make_connection_snum() uses the same logic as
check_user_ok() to decide if a user can access a share.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 1abb5eb89b97fab5a4c625f5492b7d26b7f17e98
Author: Jeremy Allison <jra at samba.org>
Date: Fri Jan 4 14:35:46 2013 -0800
Factor code out of check_user_ok() into a call to check_user_share_access().
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ea86f4e100b547c8facc5f27ac025de6b60eea94
Author: Jeremy Allison <jra at samba.org>
Date: Thu Jan 3 16:06:40 2013 -0800
Initialize stack variables. Prelude to factoring out calls to check_user_share_access().
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 8475f206b296362fc2473bf6eb4b6d51834f8245
Author: Jeremy Allison <jra at samba.org>
Date: Fri Jan 4 14:27:18 2013 -0800
Add check_user_share_access() which factors out the share security and read_only flag setting code.
Allows this to be called from both make_connection_snum() as well as check_user_ok().
Gives a consistent share security check function.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 6d7bffa6069ef41c36c40453681372973bba0c86
Author: Jeremy Allison <jra at samba.org>
Date: Fri Jan 4 14:25:55 2013 -0800
Correctly setup the conn->share_access based on the current user token.
Also use this to set conn->read_only. Cache the share_access in the
struct vuid_cache_entry struct so we only evaluate this once per new
user access on this share.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 5e9eebf5dec60177a680010e011b88ae0ecf26d2
Author: Jeremy Allison <jra at samba.org>
Date: Fri Jan 4 14:24:13 2013 -0800
Change API for create_share_access_mask() - remove conn struct.
Eventually this will be indepentent of conn, just pass in the
readonly flag.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 926d9307f789e2ca752ee2dab6b6e653dc7de628
Author: Jeremy Allison <jra at samba.org>
Date: Fri Jan 4 11:43:10 2013 -0800
Change API for create_share_access_mask() to pass in the token.
Don't automatically use the one from conn->session_info->security_token.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 00de188e1f3e3b795bfdbb0c84305f4767f56349
Author: Jeremy Allison <jra at samba.org>
Date: Fri Dec 21 09:45:03 2012 -0800
Fix API for create_share_access_mask().
Return the uint32_t share_access rather than directly
changing the conn struct.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit f7464bbf72dac41a65334c27403db8da7e08f7d3
Author: Jeremy Allison <jra at samba.org>
Date: Fri Dec 21 09:35:31 2012 -0800
Remove static from create_share_access_mask().
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 4983d5838afcab8c675cace0723a3fc284667bec
Author: Jeremy Allison <jra at samba.org>
Date: Fri Dec 21 09:22:16 2012 -0800
Add uint32_t share_access to vuid_cache_entry.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 7d90ae123af115bdcb1cdcd025cf73fdbf22b142
Author: Jeremy Allison <jra at samba.org>
Date: Thu Dec 20 14:42:55 2012 -0800
Clean up struct connection_struct, make struct vuid_cache a pointer not inline.
Change VFS ABI to 31 for 4.1.0.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 5e483ab14785faf5bc011e36ac07646a624c3962
Author: Jeremy Allison <jra at samba.org>
Date: Thu Dec 20 11:55:09 2012 -0800
Remove unneeded variable "const struct auth_session_info *session_info"
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 2e2f46433c657f8e9e68aaaee15e24ed41244d82
Author: Jeremy Allison <jra at samba.org>
Date: Thu Dec 20 11:54:07 2012 -0800
Remove dead code now vuser can no longer be NULL.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 0a09ffd188f7bc9d8e9e4272af355e53081bf7da
Author: Jeremy Allison <jra at samba.org>
Date: Thu Dec 20 11:53:11 2012 -0800
Remove the second set of {} braces, no longer needed.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 45845f5ba13ad4f5f12c22596ac5905a6cebec31
Author: Jeremy Allison <jra at samba.org>
Date: Thu Dec 20 11:52:27 2012 -0800
Remove one set of enclosing {} braces, no longer needed.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 390a812ccb9ba5dbc67296cc27e7aa56e6dd5ab3
Author: Jeremy Allison <jra at samba.org>
Date: Thu Dec 20 11:51:55 2012 -0800
Move the definition of struct vuid_cache_entry *ent outside blocks.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 310c4cac907877958f771c4933329560655f814c
Author: Jeremy Allison <jra at samba.org>
Date: Thu Dec 20 11:50:25 2012 -0800
Start to tidy-up check_user_ok().
Now we have removed "security=share" we cannot be
called with vuid == UID_FIELD_INVALID.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 5bffdac4ed3fa5477e025e871efff759aa0ee8d8
Author: Jeremy Allison <jra at samba.org>
Date: Tue Jan 8 14:18:55 2013 -0800
torture/vfstest.c: Always use create_conn_struct(). Don't hand create connection structs.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 7ba685090487410270415d3e4d69f62947ce34c3
Author: Jeremy Allison <jra at samba.org>
Date: Tue Jan 8 14:18:27 2013 -0800
source3/smbd/pysmbd.c: Always use create_conn_struct(). Don't hand create connection structs.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit a9730cb3909d8c8aea64b35342ac763b135e0b1f
Author: Jeremy Allison <jra at samba.org>
Date: Tue Jan 8 14:17:51 2013 -0800
smbd/posix_acls.c: Use create_conn_struct(). Don't hand-create connection structs.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit b6fe9ec6835c322f6d2d6e831bece311100bf051
Author: Jeremy Allison <jra at samba.org>
Date: Tue Jan 8 16:26:50 2013 -0800
Allow create_conn_struct() to be called with snum == -1.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 97eb0493fc263fabe63b6846b6f6add7068098e6
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Jan 9 08:02:23 2013 +1100
smbd: Rework create_conn_struct to use conn_new()
This avoids issues with required structure elements not being initialised.
In particular, once conn->vuid_cache becomes a pointer, this ensures
that it is initalised in all cases.
Andrew Bartlett
Reviewed by: Jeremy Allison <jra at samba.org>
commit 3d5c534f0cc7c6e3eead7462eef4a178c7035857
Author: Volker Lendecke <vl at samba.org>
Date: Tue Jan 8 15:34:19 2013 +0100
smbd: Fix bug 9549 -- Memleak in the async echo handler
Reviewed by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Jan 8 23:30:41 CET 2013 on sn-devel-104
commit eae01b0d3daf5bae9edada73669e3af879b000bb
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Dec 15 21:24:26 2012 +1100
samba-tool Add --service argument to samba-tool ntacl get/set
This also ensures a VFS connect is done to the correct service.
Andrew Bartlett
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Jan 8 03:39:21 CET 2013 on sn-devel-104
commit cef5f466af80406d9a1ce0b37d1ed1d237d59be1
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Dec 15 21:17:30 2012 +1100
pysmbd: Change to keyword based arguments
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 4741cda95668bee184cd2760848924fa4ad1e2bc
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Dec 14 22:17:23 2012 +1100
scripting-provision: Set sysvol ACLs on the sysvol share
This allows us to correctly load any modules that have been specified
by the smb.conf for [sysvol] and issue a VFS connect operation which
may be required by some VFS modules.
Andrew Bartlett
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0533905c5df2c0de4f2714df3e29ad90b48b1892
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Dec 14 22:09:18 2012 +1100
scripting-ntacls: Optionally allow the service to be specified.
Providing a service allows a VFS connect to be issued on the correct
service, and so ensures that the correct modules are loaded rather
than just what is specified in [globals].
Andrew Bartlett
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 813a3f0df91251dd7f920074ff8cd2b45bf48749
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 13:48:27 2012 +1100
pysmbd: Convert pysmbd to take an optional service to connect to
This uses create_conn_struct to correctly call VFS_CONNECT(), but only
if a service has been specified.
Andrew Bartlett
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5a3e915d20bb11984c42081bf25ce09baa58e04e
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Jan 8 09:29:48 2013 +1100
smbd: Fix calls to create_conn_struct_cwd to be correctly indented.
These are whitespace changes only, left out of the previous commit to preserve clarity.
Andrew Bartlett.
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6c80cf747d75e648a1d88d477bcf476e6874c4b3
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 13:47:49 2012 +1100
smbd: Split create_conn_struct into a fn that does not change the working dir
The python bindings do not want the current working directory changed
during operations, so we provide two functions, one providing the
original behaviour, and other providing the python bindings with just
the memory allocation and initilisation stuff.
Andrew Bartlett
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6a5afa244203c42265207c56e95783ec740ee89e
Author: Günther Deschner <gd at samba.org>
Date: Mon Jan 7 15:15:21 2013 +0100
spoolss: add stubs for new JobNamedProperty dcerpc calls.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Mon Jan 7 19:06:25 CET 2013 on sn-devel-104
commit 638ed90620e3c6a35ef56a11c612c13d6b7d6ff5
Author: Günther Deschner <gd at samba.org>
Date: Mon Jan 7 15:14:30 2013 +0100
spoolss: add SPOOLSS_DRIVER_VERSION_2012 (4) define to IDL.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 22994ca92ba92711e20da482292603927a82704e
Author: Günther Deschner <gd at samba.org>
Date: Mon Jan 7 15:14:02 2013 +0100
spoolss: add Windows ARM architecture defines to IDL.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit f2d67af7bc0b316f54d6cc1a44d07f1b24244378
Author: Volker Lendecke <vl at samba.org>
Date: Fri Dec 14 22:49:05 2012 +0100
tdb: Fix undefined prototype warnings
These functions are deliberately left without prototypes according to
3fdeaa399, but without prototypes we get warnings.
Reviewed-by: Rusty Russell <rusty at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Mon Jan 7 11:20:19 CET 2013 on sn-devel-104
commit 1beb4bc9d12fb124935e9e4710f48ad616dacc60
Author: Volker Lendecke <vl at samba.org>
Date: Wed Dec 26 21:42:14 2012 +0100
tdb: Fix \n in error messages
Reviewed-by: Rusty Russell <rusty at samba.org>
commit 94f11e9d168931018125a1552f22b786ba290dd0
Author: Andreas Schneider <asn at samba.org>
Date: Fri Dec 21 16:03:51 2012 +0100
s3-net: Fix rpc_service_list_internal() null pointer passing.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
Found by Coverity.
Autobuild-User(master): Günther Deschner <gd at samba.org>
Autobuild-Date(master): Wed Jan 2 14:19:50 CET 2013 on sn-devel-104
commit 9b0c1ab07c2c9a3fce1c49ad3d476ca1301182a4
Author: Andreas Schneider <asn at samba.org>
Date: Fri Dec 21 15:58:49 2012 +0100
s3-rpcclient: Fix cmd_eventlog_loginfo() null pointer passing.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
Found by Coverity.
commit 30e1dc08df8d891e1ab6e17d786a7a239417947f
Author: Andreas Schneider <asn at samba.org>
Date: Fri Dec 21 15:52:02 2012 +0100
s3-rpcclient: Fix cmd_eventlog_readlog() null pointer passing.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
Found by Coverity.
commit ab14918ea406eed2ed79c39dea7b855e4ecbac74
Author: Andreas Schneider <asn at samba.org>
Date: Fri Dec 14 16:54:55 2012 +0100
s3-idmap: Check return value of string_to_sid().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
commit 6cb7c4f45e1657245443c3bcc6dab219e5f1d9b5
Author: Samba-JP oota <ribbon at samba.gr.jp>
Date: Wed Jan 2 10:21:51 2013 +0100
docs: Fix typo in vfs_tsmsm.8.xml.
Reviewed-by: Karolin Seeger <kseeger at samba.org>
Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
Autobuild-Date(master): Wed Jan 2 12:12:12 CET 2013 on sn-devel-104
commit ab43e2db64ae3ef387ceb0e7e6a6f82c9e6d301d
Author: Samba-JP oota <ribbon at samba.gr.jp>
Date: Wed Jan 2 09:12:14 2013 +0100
docs: Remove superfluous bracket.
Reviewed-by: Karolin Seeger <kseeger at samba.org>
commit f77bfed088b93f3ed0f00d0c172ad495c6c2b09b
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Dec 15 10:18:08 2012 +0100
s4:drsuapi: try to behave more like windows for usn order (bug #9508)
We don't behave completely like a Windows server, but it's much more
identical than before.
The partition head is always the first object followed by the rest
sorted by uSNChanged.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Jan 1 21:09:42 CET 2013 on sn-devel-104
commit 16aef75c4f83c114206aa7637fedc9c2c2486877
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Dec 18 15:16:28 2012 +0100
s4:drsuapi: make use of LDB_TYPESAFE_QSORT() and pass getnc_state
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 88833b089a90e8f685d15b508f2e4615afb3a16f
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Dec 18 14:59:20 2012 +0100
s4:drsuapi: make sure we report the meta data from the cycle start (bug #9508)
We should build the final highwatermark and uptodatevector of
a replication cycle at the start of the cycle. Before we
search for the currently missing objects.
Otherwise we risk that some objects get lost.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 1f89d641d09ef983f6a5055bb75099dc0ce57aa8
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Dec 18 13:40:33 2012 +0100
s4:drsuapi: check the source_dsa_invocation_id (bug #9508)
The given highwatermark is only valid relative to the
specified source_dsa_invocation_id.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 91f7f2c04fd00e281b0755a331ca632a4905e3b5
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Dec 17 11:30:26 2012 +0100
s4:drsuapi: make sure we never return the same highwatermark twice in a replication cycle (bug #9508)
If the highwatermark given by the client is not the one we expect,
we need to start a new replication cycle. Otherwise the destination dsa
skips objects and linked attribute values.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 7e511b58318cef1b325a8191685ee156a7fc0cb7
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Dec 17 11:13:43 2012 +0100
s4:drsuapi: add drsuapi_DsReplicaHighWaterMark_cmp()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 02de5b140cfe6ea31e0686e5f0ff726a22153020
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Dec 17 16:34:25 2012 +0100
s4:drsuapi: always use the current uptodateness_vector
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 025c6d62f3c1b0f760aaacb7b3960135319031da
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Dec 18 12:44:43 2012 +0100
s4:drsuapi: avoid a ldb_dn_copy() and use talloc_move() instead
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 30be17bc5d6b3cf2ee0aef6663af78b153b2ab9a
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Dec 17 13:48:01 2012 +0100
s4:drsuapi: remove unused 'highest_usn' from drsuapi_getncchanges_state
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 551bb2ccea6a1d82dbe0d4a21c19a8d8bd13ccbc
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Dec 17 14:08:56 2012 +0100
s4:drsuapi: move struct drsuapi_getncchanges_state to the top of getncchanges.c
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 2e9b06412b09163d4b851135ef509d73bb6d61fc
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Dec 19 17:31:28 2012 +0100
s4:dsdb/drepl: update the source_dsa_obj/invocation_id in repsFrom
The highwatermark is relative to the source_dsa_invocation_id.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit e7a26d02413005294180a1d9cd4c90d4ac4d9733
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Dec 19 17:33:13 2012 +0100
s4:dsdb/common: use 01.01.1970 as last_sync_success for our entry in the uptodatevector
This matches a Windows 2008R2 and 2012 server.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 81fa179b155a62f2f652fbb1fc4978c9f6eb5462
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Dec 19 12:47:43 2012 +0100
s4:dsdb/common: use LDB_SEQ_HIGHEST_SEQ for our entry in the uptodatevector
We should use the global highestCommittedUSN, not the per partition value.
This matches a Windows 2008R2 and 2012 server.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 5ecbc892b5226d3d31da2c62ae5261a8d8a73072
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Dec 18 14:46:23 2012 +0100
s4:dsdb/repl_meta_data: don't merge highwatermark and uptodatevector (bug #9508)
We should not do any magic regarding the highwatermark we got from
the source dsa. We need to treat it as opaque and not try to be smart
and merge it into the uptodatevector.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ad43bb6086a7dbf48b405d0372ae85d2244384d9
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Dec 20 15:46:05 2012 +0100
s4:dsdb/repl_meta_data: also update the last_sync_success in replUpToDateVector
This matches Windows 2008R2 and Windows 2012.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 634f8cf7c43bd60507d842d35cf46c0017e34dce
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Dec 19 17:29:04 2012 +0100
s4:dsdb/repl_meta_data: store the last results and timestamps in the repsFrom
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit a37f46a9a83a03157276485eb583649b36fb6ee1
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Dec 18 14:46:23 2012 +0100
s4:dsdb/repl_meta_data: always treat the highwatermark as opaque (bug #9508)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 257ae5443631e645842cfcc9c1cedce6c41d5afa
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Dec 18 14:46:23 2012 +0100
s4:scripting/python: always treat the highwatermark as opaque (bug #9508)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit e2e2d72b0f373793458c0fda3d2ce28e2f3aea29
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Jan 1 15:43:57 2013 +0100
selftest/flapping: more samba4.rpc.samr.large-dc.two subtests are flakey
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Jan 1 18:47:42 CET 2013 on sn-devel-104
commit 6f318483709fd1fecd1a1ee1f892eb1c7ca17b94
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Jan 1 15:43:36 2013 +0100
Happy New Year 2013
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit bcacd8fc80f8b366566d576fd654856930cfc4a4
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Dec 26 22:11:13 2012 +0100
subunit: Update to latest upstream version.
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Thu Dec 27 21:08:32 CET 2012 on sn-devel-104
commit 983a3ea437d76b769b82726cc602d26e0e57894a
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Dec 26 22:11:04 2012 +0100
testtools: Update to latest upstream version.
commit 24957527e0250a9a5d4c51ff47db9ff2eb11ee7b
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Dec 27 16:09:39 2012 +0100
lib/param: use the correct path names again
This fixes a regression which was introduced by commit
5b1d95046c8ea624419d94dd7d9e2785ba86f556.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Thu Dec 27 19:19:55 CET 2012 on sn-devel-104
commit 3e28c29e6bd09bf0067ca6948aa3c538c055d4c5
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Dec 27 15:35:58 2012 +0100
selftest/flapping: mark samba4.rpc.samr.large-dc.two as knownfail
This is really flakey lately:
https://git.samba.org/autobuild.flakey/2012-12-27-1533/samba.stdout
...
https://git.samba.org/autobuild.flakey/2012-12-10-2338/samba.stdout
...
https://git.samba.org/autobuild.flakey/2012-12-09-0135/samba.stdout
...
https://git.samba.org/autobuild.flakey/2012-12-06-0333/samba.stdout
...
https://git.samba.org/autobuild.flakey/2012-12-05-0731/samba.stdout
...
https://git.samba.org/autobuild.flakey/2012-12-03-0334/samba.stdout
...
https://git.samba.org/autobuild.flakey/2012-12-02-1532/samba.stdout
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Thu Dec 27 17:36:07 CET 2012 on sn-devel-104
commit f2a6afb87e8b968681fbe0a178e76cddc680953f
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Sat Dec 15 22:16:28 2012 +0100
selftest.pl: Fix typo 'snprintf' -> 'sprintf'.
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Wed Dec 26 22:35:12 CET 2012 on sn-devel-104
commit e1a819ea18aa3ecfcddb76ec681f520db162338e
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Sun Dec 16 15:01:53 2012 +0100
wafsamba: python-config is not always a script.
commit c1fb37d7bec1dd720f3eccbd0b490b6a335ca288
Author: Jeremy Allison <jra at samba.org>
Date: Fri Dec 21 15:16:10 2012 -0800
Recent coverity changes added directory_create_or_exist() checks to many directories.
These may not be needed, but in the meantime - ensure "make test" works again
by chmod'ing the created test directories from 0777 to 0755.
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
Signed-off-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sat Dec 22 02:08:33 CET 2012 on sn-devel-104
commit b1548fd944578d845c5aaf88a528cf5a60df0c62
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 13 14:18:02 2012 +0100
s3-prefork: Directly fail if tevent_req_is_unix_error() fails.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
Autobuild-User(master): Günther Deschner <gd at samba.org>
Autobuild-Date(master): Fri Dec 21 15:38:19 CET 2012 on sn-devel-104
commit 93d2847bf4cc5d2fcdc95677d1cb1c515adc621c
Author: Andreas Schneider <asn at samba.org>
Date: Wed Dec 19 14:10:05 2012 +0100
s3-libsmb: Remove check if array is NULL.
rdata is an array with data. rdlength defines how big rdata is. So if
rdlength is not set we have a big problem.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 56eb4ab5f6280aa40c0e0edefad7f965b3f02a4a
Author: Andreas Schneider <asn at samba.org>
Date: Wed Dec 19 11:20:50 2012 +0100
s3-rpc_server: Fix username and remote check.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit bc3edaa6ad1a511075a97eab0bbb19a26b2288d2
Author: Andreas Schneider <asn at samba.org>
Date: Wed Dec 19 10:37:08 2012 +0100
s4-libcli: Use a do-while loop.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 9c273d5ca1810da8cf03a2af78b3fa5cbaaf2df7
Author: Andreas Schneider <asn at samba.org>
Date: Tue Dec 18 17:21:14 2012 +0100
s3-lib: Cleanup transfer_file_internal() a bit.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit e4649da0c72c3ec37c8a6a3920308f3ebcb1473e
Author: Andreas Schneider <asn at samba.org>
Date: Tue Dec 18 16:41:37 2012 +0100
libgpo: Make it clear that we want to fall trough here.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 53f54432831ba1c369beaed7d4ca95749eb2ee39
Author: Andreas Schneider <asn at samba.org>
Date: Tue Dec 18 16:39:40 2012 +0100
s4-dsdb: Make it clear that we want to fall trough here.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit ce25c484c12ce295820d64da0069ddcf45190825
Author: Andreas Schneider <asn at samba.org>
Date: Tue Dec 18 16:36:07 2012 +0100
s3-rpc_server: Make it clear we want to fall trough here.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 3f899daa9e32372daaed7729633a3325576f174a
Author: Andreas Schneider <asn at samba.org>
Date: Tue Dec 18 16:33:14 2012 +0100
s3-lib: Make it clear that we want to fall trough here.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 96de3e7364c6ca3c9184a1f920cf210565f4e78f
Author: Andreas Schneider <asn at samba.org>
Date: Tue Dec 18 16:31:36 2012 +0100
s3-netapi: Add missing break in NetUserSetInfo_r().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit f7d8aa79ff508dec519c493fcdcaa908cdc86670
Author: Andreas Schneider <asn at samba.org>
Date: Tue Dec 18 16:06:19 2012 +0100
s3-libsmb: Fix a possible null pointer dereference.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit fd6041a22065613de6746d0058ac1ae42b84b3b7
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 17 17:46:34 2012 +0100
s3-rpc_server: Fix null pointer derefs in rpc_pipe_open_interface().
Found by Coverity and asn ;)
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 6168d95817ebcde746f6cf8fa4da937fff7d80b3
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 17 17:18:14 2012 +0100
s3-winbind: Fix null pointer dereference in store_memory_creds().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 9631e5b1e490349dd59f0772ecba11be9f2ba963
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 17 15:36:32 2012 +0100
s3-vfs: Fix a null pointer deferference in vfs_media_harmony.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 72e02c73b64f1ff56b2d53ec63d68486a4f1ff90
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 17 15:31:21 2012 +0100
s3-rpc_server: Fix a possible null pointer dereference.
This variable can be set to NULL in an earlier function call.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit f0454ffb69d93daafd350e6021f953586c5374bd
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 17 15:21:10 2012 +0100
s3-vfs: Fix typo in readonly_connect().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 3bf3ab4f648f48c703d491ba2a883a1895960dbd
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 17 15:17:45 2012 +0100
libcli: Fix smb2cli_ioctl_send() if clause.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit f8a5abf960f40673a5113cc6820a68eb01662d3e
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 17 14:17:59 2012 +0100
libwbclient: Fix null check in process_domain_info_string().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit b26a9eae1648ecfa9912aa8ce81e0f0ea674ca53
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 17 14:40:17 2012 +0100
s3-rpc_server: Fix useless check if we still have a valid string.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit d0e20998a232b793d3e5db7dff70c84d11d2c527
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 17 14:33:45 2012 +0100
s3-libads: Fix copy&paste error in ads_keytab_add_entry().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 3bd8c7dec60a26743e889df61c862516eb5bdcc3
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 17 14:25:31 2012 +0100
s3-lib: Fix push_ucs2() for-loop.
ret is a bool and size is what we are looking for here, else the
statement can never be true.
Jeremy please check!
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 7f8c8d80ef6553dc28f0bf6d9aa7a2c46ab55529
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 17 14:21:01 2012 +0100
s3-tldap: Fix dead code in tldap_sasl_bind_send().
dn can't be NULL cause it is set to "" in that case.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 7937a6afcbe38af271894364a44abd55207ba83b
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 17 14:08:59 2012 +0100
s4-librpc: Remove dead code in smb_send_request().
If trigger_read we return earlier.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 568bade612f1969ed92e9fe4d04088b08545ad8b
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 17 14:03:50 2012 +0100
krb5_wrap: Remove dead code in smb_krb5_renew_ticket().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 24a897f029dd92a6341ef29e99291c01be928650
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 17 10:39:10 2012 +0100
nsswitch: Fix wbclient BAIL macros.
In the code you normally use:
BAIL_ON_WBC_ERROR;
but the last ; is statement never reached, so dead code.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 9981b857a5cfba3d55e25541afcfe1fda1bc4338
Author: Andreas Schneider <asn at samba.org>
Date: Fri Dec 14 18:21:26 2012 +0100
libcli: Check schannel state return value of tdb_transaction_commit().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit e41f0ccdd280f18e3b4f72f1f20cd768c4572427
Author: Andreas Schneider <asn at samba.org>
Date: Fri Dec 14 18:14:34 2012 +0100
s3-utils: Check return value of secrets_init().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 15c0594feeed89b66d869bbfaf75f9af38269c33
Author: Andreas Schneider <asn at samba.org>
Date: Fri Dec 14 18:07:10 2012 +0100
s3-net: Check return values of push_reg_sz().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 5b1d95046c8ea624419d94dd7d9e2785ba86f556
Author: Andreas Schneider <asn at samba.org>
Date: Fri Dec 14 17:54:13 2012 +0100
param: Correctly create directory and create common function.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 426bcdb37c05bd5b6ceae34a03b9dbabbf6e9727
Author: Andreas Schneider <asn at samba.org>
Date: Fri Dec 14 17:43:36 2012 +0100
librpc: Check return codes of ndr functions.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 4d02e868f6ad35a408d011e888fba5618bd0c6d9
Author: Andreas Schneider <asn at samba.org>
Date: Fri Dec 14 17:09:34 2012 +0100
ndr: Check return code of ndr_pull_advance().
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit e3eaeb942b0a0eaee810c1d5f719854745e0dc4c
Author: Andreas Schneider <asn at samba.org>
Date: Fri Dec 14 17:02:48 2012 +0100
s4-libnet: Checkr return codes in samsync_ldb_handle_domain().
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 3000fc29c373f7fcc59f4de443f209f377dbd4f6
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 13 18:16:34 2012 +0100
s3-nmbd: Check if we created the directories correctly.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 6fd4724fb95cda3adfee37b6bde7e526e423083d
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 13 17:50:55 2012 +0100
s3-eventlog: Make sure the eventlog directory exists.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit ae6947cc48d032ad8af76f8a9e3dbae6a074d10e
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 13 17:48:45 2012 +0100
s4-regsitry: Check return value of ldb_msg_add_empty().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit a3bbf1bf3460034028516c1c0fced01db0cecd0c
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 13 17:29:39 2012 +0100
s3-winbind: Check if we created the directories correctly.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit e136b95af82e200dfc28dd3e48e05c210862f906
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 13 16:10:38 2012 +0100
s4-lib: Use directory_create_or_exist() to create messaging dir.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 3dda9177708df4d3f2451d23a186b03a856aba87
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 13 14:26:40 2012 +0100
s3-smbd: Check return code of SMB_VFS_{L}STAT.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 8631a9090bd22f5ce3036dd596a213dd9d8a67c4
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 13 14:11:29 2012 +0100
s4-client: Check return codes in do_connect().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit a444bb95a270ca5b331041c11a7e785c1e0559b7
Author: Volker Lendecke <vl at samba.org>
Date: Fri Dec 14 16:07:11 2012 +0100
tdb: Add a comment explaining the "check"
I had to ask git blame to find why we have to do it here...
Reviewed-by: Rusty Russell <rusty at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Fri Dec 21 13:54:39 CET 2012 on sn-devel-104
commit 3109b541c9b2f0063e1ccb0cdaec0a8e388b29b4
Author: Volker Lendecke <vl at samba.org>
Date: Fri Dec 14 15:53:08 2012 +0100
tdb: Make tdb_new_database() follow a more conventional style
We usually "goto fail" on every error and then in normal flow set the
return variable to success. This patch removes a comment which from my
point of view is now obsolete. It violates the {} rule from README.Coding
here in favor of the style used in this function.
Reviewed-by: Rusty Russell <rusty at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit d972e6fa74b6499403d4c3d3c6a84cbda7eded39
Author: Volker Lendecke <vl at samba.org>
Date: Fri Dec 14 14:50:08 2012 +0100
tdb: Fix a typo
Reviewed-by: Rusty Russell <rusty at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit c04de8f3a4deba0062f8cdbcbe74d3735a80b735
Author: Volker Lendecke <vl at samba.org>
Date: Fri Dec 14 14:48:31 2012 +0100
tdb: Fix a typo
Reviewed-by: Rusty Russell <rusty at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 24755d75b0ee7170195bc26cf28bab4ffdb6f752
Author: Volker Lendecke <vl at samba.org>
Date: Fri Dec 14 09:24:06 2012 +0100
tdb: Use tdb_lock_covered_by_allrecord_lock in tdb_unlock
Reviewed-by: Rusty Russell <rusty at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit f8dafe5685008671f4f983a4defc90b4a05cf992
Author: Volker Lendecke <vl at samba.org>
Date: Fri Dec 14 09:21:42 2012 +0100
tdb: Factor out tdb_lock_covered_by_allrecord_lock from tdb_lock_list
Reviewed-by: Rusty Russell <rusty at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 26b8545df44df7e60ba0ba7336ffbdda8a14e423
Author: Volker Lendecke <vl at samba.org>
Date: Thu Dec 13 22:14:34 2012 +0100
tdb: Simplify logic in tdb_lock_list slightly
Reviewed-by: Rusty Russell <rusty at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 0f4e7a1401998746a6818b9469ab369d70418ac1
Author: Volker Lendecke <vl at samba.org>
Date: Thu Dec 13 21:58:00 2012 +0100
tdb: Slightly simplify tdb_lock_list
Avoid an else {} branch when we can do an early return
Reviewed-by: Rusty Russell <rusty at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 116ec13bb0718eb1de1ac1f4410d5c33f1db616f
Author: Volker Lendecke <vl at samba.org>
Date: Thu Dec 13 13:31:59 2012 +0100
tdb: Fix blank line endings
Reviewed-by: Rusty Russell <rusty at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 7237fdd4ddc0b9c848b5936431b4f8731ce56dba
Author: Volker Lendecke <vl at samba.org>
Date: Fri Dec 14 08:01:12 2012 +0100
tdb: Fix a comment
Reviewed-by: Rusty Russell <rusty at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit d2b852d79bd83754d8952a0e3dece00e513549f2
Author: Volker Lendecke <vl at samba.org>
Date: Thu Dec 13 12:36:29 2012 +0100
tdb: Fix a typo
Reviewed-by: Rusty Russell <rusty at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 2c3fd8a13e7dde23a23404cd88078a04c8b338ea
Author: Volker Lendecke <vl at samba.org>
Date: Tue Dec 11 21:04:58 2012 +0100
tdb: Fix a missing CONVERT
methods->tdb_write expects data in on-disk format. For reading that
record, methods->tdb_read() has taken care of the on-disk to in-memory
representation according to the DOCONV() flag passed down. tdb_rec_write()
is a wrapper around methods->tdb_write just doing the CONVERT() on the
way to disk.
Reviewed-by: Rusty Russell <rusty at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 2148d86c7a2facd6e128b753aef98722843af3e1
Author: Jeremy Allison <jra at samba.org>
Date: Fri Dec 14 08:39:26 2012 -0800
Fix bug #9196 - defer_open is triggered multiple times on the same request.
get_deferred_open_message_state_smb2() is buggy in that it is checking
the wrong things to determine if an open is in the deferred state.
It checks if (smb2req->async_te == NULL) which is incorrect,
as we're not always async in a deferred open - remove this.
It should check instead state->open_was_deferred as this
is explicity set to 'true' when an open is going deferred,
so add this check.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Dec 18 14:19:13 CET 2012 on sn-devel-104
commit d8461992dbc6005f02240cf1eae8a56ba4c55148
Author: Günther Deschner <gd at samba.org>
Date: Tue Dec 11 23:53:22 2012 +0100
s4-rpc_server: use netlogon_creds_encrypt_samlogon().
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Günther Deschner <gd at samba.org>
Autobuild-Date(master): Sun Dec 16 01:34:01 CET 2012 on sn-devel-104
commit be43456c94d0ed3786020223aac31e1908028caf
Author: Günther Deschner <gd at samba.org>
Date: Tue Dec 11 23:52:59 2012 +0100
s3-rpc_server: use netlogon_creds_encrypt_samlogon().
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 301f69b0ca72e55556ac2c7b5fbf940821b41766
Author: Günther Deschner <gd at samba.org>
Date: Fri Dec 14 14:18:40 2012 +0100
libcli/auth: add netlogon_creds_encrypt_samlogon_validation().
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 563cc67ac65c2061971c4b02ac7037e00f1f9ae8
Author: Günther Deschner <gd at samba.org>
Date: Fri Dec 14 14:17:22 2012 +0100
libcli/auth: rename netlogon_creds_decrypt_samlogon() to netlogon_creds_decrypt_samlogon_validation().
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 6127ba853b8288be60adc70bc0ea084f26e216f7
Author: Ricky Nance <ricky.nance at weaubleau.k12.mo.us>
Date: Thu Dec 13 20:52:46 2012 -0600
s3fs: make the log warning go away
standard input is not a socket, assuming -D option
Signed-off-by: Jelmer Vernooij <jelmer at samba.org>
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Sat Dec 15 17:50:23 CET 2012 on sn-devel-104
commit d4c3f54bbf6053783a221da84b5dbf249cdf05e7
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 26 06:55:04 2012 -0800
tdr: Strip trailing whitespace.
commit 229d934d2fb653e02b38d242bf01f199434cd1f3
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 6 14:45:24 2012 +0100
s4-libnet: Fix setting the group handle and return codes.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
Autobuild-User(master): Günther Deschner <gd at samba.org>
Autobuild-Date(master): Thu Dec 13 01:01:14 CET 2012 on sn-devel-104
commit bdc2f4bd91c3eb0ce0fa87d2d21668e064b106b6
Author: Andreas Schneider <asn at samba.org>
Date: Wed Dec 12 19:15:58 2012 +0100
util: Remove unused fde_stdin in samba_runcmd.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 74fb61d496348391a324fc69bb7b167597939d5b
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 6 11:11:15 2012 +0100
s3-lib: Don't close the listener twice if we goto failed.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit a44e58a31ebecd6f467ffdac6645ffe6a313e9c6
Author: Volker Lendecke <vl at samba.org>
Date: Wed Dec 12 12:55:45 2012 +0100
s3: Fix a typo in a debug message
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
Autobuild-User(master): Günther Deschner <gd at samba.org>
Autobuild-Date(master): Wed Dec 12 16:40:23 CET 2012 on sn-devel-104
commit 880b0f18bede936bafb806669ee4d160567e90bb
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 10 17:52:50 2012 +0100
s3-printing: Correctly create the printing cache path.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 76ac4d923d7ea07ab13190217359ce283e925fac
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 10 17:45:15 2012 +0100
s3-registry: Fix counters_directory() dir creation.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 7dd13503c0919766ecf3c8f5f48cda72aae8ac73
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 10 17:14:12 2012 +0100
s4-socket: Make sure unix socket addresses are null terminated.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 07385a851f6c07c9f8ef4414d8483de7106ee486
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 10 17:07:24 2012 +0100
s3-ctdb: Make sure addr.sun_path is null terminated.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit ef0a945bf8e6310acb41f90a2179e61d412a61ea
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 10 17:06:39 2012 +0100
torture: Make sure we use the correct size for cxd.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit b4884dcff7362d585d93c3acf08e8c4835d918d0
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 10 15:11:23 2012 +0100
s3-libsmb: Fix possible comparsion problems.
This makes the code also easier to understand.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit b4accd365d4758f3f4453083c24c59615051d863
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 10 15:02:43 2012 +0100
s4-libcli: Fix comparison of chosen_oid.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit f670cae69d85a8bfc14ab7d9cd38ab0e568e6929
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 10 14:06:32 2012 +0100
s3-utils: Correctly handle getenv() for the later system() call.
The returned string of getenv() has an unknown size. You need to store
the result always in a char array with a certain size to make sure we
don't feed tainted data to the next function call.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 34a18865d6d2acd05e93fc728510896e69449d79
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 6 18:04:41 2012 +0100
s4-client: Make sure we have a valid count if we goto cleanup.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit d55c6e7113efb9214f606dd183e5214a03f6dcae
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 6 15:40:29 2012 +0100
s3-utils: Cleanup code in wait_replies().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 1dc414e4d22e5d8c77aba2100b6c6c2e3effc00c
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 6 15:28:03 2012 +0100
nsswitch: Fix pam_get_{item,data} build warnings.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit de22df1419d205a5baf1ad1a4779ef2afe51f0f9
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 6 15:16:52 2012 +0100
nsswitch: Remove unused variable in _pam_winbind_change_pwd().
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit b8ed2efb50b4a689e02b86d4c626d96ee7b2717f
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 6 15:14:07 2012 +0100
nsswitch: Cleanup code in parse_wbinfo_domain_user().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit af18339e037e388ddac4a417544c295bcc44b31d
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 6 15:11:09 2012 +0100
s4-libnet: Don't call talloc_get_type() for the same struct twice.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 3bcd14c3970f3be58d8f0d802b905c64661173a6
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 6 15:06:06 2012 +0100
s3-nmbd: Cleanup code to make it more readable.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit e5deaa29689ca53b5ba96836ff787281fdba06f1
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 6 14:35:48 2012 +0100
s3-lib: Remove unsused variable from sys_get_nfs_quota().
testpath is the same a few lines later.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 62646b7666178bf03cd650056a61338e84b54b25
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 6 11:40:35 2012 +0100
winbind: Use talloc in resolve_username_to_alias().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit d862bbd5dcffa3f1cb8e774724132a39b55dbd9f
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 6 11:24:17 2012 +0100
winbind: Use talloc in resolve_alias_to_username().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit c9053796b389758e8bacff4cd37d633fd65171f9
Author: Andreas Schneider <asn at samba.org>
Date: Tue Dec 11 17:11:58 2012 +0100
tdb: Improve the documentation of tdb_reopen() and tdb_close().
Reviewed-by: Simo Sorce <idra at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Wed Dec 12 14:58:50 CET 2012 on sn-devel-104
commit 7f08365a28770fdcc1bb625d8a16d11d8f15c29a
Author: Andreas Schneider <asn at samba.org>
Date: Tue Dec 11 16:51:01 2012 +0100
tdb: Fix possible crash bugs in the python tdb code.
You can't call tdb_error() for tdb_reopen() or tdb_close(), both return
the error code of close(2) and not a TDB_ERROR!
Reviewed-by: Simo Sorce <idra at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit d07a964fe25caaf796449fda9beda600990be650
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 6 15:06:57 2012 +0100
misc: Add a config for clang complete.
See https://github.com/Rip-Rip/clang_complete
commit 34ac9d878687443c40e9df9941f45d9bc6040529
Author: Günther Deschner <gd at samba.org>
Date: Tue Dec 11 16:43:12 2012 +0100
s4-selftest: make sure to test rpc.samr.passwords.validate over ncacn_ip_tcp.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Wed Dec 12 13:13:47 CET 2012 on sn-devel-104
commit 6a59126d591b3a9f6a7c505cb8973b826f5cc0b0
Author: Günther Deschner <gd at samba.org>
Date: Tue Dec 11 16:42:53 2012 +0100
s3-selftest: make sure to test rpc.samr.passwords.validate over ncacn_ip_tcp.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 4fd7aaf2b148fff7d5efc15e9f1923bf56b5b54a
Author: Günther Deschner <gd at samba.org>
Date: Tue Dec 11 14:43:07 2012 +0100
s4-rpc_server: limit allowed transports for samr_ValidatePassword().
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit c9055a0be444260ddbf44eb13007399bf7dff5e1
Author: Günther Deschner <gd at samba.org>
Date: Tue Dec 11 14:41:34 2012 +0100
s3-rpc_server: limit allowed transports for samr_ValidatePassword().
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit f22efd402adf61842dd0a97e462a097e80d878a4
Author: Günther Deschner <gd at samba.org>
Date: Tue Dec 11 09:25:53 2012 +0100
s4-torture: move samr_ValidatePassword test out of main samr test.
Makes it easier to call with ncacn_ip_tcp transport (Windows does not allow
other transports).
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 014512f56478152972c7cae75e872a48ea18c91d
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 6 14:37:21 2012 +0100
dfs_server: Don't allocate a subcontext twice.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
Autobuild-User(master): Günther Deschner <gd at samba.org>
Autobuild-Date(master): Wed Dec 12 11:28:39 CET 2012 on sn-devel-104
commit ac434c4223ba7a7cbbd97a59e305445a22a32c76
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 6 16:02:57 2012 +0100
util: Don't use the pid ret value uninitialized.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit f1fe877d07d6b1d04e9bbbec558bad90a855ae95
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 6 17:04:47 2012 +0100
s3-netapi: Initialize group_handle of NetGroupSetUsers_r().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit 7d20934693174deac1f94a250ee9a2d39a7a8c8c
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 6 18:06:59 2012 +0100
s4-netapi: Initialize group_handle of NetGroupGetUsers_r().
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit 5bc5761c06decc6b1fadff5f246c820e1db3fed3
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 6 18:13:23 2012 +0100
s3-auth: Make sure we work on valid data_blobs.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit d020c51978727185803edc5575adaf485b6e894e
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 6 18:15:12 2012 +0100
s3-netapi: Initialize group_handle of NetUserSetGroups_r.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit dc9fa1a026e9cd543a53b9ca72b0c52e1740c2e4
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 10 13:22:52 2012 +0100
torture: Fix torture_rpc_spoolss_printer_teardown_common().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit 33d1d525080297686f60b46661b0b4021d31199b
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 10 13:24:46 2012 +0100
s3-netapi: Fix zeroing policy handles in NetLocalGroupAdd_r().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit 4c0b4894d58094f95d8f053651104521e46da4ec
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 10 13:35:27 2012 +0100
vfs: Make sure we don't call talloc_free on an uninitialized pointer.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit e039676fe2c2fe5c7ef53e1e58487dd048e37013
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 10 13:42:37 2012 +0100
s3-printing: Don't call talloc_free on an uninitialized pointer.
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit c83f9330a40fc53ec4cbfdfcafa2a95eae4cf7fa
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 10 15:48:28 2012 +0100
idl: Fix spoolss check for the size of the struct.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit e4e3293b482d48bc6a503e1280fe2a20556548ef
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 10 17:36:39 2012 +0100
s3-net: Check the return value of strlower_m().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit f70c56b74769711e358860655bbb5c2329ad005b
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 10 17:39:03 2012 +0100
s3-net: Check return value of string_to_sid().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit 785cc6f3f3b5fe0deae4352dbbb2cfe76257f47d
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 10 17:41:46 2012 +0100
s3-rpcclient: Check return value of add_string_to_array().
Found by Coverity.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit ff32391808322029a8d6caa9fdf1a4d253d9b1ff
Author: Andreas Schneider <asn at samba.org>
Date: Mon Dec 10 17:47:15 2012 +0100
s3-registry: Check return code of push_reg_sz().
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit 0f75d9274cff7095dfab251307231a5a911f0c8d
Author: Jeremy Allison <jra at samba.org>
Date: Mon Dec 10 13:22:10 2012 -0800
s3:auth: Tidy up some of the API confusion in create_token_from_XXX() calls.
Based on Michaels example, split out the return of NT_STATUS_NO_MEMORY
on talloc fail from other possible errors. Allow the NTSTATUS return
to be the only valid indication of success in these calls.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Tue Dec 11 20:04:25 CET 2012 on sn-devel-104
commit a20c47410fb74716c0c8b2583fd4d0ae0145fd7d
Author: Michael Adam <obnox at samba.org>
Date: Tue Dec 11 18:05:31 2012 +0100
s3:auth: fix dereference level in talloc checks in create_token_from_sid()
Commit c5b150b33fc54ed97dbd0736cc6f4c15977d6e70 introduced these checks.
The current check "found_username == NULL" is wrong (we would segfault earlier
in this case). We need to check *found_username == NULL instead as
noted by Günter.
Reported-by: Günter Kukkukk <linux at kukkukk.com>
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 9ee3343529d2897e900b8824e49b253cfc53bff9
Author: Michael Adam <obnox at samba.org>
Date: Tue Dec 11 16:13:39 2012 +0100
selftest: skip the samba4.rpc.samr.passwords test in ncacn_np(dc) and s4member environments
These currently fail in a corner case.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Karolin Seeger <kseeger at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Dec 11 17:56:01 CET 2012 on sn-devel-104
commit 498f98f126de6da5aff7f054a85270f315c7a400
Author: Michael Adam <obnox at samba.org>
Date: Tue Dec 11 13:34:49 2012 +0100
s4:torture:rpc:samr: fix password age calculation in test_ChangePasswordUser3()
The min_password_age field is the negative of the age.
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit 1a4adcfcb31a06fe3eae4e78a502cbfaa092587e
Author: Michael Adam <obnox at samba.org>
Date: Tue Dec 11 13:21:11 2012 +0100
s4:torture/samr: allow STATUS_PASSWORD_RESTRICTIONS from ChangePasswordUser
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit ce895609b04380bfc41e4f8fddc84bd2f9324340
Author: Michael Adam <obnox at samba.org>
Date: Tue Dec 11 13:18:00 2012 +0100
s4:rpc_server/samr: do WRONG_PASSWORD checks after the complexity checks
This matches the windows behavior.
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit da066ec1d7b1284461ad907a35a94f30819ecbdc
Author: Michael Adam <obnox at samba.org>
Date: Tue Dec 11 13:04:22 2012 +0100
s4:dsdb/password_hash: do the min password age checks first
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit 7c6b10fbb05eaa6075f01a4b4f8fb60f42d2dfa7
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Dec 10 23:56:47 2012 +0100
s4:dsdb/common: only pass the DSDB_CONTROL_PASSWORD_HASH_VALUES_OID if required
This should give the password_hash module a chance to detect if the called
was the cleartext password or not.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 18a306e2f2d90f6d0c7b5d82272a69d72510ed7c
Author: Michael Adam <obnox at samba.org>
Date: Tue Dec 11 11:42:11 2012 +0100
s4:torture:rpc:samr: add debugging of result of (many) dcerpc_samr_* calls
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit 48ac5842dd9f13619d652af1dfe1b04dc79ada7d
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 23 11:49:05 2012 +0100
s4:dsdb/password_hash: Honor password complexity settings.
Honor password complexity settings when creating new users.
Without this patch, you could set simple passwords although the complexity
settings were enabled. This was an issue with 'samba-tool user add' and also
when adding new users via Windows' "Active Directory Users and Computers"
MMC Snap-In.
The following scenarios were tested successfully after applying the patch:
-'samba-tool user add' against s4
-'samba-tool user add -H' against a Windows DC
-Adding a new user on a s4 DC using Windows' "Active Directory Users and
Computers" MMC Snap-In.
Please note that this bug was caused by a mistake in the documentation.
Fix bug #9414 - 'samba-tool user add' ignores password complexity settings.
Pair-programmed-with: Karolin Seeger <kseeger at samba.org>
Pair-Programmed-With: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit a5e6b05edc924bcf7859e5d6b74937ac54347a08
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Dec 11 13:08:28 2012 +0100
Revert "s4:dsdb/password_hash: Honor password complexity settings."
This reverts commit f8056b7a6998e002f473b0ad79eee046236a7032.
A better fix will follow.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 914a61d9e5b7a182592f3afe60f4dad1cd342fc4
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Dec 11 03:15:26 2012 +0100
s4:provision: set the correct nTSecurityDescriptor on CN=Domain Controllers,... (bug #9481)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Dec 11 07:05:39 CET 2012 on sn-devel-104
commit 8eb359c23c6379be1ccc32e27fd2316d77a7c7b3
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Dec 11 03:15:26 2012 +0100
s4:provision: set the correct nTSecurityDescriptor on CN=Users,... (bug #9481)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 19b03834f08c2a6645a31fe18121534c692c18d1
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Dec 10 11:32:07 2012 +0100
s4:provision: set the correct nTSecurityDescriptor on CN=Computers,... (bug #9481)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e1301fef735b305736db0b6db335c37aa9fea832
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Dec 10 11:32:07 2012 +0100
s4:provision: set the correct nTSecurityDescriptor on CN=Builtin,... (bug #9481)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit ebb0a88722d416ad470497fd6ffa7b26abfe58bc
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Dec 10 11:32:07 2012 +0100
s4:provision: set the correct nTSecurityDescriptor on CN=Infrastructure,... (bug #9481)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 999c068113af6158355634eb9a9c4b5a4d3066d8
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Dec 10 11:32:07 2012 +0100
s4:provision: set the correct nTSecurityDescriptor on CN=Sites,CN=Configuration... (bug #9481)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 649fb5b61492562f1400996a6ccf33af17af5b6b
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Dec 10 11:32:07 2012 +0100
s4:provision: set the correct nTSecurityDescriptor on CN=Partitions,CN=Configuration... (bug #9481)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit a97b5f219678e409a851d9caf8317a6ef130c12f
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Dec 11 02:01:12 2012 +0100
s4:dsdb/descriptor: pass object_list to create_security_descriptor()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit d20c46a520a7e39dd87476cd81edab56b5543892
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Dec 11 03:17:42 2012 +0100
libcli/security: calculate the correct inherited_object GUID
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 75729e6703c5b5dff7feefed590086898fc03c74
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Dec 11 02:00:38 2012 +0100
libcli/security: implement object_in_list()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 1d949cb0e51a086006612271d6f08305b68aa09c
Author: Michael Adam <obnox at samba.org>
Date: Mon Dec 10 21:56:42 2012 +0100
s3:auth: fix function header comment for user_sid_in_group_sid()
This is embarrassing: the commit 0770a4c01bef26ec51321cd5b97aea4eab9e00a8
which intended to fix an earlier copy'n'paste error, contained another
typo, fixed with this commit...
Signed-off-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Tue Dec 11 00:04:45 CET 2012 on sn-devel-104
commit cbc6a2f5e41100a12f03838396d652af5f6c105d
Author: Michael Adam <obnox at samba.org>
Date: Mon Dec 10 16:58:43 2012 +0100
pidl: change strange spelling __donnot_use_enum_* to __do_not_use_enum_*
Signed-off-by: Michael Adam <obnox at samba.org>
commit c5b150b33fc54ed97dbd0736cc6f4c15977d6e70
Author: Michael Adam <obnox at samba.org>
Date: Mon Dec 10 15:06:27 2012 +0100
s3:auth: fix create_token_from_sid() to not fail in the winbindd case
Commit 1c3c5e2156d9096f60bd53a96b88c2f1001d898a which factored
the sid-based variant out of create_token_from_username() broke
the case of a user handled by winbindd in that the "found_username"
was set to NULL which caused the function to fail with
NT_STATUS_NO_MEMORY further down.
This patch fixes the function so that the case of found_username == NULL
is cleanly separated from the NO_MEMORY case and the caller can provide
the username in this case, if required.
This fixes bug #9457.
Signed-off-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Mon Dec 10 18:18:54 CET 2012 on sn-devel-104
commit 0770a4c01bef26ec51321cd5b97aea4eab9e00a8
Author: Michael Adam <obnox at samba.org>
Date: Mon Dec 10 14:48:43 2012 +0100
s3:auth: fix header comment for user_sid_in_group_sid()
This function was created in 1c3c5e2156d9096f60bd53a96b88c2f1001d898a
and the header comment contained copy'n'paste errors from the original
function user_in_group_sid() that took the user name.
Signed-off-by: Michael Adam <obnox at samba.org>
commit 53b736444d55c4eed3abbc34974b655cc2607cd6
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Dec 7 18:58:57 2012 +0100
s4:dsdb/tests/sec_descriptor: verify the search of a windows dc join keeps working
This is a regression test for bug #9470.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Mon Dec 10 15:41:12 CET 2012 on sn-devel-104
commit e617a3fecb797031cf5a6545d51d7e116716ab52
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Dec 6 14:04:47 2012 +0100
s4:dsdb/tests/sec_descriptor: verify the nTSecurityDescriptor and sd_flags interaction
This is a regression test for bug #9470.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 6bc2caed8b3f153f92af013275f39c803f886a22
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Dec 6 15:56:26 2012 +0100
s4:dsdb/operational: fix stripping of the nTSecurityDescriptor attribute
If the sd_flags control is specified, we should return nTSecurityDescriptor
only if the client asked for all attributes.
If there's a list of only explicit attribute names, we should ignore
the sd_flags control.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 22bb2fd868b8df2244b801aeaa515a8a4036bce8
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Dec 6 12:36:09 2012 +0100
s4:dsdb/acl_read: return the nTSecurityDescriptor attr if the sd_flags control is given (bug #9470)
Not returning the nTSecurityDescriptor causes a lot of problems.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 4f8558ffaf4c9fb9e350ec528ec1ce60de5f2e24
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Dec 6 12:29:49 2012 +0100
s4:dsdb/acl_read: give some variables a better name
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit db15fcfa899e1fe4d6994f68ceb299921b8aa6f1
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Dec 7 18:40:25 2012 +0100
s4:dsdb/acl_read: fix the calculation of the attribute array for the sub search
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e2181617a00d7982e4e6ced1c51aa2ee8a40df26
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Dec 7 18:39:29 2012 +0100
s4:dsdb/acl_read: check the ldb_attr_list_copy_add() result
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 6bcafceb750d5c4d24e2ddbef35b411bebccd66f
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Dec 7 19:02:10 2012 +0100
s4:dsdb/dirsync: fix potential talloc hierachy problems (bug #9470)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit ade5bfd304cc806758a58f04b35834cd730dd9ba
Author: Günther Deschner <gd at samba.org>
Date: Fri Dec 7 12:51:10 2012 +0100
s4-torture: call the s4u2self tests with arcfour and aes.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Sun Dec 9 21:24:44 CET 2012 on sn-devel-104
commit d0bad6c3350698b26ba009bb0c91d0265cc22f60
Author: Günther Deschner <gd at samba.org>
Date: Fri Dec 7 12:57:18 2012 +0100
s4-torture: precalculate expected session keys from samlogon in schannel test.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit f6cb8049b2fe62054d254a006b8a39f000d1d1d5
Author: Günther Deschner <gd at samba.org>
Date: Fri Dec 7 12:38:16 2012 +0100
libcli/auth: support AES decryption in netlogon_creds_decrypt_samlogon().
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit be296a21fc509cacaedb5aad0c3ca4ccd44b4a62
Author: Günther Deschner <gd at samba.org>
Date: Fri Dec 7 01:05:00 2012 +0100
libcli/auth: remove trailing whitespace.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit f2d9589b178c0e3374e1c1ad363639b9e2bdce5f
Author: Günther Deschner <gd at samba.org>
Date: Thu Dec 6 15:21:02 2012 +0100
s3-auth: remove crypto from serverinfo_to_SamInfoX calls.
All crypto is dealt with within the netlogon samlogon server now.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit c1fb595081c2b0bf66bce06c09750f53e8031311
Author: Günther Deschner <gd at samba.org>
Date: Thu Dec 6 14:54:25 2012 +0100
s3-rpc_server: Remove obsolete process_creds boolean in samlogon server.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 7f435bd649f0b313804f40807a38de9478478b6c
Author: Günther Deschner <gd at samba.org>
Date: Thu Dec 6 14:31:32 2012 +0100
s3-auth: session keys in validation level 6 samlogon replies are *not* encrypted.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 645289216eeb718eab1201dd3ad0a50fdf85753c
Author: Günther Deschner <gd at samba.org>
Date: Wed Dec 5 19:49:52 2012 +0100
s3-rpc_server: support AES for interactive netlogon samlogon password decryption.
Still need to fix AES support for the returned validation info.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 71572632bd33dcb5c03a701bbb72a707e5642237
Author: Günther Deschner <gd at samba.org>
Date: Wed Dec 5 16:24:24 2012 +0100
s4-rpc_server: support AES encryption in interactive and generic samlogon.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit a52115ce67c2e5bd1e478d7601483fd2490aea31
Author: Günther Deschner <gd at samba.org>
Date: Wed Dec 5 19:52:54 2012 +0100
s3-rpc_server: we need to encrypt OWFs using DES in _netr_ServerGetTrustInfo().
Sumit, please check.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 6aec126566d01dd9ddbbd5488f73b61729094a52
Author: Günther Deschner <gd at samba.org>
Date: Wed Dec 5 18:06:54 2012 +0100
s4-torture: validate owf password hash and negotiate AES in forest trust test.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 83b00afe9f2116ef04378c251070143595450a3e
Author: Günther Deschner <gd at samba.org>
Date: Wed Dec 5 17:59:12 2012 +0100
s4-torture: validate owf password hash and negotiate AES ServerGetTrustInfo test.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 306a78d97f2fdfaa81c58bafdebcfab0fb8f1636
Author: Günther Deschner <gd at samba.org>
Date: Wed Dec 5 16:37:02 2012 +0100
s3-rpc_server: pass down netlogon cred state in _netr_ServerGetTrustInfo().
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit fd7087020344f7d24737e3be2f3afbd0417b0026
Author: Günther Deschner <gd at samba.org>
Date: Wed Dec 5 18:38:01 2012 +0100
s4-torture: use netlogon_creds_arcfour_crypt() in samba3rpc test.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 4afb7dcb43c6903568c0fe2c2c2044706e9bd613
Author: Günther Deschner <gd at samba.org>
Date: Wed Dec 5 16:21:59 2012 +0100
s4-torture: exit early when join fails in samba3rpc tests.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 5089442bfdbeff7314e589387c3702f9c401e12a
Author: Günther Deschner <gd at samba.org>
Date: Wed Dec 5 16:20:14 2012 +0100
s4-torture: support AES encryption in interactive samlogon tests in rpc.samr.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit d94f012f3fb428027709a9c8becf8edb85072463
Author: Günther Deschner <gd at samba.org>
Date: Wed Dec 5 16:23:34 2012 +0100
s4-torture: support AES encryption in pac_verify/generic samlogon netlogon tests.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 3dffd29904b3de145941a7420d56b30611f9616f
Author: Günther Deschner <gd at samba.org>
Date: Wed Dec 5 16:11:19 2012 +0100
s4-torture: use names for r.in.logon_level of netlogon samlogon requests.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 7ea9da0c9f0a0a8de416534d6cb1b0248d13f6cf
Author: Günther Deschner <gd at samba.org>
Date: Tue Dec 4 23:11:10 2012 +0100
s4-torture: remove trailing whitespace in smbtorture remote_pac test.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit c6f4745c5670e8da77078e19f2d6a3a485e7adc6
Author: Günther Deschner <gd at samba.org>
Date: Sat Dec 1 00:59:44 2012 +0100
s3-rpc_client: use netlogon_creds_aes_encrypt in interactive netlogon samlogon.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 01e69703fb8c58ab1940bb560e34f6c3f10e0ae9
Author: Günther Deschner <gd at samba.org>
Date: Thu Nov 29 22:47:40 2012 +0100
s4-rpc_server: support AES decryption in netr_ServerPasswordSet2 server.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 3dc8c20b8a94063c6578b60750757c5a40d7db38
Author: Günther Deschner <gd at samba.org>
Date: Thu Nov 29 22:47:19 2012 +0100
s4-torture: add AES support for netr_ServerPasswordSet2 tests.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 0a091604a45b4b143745a20fa842878ceb745c39
Author: Günther Deschner <gd at samba.org>
Date: Thu Nov 29 22:44:33 2012 +0100
s4-torture: pass down netlogon flags in netr_ServerPasswordSet2 tests.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit d1f481ffe17ce84ffddbedf1bd7efb0654e2807e
Author: Günther Deschner <gd at samba.org>
Date: Thu Nov 29 22:24:37 2012 +0100
s4-torture: remove trailing whitespace from netlogon test.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 1362d542df715aa31e9b818ee8783b5ee35f8870
Author: Günther Deschner <gd at samba.org>
Date: Thu Nov 29 21:35:04 2012 +0100
s3-rpc_server: support AES decryption in netr_ServerPasswordSet2 server.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 64345018cda744d16b123d6ef5c4a982340484dc
Author: Günther Deschner <gd at samba.org>
Date: Thu Nov 29 21:34:36 2012 +0100
s3-rpc_client: support AES encryption in netr_ServerPasswordSet2 client.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit ec06c81db313f2862544c972cbf582a07bb844c2
Author: Günther Deschner <gd at samba.org>
Date: Thu Nov 29 21:30:24 2012 +0100
s3-rpc_client: use netlogon_creds_arcfour_crypt() in init_netr_CryptPassword.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 429600c5f3079c8433d5a542383908d6ff61fe60
Author: Günther Deschner <gd at samba.org>
Date: Thu Nov 29 21:23:30 2012 +0100
libcli/auth: add netlogon_creds_aes_{en|de}crypt routines.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit b6e2be8e147b4d34a0424a8851b03b24f180048c
Author: Alexander Bokovoy <ab at samba.org>
Date: Sat Dec 8 17:57:20 2012 +0200
wafsamba: replace try:except: case with explicit comment about FIPS mode
Since exceptions will be caught be outer try:except: pair anyway, mark
the test of MD5 code by the comment that explains why we need to really
test it.
Do it for both hashlib.md5 and md5 modules.
Autobuild-User(master): Alexander Bokovoy <ab at samba.org>
Autobuild-Date(master): Sat Dec 8 18:41:07 CET 2012 on sn-devel-104
commit 56d9c8c4bf29eb473f9f4e7a7ef16fc6020db6b5
Author: Alexander Bokovoy <ab at samba.org>
Date: Fri Dec 7 17:36:02 2012 +0200
wafsamba: Make sure md5 is really work before using it or overriding the hash function
In FIPS mode importing md5 Python module will not cause any error but calling md5.md5()
function will throw ValueError since md5 is not available.
Make sure md5.md5() actually works and if not, fall back to use hash replacement that
we already have in wafsamba.
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Sat Dec 8 13:30:07 CET 2012 on sn-devel-104
commit b4ae73f58c48b3502147332ee4c72621867fffb3
Author: Ricky Nance <ricky.nance at weaubleau.k12.mo.us>
Date: Fri Dec 7 18:43:16 2012 -0600
samba-tool processes: Make the output a bit neater
Reviewed-By: Jelmer Vernooij <jelmer at samba.org>
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Sat Dec 8 03:34:29 CET 2012 on sn-devel-104
commit df0f59f66cca61eee967e89dc659af4ba33f0e6f
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 6 14:31:45 2012 +0100
winbind: Make the code more readable in trustdom_list_done().
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Jim McDonough <jmcd at samba.org>
Autobuild-User(master): Jim McDonough <jmcd at samba.org>
Autobuild-Date(master): Fri Dec 7 22:38:43 CET 2012 on sn-devel-104
commit 16d725b4f5ed77db865e2a3c27ae0eb4accca5a8
Author: Tsukasa Hamano <hamano at osstech.co.jp>
Date: Thu Dec 6 13:01:33 2012 -0800
Fix bug #9471 - SEGV when using second vfs module.
Don't use default_classname_table when we obviously shoud be using
classname_table.
Reviewed by: Jeremy Allison <jra at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Fri Dec 7 17:51:50 CET 2012 on sn-devel-104
commit 734d14b54834a4d03e67bcaece4f4e3cf1d10925
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Dec 7 12:56:21 2012 +0000
s4:dsdb/descriptor: fix replication of NC heads
The sub NC heads maybe replicated with the parent partition,
if we don't need to recalculate the nTSecurityDescriptor attribute in that
case, the replication of the of the sub partition should handle that.
This fixes error messages like this:
descriptor_sd_propagation_recursive: DC=ForestDnsZones,DC=s40dom,DC=base not found under DC=s40dom,DC=base
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 802124789513ef207a154ee950dc03e66a80e0b1
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Dec 7 13:39:31 2012 +0100
s4:dsdb/acl_read: improve debugging for fatal error
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 14b5b729049d92c30ba518adb82c9396fdddd09f
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Dec 7 11:02:49 2012 +0100
s4:dsdb/acl_read: keep the ldb_message of the sub search (bug #9470)
Some modules might not allocate values on the correct memory context.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 3535f8effefef6a68d2b686abe2769d797531dd9
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Dec 7 10:08:14 2012 +0000
s4:dsdb/schema_data.c: correctly move the CN=Aggregate attributes to msg->elements[i].values (bug #9470)
We should keep the talloc hierarchy sane.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 944b6863a71efc48ccc8cd9ae8ad1a3081bc1805
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Dec 7 10:34:58 2012 +0100
s4:dsdb/schema: fix dsdb_schema_set_el_from_ldb_msg() (bug #9470)
We should always update the ts_last_change.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 0fa31296864cd2b0c64c33ac74d55178ad542f90
Author: Volker Lendecke <vl at samba.org>
Date: Thu Dec 6 15:51:55 2012 +0100
s3: Fix clear_if_first for the async echo handler
A worker smbd is as not long-lived as the main smbd, but as the async
echo handler exits when the worker smbd does, passing "true" here is the
right thing to do and fixes our clear_if_first handling when the async
echo handler is active.
Reviewed-by: Christian Ambach <ambi at samba.org>
Autobuild-User(master): Christian Ambach <ambi at samba.org>
Autobuild-Date(master): Fri Dec 7 11:29:36 CET 2012 on sn-devel-104
commit f8056b7a6998e002f473b0ad79eee046236a7032
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 23 11:49:05 2012 +0100
s4:dsdb/password_hash: Honor password complexity settings.
Honor password complexity settings when creating new users.
Without this patch, you could set simple passwords although the complexity
settings were enabled. This was an issue with 'samba-tool user add' and also
when adding new users via Windows' "Active Directory Users and Computers"
MMC Snap-In.
The following scenarios were tested successfully after applying the patch:
-'samba-tool user add' against s4
-'samba-tool user add -H' against a Windows DC
-Adding a new user on a s4 DC using Windows' "Active Directory Users and
Computers" MMC Snap-In.
Please note that this bug was caused by a mistake in the documentation.
Fix bug #9414 - 'samba-tool user add' ignores password complexity settings.
Pair-programmed-with: Karolin Seeger <kseeger at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu Dec 6 05:11:43 CET 2012 on sn-devel-104
commit 171c63c3c45743f215ad360f928d9506951ddcd8
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Dec 5 12:52:22 2012 +1100
build: Install .po files for SWAT intl support
commit 631654ae114ae909228a60de13286922d383f2bb
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Dec 5 10:35:50 2012 +1100
scripting: Handle missing LDAP entries in samba-tool domain classicupgrade
Reported-by: Thomas Simmons <twsnnva at gmail.com>
commit bd18d996e2dc3e6b984d20196e9825b8b3f4dea3
Author: Scott Lovenberg <scott.lovenberg at gmail.com>
Date: Tue Dec 4 09:15:38 2012 -0500
Clean up client timeout definitions [rev. 2]
The definitions for default client timeout values have been moved to client.h. When initializing a client struct we use this value instead of the old hardcoded value. The timeout value remains 20 seconds.
Signed-off-by: Scott Lovenberg <scott.lovenberg at gmail.com>
Reviewed by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Dec 6 03:25:58 CET 2012 on sn-devel-104
commit 4eb53da3fe139b8d89ab98cc1df211267669a612
Author: Michael Adam <obnox at samba.org>
Date: Tue Dec 4 16:26:36 2012 +0100
s3:smbd: fix a cut and paste error in a debug message
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed by: Jeremy Allison <jra at samba.org>
commit 1ff1597e1feb45fd54b0d8dc6d8eabc7ace9073a
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 4 15:47:06 2012 -0800
Documentation fixes for bug #9462 - Users can not be given write permissions any more by default
Ensure we don't apply the masks + force modes on security setting
changes, only on create.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 2013bb9b4dbed747921df2591068e2765428f57d
Author: Michael Adam <obnox at samba.org>
Date: Wed Dec 5 15:04:01 2012 +0100
s3:smbd: don't apply create/directory mask and modes in apply_default_perms()
The mask/mode parameters should only apply to a situation with only
pure posix permissions.
Once we are dealing with ACLs and inheritance, we need to do it correctly.
This fixes bug #9462: Users can not be given write permissions any more by default
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed by: Jeremy Allison <jra at samba.org>
commit 943797c232f96a5dd411a803ad90b6980b2785b0
Author: Richard Sharpe <realrichardsharpe at gmail.com>
Date: Tue Dec 4 17:21:29 2012 -0800
Fix bug #9460 - Samba 3.6.x and Master respond incorrectly to FILE_STREAM_INFO requests.
Ensure we check the buffer size correctly.
Reviewed by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Dec 6 01:31:08 CET 2012 on sn-devel-104
commit 2618d67fe5eda1e86f90de2fcde90c048fbcd50b
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Sat Nov 24 20:44:23 2012 +0100
wsgi: Serve '500 Internal Server Error' page when errors occur.
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Wed Dec 5 18:40:25 CET 2012 on sn-devel-104
commit ad252fb2f5b403001a283aff58773b8b429be145
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Sat Nov 24 20:44:08 2012 +0100
web_server: Make second argument to websrv_output const.
commit 12c72a38359cb81328c5c57a8d6b6fb9920aebe6
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Sat Nov 24 19:35:33 2012 +0100
wsgi: When encountering error in Python code, print traceback to logs.
Signed-off-by: Jelmer Vernooij <jelmer at samba.org>
commit 2ad562057a6d2f19056e90ece9b7c8be396e4662
Author: Andreas Schneider <asn at samba.org>
Date: Tue Dec 4 15:03:40 2012 +0100
BUG 9459: Install manpages only if we install the target.
Reviewed-by: Alexander Bokovoy <ab at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Tue Dec 4 18:07:47 CET 2012 on sn-devel-104
commit 1c5c492f7e563ec7b21edee3da7fd0d764ccc01e
Author: Jeremy Allison <jra at samba.org>
Date: Mon Dec 3 15:07:16 2012 -0800
Remove unused append_parent_acl().
Get rid of a large chunk of unused code.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Tue Dec 4 11:59:30 CET 2012 on sn-devel-104
commit 4a8028a96e20f140c2d423efd4c010a7d300ca72
Author: Michael Adam <obnox at samba.org>
Date: Tue Dec 4 02:02:07 2012 +0100
s3:smbd:vfs_acl: fix a PANIC when setting an ACL fails with ACCESS_DENIED
Omission to free the talloc frame causes a panic (at least in developer mode)
in the next main event loop due to "Frame not freed in order."
(Freed frame ../source3/smbd/process.c:3617, expected ../source3/modules/vfs_acl_common.c:534.)
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Dec 4 09:03:25 CET 2012 on sn-devel-104
commit 61e8b80c85bf114da7f1d3dadfc2207564f5fbaa
Author: Michael Adam <obnox at samba.org>
Date: Mon Dec 3 16:52:12 2012 +0100
s3:passdb: fix building pdb_ldap as shared module
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Mon Dec 3 19:12:29 CET 2012 on sn-devel-104
commit d913fb1304378bdc8aac2543144d39ffa486f862
Author: Karolin Seeger <kseeger at samba.org>
Date: Fri Nov 30 11:33:04 2012 +0100
docs: Merge both samba.8 manpages.
Remove source4/smbd/samba.8.xml and add the additional content to
docs-xml/samba.8.xml to be able to build this manpage with the autoconf build
also.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Mon Dec 3 16:28:32 CET 2012 on sn-devel-104
commit 0e69a7ba114ed5e0ad94e4ed7bb41d7eb0294b16
Author: Karolin Seeger <kseeger at samba.org>
Date: Fri Nov 30 10:39:06 2012 +0100
docs: Add samba.8 and samba-tool manpage to waf build.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit b7f66b43c512932e5265b974012e48d5631767b0
Author: Karolin Seeger <kseeger at samba.org>
Date: Fri Nov 30 11:37:33 2012 +0100
docs: Update man 7 samba.
Update man 7 samba. Still incomplete, but at least a bit more up to date.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 4af921fe882b59d8ad16b2b906e74c28b1b36c20
Author: Karolin Seeger <kseeger at samba.org>
Date: Fri Nov 30 09:43:33 2012 +0100
lib/talloc: Move manpage to man/.
Trying to be more consistent.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit ede2aaef281048123cacab9ae879f5c546787080
Author: Karolin Seeger <kseeger at samba.org>
Date: Fri Nov 30 09:39:22 2012 +0100
lib/tdb: Rename manpages/ to man/.
Trying to be more consistent.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 532350877322cd3446cfa65459e82a45d5cef76c
Author: Andreas Schneider <asn at samba.org>
Date: Fri Nov 23 14:58:38 2012 +0100
replace: Remove deprecated getpass() support.
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit ce29ecfd44613e4f3bae98418add1cc4d0ed59ab
Author: Andreas Schneider <asn at samba.org>
Date: Fri Nov 23 14:55:48 2012 +0100
ntlm_auth4: Use new samba_getpass() function.
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 7cc108c93cd10ac592c28605f2c1e366a7e507b2
Author: Andreas Schneider <asn at samba.org>
Date: Fri Nov 23 14:48:00 2012 +0100
cmdline: Use new samba_getpass() function.
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit de1288e13eb132768d22ae8c2f34a5e99bddcb33
Author: Andreas Schneider <asn at samba.org>
Date: Fri Nov 23 14:38:14 2012 +0100
smbget: Use new samba_getpass() function.
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 353e83e4ee21e5d7955b79e3d1da046f3d1c96e1
Author: Andreas Schneider <asn at samba.org>
Date: Fri Nov 23 14:34:39 2012 +0100
util: Use new samba_getpass() function for passwd util.
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 7f4af3d1fb0827714c8637ecc780ef9d88604bc4
Author: Andreas Schneider <asn at samba.org>
Date: Fri Nov 23 14:29:38 2012 +0100
ntlm_auth: Use new samba_getpass() function.
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 270d721d36890a13ec9a393a09925d1ca27a337f
Author: Andreas Schneider <asn at samba.org>
Date: Fri Nov 23 13:17:13 2012 +0100
net: Use samba_getpass() function in net util.
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 0d5f5424b4b86c16d51a5793fa93c3bfe3cdb11a
Author: Andreas Schneider <asn at samba.org>
Date: Fri Nov 23 15:05:51 2012 +0100
net: Use new samba_getpass() function for 'net rpc'.
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit bed60120d49f3285070db130974fa385b9b57b37
Author: Andreas Schneider <asn at samba.org>
Date: Thu Nov 22 15:51:33 2012 +0100
net: Use new samba_getpass() function for 'net ads'.
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 1ded99cd1447b674a7af6e738a492a597425b6ba
Author: Andreas Schneider <asn at samba.org>
Date: Thu Nov 22 15:46:20 2012 +0100
torture: Use new samba_getpass() in masktest.
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 531af0af1a178fbae82ae2d84598e44d8a750fae
Author: Andreas Schneider <asn at samba.org>
Date: Thu Nov 22 15:46:06 2012 +0100
torture: Use new samba_getpass() in smbtorture3.
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 17bcdb52001f4625439c0c6fea2cfe174b63ce08
Author: Andreas Schneider <asn at samba.org>
Date: Thu Nov 22 15:39:34 2012 +0100
torture: Use new samba_getpass() in locktest2.
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 3c79f85b6ec8e99bd58e615b692bbef1284fef03
Author: Andreas Schneider <asn at samba.org>
Date: Thu Nov 22 15:34:06 2012 +0100
util: Use new samba_getpass() function.
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 85b1b840cbed92a5657e20407fe22dc9e8591af5
Author: Andreas Schneider <asn at samba.org>
Date: Thu Nov 22 15:33:52 2012 +0100
smbclient: Use new samba_getpass() function.
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 04c0d4878e3bb28b8ba8116abb0de4527eb96bd6
Author: Andreas Schneider <asn at samba.org>
Date: Thu Nov 22 15:33:10 2012 +0100
wbinfo: Use new samba_getpass() function.
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 27a1327b49210e342741cf8fb11576983cbcc36d
Author: Andreas Schneider <asn at samba.org>
Date: Thu Nov 22 15:22:40 2012 +0100
util: Add a UNIX platform independent samba_getpass().
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 42a23653237bfc89ba90d83d91942746825e3ee9
Author: Karolin Seeger <kseeger at samba.org>
Date: Mon Dec 3 09:08:47 2012 +0100
docs: Fix typo in the howto collection.
Thanks to Hermann Gausterer <git-samba-2012 at mrq1.org> for reporting!
Karolin
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Mon Dec 3 12:36:14 CET 2012 on sn-devel-104
commit 99efe8480ebb0493be93a6ca5f77a1fe640f3be0
Author: Michael Adam <obnox at samba.org>
Date: Mon Dec 3 02:25:40 2012 +0100
s3:selftest: extend sids2xids test script to cope with "ID_TYPE_BOTH mappings
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Mon Dec 3 10:47:17 CET 2012 on sn-devel-104
commit 93c0c0749a2c3cbb1bc85e18b7dd77989a3eada8
Author: Michael Adam <obnox at samba.org>
Date: Mon Dec 3 08:34:43 2012 +0100
s3:passdb: don't look into group mappings in legacy_sid_to_unixid()
The backends (tdbsam and ldapsam) do this.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 5fbdc5f35a122ff040c6120e2aa2cf5485e32097
Author: Michael Adam <obnox at samba.org>
Date: Mon Dec 3 01:44:49 2012 +0100
s3:passdb:pdb_ldap: treat "Unix User" and "Unix Group" in sid_to_id()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit a0f41294488fcf4c9dbe5e85be6539394b6d6d1a
Author: Michael Adam <obnox at samba.org>
Date: Mon Dec 3 01:42:38 2012 +0100
s3:passdb:pdb_ldap: pre-validate sid with sid_check_object_is_for_passdb()
instead of sid_check_sid_is_in_our_sam). This allows for builtin sids,
wellknown sids and "Unix User" and "Unix Group" domains.
This broadens up the check moved here in commit
02e25b2a43ae02205a3412f862a1482d24b70aa4.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 671f534e5e02adafe945a4e77813e80b5adaeb70
Author: Michael Adam <obnox at samba.org>
Date: Mon Dec 3 01:40:37 2012 +0100
s3:passdb: add sid_check_object_is_for_passdb()
Variant of sid_check_is_for_passdb() that only checks for objects
in the various domains, not for the domain sids themselves.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit d96aeded6193cb6381540c1073182bfb7f079025
Author: Michael Adam <obnox at samba.org>
Date: Mon Dec 3 01:34:32 2012 +0100
s3:passdb: factor pdb_sid_to_id_unix_users_and_groups() out of pdb_default_sid_to_id()
The special treatment of the "Unix User" and "Unix Group" pseudo domains
can be reused.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit ef0ed56eb15f24db5934f174f90f65d3f5c3c526
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 22 23:12:19 2012 +0100
s3:passdb: don't bail out in pdb_default_sid_to_id() if sid is not in our sam
This code treats the own sam, builtin, wellknown, and sids from the
"Unix User" and "Unix Group" pseudo-domains.
This reverts part of commit 02e25b2a43ae02205a3412f862a1482d24b70aa4.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 2d3f7e31411cc63d5c83337f7280fcd6d2330282
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 30 16:27:59 2012 +0100
s3:winbindd: use the new sid_check_is_for_passdb() in idmap_find_domain_with_sid()
This is more correct than the original one:
It also hands the wellknown and "Unix Users" and "Unix Groups" sids to passdb
for id mapping.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 845a14210729c6a4c39a65be00e2f8b19fc13ec0
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 30 16:26:28 2012 +0100
build the new sid_check_is_for_passdb() function into passdb
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit fecdf48aaf514e6cda5cd0412d7407319a3ff89f
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 30 12:27:00 2012 +0100
s3:lib: add utility function sid_check_is_for_passdb()
This function checks whether the given sid should be treated
by passdb (e.g. for id mapping).
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit e3ee3971403c7dac4e8e3578a60973b97451af68
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 30 15:27:15 2012 +0100
s3:winbindd: remove unused function idmap_backends_sid_to_unixid()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 7f2f29647a5d5906db5a267f614f30607d9162e3
Author: Michael Adam <obnox at samba.org>
Date: Tue Nov 27 12:08:33 2012 +0100
s3:test:wbinfo_sids2xids: test the results with singular calls with filled and with empty cache
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 25018d8ae6de32a2a51168a30788545646fddcae
Author: Michael Adam <obnox at samba.org>
Date: Tue Nov 27 22:43:04 2012 +0100
s3:test: fix intialization of WBINFO in test_wbinfo_sids2xids.sh
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit a1411a884c5361bb8b090695236724cd25857269
Author: Michael Adam <obnox at samba.org>
Date: Mon Oct 15 16:34:02 2012 +0200
s3:idmap_autorid: force mapping type to ID_TYPE_BOTH for sid->unixid mapping
This is to remove problems with the same unix-id being used both
as a uid and a gid.
The autorid backend will map a given number to the same SID, no matter whether this
is a uid or a gid. This will prime the idmap cache with mappings.
The sid-to-u/gid mapping, when not going through the cache, instead checks for
the type of the sid and only allows unix ids of the corresponding type.
Hence the rid backend will give different results, depending on whether the
cache is filled or not.
This patch lets the autorid backend always create sid->id mappings of type both.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 55607f0f334ca5d72f35eb6b259db5283b35e86a
Author: Michael Adam <obnox at samba.org>
Date: Mon Oct 15 16:32:25 2012 +0200
s3:idmap_rid: force mapping type to ID_TYPE_BOTH for sid->unixid mapping
This is to remove problems with the same unix-id being used both
as a uid and a gid.
The rid backend will map a given number to the same SID, no matter whether this
is a uid or a gid. This will prime the idmap cache with mappings.
The sid-to-u/gid mapping, when not going through the cache, instead checks for
the type of the sid and only allows unix ids of the corresponding type.
Hence the rid backend will give different results, depending on whether the
cache is filled or not.
This patch lets the rid backend always create sid->id mappings of type both.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit c408126b47b0ce496a8b2293a8481d439b4234cf
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 23 17:53:39 2012 +0100
s3:winbindd: remove unused idmap_sid_to_gid()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 5f7a3720036c422142774ce49147328dc784fec8
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 23 17:53:04 2012 +0100
s3:winbindd: remove unused idmap_sid_to_uid()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit b47be53a1f68735b1a95d57781eaf9beea68481b
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 23 17:50:50 2012 +0100
s3:winbindd: remove unused server implementation of wbint_Sid2Gid()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit c927ff4b3641e10369f9e17b20d92d3148f55633
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 23 17:50:11 2012 +0100
s3:winbindd: remove unused server implementation of wbint_Sid2Uid()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit aa771618718378bc3449b1caa78d1d942ff937c4
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 23 17:49:09 2012 +0100
s3:winbindd: remove wbint_Sid2Gid from the wbint.idl
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 8b73556e3f583af0a073a743f4973967aa5ad004
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 23 17:48:36 2012 +0100
s3:winbindd: remove wbint_Sid2Uid() from the wbint.idl
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit de2cf94719fa07847b9c1b8149144bb1e36ba403
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 23 17:05:01 2012 +0100
s3:winbindd: remove now unused wb_sid2uid and wb_sid2gid modules
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 5e746768c8adf77551d7904f8534372f88475675
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 23 16:54:36 2012 +0100
s3:winbindd: change winbindd_getgroups to use wb_sids2xids instead of wb_sid2gid
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit eb0fca9b7b06a2aebce0da3031b1af313f0c8081
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 23 16:44:41 2012 +0100
s3:winbindd: change wb_getgrsid to use wb_sids2xids instead of wb_sid2gid
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 55ea9210e9b9cbb5a8b4633f492920af7eda77ab
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 23 16:40:48 2012 +0100
s3:winbindd: change wb_fill_pwent to use wb_sids2xids instead of wb_sid2[ug]id
We can optimize this later and just do one wb_sids2xids_send/recv call.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 46f2dfa7a51487e1b21c329dfb2e4cac3e6ada11
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 23 01:35:30 2012 +0100
selftest:Samba3: provision the BUILTIN\Users group if the environment runs winbindd
Note that in order to create a local group (alias), the id-allocator of
id-mapping is needed, so this can only work if winbindd is running.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 11ca06338670c3aa1ad6928232f2c582116f42e8
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 23 00:18:44 2012 +0100
selftest:Samba3: add "wbinfo -p" test to wait_for_start()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 5b975ce78cc77bd9ff39e2ec0c2e7d674bf61ebe
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 23 00:09:43 2012 +0100
selftest:Samba3: add nmbd, winbindd smbd arguments to wait_for_start()
to make checks conditional
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit f7dca55224af2cb2ac172831755246f5c9b04e0f
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 23 00:02:33 2012 +0100
selftest:Samba3: call wait_for_start() from check_or_start()
...instead of calling the two one after another each time.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 4210e08109d9bc24168740f5a8a52953c532df4a
Author: Michael Adam <obnox at samba.org>
Date: Tue Nov 27 01:11:16 2012 +0100
s3:winbindd: make idmap_find_domain() static.
idmap_find_domain_with_sid() should be used instead
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 27f88ba2deeec8b5b0a72ef97ae84c1016532a3c
Author: Michael Adam <obnox at samba.org>
Date: Sun Nov 25 02:13:15 2012 +0100
s3:winbindd: also use idmap_passdb for own sam and builtin in wbint_Sids2UnixIDs()
This is the way the singular calls work and how they should (currently) work.
The two code paths need to give the same results. It is important to use
the passdb backend, otherwise groups don't work.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 370d62578dd171c6f898f4868f382cdddb908bcf
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 22 18:16:31 2012 +0100
s3:winbindd: add idmap_find_domain_with_sid()
This will return the passdb domain if the given sid is in our sam or builtin
or is the domain sid of those domains. Otherwise it returns the idmap domain
that results from the idmap configuration.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 150cfb4b97e2ee67ec1fa8fc379ac03d42002da9
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 22 16:21:53 2012 +0100
s3:winbindd: rename idmap_init_passdb_domain() -> idmap_passdb_domain()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit ee17a516c82acbdf347c2a47e7003b6a7fb879de
Author: Michael Adam <obnox at samba.org>
Date: Tue Nov 20 16:48:23 2012 +0100
selftest:Samba3: provision the domain adminstrators group in the s3 environments
I discovered that this sid / mapping is missing by working with the Sids2Uids
code and test. I do even wonder why this test could succeed prior to my pending
changes to the winbindd sids-to-xids code, for example against the s3:local
environment, since the test tries to map the sid <domsid>-512.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 28e7d73bdcdf1a3d588e92eee982ff01db53d65d
Author: Michael Adam <obnox at samba.org>
Date: Sun Nov 18 13:51:13 2012 +0100
s3:winbindd: use struct unixid instead of uint64 in Sids2Xids parent<->child
This implicitly also hands the type of the resulting unix-id that the idmap
backend has created back to the caller. This is important for backends that
would set a broader type than the requested one, e.g. rid backend returning
BOTH instead of UID or GID.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit da8d0263806260fdb4973f22fc874710bd490421
Author: Michael Adam <obnox at samba.org>
Date: Sun Nov 18 19:58:07 2012 +0100
s3:winbindd: add an explanatory comment to _wbint_Sids2UnixIDs()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 75a752473f932f84d15ba043c9b9167db10dd572
Author: Michael Adam <obnox at samba.org>
Date: Sun Nov 18 19:29:37 2012 +0100
s3:winbindd: add an explanatory comment to _wbint_Sids2UnixIDs()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 3e7f04b70f89d528aacfdc420b635d8aff0f4af6
Author: Michael Adam <obnox at samba.org>
Date: Sat Nov 17 13:10:26 2012 +0100
s3:winbindd: use wb_sids2xids instead of wb_sid2gid in winbindd_sid_to_gid
The main purpose of the change is to hand the sid into the
idmap backend and handle responsiblity for handling the
sid-type correctly to the idmap backend instead of failing
directly when the sid is not of group type.
Hence backends like rid who are sid-type agnostic, can
return gids also for sids of other types. This is an important
fix to make sid_to_gid behave the consistently with and without
the presence of cache entries.
We need to additionally filter the result for id type GID
or more general (BOTH) to keep the behaviour.
This is a step towards using only one codepath to id_mapping.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 7637c93472492f1bfd7bf46b8f855ef4818c75a9
Author: Michael Adam <obnox at samba.org>
Date: Sat Nov 17 13:04:41 2012 +0100
s3:winbindd: use wb_sids2xids instead of wb_sid2uid in winbindd_sid_to_uid
The main purpose of the change is to hand the sid into the
idmap backend and handle responsiblity for handling the
sid-type correctly to the idmap backend instead of failing
directly when the sid is not of type user.
Hence backends like rid who are sid-type agnostic, can
return uids also for sids of other types. This is an important
fix to make sid_to_uid behave the consistently with and without
the presence of cache entries.
We need to additionally filter the result for id type UID
or more general (BOTH) to keep the behaviour.
This is a step towards using only one codepath to id_mapping.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 8e5ce1e2d53f36fd35eb8efad7da680dcf0b1ce1
Author: Michael Adam <obnox at samba.org>
Date: Sat Nov 17 02:30:07 2012 +0100
s3:winbindd: factor winbindd_sids_to_xids into external and internal part
- external part takes winbindd request/reponse structs (with sid strings)
- internal part takes sid lists
The new internal part implements functions wb_sids2xids_* that are
moved into the new module wb_sids2xids.c.
The purpose of this change is to use wb_sids2xids in winbindd_sid_to_uid
and winbindd_sid_to_gid instead of the currently used wb_sid2uid and wb_sid2gid.
We should just have one code path into id mapping and not several that behave
differently.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit c58c68d5ba58855098d24c54db9c0cda19db0f4b
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 16 17:49:25 2012 +0100
s3:winbindd: convert some spaces to tabs in winbindd_sids_to_xids_send()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 349b9ac05242f87fa5afcc06c72ccc02bdb05d8b
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 9 16:09:59 2012 +0100
s3:winbindd: add explaining comment winbindd_sids_to_xids_send()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit be033a1d165f815bbddceda46384be1f9c0c2b7f
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 9 14:09:10 2012 +0100
s3:winbindd: factor lsa_SidType_to_id_type() out of winbindd_sids_to_xids_lookupsids_done()
for readability
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit b435e668aa8b2805cd94bde37b9ddf6a7ad335f8
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 9 13:54:20 2012 +0100
s3:winbindd: simplify winbindd_sids_to_xids_recv() a bit.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 3f0c31fbd388986d636b5701f66ed7b215a1b903
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 9 11:32:47 2012 +0100
s3:winbindd:util: add a comment explaining the function parse_sidlist()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 6f71071381ead9976f4a6d296c9a1ade385484e0
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Nov 29 09:57:44 2012 +0100
s4:python/ntacl: add 'as_sddl' option to dsacl2fsacl()
This allows the caller to ask for a security.descriptor instead of sddl
by passing 'as_sddl=False'.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 06f026368e5b657394bb9e681c3d0184104bc120
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Nov 29 09:28:23 2012 +0100
s4:python/ntacl: allow string or objects for sd/sid in setntacl()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit d48d0c5bbf70394dfc6ab44ef124582fd836695f
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Nov 29 09:31:12 2012 +0100
s4:samba-tool/gpo: fix the operation order when creating gpos
We should do it like the windows GUI.
1. create the LDAP objects
2. query the security_descriptor of the groupPolicyContainer
3. create the gPCFileSysPath via smb
4. set the security_descriptor of gPCFileSysPath
5. copy the files and directories into gPCFileSysPath
6. modify the groupPolicyContainer and link gPCFileSysPath
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit dde7eb0d82e9b980c9b08fb4590b7e77bda0c76b
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Nov 29 09:31:12 2012 +0100
s4:samba-tool/gpo: use 'gPCFileSysPath' when deleting gpos
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit a1a525e2a9b0bc20e3e06695fbcbdf0d172839a1
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Nov 29 09:31:12 2012 +0100
s4:samba-tool/gpo: use the dns_domain from the server when creating gpos
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit a42c49c93acb9e480b6e174f56fb75ae0524b984
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Dec 1 09:14:19 2012 +0100
s4:libcli/finddcs_cldap: allow io->in.server_address as hostname
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit c4d51d8d17f04583868f1fdc82322b26bcb1c7a0
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Dec 1 08:56:57 2012 +0100
s4:libcli/finddcs_cldap: try all NBT#1C addresses
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 0e2e3ff5e864115495be68040959838e2835e260
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 30 14:36:07 2012 +0100
s3:smbcacls: add --query-security-info and --set-security-info options
This allows the caller to specify the security_information flags.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 9afba14417ebb8e13623b62d3c81492629b92f29
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 30 13:52:53 2012 +0100
s3:libsmb: add cli_{query,set}_security_descriptor() which take sec_info flags
In order to set and get security_descriptors it's important to specify
the sec_info flags.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit cf60338ada9b1685aaa49a41cefbe1e14040a283
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Nov 29 12:33:22 2012 +0100
libcli/security: remove duplicate aces in se_create_child_secdesc()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 8fbe39d5134e136101425f9fc8d3d5080cbe25ba
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 30 13:33:59 2012 +0100
s3:smbd/open: fall back to Builtin_Administrators if SYSTEM doesn't map to a group
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 139232656a5de5f1c4694bbea8554a01c677081a
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 30 13:32:04 2012 +0100
s3:smbd/open: try the primary sid (user) as group_sid if the token has just one sid
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 0a3396b53683f5efe439bfb8395e275f53108255
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Nov 29 10:00:03 2012 +0100
s3:smbd/open: use Builtin_Administrators as owner of files (if possible)
We do this if the idmap layer resolves Builtin_Administrators
as ID_TYPE_BOTH and if the current token has the
Builtin_Administrators SID or it's SYSTEM.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 8ababf4367eb4faaeeda6cf66191aaf66a3a69da
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Dec 1 15:10:38 2012 +0100
s4:dsdb/descriptor: NULL out user_descriptor elements depending on the sd_flags
A client can send a full security_descriptor while just passing
sd_flags of SECINFO_DACL.
We need to NULL out elements which will be ignored depending on
the sd_flags and may set the old owner/group sids. Otherwise
the calculation of the DACL/SACL can replace CREATOR_OWNER with
the wrong sid.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 057c56ac2443abffbe169b06a72a93f41096fb67
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 16 12:51:44 2012 +0100
s4:dsdb/tests: add SdAutoInheritTests
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Fri Nov 30 18:59:50 CET 2012 on sn-devel-104
commit d31742641fb117e4249dcc317dac662bb5e1a690
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 23 17:10:38 2012 +0100
s4:dsdb/repl_meta_data: call dsdb_module_schedule_sd_propagation() for replicated changes
We only do so if the replicated object is not deleted.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit fb2a41d9453d94860104b7b96a75bf8fa96996d6
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 16 12:49:16 2012 +0100
s4:dsdb/descriptor: inherit nTSecurityDescriptor changes to children (bug #8621)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f8c0ad65ad783b3c82ec8ab120d18ad454fe2665
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 16 12:49:16 2012 +0100
s4:dsdb/descriptor: recalculate nTSecurityDescriptor after a rename (bug #8621)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit dae1b0d85207040fed873d4232a45206b0162f53
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 23 16:46:51 2012 +0100
s4:dsdb/acl_util: add dsdb_module_schedule_sd_propagation()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit d6962f40caad861c7d240d80bd04070989c85a73
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 23 15:55:24 2012 +0100
s4:dsdb/descriptor: implement DSDB_EXTENDED_SEC_DESC_PROPAGATION_OID
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 2101400af2e5e1b72a5d51e83f005f62bec1f482
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Nov 22 17:42:32 2012 +0100
s4:dsdb: define DSDB_EXTENDED_SEC_DESC_PROPAGATION_OID
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit ddea8564901f5aa1a25cd84713bf86a2ce95bc07
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 23 10:45:02 2012 +0100
s4:dsdb/descriptor: handle DSDB_CONTROL_SEC_DESC_PROPAGATION_OID
This can only be triggered by ourself, that's why we expect
control->data == module.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 1be4dbc0ca732bd2c35b6108331120a3f1a54ada
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 21 16:12:54 2012 +0100
s4:dsdb/schema_data: allow DSDB_CONTROL_SEC_DESC_PROPAGATION_OID on modify
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 7f42a8b7b667c6a704ecd7bce1630971eb3f1e8c
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 23 11:18:05 2012 +0100
s4:dsdb/repl_meta_data: allow DSDB_CONTROL_SEC_DESC_PROPAGATION_OID on modify
The propagation of nTSecurityDescriptor doesn't change the
replProperyMetaData.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit cb9c7ee79b2f4e8c875bd15c1fddee90648eec19
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Nov 24 15:25:06 2012 +0100
s4:dsdb/objectclass_attrs: allow DSDB_CONTROL_SEC_DESC_PROPAGATION_OID on modify
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 60f0e172e3ce182324c4573fc05197ba241def89
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Nov 22 17:42:32 2012 +0100
s4:dsdb: define DSDB_CONTROL_SEC_DESC_PROPAGATION_OID
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 7f88ad3efce5bc14de49b3d73a5dcb19499e1342
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Nov 24 10:16:45 2012 +0100
s4:dsdb/subtree_delete: delete from the leafs to the root (bug #7711)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 5dd4555f391d841b276e53e70eedde36f5190cdd
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Nov 24 10:14:59 2012 +0100
s4:dsdb/subtree_delete: do the recursive delete AS_SYSTEM/TRUSTED (bug #7711)
Now that the acl module checks for SEC_ADS_DELETE_TREE,
we can do the recursive delete AS_SYSTEM.
We need to pass the TRUSTED flags as we operate from
the TOP module.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 60192fd1004015b50e208b3da6a07bd67f9d7990
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Nov 24 10:04:39 2012 +0100
s4:dsdb/subtree_delete: do an early return and avoid some nesting
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit ff274bafeb223c7440f4d97e2225b954b1031259
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Nov 24 23:21:10 2012 +0100
s4:dsdb/objectclass: do not pass the callers controls on helper searches
We add AS_SYSTEM and SHOW_RECYCLED to the helper search,
don't let the caller specify additional controls.
This also fixes a problem when the caller also specified AS_SYSTEM.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 5838637b4218ecf88e7a650610da3be1a5a518c9
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Nov 24 10:06:13 2012 +0100
s4:dsdb/acl: require SEC_ADS_DELETE_TREE if the TREE_DELETE control is given (bug #7711)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 60c29a51a062640bf23c85d0d2f650d35a9ab59c
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Nov 24 09:20:37 2012 +0100
s4:dsdb/dirsync: remove unused 'deletedattr' variable
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit ffaf9bb98b5322cca31ef6a43f8c27ca4e5fe42e
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Nov 24 09:19:52 2012 +0100
s4:provision: add pekList and msDS-ExecuteScriptPassword to @KLUDGEACL
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 0c2c00e4b9afd72b4f4052e6b19e40096fd1e44c
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Nov 24 09:17:27 2012 +0100
s4:dsdb/common: add pekList and msDS-ExecuteScriptPassword to DSDB_SECRET_ATTRIBUTES_EX
See [MS-ADTS] 3.1.1.4.4 Extended Access Checks.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit b54d268e2042f36bc670cf8f4f33cddd957e1d34
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Nov 24 09:15:24 2012 +0100
s4:dsdb/acl: also add DSDB_SECRET_ATTRIBUTES into the password attributes
The @KLUDGEACL record might not be uptodate.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f67f469ce101e48301de790b5c31f8d4e712e0ea
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 23 10:58:49 2012 +0100
s4:dsdb/descriptor: the old nTSecurityDescriptor is always expected there on modify
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 5aa7dbe546ff18e521e72c0af713a2509201e00d
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 23 09:55:17 2012 +0100
s4:dsdb/descriptor: make explicit that we don't support MOD_DELETE on nTSecurityDescriptor
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 4ef36fda681409bf7050adb98bb4b3d574bc01a9
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 23 09:31:05 2012 +0100
s4:dsdb/descriptor: remove some nesting from descriptor_modify
If the nTSecurityDescriptor attribute is not specified,
we have nothing to do.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 8d60ac19ed0bc70ec3763614147465c04f28e286
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 23 09:20:50 2012 +0100
s4:dsdb/descriptor: remove some unnecessary nesting
sd == NULL is checked before.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 813492676c5b876d309bb2db12c794c513fab5c7
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 23 09:19:11 2012 +0100
s4:dsdb/descriptor: add some error checks to descriptor_{add,modify}
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit b3486f4e1a2108bd3af7ce760c8410a560c5237d
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 23 09:15:25 2012 +0100
s4:dsdb/descriptor: remove support for unused LDB_CONTROL_RECALCULATE_SD_OID
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 74e3f0ea0aa0352bf15e92c70256fa9b4d291cd9
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 23 07:18:35 2012 +0100
s4:dsdb/descriptor: move special dn check to the start of descriptor_{add,modify,rename}
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 4136d969cab5d4690f00c855bd98dc01253d73d9
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Nov 22 16:22:30 2012 +0100
s4:samba_upgradeprovision: use the sd_flags:1:15 control with an empty sd
The sd_flags:1:15 control together with an empty security_descriptor
has the same effect as the recalculate_sd:0 control (which is samba only).
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 118db4ca11bec17b8f5955f188c07f154b85c87b
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Nov 22 14:09:34 2012 +0100
s4:provision: add get_empty_descriptor()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 7a3e4d04c7e06379eddacb4f025a3c48a0a754a4
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Nov 22 15:53:14 2012 +0100
s4:dsdb/descriptor: if the caller specifies no DACL/SACL the objects gets a default one
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit c2c715f9c9e0d465857ad118d632493131a5f9c5
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Nov 22 14:07:04 2012 +0100
s4:dsdb/descriptor: give SYSTEM the correct default owner (group) sid
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 990448b4997d1a2423e5dd4da1e37ad51f99bf3a
Author: Stefan Metzmacher <metze at samba.org>
Date: Sun Nov 18 18:57:03 2012 +0100
s4:dsdb/acl_read: enable acl checking on search by default (bug #8620)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit fa676769e0d5d3f161b295f06f643fdacebb82ca
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 21 14:04:09 2012 +0100
s4:dsdb/acl_read: specify the correct access_mask for nTSecurityDescriptor
We need to base the access mask on the given SD Flags.
Originally, we always checked for SEC_FLAG_SYSTEM_SECURITY,
which could lead to INSUFFICIENT_RIGHTS when we should
have been allowed to read.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit ca3c0e28ef5d43f0af487e45a56f2929f5f23b4e
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 21 09:31:25 2012 +0100
s4:dsdb/acl_read: do search for instanceType AS_SYSTEM and with SHOW_RECYCLED
Note that SHOW_RECYCLED implies SHOW_DELETED.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 53b100bb59dadbc7cfb727a4ad1566302ff6c831
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 21 14:10:43 2012 +0100
s4:dsdb/acl: calculate the correct access_mask when modifying nTSecurityDescriptor
The access_mask depends on the SD Flags.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 95b480fd98d9647c679672abac49c9f4ca5b3219
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 21 12:12:41 2012 +0100
s4:dsdb/acl: don't protect confidential attributes when "acl:search = yes" is set
In that case the acl_read module does the protection.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 3d57f17db94ddb5d5d8021158548ea7aebe16cd1
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 21 12:15:00 2012 +0100
s4:dsdb/acl: remove unused "acl:perform" option
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 329afc1a203056b1f4a43dd6c98ec2067c64f962
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 21 07:14:31 2012 +0100
s4:dsdb/acl: do helper searches AS_SYSTEM and with SHOW_RECYCLED
The searches are done in order to do access checks
and the results are not directly exposed to the client.
Note that SHOW_RECYCLED implies SHOW_DELETED.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 42898590bb386a13b4f0d7b0294561a78df7e268
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 21 14:13:17 2012 +0100
s4:dsdb/descriptor: make it clear that the SD Flags are ignored on add
See [MS-ADTS] 6.1.3.2 SD Flags Control:
...
When performing an LDAP add operation, the client can supply an SD flags control
with the operation; however, it will be ignored by the server.
...
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f018772e0ca981857036078342456ef17858b966
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 21 13:05:31 2012 +0100
s4:dsdb/descriptor: make use of dsdb_request_sd_flags()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 67045fafe8a826792a51a504aa85ee6d8e137059
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 21 15:24:46 2012 +0100
s4:dsdb/descriptor: always use descriptor_search_callback if we return nTSecurityDescriptor
If the nTSecurityDescriptor is explicitly specified
without the SD Flags control we should go through descriptor_search_callback().
This is not strictly needed at the moment, but makes the code clearer
and might avoid surprises in the future.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 690b5e11618eb0385272d6a003761db22369e620
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 21 10:15:58 2012 +0100
s4:dsdb/descriptor: do searches for nTSecurityDescriptor AS_SYSTEM and with SHOW_RECYCLED
Note that SHOW_RECYCLED implies SHOW_DELETED.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 2916313f8016720fb36180db341efbf7b91522f6
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 21 12:33:35 2012 +0100
s4:dsdb/acl_util: add dsdb_request_sd_flags() helper function
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 1cdecf1234bffc37a9898b666371b2dd25ad158d
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 21 07:14:31 2012 +0100
s4:dsdb/acl_util: do helper searches AS_SYSTEM
The search is done in order to do access checks.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 8d900d06ff89136016ef2f139d6c33b306c87e93
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 21 09:33:53 2012 +0100
s4:dsdb/extended_dn_store: do helper searches AS_SYSTEM
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 659277a89dfd4226db9ea44709010ad7e3768fd6
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Nov 19 06:59:33 2012 +0100
s4:dsdb/extended_dn_in: do helper searches AS_SYSTEM and with SHOW_RECYCLED
Note that SHOW_RECYCLED implies SHOW_DELETED.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 844b736a1dd05159850ccc28eee1b3e625489139
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Nov 19 06:59:33 2012 +0100
s4:dsdb/objectclass: do helper searches AS_SYSTEM and with SHOW_RECYCLED
Note that SHOW_RECYCLED implies SHOW_DELETED.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit a882b41d44b20476a0b1549260e07be3398f9752
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Nov 12 14:19:34 2012 +0100
s4:dsdb/rootdse: do helper searches AS_SYSTEM
As anonymous users can read all rootdse attributes,
we should do helper searches with DSDB_FLAG_AS_SYSTEM
in order to avoid unnecessary access checks.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 964d96d2c31211601b8854dd3d532112fd2aaece
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Nov 26 13:38:07 2012 +0100
s4:dsdb/rootdse: remove unused variable
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 4970d3cacbd6b9a76e64030cc79628f3dfecce1b
Author: Michael Adam <obnox at samba.org>
Date: Tue Nov 27 16:43:25 2012 +0100
s4:tests/samba_tool/gpo.py: fix accidential line break
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit a58124208006ba9311588554b147acfb86d4d4eb
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Nov 20 15:02:05 2012 +0100
s4:tests/samba_tool/gpo.py: add test_show_as_admin()
This calls samba-tool gpo show as admin (which should be able to
see the full nTSecurityDescriptor.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 325e92190852ae317c42c26ab86d32818d119381
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Nov 20 14:58:13 2012 +0100
s4:netcmd/gpo.py: let get_gpo_info explicitly ask for the full ntSecurityDescriptor
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 67799962b8e6e16ac18466658a3f9924854e32f7
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Nov 20 14:56:56 2012 +0100
s4:netcmd/gpo.py: only ask for OWNER/GROUP/DACL when validating the nTSecurityDescriptor
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 6bffad67d24df2c90b174bbcc9c578899783a834
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Nov 17 07:13:40 2012 +0100
s4:netcmd/gpo.py: the nTSecurityDescriptor may not be visible for the current user
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f843c04b0f2314ccedb4759c85721773845eb207
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Nov 20 14:51:46 2012 +0100
s4:netcmd/gpo.py: s/ntSecurityDescriptor/nTSecurityDescriptor
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 8563348a01206874ff215a55d0c542912740e84b
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Nov 22 08:59:40 2012 +0100
s4:dsdb/dirsync: explicitly ask for sdctr->secinfo_flags = 0xF
A value of 0 is mapped to 0xF.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 6991fb385e3956892d904f871052aaede1137a29
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 21 09:51:45 2012 +0100
s4:dsdb/dirsync: use the correct nc_root to fetch replUpToDateVector
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 7fe1e61ab908264f2ac7b8df666b254ae2af4488
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Nov 27 14:49:11 2012 +0100
s4:dsdb/dirsync: check result of replUpToDateVector fetch on nc_root
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit ac9bd1e63a8adfb96eb5c9f996e60c2d99aba5e1
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 21 16:12:22 2012 +0100
s4:dsdb/schema_data: fix debug message in schema_data_modify()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 8f3f38ece4981d0047024019c6fc8dfde3fffed0
Author: Michael Adam <obnox at samba.org>
Date: Wed Nov 28 21:55:47 2012 +0100
ldb: fix a typo in the comment for ldb_req_is_untrusted()
Signed-off-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Fri Nov 30 15:44:46 CET 2012 on sn-devel-104
commit 06e1fca044718ed2d61ef9fe394845514dd5a652
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 30 12:31:55 2012 +0100
libnet: Fix a typo in dbsync error message.
Signed-off-by: Michael Adam <obnox at samba.org>
commit 7a429367a99fe4d77c8347f21e7b3247281191eb
Author: Andreas Schneider <asn at samba.org>
Date: Fri Nov 30 11:01:47 2012 +0100
libnet: Fix copy and paste error in dbsync error message.
commit f3d5d14906e588d44fa255fb9206b825215946ec
Author: Andreas Schneider <asn at samba.org>
Date: Fri Nov 30 10:59:06 2012 +0100
torture: Fix copy and paste error in debug message.
Found by Coverity.
commit 1b170c29bc9239e2077e70c929e7426f5b19104d
Author: Andreas Schneider <asn at samba.org>
Date: Fri Nov 30 10:57:39 2012 +0100
torture: Fix copy and paste error.
Found by Coverity.
commit aa7f4063177118b8dd37b30f40c5543fdd5f5ec0
Author: Andreas Schneider <asn at samba.org>
Date: Fri Nov 30 10:53:55 2012 +0100
s3-reg: Fix copy and paste error in debug message.
Found by coverity.
commit 234f9365b93b267f5a42dcc75512f08ccfb840c8
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 30 12:07:39 2012 +0100
s3:popt_common: Fix password processing.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Fri Nov 30 14:01:08 CET 2012 on sn-devel-104
commit 3101fcccff3ef847a123b10b2b99611e52504414
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 30 09:31:34 2012 +0100
s3:util: fix usage of popt_burn_cmdline_password()
We should only call popt_burn_cmdline_password() after poptFreeContext(),
otherwise we remove the password to early.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 4a73adf6e53fb810056a80a87c72b1370323c583
Author: Günther Deschner <gd at samba.org>
Date: Thu Nov 29 14:31:19 2012 +0100
s3-winbind: use new reconnect logic in rpc_lookup_sids() also.
Volker, please check.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 7a49c966930ad79e954be582816c45e251d477f8
Author: Günther Deschner <gd at samba.org>
Date: Thu Nov 29 12:03:53 2012 +0100
s3-winbindd: rework reconnect logic in winbindd_lookup_names().
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit cd517743166c55f3a9eb8b5232e9de061b9c8307
Author: Günther Deschner <gd at samba.org>
Date: Thu Nov 29 12:03:16 2012 +0100
s3-winbindd: rework reconnect logic in winbindd_lookup_sids().
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 82ace10492c7f71294ece4814817015cb0786bc1
Author: Günther Deschner <gd at samba.org>
Date: Wed Nov 28 20:41:21 2012 +0100
s3-winbindd: remove lookup_sids_fn_t.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit d9243815b484456dc79e99bc8062179fe96b2ecb
Author: Günther Deschner <gd at samba.org>
Date: Wed Nov 28 17:03:40 2012 +0100
s3-winbindd: remove lookup_names_fn_t.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 3c486dfee47d4d232f88bce05c0b583ed8c6a63b
Author: Günther Deschner <gd at samba.org>
Date: Wed Nov 28 17:00:49 2012 +0100
s3-rpc_client: make dcerpc_lsa_lookup_names_generic() public.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 2d38154f91d8cc7bf1269bdc134d161c438eac92
Author: Günther Deschner <gd at samba.org>
Date: Wed Nov 28 16:57:57 2012 +0100
s3-rpc_cli: make dcerpc_lsa_lookup_sids_generic() public.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 7bd9a3b86f4622369f3be57904a022202d934fec
Author: Günther Deschner <gd at samba.org>
Date: Wed Nov 28 16:57:24 2012 +0100
s3-winbindd: add cm_connect_lsat().
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 457c933ff04e8ffc11ad1b94bbd9d28c48109066
Author: Günther Deschner <gd at samba.org>
Date: Wed Nov 28 14:53:27 2012 +0100
s3-rpc_cli: Remove some unused wrapping code.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit d5693d99b83c9f10d13f279505139a3bf5591b89
Author: Volker Lendecke <vl at samba.org>
Date: Tue Nov 27 14:58:09 2012 -0800
Fix Bug 9422 - large read requests cause server to issue malformed reply
Reviewed by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Nov 30 03:27:07 CET 2012 on sn-devel-104
commit 2f38a77a2dfc72ccd94f5027807c9484dae54358
Author: Volker Lendecke <vl at samba.org>
Date: Thu Nov 29 16:45:15 2012 +0100
dbwrap: Do not rely on dbwrap_record_get_value to return a talloc object
db_tdb_fetch_locked returns the value as part of a larger talloc object
that also contains the key. This means we can not realloc, but have to
freshly alloc.
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Thu Nov 29 20:21:51 CET 2012 on sn-devel-104
commit e271db4fd82d03b39a5872b1a3fde5e2a16e1633
Author: Volker Lendecke <vl at samba.org>
Date: Thu Nov 29 15:04:33 2012 +0100
dbwrap: Remove an unnecessary if-statement
TALLOC_FREE can live with a NULL pointer
Reviewed-by: Michael Adam <obnox at samba.org>
commit c7af12dd30f9670806b161b94d91b741d06813e2
Author: Volker Lendecke <vl at samba.org>
Date: Thu Nov 29 15:03:20 2012 +0100
dbwrap: No need to NULL out a talloc_zero'ed structure element
Reviewed-by: Michael Adam <obnox at samba.org>
commit a02251333fc185aee176b565a85fd42e9ff4cfbc
Author: Volker Lendecke <vl at samba.org>
Date: Thu Nov 29 15:02:43 2012 +0100
dbwrap: Use talloc_zero in db_open_rbt
Reviewed-by: Michael Adam <obnox at samba.org>
commit 0c0815cfe3cce09ef7dffa62235967e954915513
Author: Volker Lendecke <vl at samba.org>
Date: Thu Nov 29 15:02:15 2012 +0100
dbwrap: Use talloc_zero in db_open_cache
Reviewed-by: Michael Adam <obnox at samba.org>
commit 343ce16e0b52acd3d109eb619f60e394c1e04abb
Author: Volker Lendecke <vl at samba.org>
Date: Mon Nov 12 13:42:23 2012 +0100
s3: Remove db_ctdb_fetch
Note that this also makes the request for read only copies
much more explicity visible in the code.
Reviewed-by: Michael Adam <obnox at samba.org>
commit 6b8a37f5ca83c45e2cac262f4d9eee5c7750c283
Author: Volker Lendecke <vl at samba.org>
Date: Mon Nov 12 13:36:48 2012 +0100
s3: Directly parse local existing records in db_ctdb_parse_record
Reviewed-by: Michael Adam <obnox at samba.org>
commit 9dd047d67e4b53f1240956e20af986a1d03dce32
Author: Volker Lendecke <vl at samba.org>
Date: Mon Nov 12 13:27:07 2012 +0100
s3: Factor out db_ctdb_can_use_local_hdr from db_ctdb_can_use_local_copy
Reviewed-by: Michael Adam <obnox at samba.org>
commit 55d75a3fbe95ea3b95dc83551cca742bcddb6e9b
Author: Volker Lendecke <vl at samba.org>
Date: Mon Nov 12 13:06:38 2012 +0100
s3: Remove unused code for fetching persistent ctdb records
The only entry point here is parse_record, and this catches the persistent
case with a direct parse now
Reviewed-by: Michael Adam <obnox at samba.org>
commit 7b43362a9ea942e6759fd9298b2a67cb3328520f
Author: Volker Lendecke <vl at samba.org>
Date: Mon Nov 12 13:03:56 2012 +0100
s3: Avoid db_ctdb_fetch for persistent databases
Reviewed-by: Michael Adam <obnox at samba.org>
commit 93219f92bb4294f0d7be7ba91f6a2e312336469d
Author: Volker Lendecke <vl at samba.org>
Date: Mon Nov 12 12:13:39 2012 +0100
s3: Factor out parse_newest_in_marshall_buffer from pull_newest_from_marshall_buffer
Reviewed-by: Michael Adam <obnox at samba.org>
commit 850d5de96702b8c4bd8a285b4bd44a15350dfca8
Author: Volker Lendecke <vl at samba.org>
Date: Sat Nov 10 15:03:35 2012 +0100
s3: reduce db_ctdb_marshall_loop_next to specialized db_ctdb_marshall_buf_parse
now that the db_ctdb_marshall_loop_next_key has been factored out.
Reviewed-by: Michael Adam <obnox at samba.org>
commit a742b6edd5dc23378ec1926777af67ad54e75e10
Author: Volker Lendecke <vl at samba.org>
Date: Sat Nov 10 14:46:10 2012 +0100
s3: Factor out db_ctdb_marshall_loop_next_key from db_ctdb_marshall_loop_next
Reviewed-by: Michael Adam <obnox at samba.org>
commit 664b170b13674c26c94ec1d3603570e707f8f1e5
Author: Volker Lendecke <vl at samba.org>
Date: Sat Nov 10 14:42:21 2012 +0100
s3: Slightly simplify db_ctdb_marshall_loop_next
Both callers give a key argument
Reviewed-by: Michael Adam <obnox at samba.org>
commit af608cdd8c6c2d5eaddcca90ccd8d075ddcb6c7e
Author: Volker Lendecke <vl at samba.org>
Date: Thu Nov 8 12:00:11 2012 +0100
s3: Use db_ctdb_ltdb_parse in db_ctdb_fetch_db_seqnum_from_db
Reviewed-by: Michael Adam <obnox at samba.org>
commit 71273448637e65b920535c077959e8dbb5444299
Author: Volker Lendecke <vl at samba.org>
Date: Thu Nov 8 11:52:43 2012 +0100
s3: Use db_ctdb_ltdb_parse in db_ctdb_ltdb_fetch
Reviewed-by: Michael Adam <obnox at samba.org>
commit 560ed93147b4da8b6124837133b90b4f95dbd6fc
Author: Volker Lendecke <vl at samba.org>
Date: Thu Nov 8 11:37:30 2012 +0100
s3: Add db_ctdb_ltdb_parse
Reviewed-by: Michael Adam <obnox at samba.org>
commit 6e0259d8ec4698384be803e0dc75f3ed2eef4ab1
Author: Volker Lendecke <vl at samba.org>
Date: Wed Nov 7 16:39:16 2012 +0100
s3: Slightly simplify db_ctdb_transaction_commit
Avoid an unnecessary "else".
Reviewed-by: Michael Adam <obnox at samba.org>
commit b206b5274878bbf47cd19db0fccc025a1ac16784
Author: Volker Lendecke <vl at samba.org>
Date: Wed Nov 7 16:25:31 2012 +0100
s3: Remove header==NULL code from db_ctdb_marshall_record
The only call chain (via db_ctdb_marshall_add) has header != NULL
Reviewed-by: Michael Adam <obnox at samba.org>
commit 24c36e748414d70ede930e8418455a2c11068d49
Author: Volker Lendecke <vl at samba.org>
Date: Wed Nov 7 21:24:27 2012 +0100
s3: test dbwrap_ctdb
Reviewed-by: Michael Adam <obnox at samba.org>
commit 8300791a6765499bcc8b892863d319f59332d9e3
Author: Volker Lendecke <vl at samba.org>
Date: Thu Nov 8 14:15:25 2012 +0100
dbwrap: Use dbwrap_parse_record in dbwrap_fetch_uint32_bystring
Reviewed-by: Michael Adam <obnox at samba.org>
commit 26a0ee5a0d915961067050564197a3d44b22d1e3
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 29 10:15:49 2012 +0100
docs: man oLschema2ldif: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Thu Nov 29 15:27:45 CET 2012 on sn-devel-104
commit e9e9661b23cf8b9da48284bda4e41cd6d98a2050
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 29 10:15:07 2012 +0100
docs: man ntlm_auth4: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 6ba7a6686c1e535343aad7748a2338b1bc4a3a6f
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 29 10:14:15 2012 +0100
docs: man smbtorture: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 122cc5b0230c0f99263ea1f156a34bbcf8b7664d
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 29 10:09:07 2012 +0100
docs: man masktest: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit cb501f99d26b638c6bf3ae431a2c31febd54c4f6
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 29 10:04:43 2012 +0100
docs: man locktest: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit bd3ad42d07971496b6fd800b752eb0a1b07568e2
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 29 10:04:26 2012 +0100
docs: man gentest: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 7b6186c18848675118b59bb33c2a7e41f60d4eb3
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 29 10:03:52 2012 +0100
docs: man 8 samba: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit c86707973dc7b17651187ea59b102859fa6531f2
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 29 10:03:19 2012 +0100
docs: man regtree: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 53b9e4ba6b76cc3282a6bd1be6fa1a98ababca96
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 29 10:02:51 2012 +0100
docs: man regshell: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 9678fca3c62a20b1bdef6b42a4449d23ed5dccc5
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 29 10:02:30 2012 +0100
docs: man regpatch: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 1ad091296df5f96729e8c6a76a07538522fab2c6
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 29 10:02:12 2012 +0100
docs: man regdiff: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 83fdfe36ba8e0503a6d147f7945ea1f043078901
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 29 10:01:39 2012 +0100
docs: man ndrdump: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 68c6dcb0942244f542eec7bbe5fba78ef7f66051
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 29 10:01:06 2012 +0100
docs: man tdbtool: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 174ab3542dcb49ae9bf827bea747a6135805ef04
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 29 10:00:45 2012 +0100
docs: man talloc: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 0162dd55d3fc047333db79db7ebf37a8e6721c64
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 29 10:00:10 2012 +0100
docs: man ldbsearch: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 787a58b4a7500c8bedc177579926cd9453b26c4b
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 29 09:59:52 2012 +0100
docs: man ldbrename: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 1404a24d3e92790d4306017ad08593d4b054eb53
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 29 09:59:32 2012 +0100
docs: man ldbmodify: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 0b900da6ace34d61adc13512a6b7b94e08719b69
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 29 09:59:15 2012 +0100
docs: man ldbedit: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 1d5ef8931c9e0179905de7dbcab020b4d5faa1c0
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 29 09:58:52 2012 +0100
docs: man ldbdel: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 08e63057de474441d06d6564e3c297aebb017a47
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 29 09:58:23 2012 +0100
docs: man ldbadd: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit ac4881bd0185f1d9b3f2df6e3ad3dc82bcb0e5d2
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 29 09:56:25 2012 +0100
docs: man ldb.3: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
commit e19da78ce0cf9586efa4644dc4ca5ef9cc8962f9
Author: David Disseldorp <ddiss at samba.org>
Date: Tue Nov 27 14:39:41 2012 +0100
s3-printing: add missing carriage return to debug str
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 21bd2787ae2a8864f0661b102d53bd102dbfd9f6
Author: David Disseldorp <ddiss at samba.org>
Date: Thu Nov 29 12:22:48 2012 +0100
rpcclient: fix usage docs for rpcclient adddriver
The printer driver name is incorrectly referred to as the printer name.
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 27d23dd3a94e4c870ac5f2c696b4da0e3829c109
Author: David Disseldorp <ddiss at samba.org>
Date: Thu Nov 29 12:10:45 2012 +0100
selftest: configure printer with default devmode = no
This allows us to reproduce the segfault described in bug 9433.
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 2e12deedcfdc5ce3637a125b083b0f00b208bf61
Author: David Disseldorp <ddiss at samba.org>
Date: Tue Nov 27 16:10:28 2012 +0100
spoolss: fix segfault when "default devmode" is disabled
Currently when "default devmode" is explicitly disabled, and a printer
is added with a null device mode, spoolssd crashes in copy_devicemode().
Both construct_printer_info2() and construct_printer_info8() code paths
currently unconditionally attempt to copy a printers device mode,
without checking whether one is present.
This change fixes this regression such that construct_printer_info*()
functions check for a null device mode before copying.
https://bugzilla.samba.org/show_bug.cgi?id=9433
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Thu Nov 29 13:03:05 CET 2012 on sn-devel-104
commit 941bb9bb6dfd1c2dfd01696b2169e0782158ad6d
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed Nov 28 12:46:31 2012 +0100
docs: Rename man ntlm_auth.
Rename man ntlm_auth to ntlm_auth4.
Karolin
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Wed Nov 28 20:41:48 CET 2012 on sn-devel-104
commit 29f90ecf53c8cebe955d5bb6762c6fe6de008ff0
Author: Volker Lendecke <vl at samba.org>
Date: Tue Nov 27 15:40:06 2012 +0100
s3: Use dbwrap_parse_record in fetch_share_mode_unlocked
Reviewed-by: Andreas Schneider <asn at samba.org>
commit cb0064d35cdc60c7c625ad4561ad77739f8553c5
Author: Andreas Schneider <asn at samba.org>
Date: Wed Nov 28 12:53:39 2012 +0100
BUG 9436: Fix leaking sockets of SMB connections to a DC.
As this is a burst of 3 unbound sockets with each try to reach a DC
we're running out of file descriptors pretty fast. So winbind is then
mostly spinning in an accept loop failing with EMFILE.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Jim McDonough <jmcd at samba.org>
Autobuild-User(master): Jim McDonough <jmcd at samba.org>
Autobuild-Date(master): Wed Nov 28 17:17:21 CET 2012 on sn-devel-104
commit bc6bceec655f241f23d713edc0d7a2633b5d6592
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 28 11:44:58 2012 +0100
s3:vfs_gpfs: add no memory check in gpfs2smb_acl()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Wed Nov 28 14:06:27 CET 2012 on sn-devel-104
commit 0f630abb3f197a8b672c6aa96362d83fdad1f92f
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 28 11:44:15 2012 +0100
s3:vfs_gpfs: make sure we return the correct errno in gpfs2smb_acl()
TALLOC_FREE() could overwrite errno.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit b3eb78c4f7123ccad6af50379c29d0939590d1ff
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 28 11:38:13 2012 +0100
s4:smbd/open: add missing TALLOC_FREE(frame) to inherit_new_acl()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit d5987048347beefa720f902d97b621e6cb719fdf
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 28 11:21:51 2012 +0100
s3:vfs_aixacl2: make use of vfs_aixacl_util.h
This should fix the build.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 00e2d83fa4f1e9a336c2030a3f07066caee85083
Author: Volker Lendecke <vl at samba.org>
Date: Tue Nov 20 10:02:07 2012 +0100
s3: Open gencache_notrans with TDB_NOSYNC
We are doing CLEAR_IF_FIRST here, and we are doing the transactions only to
protect gencache_stabilize against concurrent writers. tdb's transaction.c
says:
- if TDB_NOSYNC is passed to flags in tdb_open then transactions are
still available, but no fsync/msync calls are made. This means we
are still proof against a process dying during transaction commit,
but not against machine reboot.
For gencache_notrans.tdb this is exactly what we want and avoids some expensive
disk syncs.
Reviewed by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Nov 28 03:13:56 CET 2012 on sn-devel-104
commit ee5db0efa517fcf119d0318376030c01fb8f2f38
Author: Volker Lendecke <vl at samba.org>
Date: Tue Nov 20 09:50:57 2012 +0100
s3: Avoid some transaction_commit on gencache.tdb
Commits are expensive, and in some scenarios we are overwriting existing values
again and again.
Reviewed by: Jeremy Allison <jra at samba.org>
commit 5f0f50c542450b7ede855f8e538ec90450cd10ab
Author: Karolin Seeger <kseeger at samba.org>
Date: Tue Nov 27 11:46:38 2012 +0100
docs: Add some binaries to the "SEE ALSO" section
of man smb.conf.
Karolin
Reviewed by: Jeremy Allison <jra at samba.org>
commit 4a1b16fe57c31ae8125475137088215426997749
Author: Karolin Seeger <kseeger at samba.org>
Date: Tue Nov 27 11:29:26 2012 +0100
docs: Fix version in man smb.conf.
Karolin
Reviewed by: Jeremy Allison <jra at samba.org>
commit 5f2edd13efd447df0500952a0946188432453eb7
Author: Volker Lendecke <vl at samba.org>
Date: Sat Nov 24 11:39:02 2012 +0100
s3: Fix bug 9428 -- inotify detection broken
Reviewed by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Nov 27 01:20:24 CET 2012 on sn-devel-104
commit ed68f75b676a6b1d08f9668d29ff6d09f558fbe6
Author: Volker Lendecke <vl at samba.org>
Date: Sun Nov 25 14:19:32 2012 +0000
s3: Do not free a string where we should not
Reviewed by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Mon Nov 26 22:03:05 CET 2012 on sn-devel-104
commit db68915a4eaaedede9dac77c6c748718ce156139
Author: Volker Lendecke <vl at samba.org>
Date: Sun Nov 25 14:19:32 2012 +0000
s3: Do not free a string where we should not
Reviewed by: Jeremy Allison <jra at samba.org>
commit 994eec4d5861c0027b4f863baf095d95ce22c695
Author: Volker Lendecke <vl at samba.org>
Date: Sun Nov 25 10:19:23 2012 +0100
s3: Fix Coverity ID 741407 -- resource leak
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Mon Nov 26 19:20:05 CET 2012 on sn-devel-104
commit b11ba248837ae9bf1df1c5ae1ca1768d57e582bb
Author: Günther Deschner <gd at samba.org>
Date: Fri Nov 23 18:15:30 2012 +0100
s3-rpc_client: try to use socket_addr if available in rpc_pipe_open_tcp() (bug #9426)
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Mon Nov 26 17:36:20 CET 2012 on sn-devel-104
commit 8336061096c259f5c3c93f869ff51bf4daab3fdc
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Nov 24 11:28:57 2012 +0100
s4:torture/rpc/handles: try to make all assoc_group tests less flakey
Just incrementing the assoc_group_id makes it too likely to hit
a number that is already in use.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Mon Nov 26 13:53:22 CET 2012 on sn-devel-104
commit e4218e46c77e8d0c4f6c839024620c48f101e2f2
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 23 12:21:49 2012 +0100
configure(waf): Fail "configure --with-ads" if ads support is not available
Fix for bug #9350
This establishes the "auto" mode as default for ads-support, when
neither "--with-ads" nor "--without-ads" is specified for configure.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Björn Baumbach <bb at sernet.de>
Signed-off-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Fri Nov 23 19:34:55 CET 2012 on sn-devel-104
commit 2032f2746d70bbebd1af26a7a046eb1cc61ac175
Author: Günther Deschner <gd at samba.org>
Date: Fri Nov 23 13:19:53 2012 +0100
s3-rpc_client: lookup nametype 0x20 in rpc_pipe_open_tcp_port(). (bug #9426)
The server name type (0x20) is much more likely to be available in the name cache, as
this type gets stored by winbind itself - the primary user of the ncacn_ip_tcp
code currently.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Fri Nov 23 16:30:57 CET 2012 on sn-devel-104
commit 8f4b871e9776245f599a302f569594aaba9d25c9
Author: Matthieu Patou <mat at matws.net>
Date: Wed Nov 21 12:07:42 2012 -0800
Fix MD5 detection in the autoconf build
This is a front port of patches made in 3.6.x branch for bugs:
* 9037
* 9086
* 9094
* 9418
It checks if there is a library for md5 related functions (libmd or
libmd5) and if so it checks for the presence of md5.h headers it also
respect the need for osX build to not use samba's md5 implementation as
it's already present in the system libs.
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Fri Nov 23 10:05:34 CET 2012 on sn-devel-104
commit 0d9bdcf834cbe9ec4e1354bc7e912f197bf72d7b
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Nov 22 00:47:00 2012 +0000
web_server: Load SWAT if it is available.
Reviewed-by: Matthieu Patou <mat at matws.net>
Autobuild-User(master): Matthieu Patou <mat at samba.org>
Autobuild-Date(master): Fri Nov 23 01:39:38 CET 2012 on sn-devel-104
commit bfc6a9e21d2955d0662e4179448c7031806ad6d7
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Nov 22 00:46:59 2012 +0000
web_server: the web server is not multi-process, indicate so in WSGI.
This is a requirement for some of the paster middleware used by SWAT2.
Reviewed-by: Matthieu Patou <mat at matws.net>
commit b89e7f6e51011cce264a9a0c8796a5d4811007d7
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Nov 22 00:46:58 2012 +0000
web_server: Properly decrement reference counters for python objects in wsgi.
Reviewed-by: Matthieu Patou <mat at matws.net>
commit ac635d02de202523d8921ce752d7f93e2377bb07
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Nov 22 00:46:57 2012 +0000
web_server: Properly set SCRIPT_NAME and PATH_INFO.
Reviewed-by: Matthieu Patou <mat at matws.net>
commit 3bffb585ba36753cf1ebd5c00e7a47f1974b0d85
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Nov 22 00:46:56 2012 +0000
web_server: Create a string object for SERVER_PORT variable.
This matches the behaviour of other wsgi server implementations.
Reviewed-by: Matthieu Patou <mat at matws.net>
commit 31f0e24fbe5f3da7e1a3e4b0ae234c0803123501
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Nov 22 00:46:55 2012 +0000
web_server/wsgi: Don't segfault when wsgi app doesn't return iterable.
There is a bug in the application if this happens, but invalid Python
code shouldn't cause segfaults.
Reviewed-by: Matthieu Patou <mat at matws.net>
commit f22e15d9d5a3d4744982265363c357ef277ba31e
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Nov 21 20:20:46 2012 +1100
build: Do not install testing binaries
These binaries are for developer or selftest use, and are not
supported for installation onto the system. The autoconf build does
not install these binaries, and so neither should the waf build.
Andrew Bartlett
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Thu Nov 22 12:00:36 CET 2012 on sn-devel-104
commit 895cc9a9157d51f768d35f888795e8af7efed781
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Nov 21 19:52:50 2012 +1100
packaging: Remove long-gone --disable-merged-build from RHEL-CTDB packaging
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 7626b5d9045c2b490b38dee7dd45ba7763740f83
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Nov 21 17:52:35 2012 +1100
build: Remove --enable-smbtorture, require bin/smbtorture (from waf) for make test
This simply moves this to being a side-effect of --enable-selftest.
The flag was renamed from --enable-smbtorture4 in a recent patch.
Make test now relies on smbtorture4, and so this code to make the dependency
optional for the tests is not required any more.
Andrew Bartlett
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 8a2ef49dea36b103a87cf2aa63417737dd754ce6
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Nov 21 16:32:38 2012 +1100
build: Be consistent with the name of smbtorture binaries
This ensures that in both build systems, smbtorture3 is the source3 binary, and
smbtoture is our main smbtorture binary, built with waf.
Also included in this is the removal of bin/ndrdump4 as a special case.
This removes the last cases of binaries with different names in
each build system.
Andrew Bartlett
Reviewed-by: Andreas Schneider <asn at samba.org>
commit ef195a18aac1f2b1ebfd34741d2242f659896549
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Nov 21 16:00:53 2012 +1100
torture: remove source3 locktest and masktest
We now just build these in waf, using the source4/torture code.
The source4 versions of these are tested in make test.
Andrew Bartlett
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 1000da933534f1148f5b6f9db2029a5074917968
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Nov 21 15:34:43 2012 +1100
build: Use ntlm_auth from source3 as the only ntlm_auth installed on the system
The ntlm_auth4 binary is untested, and is missing major features compared with
the source3 binary. The two are being slowly merged, but I have not finished
that.
Andrew Bartlett
Reviewed-by: Andreas Schneider <asn at samba.org>
commit c704f0daa5e81911ea2b507323b5005303f61e91
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Nov 19 23:25:45 2012 +1100
lib/replace: Do not use STRERROR_R_PROTO_COMPATIBLE as only roken.h sets this
Currently, we put strerror_r into libreplace even on systems with strerror_r.
Andrew Bartlett
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 831a9f8f6dc7057855b75128bf14ed9d4a03ab26
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Nov 21 22:56:57 2012 +0000
s4/web_server: Fix typo in URL.
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Thu Nov 22 01:37:02 CET 2012 on sn-devel-104
commit d6983f470410b0befc02e43580d9b9d74d8f5d23
Author: Christian Ambach <ambi at samba.org>
Date: Tue Nov 20 14:24:13 2012 +0100
s3:smbd/aio do not mark file modified during reads
this causes each file that is potentially just opened for reading to be
marked as modified and lots of file change notifications will be send
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Christian Ambach <ambi at samba.org>
Autobuild-Date(master): Tue Nov 20 21:02:34 CET 2012 on sn-devel-104
commit 611675fb37b5745bd2ff81bfa5739c050b15e9a7
Author: Volker Lendecke <vl at samba.org>
Date: Wed Nov 7 16:22:07 2012 +0100
s3: Fix some blank line endings
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Nov 20 19:18:33 CET 2012 on sn-devel-104
commit 1199ab1f84dc7858afa137be2743c8df0735e3aa
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Nov 13 09:34:43 2012 +0100
librpc/idl: teach ndrdump about dumping security.idl structures
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 6b123607c8afa30a7f9dc62101063eb8a9a00779
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Nov 12 10:16:50 2012 +0100
s3:librpc: add support for PFC_FLAG_OBJECT_UUID when parsing packets (bug #9382)
Now the logic matches the one in dcerpc_read_ncacn_packet_done().
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 6568a26f0142950300ae8503b8bc2bffb8a77352
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 14 08:45:10 2012 +0100
s4:torture/rpc/handles: try to make the assoc_group test less flakey
Just incrementing the assoc_group_id makes it too likely to hit
a number that is already in use.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 14ee2cd938a963d5b3398eed4f21ff64630afdcd
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Nov 20 14:13:16 2012 +0100
s4:torture/rpc/handles: move a torture_comment()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 4fb0b61ad8fd45a7eff7756d43ce646ed051ee1a
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Nov 20 13:50:46 2012 +0100
s3:param: set "map archive = no" in ROLE_ACTIVE_DIRECTORY_DC
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f0c8c8518b2f25eb9e666229c37e191fa1700d0d
Author: Christian Ambach <ambi at samba.org>
Date: Tue Nov 20 09:50:15 2012 +0100
examples: fix build on AIX6
Signed-off-by: Christian Ambach <ambi at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Tue Nov 20 16:06:59 CET 2012 on sn-devel-104
commit 1fb8f8c5046cd7d0638be0d8a4b9a0e9a5799f6b
Author: Christian Ambach <ambi at samba.org>
Date: Tue Nov 20 09:49:46 2012 +0100
build(waf): fix a typo
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Tue Nov 20 11:54:51 CET 2012 on sn-devel-104
commit c5ad5029fd87b36426927d57425d5debbb26394c
Author: Jeremy Allison <jra at samba.org>
Date: Wed Nov 14 14:40:51 2012 -0800
More for #9374 - Allow smb2.acls torture test to pass against smbd with a POSIX ACLs backend.
Change can_delete_directory() to can_delete_directory_fsp(), as
we only ever call this from an open directory file handle.
This allows us to use OpenDir_fsp() instead of OpenDir().
OpenDir() re-checks the ACL on the directory, which may
refuse DIR_LIST permissions. OpenDir_fsp() does not. As
this is a file-server internal check to see if the directory
actually contains any files before setting delete on close,
we can ignore the ACL here (Windows does).
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Nov 20 01:46:28 CET 2012 on sn-devel-104
commit 4985332b951d8cd46c9c0cd877875ab7839b4edb
Author: Jeremy Allison <jra at samba.org>
Date: Wed Nov 14 14:40:50 2012 -0800
Add comments explaining exactly *why* we don't check FILE_READ_ATTRIBUTES when evaluating file/directory ACE's.
If we can access the path to this file, by
default we have FILE_READ_ATTRIBUTES from the
containing directory. See the section.
"Algorithm to Check Access to an Existing File"
in MS-FSA.pdf.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e6a100e86b7adf1c06a7c06b24fa50717ddcdb67
Author: Christian Ambach <ambi at samba.org>
Date: Mon Nov 5 18:49:54 2012 +0100
s3:modules:nfs4_acls remove unused mem_ctx parameter to smbacl4_fill_ace4
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sat Nov 17 01:11:07 CET 2012 on sn-devel-104
commit c9d70740e39722a2f98ccd932b053723a4f3de62
Author: Christian Ambach <ambi at samba.org>
Date: Mon Nov 5 18:47:01 2012 +0100
s3:modules:nfs4_acls fix memory hierarchy in smb_create_smb4acl
the ACEs should be talloc children of the ACL itself and not be placed on talloc_tos()
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 775d0a78c496af8ddbde9eb0f8c2f6d5dc5bcc81
Author: Christian Ambach <ambi at samba.org>
Date: Fri Nov 2 08:41:40 2012 +0100
s3:vfs_gpfs fix a memory leak in gpfsacl_get_posix_acl
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 1a71f07cee0bfe50ea6821a195a950d2206aab55
Author: Christian Ambach <ambi at samba.org>
Date: Fri Nov 2 08:41:10 2012 +0100
s3:vfs_gpfs fix memory corruption in gpfs2smb_acl
sys_acl_init returns a SMB_ACL_T with zero entries in the acl array
reallocate the array to proper size before filling it, otherwise we overwrite memory
This one is a result of a improper fixing in 7a6182962966e5edb42728c8
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 3dab1ef8a57670a36a81e706895bbe225892f3ff
Author: Christian Ambach <ambi at samba.org>
Date: Fri Nov 2 08:39:45 2012 +0100
s3:vfs_gpfs fix memory leak in gpfs_get_nfs4_acl
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 3925a7114caaac56e79849ebf3aa13784918282b
Author: Christian Ambach <ambi at samba.org>
Date: Fri Nov 2 08:39:17 2012 +0100
s3:vfs_gpfs fix memory leaks in gpfs_getacl_alloc
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 10b6cceb1f0f09c7a8f5fc8882fdc3852d11951f
Author: Kai Blin <kai at samba.org>
Date: Wed Nov 14 11:32:06 2012 +0100
samba-tool dns: Don't use "localhost" to connect to local host
Calling "samba-tool dns <cmd> localhost" provokes a stacktrace.
This just makes 'samba-tool dns <cmd> localhost' work and doesn't fix
the underlying issue, but I don't see it causing any harm (unless you
don't have an ipv4 localhost, I guess).
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Fri Nov 16 13:18:14 CET 2012 on sn-devel-104
commit d5de797af2aeb3697022e33ea51c516621b25e2f
Author: Kai Blin <kai at samba.org>
Date: Fri Nov 16 09:59:53 2012 +0100
utils: Remove unused samba-dig tool
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 945bc84818039b79f4d9b7982e24c1e0e7dd8a45
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Sep 12 15:34:29 2012 +0200
dsdb: Make secrets_tdb_sync cope with -H secrets.ldb
The issue was, without a / in the path, we did not cope.
Andrew Bartlett
Reviewed-by: Michael Adam <obnox at samba.org>
commit d7cab973fc3213ff777bff519eb001ae7d1c1bdc
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 16 01:00:21 2012 +0100
s3:param: make init_locals() static.
it is only used in loadparm.c
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Fri Nov 16 03:33:34 CET 2012 on sn-devel-104
commit 3fc2c03ea3dcc36778e92115a0dbca42531bd4dd
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Nov 16 10:30:44 2012 +1100
s3-param: Handle setting default AD DC per-share settings in init_locals()
This function is helpfully called between when we finish processing
the globals and when we start processing the individual shares. This
means that the "vfs objects" and other per-share settings we specify
here become the defaults for (eg) [netlogon] and [sysvol] but the
admin can override these on a per-share basis or (as we must in make
test) for the whole server.
This broke setting and fetching of group policy objects from Windows
clients, since this setting was moved from fileserver.conf in
8518dd6406c0132dfd8c44e084c2b39792974f2c, and wasn't found in 'make
test' because we have to override the vfs objects to insert the
xattr_tdb and fake_acl modules.
Andrew Bartlett
Reviewed-by: Michael Adam <obnox at samba.org>
commit ace0909b88739338e948b9c1e98307f324bb7503
Author: Arvid Requate <requate at univention.de>
Date: Wed Nov 14 15:51:19 2012 +0100
s4:samba-tool: Fix samba-tool fsmo --role=schema
Fix traceback:
samba-tool fsmo --role=schema --force
ERROR(<type 'exceptions.TypeError'>): uncaught exception - argument 2 must be string, not ldb.Dn
File "/usr/lib/python2.6/dist-packages/samba/netcmd/__init__.py", line 168, in _run
return self.run(*args, **kwargs)
File "/usr/lib/python2.6/dist-packages/samba/netcmd/fsmo.py", line 160, in run
self.seize_role(role, samdb, force)
File "/usr/lib/python2.6/dist-packages/samba/netcmd/fsmo.py", line 119, in seize_role
m.dn = ldb.Dn(samdb, self.schema_dn)
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Fri Nov 16 00:40:24 CET 2012 on sn-devel-104
commit 256391c0faf4ff4d408821e3fe8cfe2eff44c043
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Nov 5 19:36:28 2012 +1100
samba-tool: Add new samba-tool gpo aclcheck and test
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit cf1540b73714fac6b25de5942cbd821e5f4f6ffc
Author: Jeremy Allison <jra at samba.org>
Date: Tue Nov 13 11:22:15 2012 -0800
Another fix needed for bug #9236 - ACL masks incorrectly applied when setting ACLs.
Not caught by make test as it's an extreme edge case for strange
incoming ACLs. I only found this as I'm making raw.acls and smb2.acls
pass against 3.6.x and 4.0.0 with acl_xattr mapped onto a POSIX backend.
An incoming inheritable ACE entry containing only one permission,
WRITE_DATA maps into a POSIX owner perm of "-w-", which violates
the principle that the owner of a file/directory can always read.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Thu Nov 15 19:52:52 CET 2012 on sn-devel-104
commit 4ed7803c803e94f5887775f1acb902063f7bcc86
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed Nov 14 11:40:27 2012 +0100
popt_common: Fix typos.
Karolin
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed by: Jelmer Vernooij <jelmer at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Nov 15 01:31:50 CET 2012 on sn-devel-104
commit a15da3625850d97b3da1b02308c870f820007c52
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Nov 13 14:07:11 2012 +0100
lib/replace: replace all *printf function if we replace snprintf (bug #9390)
This fixes segfaults in log level = 10 on Solaris.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Björn Jacke <bj at sernet.de>
Autobuild-User(master): Björn Jacke <bj at sernet.de>
Autobuild-Date(master): Wed Nov 14 19:41:14 CET 2012 on sn-devel-104
commit a53caea7a27c8616cabfc2e5bdf91a90e35891d5
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Nov 14 09:47:16 2012 +0100
subunit: Update to latest upstream version.
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Wed Nov 14 12:11:58 CET 2012 on sn-devel-104
commit 7b654a8c180a6467147189332916a5e56634b5af
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Nov 14 09:46:53 2012 +0100
testtools: Update to latest version.
commit d10c7378d96d322910e87c21a1a3a3b28b229687
Author: Richard Sharpe <realrichardsharpe at gmail.com>
Date: Tue Nov 13 13:53:35 2012 -0800
smbd_open_one_socket does not use the messaging_context variable so why pass it in?
Reviewed by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Nov 14 02:19:46 CET 2012 on sn-devel-104
commit ec423dc2eb1aae408b37034fd497ecef285f7fb9
Author: Richard Sharpe <realrichardsharpe at gmail.com>
Date: Tue Nov 13 11:27:53 2012 -0800
A small error message fix in source3/smbd/server.c
Removes some incorrect info from an error message
(probably from its old place when it was copied).
Reviewed by: Jeremy Allison <jra at samba.org>
commit a390a5878db627a7f0147699fff97a39013816dc
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Nov 13 16:03:27 2012 +1100
scripting ntacls: Do not place a SACL in the GPO filesystem ACL
On a new GPO created on windows, the SACL is not used.
Andrew Bartlett
Reviewed by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Wed Nov 14 00:34:50 CET 2012 on sn-devel-104
commit 3e2584a86cc610c000f70105f39e7f3fa881aded
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Nov 13 16:45:03 2012 +1100
ntvfs: Fill in sd->type based on the new ACL being added
Previously we would not change the type field, and just relied on what
was in the original ACL based on the default SD.
This is required to ensure the SEC_DESC_DACL_PROTECTED is set
which is in turn required for GPOs to be set correctly
to match what windows does.
Andrew Bartlett
Reviewed by: Jeremy Allison <jra at samba.org>
commit d6c7e9b1ed6f7befbb2239350bba4547ef781e58
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Nov 12 17:11:34 2012 +1100
smbd: Remove NT4 compatability handling in posix -> NT ACL conversion
NT4 is long dead, and we should not change which ACL we return based
on what we think the client is. The reason we should not do this, is
that if we are using vfs_acl_xattr then the hash will break if we do.
Additionally, it would require that the python VFS interface set the
global remote_arch to fake up being a modern client.
This instead seems cleaner and removes untested code (the tests are
updated to then handle the results of the modern codepath).
The supporting 'acl compatability' parameter is also removed.
Andrew Bartlett
Reviewed by: Jeremy Allison <jra at samba.org>
commit 236977bf4642c035bb22cfcd1cee481c5f6c6da1
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Nov 13 12:48:53 2012 -0800
Change get_nt_acl_no_snum() to return an NTSTATUS, not a struct security_descriptor *.
Internally change the implementation to use SMB_VFS_GET_NT_ACL()
instead of SMB_VFS_FGET_NT_ACL() with a faked-up file struct.
Andrew Bartlett
Reviewed by: Jeremy Allison <jra at samba.org>
commit a4434297f19a3520d0f2ac242d4e99576d927ecc
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Nov 13 12:34:35 2012 -0800
smbd: Correctly set fsp->is_directory before dealing with ACLs
Change set_nt_acl_no_snum() to correctly set up the fsp.
This does a stat on a real fsp in set_nt_acl_no_snum.
Reviewed by: Jeremy Allison <jra at samba.org>
commit dc05ab8e19a26265ace720528f7e9341aea62ee2
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Nov 13 12:21:45 2012 -0800
Ensure we Correctly set fsp->is_directory before dealing with ACLs.
Reviewed by: Jeremy Allison <jra at samba.org>
commit 6f47497610352f72128bdbcd3b45313ea9a265ab
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Nov 12 11:42:52 2012 +0100
lib/ldb: add missing newline in the output of ldb_ldif_write_trace()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue Nov 13 13:53:31 CET 2012 on sn-devel-104
commit 11f5d54cbb10fd5c5f0e1718427609709c3476f4
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 9 09:01:29 2012 +0100
s4:samba-tool/testparm: report a CommandError if loading of the config file fails
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 1ecc76b2480c884a66e598ff6b1f9000bb0931c0
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 9 09:08:51 2012 +0100
lib/addns: remove compiler warnings
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit eecc1d294256210ee8c2f6ab79d21b835258a6d4
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 9 08:59:36 2012 +0100
lib/addns: don't depend on the order in resp->answers[]
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit b59c5db5f74f56c0536635a41ae51c389109ceb5
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 9 08:55:40 2012 +0100
lib/addns: remove pointless check for resp->num_additionals != 1
We never use resp->additionals, so there's no reason to check.
This fixes dns updates against BIND9 (used in a Samba4 domain).
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 095c7627dfbc1e25665d342699ea004dc8d0880b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Nov 13 13:31:53 2012 +1100
selftest: Add --tmpdir to 'samba-tool gpo create' test
This was the cause of the flakey test, and was only noticed when
multiple different users ran autobuild at the same time on the same
server.
We use shutil.rmtree to wipe the directory before the tests finishes
as required by the TestCaseInTempDir class.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Nov 13 10:50:56 CET 2012 on sn-devel-104
commit c5f53ed580d92088f544a7d66b8b276fef8f3ab7
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Nov 12 21:49:36 2012 +1100
Revert "selftest/skip: add samba.tests.samba_tool.gpo until it's stable"
This reverts commit 47bbf9886f0cebf994435a32bafa07e36cce191b.
This test appears to be stable now, but the changes in the previous
commit should allow the real error to be found if it comes back.
As requested by metze.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue Nov 13 01:45:04 CET 2012 on sn-devel-104
commit 4d6d6e446c030bb6cf3f27ba257e713ac6701b7a
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Nov 12 21:48:46 2012 +1100
selftest: Avoid returning errors (rather than failures) in gpo test
This should help find the real cause of the flakey test, if it ever returns.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 3b01dd5f59841b11e9906b8c23345946e0d0ea8c
Author: Andreas Schneider <asn at samba.org>
Date: Fri Nov 9 15:33:09 2012 +0100
s3:winbind: BUG 9386: Failover if netlogon pipe is not available.
Samba continues to query a broken DC while the DC did not finish to
rebuild Sysvol (after a Windows crash, for example). It causes end users
to received strange codes while trying to authenticate, even if there is
a secondary DC available.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Mon Nov 12 18:57:18 CET 2012 on sn-devel-104
commit 3bbe690c50a5d4e2ff81ff1eeeaa728990b73637
Author: Sumit Bose <sbose at redhat.com>
Date: Mon Oct 29 12:09:22 2012 +0100
Use work around for 'winbind use default domain' only if it is set
Currently in smb_getpwnam() the NetBIOS domain name and the winbind separator
character is always added to the user name returned by Get_Pwnam_alloc() if it
does not contain the winbind separator character. As comments in the code
indicates this is done as a work around if 'winbind use default domain' is set
to yes in the samba configuration.
This make sense if the option is set because otherwise the domain information is
lost from the user name. But it causes errors if other services than winbind are
used for user lookup, e.g. sssd. sssd can handle different kind of fully
qualified user names as input, e.g. user at domain.name or DOM\user, but returns a
canonical name, by default user at domain.name.
While it would be possible to get around this issue with a special configuration
either on the sssd or samba side I think the cleaner solution is to use the work
around only if 'winbind use default domain' is set to yes which is what this
patch does.
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Mon Nov 12 15:54:15 CET 2012 on sn-devel-104
commit 18e13224eb75349fc9790f20aab125f485979760
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Nov 11 21:32:22 2012 +1100
ntp_signd: Only allow group access to the ntp signd directory.
Existing installations running ntp as group 'ntp' will need to change
the permissions on the ntp_signd socket directory (eg
PREFIX/lib/ntp_signd or /var/lib/samba/ntp_signd)
The reason is that allowing other users on the host access to this
directory would allow them to potentially spoof time on the network,
or attack the password database with a chosen plaintext attack.
Permissions should be changed to:
ownership root:ntp (if ntp runs as gid ntp)
mode 0750 (this is what it will be created as)
If the permissions are not changed, Samba will refuse to start the
ntp_signd server, and NTP operations will not be signed. As the error
is declared fatal, in the future, Samba may totally refused to start.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Mon Nov 12 12:36:30 CET 2012 on sn-devel-104
commit 77bd7ea1664514a8988941d454fc621c7f0943d1
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Nov 12 08:44:02 2012 +1100
ntp_signd: move socket directory to var/lib not var/run for permissions change
With the next patch, this becomes a socket directory on which we must
maintain administrator-specified permissions we will need to move it
away from directories that wipe at boot.
This means the ntp.conf will need to change from (eg)
ntpsigndsocket /usr/local/samba/var/run/ntp_signd/
to
ntpsigndsocket /usr/local/samba/var/lib/ntp_signd/
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e0ab14f52a52c8317473b4c4cd3cf50265e1f9e4
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 9 17:23:53 2012 +0100
s4:dsdb/acl_read: make sure confidential attributes require CONTROL_ACCESS (bug #8620)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon Nov 12 01:25:21 CET 2012 on sn-devel-104
commit 21dfaefda0e22f7ddaac62bfd8b32e6fb9fc253d
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 9 17:22:44 2012 +0100
s4:dsdb/acl_read: fix whitespace formatting errors
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit f6fa7243f81891cb7703264da526fd873a9745e4
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 9 17:05:44 2012 +0100
s4:dsdb/acl: only give administrators access to attributes marked as confidential (bug #8620)
The full fix will to implement and use the code of the read_acl module,
but this is better than nothing for now.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ed8b27516b212b59167bb932de949a7b54dc44cb
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 9 11:23:47 2012 +0100
s4:dsdb/acl: reorganize the logic flow in the password filtering checks
This avoids some nesting levels and does early returns.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 54ad5c70e3cc731c872913841cbcd2ef29ec0e54
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 9 11:25:21 2012 +0100
s4:dsdb/acl: fix search filter cleanup for password attributes
We need to this when we're *not* system.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 94649e46b4dec528ab7e750d06a65ada3d978342
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Nov 12 07:53:40 2012 +1100
selftest: Avoid test cross-contamination in samba.tests.posixacl
This creates a new xattr.tdb per unit test, which avoids once and for all
the issue of dev/inode reuse.
For test_setposixacl_dir_getntacl_smbd the file ownership also set specifically.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 1d81e52bba65f05378db7027537aa27eb5bfa70a
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Nov 11 21:33:41 2012 +1100
selftest: Add tests for expected behaviour on directories as well as files
This is important because it covers the codepath which had the talloc
error fixed by commit 60cf4cb5a630506747431ecbf00d890509baf2f3
(vfs_acl_common: In add_directory_inheritable_components allocate on
psd as parent)
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sun Nov 11 15:48:10 CET 2012 on sn-devel-104
commit a6a01552efe69f6450425b001ad600ec056bd18c
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Nov 11 22:07:49 2012 +1100
pysmbd: Add SMB_ACL_EXECUTE to the mask set by make_simple_acl()
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 312f8ddae27f6fdf4f325edfa890a7b96cd348b8
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Nov 11 14:01:44 2012 +1100
selftest: Make samba.tests.ntacl also use TestCaseInTempDir
This follows on from the successful conversion of samba.tests.posixacl.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit b4d8629f511005540cb1fbbbe9abfb278c064ba2
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Nov 11 11:35:02 2012 +1100
samba-tool: Rework ldap attribute fetch in classicupgrade for missing attributes
Is is not required that these additional attributes be filled in, so
catch KeyError in both the nsswitch and ldap backend case.
We rework get_posix_attr_from_ldap_backend() so it raises KeyError
rather than trying to return None, and does not ignore other errors.
Andrew Bartlett
Tested-by: Chirana Gheorghita Eugeniu Theodor <office at adaptcom.ro>
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit c06d602d7f3b8d3da972071a1b5392c6b145133f
Author: Arvid Requate <requate at univention.de>
Date: Sat Nov 10 10:40:32 2012 +0100
s3:smbd: Fix typo in got_duplicate_group check
Reviewed by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sat Nov 10 20:25:48 CET 2012 on sn-devel-104
commit 01f188a3f0725f42ce4f17621985abe4ab5a54c2
Author: Christian Ambach <ambi at samba.org>
Date: Wed Nov 7 18:40:07 2012 +0100
build: add DMAPI configure option and checks
the waf build was missing the --with-dmapi option
and configure checks that are necessary to build the
source3 parts that need DMAPI (e.g. vfs_tsmsm)
Bug: https://bugzilla.samba.org/show_bug.cgi?id=9178
Signed-off-by: Christian Ambach <ambi at samba.org>
Autobuild-User(master): Christian Ambach <ambi at samba.org>
Autobuild-Date(master): Fri Nov 9 20:57:31 CET 2012 on sn-devel-104
commit 3712de7b9c494f6e01782e837f369e8beb5a054e
Author: Christian Ambach <ambi at samba.org>
Date: Fri Nov 9 18:58:43 2012 -0600
build(waf): support AIX 6.1
on AIX6.1, we need to define _ALL_SOURCE as well, otherwise
system headers with BSD types like u_int cannot be used
commit 52057477ee0642af4d6e9c220195c0933de7ba2e
Author: David Disseldorp <ddiss at samba.org>
Date: Wed Nov 7 13:06:54 2012 +0100
doc: list arguments for rpcclient FSRVP commands
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Fri Nov 9 18:21:39 CET 2012 on sn-devel-104
commit c70ffacf9406aa0c5aa417046aaa8f9c319fc8c2
Author: David Disseldorp <ddiss at samba.org>
Date: Tue Nov 6 12:49:42 2012 +0100
doc: describe samlogon cache caveat for winbindd -n
The samlogon cache is never bypassed, even when winbindd is run with the
-n argument.
See https://bugzilla.samba.org/show_bug.cgi?id=9125
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 9195792a38027eb30b6ac36a134d52be4db0087c
Author: David Disseldorp <ddiss at samba.org>
Date: Tue Nov 6 12:29:24 2012 +0100
Revert "s3-winbindd: make sure we obey the -n switch also for samlogon cache access."
This reverts commit ae6a779bf9f816680e724ede37324b7f5355996b.
Bug 9125 analysis from Volker:
The problem is that there are no network calls possible at all that
would do what the samlogon cache does for us. There is just no way to
retrieve the group membership in a complex trusted environment. If you
have just a single domain with Samba as domain controller it might be
possible, but even within a single domain it is not possible to
correctly retrieve all group memberships using LDAP calls due to ACLs on
directory objects. The call to get that is called NetSamLogon on the
NETLOGON pipe. But this call requires user credentials and might trigger
updating counts on the server. So to correctly implement wbinfo -r after
a user has logged in, you have two alternatives: Save the info3 struct
or the PAC in the netsamlogon cache. If you insist on doing network
calls, you need to cache the user credentials somewhere to re-do the
NetSamLogon call every time the wbinfo -r is requested.
Reviewed-by: Andreas Schneider <asn at samba.org>
commit ec0104b1e0eea73331c58d26ea96b5167c2847ed
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Tue Nov 6 22:29:07 2012 +0100
Makefile: Allow specifying PYTHON environment variable.
This is required for Minix, where python is named "python2.X".
Reviewed-by: Simo Sorce <idra at samba.org>
Signed-off-by: Jelmer Vernooij <jelmer at samba.org>
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Fri Nov 9 16:39:09 CET 2012 on sn-devel-104
commit 010fd296881aa643a4b631d57df503c9e832b35c
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Tue Nov 6 22:24:07 2012 +0100
configure: Support specifying PYTHON environment variable to run waf.
This is necessary to run configure on Minix, where python is named
"python2.X".
Reviewed-by: Simo Sorce <idra at samba.org>
Signed-off-by: Jelmer Vernooij <jelmer at samba.org>
commit 702049ef55dc17d2996a53a1c30be76591423970
Author: Andreas Schneider <asn at samba.org>
Date: Wed Nov 7 13:59:48 2012 +0100
torture: Fix smb2.create.blob test.
Reviewed-by: David Disseldorp <ddiss at samba.org>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Fri Nov 9 14:53:27 CET 2012 on sn-devel-104
commit 76fa5ee5d40e7e15c777ef11eb3492bcae7f4f0f
Author: Karolin Seeger <kseeger at samba.org>
Date: Fri Nov 9 09:07:38 2012 +0100
samba-tool: Fix typo in --help output.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Fri Nov 9 11:04:50 CET 2012 on sn-devel-104
commit f8c5f9836415ce0891624b170410e807abcfb706
Author: Matthieu Patou <mat at matws.net>
Date: Fri Oct 5 02:09:47 2012 -0700
s4-drs: Remove unused var
Signed-off-by: Matthieu Patou <mat at matws.net>
commit 50d47fc0816c842717a5c0bfb3c0863d99eed78c
Author: Andreas Schneider <asn at samba.org>
Date: Tue Nov 6 09:27:43 2012 +0100
s3fs-client: Burn commandline password of client utils.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Nov 8 21:24:21 CET 2012 on sn-devel-104
commit c51abb35dfff86cb503d36a844184f7a95f29cdb
Author: Andreas Schneider <asn at samba.org>
Date: Tue Nov 6 09:27:42 2012 +0100
s3fs-popt: Add function to burn the commandline password.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed by: Jeremy Allison <jra at samba.org>
commit d236709d15ba577def07f049c975069eb39ba1e3
Author: Volker Lendecke <vl at samba.org>
Date: Wed Nov 7 15:33:10 2012 +0100
Remove two unused variables
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Wed Nov 7 17:18:06 CET 2012 on sn-devel-104
commit 647a0fb098bada862b49a51e3a31be847207c59a
Author: Volker Lendecke <vl at samba.org>
Date: Tue Oct 30 23:15:09 2012 +0100
lib/util: Simplify bitmap.c a bit
This avoids the double-talloc for bitmaps
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 7f4d55d1b8bda4f0d7a8bdbfe82c9a623dfe5843
Author: Volker Lendecke <vl at samba.org>
Date: Tue Oct 30 22:43:21 2012 +0100
lib/util: Make "struct bitmap" abstract
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit da284b3765e3c73d204fe2c8b45d6fbd2c08d451
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Mon Nov 5 23:38:23 2012 +0100
heimdal_build: Fix finding of system heimdal.
When checking for Heimdal headers, make sure HAVE_CONFIG_H is not
defined, as config.h will not be available.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Signed-off-by: Jelmer Vernooij <jelmer at samba.org>
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Tue Nov 6 16:27:03 CET 2012 on sn-devel-104
commit 9cf985c53eb1a4bbe8b8110f123744291026cee6
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Mon Nov 5 23:33:21 2012 +0100
heimdal_build: HEIMDAL_LIBRARY(): Remove unused cflags argument.
commit 47bbf9886f0cebf994435a32bafa07e36cce191b
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Nov 6 12:16:37 2012 +0100
selftest/skip: add samba.tests.samba_tool.gpo until it's stable
See:
https://git.samba.org/autobuild.flakey/2012-11-06-0314/samba.stdout
https://git.samba.org/autobuild.flakey/2012-11-06-0514/samba.stdout
https://git.samba.org/autobuild.flakey/2012-11-06-0713/samba.stdout
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Nov 6 14:24:08 CET 2012 on sn-devel-104
commit 6073d214aa8bfeff8dae8cf151357f890dd37a48
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Tue Nov 6 01:25:00 2012 +0100
ldb_secrets_tdb_sync: Add dependency on gssapi.
This is required when building with the system heimdal, as
gssapi/gssapi_spnego.h is included.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue Nov 6 05:12:28 CET 2012 on sn-devel-104
commit ed6330094b47408f33c2d933e9c80b079dd891d6
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Tue Nov 6 01:24:59 2012 +0100
dsdb: Rename _res argument to _result.
Newer versions of heimdal include a macro that is unfortunately named
'_res'. This change prevents the clash.
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
commit ab30a8bf0fb9bd4ee3c907183132f3b9abb67c7a
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Nov 5 20:44:14 2012 +1100
provision: Make dsacl2fsacl() take a security.dom_sid, not str
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue Nov 6 00:12:43 CET 2012 on sn-devel-104
commit 033451587db21d6e4b829e89a64f894a32682131
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Nov 5 15:22:02 2012 +1100
provision: Also walk directories checking ACLs
The directory walk was missed due to a cut-and-paste error.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
commit abbbbb5cdc39b71c0f243ff1e660d1f35a4923e3
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Nov 5 19:35:51 2012 +1100
wintest: Try harder to recover from apparent failure to dcpromo
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
commit 0b7bb774ce836722d219d6e466a76b12c1a03de3
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Nov 5 12:57:17 2012 +1100
selftest: check that samba-tool gpo works for basic operations
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
commit 26faa8fe3a42f9d1278d81773c8808b05fcd76f8
Author: Volker Lendecke <vl at samba.org>
Date: Sat Nov 3 09:36:29 2012 +0100
dsdb: Simplify DsCrackNameOneFilter a bit
For me "else" branches clutter my flow reading code. If we do a hard
return at the end of an "if" branch, "else" is not required.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ec3cbb6c476698523c9b5ac047787df101746891
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Mon Nov 5 19:36:30 2012 +0100
wafsamba.abi: Fix abi_match with both excludes and includes.
This fixes a regression introduced by 9c3e294400234ebdf9b98031bae583524fd0b0ac
which caused internal symbols in libldb to be exposed.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=9357
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stephen Gallagher <sgallagh at redhat.com>
commit d02c8ba122cef7d8b254e5be3ae757eb3bb14235
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Mon Nov 5 19:36:29 2012 +0100
wafsamba.samba_abi: Add basic unit tests.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stephen Gallagher <sgallagh at redhat.com>
commit 97102fa9963ba88f4ab72165a02071990031a73b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Nov 6 07:48:52 2012 +1100
buildtools: Remove extra space from global: line
This makes it easier to put the expected values in a file
as we will not have trailing whitespace that is against git style.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ea5ef95fbebe28cca11f86a9015aab77522f5e18
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Mon Nov 5 19:36:28 2012 +0100
wafsamba.samba_abi: Refactor abi_write_vscript to take file argument.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stephen Gallagher <sgallagh at redhat.com>
commit 3d9361612d30725a3d14fa4d3a085256a91800db
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Nov 1 13:53:27 2012 +0100
s3:smbd: pass the current time to make_connection[_smb1]()
Otherwise smbstatus reports the wrong time for tree connects.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Christian Ambach <ambi at samba.org>
Autobuild-User(master): Christian Ambach <ambi at samba.org>
Autobuild-Date(master): Mon Nov 5 20:43:23 CET 2012 on sn-devel-104
commit 157de6c9878e804b963df3c7c834aa38d1fa7ac3
Author: Christian Ambach <ambi at samba.org>
Date: Fri Nov 2 08:42:28 2012 +0100
s3:utils fix a whitespace error
commit c2ca9e02106108c024b0daf27325e8eba35437f2
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 2 12:52:51 2012 +0100
s3:vfs_default: optimize vfswrap_asys_finished() and read as much as we can
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Mon Nov 5 19:01:13 CET 2012 on sn-devel-104
commit 719595b6f7f8745f2608dddb2b86476b9cc2f598
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 2 13:56:53 2012 +0100
lib/tsocket: optimize syscalls in tstream_readv_pdu_send()
Once we've got the first part of a pdu we try to optimize
readv calls for the rest of the pdu.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit e42889f83f261e2ac34014649476fae638a6e1f2
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 2 13:45:49 2012 +0100
lib/tsocket: disable the syscall optimization for recvfrom/readv by default
We only do the optimization on recvfrom/readv if the caller asked for it.
This is needed because in most cases we preferr to flush send
buffers before receiving incoming requests.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit 71e1c080cbd033b3118952c2da05186252fc411a
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Nov 5 09:46:49 2012 +1100
libads: Always free the talloc_stackframe() on error path
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon Nov 5 03:33:32 CET 2012 on sn-devel-104
commit c452efe977753a44807dd12a1b2ff8ce1387bfa6
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Nov 3 09:57:40 2012 +1100
selftest: Add skip for DIR1 test which loops on 64 bit ext4
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon Nov 5 00:34:56 CET 2012 on sn-devel-104
commit 1f55865f2830d0fa36a3f4eeb846f66940b133cd
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon Nov 5 01:09:28 2012 +1100
s4-dns: Fix format string vulnerability in an error message (bug #9354)
Also, fixes few comments.
Thanks to Bruno Rohée <bruno at rohee.org> for reporting and patch fix.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-By: Kai Blin <kai at samba.org>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Sun Nov 4 16:58:13 CET 2012 on sn-devel-104
commit 60cf4cb5a630506747431ecbf00d890509baf2f3
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Nov 1 09:51:28 2012 +1100
vfs_acl_common: In add_directory_inheritable_components allocate on psd as parent
When we add a new DACL to the security descriptor, we need to use the
SD as the memory context, so we can talloc_move() it as a tree to a
new parent.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Nov 2 22:16:14 CET 2012 on sn-devel-104
commit 92e17d5fd0f075a71d1c8f579c11b4ce9bbf6fa6
Author: Karolin Seeger <kseeger at samba.org>
Date: Fri Nov 2 10:41:01 2012 +0100
smb2_server: Fix typo in comment.
Karolin
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Fri Nov 2 15:40:22 CET 2012 on sn-devel-104
commit d551b4ab4bb06dac7d90389febbc21c2afae8bca
Author: Björn Baumbach <bb at sernet.de>
Date: Tue Oct 30 16:04:10 2012 +0100
build(waf): Fail "configure --with-cluster-support" if ctdb support is not available.
Currently, configure only warns if cluster support is not found.
Signed-off-by: Björn Baumbach <bb at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 5f1b5404b8e642dd18b55e37793068216f668242
Author: Björn Baumbach <bb at sernet.de>
Date: Tue Oct 30 16:45:30 2012 +0100
s3-torture:test_ctdbconn: fix the build against older ctdb versions
by checking if we have the ctdb_protocol.h and including ctdb_private.h otherwise.
Signed-off-by: Björn Baumbach <bb at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 541bde605e8a1158411436c4f7fdc314dfdbff23
Author: Björn Baumbach <bb at sernet.de>
Date: Wed Oct 17 16:54:33 2012 +0200
s3:ctdb library: fix the build against older ctdb versions
by checking if we have the ctdb_protocol.h and including ctdb_private.h otherwise.
Signed-off-by: Björn Baumbach <bb at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
commit bf269d6b5a6783e2479ac455b8e085a5d8ad9e9e
Author: Björn Baumbach <bb at sernet.de>
Date: Tue Oct 30 13:59:41 2012 +0100
build(waf): check if we have ctdb_protocol.h in the cluster checks
Signed-off-by: Björn Baumbach <bb at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
commit d113d8aea5411e5e0701891f44b95d6d916b1271
Author: Björn Baumbach <bb at sernet.de>
Date: Tue Oct 30 13:26:24 2012 +0100
build(autoconf): check if we have ctdb_protocol.h in the cluster checks
Signed-off-by: Björn Baumbach <bb at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e5cce4f47274a02b752e47e3d1f23d3f64f72123
Author: Björn Baumbach <bb at sernet.de>
Date: Tue Oct 30 13:40:48 2012 +0100
build(autoconf): fix check for ctdb_private.h
Signed-off-by: Björn Baumbach <bb at sernet.de>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 872f499c55ac13befb357d3e8eca0f526ea14978
Author: Michael Adam <obnox at samba.org>
Date: Tue Oct 30 14:43:42 2012 +0100
build(waf): fix the cluster(ctdb) build without system talloc installed
This is analogous to the earlier patch for tdb.
It temporarily adds the talloc include path to the
includes search list for the ctdb-header configure checks.
Signed-off-by: Michael Adam <obnox at samba.org>
Tested-by: Björn Baumbach <bb at sernet.de>
commit f8e71d4b602e5e1cca9f8701df93328718d8a6eb
Author: Michael Adam <obnox at samba.org>
Date: Tue Oct 30 14:41:04 2012 +0100
build(waf): fix a tab indentation to spaces
Signed-off-by: Michael Adam <obnox at samba.org>
commit 3ecbe8c83a003825fc58f6dcb9e02a35aad2d86e
Author: Björn Baumbach <bb at sernet.de>
Date: Fri Nov 2 10:25:27 2012 +0100
docs-xml: fix use of <smbconfoption> tag (fix bug #9345)
Signed-off-by: Björn Baumbach <bb at sernet.de>
Reviewed-by: Karolin Seeger <ks at samba.org>
Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
Autobuild-Date(master): Fri Nov 2 12:37:42 CET 2012 on sn-devel-104
commit 73fa347507e6b551205725abd276b03b7e1f934c
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 1 17:55:59 2012 +0100
s3:smbd:smb2: fix a comment typo in the crediting code.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Fri Nov 2 10:09:36 CET 2012 on sn-devel-104
commit 2a3eb641fe34fb95bf713f0e7184581847af1357
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Oct 22 14:35:41 2012 +0200
s3:winbindd: use PROTOCOL_LATEST instead of PROTOCOL_SMB2_02 (bug #9175)
We should use the latest supported dialect.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewd-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Thu Nov 1 18:11:27 CET 2012 on sn-devel-104
commit 45105afffc5678082b23165ff74610d67e57a82a
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Oct 22 14:31:20 2012 +0200
s3:winbindd: disconnection after getting NETWORK_SESSION_EXPIRED (bug #9175)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit c5cd22b5bbce724dcd68fe94320382b3f772cabf
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Oct 22 14:18:20 2012 +0200
libcli/smb: add smbXcli_session_set_disconnect_expired() (bug #9175)
This should be a short term hack until the upper layers have implemented
re-authentication.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 24f3f87706329e6e280dc6be6d025e997d46c910
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Oct 22 13:47:48 2012 +0200
lib/krb5_wrap: request enc_types in the correct order (bug #9272)
aes256-cts-hmac-sha1-96 and aes128-cts-hmac-sha1-96
should have a higher priority than arcfour-hmac-md5,
otherwise the KDC still gives us arcfour-hmac-md5 session keys.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f853c1792967332c4aff52c0fb35f653f614f86d
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 1 14:41:56 2012 +0100
s3:winbindd:cache: fix offline logons with cached credentials (bug #9321)
The removal of consumption of the time field from the centry
as "removal of unused variable" in 21528da9cd12a4f5c3792a482a5d18fe946a6f7a
had the side effect of changing the offset for reading the following
nt password hash, so the read password hash was wrong.
This patch re-installs the consumption of the time,
thereby fixing the bug without changing the disk format of the cache.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 75c51d6561f6f39dd02fd942709039b871957f44
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Nov 1 11:26:16 2012 +1100
s3-param: Move the options needed for running smbd in the AD DC to loadparm
This avoids the whole fileserver.conf thing, and simply handles everything in C.
The main challenge is that if s3fs is enabled in a member server
configuration (unlikely) then these options will not be set, and it
overrides any other attempt to set these as globals. (The previous
approach essentially just changed defaults, because the include =
of smb.conf was after the values were set in fileserver.conf).
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Thu Nov 1 11:47:22 CET 2012 on sn-devel-104
commit fc5caffbc139d63cab1ec105884863f73772586f
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Nov 1 11:24:00 2012 +1100
file_server: put set create mask and directory mask in fileserver.conf
This allows any ACL to be set from the client, without restriction
from the Samba side.
Based on advise from Jermey at https://lists.samba.org/archive/samba-technical/2012-October/088414.html
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit dd60dcf343bfb8286951d3109055693634574d8b
Author: Andrew Tridgell <tridge at samba.org>
Date: Thu Nov 1 14:11:02 2012 +1100
test-chgdcpass: test the ldap case for server password change
use samba-tool drs options which does both RPC and LDAP connections
Pair-Programmed-With: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Tridgell <tridge at samba.org>
Autobuild-Date(master): Thu Nov 1 07:21:17 CET 2012 on sn-devel-104
commit 0e6c5c036f8faddcc6ca65c26453ffaf248ed2b5
Author: Andrew Tridgell <tridge at samba.org>
Date: Thu Nov 1 14:10:14 2012 +1100
s4-ldapclient: cope with logon failure retry in LDAP
similar to what was done for rpc and cifs, we now retry once on logon
failure for ldap, allowing for a new ticket to be fetched when a
server password changes while we have a valid ticket for the old
password
Pair-Programmed-With: Andrew Bartlett <abartlet at samba.org>
commit b0cc0d5698d34aa7956b22faa8b79bd9b338286d
Author: Andrew Tridgell <tridge at samba.org>
Date: Thu Nov 1 13:42:52 2012 +1100
s4-librpc: set error code to LOGON_FAILURE on RPC fault with access denied
this allows the client code to trigger a retry with a new password
callback for NTLM connections
Pair-Programmed-With: Andrew Bartlett <abartlet at samba.org>
commit 538dd046f1efefbeb8660ef1ff5afd594a003341
Author: Andrew Tridgell <tridge at samba.org>
Date: Thu Nov 1 13:31:47 2012 +1100
samba-tool: "drs options" does not need a samdb connection
this gives us a handy pure RPC client test for use in blackbox testing
Pair-Programmed-With: Andrew Bartlett <abartlet at samba.org>
commit 5d6ae3498ad77ccdb7a8b3a316d7aa86c2f0c56a
Author: Andrew Tridgell <tridge at samba.org>
Date: Thu Nov 1 13:30:47 2012 +1100
s4-librpc: try a 2nd logon for more error cases
not all servers give LOGON_FAILURE on authentication failures, so we
need to do the retry with a new ticket on a wider range of error types
Pair-Programmed-With: Andrew Bartlett <abartlet at samba.org>
commit 30ffdda45bd3ae602b453c9c1bbdb77ea3de8a8d
Author: Andrew Tridgell <tridge at samba.org>
Date: Wed Oct 31 16:06:03 2012 +1100
ldb: fixed callers for ldb_pack_data() and ldb_unpack_data()
with ltdb_pack_data() and ltdb_unpack_data() now moved into common, we
need to increase the minor version and fixup callers of the API
Note that this relies on struct ldb_val being the same shape as
TDB_DATA, in much the same way as we rely on ldb_val and DATA_BLOB
being the same shape.
Pair-Programmed-With: Andrew Bartlett <abartlet at samba.org>
commit fc47b0d03c577730ce0ef9e09092f80c0712d5d0
Author: Andrew Tridgell <tridge at samba.org>
Date: Wed Oct 31 15:39:09 2012 +1100
ldb: move ldb_pack.c into common
this code should not be tied to the ldb_tdb backend, both because it
could be used for any record oriented backend, and because it should
be exposed for use by diagnosis/repair tools such as the recently
added ldbdump tool
Pair-Programmed-With: Andrew Bartlett <abartlet at samba.org>
commit e48099516e4975cb69c7e2850d3b13b25bab7c44
Author: Andrew Tridgell <tridge at samba.org>
Date: Wed Oct 31 18:45:25 2012 +1100
test_chgdpass: use drs bind to test password change on RPC
Pair-Programmed-With: Andrew Bartlett <abartlet at samba.org>
commit ed2e69fe91fee642392803a17d42d64adc36e41d
Author: Andrew Tridgell <tridge at samba.org>
Date: Wed Oct 31 18:44:23 2012 +1100
s4-librpc: use cli_credentials_failed_kerberos_login to cope with stale tickets
This allows our RPC client code to cope with a kerberos server
changing password while we have a valid service ticket
Pair-Programmed-With: Andrew Bartlett <abartlet at samba.org>
commit fce66b22ea312abb252fb9dc748b3adc6fbab49f
Author: Andrew Tridgell <tridge at samba.org>
Date: Wed Oct 31 18:00:43 2012 +1100
test_chgdpass: added test for kerberos retry
this tests that we correctly retry with a new ccache entry when a
server changes its password while we have a valid ticket
Pair-Programmed-With: Andrew Bartlett <abartlet at samba.org>
commit d4ea637eb869e0c3540140b7ae04c2b483f7693c
Author: Andrew Tridgell <tridge at samba.org>
Date: Wed Oct 31 17:59:54 2012 +1100
libcli: use cli_credentials_failed_kerberos_login() to cope with server changes
if a server changes while we have a valid ticket we want to retry
after removing the ccache entry.
Pair-Programmed-With: Andrew Bartlett <abartlet at samba.org>
commit 994696c5c4638b0665021eac1c55b4c6ea9fd55f
Author: Andrew Tridgell <tridge at samba.org>
Date: Wed Oct 31 17:58:20 2012 +1100
auth: added cli_credentials_failed_kerberos_login()
this is used to support retrying kerberos connections after removing a
ccache entry, to cope with a server being re-built while our client
still has a valid service ticket
Pair-Programmed-With: Andrew Bartlett <abartlet at samba.org>
commit ffb608b54d452e2c96222840f1bd48759f32d0b5
Author: Björn Jacke <bj at sernet.de>
Date: Wed Oct 31 15:31:08 2012 +0100
util: remove accidently committed hunk
Autobuild-User(master): Björn Jacke <bj at sernet.de>
Autobuild-Date(master): Wed Oct 31 19:25:30 CET 2012 on sn-devel-104
commit 59e9661de2dd19808295002f1329b27d5dca09e6
Author: Jeremy Allison <jra at samba.org>
Date: Mon Oct 29 14:49:36 2012 -0700
Add regression test for bug #9329 - Directory listing with SeBackup can crash smbd.
Ensure we exercise the SeBackup code path on directory listings.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Wed Oct 31 03:21:38 CET 2012 on sn-devel-104
commit a71ad96bd046f1199e67b4fe8fc7783cbd8dd771
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Oct 30 15:41:27 2012 +1100
ldb: Add ldbdump, based on tdbdump
This uses a tdb_traverse or (more usefully) the tdb_rescue API, like tdbdump.
The difference here is that it uses ldb helper functions to further
eliminate faulty records, which avoids creating duplicates in the output.
(The duplicates come from parts of records that are left in blank space
in the db, which tdb_rescue finds, but which are not actually a full
record).
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue Oct 30 23:56:11 CET 2012 on sn-devel-104
commit 4b2f3c6dec997b0dd4bcafeae662a71ebd34e12b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Oct 30 10:22:28 2012 +1100
ldb: Remove no-longer-existing ltdb_unpack_data_free from ldb_tdb.h
commit cc6d0decc7980028293168aee267e7610752fc80
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Oct 30 10:21:42 2012 +1100
ldb: Change ltdb_unpack_data to take an ldb_context
It always de-references the module to find the ldb anyway.
Andrew Bartlett
commit 42c379f0dfdeb36598bb2636aa2b6e3ca4410930
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Oct 29 15:36:36 2012 +1100
samba-tool: Add samba-tool processes subcommand
This will allow administrators to inspect the process list in a
similar way to what running on a platform with setproctitle might
permit.
--pid= returns the registered server names for a PID (eg kdc, cldap_server)
--name= returns the pids registered with a particular name.
Andrew Bartlett
commit a732f2a621665923322422c5a3d788c9d1aa8df9
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Oct 29 15:34:41 2012 +1100
pymessaging: Add irpc_servers_byname() and irpc_all_servers()
This will allow python scripts to inspect the process list.
Andrew Bartlett
commit 76b7348299870279acec5b7c9f02f4e4b2461703
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Oct 29 15:33:59 2012 +1100
pymessaging: Use the server_id IDL structure rather than a tuple
This will make it easier to pass this structure in and out. The tuple is still
accepted as input.
Andrew Bartlett
commit 3b4ef03097293f758d8f11cbe434063ed1dc6b91
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Oct 29 15:32:21 2012 +1100
imessaging: Add irpc_all_servers() to list all available servers
This is implemented with a tdb_traverse_read(), and will allow a tool
to disover the name and server_id of all Samba processes, as each
process registers itself to recieve messages.
Andrew Bartlett
commit 39e58d6845ee4dab0e9ae1537fccaed837ead728
Author: Andreas Schneider <asn at samba.org>
Date: Mon Oct 29 21:12:14 2012 +0100
s3fs-utils: Free the popt context in smbcacls and smbquotas.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Oct 30 20:22:46 CET 2012 on sn-devel-104
commit aca807c94cdb44cc846562400495ee3a7114f8e0
Author: Andreas Schneider <asn at samba.org>
Date: Mon Oct 29 21:12:13 2012 +0100
s3fs-net: Use talloc for memory allocation.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed by: Jeremy Allison <jra at samba.org>
commit a88e3be794a7458ad644e5b73435971533aa7dbe
Author: Christian Ambach <ambi at samba.org>
Date: Tue Oct 30 15:39:02 2012 +0100
s3:docs document shadow:snapdirseverywhere option of vfs_shadow_copy2
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Tue Oct 30 18:32:57 CET 2012 on sn-devel-104
commit d8fc4cd25e40164e23c0375b073cb42723892146
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Oct 30 11:08:19 2012 +0100
s3:smb2_read: fix SMBD_SMB2_NUM_IOV_PER_REQ check for sendfile() support (bug #9341)
Reported-by: Sebastien LAVEZE <sebastien.laveze at mindspeed.com>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Tested-by: Sebastien LAVEZE <sebastien.laveze at mindspeed.com>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Oct 30 16:49:26 CET 2012 on sn-devel-104
commit e6643fbf48afccd0acedb65fbe24d3ce84d44c40
Author: Björn Jacke <bj at sernet.de>
Date: Tue Oct 30 13:00:58 2012 +0100
wafbuild: use -Wstack-protector if available
Autobuild-User(master): Björn Jacke <bj at sernet.de>
Autobuild-Date(master): Tue Oct 30 15:04:30 CET 2012 on sn-devel-104
commit 9a03cc93f45a6908c73afe2d059a4ebf5534fdb7
Author: Björn Jacke <bj at sernet.de>
Date: Tue Oct 30 12:19:24 2012 +0100
wafbuild: use WERROR_FLAGS in wscript_configure_system_mitkrb5
commit fdead585dc11101761ac975935134c6a84ea3b4f
Author: Björn Jacke <bj at sernet.de>
Date: Tue Oct 30 12:07:26 2012 +0100
ccan/wafbuild: use WERROR_CFLAGS instead of -Werror
commit 7fcb2532b99ddf65d78dd02ea06ce8a1a6229949
Author: Björn Jacke <bj at sernet.de>
Date: Tue Oct 30 11:48:25 2012 +0100
wafbuild: reorder the Werror checks so that the ambigous w2 option is being checked last
commit 51692042d9f898c5e8f1cbc78031e37d23ec032a
Author: Björn Jacke <bj at sernet.de>
Date: Tue Oct 30 11:37:34 2012 +0100
wafbuild: merge the missing IBM compiler Werror flag "-qhalt=w" to waf
commit 0342ca40629d5a57db02c7f840809dfa0bde6780
Author: Björn Jacke <bj at sernet.de>
Date: Tue Oct 30 11:32:52 2012 +0100
wfabuild: fix the -errwarn compile flag test
as in the autoconf build this must be "-errwarn=%all"
commit a3a1cd4797c99cb5fd0234c2dfe40e5dcafb05f8
Author: Andreas Schneider <asn at cryptomilk.org>
Date: Fri Oct 26 12:46:21 2012 +0200
packaging: Add NetworkManager dispatcher script for winbind.
Signed-off-by: Andreas Schneider <asn at cryptomilk.org>
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Tue Oct 30 13:17:02 CET 2012 on sn-devel-104
commit 4dfded000c8d8d62b1160fdf41357ccd8a77254b
Author: Volker Lendecke <vl at samba.org>
Date: Mon Oct 29 16:41:15 2012 +0100
s3: Use file_id_string in file_id_string_tos
Reviewed by Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Oct 30 00:05:34 CET 2012 on sn-devel-104
commit e44b231f5823bd7a08a65391094db1b7b1eb94e8
Author: Volker Lendecke <vl at samba.org>
Date: Mon Oct 29 16:35:49 2012 +0100
s3: Fix some nonempty line endings
Reviewed by Jeremy Allison <jra at samba.org>
commit 88332dfd9f636196e594173b62d05b0607e3c05b
Author: Michael Adam <obnox at samba.org>
Date: Mon Oct 29 15:16:04 2012 +0100
lib/param: fix line length of DEBUG statments touched in previous commit in set_variable()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Ira Cooper <ira at samba.org>
Autobuild-User(master): Ira Cooper <ira at samba.org>
Autobuild-Date(master): Mon Oct 29 21:55:35 CET 2012 on sn-devel-104
commit b59fed0d5d7dceff3e5ab47a6f219849a24cff1b
Author: Michael Adam <obnox at samba.org>
Date: Mon Oct 29 14:52:50 2012 +0100
lib/param: fix function name (set_variable) in debug statements
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Ira Cooper <ira at samba.org>
commit d084f5e6a66accf223efb4f9a6fa4b2d0ca63ed6
Author: Michael Adam <obnox at samba.org>
Date: Mon Oct 29 13:44:54 2012 +0100
lib/param: fix function name (lpcfg_file_list_changed) in a debug message
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Ira Cooper <ira at samba.org>
commit 382849ad9951072ba56a8809c3e272565221c329
Author: Michael Adam <obnox at samba.org>
Date: Tue Oct 23 17:18:47 2012 +0200
s3:smbd:durable: remove a TODO comment about write time updates
This has been done.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Mon Oct 29 20:12:18 CET 2012 on sn-devel-104
commit 669a9236c37e66be08efbc5c51367113ffaf3b36
Author: Andreas Schneider <asn at samba.org>
Date: Tue Oct 23 17:12:59 2012 +0200
BUG 9326: Fix net ads join message for the dns domain.
We don't get a realm back from the server which is useable as a realm on
Unix. On Unix they are case sensitive and on Windows they aren't. This
confuses uses and if we write realm they try to use it as it came back
in lowercase.
Signed-off-by: Andreas Schneider <asn at samba.org>
Signed-off-by: Günther Deschner <gd at samba.org>
Autobuild-User(master): Günther Deschner <gd at samba.org>
Autobuild-Date(master): Mon Oct 29 18:26:19 CET 2012 on sn-devel-104
commit 3a4b755ce5b4be1981d12d5b6f3eb563ef079707
Author: Jeremy Allison <jra at samba.org>
Date: Thu Oct 25 17:07:29 2012 -0700
Fix bug #9329 - Directory listing with SeBackup can crash smbd.
When we do a become_root()/unbecome_root() pair to temporarily
raise privilege, this NULLs out the NT token. If we're within
a become_root()/unbecome_root() pair then return the previous
token on the stack as our NT token. This is what we should be
using to check against NT ACLs in the file server. This copes
with security context changing when removing a file on close
under the context of another user (when 2 users have a file
open, one sets delete on close and then the other user has
to actually do the delete).
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Mon Oct 29 16:26:20 CET 2012 on sn-devel-104
commit 334044f6fa11b5a9ac66afdc95add5e1522e6baa
Author: Andreas Schneider <asn at samba.org>
Date: Wed Oct 17 18:25:41 2012 +0200
packaging: Move smbprint to a comman location.
This also removes all the duplicate smbprint scripts.
This fixes bug #9301.
Signed-off-by: Andreas Schneider <asn at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Mon Oct 29 14:08:37 CET 2012 on sn-devel-104
commit aa411045a5ee52d440ccb259a37c6c7489099884
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Oct 28 19:57:58 2012 +1100
pidl: Remove depends_on=PIDL_MISC as it sets -I/ into CFLAGS
This in turn causes an include of <net/if.h> to hang on some systems, as
/net/ means to run the automounter!
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon Oct 29 01:23:39 CET 2012 on sn-devel-104
commit 06eee7f50b7022451dd9bac39b46e33cd434a186
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Oct 28 19:38:10 2012 +1100
build: Remove support for IDL-generated files in git tree
This was added in a9ea3d6fa510286b83c4bda42c9a857da3625451 but is no
longer required, as we do not store IDL-generated files in GIT.
Andrew Bartlett
commit 2756c3ce5c7d5d066dc76592dd1078a8594b983b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Oct 27 19:15:58 2012 +1100
lib/replace: Return size of xattr if size argument is 0
This makes rep_{f,}getxattr a more complete replacement for the linux function.
Andrew Bartlett
commit a7b8d0260a55959c72614251db880fed04a48316
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Sat Oct 27 05:31:06 2012 -0800
source3.selftest: Move last variables to selftesthelpers.
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Sat Oct 27 19:08:42 CEST 2012 on sn-devel-104
commit 66980989e5b28490cd7b04b576cf39d26f183b90
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Sat Oct 27 05:23:57 2012 -0800
source3.selftest: Move more variables to be in common.
commit 13269923585888912e2433c15c0ca010a9897595
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 26 17:31:40 2012 -0800
selftesthelpers: Fix detection of tap2subunit.
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Sat Oct 27 16:57:49 CEST 2012 on sn-devel-104
commit 8d397b69bb29b7a464b610bc46cedd6be01b2455
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 26 15:58:06 2012 -0800
TestCaseInTempDir: Use addCleanup rather than tearDown.
commit 67dd28f3605db4cbdc5feacc1121ec3d7dd075a6
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 26 15:53:57 2012 -0800
selftest: Add --random-order option.
commit 1190f385f72f68f22277c8b380f2d4c461c413a4
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 26 14:40:09 2012 -0800
source4.selftest.tests: Add FIXME about database verification.
commit 05dc5a39a6ad4b1ffafc904faea3e8e40f6f5cde
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 26 14:14:42 2012 -0800
selftesthelpers: Simplify detection of tap2subunit.
commit fd607e0a9eefb79130941e244435980afbbb4bf7
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 26 14:06:47 2012 -0800
source3.selftests.tests: Use common plansmbtorture4testsuite() function.
commit efb27e29dadf58d2dec651ca3a0c108b4cf515ae
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 26 14:00:07 2012 -0800
source3.selftest.tests: Add suffix for smbclient3/ntlm_auth3.
commit a841f0fced7abfb0f6d98390c07becdf49a91af5
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 26 13:56:30 2012 -0800
source3.selftest.tests: Remove tabs.
commit ea5e2b56c14072eeaa785d05f1da4d439667e8b6
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 26 13:52:55 2012 -0800
source4.selftest.tests: Add suffix for smbclient4/nmblookup4.
commit 58345820c078f79fe7f67b8e6f947691f7237641
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 26 13:51:54 2012 -0800
selftesthelpers: Add function for printing smbtorture4 version.
commit 8237e2727da0d04b82cb3cf644dd337a4c77fe34
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 26 13:38:32 2012 -0800
selftest: Move determining of smbtorture4 options to selftesthelpers.
commit fcb7926ce544a8d4b0e5aa6577fe21712b38bb53
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 26 13:12:54 2012 -0800
selftest/selftesthelpers: Share environment handling for extra smbtorture options.
commit 6bcb25673bdc249f5a49ded912d90bc84b13809d
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 26 13:09:45 2012 -0800
selftest/selftesthelpers.py: Share configuration variable, strip whitespace.
commit 4c4d3c86f0430d38f78d16dcb5d365b577ef4227
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 26 13:03:32 2012 -0800
selftesthelpers: Share code for listing smbtorture4 tests.
commit 868c8c058306b66fb3baa4a36bfe91d6461805d5
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 26 11:51:19 2012 -0800
source4.selftest.tests: Rename plansmbtorturesuite() to plansmbtorture4suite().
commit 55507d0612ecf2db34867eb6065fc5038ea81aa0
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 26 11:50:41 2012 -0800
source4.selftest.tests: Consistent naming of smbtorture binary.
commit 2b4672f2d30c01a4767acf660ddb061676c59908
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Oct 27 08:11:14 2012 +0200
libcli/smb: fix unitialized padding in smb2_create_blob_push_one() (bug #9209)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Sat Oct 27 10:05:22 CEST 2012 on sn-devel-104
commit 3180a1082a79698a69f6721282cb8c45900f884c
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Oct 27 10:59:43 2012 +1100
sefltest: use TestCaseInTempDir and setUp/tearDown for posixacl.py temp file
This manages the temp file more reliably, and reduces the repeated
code in each test case.
Pair-Programmed-With: Jelmer Vernooij <jelmer at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sat Oct 27 04:37:58 CEST 2012 on sn-devel-104
commit 7e90a064437790789726d701ada5de9503816281
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Oct 27 09:20:52 2012 +1100
provision: Fix comments in checksysvolacl
commit ec0f51b200d6e5b99bbd872e169621c17f33524c
Author: David Disseldorp <ddiss at suse.de>
Date: Wed Nov 2 18:39:03 2011 +0100
pam_winbind: fix segfault in pam_sm_authenticate()
Ensure the potentially null winbind context is not dereferenced on
cleanup.
https://bugzilla.samba.org/show_bug.cgi?id=8564
Signed-off-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Fri Oct 26 22:40:57 CEST 2012 on sn-devel-104
commit 281c62b33001571a4d926b30035e65d93d649660
Author: Andreas Schneider <asn at samba.org>
Date: Fri Oct 26 18:07:59 2012 +0200
ntlm_auth: Increase debug level if we use config domain name.
If an application like evolution-ews is using ntlm_auth it will alwys
get this message cause the is no winbind running and it is not needed.
Reviewed-by: Simo Sorce <idra at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Fri Oct 26 20:13:45 CEST 2012 on sn-devel-104
commit cb50e85a5a054eeb59bf4c27c886679285732548
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Oct 26 14:23:39 2012 +1100
vfstest: set umask(0) in vfstest
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Fri Oct 26 10:07:03 CEST 2012 on sn-devel-104
commit e146fe5ef96c1522175a8e81db15d1e8879e5652
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Oct 26 14:22:07 2012 +1100
pysmbd: Set umask to 0 during smbd operations
commit 728e56b4636b668aaac60ec557d6fe16b530a6f9
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Oct 26 10:07:02 2012 +1100
pysmbd: Remember to close files after setting the NT ACL
commit e107c6ace73ac40894fdd66860cfeae9115d5cd9
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Oct 26 17:25:53 2012 +1100
pysmbd: Add hook for unlink() so python scripts can remove xattr.tdb entries
If we do not provide a way to remove files from xattr.tdb, we can re-use the inode.
Andrew Bartlett
commit 52ace6767fddb389e3393c4b19685e59782c6a90
Author: Michael Adam <obnox at samba.org>
Date: Tue Oct 23 13:00:02 2012 +0200
s3:smbd:durable: factor stat checks out into vfs_default_durable_reconnect_check_stat()
This makes vfs_default_durable_reconnect() simpler to read
and it reduces code duplication in the failure case handling.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Oct 25 23:03:13 CEST 2012 on sn-devel-104
commit a2d53262e835b0c74282d389b1dd6dad2395f0f1
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 24 18:24:12 2012 +1100
python-ntacls: Cope with ACL revision 4
This is the new revision with the hash of the posix or system ACL.
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu Oct 25 15:04:39 CEST 2012 on sn-devel-104
commit f8e6bb46c005e82d5a8646e691de9282828005cc
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 24 18:23:04 2012 +1100
dbwrap: use talloc_stackframe() in db_tdb_log_key()
We can not be sure that there is already a talloc_stackframe() in place
so we must create one.
Andrew Bartlett
commit 1008f6fbf49d5b797c7d968ea7ffdcb29d623644
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Oct 25 20:18:28 2012 +1100
selftest: Always unlink the tempf in posixacl test
commit 117d5f4c372c02d69106df45e12ac69d1c047f50
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Oct 25 20:17:55 2012 +1100
selftest: Cover the important non-Samba invalidation of the NT ACL
This covers the case where we have a valid hash of the posix ACL (or the NT ACL from the
POSIX ACL) and we notice it no longer matches.
Andrew Bartlett
commit 53244c915113cef87692756e9ad545ff75074df0
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Oct 25 19:58:15 2012 +1100
selftest: Cover one more NT ACL invalidation case and improve comments
This tries to show the difference between the cases where we trap
the POSIX ACL change and where we actually detect an OS-level change.
Andrew Bartlett
commit e9b6b23fbdafff700ceb788dbff2ba69584ff833
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Oct 25 16:27:19 2012 +1100
selftest: Add many more tests for our posix ACL handling
This tests the mapping of posix ACLs to NT ACLs, the invalidation of
NT ACLs stored as an xattr and ensures this security-critical code
continues to work in the long term.
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu Oct 25 10:05:16 CEST 2012 on sn-devel-104
commit 3cdd888093e57a8cfc29d82ea47c8887a50e73a4
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Oct 25 16:25:22 2012 +1100
pysmbd: Fix pysmbd octal mode handling
It is clearly too long since Computer Science 101... ;-)
Andrew Bartlett
commit 9dbb64563c35003311d3f3d47e6c4ef0f546ffab
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 24 16:41:52 2012 +1100
dsdb-cracknames: Return DRSUAPI_DS_NAME_STATUS_NO_MAPPING when there is no SID
If there is no SID for an object being mapped, then there is no NT4 name.
We need to return DRSUAPI_DS_NAME_STATUS_NO_MAPPING rather than
error out with anything other than WERR_OK as the return value.
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu Oct 25 04:43:25 CEST 2012 on sn-devel-104
commit a9a38415e52e3f341da4dd3bf1be6c56bd8ad6ef
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Oct 23 15:00:27 2012 +0200
s4:dns_server: fix formatting difference compared to v4-0-test
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Wed Oct 24 10:12:51 CEST 2012 on sn-devel-104
commit 8697acd4b08354fb4185b05da07f4399bda917bc
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 24 11:56:02 2012 +1100
dsdb-cracknames: Always use talloc_zero()
Otherwise, we will return un-initialised values to the caller, which will
attempt to push them onto the wire.
Found by Greg Dickie <greg at justaguy.ca>.
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Wed Oct 24 05:12:04 CEST 2012 on sn-devel-104
commit d5d0a454cef8c732235b554df89761d4dcd854ba
Author: Michael Adam <obnox at samba.org>
Date: Tue Oct 23 15:53:17 2012 +0200
build(waf): Fix the --with-cluster build
The problem with the cluster/ctdb configure checks in Samba
currently is, that the headers need to include <tdb.h>.
If there are no system tdb headers, configure fails to find
tdb headers at this stage. Since the include is only required
for some defines (TDB_DATA), the workaround is to temporarily
add the included tdb copy's include path to the include search
path in the configure test. The ctdb we run against will most
likely have been compiled against a different version of TDB
anyways...
To properly fix this, we might need to change ctdb to rely
on an external tdb library. Or to incorporate ctdb into samba
as a component that uses the same shipped tdb version.
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Volker Lendecke <vl at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Oct 23 18:29:26 CEST 2012 on sn-devel-104
commit d2aa785290a283e06624f22a381a7ea02baae5ad
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Oct 2 12:20:26 2012 +0200
lib/tsocket: fix loop in tdgram_bsd_recvfrom() (bug #9184)
If the socket is not readable yet, we need to retry
if tsocket_bsd_pending() returns 0.
See also
https://lists.samba.org/archive/samba-technical/2012-October/087164.html
metze
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue Oct 23 14:44:21 CEST 2012 on sn-devel-104
commit 7138b2138ba1f67386c6aa1e1c5ef49fde07cc41
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Oct 23 17:53:58 2012 +1100
build: Add #define FREEBSD on FreeBSD
This makes waf match autoconf
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue Oct 23 11:11:44 CEST 2012 on sn-devel-104
commit 6d73fd07f94ae23f3eacaab3b220ffca201b1300
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Oct 23 17:31:03 2012 +1100
lib/replace: Fix configure on FreeBSD: define_ret is not correct here
define_ret is for when the output of the compiled and run program
should be put into the configure define. This is not the case
here.
Andrew Bartlett
commit 80f42df4ec9194ff00aeeb3c2cf6acfa1f2ab5c3
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Oct 23 17:14:55 2012 +1100
lib/replace: Fix detection of prctl
commit debb2b2b9e9a495b0f9f31753ac5e75e4b2d5364
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Oct 23 17:14:43 2012 +1100
lib/replace: Fix detection of rpcsrv/yp_prot.h on FreeBSD
commit 60a06ff09cb62d4102a89194ce8fef5c4c5a2f16
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Oct 23 16:13:28 2012 +1100
vfs: Fix compilation of ACL support on solaris
commit bd099c49f816f8f7faad7da34370bcec2d59a0aa
Author: Andreas Schneider <asn at samba.org>
Date: Wed Oct 17 18:17:27 2012 +0200
waf: Create a libnss_wins.so symlink.
The last 3 patches fixe bug #9299 - nsswitch modules under Linux need a symbolic
to their so version library.
https://bugzilla.samba.org/show_bug.cgi?id=9299
Reviewed-by: David Disseldorp <ddiss at samba.org>
Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
Autobuild-Date(master): Mon Oct 22 10:48:16 CEST 2012 on sn-devel-104
commit 1f017efeedffed84b872bd17ebefee7dfff0d11a
Author: Andreas Schneider <asn at samba.org>
Date: Wed Oct 17 18:16:15 2012 +0200
waf: Create a libnss_winbind.so symlink.
This fixes bug #9299.
commit 8490c1a503cba909b429cc3cb9c972d51dfa5ea8
Author: Andreas Schneider <asn at samba.org>
Date: Wed Oct 17 18:03:55 2012 +0200
wafsamba: If we define a realname and a soname create a symlink.
This is needed that libnss_winbind.so.2 and libnss_wins.so.2 will get a
corresponding symlinks.
commit 13bbd3b3b12bcc6e0a2e62c344908ca621774f34
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Sep 27 15:19:03 2012 -0700
pyglue: Make all_interfaces argumen to interface_ips() optional.
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Sun Oct 21 21:26:01 CEST 2012 on sn-devel-104
commit f67c0a28cfe3f3fc6ef2888c833e57c3d2138348
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Sep 27 15:13:37 2012 -0700
pyglue: Mention parameters in interface_ips() docstring.
commit d18591c97e1856bb48fd6d288db59065530f3a9b
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Oct 20 11:08:19 2012 +0200
s3:rpc_server: avoid a level 0 DEBUG if tstream_npa_connect_recv fails (bug #9309)
metze
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Sat Oct 20 12:56:23 CEST 2012 on sn-devel-104
commit 3da5d964b9821a589be39ad076ed56000952382b
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 19 21:48:20 2012 +0200
s3: Fix some blank line endings
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Sat Oct 20 09:06:12 CEST 2012 on sn-devel-104
commit 75724d9eb14cd288297f3f5228fb3d10a11861dc
Author: Volker Lendecke <vl at samba.org>
Date: Sat Oct 20 07:20:39 2012 +0200
s3: Use talloc_stackframe in token_contains_name_in_list
commit 96356219d662614cbc926d6c2dc4345f0ac432ce
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 19 18:10:22 2012 +0200
s3: Remove a call to procid_self()
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Fri Oct 19 23:15:04 CEST 2012 on sn-devel-104
commit d2069eb677e7def93cf228cc7719da02c33ba57d
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 19 18:09:21 2012 +0200
s3: Add "msg_ctx" param to winbindd_register_handlers()
commit cf1d69ae0bb4ca6182cfa838fafe429f127e1980
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 19 18:06:46 2012 +0200
s3: Make winbindd_register_handlers static
commit 422ff2523d56982480877d51dec4bbd1327b7241
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 19 17:46:14 2012 +0200
s3: Fix a typo
commit 9a2db48e7ebe808019d1bd2bfc2bd3c77204d4b2
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 19 07:15:31 2012 +0200
s3: Remove some calls to procid_self
The goal is to have procid_self handling completely in the messaging_context.
Signed-off-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Fri Oct 19 20:39:56 CEST 2012 on sn-devel-104
commit 7d05ff77264cf48d1ee82ca19c8c7e6951e64cf5
Author: Michael Adam <obnox at samba.org>
Date: Fri Oct 19 16:00:05 2012 +0200
s3:smbd:durable: store stat info for disconnected durables and check at reconnect.
At durable reconnect, we check the stat info stored in the cookie against the
current stat data from the file we just opened. If any detail differs, we deny
the durable reconnect, because in that case it is very likely that someone
opened the file while the handle was disconnected, which has to be interpreted
as an oplock break.
Pair-programmed-with: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Fri Oct 19 18:56:19 CEST 2012 on sn-devel-104
commit a6726f9023c899415441a619473ea9a7819d7c36
Author: Michael Adam <obnox at samba.org>
Date: Fri Oct 19 15:57:24 2012 +0200
s3:open_files.idl: add stat-info to vfs_default_durable_cookie.
Pair-programmed-with: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit 660e90d39174fbfea0e93f40adfe03fefb86916f
Author: Michael Adam <obnox at samba.org>
Date: Fri Oct 19 15:53:50 2012 +0200
s3:smbd/durable: remove an extra blank line from vfs_default_durable_reconnect()
Pair-programmed-with: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit 24d225f44ee4958ed5e2bd934125a9b0c4fc3323
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Oct 19 11:12:05 2012 +0200
s3:smbd/durable: add write_time specific stuff to vfs_default_durable_cookie
metze
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Fri Oct 19 17:12:29 CEST 2012 on sn-devel-104
commit 506249b86382331c39676b8632ad33b535f9fb03
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Oct 19 11:12:05 2012 +0200
s3:open_files.idl: add write_time specific stuff to vfs_default_durable_cookie
metze
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 137376391d5642c0a18ff70a5184dac4b402fa42
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Oct 19 10:58:47 2012 +0200
s3:smbd/durable: update the low level write_time before disconnecting the file.
If we close the low level FD, we should better update the write_time
if needed.
It's not unlikely that the client doesn't reclaim the durable handle,
in that case we may not close the after the durable timeout.
In such a case we should make sure that we at least update the write time
on disconnect, this makes sure backup applications notice that
the file was changed.
metze
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 9e7bce53707732700928eaf2bb53a5f1cc5d7784
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Oct 19 10:54:27 2012 +0200
s3:smbd/durable: trigger pending write_time updates before disconnecting the file
We need to call the pending write time update handler immediately.
Which means we don't wait exactly 2 seconds before updating the write time
after the first write.
metze
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 81d0b8aebf8e7dee73907fabf408f0b2c3145207
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Oct 18 15:35:39 2012 +0200
docs-xml:smbd.8: document new smbXsrv_*_global.tdb files
metze
Signed-off-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Fri Oct 19 14:00:39 CEST 2012 on sn-devel-104
commit a144911958d7bcd291a8f42a40832ffc0187279a
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Oct 5 19:05:32 2012 +0200
s3:lib: remove unused connections_fetch_entry*() and connections_init()
metze
Signed-off-by: Michael Adam <obnox at samba.org>
commit d4f369c470ec1c8c7986a73e4ee6e18a97edd834
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Oct 5 19:13:39 2012 +0200
s3:smbd: remove unused claim_connection/yield_connection
metze
Signed-off-by: Michael Adam <obnox at samba.org>
commit 3eff70087005ffdee2ca579e65846ba1c33ec17f
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Oct 5 19:11:31 2012 +0200
s3:smbd: don't call claim/yield_connection() in make_connection_snum/close_cnum()
This was used to maintain the connections.tdb database which is being removed.
We use info from the smbXsrv_tcon instead.
Signed-off-by: Michael Adam <obnox at samba.org>
commit 0ccbf89bda71cdbe8d216bab0aa6aacd98cf95df
Author: Gregor Beck <gbeck at sernet.de>
Date: Mon Sep 3 11:13:16 2012 +0200
s3:lib/conn_tdb: implement connections_forall_read() based on smbXsrv_*_global_traverse()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit f76436c6ea7867fb60d6ac6b65cffc502a018467
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Oct 18 13:40:08 2012 +0200
s3:smbd: fill tcon->global->session_global_id
metze
Signed-off-by: Michael Adam <obnox at samba.org>
commit 7be7ec803f88de68ef9a5e2b14994a13589ff441
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Oct 18 13:38:34 2012 +0200
s3:smbXsrv.idl: add session_global_id to smbXsrv_tcon_global
This is required for some debugging tools like smbstatus.
metze
Signed-off-by: Michael Adam <obnox at samba.org>
commit b74ed25a9999c0029ddf2771f729c497c20b9c30
Author: Gregor Beck <gbeck at sernet.de>
Date: Mon Aug 27 15:21:42 2012 +0200
s3:lib: remove function connections_forall()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit 3b61c605d6815a8033d70f367a69e876f63bc5de
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Oct 18 10:13:59 2012 +0200
doc-xml: remove "net connections" documentation
metze
Signed-off-by: Michael Adam <obnox at samba.org>
commit 4a7a8ecb0b69b3b79823aab7504e75451d20e5a0
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Oct 5 19:20:45 2012 +0200
s3:utils/net: remove unused "net connections"
The connections.tdb will go away.
metze
Signed-off-by: Michael Adam <obnox at samba.org>
commit 5a4ffb20ffe387fa5bb373778ba84d24a7e5b74f
Author: Gregor Beck <gbeck at sernet.de>
Date: Thu Aug 23 14:02:22 2012 +0200
s3:net_serverid: remove connections_forall from "net serverid wipedbs"
This tdb will go away.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit ac5c8909a94228cec47067188036f1c2a42378aa
Author: Gregor Beck <gbeck at sernet.de>
Date: Thu Aug 23 10:36:59 2012 +0200
s3:lib: remove unused sessionid_*() functions
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit 2f2cb2f6894c94f375310661e7c40c167a784eda
Author: Gregor Beck <gbeck at sernet.de>
Date: Thu Aug 23 14:02:22 2012 +0200
s3:net_serverid: remove sessionid_traverse from "net serverid wipedbs"
This tdb will go away.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit dbff58228e5d05d9799322973aee950951d23fb8
Author: Gregor Beck <gbeck at sernet.de>
Date: Thu Aug 23 16:15:25 2012 +0200
s3:smbd: don't use (fill) sessionid.tdb in session_claim/yield any more.
We use data from new smbXsrv_session instead.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit f2714318ae7358abd328e264dc80821c2749bcc6
Author: Gregor Beck <gbeck at sernet.de>
Date: Thu Aug 23 10:36:59 2012 +0200
s3:lib: implement sessionid_traverse_read with smb2srv_session_traverse_read
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit d9ea786c86d6bc42df60881ff703213ef3bd9319
Author: Gregor Beck <gbeck at sernet.de>
Date: Tue Aug 28 15:53:28 2012 +0200
s3:smbd/connection: use smbXsrv_tcon_traverse to count connections
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit f588704640868a003d901b57045511623e6a1f69
Author: Gregor Beck <gbeck at sernet.de>
Date: Tue Aug 28 14:29:51 2012 +0200
s3:smbd:setup_new_vc_session: traverse sessions instead of connections to shutdown other smbds
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit bcfa721a36269d4390ae5ce747cfd3dff6a255ac
Author: Gregor Beck <gbeck at sernet.de>
Date: Fri Sep 7 15:18:39 2012 +0200
s3:build: move sessionid_tdb.o and conn_tdb.o to SMBD_OBJ_BASE
and use SMBD_OBJ_BASE for a couple of targets where sessionid_tdb and conn_tdb
were used.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit 89cc865cabdf7f7fd7c26d3da784c1d7f9e1d6b0
Author: Gregor Beck <gbeck at sernet.de>
Date: Tue Aug 28 15:35:58 2012 +0200
s3:smbXsrv_tcon: add smbXsrv_tcon_global_traverse()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit c3a658f59578899215920a42f5cb568f9368ce13
Author: Gregor Beck <gbeck at sernet.de>
Date: Wed Aug 22 14:28:31 2012 +0200
s3:smbXsrv_session: add smbXsrv_session_global_traverse()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit b288ddd5c0ee7524e30a4fce3ec4f03c19a1764a
Author: Gregor Beck <gbeck at sernet.de>
Date: Thu Aug 23 15:21:06 2012 +0200
s3:smbd: use session_global_id as session number for pam and utmp
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit 92d53dd7dc8ca71ae28d2a8762524396cd3c6f58
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Oct 8 11:15:50 2012 +0200
s3:configure: check that struct utmp.ut_line is large enough for our use case
We use "smb/%u" with a 32-bit number, "smb/4294967295\0" requires
15 chars (including the '\0').
metze
Signed-off-by: Michael Adam <obnox at samba.org>
commit e24b1041b1f6e5b1c5a258a2cbe058f134a45ed9
Author: Gregor Beck <gbeck at sernet.de>
Date: Mon Aug 27 11:03:25 2012 +0200
s3:smbd: initialize session->global before calling session_claim
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit 02b9b79447be46835adf963cca14c618d0c435e6
Author: Gregor Beck <gbeck at sernet.de>
Date: Mon Aug 27 09:21:58 2012 +0200
s3:smbd: remove smbd_server_connection argument from session_claim()
retrieve the server connection from the smbXsrv_session argument instead.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit 4878769f8e6763fbb8347f2ea674c7a861d95564
Author: Gregor Beck <gbeck at sernet.de>
Date: Thu Aug 23 14:47:33 2012 +0200
s3:smbd: pass smbXsrv_session instead of user_struct to session_claim() and session_yield()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit 77f99ece482a11aad50219e64d231b27dbbccbba
Author: Gregor Beck <gbeck at sernet.de>
Date: Mon Aug 27 15:18:07 2012 +0200
s3:net_status_shares: use connections_forall_read for a read only traversal
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit 77906e7cdf4c40ab860af8bb42e2c5f3b5501e7d
Author: Gregor Beck <gbeck at sernet.de>
Date: Mon Aug 27 15:12:36 2012 +0200
s3:count_current_connections: do not clear orphaned entries from connections.tdb
This removes one of the last callers of connetions_forall.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit b237bbc0d1afdfea3b6b6335854f92d6fe80a151
Author: Gregor Beck <gbeck at sernet.de>
Date: Tue Aug 28 09:31:59 2012 +0200
s3:smbcontrol: don't do stack_trace by connection but by server_id.
Inparticular use serverid_traverse_read instead of connections_foralli
to enumerate processes.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit d5c273919d129f884d5fb13e06ad73e01c7176e1
Author: Gregor Beck <gbeck at sernet.de>
Date: Mon Aug 27 15:07:08 2012 +0200
s3:lib: remove unused function connections_traverse()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit 611e30ea233f0e5dab1439e930ea8544b85ca3b2
Author: Gregor Beck <gbeck at sernet.de>
Date: Mon Aug 27 14:46:22 2012 +0200
s3:rpc_server/srvsvc: remove function net_enum_pipes()
The relevant records are not written to connections.tdb since commit
a781b78417b6d7b875230dd2edcb932445aa4197
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit c9a2111b0025156ba70c6eb9fa857e5d639f62b7
Author: Gregor Beck <gbeck at sernet.de>
Date: Mon Sep 3 13:55:50 2012 +0200
s3:auth: use const in smb_pam_xxx_session()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit 7aa0d7c55f9cbb3ed96beaf7c4891cadc9bc00ae
Author: Michael Adam <obnox at samba.org>
Date: Thu Oct 18 16:14:19 2012 +0200
s3:auth: remove duplicate propotypes for smb_pam_claim_session and smb_pam_close_session
Signed-off-by: Michael Adam <obnox at samba.org>
commit 9b2a3ebf5cfb4613b117ebb83abe92b93e759381
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Oct 9 09:38:36 2012 +0200
s3:smbd/utmp: remove ip address from utmp record
1. This was broken since Samba 3.2. when ipv6 support was
added, it only worked for ipv6 addresses.
2. userspace tools only display the hostname field.
3. This is not really portable
metze
Signed-off-by: Michael Adam <obnox at samba.org>
commit 42b0398bdeae8fd7e8ae92ab3a464c3eba9fb0da
Author: Michael Adam <obnox at samba.org>
Date: Thu Oct 18 16:06:42 2012 +0200
s3:smbd: remove duplicate prototypes for sys_utmp_claim() an sys_utmp_yield()
Signed-off-by: Michael Adam <obnox at samba.org>
commit 8a1c7a0a660d78786adac483ecafa157c3a3dc2e
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Oct 9 08:35:04 2012 -0400
s3:smbd: add exit_server to the smbd_shim hooks
This is in preparation of moving sessionid_tdb and conn_tdb
to smbd exclusively.
metze
Signed-off-by: Michael Adam <obnox at samba.org>
commit 8eab264470ee7adea1e448fc29bc8111902a83b0
Author: Michael Adam <obnox at samba.org>
Date: Thu Oct 18 15:59:55 2012 +0200
s3:smbd: move initialization of the smbd_shim from smbd_init_globals() to main()
This is in preparation of adding server exit hooks to the shim.
Signed-off-by: Michael Adam <obnox at samba.org>
commit 781db9d1e564797546009aa5a49378b6e70502d7
Author: Michael Adam <obnox at samba.org>
Date: Thu Oct 18 15:58:01 2012 +0200
s3: fix comment header description for smbd_shim
This was copy'n'pasted from "RPC pipe client"...
Signed-off-by: Michael Adam <obnox at samba.org>
commit 980191d189ee1f5a25e74a6bdf141d4c7e4455d5
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Oct 17 14:59:30 2012 +0200
s3:smbd: update sconn->remote_hostname after the netbios session request
Also update the info in the new smbXsrv structure.
This way we can log the remote name in status outputs.
metze
Signed-off-by: Michael Adam <obnox at samba.org>
commit 1de9e714756b65b1e15fae044bde065bb2572b16
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Oct 8 11:18:03 2012 +0200
buildtools/wafsamba: only display 'ok' if the result is True
Otherwise we print the raw value.
metze
Signed-off-by: Michael Adam <obnox at samba.org>
commit e3a48bb5f65bf9f5b77df010dcb75fcc9721cf3b
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 19 09:53:02 2012 +0200
samba-tool user test: Fix expected output.
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Fri Oct 19 11:37:44 CEST 2012 on sn-devel-104
commit 364ed82d22bbcd69ae237098ba8d6946969bd390
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 19 09:21:01 2012 +0200
samba.tests.docs: Ignore removed parameters.
commit 4b4e8e21235615af94788fa0ebfa0b0bc09f14fd
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 19 09:20:44 2012 +0200
smb.conf(5): Mark four removed parameters as such.
commit ed37b8ad14d496114654017d394fa18d63456aee
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 19 09:16:55 2012 +0200
samba.tests.docs: Assume docs are generated by waf.
commit cfa72bcc5e93a840fc07f5d419216443ef8f7599
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Sep 28 21:40:32 2012 -0700
samba.tests.docs: Write error output from xsltproc to standard out.
commit 8412b57f5ce40901a0a4e2e66c5f9bcbdcb4b46e
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Sep 28 09:52:41 2012 -0700
samba.tests.docs: Skip tests if xsltproc is not present.
commit 2a31f0b50976dc5b6770639b60184a8ef9158b8b
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 13:20:42 2012 -0700
smb.conf(5): Consistent spelling of parameter names.
This includes spacing and casing.
commit 32fad2b910a9e4f9b753b43cb818c72829236a88
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 13:09:01 2012 -0700
samba.tests.docs: Support spaces before synonyms.
commit be4dea45daca51a817a7c383a4092bf69650c6cd
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 12:40:00 2012 -0700
samba.tests.docs: Support synonyms.
commit d0e644e0c83636b4e4c6b52ce0f861ffe38cedeb
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 18:41:19 2012 +0200
samba.tests.docs: Distinguish between unknown and undocumened parameters.
commit d2f8fe855d0705faf216714cf147038563c0ba7e
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 02:57:16 2012 +0200
tests: Convert find_missing_doc into a unit test.
commit 47902702b3e6390de05f8fca2bc457936af9f5c1
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 19 08:33:31 2012 +0200
smb.conf(5): Fix mixing of tabs and spaces.
commit aad30c062fd176fa15994a44a0178d51764cdbf7
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Sep 28 21:25:50 2012 -0700
smb.conf(5): Add basic documentation for 'nsupdate command'.
commit 0cea6daffe42f5b9b6ee61eb430da3f86bea31df
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Sep 28 13:05:07 2012 -0700
smb.conf(5): Add basic documentation for 'afs token lifetime'.
commit 695df863eddd6ee323229fe29a4a40712f3553b4
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Sep 28 13:01:39 2012 -0700
smb.conf(5): Add 'ldap password sync' as synonym for 'ldap passwd sync'.
commit 6c160e3892eea219c50bbb2d1113460817bfad08
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Sep 28 11:20:09 2012 -0700
smb.conf(5): Add 'socket address' as alias for 'nbt client socket address'.
commit 03b48e2bdbea30afad9b414fbab5dae67e57b5cf
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Sep 28 11:13:13 2012 -0700
smb.conf(5): Add basic documentation for 'tls dh params file'.
commit 946a873e470ed4309bf56dae574b8f48a4dc629f
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Sep 28 11:08:49 2012 -0700
smb.conf(5): Add basic documentation for 'tls enabled'.
commit 2e4f054e16aa9f67ec6bfb8ec7af6ebbba26db1d
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Sep 28 11:05:47 2012 -0700
smb.conf(5): Add basic documentation for 'tls crlfile'.
commit 008dfb9a2167603c65fb4db56c8bd62cdd2447d0
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Sep 28 11:00:09 2012 -0700
smb.conf(5): Add basic documentation for 'tls certfile'.
commit 0f5e45b84c9b54909294fc0ea48f7b6fb3ca2878
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Sep 28 10:58:45 2012 -0700
smb.conf(5): Add basic documentation for 'tls keyfile'.
commit 4e1a06dc238c31a3b2343fcf4983c78fdc52f758
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Sep 28 10:56:44 2012 -0700
smb.conf(5): Add basic documentation for 'tls cafile'.
commit e27e8f4f88dac6c938272ced6ca4b0fd3b20f8e0
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Sep 28 10:52:13 2012 -0700
smb.conf(5): Add basic documentation for 'log nt token command'.
commit 7341dcac105baad0d06d112578fa3f12826bd4ef
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Sep 28 10:42:55 2012 -0700
smb.conf(5): Add basic documentation for 'ntp signd socket directory'.
commit 6f36bde82f4a6329b97b400564e69928dffa0173
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Sep 28 10:37:23 2012 -0700
smb.conf(5): Add basic documentation for 'spn update command'.
commit 68fdcaa6b7f69c622df958413ee3809e56861c04
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Sep 28 10:35:06 2012 -0700
smb.conf(5): Add basic documentation for 'allow dns updates'.
commit b0b0266aa70721ebfea8dbc2602e81984a3b6023
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Sep 28 10:31:08 2012 -0700
smb.conf(5): Add basic documentation for 'rndc command'.
commit 4ccea7f86796070ae6dbf404aa93ad4e5a7ae66e
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Sep 28 10:16:08 2012 -0700
smb.conf(5): Add basic documentation for 'dns update command'.
commit 3cc61af7ff3b90026fdc6fc84ad905041154bfaf
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Sep 28 10:09:41 2012 -0700
smb.conf(5): Add basic documentation for 'server services'.
commit a63d6a909406c2d0e04f6142f9614c3543ae2d1b
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Sep 28 10:03:46 2012 -0700
smb.conf(5): Add basic documentation for 'samba kcc command'.
commit d09f15163843c5a027476e9087ae96700f6de003
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Sep 27 18:44:43 2012 -0700
samba-tool user: Fix typos, improve messages.
commit e7c8fcaea5b06897603abb6f4f38ce39b400c9a7
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Sep 27 17:57:54 2012 -0700
smb.conf(5): Add basic documentation 'winbind sealed pipes'.
commit e9d91cd4a133d7acb377341282230f99f5e10a12
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Sep 27 13:38:31 2012 -0700
smb.conf(5): Add basic documentation for 'dns forwarder'.
commit 394258ad4c3413388e800800b2b1b941de037fa3
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Sep 27 13:28:23 2012 -0700
smb.conf(5): Add basic documentation for 'ntvfs handler'.
commit c6ba8575ea7fe8b0fdc49d4f823ca441ae99070a
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Sep 27 12:30:07 2012 -0700
smb.conf(5): Add : to idmap config description to mark it as parametric.
commit 3cea6257a9e4a3e1dc46e6c555d57992a73d6e6c
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Sep 27 12:28:16 2012 -0700
smb.conf(5): Add basic documentation for 'winbindd privileged socket directory'.
commit d0b38752471dd870ad640fd39076bc51f84c57d1
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Sep 27 12:24:15 2012 -0700
smb.conf(5): Add basic documentation for 'winbindd socket directory'.
commit dfe75c2f3591652a370a36f73f70e8055bda9d11
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 16:02:40 2012 -0700
smb.conf(5): Extend 'server min protocol' description.
commit bea7a251781c65a87af6c6e1568cb71a5aef3f7f
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Oct 18 19:58:04 2012 +1100
build: Assert that auth_domain, auth_builtin, auth_sam, auth_winbind are builtin
These modules are used by default and for various reasons cannot be compiled into a .so
The code setting up these lists is generic, so it is easier to just assert early,
for this non-default configuration.
Andrew Bartlett
Signed-off-by: Andreas Schneider <asn at samba.org>
Address bug #9295 - Can't find guest.so module if auth_builtin is built as
module.
Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
Autobuild-Date(master): Thu Oct 18 13:14:38 CEST 2012 on sn-devel-104
commit 7786919428527f8e3b75806f5058ddd2a6ad4fab
Author: Andreas Schneider <asn at samba.org>
Date: Wed Oct 17 16:30:57 2012 +0200
BUG #9295: Build standard auth modules as internal modules.
Signed-off-by: Andreas Schneider <asn at samba.org>
commit 64886e312fe76145c2c4bc900b794274594368aa
Author: Alexander Wuerstlein <arw at arw.name>
Date: Sun Sep 30 04:32:01 2012 +0200
Warn when setting UID/GID without idmap_ldb:use rfc2307 = Yes
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu Oct 18 09:51:35 CEST 2012 on sn-devel-104
commit 071047e8953f36a4c71c30d9540323578a4204f2
Author: Alexander Wuerstlein <arw at arw.name>
Date: Sun Sep 30 04:32:00 2012 +0200
Tests for 'samba-tool user create' with RFC2307 attributes
Check if attributes are correctly set and read from SamDB
Test automatic creation of attributes from getpwent (NSS)
Check if overriding NSS attributes works
getpwent will be skipped if the current UID of the user running the
tests has no passwd entry (getpwuid(geteuid())).
If a user with the name of the current UID already exists in the
directory, the getpwent test will fail. If that should happen, the
test would need to be updated to use a nonexistent UID that is
visible to the Python 'pwd' module.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
commit bfdaaf2327441c0cf909a70f9b3ca781caadbddc
Author: Alexander Wuerstlein <arw at arw.name>
Date: Sun Sep 30 04:31:59 2012 +0200
Set RFC2307 attributes in samba-tool create
Optionally set RFC2307 (NIS Schema) attributes in samba-tool create.
Mainly needed for UID mapping to be usable.
Not all attributes are set-able, only harmless and non-overlapping
ones (uid, uidNumber, gidNumber, loginShell, gecos). Description and
homeDirectory should already be set, userPassword seems problematic.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
commit 9eb022c8c65663425e60a10a12c2ec52c3017a59
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Oct 16 13:08:22 2012 +1100
provision: No longer use the wheel group in new AD Domains
The issue here is that if we set S-1-5-32-544 (administrators) to a
GID only, then users cannot force a mandetory profile to be owned by
administrators (which is a requirement).
There is no particularly useful reason for us to enforce this matching
a system group.
Andrew Bartlett
commit b557f34c80c9326d9aa887366501366bf3956ce1
Author: Michael Adam <obnox at samba.org>
Date: Wed Sep 26 09:08:17 2012 +0200
s3:smbd: fix brace placements in validate_my_share_entries() for readability
according to coding guidelines
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Oct 17 14:37:58 CEST 2012 on sn-devel-104
commit 678cc4403f78d36f277940add7b7b4294e13100e
Author: Michael Adam <obnox at samba.org>
Date: Thu Oct 11 07:41:19 2012 +0200
s3:smbd: also log the "offline" flag when debugging the dos-mode
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Jeremy Allison <jra at samba.org>
commit d09ac9636af6a31098156ca65ab62e11ce3a5d15
Author: Ricky Nance <ricky.nance at weaubleau.k12.mo.us>
Date: Tue Oct 16 00:52:51 2012 -0500
Removed phpldapadmin inclusion for Samba 4.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Wed Oct 17 12:55:44 CEST 2012 on sn-devel-104
commit 83d34bb2bbcbc0ebbcb81825590363e996979e08
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Oct 16 15:08:30 2012 +1100
dns_server: Try and use the dns-SERVER account if we were configured with it
commit 029654897d721308c9ee782aee420abddce7edee
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Sun Oct 14 16:05:58 2012 +1030
ccan: check for all the used config.h defines
In particular, not checking for byteswap.h meant we defined duplicates:
https://bugzilla.samba.org/show_bug.cgi?id=9286
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Autobuild-User(master): Rusty Russell <rusty at rustcorp.com.au>
Autobuild-Date(master): Wed Oct 17 01:55:14 CEST 2012 on sn-devel-104
commit 05a59748910cc11d43bffbfc4d00fdf3701e2ca1
Author: Kai Blin <kai at samba.org>
Date: Sat Oct 13 02:09:57 2012 +0200
libcli/dns: Time out requests after a while
Time out UDP requests after DNS_REQUEST_TIMEOUT seconds. Currently set
to 2 seconds.
This should fix bug #8878.
Signed-off-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Oct 16 12:58:32 CEST 2012 on sn-devel-104
commit 1861213d147e0d96fd637813c5badb4908ec14d1
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Oct 16 08:34:35 2012 +0200
selftest/knownfail: add samba3.rpc.lsa.privileges.lsa.Privileges
This failed more than 20 times in the last few weeks, e.g.
https://git.samba.org/autobuild.flakey/2012-10-16-0629/samba3.stdout
https://git.samba.org/autobuild.flakey/2012-10-16-0829/samba3.stdout
[530/717 in 14m32s] samba3.rpc.lsa.privileges(s3dc)
Using seed 1350368974
Testing OpenPolicy
Testing OpenPolicy2
Testing CreateAccount
Testing Delete
Testing DeleteObject
Testing EnumAccounts
Testing LookupSids
Testing LookupNames with 7 names
LookupName of sharesec_user was unmapped
LookupName of Everyone failed to return a result
UNEXPECTED(failure): samba3.rpc.lsa.privileges.lsa.Privileges(s3dc)
REASON: _StringException: _StringException: ../source4/torture/rpc/lsa.c:319: r.out.result was STATUS_SOME_UNMAPPED, expected NT_STATUS_OK: LookupNames failed
FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)
metze
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Oct 16 10:43:02 CEST 2012 on sn-devel-104
commit 266b4c596346095f71a651e0a0231256c7409b0f
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Oct 16 08:30:17 2012 +0200
Revert "provision: Always create DNS user."
This reverts commit c2d14747d608d406de6410556807d467cd0b85ef.
samba_upgradedns handles creates/removed the dns acount.
See
https://lists.samba.org/archive/samba-technical/2012-October/thread.html#87578
metze
commit 2c3a8081ea2fd7eaa2d7bacffc35e05555a58c54
Author: Matthieu Patou <mat at matws.net>
Date: Sat Oct 13 01:36:06 2012 -0700
s4-dns: Fix the comments about ignoring zones in internal server
Acked-By: Kai Blin <kai at samba.org>
Autobuild-User(master): Kai Blin <kai at samba.org>
Autobuild-Date(master): Sat Oct 13 12:37:53 CEST 2012 on sn-devel-104
commit bddd1182ea44875f28e12cf15fd07a86f43d8716
Author: Christian Ambach <ambi at samba.org>
Date: Thu Sep 27 22:09:23 2012 -0700
s3:smb2_getinfo ensure proper error for not yet present quota support
non-existing quota support needs to be signaled by NT_STATUS_NOT_SUPPORTED,
not NT_STATUS_INVALID_PARAMETER
Autobuild-User(master): Christian Ambach <ambi at samba.org>
Autobuild-Date(master): Fri Oct 12 13:37:37 CEST 2012 on sn-devel-104
commit 6d1be1caf925f80badabcbca3a2676398647f4a3
Author: Christian Ambach <ambi at samba.org>
Date: Fri Oct 12 11:47:04 2012 +0200
s3:vfs_gpfs re-indent run-away lines
some lines added by the acl_blob additions were longer than 80 chars
commit fa728d1c0b6583c7d11b5540a8d13942a14701f4
Author: Christian Ambach <ambi at samba.org>
Date: Fri Oct 12 11:45:59 2012 +0200
s3:vfs_gpfs fix the build
make it compile again after the recent (untested) additions of the acl_blob functions
commit e4946cf10cdc112aaa61291442ce29690fe1c105
Author: Christian Ambach <ambi at samba.org>
Date: Fri Oct 12 10:32:20 2012 +0200
s3:vfs_gpfs remove a trailing space
commit 12ae1812d0f123b6b988f597efaabf610f352d30
Author: Christian Ambach <ambi at samba.org>
Date: Fri Oct 12 10:31:10 2012 +0200
s3:vfs_gpfs skip local flock when gpfs sharemodes are disabled
no sense in calling local flock when clustered sharemodes should be disabled
commit ff82afb1f8ad3cf950277487aff05d442d03c969
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 5 11:51:37 2012 +0200
selftest: Move more tests to common list script.
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Fri Oct 12 02:06:42 CEST 2012 on sn-devel-104
commit 21b58b5eacb67b4dee6e7efe90bd529bbfd6ef77
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Oct 11 17:23:13 2012 +0200
samba.join: Fix multiple spaces.
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Thu Oct 11 20:30:43 CEST 2012 on sn-devel-104
commit 1aa291c331c29c2f5ee4572b660c4c2061755856
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 5 11:46:25 2012 +0200
selftest: Move some tests to common test script.
commit 1080b6c2caf1191fd896f3caf38e576a00b01982
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Fri Oct 5 11:39:34 2012 +0200
selftests.tests: Remove reference to Samba 4.
commit 2adf27a99b999a4fd0329d9fa398a9208b60e367
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Oct 11 17:11:44 2012 +0200
samba.provision.sambadns: Use == to compare strings, not 'is'.
commit cabd2b2e960a7d6346b621a4cf37429c944a7720
Author: Andreas Schneider <asn at samba.org>
Date: Thu Oct 11 14:46:56 2012 +0200
s3fs-printing: Simplify the comment and location handling.
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Thu Oct 11 18:49:15 CEST 2012 on sn-devel-104
commit 49959cffc5717764cc4a5a654eab63bfe5f21603
Author: Andreas Schneider <asn at samba.org>
Date: Wed Oct 10 11:30:15 2012 +0200
packaging: Add support for reloading systemd services.
commit c2d14747d608d406de6410556807d467cd0b85ef
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Oct 11 14:45:10 2012 +0200
provision: Always create DNS user.
The DNS user is currently only used by the bind9 plugin. This makes it
easier to later on switch between the builtin DNS server and bind
backend.
In addition, ideally the internal DNS server would use that (separate)
user too.
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Thu Oct 11 17:05:40 CEST 2012 on sn-devel-104
commit 276460cf8afb4894fe1e980c7a75e866c14ba144
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Oct 11 14:39:50 2012 +0200
wafsamba: Ignore some more symbols when checking for dupes.
commit 1ec5486338772cecf953e150ebb717a8845c98d4
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Oct 11 22:29:43 2012 +1100
smbd: Always free the talloc_stackframe() before leaving smbd_do_query_security_desc
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu Oct 11 15:20:54 CEST 2012 on sn-devel-104
commit a11595bd2e6895f734e621c69c1ad0ee3e1a685a
Author: Karolin Seeger <kseeger at samba.org>
Date: Wed Oct 10 10:43:02 2012 +0200
docs: Add very basic samba manpage.
Please feel free to extend.
Karolin
Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
Autobuild-Date(master): Thu Oct 11 11:40:37 CEST 2012 on sn-devel-104
commit 957f9fa3ff2ba838bb1669c371da0f70ddeb2360
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Oct 11 15:08:25 2012 +1100
rpc_server:srvsvc Remove psd variable that was no longer set by SMB_VFS_FGET_NT_ACL
This fixes up an error introduced by c8ade07760ae0ccfdf2d875c9f3027926e62321b.
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu Oct 11 07:53:36 CEST 2012 on sn-devel-104
commit 0f435a7adceb6bb7e2cc57eda3bf5a4a615d6a79
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 21:20:24 2012 +1100
build: Remove --disable-shared
This does not work, and has no known use cases. Remove it so we do
not waste time trying to support it.
This also removes it for ldb/tdb/ntdb/talloc, but as these are first
shared libraries, and then tools on top of those, rpath or (for
emergency tools) --nonshared-binary= seems more appropriate.
Andrew Bartlett
commit 1722074a9b4b7370ae50ba7a0b787c5f325f592b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Oct 11 14:49:13 2012 +1100
vfs: Remove irixacl module (all the fucntions in it are unimplemented)
commit a0588fdea82ab1b5d4dbd8bf75b01b82c0879d21
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Oct 11 14:42:39 2012 +1100
vfs: Fix alternative posix and no-op sys acl implementations to take a mem_ctx
These were missed with the initial conversion to use a talloc context.
Andrew Bartlett
commit 547a260a2865d547a4ffc756b21fa648349654fd
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Oct 11 10:47:17 2012 +1100
vfs: Improve formatting of vfs_fake_acls
This avoids this bad style being copied into new modules.
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu Oct 11 05:10:16 CEST 2012 on sn-devel-104
commit d07d888ce1394c51019804d5717e02d088a715f8
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Oct 11 10:46:37 2012 +1100
vfs: Improve formatting of vfs_default
This avoids this bad style being copied into new modules.
Andrew Bartlett
commit a581b3d48edb1b3f8205e5b1dd2935e265aaba42
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Oct 11 07:53:29 2012 +1100
examples: Re-indent and reformat skel VFS modules
This avoids some of the poor style here from propogating to new VFS modules.
Andrew Bartlett
commit 38416ccac3970b2bf63fe218ef85d535d848302c
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 17:00:42 2012 +1100
vfs: Use a blocking function in vfs_zfsacl for system ACL blobs
This is so we do not query some other module for the ACL blob, as zfs
ACLs are not posix ACLs. We may add a linearisation later.
Andrew Bartlett
commit bac3ed2696e621ee18f4332e5404bbf2af0c7ccb
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 16:59:53 2012 +1100
vfs: Use posix_sys_acl_blob_get_file in vfs_tru64acl for posix ACLs
commit 998bdd516adf5edb5c5884f92f04dc690aa1ce27
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 16:59:43 2012 +1100
vfs: Use posix_sys_acl_blob_get_file in vfs_solarisacl for posix ACLs
commit 010e589c29335fc48446051347d6af5f787981a4
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 16:59:35 2012 +1100
vfs: Use posix_sys_acl_blob_get_file in vfs_posixacl for posix ACLs
commit 598b565c632aae8792dc2917eda2e2b7365d4cec
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 16:59:25 2012 +1100
vfs: Use posix_sys_acl_blob_get_file in vfs_irix for posix ACLs
commit 4eb0e406f15c5fcf3b73361978edcac0a8db5b58
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 16:59:18 2012 +1100
vfs: Use posix_sys_acl_blob_get_file in vfs_hpux for posix ACLs
commit abee79f99db802adc8e13a2baedf7817bf937786
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 16:58:59 2012 +1100
vfs: Use posix_sys_acl_blob_get_file in vfs_gpfs for posix ACLs
commit 5dddd9429e9b08b3d88ed6ba8fc86ec837ef23d8
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 16:53:43 2012 +1100
vfs: Use posix_sys_acl_blob_get_file in vfs_fake_acls for posix ACLs
commit 76b38f75e98ed68de9e649c2a0ef3b4b317292ae
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 16:53:22 2012 +1100
vfs: Use posix_sys_acl_blob_get_file in vfs_default for posix ACLs
commit 274ace37fd413240bac3d5f45fa9a481aba0bfb1
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 16:52:17 2012 +1100
vfs: Use posix_sys_acl_blob_get_file in vfs_aixacl2 for posix ACLs
commit 79edc54a94b9a42df86130174faf010010a05f82
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 16:52:02 2012 +1100
vfs: Use posix_sys_acl_blob_get_file in vfs_aixacl
commit c960a49f428d8e5030bd61c42095786406184b99
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 16:45:44 2012 +1100
vfs: Use a blocking function in vfs_afsacl for system ACL blobs
This is important, as we need to avoid asking any lower module for a
possible libear ACL blob. We may implement a linearisation in the
future.
Andrew Bartlett
commit ddcaac99f0262909be57eceac4535bd3684096b3
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 16:49:59 2012 +1100
vfs: Implement a sys_acl_blob_get_{fd,file} for POSIX ACL backends
This simply linearlises the SMB_ACL_T (default and access acl for
directories) and the file owner, group and mode into a blob.
It will be useful for an improved vfs_acl_common.c that uses this sets
that, rather than the hash of the NT ACL, in the xattr
This will in turn insulate the stored hash from changes in the ACL
mapping.
Andrew Bartlett
commit 1f36ec129300e4f69efe26d4950fe3a7cfbfb233
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 16:44:41 2012 +1100
vfs: Remove type parameter from sys_acl_blob_get_{fd,file}
This interface actually needs to match the get_nt_acl interface in
that the system ACL implmenetation may not be posix ACLs, and the blob
is not meant to be enforced to be of a particular system ACL
structure.
Andrew Bartlett
commit c8ade07760ae0ccfdf2d875c9f3027926e62321b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 11:50:27 2012 +1100
smbd: Add mem_ctx to {f,}get_nt_acl VFS call
This makes it clear which context the returned SD is allocated on, as
a number of callers do not want it on talloc_tos().
As the ACL transformation allocates and then no longer needs a great
deal of memory, a talloc_stackframe() call is used to contain the
memory that is not returned further up the stack.
Andrew Bartlett
commit 9158974540d0e311021f04789ed75ebda466c5b3
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 10:18:32 2012 +1100
smbd: Add mem_ctx to sys_acl_init() and all callers
This changes from allocation on NULL to allocation on the supplied
memory context.
Currently that supplied context is talloc_tos() at the the final consumer of
the ACL.
Andrew Bartlett
commit a4d1f2223abdb0db2a15742ebd59a611cc157443
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 12:44:14 2012 +1100
build: Add vfs_media_harmony to the waf build
commit bb99cf1f729b789290202e573ea3dcedf2f253a0
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 10 16:42:38 2012 +1100
posixacls: Add IDL changes for vfs_acl_xattr using hash of the sys acl
This will isolate the hash of the ACL from any intermediate mapping that
the POSIX -> NT mapping subsystem might need to do, and which might
change if we need to correct that mapping.
Andrew Bartlett
commit 5bb60df5136810c38a10daad152f1e744f38e976
Author: David Disseldorp <ddiss at samba.org>
Date: Wed Oct 10 10:47:20 2012 +0200
s3-rpc_server: fix build warning
enum dcerpc_transport_t is undeclared, include required headers.
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Wed Oct 10 12:41:28 CEST 2012 on sn-devel-104
commit 615951e4e77353547d91fb217b1861877540bde7
Author: Jeremy Allison <jra at samba.org>
Date: Tue Oct 9 12:46:57 2012 -0700
Make sure the returned sd is on the right context, and if not it's always freed.
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Oct 9 23:35:50 CEST 2012 on sn-devel-104
commit 5afabdc976d5ba1fd21dcdede85657b618fb6b76
Author: Jeremy Allison <jra at samba.org>
Date: Tue Oct 9 12:45:30 2012 -0700
Move setting of psd->dacl->revision and protect against null SD's.
commit f88ab17993e22a9c368017d54da437c057e371ca
Author: Karolin Seeger <kseeger at samba.org>
Date: Tue Oct 9 11:56:19 2012 +0200
docs: Add '-V' to the list of options.
Karolin
Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
Autobuild-Date(master): Tue Oct 9 18:53:12 CEST 2012 on sn-devel-104
commit f9a4a9bfe11c1551b490a0bd12fb6904b4a6542b
Author: Karolin Seeger <kseeger at samba.org>
Date: Tue Oct 9 11:53:21 2012 +0200
samba-tool: Some more unifications...
in the usage message.
Karolin
commit 66018ea4fbe290cad6aef54454c1f0703f0dff40
Author: Andreas Schneider <asn at cryptomilk.org>
Date: Tue Oct 9 14:25:29 2012 +0200
packaging: Add config for systemd-tmpfiles.
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Tue Oct 9 17:10:53 CEST 2012 on sn-devel-104
commit 2f0753b456c4d9b4eb52f128a83c8ba19adde160
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Oct 5 10:19:17 2012 +1000
samba-tool: skip chown in sysvolreset when it would fail on a GID
This skips the chown of the files if (for example) the domain Admins group
were to own the file and not be able to because the group maps only to a GID.
This essentially papers over the problem, but may be enough to get us past
the Samba 4.0 release.
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue Oct 9 15:24:44 CEST 2012 on sn-devel-104
commit 1c35c22e62253835e1c82fd44fe8532f6e79dbb9
Author: Volker Lendecke <vl at samba.org>
Date: Tue Oct 9 09:41:41 2012 +0200
s3: Pass down smb_filename to smbacl4_fill_ace4
A full fsp is a bit overkill here
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Tue Oct 9 13:38:49 CEST 2012 on sn-devel-104
commit e65a24b59f1dc7d212a46014a1d7c2531263529f
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Oct 2 13:02:07 2012 +1000
s4-rpc: dnsserver: Ignore DNS zones that are not used by RPC dnsserver
..TrustAnchors zone is not interpreted by RPC dnsserver code.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Tue Oct 9 03:21:07 CEST 2012 on sn-devel-104
commit d70f3644a485ef53e6173ef81326ba6f065f418a
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Oct 2 13:00:50 2012 +1000
s4-dns: dlz_bind9: Ignore zones that are not used by BIND9 DLZ plugin
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
commit 8746faf846fb4f4552e648f4e4e05510b8bd1ef4
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Oct 8 12:50:52 2012 +0200
s4:scripting/python: add '-V' as alias for '--version'
metze
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Mon Oct 8 17:52:52 CEST 2012 on sn-devel-104
commit 309434a77396680b5a40985157da44aaddb5ca71
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Oct 8 12:50:33 2012 +0200
s4:samba-tool: allow 'samba-tool --version'
metze
commit 2fce71c89af66c1467f0a18b97e237b307387620
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Oct 8 12:47:47 2012 +0200
s4:samba-tool: use normal option parsing in SuperCommand
We use the epilog to print the subcommands.
metze
commit 8d4943dcf943dc83b9b663d3d025fb1a8dbcba86
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Oct 8 12:45:20 2012 +0200
s4:samba-tool: add optional epilog to _create_parser()
metze
commit c12cc3cf9c64ee0edd56875a5fb85e37129872ee
Author: Andreas Schneider <asn at samba.org>
Date: Mon Oct 8 12:32:49 2012 +0200
s3fs-printing: Fix RAW printing for normal users.
This fixes bug #8769.
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Mon Oct 8 16:11:51 CEST 2012 on sn-devel-104
commit acea51cc37ff9171c9e18ff0c21b825080aa4b8e
Author: Karolin Seeger <kseeger at samba.org>
Date: Mon Oct 8 12:32:58 2012 +0200
samba-tool: Unify usage messages.
Karolin
Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
Autobuild-Date(master): Mon Oct 8 14:26:52 CEST 2012 on sn-devel-104
commit 8e259891d6ae5c94ab5bc549cbbc1a7e9efb34de
Author: Karolin Seeger <kseeger at samba.org>
Date: Mon Oct 8 11:57:40 2012 +0200
docs: Add man 8 samba-tool.
Addresses bug #8802 - Create missing manpages for new binaries.
Please note that it's a very basic version. Please feel free
to extend.
Karolin
commit a2f3ec0577e275604d15b4bb853705ed18cdd963
Author: Karolin Seeger <kseeger at samba.org>
Date: Mon Oct 8 11:47:22 2012 +0200
samba-tool: Clarify usage of --help.
Karolin
commit b1393d93bc0cbcd058354a64ef63d6f0501f1ce7
Author: Björn Baumbach <bb at sernet.de>
Date: Mon Oct 8 10:42:34 2012 +0200
docs: fix opening and ending tag mismatch: para
in forcedirectorysecuritymode.xml.
commit a93c9e23f932c753d32302d153fe172746ee1181
Author: Björn Baumbach <bb at sernet.de>
Date: Mon Oct 8 10:42:34 2012 +0200
docs: fix opening and ending tag mismatch: para
in directorysecuritymask.xml.
commit 171bf9827bffdb25cee0b0ddd0ddc20cc056fdd0
Author: Karolin Seeger <kseeger at samba.org>
Date: Mon Oct 8 09:47:37 2012 +0200
samba-tool: Fix typo in usage.
Karolin
commit 4b83c43ac27040585fefd61f18d3d111fe3d8a21
Author: Matthieu Patou <mat at matws.net>
Date: Wed Oct 3 00:37:34 2012 -0700
s4-dns: fix a warning
Autobuild-User(master): Matthieu Patou <mat at samba.org>
Autobuild-Date(master): Mon Oct 8 10:45:41 CEST 2012 on sn-devel-104
commit ffab1d7cb28590f8e1ee9b90a8f7dbb84e7adb07
Author: Matthieu Patou <mat at matws.net>
Date: Mon Oct 1 21:36:34 2012 -0700
s4-dns: Ignore zones that shouldn't be returned currently
RootDNSServers should never be returned (Windows DNS server don't)
..TrustAnchors should never be returned as is, (Windows returns
TrustAnchors) and for the moment we don't support DNSSEC so we'd better
not return this zone.
commit 95ea6d765b98d9cbdebaa8e23aad91525d94ad40
Author: Matthieu Patou <mat at matws.net>
Date: Sat Sep 29 10:15:05 2012 -0700
s4-join: factorize code, add info
commit d57e0d8a6d213543a772a517551cca053cece85e
Author: Matthieu Patou <mat at matws.net>
Date: Sun Oct 7 21:52:25 2012 -0700
s4-join: add some documentation
commit 193b15efeaf6cfe89770558cddb2110f7cbd54fe
Author: Matthieu Patou <mat at matws.net>
Date: Thu Sep 27 18:38:29 2012 -0700
s4-repl: make dreplsrv_partition_find_for_nc return BAD_NC only
commit dc002a394b0e41254c061176f480b56a0ac4097d
Author: Matthieu Patou <mat at matws.net>
Date: Thu Sep 27 15:22:00 2012 -0700
drsuapi: Validate the input parameters for the drsuapi_UpdateRefs function
commit 8be6a106ab3a701e593b43e4d5b589b8a1e9013d
Author: Matthieu Patou <mat at matws.net>
Date: Thu Sep 27 15:02:06 2012 -0700
drsuapi: check more carefully the validity of the NC
Check that both the GUID and DN are the GUID/DN of a NC if not return
WERR_DS_DRA_BAD_NC
commit 8bbb4d7b518d7a6f5a1eefdb37e61295dc69ebdd
Author: Matthieu Patou <mat at matws.net>
Date: Thu Sep 27 14:20:26 2012 -0700
drsuapi-idl: Fix the encoding of the source_dsa_dns
astring is not aligned and is not conformant
commit 97f0b8d9c964fd67bd652eaa41a883305876710f
Author: Matthieu Patou <mat at matws.net>
Date: Thu Sep 27 01:27:50 2012 -0700
drs-replica-info: level_not_supported is wrong when we do support (partialy the level)
commit 03c4dceaab82ca2c60c9ce0e09fddd071f98087b
Author: Matthieu Patou <mat at matws.net>
Date: Thu Sep 27 01:22:57 2012 -0700
lib-addns: ensure that allocated buffer are pre set to 0
It avoid bugs when one of the buffer is supposed to contain a string
that is not null terminated (ie. label->label) and that we don't force
the last byte to 0.
commit 85259635d60bc29421a878ec4118d4449c9a359d
Author: Matthieu Patou <mat at matws.net>
Date: Wed Sep 26 18:32:28 2012 -0700
ldap-server: sscanf result was never used to mistyped var
commit 97d0ad0c5eeaed7d06a27a21b96b78536b1dc5df
Author: Matthieu Patou <mat at matws.net>
Date: Wed Sep 26 18:31:39 2012 -0700
ldap-server: remove warning for the ret not being used
commit 5374334d685bd680828aed00f502e6e671e615d7
Author: Matthieu Patou <mat at matws.net>
Date: Wed Sep 26 11:49:07 2012 -0700
s4-drs: fix the logic to allow REPL_SECRET if the account has GET_ALL_CHANGES
commit 8dbba524bfc2bbf8117f51f3dffd2a08835d485d
Author: Matthieu Patou <mat at matws.net>
Date: Wed Sep 26 11:44:58 2012 -0700
s4-drs: EXOP_REPL_SECRETS can be called by RW DC as well
commit 2eae16102a583c8057f9f5a089ba0e5e97fb56d0
Author: Matthieu Patou <mat at matws.net>
Date: Tue Sep 25 14:02:55 2012 -0700
drs-getncchanges: do not set the highestUsn to 0
Paragraph 4.1.10.5 says that
if err = 0 then
msgOut.pNC := msgIn.pNC
msgOut.usnvecFrom := msgIn.usnvecFrom
so no need to set the highestUsn to 0
commit 303ef62b29227a53199f870c18ea2278853e1ddc
Author: Matthieu Patou <mat at matws.net>
Date: Tue Sep 25 13:27:04 2012 -0700
kcc: return invalid parameter if the taskId is not 0
commit f98abc7baaba7b2ea7f40b447535d5998eb819e4
Author: Matthieu Patou <mat at matws.net>
Date: Tue Sep 25 10:51:47 2012 -0700
drs-crackname: if there is no sid do not return the domain
commit e332f989091411602ef7f286ebb2f5b1462550e4
Author: Matthieu Patou <mat at matws.net>
Date: Tue Sep 25 02:00:23 2012 -0700
devel-crackname: Print if count > 0
commit 9269870a709fb7c44f9e4eeb7024ea26dbd32d70
Author: Matthieu Patou <mat at matws.net>
Date: Mon Sep 24 21:34:02 2012 -0700
Implement the LIST_INFO_FOR_SERVER input format
commit 3dd2b804b98e232bf9f28a29577f7fdd026a228c
Author: Matthieu Patou <mat at matws.net>
Date: Mon Sep 24 23:12:25 2012 -0700
getdcinfo: Check that the server object has a serverreference objects pointing to a DC object
The problem was found by the DRSR testsuite where server objects were
created in the Site container without serverrefrence attribute
triggering error in the testsuite.
commit 899cdc4503696cbe1030f3023fe259ce0740a55c
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Mon Oct 8 11:26:43 2012 +1030
ntdb: remove unused local variable.
Reported-by: Matthieu Patou <mat at samba.org>
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Autobuild-User(master): Rusty Russell <rusty at rustcorp.com.au>
Autobuild-Date(master): Mon Oct 8 04:43:37 CEST 2012 on sn-devel-104
commit 9fc42daf75d0eee9fd22e66a3eeb687b178e29e3
Author: Volker Lendecke <vl at samba.org>
Date: Tue Oct 2 15:44:41 2012 +0200
s3: Add two tests a CLEAR_IF_FIRST crash
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Sat Oct 6 17:16:39 CEST 2012 on sn-devel-104
commit c62f8baff878001ead921112dd653ff69d1cfe7d
Author: Volker Lendecke <vl at samba.org>
Date: Tue Oct 2 15:26:14 2012 +0200
tdb: Make tdb robust against improper CLEAR_IF_FIRST restart
When winbind is restarted, there is a potential crash in tdb. Following
situation: We are in a cluster with ctdb. A winbind child hangs
in a request to the DC. Cluster monitoring decides the node has a
problem. Cluster monitoring decides to kill ctdbd. winbind child
still hangs in a RPC request. winbind parent figures that ctdb is
dead and immediately commits suicide. winbind parent is restarted by
cluster management, overwriting gencache.tdb with CLEAR_IF_FIRST. The
CLEAR_IF_FIRST logic as implemented now will not see that a child still
has the tdb open, only the parent holds the ACTIVE_LOCK due to performance
reasons. During the CLEAR_IF_FIRST logic is done, there is a very small
window where we ftruncate(tfd, 0) the file and re-write a proper header
without a lock. When during this small window the winbind child comes
back, wanting to store something into gencache.tdb, that winbind child
will crash with a SIGBUS.
Sounds unlikely? See:
[2012/09/29 07:02:31.871607, 0] lib/util.c:1183(smb_panic)
PANIC (pid 1814517): internal error
[2012/09/29 07:02:31.877596, 0] lib/util.c:1287(log_stack_trace)
BACKTRACE: 35 stack frames:
#0 winbindd(log_stack_trace+0x1a) [0x7feb7d4ca18a]
#1 winbindd(smb_panic+0x2b) [0x7feb7d4ca25b]
#2 winbindd(+0x1a3cc4) [0x7feb7d4bacc4]
#3 /lib64/libc.so.6(+0x32900) [0x7feb7a929900]
#4 /lib64/libc.so.6(memcpy+0x35) [0x7feb7a97f355]
#5 /usr/lib64/libtdb.so.1(+0x6e76) [0x7feb7b0b0e76]
#6 /usr/lib64/libtdb.so.1(+0x3d37) [0x7feb7b0add37]
#7 /usr/lib64/libtdb.so.1(+0x863d) [0x7feb7b0b263d]
#8 /usr/lib64/libtdb.so.1(+0x8700) [0x7feb7b0b2700]
#9 /usr/lib64/libtdb.so.1(+0x2505) [0x7feb7b0ac505]
#10 /usr/lib64/libtdb.so.1(+0x25b7) [0x7feb7b0ac5b7]
#11 /usr/lib64/libtdb.so.1(tdb_fetch+0x13) [0x7feb7b0ac633]
#12 winbindd(gencache_set_data_blob+0x259) [0x7feb7d4d8449]
#13 winbindd(gencache_set+0x53) [0x7feb7d4d85b3]
#14 winbindd(gencache_del+0x5e) [0x7feb7d4d879e]
#15 winbindd(saf_delete+0x93) [0x7feb7d54b693]
#16 winbindd(+0xe507e) [0x7feb7d3fc07e]
#17 winbindd(+0xe85e5) [0x7feb7d3ff5e5]
#18 winbindd(+0xe65be) [0x7feb7d3fd5be]
#19 winbindd(+0xe7562) [0x7feb7d3fe562]
#20 winbindd(init_dc_connection+0x2e) [0x7feb7d3fe5be]
#21 winbindd(+0xe75d9) [0x7feb7d3fe5d9]
#22 winbindd(cm_connect_netlogon+0x58) [0x7feb7d3fe658]
#23 winbindd(_wbint_PingDc+0x61) [0x7feb7d410991]
#24 winbindd(+0x103175) [0x7feb7d41a175]
#25 winbindd(winbindd_dual_ndrcmd+0xb7) [0x7feb7d4107d7]
#26 winbindd(+0xf8609) [0x7feb7d40f609]
#27 winbindd(+0xf9075) [0x7feb7d410075]
#28 winbindd(tevent_common_loop_immediate+0xe8) [0x7feb7d4db198]
#29 winbindd(run_events_poll+0x3c) [0x7feb7d4d93fc]
#30 winbindd(+0x1c2b52) [0x7feb7d4d9b52]
#31 winbindd(_tevent_loop_once+0x90) [0x7feb7d4d9f60]
#32 winbindd(main+0x7b3) [0x7feb7d3e7aa3]
#33 /lib64/libc.so.6(__libc_start_main+0xfd) [0x7feb7a915cdd]
#34 winbindd(+0xce2a9) [0x7feb7d3e52a9]
This is in a winbind child, logfiles surrounding indicate the parent
was restarted.
This patch takes all chain locks around the CLEAR_IF_FIRST introduced
tdb_new_database.
commit 37fd93194db10fc832ed3fa1ec880ebc26be904b
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Sat Oct 6 13:23:05 2012 +0200
tdb: Make robust against shrinking tdbs
When probing for a size change (eg. just before tdb_expand, tdb_check,
tdb_rescue) we call tdb_oob(tdb, tdb->map_size, 1, 1). Unfortunately
this does nothing if the tdb has actually shrunk, which as Volker
demonstrated, can actually happen if a "longlived" parent crashes.
So move the map/update size/remap before the limit check.
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
commit 828793852f3785c620f2716c60f8b1640880ee50
Author: Jeremy Allison <jra at samba.org>
Date: Fri Oct 5 15:51:19 2012 -0700
We should never just assign an st_mode to an ace->perms field, theoretically
they are different so should go through a mapping function. Ensure this is so.
Practically this does not matter, as for user permissions the mapping
function is an identity, and the extra bits we may add are ignored
anyway, but this makes the intent clear.
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sat Oct 6 03:04:14 CEST 2012 on sn-devel-104
commit 47ebc8fbc93ee1eb9640d9ca30275fcfc3b50026
Author: Jeremy Allison <jra at samba.org>
Date: Fri Oct 5 15:48:07 2012 -0700
Modify ensure_canon_entry_valid() into ensure_canon_entry_valid_on_set() - makes the logic clearer.
commit 9466cd189d6a07411f451f7596feee36f0be7f32
Author: Jeremy Allison <jra at samba.org>
Date: Fri Oct 5 15:09:06 2012 -0700
Simplify ensure_canon_entry_valid by splitting out the _get codepath.
commit 36ea39edf8dd9ede756debaf9632f3ded2a51abb
Author: Simo Sorce <idra at samba.org>
Date: Fri Oct 5 10:32:32 2012 -0400
talloc: Convert error cecking macros into fns
This will avoid 'surprise returns' and makes the code cleare to readers.
These macros were complex enough to warrant a full function anyway not
just for readability but also for debuggability.
Thanks David for pointing out this issue.
Autobuild-User(master): Simo Sorce <idra at samba.org>
Autobuild-Date(master): Fri Oct 5 23:24:17 CEST 2012 on sn-devel-104
commit 7d7e33c624875a9694fcebdde942147ac3bf5f74
Author: Simo Sorce <idra at samba.org>
Date: Sat Sep 22 16:35:21 2012 -0400
Add tests for talloc_memlimit
Autobuild-User(master): Simo Sorce <idra at samba.org>
Autobuild-Date(master): Fri Oct 5 07:36:38 CEST 2012 on sn-devel-104
commit a33a78c302fde61fdb7a6e71669f19be2cf5c836
Author: Simo Sorce <idra at samba.org>
Date: Sat Sep 22 16:15:47 2012 -0400
Add memory limiting capability to talloc
By calling talloc_set_memlimit() we can now set a max memory limit
for a whole talloc hierarchy.
ANy attempt to allocate memory beyond the max allowed for the whole
hierarchy wil cause an allocation failure.
Stealing memory correctly accounts for used memory in the old and the new
hierarchy but exceeding the memory limit in the new parent will not cause
a failure.
commit 78594909b8b22bd07978922b1c85dfd6f6456963
Author: Jeremy Allison <jra at samba.org>
Date: Thu Oct 4 13:50:51 2012 -0700
Ensure the masks don't conflict with the ACL checks.
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Oct 5 00:36:40 CEST 2012 on sn-devel-104
commit 18e07f118c0d79b20a89e5fb566025bf88f72e63
Author: Jeremy Allison <jra at samba.org>
Date: Thu Oct 4 12:03:27 2012 -0700
Update WHATSNEW.txt with removed parameters.
commit db62a159b8833a4f1aee0c9733fd263b6d239d53
Author: Jeremy Allison <jra at samba.org>
Date: Wed Oct 3 16:04:18 2012 -0700
Remove the parameters:
security mask
force security mode
directory security mask
force directory security mode
and update the docs.
commit 7622aa16adeb00bf161a6dd07664c37125391272
Author: Jeremy Allison <jra at samba.org>
Date: Wed Oct 3 14:49:01 2012 -0700
Remove all uses of lp_security_mask/lp_force_security_mode/lp_dir_security_mask/lp_force_dir_security_mode
and replace with the normal masks. Now these parameters can be removed.
commit 92fee007bbc0a5ab3a16c8f1521478d4813d0b79
Author: Jeremy Allison <jra at samba.org>
Date: Wed Oct 3 13:59:43 2012 -0700
Revert "Add functions to programatically set the security mask and directory security mask parameters."
This reverts commit 8f0ecbbbeebff0174579a78827d384067cd4cbb7.
Not now needed as part of the move to remove security mask parameters.
commit 3f5a3b60e267d8342a95fff54428f0b13086ff77
Author: Jeremy Allison <jra at samba.org>
Date: Wed Oct 3 13:58:53 2012 -0700
Revert "When creating a new file/directory, we need to obey the create mask/directory mask parameters."
This reverts commit c251a6b0442abc13bc8be4ff8de324c1d7706a78.
Remove this as we're planning to remove the security mask,
directory security mask parameters and only use create mask/directory mask.
commit 1bf209dd7e5a0f0001b3d1e3798093772bbd3fd3
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Oct 4 11:43:20 2012 +0200
html docs: Remove link to Using Samba.
Thanks to Christian Perrier <bubulle at debian.org> for reporting!
Fix bug #7826 - HTML docs index file still points to Using Samba.
Karolin
Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
Autobuild-Date(master): Thu Oct 4 13:48:00 CEST 2012 on sn-devel-104
commit c627ba145e18c3fb91ca6da730541dd1f119c4d0
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Oct 4 10:00:44 2012 +0200
docs: Remove duplicate synonym min protocol.
Karolin
commit 50de2c9bbbc25074f022b4b2cf9d49f8e9a53e01
Author: Andreas Schneider <asn at samba.org>
Date: Tue Oct 2 15:51:08 2012 +0200
s3fs-smbd: Make sure the registry is set up before we init printing.
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Thu Oct 4 12:06:29 CEST 2012 on sn-devel-104
commit fb3cf6c24270d22dad8ac9a1c12e8d77c8189f11
Author: Andreas Schneider <asn at samba.org>
Date: Tue Oct 2 14:25:40 2012 +0200
waf: Build pam_smbpass module only if enabled.
commit 100d38d6e0fae1dc666ae43941570c9f106b73c2
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Thu Oct 4 09:04:23 2012 +0930
tdb: add -e option to tdbdump (and docment it).
This allows for an emergency best-effort dump. It's a little better than
strings(1).
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Autobuild-User(master): Rusty Russell <rusty at rustcorp.com.au>
Autobuild-Date(master): Thu Oct 4 03:16:06 CEST 2012 on sn-devel-104
commit ffde8678910ae838588ab380b48a544333f81241
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Thu Oct 4 09:04:23 2012 +0930
tdb: tdbdump should log errors, and fail in that case.
Dumping a corrupt database should not exit silently with 0 status!
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
commit 90f463b25f7bb0bc944732773c56e356834ea203
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Thu Oct 4 09:04:19 2012 +0930
tdb: add tdb_rescue()
This allows for an emergency best-effort dump. It's a little better than
strings(1).
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
commit fe38a93c71d0adc0be1d43b438ac3b54eaf4ba53
Author: Jeremy Allison <jra at samba.org>
Date: Wed Oct 3 12:58:00 2012 -0700
Correct fix for bug #9222 - smbd ignores the "server signing = no" setting for SMB2.
Signing cannot be disabled for SMB2 by design, so fix the documentation
instead.
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Oct 3 23:47:23 CEST 2012 on sn-devel-104
commit 49a335731a7139a5c66be596f3d544bef72a8556
Author: Jeremy Allison <jra at samba.org>
Date: Wed Oct 3 12:50:42 2012 -0700
Revert "Fix bug #9222 - smbd ignores the "server signing = no" setting for SMB2."
This reverts commit dfd3c31a3f9eea96854b2d22574856368e86b245.
As Metze pointed out:
From MS-SMB2 section 2.2.4:
SMB2_NEGOTIATE_SIGNING_ENABLED
When set, indicates that security signatures are enabled
on the server. The server MUST set this bit, and the client MUST return
STATUS_INVALID_NETWORK_RESPONSE if the flag is missing.
I'll submit a documentation bug to fix #9222 that way.
commit c2f5b2466bb05939c953341517da6d9df814b27c
Author: Jeremy Allison <jra at samba.org>
Date: Tue Oct 2 17:30:54 2012 -0700
Fix bug #9214 - Bad user supplied SMB2 credit value can cause smbd to call smb_panic.
Terminate the connection cleanly instead.
commit 3983515a0d2222c9e559d83f37ec0a4c5820b56d
Author: Björn Baumbach <bb at sernet.de>
Date: Tue Oct 2 11:37:11 2012 +0200
s3-docs: add delete_lost option to vfs_streams_depot.8
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Wed Oct 3 18:10:14 CEST 2012 on sn-devel-104
commit f5a7bc26648e5edd2d0958c50a4432f14f5ce727
Author: Björn Baumbach <bb at sernet.de>
Date: Tue Oct 2 10:53:15 2012 +0200
s3-docs: Fix opening and ending tag mismatch in Samba3-HOWTO (Bug #9235)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit 9a6f648122c274cc93fd8edff8616c9ffffeb6aa
Author: Björn Baumbach <bb at sernet.de>
Date: Wed Sep 19 12:03:21 2012 +0200
s4: samba_backup: Fix typos.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit 9837fd8cc6f0a46817dcfbf9ad2dfd3bfecbe543
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Oct 1 08:51:47 2012 +0200
s4:tortore/rpc/lsa: make more use of torture_assert*
Currently samba3.rpc.lsa.privileges.lsa.Privileges(s3dc)
seems to be flakey.
We may be able to find the bug with this,
or at least mark it as flapping.
metze
commit 6245c5cba29abb54df2f961d9cbe300a49ffdacf
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 3 08:22:27 2012 +1000
wintest: Give dcpromo more time
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Wed Oct 3 16:04:44 CEST 2012 on sn-devel-104
commit 10eba77dcbeec4b389aeb0a456884b7f067c1a3e
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Oct 2 18:45:39 2012 +1000
wintest: Give netdom join more time to complete
commit 535fe95f3c884b247d374685cc4408aeabc64437
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Oct 2 12:34:10 2012 +1000
wintest: Add config file for a second host
commit 1773fc06738846dac6c9cbfa3f3157a19f2567c1
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Oct 2 12:33:48 2012 +1000
wintest: bump version to 4.1
commit 1f267ca10e174ec3661631df2169e381136c2540
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Oct 2 08:12:16 2012 +1000
nsswitch: Build nss_winbind on all supported platforms
This matches what the autoconf build can do.
Andrew Bartlett
commit 0e037bfc60162aa094df3e3cda59f7b9c2327ca9
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 3 16:36:34 2012 +1000
selftest: Always build a linux-style nss_winbind for nss_wrapper
commit df23b17fa99409f680bbda3abcbb6d8eb7c498b0
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Oct 3 10:26:55 2012 +0200
provision: Use logger rather than print.
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Wed Oct 3 14:24:09 CEST 2012 on sn-devel-104
commit c1677e3b2fe42de309459fd8f8b3bea48bca5055
Author: Matthieu Patou <mat at matws.net>
Date: Tue Oct 2 14:30:25 2012 -0700
s4-provision: do not skip setting the acls on sysvol
Autobuild-User(master): Matthieu Patou <mat at samba.org>
Autobuild-Date(master): Wed Oct 3 10:26:06 CEST 2012 on sn-devel-104
commit dfd3c31a3f9eea96854b2d22574856368e86b245
Author: Jeremy Allison <jra at samba.org>
Date: Tue Oct 2 14:10:21 2012 -0700
Fix bug #9222 - smbd ignores the "server signing = no" setting for SMB2.
Still sign if client request is signed, just don't negotiate it in
negprot or sessionsetup.
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Oct 3 00:59:42 CEST 2012 on sn-devel-104
commit c251a6b0442abc13bc8be4ff8de324c1d7706a78
Author: Jeremy Allison <jra at samba.org>
Date: Tue Oct 2 10:25:14 2012 -0700
When creating a new file/directory, we need to obey the create mask/directory mask parameters.
Currently we call FSET_NT_ACL to inherit any ACLs on create. However
FSET_NT_ACL uses the security mask/directory security mask parameters
instead of the create mask/directory mask parameters.
Swap them temporarily when creating to ensure the correct masks
are applied.
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Oct 2 22:27:17 CEST 2012 on sn-devel-104
commit 8f0ecbbbeebff0174579a78827d384067cd4cbb7
Author: Jeremy Allison <jra at samba.org>
Date: Tue Oct 2 10:22:39 2012 -0700
Add functions to programatically set the security mask and directory security mask parameters.
commit 6575d1d34fee45c7a965c7c9641cc52b566a9e7f
Author: Jeremy Allison <jra at samba.org>
Date: Tue Oct 2 10:15:54 2012 -0700
When setting a non-default ACL, don't forget to apply masks to SMB_ACL_USER and SMB_ACL_GROUP entries.
commit 5d5ddbd62490d3e87dd990554a2c7b7eaf2cc24e
Author: Jeremy Allison <jra at samba.org>
Date: Tue Oct 2 10:12:45 2012 -0700
Only apply masks on non-default ACL entries when setting the ACL.
commit 82e7132bdf7c9d4ddead3cd5d845bfe68b93448b
Author: Jeremy Allison <jra at samba.org>
Date: Tue Oct 2 09:55:09 2012 -0700
Use is_default_acl variable in canonicalise_acl().
commit efb446a38cca448855977666499603d12e1477b4
Author: Jeremy Allison <jra at samba.org>
Date: Tue Oct 2 09:21:17 2012 -0700
Reformat spacing to be even.
commit a168a7c791a4be1730a370d059b3a1073fbb0bdd
Author: Volker Lendecke <vl at samba.org>
Date: Tue Oct 2 12:21:20 2012 +0200
tdb: Fix a typo
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Tue Oct 2 19:52:16 CEST 2012 on sn-devel-104
commit 7751d03a1e18a94de1f54f6ba4143b52d8c53180
Author: Günther Deschner <gd at samba.org>
Date: Mon Oct 1 16:19:28 2012 +0200
s3-net: Fix DEBUG() location.
Guenther
Autobuild-User(master): Günther Deschner <gd at samba.org>
Autobuild-Date(master): Tue Oct 2 18:06:17 CEST 2012 on sn-devel-104
commit 0eded14f19806e87b2205677064d1413bcb86d38
Author: Günther Deschner <gd at samba.org>
Date: Tue Sep 25 11:09:45 2012 +0200
s3-net: give more control how to update/register DNS entries.
Guenther
commit ec23d0a3eeeeb2f3969d4d113d80bd82cb1dbbcd
Author: Günther Deschner <gd at samba.org>
Date: Tue Sep 25 11:08:48 2012 +0200
s3-net: pass down a flags field to DoDNSUpdate().
Guenther
commit 5d4247ae7434adae87b265a362a9fa19b4ca557c
Author: Günther Deschner <gd at samba.org>
Date: Wed Sep 19 15:35:15 2012 +0200
s3-net: move out some prototypes to net_dns.h.
Guenther
commit a2fec69b0958f75e31c702e25017eeae6a92be0d
Author: Günther Deschner <gd at samba.org>
Date: Wed Sep 19 15:31:57 2012 +0200
s3-net: pass down struct net_context to the dns update calls.
Guenther
commit 06f3b1f0b0dcf9355a8d634cdb62f1f0a8ea4dbe
Author: Günther Deschner <gd at samba.org>
Date: Mon Dec 19 10:52:58 2011 +0100
s3-kerberos: add aes enctypes to generated krb5.conf.
Guenther
commit eae33e96fcaa456830862325b91579faf2a96213
Author: Günther Deschner <gd at samba.org>
Date: Thu Dec 15 18:12:41 2011 +0100
s3-krb5: use and request AES keys in kerberos operations.
Guenther
commit 4a21d2e7790f1c76cf0d0fcfb2f4a8ef13721532
Author: Alexander Bokovoy <ab at samba.org>
Date: Tue Oct 2 14:53:38 2012 +0300
Fix release script to build full set of documentation
build-docs script was not setting XML catalog properly.
In addition, some time ago pdf versions of images were introduced as
generated dependencies in our books but svg -> pdf rule was not added,
so building books never finished properly.
Autobuild-User(master): Alexander Bokovoy <ab at samba.org>
Autobuild-Date(master): Tue Oct 2 16:21:23 CEST 2012 on sn-devel-104
commit dce8a8e284e544999d85aa7df3ef97c3701742b4
Author: Karolin Seeger <kseeger at samba.org>
Date: Tue Oct 2 10:29:16 2012 +0200
librelease.sh: Move the GPG data to the library section.
Don't use the Library key for the samba releases.
Karolin
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 7eb1f6ff178cb04a04dcaee88f15be850d239430)
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Oct 2 14:28:10 CEST 2012 on sn-devel-104
commit f4b9007faf901db6f703b5109df055081949c3f1
Author: Matthieu Patou <mat at matws.net>
Date: Mon Oct 1 21:43:11 2012 -0700
s4-dns: fix a non handled memory out of memory
Signed-off-by: Kai Blin <kai at samba.org>
Autobuild-User(master): Kai Blin <kai at samba.org>
Autobuild-Date(master): Tue Oct 2 09:43:52 CEST 2012 on sn-devel-104
commit 9f83968e1c201c1196fb4a9699b592bdfc718ea8
Author: Jeremy Allison <jra at samba.org>
Date: Fri Sep 28 09:39:15 2012 -0700
Add samba3.samba3badnameblob test to check regressions in bug #9215.
Bad name in SMB1 openX can cause a crash in iconv inside glibc.
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Mon Oct 1 23:29:25 CEST 2012 on sn-devel-104
commit aa6a7a97803b1106d2200c889a2260f81059c450
Author: Andreas Schneider <asn at samba.org>
Date: Thu Sep 27 19:01:15 2012 +0200
s3fs-smbd: Move housekeeping to the background process.
If you add 200 printers using lpadmin. Then you wait for the printcap
cache to expire. As soon as this expires we notify all deamons that they
should reload the printers. This mean we need to create the default
registry keys for each printer. If you do e.g. a 'smbclient -L' during
that time you will get a lot of timeouts.
This lets the housekeeping function of the printcap cache do the task of
creating the default registry keys in background queue process. When it is done
with the task it will tell all smbd childs to reload the printers and the 200
printers appear.
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Mon Oct 1 20:28:23 CEST 2012 on sn-devel-104
commit 8da8a2289ea51d4fcdf6b5352a46c14d36d8f072
Author: Björn Baumbach <bb at sernet.de>
Date: Thu Sep 27 12:40:47 2012 +0200
s3: vfs_streams_depot: add delete_lost option
With this option lost stream directories will be removed
instead of renamed.
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Mon Oct 1 18:47:30 CEST 2012 on sn-devel-104
commit 7a76762c688f4fc7519dbd204b036963c460e093
Author: Björn Baumbach <bb at sernet.de>
Date: Mon Oct 1 09:55:28 2012 +0200
s3: make recursive_rmdir function non-static
commit 07b918ade8b9f932d6945912d22a04269198a2fe
Author: Jeremy Allison <jra at samba.org>
Date: Mon Oct 1 06:16:18 2012 +0200
s3: Fix bug 8966, Fix net rpc share allowedusers to work with 2008r2
The RAP NetShareEnum command was removed in 2008r2, so use the RPC
equivalent instead.
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Mon Oct 1 07:59:34 CEST 2012 on sn-devel-104
commit 6dbe0aad260d1f6e46e58871a7ce613ca27d0bf6
Author: Ira Cooper <ira at samba.org>
Date: Sun Sep 30 19:02:13 2012 +0000
s3: Fix libnss_winbind.so's build on Illumos/Solaris
Due to not building and linking in the winbind_nss_solaris bits in addition
to the linux bits, nss was broken on Solaris.
Autobuild-User(master): Ira Cooper <ira at samba.org>
Autobuild-Date(master): Sun Sep 30 22:56:30 CEST 2012 on sn-devel-104
commit 81805222ec7a652e188bd106199820570c9dcaad
Author: Kai Blin <kai at samba.org>
Date: Sun Sep 30 11:26:24 2012 +0200
s4 dns: Fix return code for deleted records
This fixes bug #9225. We already had a test for this scenario, but the test wasn't
correct. This patch fixes the test, and also fixes the bug.
Signed-off-by: Kai Blin <kai at samba.org>
Autobuild-User(master): Kai Blin <kai at samba.org>
Autobuild-Date(master): Sun Sep 30 13:09:14 CEST 2012 on sn-devel-104
commit ecb4a8a824faf89a442bdd0eeb5ab9f79a14fb40
Author: Kai Blin <kai at samba.org>
Date: Sun Sep 30 10:44:03 2012 +0200
s4 dns: Get rid of deprecated allocation result check
commit 7d0a9f5a06c807855335b9553a15ba312a7562ff
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Sep 29 20:40:13 2012 +1000
selftest: use an array when starting testenv with system()
By reduing the need for escapes and forcing the use of bash, this
seems to allow 'make testenv' to start on FreeBSD
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sun Sep 30 02:30:40 CEST 2012 on sn-devel-104
commit e576bf5310bc9de9686a71539e9a1b60b4fba5cc
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 25 11:37:33 2012 -0700
s3: Fix opening a file under kernel oplocks
With the prior code we assumed that we do not have kernel oplocks around
when we open a file because we handled samba-internal oplock breaks
before the open attempt.
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Sat Sep 29 19:29:36 CEST 2012 on sn-devel-104
commit e00df42a37ab8ae9818d2dfd33effc160b9ff3c1
Author: Volker Lendecke <vl at samba.org>
Date: Thu Sep 13 15:51:44 2012 +0200
s3: Remove a SMB_ASSERT
With the simplified logic this became unnecessary
commit 8b7e75b3582f288774016ab3d5d32911959da5aa
Author: Volker Lendecke <vl at samba.org>
Date: Wed Sep 26 22:20:57 2012 +0200
s3: Close the now opened file descriptor in error paths
commit 64c49400396847160346e65912c5048ff982764a
Author: Volker Lendecke <vl at samba.org>
Date: Wed Sep 26 10:52:14 2012 -0700
s3: No code change, just re-indent
Look at this with "git diff -b" if you don't believe me :-)
commit 173e808ed48a67ffbafd77a5e9d54ba6b8d3e6e8
Author: Volker Lendecke <vl at samba.org>
Date: Thu Sep 13 15:40:17 2012 +0200
s3: Remove share mode handling before we open the file
This is a significant behaviour change: We do not open the file under
the share mode lock anymore. This might lead to more open calls in case
of oplock breaks or sharing violations, but those are slow error paths
and as such might be not too performance sensitive. The benefit of this
patch is a significant reduction of complexity of open_file_ntcreate()
commit 590d3138be0293fbe9cb575261eb5319351d1e91
Author: Volker Lendecke <vl at samba.org>
Date: Thu Sep 13 15:45:49 2012 +0200
s3: Fix fcb_or_dos_open after logic change
With the new behaviour, we call fcb_or_dos_open after open_file(). It
is open_file() that sets up the fsp so that fcb_or_dos_open can find it
in the list of fsps. Avoid finding the fsp we are just setting up.
commit 8be0f4d30f84e8d9ba0a49ce71f331977f0fb8e7
Author: Volker Lendecke <vl at samba.org>
Date: Wed Sep 26 10:39:42 2012 -0700
s3: Copy share mode handling from before to after open_file
This is a 1:1 copy&paste of the oplock/sharemode code that we do before
an existing file is opened. It is a prerequiste for a patch that removes
all of that handling before we open the file.
commit 6fbb1b5fd55897def70b9603423f23ed8335428e
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Sep 28 19:11:14 2012 +0200
s3:libsmb: use smbXcli_conn_remote_name() in smb2_tcon_send()
metze
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Sat Sep 29 11:52:43 CEST 2012 on sn-devel-104
commit 4e1306c46a0ab00c2e1a5d78a2f3a9bd9bb45cbe
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Sep 28 20:00:21 2012 +0200
s3:libsmb: make cli_echo* protocol independent
metze
commit b186fdd185d2d5c7d9abd7f652aed58fec6de2ff
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Sep 28 19:53:16 2012 +0200
libcli/smb: add smb1cli_echo*
metze
commit a7fa02664ad8c8bbdad14e4c7f732d0da1867449
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Sep 28 19:18:37 2012 +0200
libcli/smb: add smb2cli_echo*
metze
commit faa039ef463e681a28cacd7dda44961219f7b8c6
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Sep 28 19:48:26 2012 +0200
libcli/smb: use an explicit TALLOC_FREE(subreq) in smb2cli_*
metze
commit f0f310c21d0d3863323a7759be104ee3d2d6c23d
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Sep 29 14:31:28 2012 +1000
build: Remove duplicate check for struct getquota_rslt member getquota_rslt_u
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sat Sep 29 08:51:03 CEST 2012 on sn-devel-104
commit 006bdc0be0bf2ef70b3eb24d679bd49f6d8079fd
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Sep 29 14:28:57 2012 +1000
build: Fix quota tests, including move of sysquotas.c to the top level
This correctly detects quotas on FreeBSD
Andrew Bartlett
commit 931ed2509d93110b525f763ffb15ee3feff87fa0
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Sep 29 14:36:41 2012 +1000
lib/replace: Add test for what flag we need for -Werror behaviour
commit 837f47d630618fb382cfd49f5fb14e9af35e82fa
Author: Günther Deschner <gd at samba.org>
Date: Fri Sep 28 18:04:07 2012 +0200
s3-winbindd: Adjust error code loop logic in rpc_trusted_domains().
Guenther
Autobuild-User(master): Günther Deschner <gd at samba.org>
Autobuild-Date(master): Sat Sep 29 00:34:04 CEST 2012 on sn-devel-104
commit e792a44c34e7767f21f8a3dbcdf41e8416349da7
Author: Günther Deschner <gd at samba.org>
Date: Fri Sep 28 18:03:25 2012 +0200
s3-lsa: Flesh out the returned info in _lsa_EnumTrustedDomainsEx().
Guenther
commit 8e53b9dd51b25c9830799e162f7b98286d844c96
Author: Sumit Bose <sbose at redhat.com>
Date: Tue Sep 11 13:28:35 2012 +0200
s3-winbindd: Allow DNS resolution of trusted domains if DNS name is avaliable
Signed-off-by: Günther Deschner <gd at samba.org>
commit 0d7a2af9084c376ad4f664389bb8a59dd6887ab7
Author: David Disseldorp <ddiss at samba.org>
Date: Thu Sep 27 12:34:53 2012 +0200
vfs: check full_audit enum->str mapping on startup
Signed-off-by: Jim McDonough <jmcd at samba.org>
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Fri Sep 28 19:28:49 CEST 2012 on sn-devel-104
commit e8e91fbbab16c7bcaa9665839d86c7d169e89fff
Author: David Disseldorp <ddiss at samba.org>
Date: Thu Sep 27 11:50:22 2012 +0200
vfs: add missing pwrite ops to full_audit
The op enum is used by audit_opname() as an index into the vfs_op_names
array, so any decrepencies cause bogus audit log entries.
Signed-off-by: Jim McDonough <jmcd at samba.org>
commit b9ca792af2091474f826827190987681c1333ef5
Author: Karolin Seeger <kseeger at samba.org>
Date: Fri Sep 28 12:40:14 2012 +0200
WHATSNEW: Add changed parameters.
Needs to be double-checked.
Karolin
Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
Autobuild-Date(master): Fri Sep 28 14:22:52 CEST 2012 on sn-devel-104
commit e30937e2826b43ebb3a77b621a6de8bf272b02d0
Author: Karolin Seeger <kseeger at samba.org>
Date: Fri Sep 28 11:30:06 2012 +0200
WHATSNEW: Start release notes for Samba 4.0.0rc2.
To be continued...
Karolin
commit a6be8a97f705247c1b1cbb0595887d8924740a71
Author: Simo Sorce <idra at samba.org>
Date: Thu Sep 27 14:12:06 2012 -0400
Support UPN_DNS_INFO in the PAC
Previously marked as UNKNOWN_12 the UPN_DNS_INFO is defined in MS-PAC
Autobuild-User(master): Simo Sorce <idra at samba.org>
Autobuild-Date(master): Fri Sep 28 01:13:44 CEST 2012 on sn-devel-104
commit 322e3d42f65dadabeccf8813fcb0e9b7d353ffb2
Author: Jeremy Allison <jra at samba.org>
Date: Wed Sep 26 16:58:58 2012 -0700
Fix bug #9209 - Parse of invalid SMB2 create blob can cause smbd crash.
Ensure we correctly protect against blobs with data_offset==0
and data_length != 0.
Jeremy.
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Sep 27 22:07:02 CEST 2012 on sn-devel-104
commit b7822a55c40c5c42356b263c3d7bc1998fb1a7d3
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Sep 27 09:41:32 2012 -0700
samba4-tests: Move 'samba.tests.source' up.
We would like to run this as early as possible so we get a quick
failure when there is trailing whitespace.
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Thu Sep 27 20:26:27 CEST 2012 on sn-devel-104
commit 0883e174bfdec22a4ff373041afce396cfe7fd7b
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Sep 27 09:34:36 2012 -0700
sanba.upgradehelpers: Use standard functionality for getting temp dir.
commit 2a797f29aa12f6847844af504026be52db659fbb
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Sep 27 09:30:47 2012 -0700
s4-python: Various formatting fixes.
* Trailing whitespace
* use of "==" where "is" should be used
* double spaces
commit 6986f7bdda56d693c642945485006f9660053758
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Thu Sep 27 09:30:26 2012 -0700
samba.tests.source: Check for trailing whitespace in Python files.
commit f8aab2f55fb552c6fd1fc51106cc237f9a1fc32a
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 18:01:35 2012 -0700
smb.conf(5): Add basic documentation for 'dcerpc endpoint servers'.
commit aad669b53eca99f86c2e630bf3f2e9f594fed9c1
Author: Volker Lendecke <vl at samba.org>
Date: Wed Sep 26 16:53:48 2012 -0700
s3: Fix some blank line endings
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Thu Sep 27 07:57:03 CEST 2012 on sn-devel-104
commit 965a2fb6b6bd0401baf273b28d0a5560cde6ebcc
Author: Christian Ambach <ambi at samba.org>
Date: Wed Sep 26 18:30:37 2012 -0700
Revert "smb.conf(5): Remove 'idmap config' documentation - the parameter has"
This reverts commit e809abf55f6a2e6d93bcb5678142f56c49aea397.
This parameter still exists, it is just only used as parametric option
in the code and not easy to spot when looking out for lp_xxx
Autobuild-User(master): Christian Ambach <ambi at samba.org>
Autobuild-Date(master): Thu Sep 27 06:18:38 CEST 2012 on sn-devel-104
commit 1947164feb41710842277874cae0c35bfc97e3ab
Author: Christian Ambach <ambi at samba.org>
Date: Tue Sep 25 03:25:36 2012 +0200
s3:nfs4acls filter away inheritance flags on files
While it is possible to define inheritance flags on files on Windows, this will
be denied by GPFS and UFS (and potentially others).
So it will be better to strip of these bits when being set for files instead of
failing to set the ACL completely (this is current behavior).
Users that want to retain the full SD will have to use acl_xattr (acl_tdb), as
other pieces of the SD are also lost when translating to NFSv4. So this should
not be a too intrusive change, but allow users to migrate data with such flags
instead of failing to migrate the ACL completely.
commit 19631e8e7e7d871261642340ffdcec3f73dccca6
Author: Christian Ambach <ambi at samba.org>
Date: Tue Sep 25 01:34:04 2012 +0200
s3:nfs4acls pass down fsp instead of just the filename
commit 43606bcbbfe237990ab0b100cf322c0c80e90eb2
Author: Christian Ambach <ambi at samba.org>
Date: Mon Sep 24 03:03:26 2012 +0200
s3:passdb formatting changes
fix some trailing whitespace and a typo
commit ee0012de1af1a3899856bcdb80033d1a82d5b174
Author: Ricky Nance <ricky.nance at weaubleau.k12.mo.us>
Date: Wed Sep 26 17:24:40 2012 -0700
samba-tool domain provision: DNS forwarder default
Provision would break with an exception if there was no value given for the DNS forwarder, this simply sets a default to "none".
Signed-off-by: Jelmer Vernooij <jelmer at samba.org>
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Thu Sep 27 04:35:33 CEST 2012 on sn-devel-104
commit ba7075597e5c28f50f3695c59a5050d1c2c98ae4
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 16:06:14 2012 -0700
smb.conf(5): List 'protocol' as alias for 'server max protocol'.
commit 3dc6daf6a950d7059daa8df40e31b51617310496
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 16:11:05 2012 -0700
smb.conf(5): Add documentation for 'client max protocol'.
commit 60b93c314cc204ae0a4e2598100674cf2ff5bf51
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 16:12:16 2012 -0700
smb.conf(5): Add basic documentation for 'client min protocol'.
commit b6cb0b65e08aee972321220ae54cdf2d181356a8
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 15:44:46 2012 -0700
smb.conf(5): Document 'share backend' parameter.
commit b97c257f3af942d0767226793fa705940caad8dd
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 15:55:04 2012 -0700
smb.conf(5): Add basic documentation for 'server min protocol'.
Conflicts:
docs-xml/smbdotconf/protocol/serverminprotocol.xml
commit d1845558e09fd227338d06831f1ea1cf68d2e6fa
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 16:02:40 2012 -0700
smb.conf(5): Extend 'server min protocol' description.
Conflicts:
docs-xml/smbdotconf/protocol/serverminprotocol.xml
commit bc9d5cb13f51be7feac96b754f875d2b33775160
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 13:20:42 2012 -0700
smb.conf(5): Consistent spelling of parameter names.
This includes spacing and casing.
Conflicts:
source4/scripting/python/samba/tests/docs.py
commit 4544c52fc432c4eb5ba45389519d00923d9698ca
Author: Volker Lendecke <vl at samba.org>
Date: Wed Sep 26 15:26:35 2012 -0700
s3: For read-only shares, filter out write bits from conn->access_mask
Signed-off-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Sep 27 02:51:42 CEST 2012 on sn-devel-104
commit 4666dec4160d09a6d87349c5521fe5751eb5e764
Author: Volker Lendecke <vl at samba.org>
Date: Wed Sep 26 14:53:59 2012 -0700
s3: Fix rejecting mkdir on read-only shares
Signed-off-by: Jeremy Allison <jra at samba.org>
commit 3bdca921cc9344d96f4aa3a18ba4aac971539b25
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 13:07:54 2012 -0700
smb.conf(5): Add basic documentation for 'rpc bigendian'.
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Wed Sep 26 23:51:34 CEST 2012 on sn-devel-104
commit 0dd965492cb97e0b3711ab6380a5f9ae0be5ec8c
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 12:59:32 2012 -0700
smb.conf(5): Add basic documentation for 'kpasswd port'.
commit 879b3ad0812a515e784a2623a035fd74369c8a9b
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 12:58:02 2012 -0700
smb.conf(5): Add basic documentation for 'dgram port'.
commit 12ab467f8768a3e2218b3ebddf43fa15c6743d69
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 12:55:15 2012 -0700
smb.conf(5): Add basic documentation for 'unicode'.
commit 3ab03ccd8420a4fc18c46a82a57d18e16cb75c22
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 12:51:41 2012 -0700
smb.conf(5): Add basic documentation for 'web port'.
commit c66744a8c9f60862579bdfa23774d145ff30b406
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 12:50:34 2012 -0700
smb.conf(5): Add basic documentation for 'nbt port'.
commit 29a763aa0f15faa5d6568ad853e8997f90fa924b
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 12:46:37 2012 -0700
smb.conf(5): Add basic documentation for 'krb5 port'.
commit 7dd3cdc6739f0d0ae0a367b45860202e503b6d00
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 12:41:20 2012 -0700
smb.conf(5): 'write ok' is a reverse synonym for 'read only'.
commit 6b9960e78aa860a163ef477701be43273164e4ba
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 18:36:28 2012 +0200
smb.conf(5): Distinguish parametric options.
commit 4192960a9ee692f7c7c1aa3d4393518910ec7542
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 02:37:01 2012 +0200
find_missing_doc: Convert to python.
commit f2b2c1028bcb5da2292c543e4419d258ec3d6b46
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 02:05:39 2012 +0200
find_missing_manpages: convert to python
commit 104c3df6cf759a69eafd303fe8d5870ae5d34149
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 01:24:04 2012 +0200
find_missing_manpages: Ignore make variables.
commit 90b1a94cb436d872148742eec1af56ba7c6dc9ef
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 19:47:56 2012 +0200
netlogon: Per MS-NRPC, don't send unknown workstation flags back to the
client.
commit 5022b3d8c183181b922e3ccac49e5819eb453035
Author: Volker Lendecke <vl at samba.org>
Date: Wed Sep 26 10:07:32 2012 -0700
s4: Fix a -Wunused-value warning
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Wed Sep 26 21:52:00 CEST 2012 on sn-devel-104
commit 24fc5b46f2b33f94bf79fc375432609697aaa45e
Author: Andreas Schneider <asn at samba.org>
Date: Wed Sep 26 18:21:55 2012 +0200
s3-spoolss: Fix builtin forms order to match Windows again.
Thanks to mamachine at gmail.com.
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Wed Sep 26 20:07:44 CEST 2012 on sn-devel-104
commit 36ec31336f4547b311148f27075cdb4fc8c37609
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 4 10:36:47 2012 +0200
s3: Slightly simplify open_file()
The "else" is not necessary. In the if-branch we just returned.
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Wed Sep 26 18:08:03 CEST 2012 on sn-devel-104
commit be300b0588729c3c87f765e2737ebaccc0af02ff
Author: Volker Lendecke <vl at samba.org>
Date: Wed May 30 10:14:51 2012 +0200
Coding: Add comment disproving control-flow changing macros
commit 1fa730deba0f36947775fe490b9be98a92560b3f
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 4 09:28:26 2012 +0200
s3: Slightly simplify calculate_open_access_flags
commit cc58a19565870d62b3d3476b4b718fcd1ff94a46
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 4 09:26:28 2012 +0200
s3: Slightly simplify calculate_open_access_flags
commit 50d324b7e070de4672eff3fb6231923e6dca807a
Author: Andreas Schneider <asn at samba.org>
Date: Tue Sep 25 14:28:22 2012 +0200
s3-smbd: Don't segfault if user specified ports out for range.
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Wed Sep 26 16:28:44 CEST 2012 on sn-devel-104
commit 968da5f890a978f482f56f9eaff0c56a0d52980c
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Sep 26 18:09:20 2012 +1000
nsswitch: Add waf tests for solaris special cases
These are in configure.in for autoconf. Found in the config.h comparison on
the smbtorture4 build.
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Wed Sep 26 11:50:10 CEST 2012 on sn-devel-104
commit 128fb54ab4feb0c665f438f56dca5f734e355be1
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Sep 26 13:10:17 2012 +1000
build: Remove unused --with-sys-quotas option
commit afbc87b8cc5b068feadb773bdf755abc26f7d0db
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Sep 26 12:42:15 2012 +1000
build: Set HAVE_SYS_QUOTAS and WITH_QUOTAS if we have any supported sysquota backend
commit 7ad1971e2240eccda70783c4de77b7c5bc7893d3
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Sep 26 12:33:50 2012 +1000
build: Remove unused samba_cv_sysquotas_file variable from autoconf configure
commit e1f17eef970cd8432a3391b0bb79de4857fac177
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Sep 26 12:33:13 2012 +1000
build: Add waf configure support for non-linux quotas
commit 11634e6cd72bb6883923369731825b81758fbf68
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 02:59:35 2012 +0200
smb.conf(5): Remove documentation for removed 'lock spin count'
parameter.
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Wed Sep 26 09:41:09 CEST 2012 on sn-devel-104
commit e809abf55f6a2e6d93bcb5678142f56c49aea397
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 02:58:28 2012 +0200
smb.conf(5): Remove 'idmap config' documentation - the parameter has
been removed.
commit 30c0c751c2a61b530099ac35663ec8cd8cb66527
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 01:28:17 2012 +0200
Remove unused neatquotes script.
commit be564022cbb394667ec3fed1f811b4628b8423bd
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 01:31:26 2012 +0200
smb.conf.5: Document 'cldap port'.
commit 718317ecef54d90070b29657f613e39892e38d10
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 01:31:37 2012 +0200
undocumented: Drop extension from helper scripts.
commit 05ba1fe418035e44c131fc76b5e62268b433eadc
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Wed Sep 26 00:47:02 2012 +0200
Remove obsolete land-remote.py and land.py scripts.
commit c5e83ee9a57d2d6648941e064f7c1156e52419a9
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Tue Sep 25 22:34:36 2012 +0200
samba-tool: Hide 'samba-tool domain samba3upgrade'.
This subcommand is provided for backwards compatibility only; new use of
it should be discouraged. Its new name is 'samba-tool domain
classicupgrade'.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=9047
commit 98d117a5424d62804b7cb3d8a9ad35e703fc158a
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Sep 26 03:24:22 2012 +0200
selftest/knownfail: samba*.smb2.oplock.stream1 doesn't work
metze
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Wed Sep 26 07:57:12 CEST 2012 on sn-devel-104
commit 7a14f09f9cc14cfb6234175add1841faf751d51a
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Sep 26 03:08:33 2012 +0200
s4:torture/smb2: remove samba specific stuff from smb2.oplock
metze
commit 4604219ceba96955b3c4bf6ab31aa70c11442d61
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Sep 26 03:04:20 2012 +0200
s3:smb2_create: don't take 'state->te' as indication for "was_deferred" (bug #9196)
We always set state->te = NULL of TALLOC_FREE(state->te),
before calling smbd_smb2_request_dispatch(), so
open_was_deferred_smb2() always returned false, while dispatching
it again.
But it's remove_deferred_open_message_smb2_internal() which
should reset this state.
In developer mode validate_my_share_entries() did call smb_panic()
before.
metze
commit 3c4d0ce46995f82921f538757783fa7a678a7fc1
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Sep 26 10:02:43 2012 +1000
samba_dnsupdate: Safely update/create names for Samba3 targets as well
This avoids unlocked writes to the dns_hosts_file, and may fix some of our
issues on the build farm where large numbers of tests fail due to failed name resolution.
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Wed Sep 26 05:48:25 CEST 2012 on sn-devel-104
commit 6d7c651f2f61b481c1e1ade1e2e0e756ccef2210
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Sep 26 09:48:48 2012 +1000
samba_dnsupdate: Move to using tmpfile/rename to keep the dns_hosts_file consistent
This may be the cause of some of the large failure modes on the build farm.
Andrew Bartlett
commit b320e7f93b5905558efa879992c125af66f0043c
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Sep 26 10:40:17 2012 +1000
selftest: Remove invalid security=share and rename secshare to simpleserver
This avoids the loadparm code failing due to the invalid smb.conf entry, and removes
the very last hint of security=share!
Andrew Bartlett
commit 83f60672e1b3069e6b1b90b376460da895e37df3
Author: Jeremy Allison <jra at samba.org>
Date: Tue Sep 25 16:35:09 2012 -0700
Fix bug #9213 - Bad ASN.1 NegTokenInit packet can cause invalid free.
Not the correct fix for the specific issue, but a general fix to
make sure this can never happen again.
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Sep 26 04:07:57 CEST 2012 on sn-devel-104
commit 3902e7332d3d79c257fca451635d08a58d327d70
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Sep 26 08:10:29 2012 +1000
lib/util/charset: We do not use fucntions from wchar.h any more
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Wed Sep 26 02:13:10 CEST 2012 on sn-devel-104
commit 1c5c96d7cd63ad1d46fb120119c5ad6594e103cf
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Sep 26 07:41:38 2012 +1000
lib/util/charset: Try to find iconv on HP-UX
commit 6146b609e7add16a34067a4c40902f63d19fe5fe
Author: Ricky Nance <ricky.nance at weaubleau.k12.mo.us>
Date: Tue Sep 25 01:10:42 2012 -0500
wscript: Removed executable bit.
Removed the executable for both wscript and wscript_build.
commit 7600fd8b0cef3f1de99204ebdd14115a5f36c958
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 4 09:22:49 2012 +0200
s3: Factor out calculate_open_access_flags
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Wed Sep 26 00:22:56 CEST 2012 on sn-devel-104
commit e0de443af80ee6231f4deddc5c7b4534d8c11f83
Author: Volker Lendecke <vl at samba.org>
Date: Wed Sep 12 16:43:36 2012 +0200
s3: Slightly simplify smbd_smb2_request_process_negprot
Remove a nested if-statement
commit 1b403d46c7a94645c72fead6758d81f5b20298cc
Author: Volker Lendecke <vl at samba.org>
Date: Mon Sep 24 14:11:05 2012 -0700
s3: Fix some blank line endings
commit 11af163df89f504da6d9b0878fe99e2941a1d6d6
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 25 10:34:49 2012 -0700
s3: Fix a typo
commit 0feb341502ee5ff1f7d6cff41496a99ba47280d2
Author: Volker Lendecke <vl at samba.org>
Date: Mon Sep 24 14:18:42 2012 -0700
pysmbd: Fix cut&paste errors
commit 809004689a5ec60066d1ae26e9599ec09895c46c
Author: Pierre Lejeune <superheron at gmail.com>
Date: Tue Sep 25 20:56:37 2012 +0200
pyntdb: Fix init function for ntdb python module.
Signed-Off-By: Jelmer Vernooij <jelmer at samba.org>
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Tue Sep 25 22:40:39 CEST 2012 on sn-devel-104
commit fa332b71dc71d23f1475ed6c25a6376934ab652a
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Tue Sep 25 20:49:22 2012 +0200
s4-python: Override SIGINT handler in scripts only.
Override the SIGINT handler in a few select cases only, rather than
doing so in one of the samba Python modules. I've done this where it
matters most; we can add this code to other scripts too if necessary.
This means that importing the 'samba' module from a third party
application does not have side-effects on the state of the signal
handlers.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=9068
commit c034ff7b1516f827ab4538613ec98daa170d9f25
Author: Volker Lendecke <vl at samba.org>
Date: Wed Sep 5 15:24:46 2012 +0200
s3: Slightly simplify is_stat_open
The "access_bits" clause is redundant. is_stat_open says that exactly
at least one of the stat_open_bits must be set and none else.
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Tue Sep 25 20:05:06 CEST 2012 on sn-devel-104
commit 34f2d189846de2cd134756d8f435370b69afb49d
Author: Volker Lendecke <vl at samba.org>
Date: Wed Sep 5 15:19:28 2012 +0200
s3: Make is_stat_open() a bit more readable
commit 849648cdb2ee07d5a0ec687bf5eba900db5c9001
Author: Volker Lendecke <vl at samba.org>
Date: Sun Aug 12 14:29:26 2012 +0200
lib: Make async_sock includable on its own
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Tue Sep 25 18:03:46 CEST 2012 on sn-devel-104
commit f01013b1a47b3dcd6e8099fe69895136e5bab5ad
Author: Volker Lendecke <vl at samba.org>
Date: Thu Sep 13 16:52:44 2012 +0200
s4-torture: Fix some nonemtpy blank lines
commit 456f821626b50e20acc943c7586f1e1cff40f25f
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 4 09:16:55 2012 +0200
s3: Fix indentation of if-expressions
To me this makes open_file_ntcreate a little easier to understand
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Tue Sep 25 10:08:15 CEST 2012 on sn-devel-104
commit 1c1ae6d639364533c4b23cb71c471d0d46bfff36
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Sep 25 11:05:37 2012 +1000
docs: Change TOSHARG-VFS to avoid suggesting VFS modules are Linux/IRIX only
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue Sep 25 08:27:15 CEST 2012 on sn-devel-104
commit a92d95b1773cb024349a0a06432b685d69d59976
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Sep 25 11:05:01 2012 +1000
docs: Remove mention of auth methods in TOSHARG-Passdb
This is not connected to the passdb system, and we should not encourage setting of auth methods
in any case.
Andrew Bartlett
commit 39b1ce102d4d8bca472ae96966e2afab83e8f1c0
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Sep 25 11:04:14 2012 +1000
docs: Fix typo in TOSHARG-Passdb
commit e3f554a99f3871eabac35db1ba3236772ef58f64
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Sep 23 04:55:20 2012 +1000
docs: Remove Win9X/WinMe mentions from TOSHARG-PDC
commit f82affaa6defef52696f69f114143cfb80fee241
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Sep 23 04:54:24 2012 +1000
docs: Add mention of AD DC support in TOSHARG-PDC
commit 6fcb95bad7db8f970ae6c74f1fdd7b4c2a41f25c
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Sep 23 04:53:55 2012 +1000
docs: Explain the no-domain-logons restriction applies to all HOME editions
commit 3be323c6110f1a241f86aacb94c8ff1ba69351c5
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Sep 23 04:52:56 2012 +1000
docs: Remove references to default paramters in TOSHARG-PDC
commit f3ab05003ea94ba2717b544d912ec3e15fb629d5
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Sep 23 03:09:32 2012 +1000
docs: Update TOSHARG-Install
- winbindd runs as many processes now
- open_oplock_ipc errors do not happen any more, we do not use UDP messaging any more.
Andrew Bartlett
commit c4f143f9d7a1502712d8a6b1c872a13632a5cff3
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Sep 25 10:41:05 2012 +1000
client: Fix talloc_stackframe() free order assertion in developer mode
Reported-by: Ricky Nance <ricky.nance at weaubleau.k12.mo.us>
commit 6749cfb418cd8e21df626c7144f1f4db3b6770e7
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Tue Sep 25 01:22:56 2012 +0200
replace: Avoid returning value in void setproctitle() replacement.
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Tue Sep 25 06:38:40 CEST 2012 on sn-devel-104
commit 322654d7923315ac43b2cf9e7a942d535f2ee224
Author: Jeremy Allison <jra at samba.org>
Date: Thu Sep 20 13:35:47 2012 -0700
We now pass "samba3.raw.acls.generic" and "samba3.smb2.acls.GENERIC" with the max access change.
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Sep 25 04:57:44 CEST 2012 on sn-devel-104
commit aef862c7b0f9c4c00f08f57f04d3ccdd859b5b18
Author: Jeremy Allison <jra at samba.org>
Date: Thu Sep 20 12:32:10 2012 -0700
Fix bug #9189 - SMB2 Create doesn't return correct MAX ACCESS access mask in blob.
If we aren't already granted DELETE access, check if we have
DELETE_CHILD in the containing directory.
commit f240a4c2e7e5b05f91ae728334a9aadb4e97351f
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Sep 25 01:13:12 2012 +0200
s4:rpc_server/drsuapi: use talloc_zero instead of talloc() in dcesrv_drsuapi_DsBind()
metze
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Sep 25 03:06:13 CEST 2012 on sn-devel-104
commit bbac4fb42fc441a2b744ad5c5ecf93fbce920665
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Sep 25 01:09:55 2012 +0200
s4:rpc_server/drsuapi: fix a crash in dcesrv_drsuapi_DsGetDomainControllerInfo_1()
metze
commit f44ad3671876802a42846597be901257633e8ca3
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Mon Sep 24 23:02:05 2012 +0200
samba-tool domain provision: DNS forwarder is not a boolean.
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Tue Sep 25 00:48:43 CEST 2012 on sn-devel-104
commit 78cb9fd91bc1ac73ad1a1deb8c9423f88729b707
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Mon Sep 24 09:42:15 2012 +0200
Remove compatibility code for setproctitle() now moved to libreplace.
commit fd8d4ec34785e71de3f8458222d196d454d0e723
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Mon Sep 24 09:20:46 2012 +0200
replace: Support setproctitle().
This uses the setproctitle() from libc, libsetproctitle or libbsd.
If none is available it provides a dummy implementation.
commit 6641d76562db10e6289c5e819b1296d8f6df37bf
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Mon Sep 24 08:26:12 2012 +0200
samba-tool domain-provision: Avoid python2.5-isms.
commit 61ce3e871a1fc1d16202d337d74c2e10f64b2c86
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Mon Sep 24 08:21:27 2012 +0200
samba-tool domain-provision: Fix docstring.
commit df48092a23d7193d3a0f70f5089ec3fbee87a96b
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Sep 24 11:53:22 2012 +0200
script/autobuild.py: set the default for --log-base to the current gitroot
metze
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Mon Sep 24 15:27:16 CEST 2012 on sn-devel-104
commit 67230c43db5eb955c89ccc89d8e8d8aca1f35a1c
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Sep 24 18:02:01 2012 +1000
build: Fix detection of quotas on macos
This is a weird one. While visually OK, the . in sys/types.h was not
made up of the typical ASCII character, so of course did not find
types.h!
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon Sep 24 12:24:45 CEST 2012 on sn-devel-104
commit 13c28787ad22454ddd19e06ae680b8d5abb986c0
Author: Volker Lendecke <vl at samba.org>
Date: Sun Sep 23 18:50:22 2012 -0700
s3-pylibsmb: Use Py_RETURN_NONE
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Mon Sep 24 08:09:53 CEST 2012 on sn-devel-104
commit 0991aed60c47ecbcb0d08368375f6ae2847c8f59
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Sep 24 09:20:59 2012 +1000
torture: More torture_assert() calls in rpc.lsa
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon Sep 24 05:27:46 CEST 2012 on sn-devel-104
commit a807a63f3d1d692d80d640f23ccb9bdbc7b6676f
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Sep 24 08:59:10 2012 +1000
torture: use torture_assert rather than return false in rpc.lsa
This will help ensure we always generate correct subunit failures.
Andrew Bartlett
commit f0908c1dc604b304a788261784a39d08cfb48760
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Sep 24 08:40:05 2012 +1000
torture: tidy up rpc.lsa OpenPolicy2 test to more clearly use torture_fail()
commit 00b12674685798f300e04d6d2e62f1cfa435c982
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Sep 24 07:06:53 2012 +1000
build: Add missing dep on tdb_compat
commit 2e51c386beff808e74c8c1f360a6f4db30fe74b5
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Sep 24 06:45:05 2012 +1000
lib/replace: Look for special flags needed for c99
This is normally handled by the waf core, but for HP-UX we currently fail.
The autoconf code hard-codes a case for HP-UX, but I want to try testing
it using a generic system first.
Andrew Bartlett
commit 0727ad73212ff3cfe7e78249504b0209e082d7c4
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Sep 24 06:03:31 2012 +1000
lib/replace: Improve mkstemp test in autoconf and waf
On the Sernet-solaris8 host, this test passed in the autoconf build,
then failed in the recursive waf build. This newer test should probe
the behaviour more closely, by checking we get two distinct, secure
files.
Andrew Bartlett
commit f767059911460c0944d5e9289148a0776aeb97e5
Author: Christian Ambach <ambi at samba.org>
Date: Sat Sep 22 20:44:41 2012 -0700
s3:winbindd fix a compiler warning
about type potentially being used uninitialized
Autobuild-User(master): Christian Ambach <ambi at samba.org>
Autobuild-Date(master): Mon Sep 24 03:49:53 CEST 2012 on sn-devel-104
commit 9f589ea4066099ed50e7f2323f572b3a8c98c60e
Author: Christian Ambach <ambi at samba.org>
Date: Sun Sep 23 08:39:49 2012 +0200
s3:printing only do printing_subsystem_update when printing is enabled
no point in calling this if printing was disabled and no spoolss service was started
this hurts CTDB clusters as the smbds on the cluster nodes will fight for the single record in the TDB
This fixes Bug 9197 - Disabling printing still makes smbd create and access printer_list.tdb
commit 5f973631b6ba6666ecf5f026d07dded9da15650e
Author: Matthias Dieter Wallnöfer <mdw at samba.org>
Date: Sun Aug 12 18:08:20 2012 +0200
s4:dns_server - introduce the wildcard binding feature
We need the wildcard binding feature otherwise we might get bound to a
private interface in case of multiple interfaces and no "interfaces"
parameter in smb.conf.
Code taken from source4/ldap_server/ldap_server.c
Signed-off-by: Kai Blin <kai at samba.org>
Autobuild-User(master): Kai Blin <kai at samba.org>
Autobuild-Date(master): Sun Sep 23 23:44:03 CEST 2012 on sn-devel-104
commit 9e6070b5fcc17f0e866367c4d3f4dfcb95be6c46
Author: Volker Lendecke <vl at samba.org>
Date: Sat Sep 22 10:45:32 2012 -0700
s3-pylibsmb: Add get_oplock_break
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Sun Sep 23 18:01:28 CEST 2012 on sn-devel-104
commit ff6840815d6e6252aa3fa27a4f04d992ab912d14
Author: Volker Lendecke <vl at samba.org>
Date: Sat Sep 22 10:40:06 2012 -0700
s3-pylibsmb: Factor out py_tevent_cond_signal
commit d0a0fb32929e26ea9dd30cb3e2cacff03f68b9d2
Author: Volker Lendecke <vl at samba.org>
Date: Sat Sep 22 10:38:46 2012 -0700
s3-pylibsmb: Reduce the number of warnings
commit 7305660c1139fc1d2dc40fb3324855ec7381eac5
Author: Volker Lendecke <vl at samba.org>
Date: Sat Sep 22 18:57:47 2012 +0200
s3: Convert cli_oplock_break_waiter to smbXcli
commit 982ddc478551c3eb11a6d01acaea22fb60743d2a
Author: Volker Lendecke <vl at samba.org>
Date: Mon Aug 20 14:38:42 2012 +0200
s3: Add "readdir" to pylibsmb
commit a272635b792a806f589cd5a6a3a345cdc855b4be
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 18 16:19:07 2012 -0700
s3: Fix some nonempty line endings
commit e0fdeda86cfc75cfe2bdd7dffeef7fc9e173c8aa
Author: Christian Ambach <ambi at samba.org>
Date: Sun Sep 16 11:39:26 2012 -0700
s3-pylibsmb: move py_tevent_req_wait_exc up in the file
this is needed to be able to use it in other functions and
spares the prototype
Pair-Programmed-With: Volker Lendecke <vl at samba.org>
commit 947520521ed3da2f0787e17a9fe906024fdee7e3
Author: Volker Lendecke <vl at samba.org>
Date: Fri Sep 21 12:05:04 2012 -0700
s3-pylibsmb: Factor out py_tevent_cond_wait
commit 8e5f30c830c23d8223c38e34669f069e44fee64b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Sep 23 14:37:24 2012 +1000
build: Remove unused define UNIXWARE
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sun Sep 23 08:33:02 CEST 2012 on sn-devel-104
commit ffb3f2a19f4780e45ea0b95520aeb73c20893c44
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Sep 23 14:35:58 2012 +1000
lib/replace: Remove unused nap and therefore the SCO define
In any case, the Samba Team stopped supporting SCO systems a long time ago.
Andrew Bartlett
commit 0f69bf2cc9ce8ab76afefa693f3d50e458459854
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Sep 23 14:30:37 2012 +1000
build: Make waf configure match autoconf for HPUX ACLs
commit e0bcce55033f27ffa734b839e23bc731d82614f0
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Sep 23 14:30:10 2012 +1000
build: Rework waf STAT_ST_BLOCKSIZE to match autoconf, with 512 as the default
The autoconf build simply has 512 as the default, without a warning. Rather than
enumerate every OS ever made, just handle the known exceptions.
Andrew Bartlett
commit 73bdb2a6c2f04c22780e2441a3e671722b16dfab
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Sep 23 14:25:00 2012 +1000
lib/util: Remove unbuilt file util_getent.c and BROKEN_GETGRNAM
Removing this unbuilt file allows removing BROKEN_GETGRNAM which was only
ever defined per-OS, not based on an actual test.
Andrew Bartlett
commit 41b9cb32ce82a33b5dd8f5bd00d05ac0708a5a4d
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Sep 23 13:57:44 2012 +1000
build: Remove unused IRIX and IRIX6 defines
commit 502135df9f0d839e75907260f5dcdab4052d995e
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Sep 23 13:39:01 2012 +1000
lib/replace: Try to fix build on HP-UX for os2_delete test
The issue is that this file is both used in an autoconf test, and
later in a smbtorture test. Because os2_delete.c does not include
replace.h, bool may not be defined.
So, instead we shift the need for bool to a different header.
(The readdir tests in repdir.m4 are not yet in the waf configure).
Andrew Bartlett
commit 08d3062fc3ece6b5d98e32bad5f1d54c088b0dd0
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sun Sep 23 13:20:45 2012 +1000
ntdb: Try to fix the build on Solaris which does not have err
commit a4c54f66585c6f6cf01be5e28f211176fc7d241d
Author: Michael Adam <obnox at samba.org>
Date: Fri Sep 7 12:09:13 2012 +0200
s4:torture:smb2: add a durable-open.read-only test
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Sun Sep 23 05:47:30 CEST 2012 on sn-devel-104
commit b5ef4d5cad2395421c9136898cd271309882761c
Author: Stefan Metzmacher <metze at samba.org>
Date: Sun Sep 23 00:50:48 2012 +0200
script/autobuild.py: remove --rebase-master and --push-master options
You should explicitly pass the urls to --rebase= and --pushto=
metze
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Sun Sep 23 02:53:56 CEST 2012 on sn-devel-104
commit 0319903b31474575baa78abac30004693f574158
Author: Christian Ambach <ambi at samba.org>
Date: Sat Sep 22 13:33:02 2012 -0700
s3:vfs_fake_acls fix a compiler warning
about acl being potentially uninitialized
Autobuild-User(master): Christian Ambach <ambi at samba.org>
Autobuild-Date(master): Sun Sep 23 01:08:39 CEST 2012 on sn-devel-104
commit 1b5256c184ec378783e6219b34b5a3e512c4df99
Author: Christian Ambach <ambi at samba.org>
Date: Sat Sep 22 13:32:00 2012 -0700
s3:winbindd fix a compiler warning
about result being potentially uninitialized
commit f339c1fd91baaff1d727cda1a30b0963423dcb5b
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Sep 22 02:40:19 2012 +0200
script/autobuild.py: add --log-base option
metze
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Sat Sep 22 23:21:59 CEST 2012 on sn-devel-104
commit 1362bb548c9cb6d3e688ab102bd1d8166d73d95f
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Sep 22 02:34:38 2012 +0200
script/autobuild.py: add log_base variable to avoid hardcoded values
metze
commit 23dbf63e2d1bf3a30a2b6563fc9bafde4ca157fb
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Sep 22 02:26:10 2012 +0200
script/autobuild.py: add --branch option
metze
commit ce22882df7e00b22a735539791806264424033a7
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Sep 22 02:18:11 2012 +0200
script/autobuild.py: use some variables for push_remote and push_branch
metze
commit a68ab0e97e8dedc8298ca6502b1efc6ca2e32d66
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Sep 22 00:23:21 2012 +0200
script/autobuild.py: use some variables for rebase_remote and rebase_branch
metze
commit 162fbf4adbd78af0ca62e01da30e9c8bf86d3b4d
Author: Michael Adam <obnox at samba.org>
Date: Sat Sep 22 19:07:51 2012 +0200
selftest: skip the samba4.smb2.compound testsuite
Too many tests are starting but never finish.
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Sat Sep 22 20:50:06 CEST 2012 on sn-devel-104
commit 93bee9b3e31b398b9becc7be7804025d4066359b
Author: Michael Adam <obnox at samba.org>
Date: Fri Sep 21 22:56:20 2012 +0200
s3:smbd:smb2: initialize variable in vfs_default_durable_reconnect()
Found by Ambi's state-of-the-art compiler!
commit 841934647b06d6400148932cc8ce02a20c209610
Author: Michael Adam <obnox at samba.org>
Date: Thu Sep 20 20:46:53 2012 +0200
selftest: we fail samba3.smb2.compound.interim2
We currently return NT_STATUS_CANCELLED where we should
return NT_STATUS_INTERNAL_ERROR.
commit 6f6b1c6ac15f225978e8c2d67c1a817d9e098317
Author: Michael Adam <obnox at samba.org>
Date: Thu Sep 20 00:43:54 2012 +0200
s4:torture:smb2:compound: remove two unused macros
commit 8df0b023c51ed198d3054760447e1b273eada991
Author: Michael Adam <obnox at samba.org>
Date: Thu Sep 20 00:41:48 2012 +0200
s4:torture:smb2: don't skip the compound.interim2 test for non win7/win2k8
commit 917e714831178b2a3d07c7f9d09711231a7ccf31
Author: Michael Adam <obnox at samba.org>
Date: Thu Sep 20 00:41:04 2012 +0200
s4:torture:smb2: don't skip the compound.interim1 test for non win7/win2k8
commit 88d051f7f18ff88ec5385fdc798f051659134bd3
Author: Michael Adam <obnox at samba.org>
Date: Sat Sep 22 02:05:18 2012 +0200
s3:smbd: remove struct member smbd_smb2_request.cancelled - it was only written
commit 603f9bfa4cf7910e1c1cae1a8d0741a6d0874baa
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Sep 20 16:16:03 2012 +0200
s3:smb2_lock: let smbd_smb2_create_cancel() trigger NT_STATUS_CANCELED
Instead of violating the tevent_req layers.
metze
commit 65a81060093cf9d7c0ebf8d6e160625bdc87baab
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Sep 20 16:16:03 2012 +0200
s3:smb2_lock: smbd_smb2_notify_recv() can already return NT_STATUS_CANCELED
That's why we can remove the code that violates the tevent_req layers.
metze
commit 882cee0acb9c1e2105a005f0ea90691197a696c7
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Sep 20 16:25:58 2012 +0200
s3:smb2_notify: make use of tevent_req_defer_callback() instead of custom tevent_immediate
metze
commit 1f0dfd42f16c388abc7054a7b615d2e81031472b
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Sep 20 16:23:26 2012 +0200
s3:smb2_notify: don't call tevent_req_done() from smbd_smb2_notify_cancel()
smbd_notify_cancel_by_smbreq() will already trigger this via
smbd_smb2_notify_reply() and smbd_smb2_notify_reply_trigger().
metze
commit 1f8e4732c5870043fbbc22c772404b5380f808f0
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Sep 20 16:16:03 2012 +0200
s3:smb2_lock: let smbd_smb2_lock_cancel() trigger NT_STATUS_CANCELED
Instead of violating the tevent_req layers.
metze
commit 9249871f40aab021d62d3154f8ca286b52f5ef76
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Sep 20 16:04:01 2012 +0200
s3:smb2_server: avoid segfault in smbd_smb2_request_pending_queue()
Because we should not call smbd_smb2_request_error() on an
request that is still running.
If the subreq implementes a cancel function, this should
take care of triggering smbd_smb2_request_error.
metze
Signed-off-by: Michael Adam <obnox at samba.org>
commit 25437df8a65e56616499dda18c696f58be08f67a
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Sep 21 22:20:20 2012 +0200
s4:torture:smb2: extend the compound.invalid1 test
Test that when turning the related flag back off for the
last compound request, the return code changes from
invalid parameter to file closed.
Pair-Programmed-With: Michael Adam <obnox at samba.org>
commit 1ae6f9c62629f8513bbe93a56775b3c64ff06832
Author: Michael Adam <obnox at samba.org>
Date: Fri Sep 21 21:43:36 2012 +0200
s3:smbd:smb2: simplify smbd_smb2_request_validate() and smbd_smb2_request_dispatch()
removes unnneccary checks/assignments for compound_related and next_status
and duplicate setting of error status.
And remove (now) unused next_status from struct smbd_smb2_request.
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
commit 27d38b5c27bd96d5124c175d946718bf0836b8f4
Author: Michael Adam <obnox at samba.org>
Date: Sat Sep 22 04:06:27 2012 +0200
s3:smbd:smb2: add check for session_status for compound requests
commit 4384485f82aac109bf4c4c31075e313e54b4c076
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Sep 20 00:52:19 2012 +0200
s3:smb2_server: do the req->next_status check before the signing checks
Windows 2012 returns NT_STATUS_INVALID_PARAMETER to
the smb2.compound.invalid1 test if that uses signing
(instead of NT_STATUS_ACCESS_DENIED).
metze
commit 2552b6632372b35cbd7b788c4e00091dfe520a41
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Sep 20 05:10:28 2012 +0200
s3:smb2_server: reset req->last_session_id and req->last_tid after using it
If we can find a valid session or tcon we'll set it after the lookup,
but it need to make sure to reset it if we don't find the session.
This fixes a problem where a compound unrelated request between
related requests doesn't reset the session.
If we have 3 requests in a compound chain, request 3 should never
use the id's cached from request 1. It should only every inherit
handles from request 2.
metze
commit bd8d50b451ea7f94efa7777fbe5dc0c2c19f6bf9
Author: Michael Adam <obnox at samba.org>
Date: Thu Sep 20 00:36:29 2012 +0200
s4:torture:smb2: fix the compound.invalid3 test to work against windows
commit 8e525a29a7c6512f61e4647ecb2e0771e2019a49
Author: Michael Adam <obnox at samba.org>
Date: Thu Sep 20 00:35:52 2012 +0200
s4:torture:smb2: fix compound.related3 test to work against windows
commit 75951946193c874b6db30c1b9c8722264c3ce656
Author: Ira Cooper <ira at samba.org>
Date: Wed Sep 19 18:39:07 2012 +0000
s3: Compound requests should continue processing.
This patch addresses #9173.
Signed-off-by: Michael Adam <obnox at samba.org>
commit fe2071cd3bae655b9aa7908059f0e19520e2db90
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Sep 21 22:27:24 2012 -0700
build: Fix enabled handling for HAVE_LDAP, we need to use bld.CONFIG_SET
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sat Sep 22 09:09:17 CEST 2012 on sn-devel-104
commit b8eaa57a100818d337c85ac42828801a59062587
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Sep 21 21:57:22 2012 -0700
build: Try not build with LDAP if we do not have ldap.h
commit cb157e19cb6e96f319008c7178d04bfe7b30b5b4
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Sep 21 23:06:13 2012 +0200
s4:dns.py: reproducer for (bug #9184)
metze
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Sat Sep 22 06:08:05 CEST 2012 on sn-devel-104
commit eacdd9f730c09bc59e3906e4f2eff6b8b3051169
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Sep 21 22:54:26 2012 +0200
lib/tsocket: fix receiving of udp packets from 0 bytes (bug #9184)
It's possible for a client to send 0 bytes in a UDP packet,
we need still need to call recvfrom() and skip the invalid
packet at a higher level. Otherwise the kernel receive queue
is blocked.
metze
commit cc93a3004e1f7a38e7519ecd124a1ce6a21ffe1c
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Sep 21 22:18:10 2012 +0200
libcli/echo: validate the message length
metze
commit 83ed9b52e75215e7590f842fa7c1ec1a4e4aa6bc
Author: Christian Ambach <ambi at samba.org>
Date: Fri Sep 21 13:54:47 2012 -0700
s3:pdb_ldap remove unused function
Autobuild-User(master): Christian Ambach <ambi at samba.org>
Autobuild-Date(master): Sat Sep 22 04:28:37 CEST 2012 on sn-devel-104
commit 8df92a44fcf96a8950a1ba500dbe8febfe91b3de
Author: Christian Ambach <ambi at samba.org>
Date: Fri Sep 21 14:00:53 2012 -0700
s3:rpcclient fix a compiler warning
commit f480b44430520f998fea867aa4c2cf9e93cb8d51
Author: Christian Ambach <ambi at samba.org>
Date: Fri Sep 21 13:58:29 2012 -0700
s3:utils/net fix a compiler warning
ret might be used uninitialized in out-of-memory condition
commit d59688a8e749454a59174b545f152a5c2880f999
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Sep 21 15:59:11 2012 -0700
auth/kerberos: add HAVE_KRB5 guard to fix non-krb5 build after winbindd pac changes
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sat Sep 22 02:44:07 CEST 2012 on sn-devel-104
commit 7a493fd867b95a7901c5f2b0c77cfb1c4496fbef
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Sep 21 20:36:16 2012 +0200
s3:smbd: release the share mode lock before calling exit_server() (bug #9191)
metze
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Fri Sep 21 22:36:57 CEST 2012 on sn-devel-104
commit bfafb0ce838c0cc3003c35e16c99d9eb9e1266a8
Author: Gregor Beck <gbeck at sernet.de>
Date: Tue Nov 8 16:06:56 2011 +0100
s3:dbwrap_ctdb: set errno = ENOSYS if clustering is not supported
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Fri Sep 21 18:05:56 CEST 2012 on sn-devel-104
commit 160ca49953570fe55fe089241d1ba6ed1c9c9783
Author: Gregor Beck <gbeck at sernet.de>
Date: Tue Oct 18 13:15:22 2011 +0200
libtorture: factor out simple ui backend
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit c3f1aed86f7f414ecdf676d52011c396e65aa374
Author: Gregor Beck <gbeck at sernet.de>
Date: Tue Oct 25 14:51:23 2011 +0200
s3:dbwrap: remove unused args from db_open_file()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit fe74b777d2beb6d033b68c271d9c869789cc4ac5
Author: Gregor Beck <gbeck at sernet.de>
Date: Tue Oct 25 09:33:05 2011 +0200
s3:dbwrap: let dbwrap_fetch_uint32 distinguish between "not found" and "wrong format"
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit ae037670b83557d8591c633896186a3634de30cc
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jan 18 08:33:37 2012 +0100
dynconfig/config.m4: disallow --prefix=/usr and --prefix=/usr/local without --enable-fhs
This matches the waf configure behavior and catches the case where old build
scripts try '--with-fhs' instead of '--enable-fhs'.
metze
commit 914b02be5a3e7805110f517e39ed9f6fe760c2bc
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Sep 20 19:46:31 2012 -0700
libwbclient: bump ABI to 0.11 as wbcAuthenticateUserEx now provides PAC parsing
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Fri Sep 21 06:37:15 CEST 2012 on sn-devel-104
commit d9747b15c4a737a1422d0156d92efed762bb672d
Author: Christof Schmitt <christof.schmitt at us.ibm.com>
Date: Thu Sep 20 18:30:07 2012 -0700
s4-torture: Complete test for winbindd PAC parsing
Decode the PAC through the wbcAuthenticateUserEx call, also decode it
locally and compare the result.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
commit 05befd2f734d3962619ebc0cc137bbe5cedfd81d
Author: Christof Schmitt <christof.schmitt at us.ibm.com>
Date: Mon Jul 30 11:03:54 2012 -0700
auth/kerberos: Adjust log level for failed PAC signature verification
With winbindd trying to verify the signature of an application provided
PAC, this message can be easily triggered. Adjust the debug level to
avoid filling up the logs.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
commit 1bc2f28b9420829645ed571daf2a17e6688b2103
Author: Christof Schmitt <christof.schmitt at us.ibm.com>
Date: Wed Jul 18 14:38:47 2012 -0700
winbind: Extend wbcAuthenticateUserEx to provide PAC
With this new interface, external applications that have authenticated
to an ADS can pass the PAC from the Kerberos ticket to
wbcAuthenticateUserEx. winbindd decodes and extracts the info3
information for the external application. If winbindd can verify the PAC
signature, the info3 from the PACis also added to the netsamlogon_cache.
The info3 data can be used by the external application to get the uid
and primary gid. The data in netsamlogon_cache allows to retrieve the
complete group list through the NSS function getgrouplist.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
commit 8a6a13ab51f404525ff18f65d5a22132c465898e
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 18 10:34:48 2012 -0700
auth: Fix some nonempty blank lines
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
commit 0231575709231eadd89761d966c1b8412950de00
Author: Ira Cooper <ira at samba.org>
Date: Thu Sep 20 19:38:12 2012 +0000
waf: Make samba "ok" with directories for install being symlinks
stat -> lstat conversion. This allows people for whom $PREFIX/var is a
symlink to complete make install.
Autobuild-User(master): Ira Cooper <ira at samba.org>
Autobuild-Date(master): Thu Sep 20 23:26:26 CEST 2012 on sn-devel-104
commit a125ea7419142dfb86c4f32b1d46896f3bf40704
Author: David Disseldorp <ddiss at samba.org>
Date: Thu Sep 20 08:35:27 2012 +0200
vfs: fix acl_blob_get* in vfs_full_audit
Plumb-in functions and use correct return types.
Autobuild-User(master): David Disseldorp <ddiss at samba.org>
Autobuild-Date(master): Thu Sep 20 20:42:09 CEST 2012 on sn-devel-104
commit 47becf6e20a970d273afab8be176d8cbe5ab2b9c
Author: David Disseldorp <ddiss at samba.org>
Date: Thu Sep 20 08:20:57 2012 +0200
vfs: fix lock logging in vfs_full_audit
commit 48e6da64fd6cdd055008c7d3e42e8245435f422e
Author: Daniele Dario <d.dario76 at gmail.com>
Date: Thu Sep 20 15:05:13 2012 +0200
Correct command help message
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Thu Sep 20 16:55:17 CEST 2012 on sn-devel-104
commit d52d7efba31e3f1e63ed365900aba0a8cb960930
Author: Andreas Schneider <asn at samba.org>
Date: Thu Sep 20 10:20:31 2012 +0200
s3-printing: Increase debug level for info that the db is empty.
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Thu Sep 20 12:01:48 CEST 2012 on sn-devel-104
commit bc77745cfaf502e24575dab9ae323643d94760e3
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Sep 20 00:42:02 2012 +0200
s3:smb2_server: fix usage of invalid memory in smb2_signing_check_pdu()
metze
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Thu Sep 20 07:18:31 CEST 2012 on sn-devel-104
commit 38994f6ff34316ad08961f62a1f57429f7968e70
Author: Michael Adam <obnox at samba.org>
Date: Wed Sep 19 02:57:37 2012 +0200
s3:winbind:idmap_tdb_common: improve readability of assignment by adding an "if"
in idmap_tdb_common_sids_to_unixids()
commit d1de2b4d3999dda96df9156da30a239af3b2b88e
Author: Michael Adam <obnox at samba.org>
Date: Wed Sep 19 02:57:37 2012 +0200
s3:winbind:idmap_tdb_common: improve readability of assignment by adding an "if"
in idmap_tdb_common_unixids_to_sids()
commit 03055af9b2af8a5a1c23946369a21d6437cf1b8c
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 18 15:31:26 2012 -0700
s3: Fix idmap_hash
Calling be_init with NULL safely crashes, because we dereference NULL. We
don't need to call it here, this is called in all workers anyway. Thanks
to Jiri Sasek <jiri.sasek at oracle.com> for finding this.
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Thu Sep 20 05:03:54 CEST 2012 on sn-devel-104
commit f43498b7590e33f2c8939c4f04781068674335af
Author: Michael Adam <obnox at samba.org>
Date: Fri Sep 7 16:42:37 2012 +0200
selftest: we currently fail smb2.durable-v2-open.app-instance
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Wed Sep 19 23:05:43 CEST 2012 on sn-devel-104
commit 1c2f1a18623c9092fda6cb74788c17fc572e5791
Author: Michael Adam <obnox at samba.org>
Date: Fri Sep 7 14:30:07 2012 +0200
s4:torture:smb2: add a new test durable-v2-open.app-instance
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
commit a397c8516467b83d7e2cb5b4a15dea26798786d5
Author: Michael Adam <obnox at samba.org>
Date: Fri Sep 7 12:06:36 2012 +0200
s4:libci: add a SMB2_CREATE_APP_INSTANCE_ID blob to the request if the in.app_instance_id is present
commit 562719f75f9868d13f4838b36cc263ef5d3541b1
Author: Michael Adam <obnox at samba.org>
Date: Fri Sep 7 12:06:05 2012 +0200
s4:libcli: add a app_instance_id member to the smb2_create input struct
commit 50c10cbdcedc892e07297686dbe380cfb3f94cef
Author: Michael Adam <obnox at samba.org>
Date: Fri Sep 7 12:05:24 2012 +0200
libcli: add a define for the APP_INSTANCE_ID smb2 create context
commit e6c600aa2c751e694917322378417816c3e58eb6
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Sep 19 21:18:46 2012 +0200
s4:torture/smb2: improve the smb2.create.blob test
metze
commit aa5caf1fe92b159eae00c7b11499e9ec697cf9ae
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Sep 19 08:11:23 2012 +0200
libcli/smb: fix padding in smb2_create_blob*
metze
commit 98d90c02f0961d173bebb9901c7ad0819827f96e
Author: Günther Deschner <gd at samba.org>
Date: Wed Sep 19 10:59:50 2012 +0200
pam_winbind: match more return codes when wbcGetPwnam has failed.
This is required to properly return PAM_USER_UNKNOWN in case winbind had a
problem.
Guenther
Autobuild-User(master): Günther Deschner <gd at samba.org>
Autobuild-Date(master): Wed Sep 19 15:06:10 CEST 2012 on sn-devel-104
commit f6e33eb890dbe4451d3b3ff52a2f38d3a5ceb8c8
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 18 14:35:39 2012 -0700
s3: Use SBVAL in put_long_date_timespec
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Wed Sep 19 01:16:25 CEST 2012 on sn-devel-104
commit 2bbde78ce491cce4ea504cbc583a6935b809d609
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 18 11:56:03 2012 -0700
s3: Fix some nonempty line endings
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Tue Sep 18 22:39:07 CEST 2012 on sn-devel-104
commit ea96d79e21a549204a7f64307059ea877bfb9fd5
Author: Björn Jacke <bj at sernet.de>
Date: Tue Sep 18 14:04:06 2012 +0200
replace: fix 520c9b0b0ae33
fix typo in ifdef. Thanks to Joachim Schmitz for spotting this!
Autobuild-User(master): Björn Jacke <bj at sernet.de>
Autobuild-Date(master): Tue Sep 18 16:06:18 CEST 2012 on sn-devel-104
commit 0b57d1c07520f4995412f224945324fef29f5989
Author: Björn Jacke <bj at sernet.de>
Date: Tue Sep 18 13:57:30 2012 +0200
quota: add supprt for gfs2
gfs2 uses the same generic quota interface as xfs and it has the same base
block/quota block size ratio and seems to work nice with the xfs quota module.
(People using gfs should be aware that quota reporting is lagging quite a bit
on gfs. If you copy a file on a gfs volume the quota values are being updated
with a delay of 30s here with kernel 3.5. This reporting can lead to data
corruption if a client thinks he can write but actually he suddently can't.)
commit 6fb91dd36950151aeec69c074f4d900a6e7adba1
Author: Karolin Seeger <kseeger at samba.org>
Date: Tue Sep 18 11:08:17 2012 +0200
RHEL packaging: Try to fix makerpms.sh on RHEL.
Address bug #9165 - makerpms.sh can't create package fo RHEL.
Karolin
Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
Autobuild-Date(master): Tue Sep 18 12:51:01 CEST 2012 on sn-devel-104
commit 2a7484eb7286a6896826ad1ed15aa7b1760a451c
Author: Matthieu Patou <mat at matws.net>
Date: Mon Sep 17 16:51:02 2012 -0700
panic action is defined as GLOBAL_VAR(szPanicAction) not GLOBAL_VAR(panic_action)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Sep 18 06:12:00 CEST 2012 on sn-devel-104
commit 56956910051a8d11b36d125780fde048d29ad604
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Sep 17 18:15:03 2012 +0200
packaging/RHEL-CTDB: add "BUILD_GPFS=no configure.rpm" and "BUILD_GPFS=no makerpms.sh"
metze
commit 914fc4f265ef9f538fc5077fe0257565b282bd24
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Sep 17 18:15:03 2012 +0200
packaging/RHEL-CTDB: try harder to set $RPMVER
metze
commit 77f281a6d16cd9e7a787de8d954846a840fb03b0
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Sep 17 18:15:03 2012 +0200
packaging/RHEL-CTDB: fix the build
metze
commit 1a945686a6770a0ac17bded73201368f10c65bc9
Author: Michael Adam <obnox at samba.org>
Date: Mon Sep 17 20:30:27 2012 -0400
source3/script: fix installman.sh after the last build-manpages-nogit change
commit cfdab79729e8507a7504b0224c60454d3bc40ffc
Author: Michael Adam <obnox at samba.org>
Date: Wed Sep 12 15:46:35 2012 +0200
release-scripts: let build-manpages-nogit store generated docs under ./bin/docs
not under ./docs
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit a4e8869f7c93f30dd7014ff83d6d2f2b5afc2d64
Author: Vladimir Marek <Vladimir.Marek at Oracle.COM>
Date: Mon Sep 17 13:50:55 2012 -0700
Fix service control for non-internal services.
Signed-off-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Sep 18 01:42:23 CEST 2012 on sn-devel-104
commit 7542b63188f7e73588c9abb40e36a910c87bc534
Author: Joachim Schmitz <schmitz at hp.com>
Date: Mon Sep 17 05:26:31 2012 -0700
libreplace: Bug 8107, Fix poll replacement to become a msleep replacement
Signed-off-by: Jeremy Allison <jra at samba.org>
commit ffd61e2bbf46ab8660c32b90c547beb8b77fcb9d
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Sep 17 11:57:33 2012 -0700
ldb: bump version to 1.1.13 so the 4.0 release can get the isprint fix
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon Sep 17 23:47:57 CEST 2012 on sn-devel-104
commit 0eae4cd787179b40375e298cfd95df817c67a94f
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Sep 17 11:56:28 2012 -0700
docs: Remove another reference to security=share
commit 8e95dee5cfc4175c7a93f1c55b08db8ab5f822c3
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Sep 17 11:56:08 2012 -0700
docs: Remove references to specific windows versions, instead mention Home/Professional/Server
The flavours of windows seem to last longer than the individual products.
Andrew Bartlett
commit 36bfb1e2282d24d2cc20f812bc59ea1ede0e660c
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Sep 17 11:55:12 2012 -0700
docs: Remove references to mulitple passdb backends
These are long-gone and confusing.
Andrew Bartlett
commit e2219850d604470e484e9f8eb6e573c97d474298
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Sep 17 11:54:25 2012 -0700
docs: Remove references to sysv-style CUPS from TOSHARG-CUPS-printing
This also simplifies the cups config by not duplicating the printcap name parameter
that is already set by default when printing=cups is set.
Andrew Bartlett
commit d4efb94dbb3121ccaf17366585ba7ca325f8d699
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Sep 15 15:55:55 2012 -0700
docs: Remove very outdated TOSHARG-Other-Clients section
commit cbfeba71bcd2223c8e919c7d7d73597b03d12b99
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Sep 15 15:52:47 2012 -0700
docs: Remove very outdated TOSHARG-Portability section
commit 6786efa358b471956b017570938676e2306d29c5
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Sep 15 12:53:37 2012 -0700
docs: Update FastStart: remove security=share, avoid disable spoolss
As I understand it, all printing is via spoolss, so do not disable it!
Andrew Bartlett
commit 6bc861663526e1234899ca5815df7a3c122c2b2e
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Sep 14 23:13:33 2012 -0700
docs: Clarify TOSHARG-Bugs for 2012
commit 27359acf59cc7899e8de164f9311ef3b2b6db85a
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Sep 14 23:08:53 2012 -0700
docs: Remove reference to inetd startup, it is not recommended
commit 64e3f1c637b940e60d3d6988a033f4d391b7dab9
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Sep 14 23:06:59 2012 -0700
docs: Update BDC docs to recognise the AD DC and to exclusivly recommend LDAP
The confusing references to the not-recommended techniques and
outdated steps (like net rpc getsid, replaced by simply having the SID
just be in LDAP) just detract from the clarity of this document.
Andrew Bartlett
commit 4de371818504c522613845a1ae4fa97a69bcf412
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Sep 14 22:30:06 2012 -0700
docs: Remove referenece to old Red Hat Linux habits on winbindd
commit a5084a3077b0fecde0772e99302e0e7353c59da3
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Sep 14 22:29:39 2012 -0700
docs: Remove referenece to autogen.sh and document waf build instead
commit f99574905d66da771b6d37ef580165ca800ba70f
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Sep 14 22:29:05 2012 -0700
docs: Remove out of date links to pserver.samba.org and old tarballs
commit 0d73ce12e751192ef6e3a8acdcf136a5a60c9439
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Sep 14 22:28:19 2012 -0700
docs: Remove references to Subversion, replace with wiki link
commit 2dcc4fec33a35e35dc9cced64e4ed61608f295c6
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Sep 14 12:06:40 2012 -0700
docs: Remove references to old kerberos behaviour
I have not seen any issues using the SRV records with windows, and this certainly
does not apply to current versions. Similarly, the need to change the admin password
does not apply now we require a krb5 lib with arcfour-hmac-md5 support.
Andrew Bartlett
commit 48e547c0734f9f646b7683059552c503c809b8ed
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Sep 14 12:04:00 2012 -0700
docs: Remove confusing reference to smb signing and client use spnego
This section is more confusing than helpful, as client support for both is on by default.
Andrew Bartlett
commit b06dbfbba6bf62fd99067675dd9818d6314fd2d0
Author: Christian Ambach <ambi at samba.org>
Date: Sun Sep 16 21:45:56 2012 -0700
s3:libsmb fix a double free error
t refers to self->thread_state that is freed a few lines below
Autobuild-User(master): Christian Ambach <ambi at samba.org>
Autobuild-Date(master): Mon Sep 17 22:04:13 CEST 2012 on sn-devel-104
commit e7a58bc251bd74c3c7c64ee4f5cb85ec76852a8d
Author: Alexander Bokovoy <ab at samba.org>
Date: Mon Sep 17 19:09:35 2012 +0300
docs-xml: fix build of winbindd- and krb5 locator-related manpages
These manpages depend on docs-xml infrastructure (samba DTDs)
Autobuild-User(master): Alexander Bokovoy <ab at samba.org>
Autobuild-Date(master): Mon Sep 17 19:52:53 CEST 2012 on sn-devel-104
commit 73ed1533105ac3f90813e5a0e7888a095eff4b75
Author: Alexander Bokovoy <ab at samba.org>
Date: Mon Sep 17 13:07:26 2012 +0300
docs-xml: convert smb.conf.5 build to waf
smb.conf(5) is different from other manpages because before it is
built, it gets merged together from a number of smaller files, one
per parameter. So we first create a parameters.all.xml file that
references all these files and then include it into master smb.conf.5.xml
One small issue is how to handle generated files in WAF build
from xi:include perspective as the files are generated in bin/default/docs-xml
rather than in docs-xml. We solve this by further expanding use of XML catalogs
and rewriting virtual path http://www.samba.org/samba/smbdotconf/ to proper
location.
Both docs-xml autoconf and waf builds work correctly now.
Autobuild-User(master): Alexander Bokovoy <ab at samba.org>
Autobuild-Date(master): Mon Sep 17 14:18:31 CEST 2012 on sn-devel-104
commit 57990cbcbbdf83d7b9997ac1fd33528c63c96226
Author: Christian Ambach <ambi at samba.org>
Date: Sun Sep 16 00:15:21 2012 +0200
s3:libsmb fix a potential crash
Signed-off-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Christian Ambach <ambi at samba.org>
Autobuild-Date(master): Sun Sep 16 22:31:38 CEST 2012 on sn-devel-104
commit 7a6182962966e5edb42728c8d0a4d471a69c83d7
Author: Christian Ambach <ambi at samba.org>
Date: Sat Sep 15 22:57:51 2012 +0200
s3:vfs_gpfs: fix build
after recent VFS changes
commit 99b5c75974dd904644054433a3c3ad46a4ffc498
Author: Christian Ambach <ambi at samba.org>
Date: Sat Sep 15 22:47:06 2012 +0200
s3:auth fix a compiler warning
commit c0d4f2462f75e0bc0545402b76984b4e6fcb13f1
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Sun Sep 16 14:18:51 2012 +0200
s4-python: Formatting fixes, break lines.
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Sun Sep 16 15:58:04 CEST 2012 on sn-devel-104
commit 0ff2ea56d97cd8df7abeea8e819d7ec0bfd5b886
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Sun Sep 16 14:18:39 2012 +0200
samba.netcmd: Formatting fixes, break lines.
commit ebcb6a744791478bfc4be0b94733ace540ab06bc
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Sun Sep 16 00:34:14 2012 +0200
samba.provision.common: Fix formatting.
commit cd7dcf4571b321f39eda07c489dd16833d8d4185
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Sun Sep 16 00:34:00 2012 +0200
samba.provision.sambadns: Fix formatting.
commit 858135920d54662a06252deac4dbf9191a251018
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Sun Sep 16 00:33:09 2012 +0200
samba.provision.backend: Fix formatting.
commit fdb873a203695f0b208967a561424c0357374e5b
Author: Jelmer Vernooij <jelmer at samba.org>
Date: Sun Sep 16 00:32:52 2012 +0200
samba.provision: Fix formatting, NameErrors.
commit 520c9b0b0ae33e6e8fb78034cfff685f5491aab3
Author: Björn Jacke <bj at sernet.de>
Date: Sun Sep 16 02:21:39 2012 +0200
replace: add some includes for poll.h
See bug #8107
Autobuild-User(master): Björn Jacke <bj at sernet.de>
Autobuild-Date(master): Sun Sep 16 04:05:08 CEST 2012 on sn-devel-104
commit b53c5bcf5bddb8a673d94870bdcfac426a8159ec
Author: Björn Jacke <bj at sernet.de>
Date: Fri Sep 14 20:46:45 2012 +0200
quota: also log which fs type we found
Autobuild-User(master): Björn Jacke <bj at sernet.de>
Autobuild-Date(master): Sat Sep 15 02:18:16 CEST 2012 on sn-devel-104
commit 29c5780f8d0b7413136140db4ce133e97625ae31
Author: Björn Jacke <bj at sernet.de>
Date: Fri Sep 14 20:32:15 2012 +0200
autoconf: check for dn_expand also in libinet
see bug #7472
commit 39d1a2c2a1d5e69d0396622bc9fea00d0f0d779d
Author: Björn Jacke <bj at sernet.de>
Date: Fri Sep 14 20:41:08 2012 +0200
wafbuild: check for dn_expand also in libinet
see bug #7472
commit 8de46eac65deb33cd91fa242fb89fb59dc3cac42
Author: Jeremy Allison <jra at samba.org>
Date: Thu Sep 13 17:12:24 2012 -0700
Add 'bool use_privs' to smbd_calculate_access_mask().
Replaces blanket root allow if set. Set to 'false' for
all current callers.
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sat Sep 15 00:37:49 CEST 2012 on sn-devel-104
commit 6d82976597d6418005a889781cc23adf6b3090c3
Author: Jeremy Allison <jra at samba.org>
Date: Thu Sep 13 17:08:43 2012 -0700
Fix bad string in debug message (remove it).
commit aa0a7cf51a8b4ed2f188c2c38c4d5d47688de9ad
Author: Jeremy Allison <jra at samba.org>
Date: Thu Sep 13 16:11:31 2012 -0700
Add bool use_privs parameter to smbd_check_access_rights()
If this is set we should use it in preference to blindly assuming
root can do anything. Currently set to 'false' in (most) callers.
commit 1e34d584393c09a43bf0226bebc0ae0f675e57ae
Author: Jeremy Allison <jra at samba.org>
Date: Thu Sep 13 15:35:21 2012 -0700
Add "backup_intent" bool.
commit b66bcab58ce73f86424b9a6ffbf9d3634e42f8ae
Author: Jeremy Allison <jra at samba.org>
Date: Thu Sep 13 14:36:57 2012 -0700
Don't call can_write_to_file() if we already have 'fsp->can_write' set.
commit 35a4a1ed1f0fc6f1cbccd31bb7db9431b2518a5b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Sep 14 11:58:02 2012 -0700
build: Fix build on systems without ldap development headers
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Fri Sep 14 22:53:30 CEST 2012 on sn-devel-104
commit 7ef7ec7be88f365ebd0c9da425283375188be2d1
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Sep 14 11:57:38 2012 -0700
docs: update for modern kerberos libs
commit f84893a54b27828946ca75e72542116a560315d6
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Sep 14 11:57:05 2012 -0700
docs: remove references to security=server
commit 963664eccce0e7e221ab2c465a430b4d8e2e081b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Sep 14 09:29:51 2012 -0700
docs: Remove distinction between server and domain accounts
Accounts on a server become accounts on the DC when upgraded. If they do not
then this is simply a bug (in say tdbsam), not a feature to be documented.
Andrew Bartlett
commit c5151b62679edd11940023e757378c7aac66933a
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Sep 14 09:28:06 2012 -0700
docs: Update docs to the modern age of Samba 4.0
This removes references to security=share, security=server and other outdated things.
It also updates to a world where encrypted passwords are the norm.
Andrew Bartlett
commit 58e62ae7761d3066a85176ee0b860abfb7904c74
Author: Michael Adam <obnox at samba.org>
Date: Thu Sep 13 14:06:40 2012 +0200
s4:torture: fix error reporting in the raw.oplock-brl3 test
Error was assigned to a variable that was not returned.
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Fri Sep 14 14:05:20 CEST 2012 on sn-devel-104
commit 1aa281ecb0f45c97d78161fd1308be8655295f1f
Author: Björn Jacke <bj at sernet.de>
Date: Fri Sep 14 10:01:33 2012 +0200
s3: fix the hpux acl module
This was not adopted to the recent VFS acl structure changes.
Autobuild-User(master): Björn Jacke <bj at sernet.de>
Autobuild-Date(master): Fri Sep 14 12:23:23 CEST 2012 on sn-devel-104
commit 9222f0f9280485c2751ecfdb96421da25e6e5344
Author: Björn Jacke <bj at sernet.de>
Date: Fri Sep 14 09:40:07 2012 +0200
s3: fix the tru64 acl module
This was not adopted to the recent VFS acl structure changes.
commit 35632eec8e3b0dcfecffde814a790cc4f444dd97
Author: Björn Jacke <bj at sernet.de>
Date: Fri Sep 14 09:35:53 2012 +0200
s3: fix the aix acl module
This was not adopted to the recent VFS acl structure changes.
commit 4a8cbe245726b17b6fcd8615b7c30963dd863422
Author: Karolin Seeger <kseeger at samba.org>
Date: Fri Sep 14 08:57:25 2012 +0200
WHATSNEW: Fix some issues in the release notes.
Karolin
Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
Autobuild-Date(master): Fri Sep 14 10:40:02 CEST 2012 on sn-devel-104
commit 5e51f63e86ab0855daf9e822d48a12134bfb6f26
Author: Ira Cooper <ira at samba.org>
Date: Fri Sep 14 01:32:45 2012 +0000
s3: Fix the vfs_solarisacl module to compile.
This got broken with the recent VFS acl structure changes.
Autobuild-User(master): Ira Cooper <ira at samba.org>
Autobuild-Date(master): Fri Sep 14 05:21:29 CEST 2012 on sn-devel-104
commit 88a5bff88917d7e3013ced7e85d56a8ecdfeece4
Author: Björn Jacke <bj at sernet.de>
Date: Fri Sep 14 00:25:38 2012 +0200
packaging: apply some solaris packaging fixes
Actually this might be outdated already. See bug #5670.
Thanks to Michal Ludvig.
Autobuild-User(master): Björn Jacke <bj at sernet.de>
Autobuild-Date(master): Fri Sep 14 02:42:53 CEST 2012 on sn-devel-104
commit 70bc93650f86a76c6f1617139cb71539c76abf42
Author: Björn Jacke <bj at sernet.de>
Date: Fri Sep 14 00:02:22 2012 +0200
autoconf: fix --with(out)-sendfile-support option handling
this fixes bug #8344
commit 86a4ca28649141f77556208b833db2e076c0125d
Author: Alexander Bokovoy <ab at samba.org>
Date: Thu Sep 13 20:29:25 2012 +0300
s3: make smbldaphelper subsystem an internal library
Break pdb_ldap -> smbldaphelper -> pdb -> pdb_ldap loop by
making smbldaphelp intentionally underlinked internal library.
It means that libsmbldaphelp is not usable unless its user is
also linked to libpdb (that is the case for both its users,
idmap_ldap and pdb_ldap, already) but gives us a break of
the circular dependency in case pdb_ldap statically linked
into pdb (default).
This should solve case when idmap_ldap and pdb_ldap are dynamically
loaded modules
Autobuild-User(master): Alexander Bokovoy <ab at samba.org>
Autobuild-Date(master): Fri Sep 14 01:02:21 CEST 2012 on sn-devel-104
commit 56b752512597acaffa94a979ef9140760e0f5cf3
Author: Jeremy Allison <jra at samba.org>
Date: Thu Sep 13 10:13:21 2012 -0700
Sigh :-(. Removing optimization prematurely is the root of all evil :-(.
Sorry for the mistake, but the LastDir singleton cache in vfs_ChDir()
actually plays an important role. When we're processing a stream of
SMB1/SMB2/SMB3 requests we don't want to add a chdir()/getcwd()
system call pair on every request if they're all on the same connection
and dealing with the same base path.
I did some testing with a program that times 1,000,000 chdir()
requests vs. 1,000,000 strcmp requests and it's a penalty of 10x
doing the system calls.
Just because it's old code, doesn't mean it's bad :-(.
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Sep 13 21:31:42 CEST 2012 on sn-devel-104
commit 23158d72c8de9318e1f136331ef4d788df243af7
Author: Andreas Schneider <asn at samba.org>
Date: Thu Sep 13 17:52:13 2012 +0200
docs: Fix generating idmap manpages.
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Thu Sep 13 19:52:53 CEST 2012 on sn-devel-104
commit be7a856f5bd251dc84a72eb56cf011facd10988f
Author: Alexander Bokovoy <ab at samba.org>
Date: Thu Sep 13 15:40:31 2012 +0300
s3: make ldapsam-related functions a smbldaphelper subsystem
Since these functions are used in pdb_ldap and idmap_ldap, and
pdb_ldap might be statically linked to libpdb (default), it is
better to keep them as separate subsystem to avoid polluting libpdb
namespace.
This is first step in refactoring libpdb. Right now I cannot move
these functions into proper libsmbldaphelper as it uses more of
libpdb-included functions and linking pdb_ldap against libsmbldaphelper
library would have created a loop if pdb_ldap is included into libpdb.
Autobuild-User(master): Alexander Bokovoy <ab at samba.org>
Autobuild-Date(master): Thu Sep 13 17:36:07 CEST 2012 on sn-devel-104
commit 915842333e641190035c2911940f08870abd221f
Author: Michael Adam <obnox at samba.org>
Date: Wed Sep 12 15:34:29 2012 +0200
VERSION: Bump version up to 4.1.0pre1
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Thu Sep 13 01:35:33 CEST 2012 on sn-devel-104
-----------------------------------------------------------------------
--
Samba Shared Repository
More information about the samba-cvs
mailing list