[SCM] Samba Shared Repository - branch master updated

[Jeremy Allison]

The branch, master has been updated
       via  fe06e1b smbd: Fix CID 1035536 Uninitialized pointer read
       via  d7da8da smbd: Fix CID 1035537 Uninitialized pointer read
       via  a1e0acc smbd: Fix CID 1035538 Uninitialized pointer read
       via  a6a0d23 tdb: Fix CID 1034959 Uninitialized scalar variable
       via  f25449b tdb: Fix CID 1034960 Uninitialized scalar variable
      from  b505111 s3-waf: Rename regedit to samba-regedit.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit fe06e1b0a3c06ffa859fa0d5e52ed4cc59de0950
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Jun 22 13:06:34 2013 +0200

    smbd: Fix CID 1035536 Uninitialized pointer read
    
    rpc_pipe_open_interface just returns okay if the pipe in question is
    already open. For this, it needs to read the value.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Jul 23 02:05:19 CEST 2013 on sn-devel-104

commit d7da8dabaa94af6662741c8ce8efdf87c34c03d2
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Jun 22 13:06:34 2013 +0200

    smbd: Fix CID 1035537 Uninitialized pointer read
    
    rpc_pipe_open_interface just returns okay if the pipe in question is
    already open. For this, it needs to read the value.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a1e0accc5f4f33ce296bad79a088499cf082d9b5
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Jun 22 13:06:34 2013 +0200

    smbd: Fix CID 1035538 Uninitialized pointer read
    
    rpc_pipe_open_interface just returns okay if the pipe in question is
    already open. For this, it needs to read the value.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a6a0d238b368fd15ceb0237c2f9ff13c58b18fad
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Jun 22 12:13:26 2013 +0200

    tdb: Fix CID 1034959 Uninitialized scalar variable
    
    log_ctx.log_private was used uninitialized. Not a real bug here,
    as tdb_log does not access it, but tdb_open_ex still moves around
    uninitialized data. So this would show up in valgrind as well.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f25449b00a81bdb4010aed36d7c713513b70bcce
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Jun 22 12:13:26 2013 +0200

    tdb: Fix CID 1034960 Uninitialized scalar variable
    
    log_ctx.log_private was used uninitialized. Not a real bug here,
    as tdb_log does not access it, but tdb_open_ex still moves around
    uninitialized data. So this would show up in valgrind as well.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

-----------------------------------------------------------------------

Summary of changes:
 lib/tdb/tools/tdbtool.c |    4 ++--
 source3/smbd/lanman.c   |    6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)


Changeset truncated at 500 lines:

diff --git a/lib/tdb/tools/tdbtool.c b/lib/tdb/tools/tdbtool.c
index d007796..01b9a14 100644
--- a/lib/tdb/tools/tdbtool.c
+++ b/lib/tdb/tools/tdbtool.c
@@ -222,7 +222,7 @@ static void terror(const char *why)
 
 static void create_tdb(const char *tdbname)
 {
-	struct tdb_logging_context log_ctx;
+	struct tdb_logging_context log_ctx = { NULL, NULL};
 	log_ctx.log_fn = tdb_log;
 
 	if (tdb) tdb_close(tdb);
@@ -235,7 +235,7 @@ static void create_tdb(const char *tdbname)
 
 static void open_tdb(const char *tdbname)
 {
-	struct tdb_logging_context log_ctx;
+	struct tdb_logging_context log_ctx = { NULL, NULL };
 	log_ctx.log_fn = tdb_log;
 
 	if (tdb) tdb_close(tdb);
diff --git a/source3/smbd/lanman.c b/source3/smbd/lanman.c
index b5598a4..9278a3f 100644
--- a/source3/smbd/lanman.c
+++ b/source3/smbd/lanman.c
@@ -2341,7 +2341,7 @@ static bool api_RNetGroupEnum(struct smbd_server_connection *sconn,
 
 	uint32_t num_groups;
 	uint32_t resume_handle;
-	struct rpc_pipe_client *samr_pipe;
+	struct rpc_pipe_client *samr_pipe = NULL;
 	struct policy_handle samr_handle, domain_handle;
 	NTSTATUS status, result;
 	struct dcerpc_binding_handle *b;
@@ -2525,7 +2525,7 @@ static bool api_NetUserGetGroups(struct smbd_server_connection *sconn,
 	uint32_t i;
 	char *endp = NULL;
 
-	struct rpc_pipe_client *samr_pipe;
+	struct rpc_pipe_client *samr_pipe = NULL;
 	struct policy_handle samr_handle, domain_handle, user_handle;
 	struct lsa_String name;
 	struct lsa_Strings names;
@@ -2715,7 +2715,7 @@ static bool api_RNetUserEnum(struct smbd_server_connection *sconn,
 	int i, resume_context, cli_buf_size;
 	uint32_t resume_handle;
 
-	struct rpc_pipe_client *samr_pipe;
+	struct rpc_pipe_client *samr_pipe = NULL;
 	struct policy_handle samr_handle, domain_handle;
 	NTSTATUS status, result;
 


-- 
Samba Shared Repository