[SCM] Samba Shared Repository - branch master updated

David Disseldorp ddiss at samba.org
Mon Jan 21 05:31:02 MST 2013


The branch, master has been updated
       via  c38fb0b BUG 9574: Fix a possible null pointer dereference in spoolss.
      from  f70d0ac Tests: remove redondent testsuites in provision

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit c38fb0b106b62e42a5b75b1c78386bb8912c7d7e
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Jan 18 18:04:17 2013 +0100

    BUG 9574: Fix a possible null pointer dereference in spoolss.
    
    If the the client enumerates the printers and didn't specify a
    servername we have a null pointer dereference, so the process serving
    the connection crashes.
    
    Reviewed-by: David Disseldorp <ddiss at samba.org>
    
    Autobuild-User(master): David Disseldorp <ddiss at samba.org>
    Autobuild-Date(master): Mon Jan 21 13:30:11 CET 2013 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/rpc_server/spoolss/srv_spoolss_nt.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c b/source3/rpc_server/spoolss/srv_spoolss_nt.c
index ef854b1..9df0b8a 100644
--- a/source3/rpc_server/spoolss/srv_spoolss_nt.c
+++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c
@@ -4466,7 +4466,8 @@ static WERROR enum_all_printers_info_1_network(TALLOC_CTX *mem_ctx,
 	   listed. Windows responds to this call with a
 	   WERR_CAN_NOT_COMPLETE so we should do the same. */
 
-	if (servername[0] == '\\' && servername[1] == '\\') {
+	if (servername != NULL &&
+	    (servername[0] == '\\') && (servername[1] == '\\')) {
 		 s = servername + 2;
 	}
 


-- 
Samba Shared Repository


More information about the samba-cvs mailing list