[SCM] Samba Shared Repository - branch master updated

Christian Ambach ambi at samba.org
Wed Feb 20 11:01:02 MST 2013


The branch, master has been updated
       via  3d29bb2 s3:rpc_client fix a crash
      from  2f4b21b ntdb: switch between secrets.tdb and secrets.ntdb depending on 'use ntdb'

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 3d29bb2d37b02909ecb500e864f3c13e06957a86
Author: Christian Ambach <ambi at samba.org>
Date:   Wed Feb 20 16:59:05 2013 +0100

    s3:rpc_client fix a crash
    
    state->cli->dc does not have to be set (e.g. when running
    net rpc join against an older Samba PDC), so check it before dereferencing it
    
    This fixes Bug 9669 - net rpc join crashes against a Samba 3.0.33 PDC
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=9669
    
    Signed-off-by: Christian Ambach <ambi at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Christian Ambach <ambi at samba.org>
    Autobuild-Date(master): Wed Feb 20 19:00:52 CET 2013 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/rpc_client/cli_pipe.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/rpc_client/cli_pipe.c b/source3/rpc_client/cli_pipe.c
index 2743a07..2e978ef 100644
--- a/source3/rpc_client/cli_pipe.c
+++ b/source3/rpc_client/cli_pipe.c
@@ -1805,7 +1805,7 @@ static void rpc_pipe_bind_step_two_done(struct tevent_req *subreq)
 	status = dcerpc_netr_LogonGetCapabilities_r_recv(subreq, talloc_tos());
 	TALLOC_FREE(subreq);
 	if (NT_STATUS_EQUAL(status, NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE)) {
-		if (state->cli->dc->negotiate_flags &
+		if (state->cli->dc && state->cli->dc->negotiate_flags &
 		    NETLOGON_NEG_SUPPORTS_AES) {
 			DEBUG(5, ("AES is not supported and the error was %s\n",
 				  nt_errstr(status)));


-- 
Samba Shared Repository


More information about the samba-cvs mailing list