[SCM] Samba Shared Repository - branch master updated

David Disseldorp ddiss at samba.org
Mon Feb 4 07:58:01 MST 2013

The branch, master has been updated
       via  c5d991e Revert "selftest: skip smb2.ioctl tests on ntvfs"
      from  4c1527b s3:modules remove gpfs_getacl_alloc


- Log -----------------------------------------------------------------
commit c5d991e5102069ec712fe609c031a10ee8b0f389
Author: David Disseldorp <ddiss at samba.org>
Date:   Sun Feb 3 17:06:37 2013 +0100

    Revert "selftest: skip smb2.ioctl tests on ntvfs"
    This reverts commit cf27c2fbb6e7422cb962f4c63a53515321c65a70.
    The following concerns were raised with regard to the relocation of
    tests from selftest/knownfail to selftest/skip.
    Andrew Bartlett <abartlet at samba.org> wrote:
    Unless there is some entirely undesirable side-effect, this patch throws
    away valuable testing, because it removes the test of the testsuite for
    failure (ie, does the test work!), and it removes the documentation of
    the difference between the servers (if someone did add some this to the
    ntvfs server, it would never be tested).
    It also removes a test that if this unimplemented functionality is
    called, that we don't crash and die.
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Autobuild-User(master): David Disseldorp <ddiss at samba.org>
    Autobuild-Date(master): Mon Feb  4 15:57:29 CET 2013 on sn-devel-104


Summary of changes:
 selftest/knownfail |    2 ++
 selftest/skip      |    1 -
 2 files changed, 2 insertions(+), 1 deletions(-)

Changeset truncated at 500 lines:

diff --git a/selftest/knownfail b/selftest/knownfail
index dcd94ec..39485af 100644
--- a/selftest/knownfail
+++ b/selftest/knownfail
@@ -172,6 +172,8 @@
+^samba4.smb2.ioctl.req_resume_key\(dc\) # not supported by s4 ntvfs server
+^samba4.smb2.ioctl.copy_chunk_\w*\(dc\)	# not supported by s4 ntvfs server
diff --git a/selftest/skip b/selftest/skip
index d54a5b0..5c49306 100644
--- a/selftest/skip
+++ b/selftest/skip
@@ -61,7 +61,6 @@
-^samba4.smb2.ioctl	# not supported by ntvfs

Samba Shared Repository

More information about the samba-cvs mailing list