[SCM] Samba Shared Repository - branch master updated

Andreas Schneider asn at samba.org
Mon Dec 16 09:12:03 MST 2013


The branch, master has been updated
       via  04297e8 gencache: Fix a type-punned warning
      from  ef5a3be s3: smbpasswd - fix crashes on invalid input.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 04297e8914548fc5cadb912901305c75ee662154
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Dec 16 12:42:46 2013 +0100

    gencache: Fix a type-punned warning
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Mon Dec 16 17:11:13 CET 2013 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/lib/gencache.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/lib/gencache.c b/source3/lib/gencache.c
index 835f5e1..168b511 100644
--- a/source3/lib/gencache.c
+++ b/source3/lib/gencache.c
@@ -723,7 +723,11 @@ bool gencache_get(const char *keystr, TALLOC_CTX *mem_ctx, char **value,
 		return false;
 	}
 	if (value) {
-		*value = talloc_move(mem_ctx, (char **)&blob.data);
+		/*
+		 * talloc_move generates a type-punned warning here. As we
+		 * leave the function immediately, do a simple talloc_steal.
+		 */
+		*value = (char *)talloc_steal(mem_ctx, blob.data);
 		return true;
 	}
 	data_blob_free(&blob);


-- 
Samba Shared Repository


More information about the samba-cvs mailing list