[SCM] Samba Shared Repository - branch master updated

Andrew Bartlett abartlet at samba.org
Thu Aug 29 18:44:03 MDT 2013


The branch, master has been updated
       via  ba04400 vfs_glusterfs: Fix excessive debug output from vfs_gluster_open().
      from  91910fe s3:winbind: fail ads_cached_connection_connect() if realm == NULL

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit ba04400d01c6ad05651672e087527391da7fdaf4
Author: Christopher R. Hertel <crh at redhat.com>
Date:   Thu Aug 29 16:58:16 2013 -0500

    vfs_glusterfs: Fix excessive debug output from vfs_gluster_open().
    
    The vfs_gluster_open() function generates a debug message (at level 0)
    for every failed attempt to open a pathname.  This includes cases in
    which attempts are made to open a directory as a file (those attempts
    are retried calling vfs_gluster_opendir()).  The result is that the log
    file fills with messages about failed attempts to open directories, just
    because they are directories.
    
    This latest version, of the patch completely removes logging from the
    vfs_gluster_open() function.  The error code returned is handled in
    upper layers, and the open function in the default VFS module does not
    log any errors.
    
    Signed-off-by: Christopher R. Hertel <crh at redhat.com>
    Reviewed-by: susant palai <spalai at redhat.com>
    Reviewed-by: raghavendra talur <rtalur at redhat.com>
    Reviewed-by: Jose A. Rivera <jarrpa at redhat.com>
    
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Fri Aug 30 02:43:48 CEST 2013 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/modules/vfs_glusterfs.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/modules/vfs_glusterfs.c b/source3/modules/vfs_glusterfs.c
index eac1b24..237236a 100644
--- a/source3/modules/vfs_glusterfs.c
+++ b/source3/modules/vfs_glusterfs.c
@@ -481,11 +481,8 @@ static int vfs_gluster_open(struct vfs_handle_struct *handle,
 	}
 
 	if (glfd == NULL) {
-		DEBUG(0, ("glfs_{open[dir],creat}(%s) failed: %s\n",
-			  smb_fname->base_name, strerror(errno)));
 		return -1;
 	}
-
 	return glfd_fd_store(glfd);
 }
 


-- 
Samba Shared Repository


More information about the samba-cvs mailing list