[SCM] Samba Shared Repository - branch v3-6-stable updated

Karolin Seeger kseeger at samba.org
Mon Aug 5 02:38:05 MDT 2013


The branch, v3-6-stable has been updated
       via  e03ad14 WHATSNEW: Add release notes for Samba 3.6.17.
       via  efdbcab Fix bug #10010 - Missing integer wrap protection in EA list reading can cause server to loop with DOS.
      from  b45411c WHATSNEW: Start release notes for Samba 3.6.17.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-stable


- Log -----------------------------------------------------------------
commit e03ad1401fd1cca54f9f5c4c1e98ec9ad87b5565
Author: Karolin Seeger <kseeger at samba.org>
Date:   Mon Jul 29 20:55:18 2013 +0200

    WHATSNEW: Add release notes for Samba 3.6.17.
    
    Signed-off-by: Karolin Seeger <kseeger at samba.org>

commit efdbcabbe97a594572d71d714d258a5854c5d8ce
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 10 17:10:17 2013 -0700

    Fix bug #10010 - Missing integer wrap protection in EA list reading can cause server to loop with DOS.
    
    Ensure we never wrap whilst adding client provided input.
    CVE-2013-4124
    
    Signed-off-by: Jeremy Allison <jra at samba.org>

-----------------------------------------------------------------------

Summary of changes:
 WHATSNEW.txt           |   23 +++++++++++++++++++----
 source3/smbd/nttrans.c |   12 ++++++++++++
 2 files changed, 31 insertions(+), 4 deletions(-)


Changeset truncated at 500 lines:

diff --git a/WHATSNEW.txt b/WHATSNEW.txt
index a921e4a..4291736 100644
--- a/WHATSNEW.txt
+++ b/WHATSNEW.txt
@@ -1,19 +1,34 @@
                    ==============================
                    Release Notes for Samba 3.6.17
-                          August 14, 2013
+                          August 05, 2013
                    ==============================
 
 
-This is is the latest stable release of Samba 3.6.
+This is a security release in order to address
+CVE-2013-4124 (Missing integer wrap protection in EA list reading can cause
+server to loop with DOS).
+
+o  CVE-2013-4124:
+   All current released versions of Samba are vulnerable to a denial of
+   service on an authenticated or guest connection. A malformed packet
+   can cause the smbd server to loop the CPU performing memory
+   allocations and preventing any further service.
+
+   A connection to a file share, or a local account is needed to exploit
+   this problem, either authenticated or unauthenticated if guest
+   connections are allowed.
 
-Major enhancements in Samba 3.6.17 include:
+   This flaw is not exploitable beyond causing the code to loop
+   allocating memory, which may cause the machine to exceed memory
+   limits.
 
-o  
 
 Changes since 3.6.16:
 ---------------------
 
 o   Jeremy Allison <jra at samba.org>
+    * BUG 10010: CVE-2013-4124: Missing integer wrap protection in EA list
+      reading can cause server to loop with DOS.
 
 
 ######################################################################
diff --git a/source3/smbd/nttrans.c b/source3/smbd/nttrans.c
index ea9d417..5fc3a09 100644
--- a/source3/smbd/nttrans.c
+++ b/source3/smbd/nttrans.c
@@ -989,7 +989,19 @@ struct ea_list *read_nttrans_ea_list(TALLOC_CTX *ctx, const char *pdata, size_t
 		if (next_offset == 0) {
 			break;
 		}
+
+		/* Integer wrap protection for the increment. */
+		if (offset + next_offset < offset) {
+			break;
+		}
+
 		offset += next_offset;
+
+		/* Integer wrap protection for while loop. */
+		if (offset + 4 < offset) {
+			break;
+		}
+
 	}
 
 	return ea_list_head;


-- 
Samba Shared Repository


More information about the samba-cvs mailing list