[SCM] Samba Shared Repository - branch master updated
Richard Sharpe
sharpe at samba.org
Sat Aug 3 09:42:01 MDT 2013
The branch, master has been updated
via 852c9ac There are tests all over the SMB1 code to check that srv_send_smb fails, but it never returns false.
from 859182d dfs_server: Use dsdb_search_one to catch 0 results as well as NO_SUCH_OBJECT errors
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 852c9ac34dbef66d0b2619554c611157c2fab771
Author: Richard Sharpe <realrichardsharpe at gmail.com>
Date: Mon Jul 22 16:04:43 2013 -0700
There are tests all over the SMB1 code to check that srv_send_smb fails, but it never returns false.
Even if the write to the socket/fd fails, we never return false and
will keep reading stuff off of the input buffer until it is exhausted
and then we will exit.
Signed-off-by: Richard Sharpe <rsharpe at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Richard Sharpe <sharpe at samba.org>
Autobuild-Date(master): Sat Aug 3 17:41:22 CEST 2013 on sn-devel-104
-----------------------------------------------------------------------
Summary of changes:
source3/smbd/process.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/smbd/process.c b/source3/smbd/process.c
index 5ef0fd3..3fbfc37 100644
--- a/source3/smbd/process.c
+++ b/source3/smbd/process.c
@@ -194,7 +194,7 @@ out:
SMB_PERFCOUNT_END(pcd);
smbd_unlock_socket(sconn);
- return true;
+ return (ret > 0);
}
/*******************************************************************
--
Samba Shared Repository
More information about the samba-cvs
mailing list