[SCM] Samba Shared Repository - branch master updated

Stefan Metzmacher metze at samba.org
Wed Apr 3 10:40:01 MDT 2013


The branch, master has been updated
       via  b5d5b9a libsmbclient: Fix cli_session_setup_guest_send
      from  ed76e65 ntvfs: support setfileinfo with FULL_EA_INFORMATION

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit b5d5b9a40eb13f89a552e29096deed52229c147e
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Apr 3 13:24:53 2013 +0200

    libsmbclient: Fix cli_session_setup_guest_send
    
    This worked fine so far, but for the wrong reason: We only ever called
    this through the sync wrapper. The tevent_req_nterror in the NT_STATUS_OK
    case does not call tevent_req_finish. So the tevent_loop_poll did call
    into the core send/receive smb code. This is a fix for the case when
    smb1cli_req_chain_submit fails for some reason.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
    Autobuild-Date(master): Wed Apr  3 18:39:30 CEST 2013 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/libsmb/cliconnect.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/libsmb/cliconnect.c b/source3/libsmb/cliconnect.c
index 872900c..ec5c273 100644
--- a/source3/libsmb/cliconnect.c
+++ b/source3/libsmb/cliconnect.c
@@ -446,7 +446,7 @@ struct tevent_req *cli_session_setup_guest_send(TALLOC_CTX *mem_ctx,
 	}
 
 	status = smb1cli_req_chain_submit(&subreq, 1);
-	if (NT_STATUS_IS_OK(status)) {
+	if (!NT_STATUS_IS_OK(status)) {
 		tevent_req_nterror(req, status);
 		return tevent_req_post(req, ev);
 	}


-- 
Samba Shared Repository


More information about the samba-cvs mailing list