[SCM] Samba Shared Repository - branch v3-5-test updated

Karolin Seeger kseeger at samba.org
Mon Sep 17 03:37:39 MDT 2012

The branch, v3-5-test has been updated
       via  25bf057 nsswitch: fix crash on null pam change pw response
      from  9258a7b Fix bug #9147 - winbind can't fetch user or group info from AD via LDAP


- Log -----------------------------------------------------------------
commit 25bf057288d5e77c07a5ed3d3c3fb7f5f33f62b6
Author: Luca Lorenzetto <lorenzetto-luca at ubuntu-it.org>
Date:   Tue Sep 11 18:35:42 2012 +0200

    nsswitch: fix crash on null pam change pw response
    The function _pam_winbind_change_pwd crashes due to a null value passed
    to the function strcasecmp and denies to login via graphical login
    manager. Check for a null value before doing a strcasecmp.
    Bug-Ubuntu: https://bugs.launchpad.net/bugs/1003296
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=9013
    (Desktop Managers (xdm, gdm, lightdm...) crashes with SIGSEGV in
    _pam_winbind_change_pwd() when password is expiring)
    (cherry picked from commit 47f2211f137688a7c46c4a38571a9f94e59dbf6a)


Summary of changes:
 nsswitch/pam_winbind.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Changeset truncated at 500 lines:

diff --git a/nsswitch/pam_winbind.c b/nsswitch/pam_winbind.c
index 81055c9..fdaf807 100644
--- a/nsswitch/pam_winbind.c
+++ b/nsswitch/pam_winbind.c
@@ -831,7 +831,7 @@ static bool _pam_winbind_change_pwd(struct pwb_context *ctx)
 	_pam_log(ctx, LOG_CRIT, "Received [%s] reply from application.\n", resp->resp);
-	if (strcasecmp(resp->resp, "yes") == 0) {
+	if ((resp->resp != NULL) && (strcasecmp(resp->resp, "yes") == 0)) {
 		retval = true;

Samba Shared Repository

More information about the samba-cvs mailing list