[SCM] Samba Shared Repository - branch master updated

[David Disseldorp]

The branch, master has been updated
       via  4e595f4 nsswitch: fix crash on null pam change pw response
      from  df5f962 s4:torture:smb2: fix error reporting in the oplock-brl3 test

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 4e595f4bf08489cb69e871093804b9069d63d9f5
Author: Luca Lorenzetto <lorenzetto-luca at ubuntu-it.org>
Date:   Tue Sep 11 18:35:42 2012 +0200

    nsswitch: fix crash on null pam change pw response
    
    The function _pam_winbind_change_pwd crashes due to a null value passed
    to the function strcasecmp and denies to login via graphical login
    manager. Check for a null value before doing a strcasecmp.
    
    Bug-Ubuntu: https://bugs.launchpad.net/bugs/1003296
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=9013
    
    Autobuild-User(master): David Disseldorp <ddiss at samba.org>
    Autobuild-Date(master): Wed Sep 12 00:07:28 CEST 2012 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 nsswitch/pam_winbind.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/nsswitch/pam_winbind.c b/nsswitch/pam_winbind.c
index e3e9af1..fb84985 100644
--- a/nsswitch/pam_winbind.c
+++ b/nsswitch/pam_winbind.c
@@ -831,7 +831,7 @@ static bool _pam_winbind_change_pwd(struct pwb_context *ctx)
 	}
 	_pam_log(ctx, LOG_CRIT, "Received [%s] reply from application.\n", resp->resp);
 
-	if (strcasecmp(resp->resp, "yes") == 0) {
+	if ((resp->resp != NULL) && (strcasecmp(resp->resp, "yes") == 0)) {
 		retval = true;
 	}
 


-- 
Samba Shared Repository