[SCM] Samba Shared Repository - branch v3-6-test updated

Karolin Seeger kseeger at samba.org
Mon Sep 10 02:53:35 MDT 2012


The branch, v3-6-test has been updated
       via  9acfa61 s3:client use more access bits for snapshot display
       via  1f8d686 s3:libsmb correctly set isFsctl for snapshot list
      from  7ec71c2 s3-winbind: DON'T PANIC if we couldn't find the domain.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test


- Log -----------------------------------------------------------------
commit 9acfa6126229cc61ba5f45908f97c68f353f8f85
Author: Christian Ambach <ambi at samba.org>
Date:   Wed Sep 5 15:07:54 2012 +0200

    s3:client use more access bits for snapshot display
    
    otherwise Windows server will reject the request for shadow copy enumeration
    with access denied
    
    The last 2 patches address bug #9137 - smbclient allinfo does not show snapshot
    list.

commit 1f8d68699ffcee1513ae68f8c6ef947a05742bc6
Author: Christian Ambach <ambi at samba.org>
Date:   Thu Aug 30 16:43:33 2012 +0200

    s3:libsmb correctly set isFsctl for snapshot list
    
    FSCTL_GET_SHADOW_COPY_DATA is a FSCTL, so set the isFsctl marker
    otherwise smbclient allinfo will not report snapshots any more with the changes
    made for Bug #8311
    
    Autobuild-User(master): Christian Ambach <ambi at samba.org>
    Autobuild-Date(master): Thu Aug 30 18:57:24 CEST 2012 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/client/client.c  |    3 ++-
 source3/libsmb/clifile.c |    2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/client/client.c b/source3/client/client.c
index 05c4f91..58115ad 100644
--- a/source3/client/client.c
+++ b/source3/client/client.c
@@ -1717,7 +1717,8 @@ static int do_allinfo(const char *name)
 	}
 
 	status = cli_ntcreate(cli, name, 0,
-			      CREATE_ACCESS_READ, 0,
+			      SEC_FILE_READ_DATA | SEC_FILE_READ_ATTRIBUTE |
+			      SEC_STD_SYNCHRONIZE, 0,
 			      FILE_SHARE_READ|FILE_SHARE_WRITE
 			      |FILE_SHARE_DELETE,
 			      FILE_OPEN, 0x0, 0x0, &fnum);
diff --git a/source3/libsmb/clifile.c b/source3/libsmb/clifile.c
index 64e4984..6763d69 100644
--- a/source3/libsmb/clifile.c
+++ b/source3/libsmb/clifile.c
@@ -5256,7 +5256,7 @@ struct tevent_req *cli_shadow_copy_data_send(TALLOC_CTX *mem_ctx,
 
 	SIVAL(state->setup + 0, 0, FSCTL_GET_SHADOW_COPY_DATA);
 	SSVAL(state->setup + 2, 0, fnum);
-	SCVAL(state->setup + 3, 0, 0); /* isFsctl */
+	SCVAL(state->setup + 3, 0, 1); /* isFsctl */
 	SCVAL(state->setup + 3, 1, 0); /* compfilter, isFlags (WSSP) */
 
 	subreq = cli_trans_send(


-- 
Samba Shared Repository


More information about the samba-cvs mailing list