[SCM] Samba Shared Repository - branch master updated

Jeremy Allison jra at samba.org
Mon May 21 14:11:03 MDT 2012


The branch, master has been updated
       via  8576256 s3: Fix vfs_xattr_tdb.c
      from  ce11eb5 s3:smb2_ioctl: Fix Coverity ID 701771 Uninitialized scalar variable

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 857625673833ddfa3897ce30def118cb593865b6
Author: Volker Lendecke <vl at samba.org>
Date:   Mon May 21 14:41:40 2012 +0200

    s3: Fix vfs_xattr_tdb.c
    
    "size" is the maximum buffer, only copy what we actually got. For me, this
    fixes valgrind errors in the DIR1 test that might potentially make DIR1
    non-flaky again.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User: Jeremy Allison <jra at samba.org>
    Autobuild-Date: Mon May 21 22:10:15 CEST 2012 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/modules/vfs_xattr_tdb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/modules/vfs_xattr_tdb.c b/source3/modules/vfs_xattr_tdb.c
index ee3199d..fc5c3de 100644
--- a/source3/modules/vfs_xattr_tdb.c
+++ b/source3/modules/vfs_xattr_tdb.c
@@ -57,7 +57,7 @@ static ssize_t xattr_tdb_getxattr(struct vfs_handle_struct *handle,
 		errno = ERANGE;
 		return -1;
 	}
-	memcpy(value, blob.data, size);
+	memcpy(value, blob.data, xattr_size);
 	return xattr_size;
 }
 


-- 
Samba Shared Repository


More information about the samba-cvs mailing list