[SCM] Samba Shared Repository - branch v3-6-test updated

Karolin Seeger kseeger at samba.org
Thu May 10 03:01:26 MDT 2012


The branch, v3-6-test has been updated
       via  da5c342 Fix bug 8920, null dereference
      from  00c901a s3-pam_winbind: Fix the build.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test


- Log -----------------------------------------------------------------
commit da5c342b6d3d3c05a8ab42bb40eb2e77d7b40ec2
Author: Steve Langasek <steve.langasek at ubuntu.com>
Date:   Wed May 9 07:56:00 2012 +0200

    Fix bug 8920, null dereference
    
    Description: Avoid null dereference in initialize_password_db()
     When initialize_password_db() is called with reload=True, it's assumed that
     the free_private_data member of pdb_methods is non-null.  This is not
     necessarily the case, as the tdb backend has no private data and therefore
     no free function.  Check to see if we have private data that needs freed
     before calling.
    Author: Steve Langasek <steve.langasek at ubuntu.com>
    Bug-Ubuntu: https://bugs.launchpad.net/bugs/829221

-----------------------------------------------------------------------

Summary of changes:
 source3/passdb/pdb_interface.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/passdb/pdb_interface.c b/source3/passdb/pdb_interface.c
index 36d5aaa..3c11016 100644
--- a/source3/passdb/pdb_interface.c
+++ b/source3/passdb/pdb_interface.c
@@ -184,7 +184,9 @@ static struct pdb_methods *pdb_get_methods_reload( bool reload )
 	static struct pdb_methods *pdb = NULL;
 
 	if ( pdb && reload ) {
-		pdb->free_private_data( &(pdb->private_data) );
+		if (pdb->free_private_data != NULL) {
+			pdb->free_private_data( &(pdb->private_data) );
+		}
 		if ( !NT_STATUS_IS_OK( make_pdb_method_name( &pdb, lp_passdb_backend() ) ) ) {
 			char *msg = NULL;
 			if (asprintf(&msg, "pdb_get_methods_reload: "


-- 
Samba Shared Repository


More information about the samba-cvs mailing list