[SCM] Samba Shared Repository - branch master updated

Volker Lendecke vlendec at samba.org
Sat Mar 3 15:39:03 MST 2012


The branch, master has been updated
       via  c887cb6 s3: Fix a bogus if (client_len < 0)
      from  58c26c2 selftest: more precisely skip durable-open, not durable.open

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit c887cb6852ce6ec669f87c282aaaad55267c6d3e
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Mar 3 17:02:01 2012 +0100

    s3: Fix a bogus if (client_len < 0)
    
    On some platforms socklen_t might be unsigned, so comparing for <0
    always returns true. Also, tsocket_address_bsd_sockaddr returns
    ssize_t.
    
    Autobuild-User: Volker Lendecke <vl at samba.org>
    Autobuild-Date: Sat Mar  3 23:38:31 CET 2012 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/rpc_server/spoolss/srv_spoolss_nt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c b/source3/rpc_server/spoolss/srv_spoolss_nt.c
index ed5edcc..f66bea8 100644
--- a/source3/rpc_server/spoolss/srv_spoolss_nt.c
+++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c
@@ -2677,7 +2677,7 @@ WERROR _spoolss_RemoteFindFirstPrinterChangeNotifyEx(struct pipes_struct *p,
 	int snum = -1;
 	struct spoolss_NotifyOption *option = r->in.notify_options;
 	struct sockaddr_storage client_ss;
-	socklen_t client_len;
+	ssize_t client_len;
 
 	/* store the notify value in the printer struct */
 


-- 
Samba Shared Repository


More information about the samba-cvs mailing list