[SCM] Samba Shared Repository - branch v3-5-test updated

Karolin Seeger kseeger at samba.org
Wed Jun 13 11:37:38 MDT 2012


The branch, v3-5-test has been updated
       via  bc4a2c1 s3: Fix uninitialized memory read in talloc_free()
      from  d853bc0 Fix bug #8970 - Possible memory leaks in the samba master process.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test


- Log -----------------------------------------------------------------
commit bc4a2c143b531f9362acb8f3d6e099cbac070840
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Jun 4 12:22:21 2012 -0700

    s3: Fix uninitialized memory read in talloc_free()
    
    Thanks to laurent gaffie <laurent.gaffie at gmail.com> for reporting
    this issue!

-----------------------------------------------------------------------

Summary of changes:
 source3/libsmb/clispnego.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/libsmb/clispnego.c b/source3/libsmb/clispnego.c
index 36d21d0..3322529 100644
--- a/source3/libsmb/clispnego.c
+++ b/source3/libsmb/clispnego.c
@@ -161,6 +161,9 @@ bool spnego_parse_negTokenInit(DATA_BLOB blob,
 	for (i=0; asn1_tag_remaining(data) > 0 && i < ASN1_MAX_OIDS-1; i++) {
 		const char *oid_str = NULL;
 		asn1_read_OID(data,talloc_autofree_context(),&oid_str);
+		if (data->has_error) {
+			break;
+		}
 		OIDs[i] = CONST_DISCARD(char *, oid_str);
 	}
 	OIDs[i] = NULL;


-- 
Samba Shared Repository


More information about the samba-cvs mailing list