[SCM] Samba Shared Repository - branch master updated

[Matthieu Patou]

The branch, master has been updated
       via  17d5fbd s3-winbindd: add comments about dump_core_setup
      from  4c33f28 s3:smbd: explain parameters to filename_convert call in smbd_smb2_create_send()

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 17d5fbde4341d82c8a20dfa0bd94a6db12bebe41
Author: Matthieu Patou <mat at matws.net>
Date:   Mon Jun 11 10:23:51 2012 -0700

    s3-winbindd: add comments about dump_core_setup
    
    This patch is related to change 0ea7152ff479e32e25817e4ddb1c2a1569bad81d
    Comments are added to explain why we call dump_core_setup 3 times.
    
    Autobuild-User(master): Matthieu Patou <mat at samba.org>
    Autobuild-Date(master): Mon Jun 11 21:21:11 CEST 2012 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/winbindd/winbindd.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/winbindd/winbindd.c b/source3/winbindd/winbindd.c
index 20ee2fc..1b6f425 100644
--- a/source3/winbindd/winbindd.c
+++ b/source3/winbindd/winbindd.c
@@ -1350,6 +1350,13 @@ int main(int argc, char **argv, char **envp)
 		}
 	}
 
+	/* We call dump_core_setup one more time because the command line can
+	 * set the log file or the log-basename and this will influence where
+	 * cores are stored. Without this call get_dyn_LOGFILEBASE will be
+	 * the default value derived from build's prefix. For EOM this value
+	 * is often not related to the path where winbindd is actually run
+	 * in production.
+	 */
 	dump_core_setup("winbindd", lp_logfile());
 	if (is_daemon && interactive) {
 		d_fprintf(stderr,"\nERROR: "
@@ -1390,6 +1397,10 @@ int main(int argc, char **argv, char **envp)
 		DEBUG(0, ("error opening config file '%s'\n", get_dyn_CONFIGFILE()));
 		exit(1);
 	}
+	/* After parsing the configuration file we setup the core path one more time
+	 * as the log file might have been set in the configuration and cores's
+	 * path is by default basename(lp_logfile()).
+	 */
 	dump_core_setup("winbindd", lp_logfile());
 
 	/* Initialise messaging system */


-- 
Samba Shared Repository