[SCM] Samba Shared Repository - branch master updated

Andreas Schneider asn at samba.org
Fri Jul 6 03:51:02 MDT 2012


The branch, master has been updated
       via  a49eb60 s4-lsarpc: DCERPC_FAULT_ACCESS_DENIED for tcp
       via  1744e99 s4-lsarpc: DCERPC_FAULT_ACCESS_DENIED for np
       via  997c780 s4-lsarpc: Restrict LookupSids3 to crypto connections only.
       via  1a12bbd s4-lsarpc: Restrict LookupNames4 to crypto connections only.
       via  13a7f98 s4-lsarpc: Don't call lsa_OpenPolicy2 in lsa_LookupSids3.
       via  9fa979c s4-lsaprc: Don't call lsa_OpenPolicy2 in lsa_LookupNames4.
       via  8e32715 selftest: Update knownfail list for samba4.rpc.lsalookup.
       via  de54047 s4-selftest: Don't run lsarpc requiring a named pipe over tcpip.
       via  48b30bf s4-selftest: Don't plan lsa.secrets tests over tcpip.
       via  0b93587 s4-libnet: Skip calling lsarpc functions over a wrong pipe.
       via  027b913 s4-torture: Call lsarpc tests over the correct pipe.
       via  a070ce3 s4-torture: Don't consider NONE_MAPPED an error in LookupSids3.
       via  2a46c7f s4-torture: Don't consider NONE_MAPPED an error in LookupNames4.
       via  eeba5ad s4-torture: Add a lsarpc test_GetUserName_fail function.
       via  5dc5cda s4-torture: Add a lsarpc test_OpenPolicy2_fail function.
       via  39a13d1 s4-torture: Add a lsarpc test_OpenPolicy_fail function.
       via  4ece074 s4-torture: Add a lsarpc test_LookupNames4_fail function.
       via  ed7be19 s4-torture: Add a lsarpc test_LookupSids3_fail function.
       via  d37643c s3-lsarpc: Enforce a secure connection for LookupSids3 and LookupNames4.
       via  d1e829b s3-lsarpc: Restrict lsa_LookupNames4 to ncacn_ip_tcp connections.
       via  426cf36 s3-lsarpc: Restrict lsa_LookupSids3 to ncacn_ip_tcp connections.
       via  bbf70e7 s3-lsarpc: Restrict the transport for ncacn_np functions.
       via  a866dcc s3-rpc: Return the correct ntstatus depending on the transport.
       via  fae6091 s3-rpc_server: Make it possible to use more rpc exceptions.
       via  81ff67c s3-selftest: Run lsa tests over np and tcpip.
       via  47e5a8c s4-torture: Test LookupSids3/LookupNames4 over np and tcpip.
       via  1c46bff s4-torture: Make sure lsa_OpenPolicy2 fails over TCP/IP.
       via  8bc4d7a s4-torture: Make sure lsa_OpenPolicy fails over TCP/IP.
       via  22da710 s4-torture: Make sure ncacn_np tests are only called over the a pipe.
       via  00171a5 s4-torture: Test LookupSids3 and LookupNames4 only over tcpip.
       via  682277b s4-torture: Use test_LookupSids3 function.
       via  1000884 s4-torture: Fix build warnings in lsa test.
      from  8f44389 s4-classicupgrade: Demote any other 'BDC' accounts back to a member server during upgrade

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit a49eb60e041a55122ce04ed6f576c2ba09c11fe3
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Jun 29 17:59:36 2012 +0200

    s4-lsarpc: DCERPC_FAULT_ACCESS_DENIED for tcp
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Fri Jul  6 11:50:40 CEST 2012 on sn-devel-104

commit 1744e99d0a339824a4e73038dccd673920f0c7bb
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Jun 29 17:59:17 2012 +0200

    s4-lsarpc: DCERPC_FAULT_ACCESS_DENIED for np

commit 997c780d24d8f59890ffe92c26107ff4f544a038
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Jun 29 16:42:16 2012 +0200

    s4-lsarpc: Restrict LookupSids3 to crypto connections only.

commit 1a12bbd5d8a328ae91b8513a47e76c4e32607df4
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Jun 29 16:41:29 2012 +0200

    s4-lsarpc: Restrict LookupNames4 to crypto connections only.

commit 13a7f98f9f9a6dd26d0a2ab73ca8d0b40fc441e2
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jun 27 13:45:55 2012 +0200

    s4-lsarpc: Don't call lsa_OpenPolicy2 in lsa_LookupSids3.

commit 9fa979c9340b004984a615e19415958b3a2d685b
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jun 27 13:01:57 2012 +0200

    s4-lsaprc: Don't call lsa_OpenPolicy2 in lsa_LookupNames4.

commit 8e32715d5ddd9d62987e84012b928197ee3c35ad
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Jul 5 12:41:44 2012 +0200

    selftest: Update knownfail list for samba4.rpc.lsalookup.

commit de54047c05e3969f6bbd4ec9269be2879acb5f9b
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Jul 6 08:04:45 2012 +0200

    s4-selftest: Don't run lsarpc requiring a named pipe over tcpip.

commit 48b30bfce61e657d55cfc4e0d091e6d21de02b7a
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Jun 29 17:59:50 2012 +0200

    s4-selftest: Don't plan lsa.secrets tests over tcpip.
    
    These will only work over a named pipe or ncalrpc.

commit 0b93587b7e3d43b32835bf0b76fe4eebef1d4036
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Jul 6 00:01:41 2012 +0200

    s4-libnet: Skip calling lsarpc functions over a wrong pipe.

commit 027b913a25a174790740684269c87d9c26cba2bc
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Jul 6 00:00:04 2012 +0200

    s4-torture: Call lsarpc tests over the correct pipe.

commit a070ce35557d8f51aff6fa13a65c1c86b5631f2a
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Jul 5 14:11:51 2012 +0200

    s4-torture: Don't consider NONE_MAPPED an error in LookupSids3.

commit 2a46c7fff211425bd5ff7394b70bec45c21b04fe
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Jul 5 14:11:25 2012 +0200

    s4-torture: Don't consider NONE_MAPPED an error in LookupNames4.

commit eeba5ad9fa5eb5e8836847e75c300decc848ed50
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Jun 29 17:57:12 2012 +0200

    s4-torture: Add a lsarpc test_GetUserName_fail function.

commit 5dc5cdaa6c867ef2daa791307c48b1b90b17835a
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Jun 29 17:50:06 2012 +0200

    s4-torture: Add a lsarpc test_OpenPolicy2_fail function.

commit 39a13d19815890587ba48e2a79ac9650bb034f5c
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Jun 29 16:50:38 2012 +0200

    s4-torture: Add a lsarpc test_OpenPolicy_fail function.

commit 4ece074f256062deeac5783d209cafd441120a9e
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Jun 29 12:10:20 2012 +0200

    s4-torture: Add a lsarpc test_LookupNames4_fail function.

commit ed7be198c4251247d9075f3c739e079ad60c148b
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Jun 29 11:54:45 2012 +0200

    s4-torture: Add a lsarpc test_LookupSids3_fail function.

commit d37643c2046c9f45bd9580a9e1107cb33f442cd3
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Jun 26 17:25:57 2012 +0200

    s3-lsarpc: Enforce a secure connection for LookupSids3 and LookupNames4.
    
    http://thread.gmane.org/gmane.network.protocol.cifs.general/291

commit d1e829bbabc9d2f2fdbe2e6fde57bf1e0f441b81
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Jun 25 18:53:03 2012 +0200

    s3-lsarpc: Restrict lsa_LookupNames4 to ncacn_ip_tcp connections.
    
    See MS-LAT, Section 2.1 Transport.

commit 426cf362ed672d44e266c18d58dff1cbe5f61c53
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Jun 25 18:49:11 2012 +0200

    s3-lsarpc: Restrict lsa_LookupSids3 to ncacn_ip_tcp connections.
    
    See MS-LAT, Section 2.1 Transport.

commit bbf70e793c7bbb16a0b147a514a9431b13c40e9c
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Jun 25 18:45:35 2012 +0200

    s3-lsarpc: Restrict the transport for ncacn_np functions.
    
    See MS-LAT, section 2.1 Transport.

commit a866dcc4f6696ed409a219b5cdd1baf56ccb2ff0
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Jul 3 13:01:47 2012 +0200

    s3-rpc: Return the correct ntstatus depending on the transport.

commit fae6091f1df9ae77f96743f6467b20386f6db404
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jun 27 15:21:11 2012 +0200

    s3-rpc_server: Make it possible to use more rpc exceptions.

commit 81ff67c3c8a9648a233c2a78450b68496c5c4332
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jun 27 11:15:05 2012 +0200

    s3-selftest: Run lsa tests over np and tcpip.

commit 47e5a8c2b3ba8d7abdd60daa4a0be262e78f0a38
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jun 27 11:14:35 2012 +0200

    s4-torture: Test LookupSids3/LookupNames4 over np and tcpip.

commit 1c46bffb115506a561d85ee2e2710b01a377d0f5
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Jun 26 10:38:08 2012 +0200

    s4-torture: Make sure lsa_OpenPolicy2 fails over TCP/IP.

commit 8bc4d7a3e61f5af4ed1e731b43a8530b80403d3a
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Jun 26 09:58:12 2012 +0200

    s4-torture: Make sure lsa_OpenPolicy fails over TCP/IP.

commit 22da7106b3c7a8b531d18c59401414bb548528ee
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Jun 25 19:06:34 2012 +0200

    s4-torture: Make sure ncacn_np tests are only called over the a pipe.

commit 00171a549a29f58659fbe8764a3ee59a155dffae
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Jun 25 18:23:31 2012 +0200

    s4-torture: Test LookupSids3 and LookupNames4 only over tcpip.
    
    LookupSids3 and LookupNames4 are only available over tcpip and MUST
    fail over named pipes.

commit 682277b44c3aa0e71f0924782cc8964810cb60e9
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Jun 25 18:03:40 2012 +0200

    s4-torture: Use test_LookupSids3 function.

commit 1000884bb39af5df9bd375545a4d18022d046822
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Jun 25 17:55:02 2012 +0200

    s4-torture: Fix build warnings in lsa test.

-----------------------------------------------------------------------

Summary of changes:
 pidl/lib/Parse/Pidl/Samba3/ServerNDR.pm       |    2 +-
 selftest/knownfail                            |    6 +-
 source3/rpc_client/rpc_transport_tstream.c    |   18 +-
 source3/rpc_server/dfs/srv_dfs_nt.c           |   36 +-
 source3/rpc_server/dssetup/srv_dssetup_nt.c   |   20 +-
 source3/rpc_server/echo/srv_echo_nt.c         |   10 +-
 source3/rpc_server/epmapper/srv_epmapper.c    |   10 +-
 source3/rpc_server/eventlog/srv_eventlog_nt.c |   32 +-
 source3/rpc_server/lsa/srv_lsa_nt.c           |  178 +++++++---
 source3/rpc_server/netlogon/srv_netlog_nt.c   |   60 ++--
 source3/rpc_server/ntsvcs/srv_ntsvcs_nt.c     |  116 +++---
 source3/rpc_server/rpc_handles.c              |    2 +-
 source3/rpc_server/rpc_ncacn_np.c             |   19 +-
 source3/rpc_server/rpc_pipes.h                |   17 +-
 source3/rpc_server/samr/srv_samr_nt.c         |   16 +-
 source3/rpc_server/spoolss/srv_spoolss_nt.c   |  112 +++---
 source3/rpc_server/srv_pipe.c                 |   21 +-
 source3/rpc_server/srvsvc/srv_srvsvc_nt.c     |   70 ++--
 source3/rpc_server/svcctl/srv_svcctl_nt.c     |   56 ++--
 source3/rpc_server/winreg/srv_winreg_nt.c     |   10 +-
 source3/rpc_server/wkssvc/srv_wkssvc_nt.c     |   53 ++--
 source3/selftest/tests.py                     |    5 +
 source4/libnet/libnet_rpc.c                   |    9 +
 source4/rpc_server/lsa/dcesrv_lsa.c           |   10 +
 source4/rpc_server/lsa/lsa_init.c             |   10 +
 source4/rpc_server/lsa/lsa_lookup.c           |  241 ++++++++-----
 source4/selftest/tests.py                     |   10 +-
 source4/torture/rpc/lsa.c                     |  484 +++++++++++++++++++++----
 source4/torture/rpc/lsa_lookup.c              |   16 +
 source4/torture/rpc/schannel.c                |    6 +
 30 files changed, 1089 insertions(+), 566 deletions(-)


Changeset truncated at 500 lines:

diff --git a/pidl/lib/Parse/Pidl/Samba3/ServerNDR.pm b/pidl/lib/Parse/Pidl/Samba3/ServerNDR.pm
index c4374ba..d433f60 100644
--- a/pidl/lib/Parse/Pidl/Samba3/ServerNDR.pm
+++ b/pidl/lib/Parse/Pidl/Samba3/ServerNDR.pm
@@ -183,7 +183,7 @@ sub ParseFunction($$)
 	);
 
 	pidl "";
-	pidl "if (p->rng_fault_state) {";
+	pidl "if (p->fault_state) {";
 	pidl "\ttalloc_free(r);";
 	pidl "\t/* Return true here, srv_pipe_hnd.c will take care */";
 	pidl "\treturn true;";
diff --git a/selftest/knownfail b/selftest/knownfail
index c67915d..f68db5a 100644
--- a/selftest/knownfail
+++ b/selftest/knownfail
@@ -60,7 +60,11 @@
 ^samba4.rpc.wkssvc
 ^samba4.rpc.handles.*.lsarpc-shared
 ^samba4.rpc.epmapper
-^samba4.rpc.lsalookup
+^samba4.rpc.lsalookup on ncalrpc
+^samba4.rpc.lsalookup on ncacn_np
+^samba4.rpc.lsalookup with seal,padcheck
+^samba4.rpc.lsalookup with validate
+^samba4.rpc.lsalookup with bigendian
 ^samba4.rpc.cracknames
 ^samba4.rpc.netlogon.*.LogonUasLogon
 ^samba4.rpc.netlogon.*.LogonUasLogoff
diff --git a/source3/rpc_client/rpc_transport_tstream.c b/source3/rpc_client/rpc_transport_tstream.c
index 01e7a5e..11cd8d4 100644
--- a/source3/rpc_client/rpc_transport_tstream.c
+++ b/source3/rpc_client/rpc_transport_tstream.c
@@ -186,7 +186,11 @@ static struct tevent_req *rpc_tstream_read_send(TALLOC_CTX *mem_ctx,
 		return NULL;
 	}
 	if (!rpc_tstream_is_connected(transp)) {
-		tevent_req_nterror(req, NT_STATUS_CONNECTION_DISCONNECTED);
+		NTSTATUS status = NT_STATUS_CONNECTION_DISCONNECTED;
+		if (tstream_is_cli_np(transp->stream)) {
+			status = NT_STATUS_PIPE_DISCONNECTED;
+		}
+		tevent_req_nterror(req, status);
 		return tevent_req_post(req, ev);
 	}
 	state->transp = transp;
@@ -270,7 +274,11 @@ static struct tevent_req *rpc_tstream_write_send(TALLOC_CTX *mem_ctx,
 		return NULL;
 	}
 	if (!rpc_tstream_is_connected(transp)) {
-		tevent_req_nterror(req, NT_STATUS_CONNECTION_DISCONNECTED);
+		NTSTATUS status = NT_STATUS_CONNECTION_DISCONNECTED;
+		if (tstream_is_cli_np(transp->stream)) {
+			status = NT_STATUS_PIPE_DISCONNECTED;
+		}
+		tevent_req_nterror(req, status);
 		return tevent_req_post(req, ev);
 	}
 	state->ev = ev;
@@ -366,7 +374,11 @@ static struct tevent_req *rpc_tstream_trans_send(TALLOC_CTX *mem_ctx,
 	}
 
 	if (!rpc_tstream_is_connected(transp)) {
-		tevent_req_nterror(req, NT_STATUS_CONNECTION_DISCONNECTED);
+		NTSTATUS status = NT_STATUS_CONNECTION_DISCONNECTED;
+		if (tstream_is_cli_np(transp->stream)) {
+			status = NT_STATUS_PIPE_DISCONNECTED;
+		}
+		tevent_req_nterror(req, status);
 		return tevent_req_post(req, ev);
 	}
 	state->ev = ev;
diff --git a/source3/rpc_server/dfs/srv_dfs_nt.c b/source3/rpc_server/dfs/srv_dfs_nt.c
index 2c840e2..49e6506 100644
--- a/source3/rpc_server/dfs/srv_dfs_nt.c
+++ b/source3/rpc_server/dfs/srv_dfs_nt.c
@@ -422,125 +422,125 @@ WERROR _dfs_GetInfo(struct pipes_struct *p, struct dfs_GetInfo *r)
 WERROR _dfs_SetInfo(struct pipes_struct *p, struct dfs_SetInfo *r)
 {
 	/* FIXME: Implement your code here */
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
 WERROR _dfs_Rename(struct pipes_struct *p, struct dfs_Rename *r)
 {
 	/* FIXME: Implement your code here */
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
 WERROR _dfs_Move(struct pipes_struct *p, struct dfs_Move *r)
 {
 	/* FIXME: Implement your code here */
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
 WERROR _dfs_ManagerGetConfigInfo(struct pipes_struct *p, struct dfs_ManagerGetConfigInfo *r)
 {
 	/* FIXME: Implement your code here */
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
 WERROR _dfs_ManagerSendSiteInfo(struct pipes_struct *p, struct dfs_ManagerSendSiteInfo *r)
 {
 	/* FIXME: Implement your code here */
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
 WERROR _dfs_AddFtRoot(struct pipes_struct *p, struct dfs_AddFtRoot *r)
 {
 	/* FIXME: Implement your code here */
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
 WERROR _dfs_RemoveFtRoot(struct pipes_struct *p, struct dfs_RemoveFtRoot *r)
 {
 	/* FIXME: Implement your code here */
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
 WERROR _dfs_AddStdRoot(struct pipes_struct *p, struct dfs_AddStdRoot *r)
 {
 	/* FIXME: Implement your code here */
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
 WERROR _dfs_RemoveStdRoot(struct pipes_struct *p, struct dfs_RemoveStdRoot *r)
 {
 	/* FIXME: Implement your code here */
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
 WERROR _dfs_ManagerInitialize(struct pipes_struct *p, struct dfs_ManagerInitialize *r)
 {
 	/* FIXME: Implement your code here */
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
 WERROR _dfs_AddStdRootForced(struct pipes_struct *p, struct dfs_AddStdRootForced *r)
 {
 	/* FIXME: Implement your code here */
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
 WERROR _dfs_GetDcAddress(struct pipes_struct *p, struct dfs_GetDcAddress *r)
 {
 	/* FIXME: Implement your code here */
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
 WERROR _dfs_SetDcAddress(struct pipes_struct *p, struct dfs_SetDcAddress *r)
 {
 	/* FIXME: Implement your code here */
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
 WERROR _dfs_FlushFtTable(struct pipes_struct *p, struct dfs_FlushFtTable *r)
 {
 	/* FIXME: Implement your code here */
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
 WERROR _dfs_Add2(struct pipes_struct *p, struct dfs_Add2 *r)
 {
 	/* FIXME: Implement your code here */
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
 WERROR _dfs_Remove2(struct pipes_struct *p, struct dfs_Remove2 *r)
 {
 	/* FIXME: Implement your code here */
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
 WERROR _dfs_EnumEx(struct pipes_struct *p, struct dfs_EnumEx *r)
 {
 	/* FIXME: Implement your code here */
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
 WERROR _dfs_SetInfo2(struct pipes_struct *p, struct dfs_SetInfo2 *r)
 {
 	/* FIXME: Implement your code here */
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
diff --git a/source3/rpc_server/dssetup/srv_dssetup_nt.c b/source3/rpc_server/dssetup/srv_dssetup_nt.c
index 1cf4ab8..fef2dbd 100644
--- a/source3/rpc_server/dssetup/srv_dssetup_nt.c
+++ b/source3/rpc_server/dssetup/srv_dssetup_nt.c
@@ -130,7 +130,7 @@ WERROR _dssetup_DsRoleGetPrimaryDomainInformation(struct pipes_struct *p,
 WERROR _dssetup_DsRoleDnsNameToFlatName(struct pipes_struct *p,
 					struct dssetup_DsRoleDnsNameToFlatName *r)
 {
-	p->rng_fault_state = true;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
@@ -140,7 +140,7 @@ WERROR _dssetup_DsRoleDnsNameToFlatName(struct pipes_struct *p,
 WERROR _dssetup_DsRoleDcAsDc(struct pipes_struct *p,
 			     struct dssetup_DsRoleDcAsDc *r)
 {
-	p->rng_fault_state = true;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
@@ -150,7 +150,7 @@ WERROR _dssetup_DsRoleDcAsDc(struct pipes_struct *p,
 WERROR _dssetup_DsRoleDcAsReplica(struct pipes_struct *p,
 				  struct dssetup_DsRoleDcAsReplica *r)
 {
-	p->rng_fault_state = true;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
@@ -160,7 +160,7 @@ WERROR _dssetup_DsRoleDcAsReplica(struct pipes_struct *p,
 WERROR _dssetup_DsRoleDemoteDc(struct pipes_struct *p,
 			       struct dssetup_DsRoleDemoteDc *r)
 {
-	p->rng_fault_state = true;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
@@ -170,7 +170,7 @@ WERROR _dssetup_DsRoleDemoteDc(struct pipes_struct *p,
 WERROR _dssetup_DsRoleGetDcOperationProgress(struct pipes_struct *p,
 					     struct dssetup_DsRoleGetDcOperationProgress *r)
 {
-	p->rng_fault_state = true;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
@@ -180,7 +180,7 @@ WERROR _dssetup_DsRoleGetDcOperationProgress(struct pipes_struct *p,
 WERROR _dssetup_DsRoleGetDcOperationResults(struct pipes_struct *p,
 					    struct dssetup_DsRoleGetDcOperationResults *r)
 {
-	p->rng_fault_state = true;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
@@ -190,7 +190,7 @@ WERROR _dssetup_DsRoleGetDcOperationResults(struct pipes_struct *p,
 WERROR _dssetup_DsRoleCancel(struct pipes_struct *p,
 			     struct dssetup_DsRoleCancel *r)
 {
-	p->rng_fault_state = true;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
@@ -200,7 +200,7 @@ WERROR _dssetup_DsRoleCancel(struct pipes_struct *p,
 WERROR _dssetup_DsRoleServerSaveStateForUpgrade(struct pipes_struct *p,
 						struct dssetup_DsRoleServerSaveStateForUpgrade *r)
 {
-	p->rng_fault_state = true;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
@@ -210,7 +210,7 @@ WERROR _dssetup_DsRoleServerSaveStateForUpgrade(struct pipes_struct *p,
 WERROR _dssetup_DsRoleUpgradeDownlevelServer(struct pipes_struct *p,
 					     struct dssetup_DsRoleUpgradeDownlevelServer *r)
 {
-	p->rng_fault_state = true;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
 
@@ -220,6 +220,6 @@ WERROR _dssetup_DsRoleUpgradeDownlevelServer(struct pipes_struct *p,
 WERROR _dssetup_DsRoleAbortDownlevelServerUpgrade(struct pipes_struct *p,
 						  struct dssetup_DsRoleAbortDownlevelServerUpgrade *r)
 {
-	p->rng_fault_state = true;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return WERR_NOT_SUPPORTED;
 }
diff --git a/source3/rpc_server/echo/srv_echo_nt.c b/source3/rpc_server/echo/srv_echo_nt.c
index 7c8ae19..f1bb5d3 100644
--- a/source3/rpc_server/echo/srv_echo_nt.c
+++ b/source3/rpc_server/echo/srv_echo_nt.c
@@ -87,13 +87,13 @@ void _echo_SourceData(struct pipes_struct *p, struct echo_SourceData *r)
 
 void _echo_TestCall(struct pipes_struct *p, struct echo_TestCall *r)
 {
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return;
 }
 
 NTSTATUS _echo_TestCall2(struct pipes_struct *p, struct echo_TestCall2 *r)
 {
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return NT_STATUS_OK;
 }
 
@@ -105,18 +105,18 @@ uint32 _echo_TestSleep(struct pipes_struct *p, struct echo_TestSleep *r)
 
 void _echo_TestEnum(struct pipes_struct *p, struct echo_TestEnum *r)
 {
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return;
 }
 
 void _echo_TestSurrounding(struct pipes_struct *p, struct echo_TestSurrounding *r)
 {
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return;
 }
 
 uint16 _echo_TestDoublePointer(struct pipes_struct *p, struct echo_TestDoublePointer *r)
 {
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return 0;
 }
diff --git a/source3/rpc_server/epmapper/srv_epmapper.c b/source3/rpc_server/epmapper/srv_epmapper.c
index 5cd25ed..ac215cb 100644
--- a/source3/rpc_server/epmapper/srv_epmapper.c
+++ b/source3/rpc_server/epmapper/srv_epmapper.c
@@ -306,7 +306,7 @@ error_status_t _epm_Insert(struct pipes_struct *p,
 	/* If this is not a priviledged users, return */
 	if (p->transport != NCALRPC ||
 	    !is_priviledged_pipe(p->session_info)) {
-		p->rng_fault_state = true;
+		p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 		return EPMAPPER_STATUS_CANT_PERFORM_OP;
 	}
 
@@ -443,7 +443,7 @@ error_status_t _epm_Delete(struct pipes_struct *p,
 	/* If this is not a priviledged users, return */
 	if (p->transport != NCALRPC ||
 	    !is_priviledged_pipe(p->session_info)) {
-		p->rng_fault_state = true;
+		p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 		return EPMAPPER_STATUS_CANT_PERFORM_OP;
 	}
 
@@ -1110,7 +1110,7 @@ error_status_t _epm_LookupHandleFree(struct pipes_struct *p,
 error_status_t _epm_InqObject(struct pipes_struct *p,
 		      struct epm_InqObject *r)
 {
-	p->rng_fault_state = true;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return EPMAPPER_STATUS_CANT_PERFORM_OP;
 }
 
@@ -1124,7 +1124,7 @@ error_status_t _epm_InqObject(struct pipes_struct *p,
 error_status_t _epm_MgmtDelete(struct pipes_struct *p,
 		       struct epm_MgmtDelete *r)
 {
-	p->rng_fault_state = true;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return EPMAPPER_STATUS_CANT_PERFORM_OP;
 }
 
@@ -1135,7 +1135,7 @@ error_status_t _epm_MgmtDelete(struct pipes_struct *p,
 error_status_t _epm_MapAuth(struct pipes_struct *p,
 		    struct epm_MapAuth *r)
 {
-	p->rng_fault_state = true;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return EPMAPPER_STATUS_CANT_PERFORM_OP;
 }
 
diff --git a/source3/rpc_server/eventlog/srv_eventlog_nt.c b/source3/rpc_server/eventlog/srv_eventlog_nt.c
index ea3da4d..67ab471 100644
--- a/source3/rpc_server/eventlog/srv_eventlog_nt.c
+++ b/source3/rpc_server/eventlog/srv_eventlog_nt.c
@@ -696,7 +696,7 @@ NTSTATUS _eventlog_GetNumRecords(struct pipes_struct *p,
 
 NTSTATUS _eventlog_BackupEventLogW(struct pipes_struct *p, struct eventlog_BackupEventLogW *r)
 {
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return NT_STATUS_NOT_IMPLEMENTED;
 }
 
@@ -839,104 +839,104 @@ NTSTATUS _eventlog_ReportEventW(struct pipes_struct *p,
 NTSTATUS _eventlog_DeregisterEventSource(struct pipes_struct *p,
 					 struct eventlog_DeregisterEventSource *r)
 {
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return NT_STATUS_NOT_IMPLEMENTED;
 }
 
 NTSTATUS _eventlog_ChangeNotify(struct pipes_struct *p,
 				struct eventlog_ChangeNotify *r)
 {
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return NT_STATUS_NOT_IMPLEMENTED;
 }
 
 NTSTATUS _eventlog_RegisterEventSourceW(struct pipes_struct *p,
 					struct eventlog_RegisterEventSourceW *r)
 {
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return NT_STATUS_NOT_IMPLEMENTED;
 }
 
 NTSTATUS _eventlog_OpenBackupEventLogW(struct pipes_struct *p,
 				       struct eventlog_OpenBackupEventLogW *r)
 {
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return NT_STATUS_NOT_IMPLEMENTED;
 }
 
 NTSTATUS _eventlog_ClearEventLogA(struct pipes_struct *p,
 				  struct eventlog_ClearEventLogA *r)
 {
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return NT_STATUS_NOT_IMPLEMENTED;
 }
 
 NTSTATUS _eventlog_BackupEventLogA(struct pipes_struct *p,
 				   struct eventlog_BackupEventLogA *r)
 {
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return NT_STATUS_NOT_IMPLEMENTED;
 }
 
 NTSTATUS _eventlog_OpenEventLogA(struct pipes_struct *p,
 				 struct eventlog_OpenEventLogA *r)
 {
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return NT_STATUS_NOT_IMPLEMENTED;
 }
 
 NTSTATUS _eventlog_RegisterEventSourceA(struct pipes_struct *p,
 					struct eventlog_RegisterEventSourceA *r)
 {
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return NT_STATUS_NOT_IMPLEMENTED;
 }
 
 NTSTATUS _eventlog_OpenBackupEventLogA(struct pipes_struct *p,
 				       struct eventlog_OpenBackupEventLogA *r)
 {
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return NT_STATUS_NOT_IMPLEMENTED;
 }
 
 NTSTATUS _eventlog_ReadEventLogA(struct pipes_struct *p,
 				 struct eventlog_ReadEventLogA *r)
 {
-	p->rng_fault_state = True;
+	p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
 	return NT_STATUS_NOT_IMPLEMENTED;
 }
 
 NTSTATUS _eventlog_ReportEventA(struct pipes_struct *p,


-- 
Samba Shared Repository


More information about the samba-cvs mailing list