[SCM] Samba Shared Repository - branch v3-6-test updated

Karolin Seeger kseeger at samba.org
Wed Jan 4 13:08:50 MST 2012


The branch, v3-6-test has been updated
       via  16c0d52 Fix bug #8644 - vfs_acl_xattr and vfs_acl_tdb modules can fail to add inheritable entries on a directory with no stored ACL.
      from  ceeab5c s3/doc: document the ignore system acls option of vfs_acl_xattr and vfs_acl_tdb

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test


- Log -----------------------------------------------------------------
commit 16c0d52842386fc2ebf975166b57b888d36796c5
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Dec 2 10:55:40 2011 -0800

    Fix bug #8644 - vfs_acl_xattr and vfs_acl_tdb modules can fail to add inheritable entries on a directory with no stored ACL.
    
    If referring to an fsp sbuf can be left as an uninitialized variable,
    causing the 'is_directory' variable to be false when it should be true.

-----------------------------------------------------------------------

Summary of changes:
 source3/modules/vfs_acl_common.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/modules/vfs_acl_common.c b/source3/modules/vfs_acl_common.c
index 81c734a..f82f031 100644
--- a/source3/modules/vfs_acl_common.c
+++ b/source3/modules/vfs_acl_common.c
@@ -378,7 +378,7 @@ static NTSTATUS get_nt_acl_internal(vfs_handle_struct *handle,
 				return map_nt_error_from_unix(errno);
 			}
 		}
-		is_directory = S_ISDIR(sbuf.st_ex_mode);
+		is_directory = S_ISDIR(psbuf->st_ex_mode);
 
 		if (ignore_file_system_acl) {
 			TALLOC_FREE(pdesc_next);


-- 
Samba Shared Repository


More information about the samba-cvs mailing list