[SCM] Samba Shared Repository - branch master updated
Jeremy Allison
jra at samba.org
Fri Dec 21 18:09:04 MST 2012
The branch, master has been updated
via c1fb37d Recent coverity changes added directory_create_or_exist() checks to many directories.
from b1548fd s3-prefork: Directly fail if tevent_req_is_unix_error() fails.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit c1fb37d7bec1dd720f3eccbd0b490b6a335ca288
Author: Jeremy Allison <jra at samba.org>
Date: Fri Dec 21 15:16:10 2012 -0800
Recent coverity changes added directory_create_or_exist() checks to many directories.
These may not be needed, but in the meantime - ensure "make test" works again
by chmod'ing the created test directories from 0777 to 0755.
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
Signed-off-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sat Dec 22 02:08:33 CET 2012 on sn-devel-104
-----------------------------------------------------------------------
Summary of changes:
selftest/target/Samba3.pm | 7 +++++++
selftest/target/Samba4.pm | 6 ++++++
2 files changed, 13 insertions(+), 0 deletions(-)
Changeset truncated at 500 lines:
diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm
index ea2e21d..adca52f 100755
--- a/selftest/target/Samba3.pm
+++ b/selftest/target/Samba3.pm
@@ -765,6 +765,13 @@ sub provision($$$$$$)
mkdir($_, 0777) foreach(@dirs);
##
+ ## lockdir and piddir must be 0755
+ ##
+ chmod 0755, $lockdir;
+ chmod 0755, $piddir;
+
+
+ ##
## create ro and msdfs share layout
##
diff --git a/selftest/target/Samba4.pm b/selftest/target/Samba4.pm
index 5988b83..ba37504 100644
--- a/selftest/target/Samba4.pm
+++ b/selftest/target/Samba4.pm
@@ -555,6 +555,12 @@ sub provision_raw_step1($$)
mkdir($_, 0777) foreach (@{$ctx->{directories}});
+ ##
+ ## lockdir and piddir must be 0755
+ ##
+ chmod 0755, $ctx->{lockdir};
+ chmod 0755, $ctx->{piddir};
+
unless (open(CONFFILE, ">$ctx->{smb_conf}")) {
warn("can't open $ctx->{smb_conf}$?");
return undef;
--
Samba Shared Repository
More information about the samba-cvs
mailing list