[SCM] Samba Shared Repository - branch master updated

Jeremy Allison jra at samba.org
Mon Aug 20 17:32:02 MDT 2012


The branch, master has been updated
       via  21e67bd Fix bug #9104 - winbindd can mis-identify idle clients - can cause crashes and NDR parsing errors.
      from  84d6e09 s4-torture: Use torture_fail() in the unix.unix_info2 test

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 21e67bdcee79b813ddb7b73f72a54b363db294d6
Author: Herb Lewis <hlewis at panasas.com>
Date:   Mon Aug 20 14:51:28 2012 -0700

    Fix bug #9104 - winbindd can mis-identify idle clients - can cause crashes and NDR parsing errors.
    
    A connection is idle when both struct winbindd_cli_state->request AND
    struct winbindd_cli_state->response are NULL. Otherwise we can flag
    as idle a connection in the state of having sent the request to
    the winbindd child (request != NULL) but not yet received a reply
    (response == NULL).
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Aug 21 01:31:46 CEST 2012 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/winbindd/winbindd.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/winbindd/winbindd.c b/source3/winbindd/winbindd.c
index 6d3fece..c43b585 100644
--- a/source3/winbindd/winbindd.c
+++ b/source3/winbindd/winbindd.c
@@ -923,7 +923,8 @@ static void remove_client(struct winbindd_cli_state *state)
 /* Is a client idle? */
 
 static bool client_is_idle(struct winbindd_cli_state *state) {
-  return (state->response == NULL &&
+  return (state->request == NULL &&
+	  state->response == NULL &&
 	  !state->pwent_state && !state->grent_state);
 }
 


-- 
Samba Shared Repository


More information about the samba-cvs mailing list