[SCM] Samba Shared Repository - branch master updated

[Andrew Bartlett]

The branch, master has been updated
       via  a7b8e9f5 s4-dsdb: Ensure we always free tmp_ctx in schema refresh check
      from  21c8fa25 Fix bug #9085 - NMB registration for a duplicate workstation fails with registration refuse

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit a7b8e9f562780dc6a3487644623decd1cff226e2
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Aug 17 12:42:15 2012 +1000

    s4-dsdb: Ensure we always free tmp_ctx in schema refresh check
    
    This was found based on a log provided by Ricky Nance
    <ricky.nance at weaubleau.k12.mo.us>.  Thanks Ricky!
    
    In that log, over 2.5 days this particular allocation was repeated:
    
    1715099     talloc_new: ../source4/dsdb/samdb/ldb_modules/schema_load.c:120 contains      0 bytes in   1 blocks
    
    Andrew Bartlett
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Fri Aug 17 06:21:18 CEST 2012 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source4/dsdb/samdb/ldb_modules/schema_load.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/dsdb/samdb/ldb_modules/schema_load.c b/source4/dsdb/samdb/ldb_modules/schema_load.c
index 82ae7d8..be7915e 100644
--- a/source4/dsdb/samdb/ldb_modules/schema_load.c
+++ b/source4/dsdb/samdb/ldb_modules/schema_load.c
@@ -131,8 +131,10 @@ static int schema_metadata_get_uint64(struct ldb_module *module,
 	if (!tdb_data.dptr) {
 		if (tdb_error(tdb) == TDB_ERR_NOEXIST) {
 			*value = default_value;
+			talloc_free(tmp_ctx);
 			return LDB_SUCCESS;
 		} else {
+			talloc_free(tmp_ctx);
 			return ldb_module_error(module, LDB_ERR_OPERATIONS_ERROR,
 						tdb_errorstr_compat(tdb));
 		}


-- 
Samba Shared Repository