[SCM] Samba Shared Repository - branch master updated

Jeremy Allison jra at samba.org
Thu Apr 19 16:07:08 MDT 2012


The branch, master has been updated
       via  00d5f32 Fix bug #8877 - Syslog broken owing to mistyping of debug_settings.syslog.
      from  393936a s3: Fix Coverity ID 2682 -- NULL_RETURNS

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 00d5f32025bf13285ab3f8ffae914107c9eca275
Author: Joseph Tam <jtam.home at gmail.com>
Date:   Thu Apr 19 11:46:16 2012 -0700

    Fix bug #8877 - Syslog broken owing to mistyping of debug_settings.syslog.
    
    Setting "syslog only = yes" did not divert log messages to syslog.  The test in
    lib/util/debug.c:Debug1():747
    
       if( syslog_level < state.settings.syslog )
    
    produces wrong results since .syslog is typed "bool" rather than "int".
    The attached patch fixes this by typing this field correctly as "int".
    
    Autobuild-User: Jeremy Allison <jra at samba.org>
    Autobuild-Date: Fri Apr 20 00:06:12 CEST 2012 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 lib/util/debug.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/lib/util/debug.h b/lib/util/debug.h
index b3647a3..2566418 100644
--- a/lib/util/debug.h
+++ b/lib/util/debug.h
@@ -201,7 +201,7 @@ enum debug_logtype {DEBUG_DEFAULT_STDERR = 0, DEBUG_DEFAULT_STDOUT = 1, DEBUG_FI
 
 struct debug_settings {
 	size_t max_log_size;
-	bool syslog;
+	int syslog;
 	bool syslog_only;
 	bool timestamp_logs;
 	bool debug_prefix_timestamp;


-- 
Samba Shared Repository


More information about the samba-cvs mailing list