[SCM] Samba Shared Repository - branch v3-6-test updated

Karolin Seeger kseeger at samba.org
Tue Apr 10 13:01:26 MDT 2012


The branch, v3-6-test has been updated
       via  3bdcf32 s3-smbd: move print_backend_init() behind init_system_info()
      from  6edb03e docs: remove whitespace in example samba.ldif (fix bug #8789) (cherry picked from commit 9a68a98e87e5597ba684bea3d5e6a44951e51973)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test


- Log -----------------------------------------------------------------
commit 3bdcf3208c8ff1a99bc457549257af83a869b381
Author: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
Date:   Wed Apr 4 17:40:27 2012 +0200

    s3-smbd: move print_backend_init() behind init_system_info()
    
    On smbd startup check_published_printers() fails with the following error
    messages:
    
    [2012/04/04 16:29:50.511526,  0] printing/nt_printing_ads.c:360(check_published_printers)
      check_published_printers: Could not create system session_info
    [2012/04/04 16:29:50.512101,  0] printing/nt_printing.c:102(nt_printing_init)
      nt_printing_init: error checking published printers: WERR_ACCESS_DENIED
    
    check_published_printers() requires session_info to be set, but
    initialization of session_info in main() is done after calling
    print_backend_init(). Move print_backend_init() behind init_system_info().
    
    Signed-off-by: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
    
    Fix bug #8845 (check_published_printers: Could not create system session_info).

-----------------------------------------------------------------------

Summary of changes:
 source3/smbd/server.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/server.c b/source3/smbd/server.c
index 28bb947..8cda180 100644
--- a/source3/smbd/server.c
+++ b/source3/smbd/server.c
@@ -1209,9 +1209,6 @@ extern void build_options(bool screen);
 	if (!W_ERROR_IS_OK(registry_init_full()))
 		exit(1);
 
-	if (!print_backend_init(smbd_messaging_context()))
-		exit(1);
-
 	/* Open the share_info.tdb here, so we don't have to open
 	   after the fork on every single connection.  This is a small
 	   performance improvment and reduces the total number of system
@@ -1228,6 +1225,9 @@ extern void build_options(bool screen);
 		return -1;
 	}
 
+	if (!print_backend_init(smbd_messaging_context()))
+		exit(1);
+
 	if (!init_guest_info()) {
 		DEBUG(0,("ERROR: failed to setup guest info.\n"));
 		return -1;


-- 
Samba Shared Repository


More information about the samba-cvs mailing list