[SCM] Samba Shared Repository - branch v3-6-test updated

Karolin Seeger kseeger at samba.org
Thu Sep 22 13:55:25 MDT 2011


The branch, v3-6-test has been updated
       via  9bbb3a8 Fix bug #8453 - smbclient segfaults when dialect option -m is used for legacy dialects
      from  5a109e3 WHATSNEW: Add changes since 3.6.0.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test


- Log -----------------------------------------------------------------
commit 9bbb3a89ffa39c9be30c269bf96f080866740406
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 14 11:55:16 2011 -0700

    Fix bug #8453 - smbclient segfaults when dialect option -m is used for legacy dialects
    
    Ensure we have valid pointers.

-----------------------------------------------------------------------

Summary of changes:
 source3/libsmb/cliconnect.c |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/libsmb/cliconnect.c b/source3/libsmb/cliconnect.c
index 81c1819..113b8a5 100644
--- a/source3/libsmb/cliconnect.c
+++ b/source3/libsmb/cliconnect.c
@@ -1997,6 +1997,19 @@ NTSTATUS cli_session_setup(struct cli_state *cli,
 	}
 
 	if (cli->protocol < PROTOCOL_LANMAN1) {
+		/*
+		 * Ensure cli->server_domain,
+		 * cli->server_os and cli->server_type
+		 * are valid pointers.
+		 */
+		cli->server_domain = talloc_strdup(cli, "");
+		cli->server_os = talloc_strdup(cli, "");
+		cli->server_type = talloc_strdup(cli, "");
+		if (cli->server_domain == NULL ||
+				cli->server_os == NULL ||
+				cli->server_type == NULL) {
+			return NT_STATUS_NO_MEMORY;
+		}
 		return NT_STATUS_OK;
 	}
 


-- 
Samba Shared Repository


More information about the samba-cvs mailing list