[SCM] Samba Shared Repository - branch master updated

Jeremy Allison jra at samba.org
Wed Nov 23 14:39:02 MST 2011


The branch, master has been updated
       via  9c4fdde Fix uninitialized variable frees on error paths.
      from  b1f7164 s3: Fix a valgrind error

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 9c4fdde023ff156e61d11429cfbd388db708ca42
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Nov 23 11:59:53 2011 -0800

    Fix uninitialized variable frees on error paths.
    
    Autobuild-User: Jeremy Allison <jra at samba.org>
    Autobuild-Date: Wed Nov 23 22:38:13 CET 2011 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 lib/addns/dnsrecord.c |   22 +++++++++++-----------
 1 files changed, 11 insertions(+), 11 deletions(-)


Changeset truncated at 500 lines:

diff --git a/lib/addns/dnsrecord.c b/lib/addns/dnsrecord.c
index f9435da..e5a43b8 100644
--- a/lib/addns/dnsrecord.c
+++ b/lib/addns/dnsrecord.c
@@ -27,8 +27,8 @@ DNS_ERROR dns_create_query( TALLOC_CTX *mem_ctx, const char *name,
 			    uint16 q_type, uint16 q_class,
 			    struct dns_request **preq )
 {
-	struct dns_request *req;
-	struct dns_question *q;
+	struct dns_request *req = NULL;
+	struct dns_question *q = NULL;
 	DNS_ERROR err;
 
 	if (!(req = talloc_zero(mem_ctx, struct dns_request)) ||
@@ -60,8 +60,8 @@ DNS_ERROR dns_create_query( TALLOC_CTX *mem_ctx, const char *name,
 DNS_ERROR dns_create_update( TALLOC_CTX *mem_ctx, const char *name,
 			     struct dns_update_request **preq )
 {
-	struct dns_update_request *req;
-	struct dns_zone *z;
+	struct dns_update_request *req = NULL;
+	struct dns_zone *z = NULL;
 	DNS_ERROR err;
 
 	if (!(req = talloc_zero(mem_ctx, struct dns_update_request)) ||
@@ -95,7 +95,7 @@ DNS_ERROR dns_create_rrec(TALLOC_CTX *mem_ctx, const char *name,
 			  uint16 data_length, uint8 *data,
 			  struct dns_rrec **prec)
 {
-	struct dns_rrec *rec;
+	struct dns_rrec *rec = NULL;
 	DNS_ERROR err;
 
 	if (!(rec = talloc(mem_ctx, struct dns_rrec))) {
@@ -221,8 +221,8 @@ DNS_ERROR dns_create_tkey_record(TALLOC_CTX *mem_ctx, const char *keyname,
 				 uint16 key_length, const uint8 *key,
 				 struct dns_rrec **prec)
 {
-	struct dns_buffer *buf;
-	struct dns_domain_name *algorithm;
+	struct dns_buffer *buf = NULL;
+	struct dns_domain_name *algorithm = NULL;
 	DNS_ERROR err;
 
 	if (!(buf = dns_create_buffer(mem_ctx))) {
@@ -371,8 +371,8 @@ DNS_ERROR dns_create_probe(TALLOC_CTX *mem_ctx, const char *zone,
 			   const struct sockaddr_storage *sslist,
 			   struct dns_update_request **preq)
 {
-	struct dns_update_request *req;
-	struct dns_rrec *rec;
+	struct dns_update_request *req = NULL;
+	struct dns_rrec *rec = NULL;
 	DNS_ERROR err;
 	uint16 i;
 
@@ -409,8 +409,8 @@ DNS_ERROR dns_create_update_request(TALLOC_CTX *mem_ctx,
 				    size_t num_addrs,
 				    struct dns_update_request **preq)
 {
-	struct dns_update_request *req;
-	struct dns_rrec *rec;
+	struct dns_update_request *req = NULL;
+	struct dns_rrec *rec = NULL;
 	DNS_ERROR err;
 	size_t i;
 


-- 
Samba Shared Repository


More information about the samba-cvs mailing list