[SCM] Samba Shared Repository - branch v3-6-test updated

Karolin Seeger kseeger at samba.org
Fri May 20 13:13:08 MDT 2011


The branch, v3-6-test has been updated
       via  8546896 Fix bug 8153 found when building on an IPv6-only system by Kai Blin.
      from  72e50d3 Fix Bug 8152 - smbd crash in release_ip()

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test


- Log -----------------------------------------------------------------
commit 85468960ebdb3d813bd863e57f6dca6bab61bec2
Author: Jeremy Allison <jra at samba.org>
Date:   Thu May 19 12:32:15 2011 -0700

    Fix bug 8153 found when building on an IPv6-only system by Kai Blin.
    
    When building on IPv6-only, doing:
    
    hints.ai_family = AF_INET;
    getaddrinfo("0.0.0.0", NULL, &hints, &ppres)
    
    fails as AF_INET is unavailable on an IPv6-only system. This
    causes us to fallback to our replacement getaddrinfo code
    which is IPv4-only.
    
    As we're only trying to detect a specific AIX bug here,
    broaden the tests to find that bug, and also test for
    working getaddrinfo in an IPv6-only safe way.

-----------------------------------------------------------------------

Summary of changes:
 lib/replace/libreplace_network.m4 |   19 ++++++++++++++++---
 1 files changed, 16 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/lib/replace/libreplace_network.m4 b/lib/replace/libreplace_network.m4
index f9bca40..eadcc6b 100644
--- a/lib/replace/libreplace_network.m4
+++ b/lib/replace/libreplace_network.m4
@@ -240,12 +240,25 @@ if test x"$libreplace_cv_HAVE_GETADDRINFO" = x"yes"; then
 		{
 			struct addrinfo hints = {0,};
 			struct addrinfo *ppres;
-			const char hostname[] = "0.0.0.0";
+			const char hostname1[] = "0.0.0.0";
+			const char hostname2[] = "127.0.0.1";
+			const char hostname3[] = "::";
 			hints.ai_socktype = SOCK_STREAM;
-			hints.ai_family = AF_INET;
+			hints.ai_family = AF_UNSPEC;
 			hints.ai_flags =
 				AI_NUMERICHOST|AI_PASSIVE|AI_ADDRCONFIG;
-			return getaddrinfo(hostname, NULL, &hints, &ppres) != 0 ? 1 : 0;
+			/* Test for broken flag combination on AIX. */
+			if (getaddrinfo(hostname1, NULL, &hints, &ppres) == EAI_BADFLAGS) {
+				/* This fails on an IPv6-only box, but not with
+				   the EAI_BADFLAGS error. */
+				return 1;
+			}
+			if (getaddrinfo(hostname2, NULL, &hints, &ppres) == 0) {
+				/* IPv4 lookup works - good enough. */
+				return 0;
+			}
+			/* Uh-oh, no IPv4. Are we IPv6-only ? */
+			return getaddrinfo(hostname3, NULL, &hints, &ppres) != 0 ? 1 : 0;
 		}],
 		libreplace_cv_HAVE_GETADDRINFO=yes,
 		libreplace_cv_HAVE_GETADDRINFO=no)


-- 
Samba Shared Repository


More information about the samba-cvs mailing list