[SCM] Samba Shared Repository - branch master updated

Günther Deschner gd at samba.org
Fri Mar 25 11:22:02 MDT 2011


The branch, master has been updated
       via  5779460 s3-netapi: fix memoryleak while not using talloc_tos() in cli_get_session_key() usage.
      from  26253e0 s3: Compile IDL files in autogen, some configure tests need this

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 5779460f3ffff0f929d0621b4ea4d1883abb878f
Author: Günther Deschner <gd at samba.org>
Date:   Fri Mar 25 12:13:36 2011 +0100

    s3-netapi: fix memoryleak while not using talloc_tos() in cli_get_session_key() usage.
    
    Thanks Volker!
    
    Guenther
    
    Autobuild-User: Günther Deschner <gd at samba.org>
    Autobuild-Date: Fri Mar 25 18:21:18 CET 2011 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/lib/netapi/joindomain.c |    8 ++++----
 source3/lib/netapi/user.c       |    4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/lib/netapi/joindomain.c b/source3/lib/netapi/joindomain.c
index edc45ef..b6fb57a 100644
--- a/source3/lib/netapi/joindomain.c
+++ b/source3/lib/netapi/joindomain.c
@@ -126,7 +126,7 @@ WERROR NetJoinDomain_r(struct libnetapi_ctx *ctx,
 
 	if (r->in.password) {
 
-		status = cli_get_session_key(ctx, pipe_cli, &session_key);
+		status = cli_get_session_key(talloc_tos(), pipe_cli, &session_key);
 		if (!NT_STATUS_IS_OK(status)) {
 			werr = ntstatus_to_werror(status);
 			goto done;
@@ -267,7 +267,7 @@ WERROR NetUnjoinDomain_r(struct libnetapi_ctx *ctx,
 
 	if (r->in.password) {
 
-		status = cli_get_session_key(ctx, pipe_cli, &session_key);
+		status = cli_get_session_key(talloc_tos(), pipe_cli, &session_key);
 		if (!NT_STATUS_IS_OK(status)) {
 			werr = ntstatus_to_werror(status);
 			goto done;
@@ -465,7 +465,7 @@ WERROR NetGetJoinableOUs_r(struct libnetapi_ctx *ctx,
 
 	if (r->in.password) {
 
-		status = cli_get_session_key(ctx, pipe_cli, &session_key);
+		status = cli_get_session_key(talloc_tos(), pipe_cli, &session_key);
 		if (!NT_STATUS_IS_OK(status)) {
 			werr = ntstatus_to_werror(status);
 			goto done;
@@ -518,7 +518,7 @@ WERROR NetRenameMachineInDomain_r(struct libnetapi_ctx *ctx,
 
 	if (r->in.password) {
 
-		status = cli_get_session_key(ctx, pipe_cli, &session_key);
+		status = cli_get_session_key(talloc_tos(), pipe_cli, &session_key);
 		if (!NT_STATUS_IS_OK(status)) {
 			werr = ntstatus_to_werror(status);
 			goto done;
diff --git a/source3/lib/netapi/user.c b/source3/lib/netapi/user.c
index 29f609d..63be7ac 100644
--- a/source3/lib/netapi/user.c
+++ b/source3/lib/netapi/user.c
@@ -483,7 +483,7 @@ WERROR NetUserAdd_r(struct libnetapi_ctx *ctx,
 		goto done;
 	}
 
-	status = cli_get_session_key(ctx, pipe_cli, &session_key);
+	status = cli_get_session_key(talloc_tos(), pipe_cli, &session_key);
 	if (!NT_STATUS_IS_OK(status)) {
 		werr = ntstatus_to_werror(status);
 		goto done;
@@ -1989,7 +1989,7 @@ WERROR NetUserSetInfo_r(struct libnetapi_ctx *ctx,
 		goto done;
 	}
 
-	status = cli_get_session_key(ctx, pipe_cli, &session_key);
+	status = cli_get_session_key(talloc_tos(), pipe_cli, &session_key);
 	if (!NT_STATUS_IS_OK(status)) {
 		werr = ntstatus_to_werror(status);
 		goto done;


-- 
Samba Shared Repository


More information about the samba-cvs mailing list