[SCM] Samba Shared Repository - branch v3-5-stable updated
Karolin Seeger
kseeger at samba.org
Sun Mar 6 23:07:34 MST 2011
The branch, v3-5-stable has been updated
via 0abd2c0 WHATSNEW: Update release notes for 3.5.8.
via 1d6327b WHATSNEW: Start to list changes since 3.5.7.
via cbfda3a rerun 'make samba3-idl'
via 113eddb librpc/ndr: handle NOALIGN flag for relative pointers and alignment DATA_BLOBs
via b8fbc4e spoolss.idl: align spoolss_DriverFileInfo relative pointer to 4 byte
via 380c409 spoolss.idl: align spoolss_PrinterEnumValues 'data' based on the type
via 50f6396 librpc/ndr: remove align2 hack for relative pointers
via c13d11b librpc: align nstring and nstring_array to 2 byte
via 8c61ff6 librpc/ndr: ndr align relative pointers based on the given flags
via 3047e20 librpc/ndr: let ndr_push/pull_DATA_BLOB() look at LIBNDR_FLAG_REMAINING before LIBNDR_ALIGN_FLAGS
via 2fd1b7c spoolss: pretty-print a struct spoolss_Time.
via cdcc2ba spoolss: fix potential crash bug in spoolss_PrinterEnumValues push path.
via 857b3d6 s3-param: Make "rlimit_max below minimum Windows limit" notification less scary
via 2f810e8 s3:vfs:gpfs: fix logic when gpfs:winattr is false (the default!)
via 5050560 Fix bug 7950 - Samba 3.5.x fails BASE-CREATEX_SHAREMODES_DIR smbtorture4 test We need to revalidate the pathname once re-constructed from a root fsp.
via 37013cb s3-winbindd: let winbind try to use samlogon validation level 6. (bug #7945)
via e4052d4 s3: Prune the printername cache when a printer is deleted.
via 881c24c s3:winbindd: catch lookup_names/sids schannel errors over ncacn_ip_tcp (bug #7944)
via 380c7e8 librpc/rpc: display DCERPC_FAULT_SEC_PKG_ERROR nicely in dcerpc_errstr()
via f23f22b rerun 'make samba3-idl'
via f332775 dcerpc.idl: add DCERPC_FAULT_SEC_PKG_ERROR
via 209d2a8 s3:lib/events: use DLIST_DEMOTE() for fd events
via 90ad8ab s3:smbd: let smbd_server_connection_loop_once() check for select errors
via e03cb16 s3:lib/events: don't loop over fd events is select gave -1
via ada42e5 s3: Fix bug 7940 -- fall back for utimes calls
via 350ad25 s3: Fix connecting to port-139 only servers
via 33a17fe Revert "s3-printing: update parent smbd pcap cache"
via de86bbb Revert "s3-printing: reload shares after pcap cache fill"
via 100547c s3: Fix bug 7917: Yet another bug in chain_reply
via bdeb19f s3-rpcclient: Fix bug #7880: cmd_spoolss_deletedriver() returned without checking all architectures.
via 88bf55f s3-printing: update parent smbd pcap cache
via 99772e1 s3-printing: reload shares after pcap cache fill
via 666e1fb s3-spoolss: Fix Bug #7641: handle win9x adddriver calls w/o config file.
via ca76cca s3-dns Don't use DELEG_FLAG in DNS update, Windows 2008R2 does not like it (cherry picked from commit 280caa6b3bb1199939f9349ea5a436a491c81791)
via 1847108 s3-dns Don't use SEQUENCE_FLAG in DNS update, Windows 2008R2 does not like it
via 3c4e495 s3:net_rpc_vampire_keytab: don't return -1 on success (bug #7899)
via 887aee0 s3-nmbd: Fix bug #7875
via d700f40 s3:lib/netapi: don't set SAMR_FIELD_FULL_NAME if we just want to set the account name (bug #7896)
via a40be16 s3:libsmb: use 16 zero bytes as channel binding checksum in the gssapi checksum (bug #7883)
via 009bb81 s3-krb5 Fix Kerberos on FreeBSD with Samba4 DCs
via 1075bc3 s3: Fix a memleak in receive_getdc_response
via e1bf4fd Fix a valgrind error
via d7eb70a s3: Fix bug 7066 -- wbcAuthenticateEx gives unix times
via 346b638 s3: Fix another aspect of bug 7262
via 992c97c Ñ•3/configue: set Tru64 cc's PIC switch right (none)
via d477e3a s3:winbind: fix bug #7894 - sporadic winbind panic in rpc query_user_list
via f5477f6 Fix bug #7892 - open_file_fchmod() leaves a stale lock. (cherry picked from commit 8d9ef26538a29ab9f5b0a3179c28beecab1a099a)
via ffd38c0 s3: Use smbsock_any_connect in winbind
via 8334b1d s3: Retry *SMBSERVER in nb_connect (cherry picked from commit 6e9e567dfeb860c8b9a342bf46765f8c9b8ea7db)
via 33a9b4f s3: Add smbsock_any_connect (cherry picked from commit b289052828eb03b8c353b85691ce6af6aef6bf41)
via 6d3ff3b s3: Add an async smbsock_connect
via 81333e1 v3-5-test: Pull in tevent_req_poll_ntstatus from master (cherry picked from commit 0b13028cb4d6fc2ff267df477b5c2c4291286a43)
via 7357728 s3: Add async cli_session_request
via a9c8cc0 s3: Add some const to name_mangle() (cherry picked from commit 1552acea9a55dd6bc5f386a5f424e09875ed463c)
via 65201da s3:net ads dns register: use "cluster addresses" option if configured (bug #7871)
via 47e45c5 s3:net ads dns register: add support for specifying addresse on the commandline (bug #7871)
via 0868727 s3:net: add net_update_dns_ext() that accepts a list of addresses as parameter (bug# 7871)
via dbc58fe s3:net: disable dynamic dns updates at the end of "net ads join" in a cluster (bug #7871)
via 95a59f0 s3-net Allow 'net ads dns register' to take an optional hostname argument
via 1ad454d s3:ntlm_auth: support clients which offer a spnego mechs we don't support (bug #7855)
via faf8371 s3:ntlm_auth: free session key, as we don't use it (at least for now)
via 8177c59 s3:ntlm_auth: fix memory leak in the raw ntlmssp code path
via c642910 s3: Correctly unwrap the krb ticket in gss-spnego (cherry picked from commit 547b268cfaa2e791bf92e8804bfa504c4e37050b)
via 9bce549 s3: Fall back to raw NTLMSSP for the gss-spnego protocol
via fdfef32 s3: Split off output generation from manage_squid_ntlmssp_request (cherry picked from commit de2c143f4d540f695db5c7fe8685614c03977365)
via 9244295 s3: Wrap the ntlm_auth loop with a talloc_stackframe (cherry picked from commit ae483bbe9af526623189cefe7735f3f2813da6d7)
via c838f2c s3: Fix some debug msgs in ntlm_auth (cherry picked from commit 6400f3ee62108e3dd1e6c1013ccea9fb4b08d562)
via a63c27a ntlm_auth: Fix a valgrind error (cherry picked from commit 69db4b4ccf051b05517e6eb9039ab48f90608075)
via 24693c1 Fix bso#3185, return false when EOF is encountered in param name. (cherry picked from commit a9664633c667f6d02f33b951805882258604ff1c)
via b781312 s3: Fix bug 7843: Expand the local SAMs aliases (cherry picked from commit 50c8b426385df953d2e3748a39041d4b92cd7ed9)
via bbbcfa9 s3: Fix bug 7842: WINBINDD_LOOKUPRIDS does not return the domain name (cherry picked from commit 0737a34a12e46d53e4332ea06eac0ba948608fff)
via cd2f806 s3: Fix bug 7841: WINBINDD_LOOKUPRIDS asks the wrong domain (cherry picked from commit a257253f8f82bcab52508273b12cd92fadd3ba1a)
via 6fa4b9d Fix bug #7835 - vfs_fill_sparse() doesn't use posix_fallocate when strict allocate is on
via a0b4734 s3: Fix "force group" with ntlmssp guest session setup
via 3d0959b s3: Make winbind recover from a signing error
via cc3a366 switch from mtime to ctime which is more reliable if files can be accessed outside samba as well
via 23dfe81 Fix bug #7812 - vfs_acl_xattr/vfs_acl_tdb: ACL inheritance cannot be disabled
via aa79770 Fix our privileges code to display privileges with the "high" 32-bit value set.
via 5c75572 Add SeSecurityPrivilige.
via e91b5ab Ensure we have correct parameters to use Windows ACL modules. (cherry picked from commit 117d14f108cded28ac2868d5040f633856cca923)
via 5d762df Add acl_xattr:ignore system acls boolean (normally false) to allow Samba ACL module to ignore mapping to lower POSIX layer. With this fix Samba 3.6.x now passes RAW-ACLs (with certain smb.conf parameters set).
via 9268e60 Add make_default_filesystem_acl() function to be used in following change to acl_xattr and acl_tdb module. (cherry picked from commit 2d84fce8f20c4eac70b02f0fc4333b15e278edfc)
via 17d265d Fix handling of "NULL" DACL. Map to u/g/w - rwx. (cherry picked from commit 84b2a3d013390c01ef27d10085a0bf10137c857f)
via a1ef65b Fix "force unknown ACL user" to strip out foreign SIDs from POSIX ACLs if they can't be mapped. (cherry picked from commit 3fcceb6c5ae55f5e3a66f71e44b5caa665596832)
via ad3c0b7 Add debug message to get_nt_acl_internal() to see what we got. (cherry picked from commit 514e3e786f999979f9fd85a9c08de9e06e50938b)
via 961afdd Fix valgrind "uninitialized read" error on "info" when returning !NT_STATUS_OK. (cherry picked from commit 9b615ce8706f4f4c59055fe155446f1fdac36323)
via 1f40a8e Fix bug #7734 - When creating files with "inherit ACLs" set to true, we neglect to apply appropriate create masks.
via 4596132 Fix bug #7733 - Invalid client DOS attributes on create can cause incorrect unix mode_t to be generated.
via 56628b0 Make the vfs_acl_xattr and other modules work with NULL SD's. Fix the "protected" inheritance problem (bleeding up from the POSIX layer).
via 46e4596 Canonicalize incoming and outgoing ACLs.
via 8b85046 Make the posix ACL module cope with a NULL incoming DACL and a missing owner/group.
via 2c885d6 Fix bug #7785 - atime limit.
via ae1b77e s3-docs: Update 3.2 features. (cherry picked from commit aa54713615c5d0367528733ff2c3a5650eed96f7) (cherry picked from commit 55754e2c1f620eee662319a0bcb89f8620014d56)
via 48d41b4 Fix bug #7791 - gvfsd-smb (Gnome vfs) fails to copy files from a SMB share using SMB signing.
via 8af8764 Second part of fix for bug #7777 - When requesting lookups for BUILTIN sids, winbindd allocates new uids/gids in error.
via 5cbd095 First part of fix for bug #7777 - When requesting lookups for BUILTIN sids, winbindd allocates new uids/gids in error.
via 8405769 s3: Fix bug 7779, crash in expand_msdfs (cherry picked from commit 82e15a5ee335ac87ab473899b333056a02bf15b3)
via 5daed7f s3: Fix a getgrent crash with many groups
via f1fa394 Fix bug #7744 - "dfree cache time" doesn't work.
via d82d334 Fix bug #7743 - Inconsistent use of system name lookup can cause a domain joined machine to fail to find users.
via b2b9b99 s3: Fix bug 7730 -- crash in winbindd_dsgetdcname.c (cherry picked from commit f1b04a210074546d4e4347b62b4f7f5b879454d9)
via 091d0a0 Fix bug 7716 - acl_xattr and acl_tdb modules don't store unmodified copies of security descriptors.
via 2f7bcbc s3: Attempt to fix bug 7665
via 43bbd23 s3:librpc/ndr: use new strlen_m_ext_term() in ndr_charset_length(): fix bug #7594
via 3065a29 librpc/ndr: correctly implement ndr_charset_length()
via 43e78d0 s3:lib/util_str: add strlen_m_ext_term() - variant of strlen_m_ext() counting terminator (cherry picked from commit f7928a0e0b2be27e83bf26644c45ac554c5acec2)
via b873b8b s3:lib/util_str: add strlen_m_ext() that takes the dest charset as a parameter. (cherry picked from commit 054cd7ec30a3289443c97d36ea416d37f19d6b0b)
via 4d06efb Fix bug 7409 - Thousands of reduce_name: couldn't get realpath.
from 6964fc5 WHATSNEW: Start release notes for 3.5.8.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-stable
- Log -----------------------------------------------------------------
commit 0abd2c034d1c3f437d5c656a06fe50fbd8428ce3
Author: Karolin Seeger <kseeger at samba.org>
Date: Sat Mar 5 22:14:43 2011 +0100
WHATSNEW: Update release notes for 3.5.8.
Karolin
(cherry picked from commit fca681fede6d4b8b28490f58b5c3727f6c699e1a)
commit 1d6327b25261fb3ec5cb12696bf42dffceef5f29
Author: Karolin Seeger <kseeger at samba.org>
Date: Sat Mar 5 15:24:10 2011 +0100
WHATSNEW: Start to list changes since 3.5.7.
Karolin
(cherry picked from commit 7c7742e589c7ed0f618eb8a1ad64e26715da34b4)
commit cbfda3a086e27b6efa7db6ab1d41ef96fe04d171
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Mar 2 10:14:54 2011 +0100
rerun 'make samba3-idl'
metze
The last 10 patches address bug #7567 (printing from Windows 7 fails with
0x000003e6 (in AD w2k8r2 controlled domain)).
(cherry picked from commit c81256b04ead01f0d44c8a235d2ac793b7a51364)
commit 113eddb2aef31d80a2ce7bab2f754add89015e71
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Mar 1 14:20:32 2011 +0100
librpc/ndr: handle NOALIGN flag for relative pointers and alignment DATA_BLOBs
metze
Autobuild-User: Stefan Metzmacher <metze at samba.org>
Autobuild-Date: Tue Mar 1 17:11:03 CET 2011 on sn-devel-104
(cherry picked from commit ef224aa004d5f1726d8dca020e0ef96d8c58565e)
(cherry picked from commit 1ea17bacdb09d28a12a8b6ddeba3ac285cd9f905)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 7c6bc031b3af3643027865e444fb16f7bb7c7152)
commit b8fbc4eff64d4ec5dec0bbfd055f8b3a6851b9f0
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Feb 22 15:56:30 2011 +0100
spoolss.idl: align spoolss_DriverFileInfo relative pointer to 4 byte
metze
(cherry picked from commit b6ece01c7922adeb3c9e718bc8cc610cae7c543c)
(cherry picked from commit ba1a72cb153892e491af91a6bb61e1820135fa12)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 25f93fe17a396f9c0372dd5d1f4210ecfce7ded9)
commit 380c40986d029d21e9965f582a0ba3085262466c
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Feb 22 19:23:33 2011 +0100
spoolss.idl: align spoolss_PrinterEnumValues 'data' based on the type
metze
(cherry picked from commit 341330600aebcec92fba64ea343888c15a0c3d44)
(cherry picked from commit 757471a5fcd4f95da28402bae6c9ceccff7d6548)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 3cb71012a2cf26037323cded8cfd9ec5d12223c6)
commit 50f639635ceda021efd129d8ea1ecaba4c985f4c
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Feb 22 15:58:45 2011 +0100
librpc/ndr: remove align2 hack for relative pointers
metze
(cherry picked from commit 23f6f449792d889538e0d0028bb8fbd5c807b0da)
(cherry picked from commit 9313b5d1da24406dd7d26afb2488fee0cbea44a9)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 1757dee05942add03edb51163bead807d839fcf6)
commit c13d11b336141800db85667e53877ae689583417
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Feb 22 15:57:21 2011 +0100
librpc: align nstring and nstring_array to 2 byte
metze
(cherry picked from commit 712ef2590d0ee59a4a659926cdf8aac6e968dfa8)
(cherry picked from commit 0fb64a26b3b35b75f2f548d882bed41aa0386c6b)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit c26be77576e13582c7d51fe84f4c69f1c1abf28d)
commit 8c61ff6c55fef5f5b2c256503bbde07c6365a805
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Feb 22 15:45:44 2011 +0100
librpc/ndr: ndr align relative pointers based on the given flags
We used to do this only for the reverse relative pointers
and now we always do it.
metze
(cherry picked from commit 84b884eb4bec38b721d6c38704f12d1d2c601bcb)
(cherry picked from commit 6648ce8990a97da739d4be69657e9ace6198068c)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 490d1553714ffc5afe0e49c3473e19697bdfbd53)
commit 3047e20d3b0ac89afdad3fda741f948b03e2ffdc
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Feb 22 18:19:13 2011 +0100
librpc/ndr: let ndr_push/pull_DATA_BLOB() look at LIBNDR_FLAG_REMAINING before LIBNDR_ALIGN_FLAGS
metze
(cherry picked from commit 6c3a49ced333988b21d86e47b2b1dd1a5957e15c)
(cherry picked from commit 5f8b7f95e9ce5946f048b242dbbaa14897aea919)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit eab30c15b2528d92e09b774be453e657020e5aa7)
commit 2fd1b7cb9d7908dcb02e7405a8e532fd9a9738b0
Author: Günther Deschner <gd at samba.org>
Date: Thu Apr 22 11:42:45 2010 +0200
spoolss: pretty-print a struct spoolss_Time.
Guenther
(cherry picked from commit 440075247d11a7852d8567753f426fa67f41d875)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 0396087c36652b6c3d2bf4206212c2823352f9e0)
commit cdcc2ba83c2e4a1f5ca5da870dc673e7e2507d23
Author: Günther Deschner <gd at samba.org>
Date: Mon Aug 2 15:52:09 2010 +0200
spoolss: fix potential crash bug in spoolss_PrinterEnumValues push path.
Guenther
(cherry picked from commit 45952b56797982d27731b20d97f5648c9414814a)
(cherry picked from commit ad68e45b505331683a2510de20f113a7c20e68e1)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 5a660f3f15e1e04d556b34b9e49e7177193df026)
commit 857b3d60ef33a598fbaf5727001aaf0f2fded9a7
Author: Jonathan Nieder <jrnieder at gmail.com>
Date: Sun Jan 2 02:40:09 2011 -0600
s3-param: Make "rlimit_max below minimum Windows limit" notification less scary
The fix to bug #6837 results in messages from testparm that look
like a misconfiguration even though they aren't:
rlimit_max: rlimit_max (8192) below minimum Windows limit (16384)
Apply a slight change in wording ("increasing rlimit_max to minimum
Windows limit") to make it clearer that the user has done nothing
wrong. (Similarly for sysctl_max.)
Reported-by: Miguel Medalha <miguelmedalha at sapo.pt>
Signed-off-by: Jonathan Nieder <jrnieder at gmail.com>
(cherry picked from commit 5d525ea0ed937e4146dee0859d0218ef730bfa27)
commit 2f810e81944f0eebfb30a64523971c1f0ec29633
Author: Rusty Russell <rusty at rustcorp.com.au>
Date: Fri Nov 20 10:39:57 2009 +0100
s3:vfs:gpfs: fix logic when gpfs:winattr is false (the default!)
On my autocluster setup, it's not set. Maybe it should be? Otherwise
smbclient and some Windows client programs will get errors like:
# smbclient //localhost/data -Uadministrator%XXX
Domain=[VSOFS1] OS=[Unix] Server=[Samba 3.4.2-ctdb-10]
smb: \> put /etc/resolv.conf resolv.conf
NT_STATUS_ACCESS_DENIED closing remote file \resolv.conf
smb: \>
Caused by attempting to update the time on close.
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
Signed-off-by: Michael Adam <obnox at samba.org>
(cherry picked from commit 385d925f7e0fedca7d480e4f25d89e3194433b88)
Fix bug #7498 (robocopy fails to a GPFS share when setting the date).
(cherry picked from commit fd6af89cb86c7ffb99ba4de986d932ec58182c81)
commit 505056084568429cc32f69099f1d478430c487ff
Author: Jeremy Allison <jra at samba.org>
Date: Wed Feb 23 18:24:41 2011 -0800
Fix bug 7950 - Samba 3.5.x fails BASE-CREATEX_SHAREMODES_DIR smbtorture4 test
We need to revalidate the pathname once re-constructed from a root fsp.
Jeremy.
(cherry picked from commit 916e82823b56a70d7761644b38a250ea8c38e204)
(cherry picked from commit 203b4aa318ce2aa64812006ed94a1e4e1becf66f)
commit 37013cbaf192057943764eb9b57369a45b76d099
Author: Günther Deschner <gd at samba.org>
Date: Fri Jan 7 17:28:29 2011 +0100
s3-winbindd: let winbind try to use samlogon validation level 6. (bug #7945)
The benefit of this that it makes us more robust to secure channel resets
triggered from tools outside the winbind process. Long term we need to have a
shared tdb secure channel store though as well.
Guenther
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(similar to commit f60398d7b20869d7b09d81854f3727fdcd897430)
(similar to commit 7add712498fe93603b1bffff2c633e097ce8fbdf)
(cherry picked from commit a5b388fc5ea81868f09590e8b7674826315c348c)
commit e4052d461acb395c59fa74f34e679dcf51288e39
Author: Volker Lendecke <vl at samba.org>
Date: Mon Sep 6 20:58:45 2010 -0700
s3: Prune the printername cache when a printer is deleted.
Signed-off-by: Andreas Schneider <asn at samba.org>
Fix bug #7656 (Scalability problem with hundreds of printers).
(cherry picked from commit f0e39788d88c4e29d9724288565241c71b860bb2)
commit 881c24cd95971fce462a681948c648dd82a2e796
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Feb 1 18:46:57 2011 +0100
s3:winbindd: catch lookup_names/sids schannel errors over ncacn_ip_tcp (bug #7944)
If winbindd connects to a domain controller it doesn't establish the lsa
connection over ncacn_ip_tcp direct. This happens only on demand.
If someone does a 'net rpc testjoin' and then a
wbinfo -n DOMAIN\\administrator, we'll get DCERPC faults with
ACCESS_DENIED/SEC_PKG_ERROR, because winbindd's in memory copy
of the schannel session key is invalidated.
This problem can also happen on other calls, but the
lookup_names/sids calls on thet lsa ncacn_ip_tcp connection
are the most important ones.
The long term fix is to store the schannel client state in a
tdb, but for now it's enough to catch the error and invalidate
the all connections to the dc and reestablish the schannel
session key.
The fix for bug 7568 (commit be396411a4e1f3a174f8a44b6c062d834135e70a)
made this worse, as it assumes winbindd's in memory session key is
always the current one.
metze
(cherry picked from commit 255f2e06991aa543cd2c6f4d0123664b2a76c99d)
(cherry picked from commit a699ac50f7c9a5eeb57215879e17631c9a1f534f)
(cherry picked from commit b40ce0559c6da04f269cb9ac4d4a215ea8e9f925)
commit 380c7e8826b41c3f3fadcd416976e07d1841c2a1
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 2 14:18:33 2011 +0100
librpc/rpc: display DCERPC_FAULT_SEC_PKG_ERROR nicely in dcerpc_errstr()
metze
(cherry picked from commit ab492152e86220600429d0bc85a3783463889cee)
commit f23f22ba75ed6ca804f03227fcdaeb41f366a86e
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Feb 2 14:20:58 2011 +0100
rerun 'make samba3-idl'
metze
(cherry picked from commit 782726a5161da3ad1369dc63e13956a3faad4980)
commit f332775a0fdf446ed606e7444b5d616ac7bfb697
Author: Stefan Metzmacher <metze at samba.org>
Date: Sun Jan 30 17:34:11 2011 +0100
dcerpc.idl: add DCERPC_FAULT_SEC_PKG_ERROR
metze
(cherry picked from commit 8d07deaeaacbd376f9824ac350c01510e05a76ca)
(cherry picked from commit 85358c0534472fde71e304ddada678b61637ba40)
(cherry picked from commit 80b95a13dd7c0ef57e079b370b80993326bc616d)
commit 209d2a8706ea5ef159c7015ec151c4701cd0f0ca
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Jan 24 08:47:12 2011 +0100
s3:lib/events: use DLIST_DEMOTE() for fd events
This makes sure that fd events doesn't dry out,
because a fd with a lower number is busy.
metze
The last 3 patches address bug #7942 (inotify can somehow cause endless loops in
with select()).
Autobuild-User: Stefan Metzmacher <metze at samba.org>
Autobuild-Date: Mon Jan 31 16:59:44 CET 2011 on sn-devel-104
(cherry picked from commit ad10289ebcc78ab62ec86abb29f81eb769d17f4e)
(cherry picked from commit 3d2f72844a221dbdfe94fbf6e2b45c98ee158a9b)
(cherry picked from commit 44a2e73cf07110e463f2262c50a377bdf17253d6)
commit 90ad8ab384196cc9351bdcbe8e9cdf8efc3b1fec
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Jan 24 09:00:53 2011 +0100
s3:smbd: let smbd_server_connection_loop_once() check for select errors
metze
(cherry picked from commit 0bbe7334d69bcaa476f0741e0bd9685b023a4208)
(cherry picked from commit d677921237c66e6cdf83de04e16c576a101d6493)
(cherry picked from commit 8a82e65f711e2f4ac893bd7e2365b305e1b088b8)
commit e03cb16fd4488b7960f285b8af6cf41568f4d6c9
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Jan 24 08:57:47 2011 +0100
s3:lib/events: don't loop over fd events is select gave -1
metze
(cherry picked from commit 1f2be10ebf4cc06e3b7aac41ea35bfc4a41ce828)
(cherry picked from commit d506b574bb94fdc23c5a62c5326cd478b5b63a11)
(cherry picked from commit 6647d687654aff806dfa8d797634b47ede36bf9c)
commit ada42e58dadd74d7b38f2f3a87e45c0664a468aa
Author: Volker Lendecke <vl at samba.org>
Date: Sat Jan 29 10:59:14 2011 +0100
s3: Fix bug 7940 -- fall back for utimes calls
There are systems where ./configure has detected advanced utimes calls which
are then not available on other kernels. We should do a proper fallback.
(cherry picked from commit a50a0f438a928db9c2f25c779186611e40b2a960)
commit 350ad25db6ed3af91339e336e6a6dafe580fa54f
Author: Volker Lendecke <vl at samba.org>
Date: Sat Jan 22 16:22:42 2011 +0100
s3: Fix connecting to port-139 only servers
When the TCP RST came before the 5 msecs timeout kicked in, we
viewed this as final, as state->req_139 was not set yet.
Fix bug introduced by a fix for bug #7881 (winbind flaky against w2k8).
(cherry picked from commit f2a19b87725f9318e983dff6358a3eee721bff08)
commit 33a17fe21ba9bed23c48b6f9e6c173997cb5917b
Author: Karolin Seeger <kseeger at samba.org>
Date: Sat Jan 15 19:19:43 2011 +0100
Revert "s3-printing: update parent smbd pcap cache"
This reverts commit 5a2b2d4aeb6fe4af13aa0c92d22ba5bc9b7f7e13.
(cherry picked from commit b6268f507fa3276c2ef22c58bad400a3fed48cd9)
commit de86bbbe530a3f15c07d2ae51677c57fe7afa6c4
Author: Karolin Seeger <kseeger at samba.org>
Date: Sat Jan 15 19:19:13 2011 +0100
Revert "s3-printing: reload shares after pcap cache fill"
This reverts commit a8a01e4a3dcafd97372021d0d6f859fd3a69235f.
This commit seems to break 'make test'.
(cherry picked from commit e4579eab7fe3eab7a5209e6de74e6fd2f53099d0)
commit 100547cddf941353a7df2aa3df7e54d3c00a5d74
Author: Volker Lendecke <vl at samba.org>
Date: Fri Jan 14 16:43:00 2011 +0100
s3: Fix bug 7917: Yet another bug in chain_reply
Found by Michael Hanscho <samba at micha.priv.at> with a WinCE client.
(cherry picked from commit 8917d84130991ed24767f21876b18ac82b246d87)
commit bdeb19f32523353e4f03ac8e9e5098ccfabeb642
Author: Björn Baumbach <bb at sernet.de>
Date: Wed Dec 22 15:20:29 2010 +0100
s3-rpcclient: Fix bug #7880: cmd_spoolss_deletedriver() returned without checking all architectures.
Continues now with next architecture if no driver is available.
Because of the broken behavior of the rpccli_*() functions,
we need special error code handling.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit f5af66e67d7c6d62315671c0cf57f47973316226)
(cherry picked from commit dc63f45b523deb5c3d0c4be4239507e5fc4f6a40)
commit 88bf55f4949d116e8c78583a052aa72870f9b4f1
Author: David Disseldorp <ddiss at suse.de>
Date: Mon Jan 10 14:08:07 2011 +0100
s3-printing: update parent smbd pcap cache
If a client connects to a samba share and while connected a printer is
added, the client will see the new printer share after a maximum of
'printcap cache time' seconds.
smbd's forked for new client connections inherit printcap information
from the parent (listener) smbd, which does not perform updates on
printcap cache time expiry. Therefore newly connected clients may
initially be presented with stale printer shares.
Add a housekeeping function to the parent smbd to ensure newly connected
clients see up to date printer shares.
The last 2 patches address bug #7836 (A newly added printer isn't visbile to
clients).
(cherry picked from commit 5a2b2d4aeb6fe4af13aa0c92d22ba5bc9b7f7e13)
commit 99772e1e3e6af29ec597369d3ae8ccdca257ae3a
Author: David Disseldorp <ddiss at suse.de>
Date: Sun Dec 19 19:52:08 2010 +0100
s3-printing: reload shares after pcap cache fill
Since commit eada8f8a, updates to the cups pcap cache are performed
asynchronously - cups_cache_reload() forks a child process to request
cups printer information and notify the parent smbd on completion.
Currently printer shares are reloaded immediately following the call to
cups_cache_reload(), this occurs prior to smbd receiving new cups pcap
information from the child process. Such behaviour can result in stale
print shares as outlined in bug 7836.
This fix ensures print shares are only reloaded after new pcap data has
been received.
Pair-Programmed-With: Lars Müller <lars at samba.org>
(cherry picked from commit a8a01e4a3dcafd97372021d0d6f859fd3a69235f)
commit 666e1fb9915b0b4304862fd737d64464076f6ba6
Author: Günther Deschner <gd at samba.org>
Date: Mon Nov 29 17:56:40 2010 +0100
s3-spoolss: Fix Bug #7641: handle win9x adddriver calls w/o config file.
This turned cupsaddsmb to run into an infinite loop.
Guenther
(cherry picked from commit c62509c8f2589e7b952517626d61ee34b83e96b3)
(cherry picked from commit 0a0f3b4947689ca4ab7015e9a1ace8d204bab9f3)
(cherry picked from commit b57378b3663fb796ed07c2a8c30f9bda27d3aa9c)
commit ca76cca026e02dc08de72e3356a8b67f13eabed0
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Dec 10 15:32:08 2010 +1100
s3-dns Don't use DELEG_FLAG in DNS update, Windows 2008R2 does not like it (cherry picked from commit 280caa6b3bb1199939f9349ea5a436a491c81791)
The last 2 patches address bug #7356 (net ads dns register fails in 2008 R2
domain).
(cherry picked from commit 6857b749229cc72c604ab5646a4bae5f09b72e11)
commit 1847108a35b1dd03f6dc89cb8055336891fc7d76
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Dec 10 15:30:22 2010 +1100
s3-dns Don't use SEQUENCE_FLAG in DNS update, Windows 2008R2 does not like it
Andrew Bartlett
(cherry picked from commit 0f1cc889a26477e9a98629f120fe5890b2e106fa)
(cherry picked from commit 2b463484cc7bb80cdfb6727ab9e5a873faff5ec8)
commit 3c4e4959aec276c3fb189ab540f8da9b9dc246f3
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Jan 3 16:58:56 2011 +0100
s3:net_rpc_vampire_keytab: don't return -1 on success (bug #7899)
metze
Autobuild-User: Stefan Metzmacher <metze at samba.org>
Autobuild-Date: Mon Jan 3 19:05:11 CET 2011 on sn-devel-104
(cherry picked from commit ddbbc7b12ae8e51bc9658e3356bbeefe314f55bb)
(cherry picked from commit 32d111bef6d38bc3f946e68f133d37e1f1cc25bc)
(cherry picked from commit 86e72cb783fe74fd1504b111f615b71d4260e74e)
commit 887aee0d11b157a2dc7a3ce9bfc34cb6794a450d
Author: Björn Baumbach <bb at sernet.de>
Date: Fri Jan 7 15:53:13 2011 +0100
s3-nmbd: Fix bug #7875
nmbd --port didn't work
(cherry picked from commit 79280c99f67c3a3bfb1873b373ec181fa402f18c)
commit d700f40e7220cc5b1ccc37c7476bfd42b502ceba
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Dec 29 12:08:19 2010 +0100
s3:lib/netapi: don't set SAMR_FIELD_FULL_NAME if we just want to set the account name (bug #7896)
metze
Autobuild-User: Stefan Metzmacher <metze at samba.org>
Autobuild-Date: Thu Dec 30 18:09:13 CET 2010 on sn-devel-104
(cherry picked from commit f1d15ea54c313e71fc032b2ed191bdecad868858)
(cherry picked from commit c6a0971b3790253a906b370562237479d273bb94)
commit a40be169f3b07b5f3fc72d066b21d96e26bdf58a
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Dec 23 08:17:48 2010 +0100
s3:libsmb: use 16 zero bytes as channel binding checksum in the gssapi checksum (bug #7883)
This fixes SMB session setups with kerberos against some closed
source SMB servers.
The new behavior matches heimdal and mit.
metze
Autobuild-User: Stefan Metzmacher <metze at samba.org>
Autobuild-Date: Thu Dec 23 09:38:43 CET 2010 on sn-devel-104
(cherry picked from commit e9dddc55e324c62973e6a561477b532cf9ed79af)
(cherry picked from commit 3356192af5d36fbe986c4728162d10fe883ba2fd)
(cherry picked from commit 3d9dd75e811eb251002b7c1b958f58790a089086)
commit 009bb8128981965995eff6088a74a195c05f40f8
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Sep 11 16:13:33 2010 +1000
s3-krb5 Fix Kerberos on FreeBSD with Samba4 DCs
The idea of this patch is: Don't support a mix of different kerberos
features.
Either we should prepare a GSSAPI (8003) checksum and mark the request as
such, or we should use the old behaviour (a normal kerberos checksum of 0 data).
Sending the GSSAPI checksum data, but without marking it as GSSAPI broke
Samba4, and seems well outside the expected behaviour, even if Windows accepts it.
Andrew Bartlett
(cherry picked from commit 3b4db34011f06fb785153fa9070fb1da9d8f5c78)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit b31c9cf18a5bd592912bd300e028d0798e93978d)
commit 1075bc3a92d282c9ce61b5f6e773a505e598d1f6
Author: Volker Lendecke <vl at samba.org>
Date: Sun Jan 2 07:42:57 2011 +0100
s3: Fix a memleak in receive_getdc_response
The last 2 patches addresbug #7879 (Memory problems in winbind).
(cherry picked from commit bba197b7ee6efbb6d271e6e60e53ae1632330086)
commit e1bf4fda6afd6d002c4741252e90ffed4b0faf66
Author: Volker Lendecke <vl at samba.org>
Date: Sun Jan 2 02:48:03 2011 +0100
Fix a valgrind error
Thanks to Tridge for the hint.
Autobuild-User: Volker Lendecke <vlendec at samba.org>
Autobuild-Date: Sun Jan 2 10:58:51 CET 2011 on sn-devel-104
(cherry picked from commit 23693fe3c51ac89db64fefed292f7e4ff38e00e8)
commit d7eb70adaccabf0d5c4f095ccadec87e86bee4e7
Author: Volker Lendecke <vl at samba.org>
Date: Sat Dec 18 16:02:09 2010 +0100
s3: Fix bug 7066 -- wbcAuthenticateEx gives unix times
We might eventually want to change this, but right now we get unix times
out of the winbind pipe struct
(cherry picked from commit 993923880e213136de89b5b8d59f6f32a51b94b7)
commit 346b6384b15080fc97fa3426e861c6b2bdfbe1d7
Author: Volker Lendecke <vl at samba.org>
Date: Tue Jul 6 16:55:14 2010 +0200
s3: Fix another aspect of bug 7262
(Unable to maintain users' groups via UsrMgr)
(cherry picked from commit 9b1d0d409824cff275aaf9563eaa3ed77ccf8466)
commit 992c97cbc98afa0fd1502d1cdd4261e3b446e6f5
Author: Björn Jacke <bj at sernet.de>
Date: Fri Nov 26 01:32:53 2010 +0100
Ñ•3/configue: set Tru64 cc's PIC switch right (none)
-fPIC made shared library builds fail there
Fixes #7821
(cherry picked from commit dbcf73c45782c310cb7ff1f2177d410399e2f06d)
(cherry picked from commit 83eb2e9aef40e5e838d2654298e281ad3ec98af3)
commit d477e3a807e44acafb16c8bf41bf3a40c9e5c1bd
Author: Michael Adam <obnox at samba.org>
Date: Thu Dec 30 11:12:42 2010 +0100
s3:winbind: fix bug #7894 - sporadic winbind panic in rpc query_user_list
correctly evaluate return code of rpccli_samr_QueryDisplayInfo()
before accessing results.
(cherry picked from commit bdebae14aa646dd9f969db5b3d1aa25c971c9381)
commit f5477f6fdc126ccad178dc4b0158d701144077c3
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 28 17:24:27 2010 -0800
Fix bug #7892 - open_file_fchmod() leaves a stale lock.
(cherry picked from commit 8d9ef26538a29ab9f5b0a3179c28beecab1a099a)
commit ffd38c02107c9b59261e6c92e73080824c968d5a
Author: Volker Lendecke <vl at samba.org>
Date: Tue Dec 21 21:55:01 2010 +0100
s3: Use smbsock_any_connect in winbind
The last 7 patches address bug #7881 (winbind flaky against w2k8).
(cherry picked from commit 969f452de253cd8dbe6f4448168eaa11baed1fbc)
commit 8334b1dfac04fddc3fd56b60a7ea79d872cb48b2
Author: Volker Lendecke <vl at samba.org>
Date: Tue Dec 21 18:52:53 2010 +0100
s3: Retry *SMBSERVER in nb_connect
(cherry picked from commit 6e9e567dfeb860c8b9a342bf46765f8c9b8ea7db)
commit 33a9b4ff5992b949e79d2f6b004cb5e1e5b64584
Author: Volker Lendecke <vl at samba.org>
Date: Mon Dec 13 17:17:51 2010 +0100
s3: Add smbsock_any_connect
(cherry picked from commit b289052828eb03b8c353b85691ce6af6aef6bf41)
commit 6d3ff3bb143f07ed4a1ac237dbdde40bd4006e7a
Author: Volker Lendecke <vl at samba.org>
Date: Sun Dec 12 18:55:06 2010 +0100
s3: Add an async smbsock_connect
This connects to 445 and after 5 milliseconds also to 139. It treats a netbios
session setup failure as equivalent as a TCP connect failure. So if 139 is
faster but fails the nb session setup, the 445 still has the chance to succeed.
(cherry picked from commit 8b6b80ef591031ea6e394cebd6e0fdf8c7b8485a)
commit 81333e1b9d67f58c05f44343a754376a0b5f4607
Author: Volker Lendecke <vl at samba.org>
Date: Wed Dec 22 15:21:27 2010 +0100
v3-5-test: Pull in tevent_req_poll_ntstatus from master
(cherry picked from commit 0b13028cb4d6fc2ff267df477b5c2c4291286a43)
commit 73577282c23f5e5bab18f2b215d419daadbfaf80
Author: Volker Lendecke <vl at samba.org>
Date: Sun Dec 12 18:54:31 2010 +0100
s3: Add async cli_session_request
This does not do the redirects, but I think that might be obsolete anyway
(cherry picked from commit a30258cf98ff334a786ea1566b607208d82617a0)
commit a9c8cc098bca9abd45fb0aebdd4162075f2331f0
Author: Volker Lendecke <vl at samba.org>
Date: Sun Dec 12 18:53:49 2010 +0100
s3: Add some const to name_mangle()
(cherry picked from commit 1552acea9a55dd6bc5f386a5f424e09875ed463c)
commit 65201dafba8ef5abdb8b662158156b94c98da574
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Dec 16 12:07:24 2010 +0100
s3:net ads dns register: use "cluster addresses" option if configured (bug #7871)
metze
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User: Stefan Metzmacher <metze at samba.org>
Autobuild-Date: Fri Dec 17 16:49:14 CET 2010 on sn-devel-104
(cherry picked from commit 1dc2fa7616207a2d3a9f1cbe69b2ec1fc61634fd)
(cherry picked from commit 9a40e5f6a500571cc752383ca7fa27347e4efa45)
(cherry picked from commit 53f163bbc2e5722a46eeb55d15cca2c23994e71b)
commit 47e45c5d6737bd56dfb8d28e38776eb9ee87071e
Author: Michael Adam <obnox at samba.org>
Date: Thu Dec 16 01:49:14 2010 +0100
s3:net ads dns register: add support for specifying addresse on the commandline (bug #7871)
In the clustering case, this is also made the only possiblity to do dns updates,
since the list addresses on the local interfaces is not suitable in that case.
This fixes the "net ads dns register" part of bug #7871.
It might be extended by a parsing of the "cluster addresses" setting.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 5e83a05009787d8a2086db1adc1ed58d61b3725d)
(cherry picked from commit 9ed3d33fb3d7365a127ea2752032840272697902)
(cherry picked from commit 5e708489d56bc7a2b0a033a38e62bed519249b33)
commit 086872720ae9fc252955bbdaba8bf0e16d62cfd3
Author: Michael Adam <obnox at samba.org>
Date: Thu Dec 16 00:52:41 2010 +0100
s3:net: add net_update_dns_ext() that accepts a list of addresses as parameter (bug# 7871)
This generalized form of net_update_dns() will be used to
add support for specifying a list of addresses on the commandline
of "net ads dns register".
This prepares the "net ads dns register" part of the fix for bug #7871.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 4d91f98b433e07922373bf4e3ba9668b7af71a00)
(cherry picked from commit 4b7775500b1055acf62decbc0fc8283b088da452)
(cherry picked from commit ed914296df896a3805c8c6b74ad8bd9e1dcac35b)
commit dbc58fe725faf3a19454ecbf02c6164138a30f50
Author: Michael Adam <obnox at samba.org>
Date: Thu Dec 2 00:42:21 2010 +0100
s3:net: disable dynamic dns updates at the end of "net ads join" in a cluster (bug #7871)
In a clustered environment, registering the set of ip addresses that are
assigned to the interfaces of the node that performs the join does usually
not have the desired effect, since the local interfaces do not carry
complete set of the cluster's public IP addresses. And it can also contain
internal addresses that should not be visible to the outside at all.
In order to do dns updates in a clustererd setup, use net ads dns register.
This fixes the net ads join part of bug #7871.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit b8f19df53e66bf0260b4ae6c49acea87ac379deb)
(cherry picked from commit 1c73d52ddddfcec25cf079da4a0d6bf81fb030da)
(cherry picked from commit ae5ba417d3599cf6ad81a9612e7998a30d8a4061)
commit 95a59f06debc312d57d7be8724f0eb54f59229b0
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Dec 10 15:08:53 2010 +1100
s3-net Allow 'net ads dns register' to take an optional hostname argument
This allows the administrator to more carefully chose what name to register.
Andrew Bartlett
(cherry picked from commit c2a1ad9047508cf2745a9019e6783c8b8f7ef475)
(cherry picked from commit 10c5a59315ef69eeb4d8bc19237de9787284a63d)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit bce7e8c8e11321d98a30a8b6bb79a392a5e644ba)
commit 1ad454de40092897783d09c8a3cd3f22f3872466
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Dec 2 00:39:23 2010 +0100
s3:ntlm_auth: support clients which offer a spnego mechs we don't support (bug #7855)
Before we rejected the authentication if we don't support the
first spnego mech the client offered.
We now negotiate the first mech we support.
This fix works arround problems, when a client
sends the NEGOEX (1.3.6.1.4.1.311.2.2.30) oid,
which we don't support.
metze
(cherry picked from commit f802075f08fe0d86f3d176f2302236aeb5834f3d)
Modified to work in the v3-5-test branch, e.g. use ntlmssp_end()
The last 9 patches address bug #7855 (ntlm_auth only handles the first spnego
mech).
(cherry picked from commit ab69b55011eea73d7c8827fc339feb905474f201)
commit faf83711ed7365848a960c5b906a0882bca07cef
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Dec 1 05:59:16 2010 +0100
s3:ntlm_auth: free session key, as we don't use it (at least for now)
metze
(cherry picked from commit ee4f5ac6182969bcab91955e6d6581e408d222f1)
(cherry picked from commit e00cb883107753380272e128955ae5ad3057fd40)
commit 8177c59551256279f5088170c7eb591f95e10fa2
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Dec 1 05:50:59 2010 +0100
s3:ntlm_auth: fix memory leak in the raw ntlmssp code path
metze
(cherry picked from commit 9a56ade6b1d627126418c75de4602610b4482503)
(cherry picked from commit 7c3bb9af54b40dbd24b781186607339c76a25a85)
commit c642910ef6c78dc3d4d92610e0c7a85e7aea5ee3
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Nov 30 10:52:52 2010 +0100
s3: Correctly unwrap the krb ticket in gss-spnego (cherry picked from commit 547b268cfaa2e791bf92e8804bfa504c4e37050b)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
renamed to _spnego_parse_krb5_wrap()
metze
(cherry picked from commit 7cb3d84fc11490c97d7d84a3231e2d9f6b2d69fe)
commit 9bce549f4d7e10225bab855ede33adf8578eec51
Author: Volker Lendecke <vl at samba.org>
Date: Thu Sep 16 10:22:00 2010 +0200
s3: Fall back to raw NTLMSSP for the gss-spnego protocol
This is to handle the mod_auth_ntlm_winbind protocol
sending "Negotiate" to IE, which sends raw NTLMSSP
instead of a SPNEGO wrapped NTLMSSP blob.
(cherry picked from commit 70ab7eb5303a5ff058939541dd5bc1f81113a48e)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 7652f2a782559bb0346b0976929b5b5b5377dcbc)
commit fdfef32f5c0c6904ab1bd12e4389bee46d5d0120
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Nov 30 10:46:28 2010 +0100
s3: Split off output generation from manage_squid_ntlmssp_request (cherry picked from commit de2c143f4d540f695db5c7fe8685614c03977365)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 8443abede7c3f6deb7a7c584937d9e28eb9274da)
commit 9244295a14b2231693ae4417e32b52f3493a0bad
Author: Volker Lendecke <vl at samba.org>
Date: Thu Sep 16 10:36:21 2010 +0200
s3: Wrap the ntlm_auth loop with a talloc_stackframe (cherry picked from commit ae483bbe9af526623189cefe7735f3f2813da6d7)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 0d9b2e954d61c9f6211c867348a817e42bd4b12f)
commit c838f2cacaf81befbb5177676fae4eafa312711f
Author: Volker Lendecke <vl at samba.org>
Date: Wed Sep 15 10:29:44 2010 +0200
s3: Fix some debug msgs in ntlm_auth (cherry picked from commit 6400f3ee62108e3dd1e6c1013ccea9fb4b08d562)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 498f1c87e6c9bc136da696bae5e9a71df9b8233e)
commit a63c27a1e44a3213539e6c548f7b49dd0250d663
Author: Volker Lendecke <vl at samba.org>
Date: Mon Sep 13 18:09:20 2010 +0200
ntlm_auth: Fix a valgrind error (cherry picked from commit 69db4b4ccf051b05517e6eb9039ab48f90608075)
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 63fa349916d72c158b1fc4ab7a60b9a909a15131)
commit 24693c10f123b907904d626980516291e3442688
Author: Holger Hetterich <hhetter at novell.com>
Date: Sat Dec 4 18:18:50 2010 +0100
Fix bso#3185, return false when EOF is encountered in param name.
(cherry picked from commit a9664633c667f6d02f33b951805882258604ff1c)
commit b781312af82b9ada8395d30447e41a97f0ad88a9
Author: Jeremy Allison <jra at samba.org>
Date: Sun Dec 5 20:40:21 2010 +0100
s3: Fix bug 7843: Expand the local SAMs aliases
(cherry picked from commit 50c8b426385df953d2e3748a39041d4b92cd7ed9)
commit bbbcfa921bc4f77e8d3f4c1624f4c5b893a53162
Author: Volker Lendecke <vl at samba.org>
Date: Sat Dec 4 20:34:05 2010 +0100
s3: Fix bug 7842: WINBINDD_LOOKUPRIDS does not return the domain name
(cherry picked from commit 0737a34a12e46d53e4332ea06eac0ba948608fff)
commit cd2f806b58c78f59029fd67b00aa28104ad79d1e
Author: Volker Lendecke <vl at samba.org>
Date: Sat Dec 4 20:31:36 2010 +0100
s3: Fix bug 7841: WINBINDD_LOOKUPRIDS asks the wrong domain
(cherry picked from commit a257253f8f82bcab52508273b12cd92fadd3ba1a)
commit 6fa4b9d956b600045100746639c5d05489696234
Author: Jeremy Allison <jra at samba.org>
Date: Thu Dec 2 15:27:17 2010 -0800
Fix bug #7835 - vfs_fill_sparse() doesn't use posix_fallocate when strict allocate is on
Tries posix_fallocate() and then falls back to old code.
Jeremy.
(cherry picked from commit 0c45b32bc7d93b03838405a97b054cb414267892)
commit a0b473423586a42f48733113058f84f0515a769e
Author: Volker Lendecke <vl at samba.org>
Date: Sat Nov 13 18:03:25 2010 +0100
s3: Fix "force group" with ntlmssp guest session setup
This one is subtle: Set "force group = <somegroup>" together with "guest ok =
yes". Then try "smbclient //server/share -U%". Works. Then try to connect to
the same share from Windows 2003 using an anonymous connection. Breaks with
make_connection: connection to share denied due to security descriptor
although the share_info.tdb is empty. I've seen reports of this on the lists,
but I could never ever nail it until a customer gave me access to such a box.
What happens? With an empty share_info.tdb we create a security descriptor
allow everything to the world. The problem with the above parameter combination
is that S-1-1-0 (World) is lost in the token. When you look at the callers of
create_local_token, they are only called if the preceding check_ntlm_password
did not create server_info->ptok. Not so with the one in auth_ntlmssp.c. So, if
we get a NTLMSSP session setup with user="", domain="", pass="" we call
create_local_token even though check_guest_security() via
make_server_info_guest() has already correctly done so. In this case
create_local_token puts S-1-1-0 into user_sids[1], which is supposed to be the
primary group sid of the user logging in. "force group" then overwrites this ->
the world is gone -> "denied due to security descriptor".
Why don't you see it with smbclient -U% (anonymous connection)? smbclient does
not use ntlmssp for anon session setup.
This seems not to happen to 3.6.
Volker
Fix bug #7817 ("force group" broken).
(cherry picked from commit 56b1082fe436e1f99a87d3e37d9ea8b017353b39)
commit 3d0959be5e7422172ad59628fa55d9c0534a441b
Author: Volker Lendecke <vl at samba.org>
Date: Thu Nov 18 13:28:47 2010 +0100
s3: Make winbind recover from a signing error
When winbind sees a signing error on the smb connection to a DC (for whatever
reason, our bug, network glitch, etc) it should recover properly. The "old"
code in clientgen.c just closed the socket in this case. This is the right
thing to do, this connection is spoiled anyway. The new, async code did not do
this so far, which led to the code in winbindd_cm.c not detect that we need to
reconnect.
Fix bug #7800 (winbind does not recover from smb signing errors).
(cherry picked from commit 49632d414e13ecd2f17362869c5dc1cceb47862b)
commit cc3a3668a4b9318ad157cf6d8ad81e219b8fc9bf
Author: olivier <olivier at virtscano.fakenet>
Date: Wed Nov 10 17:48:06 2010 +0100
switch from mtime to ctime which is more reliable if files can be accessed outside samba as well
Fix bug #7789 (change vfs_scannedonly from mtime to ctime).
(cherry picked from commit 2d24c4a056e5c54b5ef4c9112cec076ac7c08d6f)
commit 23dfe811c929dfb94ef4fc1b3f93658c8104fc32
Author: Jeremy Allison <jra at samba.org>
Date: Tue Nov 23 14:21:25 2010 -0800
Fix bug #7812 - vfs_acl_xattr/vfs_acl_tdb: ACL inheritance cannot be disabled
We were losing the incoming security descriptor revision number and
most importantly the "type" field as sent by the client. Ensure we
correctly store these in the xattr object.
Jeremy.
(cherry picked from commit 67235a5532a00e6ccb41748dc9a8c3e9159ba79e)
commit aa7977074307e24b0b215185ba46cdb7628571c2
Author: Jeremy Allison <jra at samba.org>
Date: Wed Nov 17 15:58:15 2010 -0800
Fix our privileges code to display privileges with the "high" 32-bit value set.
SeSecurityPrivilege is the first LUID we have added that has a non-zero
"high" value, ensure our LUID code correctly supports it.
Jeremy.
The last 14 patches address bug #7716 (acl_xattr and acl_tdb modules don't store
unmodified copies of security descriptors).
(cherry picked from commit 941129fb70261d4871de4804a81ce82e23d9d0f7)
commit 5c755725f9acf7db9896c615341ac37d73b1405c
Author: Jeremy Allison <jra at samba.org>
Date: Thu Nov 18 16:13:28 2010 -0800
Add SeSecurityPrivilige.
Jeremy.
(cherry picked from commit f11da60f3189bc70eb82259435e108f40b2bb333)
commit e91b5ab21ad88f0d9144c2db72301e391997aafd
Author: Jeremy Allison <jra at samba.org>
Date: Fri Oct 22 16:14:28 2010 -0700
Ensure we have correct parameters to use Windows ACL modules.
(cherry picked from commit 117d14f108cded28ac2868d5040f633856cca923)
commit 5d762df52f47602f6eae667c56e7ad910c3c87eb
Author: Jeremy Allison <jra at samba.org>
Date: Fri Oct 22 17:28:58 2010 -0700
Add acl_xattr:ignore system acls boolean (normally false) to allow Samba ACL module to ignore mapping to lower POSIX layer. With this fix Samba 3.6.x now passes RAW-ACLs (with certain smb.conf parameters set).
Jeremy.
(cherry picked from commit 7c892ed58f816985e58b9cef2ff4cd2a81d16995)
commit 9268e6028cf43f1ac0e3b073c32e364ea4ca4611
Author: Jeremy Allison <jra at samba.org>
Date: Fri Oct 22 16:04:53 2010 -0700
Add make_default_filesystem_acl() function to be used in following change to acl_xattr and acl_tdb module.
(cherry picked from commit 2d84fce8f20c4eac70b02f0fc4333b15e278edfc)
commit 17d265d7a7ac7585bbcbb97c5ad12a99a0f1bdc9
Author: Jeremy Allison <jra at samba.org>
Date: Fri Oct 22 15:56:31 2010 -0700
Fix handling of "NULL" DACL. Map to u/g/w - rwx.
(cherry picked from commit 84b2a3d013390c01ef27d10085a0bf10137c857f)
commit a1ef65bd6495dd7292657ad19f190dcff1a8a829
Author: Jeremy Allison <jra at samba.org>
Date: Fri Oct 22 17:23:13 2010 -0700
Fix "force unknown ACL user" to strip out foreign SIDs from POSIX ACLs if they can't be mapped.
(cherry picked from commit 3fcceb6c5ae55f5e3a66f71e44b5caa665596832)
commit ad3c0b7fc7558fa93c749ad25c61d6783bd28d9e
Author: Jeremy Allison <jra at samba.org>
Date: Fri Oct 22 14:55:52 2010 -0700
Add debug message to get_nt_acl_internal() to see what we got.
(cherry picked from commit 514e3e786f999979f9fd85a9c08de9e06e50938b)
commit 961afddd1f2edf0a22a6808fdf477c360d1c5528
Author: Jeremy Allison <jra at samba.org>
Date: Fri Oct 22 14:54:19 2010 -0700
Fix valgrind "uninitialized read" error on "info" when returning !NT_STATUS_OK.
(cherry picked from commit 9b615ce8706f4f4c59055fe155446f1fdac36323)
commit 1f40a8e67aa251c2e0a9bbd95235b57c3672a9bf
Author: Jeremy Allison <jra at samba.org>
Date: Fri Oct 15 14:12:04 2010 -0700
Fix bug #7734 - When creating files with "inherit ACLs" set to true, we neglect to apply appropriate create masks.
Jeremy.
(cherry picked from commit 8cad5e23b6e2440a566def6fb138d484e3b47643)
(cherry picked from commit e675462b3cfc53d7fe0c6e07c13a386599c5afd9)
commit 459613222a6d3c3b7a6b8c6c3184e67b25af537c
Author: Jeremy Allison <jra at samba.org>
Date: Fri Oct 15 13:30:07 2010 -0700
Fix bug #7733 - Invalid client DOS attributes on create can cause incorrect unix mode_t to be generated.
It turns out a client can send an NTCreateX call for a new file, but specify
FILE_ATTRIBUTE_DIRECTORY in the attribute list. Windows silently strips this,
but we don't - causing the unix_mode() function to go through the "mode bits
for new directory" codepath, instead of the "mode bits for new file" codepath.
Jeremy.
(cherry picked from commit 92adb686372a9b67e47efb5b051bc351212f1780)
(cherry picked from commit 6b4141e92151adaa0d2ef036657783a99ef517c6)
commit 56628b08a587c31ba4031dfaac64057b06452ac1
Author: Jeremy Allison <jra at samba.org>
Date: Fri Oct 22 17:18:45 2010 -0700
Make the vfs_acl_xattr and other modules work with NULL SD's. Fix the "protected" inheritance problem (bleeding up from the POSIX layer).
Jeremy
(cherry picked from commit fe5b8a9dc994d3020537f4e68f2105c806cd103b)
commit 46e4596f82c5dce4656b0a23545a4b38637097f5
Author: Jeremy Allison <jra at samba.org>
Date: Fri Oct 22 17:11:17 2010 -0700
Canonicalize incoming and outgoing ACLs.
Jeremy.
(cherry picked from commit b01501af60d364ce7e7c96b7e4b93502c453ac6d)
commit 8b85046727dad9b7c0db858332b4063300fe0b82
Author: Jeremy Allison <jra at samba.org>
Date: Fri Oct 22 17:07:10 2010 -0700
Make the posix ACL module cope with a NULL incoming DACL and a missing owner/group.
Jeremy.
(cherry picked from commit 09ee42d774c0b0f8cf9a67feb80426c19b4ce24c)
commit 2c885d6e17588c5b51ff1b3310bdb17be313fdd8
Author: Jeremy Allison <jra at samba.org>
Date: Tue Nov 23 11:16:31 2010 -0800
Fix bug #7785 - atime limit.
On a 64-bit time_t system make MAX_TIME_T the max value that
can be represented in a struct tm. This allows applications to
set times in the future beyond the 32-bit time_t limit (2037).
This is only in source3/configure.in, needs adding to the waf
configure/build system (but I'll need help with that).
Jeremy.
(cherry picked from commit ff6c598f7f18e6ba945a3fe082b01255a0a42325)
commit ae1b77eff891ac613b4aaa3917659062cb5154d1
Author: Samba-JP oota <ribbon at samba.gr.jp>
Date: Tue Nov 23 17:06:48 2010 +0100
s3-docs: Update 3.2 features.
(cherry picked from commit aa54713615c5d0367528733ff2c3a5650eed96f7)
(cherry picked from commit 55754e2c1f620eee662319a0bcb89f8620014d56)
commit 48d41b445970f664152b5792b13f63693ff30cde
Author: Jeremy Allison <jra at samba.org>
Date: Thu Nov 11 09:44:21 2010 -0800
Fix bug #7791 - gvfsd-smb (Gnome vfs) fails to copy files from a SMB share using SMB signing.
The underlying problem is that the old code invoked by cli_write() increments
cli->mid directly when issuing outstanding writes. This should now be done only
in libsmb/clientgen.c to make metze's new signing engine works correctly. Just
deleting this code fixes the problem.
Jeremy.
(cherry picked from commit 9a02a38d9783b0d7dc172cc5bdc2380bc5d107cf)
commit 8af876432a83292db672c5f7a1fb7e0ec9c1cf65
Author: Jeremy Allison <jra at samba.org>
Date: Fri Nov 5 12:13:38 2010 -0700
Second part of fix for bug #7777 - When requesting lookups for BUILTIN sids, winbindd allocates new uids/gids in error.
Ensure we return after calling passdb for SID lookups for which we are
authoritative.
Jeremy.
(cherry picked from commit b5c8b1bbb53caa0ceabb4a5180ff7deb1e58b538)
commit 5cbd0958eaf25952055c08e3fdc065b815634a3e
Author: Jeremy Allison <jra at samba.org>
Date: Fri Nov 5 12:11:53 2010 -0700
First part of fix for bug #7777 - When requesting lookups for BUILTIN sids, winbindd allocates new uids/gids in error.
Ensure idmap_init_passdb_domain() correctly initialized the default
domain first.
Jeremy.
(cherry picked from commit 32a5aa62cb54e90947bd027e72871ffc07c3dbcf)
commit 8405769f713d78c5a93e646a3e0c4e4b91c7d462
Author: Volker Lendecke <vl at samba.org>
Date: Sat Nov 6 21:18:35 2010 +0100
s3: Fix bug 7779, crash in expand_msdfs
(cherry picked from commit 82e15a5ee335ac87ab473899b333056a02bf15b3)
commit 5daed7f2c4b9bec0472f9d3f5289bd255b981353
Author: Volker Lendecke <vl at samba.org>
Date: Wed Nov 3 13:08:37 2010 +0100
s3: Fix a getgrent crash with many groups
Fix bug #7774.
(cherry picked from commit d070359ca01c1b340a610dd2cf9ce60b33c256e4)
commit f1fa394584ca5297d281c8fe214aba2fe856d458
Author: Jeremy Allison <jra at samba.org>
Date: Wed Oct 20 13:58:15 2010 -0700
Fix bug #7744 - "dfree cache time" doesn't work.
There is a bug in processing the dfree cache time, which is associated with the
smbd idle timer. The idle timer call conn_idle_all(), which updates the
conn->lastused timestamp. The dfree cache time code in smbd/dfree.c depends on
conn->lastused being up to date to refresh the cached dfree value.
Unfortunately the conn_idle_all() returns early if any of the connection
structs is not idle, never updating any further conn->lastused timestamps. If
(as is common due to an IPC$ connection) there are more than one used
connection struct, then the conn->lastused timestamps after the IPC$ connection
in the connection list will never be updated.
Ensure we always update conn->lastused for all connections when calling
conn_idle_all().
Jeremy.
(cherry picked from commit 47841952936e28916a738105194d662207477285)
commit d82d3346cf87dcce9f7d098bb975055e69473078
Author: Jeremy Allison <jra at samba.org>
Date: Wed Oct 20 11:22:57 2010 -0700
Fix bug #7743 - Inconsistent use of system name lookup can cause a domain joined machine to fail to find users.
Ensure all username lookups go through Get_Pwnam_alloc(), which is the
correct wrapper function. We were using it *some* of the time anyway,
so this just makes us properly consistent.
Jeremy.
(cherry picked from commit 6e9d95f753b2b127268f1eb9a40d601002484bd1)
commit b2b9b999c8031fa8218e11a99eb5b67a42deb158
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 15 16:37:47 2010 +0200
s3: Fix bug 7730 -- crash in winbindd_dsgetdcname.c
(cherry picked from commit f1b04a210074546d4e4347b62b4f7f5b879454d9)
commit 091d0a00349478c921a3f41c2915821e8d13315e
Author: Jeremy Allison <jra at samba.org>
Date: Thu Oct 7 14:26:13 2010 -0700
Fix bug 7716 - acl_xattr and acl_tdb modules don't store unmodified copies of security descriptors.
As pointed out by an OEM, the code within smbd/posix_acl.c, even though passed
a const pointer to a security descriptor, still modifies the ACE entries within
it (which are not const pointers).
This means ACLs stored in the extended attribute by the acl_xattr module have
already been modified by the POSIX acl layer, and are not the original intent
of storing the "unmodified" ACL from the client.
Use dup_sec_desc to make a copy of the incoming ACL on talloc_tos() - that
is what is then modified inside smbd/posix_acl.c, leaving the original ACL
to be correctly stored in the xattr.
Jeremy.
(cherry picked from commit 02dd1fc3c777a49e4fa51982956dcdcc8761e0c9)
commit 2f7bcbc8806d0d2ad15d3137dd05d6f8e976659e
Author: Volker Lendecke <vl at samba.org>
Date: Sat Oct 2 11:50:26 2010 +0200
s3: Attempt to fix bug 7665
Quite a few of our internal routines put stuff on talloc_tos() these days.
In top-level netapi routines, properly allocate a stackframe and clean it
again. Also, don't leak memory in the rpccli_ callers onto the libnetapi
context.
(cherry picked from commit c4421a287c7e613c0c8da188a6ae8db37e90c8fc)
commit 43bbd23e628a0bcd17b7a37301a9af7e5f89d1b2
Author: Michael Adam <obnox at samba.org>
Date: Sun Oct 31 02:04:25 2010 +0200
s3:librpc/ndr: use new strlen_m_ext_term() in ndr_charset_length(): fix bug #7594
This fixes the calculation of needed space for destination unicode charset.
The last 4 patches address bug #7594 ("wbinfo -u" and "wbinfo -g" gives no
output (log=>ndr_pull_error)).
(cherry picked from commit 8e46bff8b88103f4a5b0d3920ab6e3901decaf22)
commit 3065a29ca6fb5dfb83f0fd272ebae15fca9cb5ea
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Aug 25 10:05:15 2010 +0200
librpc/ndr: correctly implement ndr_charset_length()
Before we ignored the charset type.
metze
Signed-off-by: Michael Adam <obnox at samba.org>
(cherry picked from commit 9fd5cc6d85d3179972d7567bad95538ab2873c30)
commit 43e78d0b46529955bc8e66e6d4f127dbfe35904d
Author: Michael Adam <obnox at samba.org>
Date: Sun Oct 31 02:02:16 2010 +0200
s3:lib/util_str: add strlen_m_ext_term() - variant of strlen_m_ext() counting terminator
(cherry picked from commit f7928a0e0b2be27e83bf26644c45ac554c5acec2)
commit b873b8b061cbbff578c242e2a062bd198a5069b3
Author: Michael Adam <obnox at samba.org>
Date: Mon Nov 1 16:28:43 2010 +0100
s3:lib/util_str: add strlen_m_ext() that takes the dest charset as a parameter.
(cherry picked from commit 054cd7ec30a3289443c97d36ea416d37f19d6b0b)
commit 4d06efbc24174b6c4f6627abdaa4dcdf58f286d3
Author: Jeremy Allison <jra at samba.org>
Date: Mon Sep 13 16:51:59 2010 -0700
Fix bug 7409 - Thousands of reduce_name: couldn't get realpath.
Don't log this at level 1 - every EACCES will generate one.
Thanks to muehlfeld at medizinische-genetik.de for pointing this out.
Jeremy.
(cherry picked from commit 7effd963691f8a1307b658b029c4f7f255399bb6)
-----------------------------------------------------------------------
Summary of changes:
WHATSNEW.txt | 103 ++-
docs-xml/Samba3-HOWTO/TOSHARG-upgrading-to-3.0.xml | 96 ++
lib/util/params.c | 2 +-
libcli/nbt/nbtname.c | 6 +-
librpc/gen_ndr/dcerpc.h | 1 +
librpc/gen_ndr/drsblobs.h | 4 +-
librpc/gen_ndr/eventlog.h | 12 +-
librpc/gen_ndr/misc.h | 4 +-
librpc/gen_ndr/nbt.h | 26 +-
librpc/gen_ndr/ndr_drsblobs.c | 16 +-
librpc/gen_ndr/ndr_eventlog.c | 24 +-
librpc/gen_ndr/ndr_misc.c | 12 +-
librpc/gen_ndr/ndr_nbt.c | 44 +-
librpc/gen_ndr/ndr_netlogon.c | 8 +-
librpc/gen_ndr/ndr_spoolss.c | 1071 ++++++++++----------
librpc/gen_ndr/ndr_svcctl.c | 40 +-
librpc/gen_ndr/netlogon.h | 4 +-
librpc/gen_ndr/spoolss.h | 306 +++---
librpc/gen_ndr/svcctl.h | 10 +-
librpc/idl/dcerpc.idl | 1 +
librpc/idl/idl_types.h | 4 +-
librpc/idl/spoolss.idl | 8 +-
librpc/ndr/ndr.c | 34 +-
librpc/ndr/ndr_basic.c | 20 +-
librpc/ndr/ndr_spoolss_buf.c | 59 ++
librpc/ndr/ndr_spoolss_buf.h | 2 +
librpc/rpc/dcerpc_error.c | 1 +
source3/Makefile.in | 3 +-
source3/auth/auth_domain.c | 1 +
source3/auth/auth_netlogond.c | 1 +
source3/auth/auth_ntlmssp.c | 13 +-
source3/auth/auth_util.c | 16 +-
source3/configure.in | 29 +-
source3/include/async_smb.h | 7 +
source3/include/privileges.h | 2 +
source3/include/proto.h | 42 +-
source3/lib/events.c | 3 +-
source3/lib/netapi/file.c | 6 +-
source3/lib/netapi/getdc.c | 4 +-
source3/lib/netapi/group.c | 112 +-
source3/lib/netapi/joindomain.c | 10 +-
source3/lib/netapi/libnetapi.c | 159 +++
source3/lib/netapi/localgroup.c | 34 +-
source3/lib/netapi/netlogon.c | 6 +-
source3/lib/netapi/serverinfo.c | 6 +-
source3/lib/netapi/share.c | 10 +-
source3/lib/netapi/shutdown.c | 4 +-
source3/lib/netapi/user.c | 83 +-
source3/lib/privileges_basic.c | 29 +-
source3/lib/util.c | 13 +-
source3/lib/util_seaccess.c | 6 +-
source3/lib/util_str.c | 72 ++-
source3/libaddns/dnsgss.c | 4 +-
source3/librpc/gen_ndr/cli_wbint.c | 5 +
source3/librpc/gen_ndr/cli_wbint.h | 2 +
source3/librpc/gen_ndr/ndr_secrets.c | 2 -
source3/librpc/gen_ndr/ndr_wbint.c | 48 +
source3/librpc/gen_ndr/srv_wbint.c | 11 +
source3/librpc/gen_ndr/wbint.h | 1 +
source3/librpc/idl/wbint.idl | 1 +
source3/librpc/ndr/ndr_string.c | 16 +-
source3/libsmb/async_smb.c | 129 +++
source3/libsmb/clidgram.c | 9 +
source3/libsmb/clikrb5.c | 34 +-
source3/libsmb/clireadwrite.c | 7 +-
source3/libsmb/nmblib.c | 2 +-
source3/libsmb/smbsock_connect.c | 575 +++++++++++
source3/modules/onefs_open.c | 4 +-
source3/modules/vfs_acl_common.c | 123 ++-
source3/modules/vfs_acl_tdb.c | 8 +-
source3/modules/vfs_acl_xattr.c | 14 +-
source3/modules/vfs_default.c | 20 +-
source3/modules/vfs_gpfs.c | 12 +-
source3/modules/vfs_scannedonly.c | 8 +-
source3/nmbd/nmbd.c | 4 +-
source3/param/loadparm.c | 4 +-
source3/passdb/pdb_interface.c | 4 +-
source3/passdb/pdb_ldap.c | 8 +-
source3/passdb/pdb_smbpasswd.c | 2 +-
source3/passdb/util_unixsids.c | 2 +-
source3/printing/nt_printing.c | 10 +-
source3/rpc_client/cli_netlogon.c | 100 ++-
source3/rpc_server/srv_dfs_nt.c | 12 +-
source3/rpc_server/srv_spoolss_nt.c | 23 +-
source3/rpcclient/cmd_spoolss.c | 6 +-
source3/smbd/conn.c | 9 +-
source3/smbd/dosmode.c | 11 +-
source3/smbd/msdfs.c | 8 +-
source3/smbd/nttrans.c | 75 ++-
source3/smbd/open.c | 101 +--
source3/smbd/password.c | 2 +-
source3/smbd/posix_acls.c | 175 ++++-
source3/smbd/process.c | 8 +-
source3/smbd/uid.c | 2 +-
source3/smbd/vfs.c | 36 +-
source3/torture/pdbtest.c | 2 +-
source3/utils/net_ads.c | 117 ++-
source3/utils/net_rpc_samsync.c | 1 -
source3/utils/net_sam.c | 4 +-
source3/utils/ntlm_auth.c | 417 ++++++---
source3/web/cgi.c | 4 +-
source3/winbindd/idmap.c | 10 +
source3/winbindd/idmap_util.c | 31 +-
source3/winbindd/wb_dsgetdcname.c | 4 +
source3/winbindd/wb_gettoken.c | 4 +-
source3/winbindd/winbindd.h | 1 +
source3/winbindd/winbindd_cm.c | 59 +-
source3/winbindd/winbindd_dual_srv.c | 2 +
source3/winbindd/winbindd_getgrent.c | 1 +
source3/winbindd/winbindd_lookuprids.c | 5 +-
source3/winbindd/winbindd_pam.c | 97 ++-
source3/winbindd/winbindd_rpc.c | 31 +
112 files changed, 3590 insertions(+), 1426 deletions(-)
create mode 100644 source3/libsmb/smbsock_connect.c
Changeset truncated at 500 lines:
diff --git a/WHATSNEW.txt b/WHATSNEW.txt
index 70b1c24..a629289 100644
--- a/WHATSNEW.txt
+++ b/WHATSNEW.txt
@@ -6,15 +6,116 @@
This is the latest stable release of Samba 3.5.
+Major enhancements in Samba 3.5.8 include:
-o
+o Fix Winbind crash bug when no DC is available (bug #7730).
+o Fix finding users on domain members (bug #7743).
+o Fix memory leaks in Winbind (bug #7879).
+o Fix printing with Windows 7 clients (bug #7567).
Changes since 3.5.7:
--------------------
+o Michael Adam <obnox at samba.org>
+ * BUG 7594: Fix "log=>ndr_pull_error" in 'wbinfo -u' and 'wbinfo -g'.
+ * BUG 7871: Fix 'net ads dns register' in cluster setups.
+ * BUG 7894: Fix sporadic Winbind panic in rpc query_user_list.
+
+
o Jeremy Allison <jra at samba.org>
+ * BUG 7409: Raise debug level for "reduce_name: couldn't get realpath"
+ messages.
+ * BUG 7716: Store unmodified copies of security descriptors in acl_xattr and
+ acl_tdb modules.
+ * BUG 7733: Fix incorrect unix mode_t caused by invalid client DOS
+ attributes on create.
+ * BUG 7734: Apply appropriate create masks when creating files with "inherit
+ ACLs" set to true.
+ * BUG 7743: Fix finding users on domain members.
+ * BUG 7744: Fix "dfree cache time" parameter.
+ * BUG 7777: Fix requesting lookups for BUILTIN sids.
+ * BUG 7785: Fix atime limit.
+ * BUG 7791: Fix copying files from a SMB share using Gnome vfs and SMB
+ signing.
+ * BUG 7812: ACL inheritance cannot be disabled in vfs_acl_xattr/vfs_acl_tdb.
+ * BUG 7835: vfs_fill_sparse() doesn't use posix_fallocate when strict
+ allocate is on.
+ * BUG 7843: Expand the local SAMs aliases.
+ * BUG 7892: Fix stale lock in open_file_fchmod().
+ * BUG 7950: Revalidate the pathname once re-constructed from a root fsp.
+
+
+o Andrew Bartlett <abartlet at samba.org>
+ * BUG 7356: Fix 'net ads dns register' in Windows 2008 R2 domains.
+
+
+o Björn Baumbach <bb at sernet.de>
+ * BUG 7875: Fix 'nmbd --port'.
+ * BUG 7880: Make 'rpcclient deldriver' delete drivers for all architectures.
+
+
+o Günther Deschner <gd at samba.org>
+ * BUG 7567: Fix printing with Windows 7 clients.
+ * BUG 7641: Handle Windows 9x adddriver calls without config file.
+ * BUG 7945: Let Winbind try to use samlogon validation level 6.
+
+
+o Holger Hetterich <hhetter at novell.com>
+ * BUG 3185: Fix 'testparm' return code when EOF in encountered in param
+ name.
+
+
+o Björn Jacke <bj at sernet.de>
+ * BUG 7821: Fix build of shared libraries on Tru64.
+
+
+o Volker Lendecke <vl at samba.org>
+ * BUG 7066: Fix "Your Password expires today" message for users of trusted
+ domains.
+ * BUG 7262: Fix maintaining of users' groups via UsrMgr.
+ * BUG 7656: Fix scalability problem with hundreds of printers.
+ * BUG 7665: Fix memory leak in the netapi routines.
+ * BUG 7730: Fix Winbind crash bug when no DC is available.
+ * BUG 7774: Fix a getgrent crash with many groups.
+ * BUG 7779: Fix smbd crash caused by expand_msdfs.
+ * BUG 7800: Make Winbind recover from a signing error.
+ * BUG 7817: Fix "force group" with ntlmssp guest session setup.
+ * BUG 7841: Make WINBINDD_LOOKUPRIDS asking the right domain.
+ * BUG 7842: Make WINBINDD_LOOKUPRIDS returning the domain name.
+ * BUG 7855: ntlm_auth: Support clients which offer a spnego mechs we don't
+ support.
+ * BUG 7879: Fix memory leaks in Winbind.
+ * BUG 7881: Fix flaky Winbind against Windows 2008.
+ * BUG 7917: Fix connections from WinCE.
+ * BUG 7940: Fix opening MS Powerpoint files.
+
+
+o Stefan Metzmacher <metze at samba.org>
+ * BUG 7567: Fix printing with Windows 7 clients.
+ * BUG 7855: ntlm_auth: Support clients which offer a spnego mechs we don't
+ support.
+ * BUG 7883: Fix SMB session setups with Kerberos against some closed source
+ SMB servers.
+ * BUG 7896: Don't set SAMR_FIELD_FULL_NAME if we just want to set the
+ account name.
+ * BUG 7899: Don't return "-1" on success in 'net rpc vampire keytab'.
+ * BUG 7942: Fix endless loops caused by inotify.
+ * BUG 7944: Catch lookup_names/sids schannel errors over ncacn_ip_tcp.
+
+
+o Jonathan Nieder <jrnieder at gmail.com>
+ * BUG 6837: Make "rlimit_max below minimum Windows limit" notification less
+ scary.
+
+
+o olivier <olivier at virtscano.fakenet>
+ * BUG 7789: vfs_scannedonly: Switch from mtime to ctime which is more reliable.
+
+
+o Rusty Russell <rusty at rustcorp.com.au>
+ * BUG 7498: Fix updating the time on close in vfs_gpfs.
######################################################################
diff --git a/docs-xml/Samba3-HOWTO/TOSHARG-upgrading-to-3.0.xml b/docs-xml/Samba3-HOWTO/TOSHARG-upgrading-to-3.0.xml
index f3fb688..7ae6fd5 100644
--- a/docs-xml/Samba3-HOWTO/TOSHARG-upgrading-to-3.0.xml
+++ b/docs-xml/Samba3-HOWTO/TOSHARG-upgrading-to-3.0.xml
@@ -94,8 +94,104 @@ See <link linkend="pdbeditthing">The <emphasis>pdbedit</emphasis> Command</link>
<sect2>
<title>New Features in Samba-3.2.x Series</title>
+
+<para>Samba is now distributed under the version 3
+of the new GNU General Public License.
+</para>
+
+<para>
+The major new features are:
+</para>
+
+
+<orderedlist numeration="arabic">
+ <listitem><para>
+<indexterm><primary>File Service</primary></indexterm>
+<indexterm><primary>limit</primary></indexterm>
+ Removal of the 1024 byte limit on pathnames and 256 byte limit on
+ filename components to honor the MAX_PATH setting from the host OS.
+ </para></listitem>
+
+ <listitem><para>
+<indexterm><primary>Registory</primary></indexterm>
+<indexterm><primary>Configuration</primary></indexterm>
+ Introduction of a registry based configuration system.
+ </para></listitem>
+
+ <listitem><para>
+<indexterm><primary>cluster</primary></indexterm>
+ Experimental support for file serving clusters.
+ </para></listitem>
+
+ <listitem><para>
+<indexterm><primary>IPv6</primary></indexterm>
+ Support for IPv6 in the server, and client tools and libraries.
+ </para></listitem>
+
+ <listitem><para>
+<indexterm><primary>alternate data streams</primary></indexterm>
+ Support for storing alternate data streams in xattrs.
+ </para></listitem>
+
+ <listitem><para>
+<indexterm><primary>Encrypted SMB transport</primary></indexterm>
+ Encrypted SMB transport in client tools and libraries, and server.
+ </para></listitem>
+
+ <listitem><para>
+<indexterm><primary>Windows Vista</primary></indexterm>
+ Support for Vista clients authenticating via Kerberos.
+ </para></listitem>
+
+ <listitem><para>
+<indexterm><primary>Winbind</primary></indexterm>
+<indexterm><primary>forest</primary></indexterm>
+ Full support for Windows 2003 cross-forest, transitive trusts
+ and one-way domain trusts.
+ </para></listitem>
+
+ <listitem><para>
+<indexterm><primary>pam_winbind</primary></indexterm>
+ Support for userPrincipalName logons via pam_winbind and NSS lookups.
+ </para></listitem>
+
+ <listitem><para>
+<indexterm><primary>LDAP</primary></indexterm>
+<indexterm><primary>Active Directory</primary></indexterm>
+<indexterm><primary>Signing</primary></indexterm>
+ Support for Active Directory LDAP Signing policy.
+ </para></listitem>
+
+ <listitem><para>
+<indexterm><primary>Licence</primary></indexterm>
+<indexterm><primary>GPL</primary></indexterm>
+ New LGPL Winbind client library (libwbclient.so).
+ </para></listitem>
+
+ <listitem><para>
+<indexterm><primary>domain</primary></indexterm>
+<indexterm><primary>domain trust</primary></indexterm>
+ Support for establishing interdomain trust relationships with Windows 2008.
+ </para></listitem>
+
+ <listitem><para>
+<indexterm><primary>joining</primary></indexterm>
+ New client and server support for remotely joining and unjoining Domains.
+ </para></listitem>
+
+
+ <listitem><para>
+<indexterm><primary>joining</primary></indexterm>
+ Support for joining into Windows 2008 domains.
+ </para></listitem>
+
+</orderedlist>
+
<para>
+Plus lots of other improvements!
</para>
+
+
</sect2>
<sect2>
diff --git a/lib/util/params.c b/lib/util/params.c
index 80adc71..376fed4 100644
--- a/lib/util/params.c
+++ b/lib/util/params.c
@@ -358,7 +358,7 @@ static bool Parameter( myFILE *InFile, bool (*pfunc)(const char *, const char *,
case EOF:
InFile->bufr[i] = '\0';
DEBUG(1,("%s Unexpected end-of-file at: %s\n", func, InFile->bufr ));
- return( true );
+ return( false );
default:
if( isspace( c ) ) /* One ' ' per whitespace region. */
diff --git a/libcli/nbt/nbtname.c b/libcli/nbt/nbtname.c
index 338cb21..5346ee3 100644
--- a/libcli/nbt/nbtname.c
+++ b/libcli/nbt/nbtname.c
@@ -82,7 +82,9 @@ static enum ndr_err_code ndr_pull_component(struct ndr_pull *ndr,
return ndr_pull_error(ndr, NDR_ERR_STRING,
"BAD NBT NAME component");
}
- *component = (uint8_t*)talloc_strndup(ndr, (const char *)&ndr->data[1 + *offset], len);
+ *component = (uint8_t*)talloc_strndup(
+ ndr->current_mem_ctx,
+ (const char *)&ndr->data[1 + *offset], len);
NDR_ERR_HAVE_NO_MEMORY(*component);
*offset += len + 1;
*max_offset = MAX(*max_offset, *offset);
@@ -126,7 +128,7 @@ _PUBLIC_ enum ndr_err_code ndr_pull_nbt_string(struct ndr_pull *ndr, int ndr_fla
"BAD NBT NAME too many components");
}
if (num_components == 0) {
- name = talloc_strdup(ndr, "");
+ name = talloc_strdup(ndr->current_mem_ctx, "");
NDR_ERR_HAVE_NO_MEMORY(name);
}
diff --git a/librpc/gen_ndr/dcerpc.h b/librpc/gen_ndr/dcerpc.h
index 5408cf4..f64f7ae 100644
--- a/librpc/gen_ndr/dcerpc.h
+++ b/librpc/gen_ndr/dcerpc.h
@@ -22,6 +22,7 @@
#define DCERPC_FAULT_OTHER ( 0x00000001 )
#define DCERPC_FAULT_ACCESS_DENIED ( 0x00000005 )
#define DCERPC_FAULT_CANT_PERFORM ( 0x000006d8 )
+#define DCERPC_FAULT_SEC_PKG_ERROR ( 0x00000721 )
#define DCERPC_FAULT_TODO ( 0x00000042 )
#define DCERPC_AUTH_LEVEL_DEFAULT ( DCERPC_AUTH_LEVEL_CONNECT )
#define DCERPC_AUTH_TRAILER_LENGTH ( 8 )
diff --git a/librpc/gen_ndr/drsblobs.h b/librpc/gen_ndr/drsblobs.h
index 64f6ce8..f4adc57 100644
--- a/librpc/gen_ndr/drsblobs.h
+++ b/librpc/gen_ndr/drsblobs.h
@@ -84,9 +84,9 @@ struct repsFromTo1 {
struct repsFromTo2OtherInfo {
uint32_t __ndr_size;/* [value(ndr_size_repsFromTo2OtherInfo(this,ndr->iconv_convenience,ndr->flags))] */
- const char * dns_name1;/* [relative,flag(LIBNDR_FLAG_STR_NULLTERM)] */
+ const char * dns_name1;/* [relative,flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2)] */
uint32_t unknown1;
- const char * dns_name2;/* [relative,flag(LIBNDR_FLAG_STR_NULLTERM)] */
+ const char * dns_name2;/* [relative,flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2)] */
uint64_t unknown2;
}/* [relative_base,gensize,public] */;
diff --git a/librpc/gen_ndr/eventlog.h b/librpc/gen_ndr/eventlog.h
index dc2e877..2ff0cbc 100644
--- a/librpc/gen_ndr/eventlog.h
+++ b/librpc/gen_ndr/eventlog.h
@@ -59,13 +59,13 @@ struct eventlog_Record_tdb {
uint32_t data_length;/* [value(data.length)] */
uint32_t data_offset;
uint32_t source_name_len;/* [value(2*strlen_m_term(source_name))] */
- const char * source_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM)] */
+ const char * source_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2)] */
uint32_t computer_name_len;/* [value(2*strlen_m_term(computer_name))] */
- const char * computer_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM)] */
+ const char * computer_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2)] */
uint32_t sid_padding;
DATA_BLOB sid;
uint32_t strings_len;/* [value(2*ndr_size_string_array(strings,num_of_strings,LIBNDR_FLAG_STR_NULLTERM))] */
- const char * *strings;/* [flag(LIBNDR_FLAG_STR_NULLTERM)] */
+ const char * *strings;/* [flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2)] */
DATA_BLOB data;
uint32_t padding;
}/* [public,flag(LIBNDR_FLAG_NOALIGN|LIBNDR_PRINT_ARRAY_HEX)] */;
@@ -119,10 +119,10 @@ struct EVENTLOGRECORD {
uint32_t UserSidOffset;/* [value(56+2*(strlen_m_term(SourceName)+strlen_m_term(Computername)))] */
uint32_t DataLength;
uint32_t DataOffset;/* [value(56+2*(strlen_m_term(SourceName)+strlen_m_term(Computername))+UserSidLength+(2*ndr_size_string_array(Strings,NumStrings,LIBNDR_FLAG_STR_NULLTERM)))] */
- const char * SourceName;/* [flag(LIBNDR_FLAG_STR_NULLTERM)] */
- const char * Computername;/* [flag(LIBNDR_FLAG_STR_NULLTERM)] */
+ const char * SourceName;/* [flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2)] */
+ const char * Computername;/* [flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2)] */
struct dom_sid0 UserSid;/* [subcontext_size(UserSidLength),subcontext(0),flag(LIBNDR_FLAG_ALIGN4)] */
- const char * *Strings;/* [flag(LIBNDR_FLAG_STR_NULLTERM)] */
+ const char * *Strings;/* [flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2)] */
uint8_t *Data;/* [flag(LIBNDR_PRINT_ARRAY_HEX)] */
const char * Pad;/* [flag(LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_NULLTERM)] */
uint32_t Length2;/* [value(Length)] */
diff --git a/librpc/gen_ndr/misc.h b/librpc/gen_ndr/misc.h
index 6672c61..90330b3 100644
--- a/librpc/gen_ndr/misc.h
+++ b/librpc/gen_ndr/misc.h
@@ -84,10 +84,10 @@ enum winreg_Type
;
union winreg_Data {
- const char * string;/* [flag(LIBNDR_FLAG_STR_NULLTERM),case(REG_SZ)] */
+ const char * string;/* [flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2),case(REG_SZ)] */
DATA_BLOB binary;/* [flag(LIBNDR_FLAG_REMAINING),case(REG_BINARY)] */
uint32_t value;/* [case(REG_DWORD)] */
- const char ** string_array;/* [flag(LIBNDR_FLAG_STR_NULLTERM),case(REG_MULTI_SZ)] */
+ const char ** string_array;/* [flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2),case(REG_MULTI_SZ)] */
DATA_BLOB data;/* [flag(LIBNDR_FLAG_REMAINING),default] */
}/* [public,nodiscriminant,flag(LIBNDR_FLAG_LITTLE_ENDIAN)] */;
diff --git a/librpc/gen_ndr/nbt.h b/librpc/gen_ndr/nbt.h
index ec234e1..31ea414 100644
--- a/librpc/gen_ndr/nbt.h
+++ b/librpc/gen_ndr/nbt.h
@@ -456,8 +456,8 @@ enum netlogon_command
struct NETLOGON_SAM_LOGON_REQUEST {
uint16_t request_count;
- const char * computer_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM)] */
- const char * user_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM)] */
+ const char * computer_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2)] */
+ const char * user_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2)] */
const char * mailslot_name;/* [flag(LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_NULLTERM)] */
uint32_t acct_control;
uint32_t sid_size;/* [value(ndr_size_dom_sid0(&sid,ndr->flags))] */
@@ -470,9 +470,9 @@ struct NETLOGON_SAM_LOGON_REQUEST {
struct NETLOGON_SAM_LOGON_RESPONSE_NT40 {
enum netlogon_command command;
- const char * server;/* [flag(LIBNDR_FLAG_STR_NULLTERM)] */
- const char * user_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM)] */
- const char * domain;/* [flag(LIBNDR_FLAG_STR_NULLTERM)] */
+ const char * server;/* [flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2)] */
+ const char * user_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2)] */
+ const char * domain;/* [flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2)] */
uint32_t nt_version;
uint16_t lmnt_token;
uint16_t lm20_token;
@@ -480,9 +480,9 @@ struct NETLOGON_SAM_LOGON_RESPONSE_NT40 {
struct NETLOGON_SAM_LOGON_RESPONSE {
enum netlogon_command command;
- const char * pdc_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM)] */
- const char * user_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM)] */
- const char * domain_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM)] */
+ const char * pdc_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2)] */
+ const char * user_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2)] */
+ const char * domain_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2)] */
struct GUID domain_uuid;
struct GUID zero_uuid;
const char * forest;
@@ -520,7 +520,7 @@ struct nbt_netlogon_query_for_pdc {
const char * computer_name;/* [flag(LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_NULLTERM)] */
const char * mailslot_name;/* [flag(LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_NULLTERM)] */
DATA_BLOB _pad;/* [flag(LIBNDR_FLAG_ALIGN2)] */
- const char * unicode_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM)] */
+ const char * unicode_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2)] */
uint32_t nt_version;
uint16_t lmnt_token;
uint16_t lm20_token;
@@ -530,8 +530,8 @@ struct nbt_netlogon_response_from_pdc {
enum netlogon_command command;
const char * pdc_name;/* [flag(LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_NULLTERM)] */
DATA_BLOB _pad;/* [flag(LIBNDR_FLAG_ALIGN2)] */
- const char * unicode_pdc_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM)] */
- const char * domain_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM)] */
+ const char * unicode_pdc_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2)] */
+ const char * domain_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2)] */
uint32_t nt_version;
uint16_t lmnt_token;
uint16_t lm20_token;
@@ -551,8 +551,8 @@ struct NETLOGON_DB_CHANGE {
const char * pdc_name;/* [flag(LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_NULLTERM)] */
const char * domain;/* [flag(LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_NULLTERM)] */
DATA_BLOB _pad;/* [flag(LIBNDR_FLAG_ALIGN2)] */
- const char * unicode_pdc_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM)] */
- const char * unicode_domain;/* [flag(LIBNDR_FLAG_STR_NULLTERM)] */
+ const char * unicode_pdc_name;/* [flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2)] */
+ const char * unicode_domain;/* [flag(LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2)] */
uint32_t db_count;
struct nbt_db_change_info *dbchange;
uint32_t sid_size;/* [value(ndr_size_dom_sid0(&sid,ndr->flags))] */
diff --git a/librpc/gen_ndr/ndr_drsblobs.c b/librpc/gen_ndr/ndr_drsblobs.c
index 33ebf4c..948fdc5 100644
--- a/librpc/gen_ndr/ndr_drsblobs.c
+++ b/librpc/gen_ndr/ndr_drsblobs.c
@@ -638,14 +638,14 @@ _PUBLIC_ enum ndr_err_code ndr_push_repsFromTo2OtherInfo(struct ndr_push *ndr, i
NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, ndr_size_repsFromTo2OtherInfo(r, ndr->iconv_convenience, ndr->flags)));
{
uint32_t _flags_save_string = ndr->flags;
- ndr_set_flags(&ndr->flags, LIBNDR_FLAG_STR_NULLTERM);
+ ndr_set_flags(&ndr->flags, LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2);
NDR_CHECK(ndr_push_relative_ptr1(ndr, r->dns_name1));
ndr->flags = _flags_save_string;
}
NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, r->unknown1));
{
uint32_t _flags_save_string = ndr->flags;
- ndr_set_flags(&ndr->flags, LIBNDR_FLAG_STR_NULLTERM);
+ ndr_set_flags(&ndr->flags, LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2);
NDR_CHECK(ndr_push_relative_ptr1(ndr, r->dns_name2));
ndr->flags = _flags_save_string;
}
@@ -656,7 +656,7 @@ _PUBLIC_ enum ndr_err_code ndr_push_repsFromTo2OtherInfo(struct ndr_push *ndr, i
NDR_CHECK(ndr_push_setup_relative_base_offset2(ndr, r));
{
uint32_t _flags_save_string = ndr->flags;
- ndr_set_flags(&ndr->flags, LIBNDR_FLAG_STR_NULLTERM);
+ ndr_set_flags(&ndr->flags, LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2);
if (r->dns_name1) {
NDR_CHECK(ndr_push_relative_ptr2_start(ndr, r->dns_name1));
NDR_CHECK(ndr_push_string(ndr, NDR_SCALARS, r->dns_name1));
@@ -666,7 +666,7 @@ _PUBLIC_ enum ndr_err_code ndr_push_repsFromTo2OtherInfo(struct ndr_push *ndr, i
}
{
uint32_t _flags_save_string = ndr->flags;
- ndr_set_flags(&ndr->flags, LIBNDR_FLAG_STR_NULLTERM);
+ ndr_set_flags(&ndr->flags, LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2);
if (r->dns_name2) {
NDR_CHECK(ndr_push_relative_ptr2_start(ndr, r->dns_name2));
NDR_CHECK(ndr_push_string(ndr, NDR_SCALARS, r->dns_name2));
@@ -692,7 +692,7 @@ _PUBLIC_ enum ndr_err_code ndr_pull_repsFromTo2OtherInfo(struct ndr_pull *ndr, i
NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, &r->__ndr_size));
{
uint32_t _flags_save_string = ndr->flags;
- ndr_set_flags(&ndr->flags, LIBNDR_FLAG_STR_NULLTERM);
+ ndr_set_flags(&ndr->flags, LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2);
NDR_CHECK(ndr_pull_generic_ptr(ndr, &_ptr_dns_name1));
if (_ptr_dns_name1) {
NDR_PULL_ALLOC(ndr, r->dns_name1);
@@ -705,7 +705,7 @@ _PUBLIC_ enum ndr_err_code ndr_pull_repsFromTo2OtherInfo(struct ndr_pull *ndr, i
NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, &r->unknown1));
{
uint32_t _flags_save_string = ndr->flags;
- ndr_set_flags(&ndr->flags, LIBNDR_FLAG_STR_NULLTERM);
+ ndr_set_flags(&ndr->flags, LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2);
NDR_CHECK(ndr_pull_generic_ptr(ndr, &_ptr_dns_name2));
if (_ptr_dns_name2) {
NDR_PULL_ALLOC(ndr, r->dns_name2);
@@ -722,7 +722,7 @@ _PUBLIC_ enum ndr_err_code ndr_pull_repsFromTo2OtherInfo(struct ndr_pull *ndr, i
NDR_CHECK(ndr_pull_setup_relative_base_offset2(ndr, r));
{
uint32_t _flags_save_string = ndr->flags;
- ndr_set_flags(&ndr->flags, LIBNDR_FLAG_STR_NULLTERM);
+ ndr_set_flags(&ndr->flags, LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2);
if (r->dns_name1) {
uint32_t _relative_save_offset;
_relative_save_offset = ndr->offset;
@@ -737,7 +737,7 @@ _PUBLIC_ enum ndr_err_code ndr_pull_repsFromTo2OtherInfo(struct ndr_pull *ndr, i
}
{
uint32_t _flags_save_string = ndr->flags;
- ndr_set_flags(&ndr->flags, LIBNDR_FLAG_STR_NULLTERM);
+ ndr_set_flags(&ndr->flags, LIBNDR_FLAG_STR_NULLTERM|LIBNDR_FLAG_ALIGN2);
if (r->dns_name2) {
uint32_t _relative_save_offset;
_relative_save_offset = ndr->offset;
diff --git a/librpc/gen_ndr/ndr_eventlog.c b/librpc/gen_ndr/ndr_eventlog.c
index a7e502c..e0ac6d2 100644
--- a/librpc/gen_ndr/ndr_eventlog.c
+++ b/librpc/gen_ndr/ndr_eventlog.c
@@ -121,14 +121,14 @@ _PUBLIC_ enum ndr_err_code ndr_push_eventlog_Record_tdb(struct ndr_push *ndr, in
--
Samba Shared Repository
More information about the samba-cvs
mailing list