[SCM] Samba Shared Repository - branch master updated

Jeremy Allison jra at samba.org
Tue Jun 28 20:38:03 MDT 2011


The branch, master has been updated
       via  1fffddb Fix bug #8219 - SMB Panic from Windows 7 Client
      from  e63d5d2 s3-param use lp_parm_ptr() rather than parm.ptr directly

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 1fffddb2386e5c220d022da7e7a0b1baf410ce09
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Jun 28 17:45:49 2011 -0700

    Fix bug #8219 - SMB Panic from Windows 7 Client
    
    Caused by referencing an uninitialized variable in the
    duplicated struct smbd_smb2_request when sending a signed
    intermediate reply.
    
    Autobuild-User: Jeremy Allison <jra at samba.org>
    Autobuild-Date: Wed Jun 29 04:37:28 CEST 2011 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/smbd/smb2_server.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/smb2_server.c b/source3/smbd/smb2_server.c
index 65bb5b9..24953ed 100644
--- a/source3/smbd/smb2_server.c
+++ b/source3/smbd/smb2_server.c
@@ -665,10 +665,18 @@ static struct smbd_smb2_request *dup_smb2_req(const struct smbd_smb2_request *re
 	}
 
 	newreq->sconn = req->sconn;
+	newreq->session = req->session;
 	newreq->do_signing = req->do_signing;
 	newreq->current_idx = req->current_idx;
 	newreq->async = false;
 	newreq->cancelled = false;
+	/* Note we are leaving:
+		->tcon
+		->smb1req
+		->compat_chain_fsp
+	   uninitialized as NULL here as
+	   they're not used in the interim
+	   response code. JRA. */
 
 	outvec = talloc_zero_array(newreq, struct iovec, count);
 	if (!outvec) {


-- 
Samba Shared Repository


More information about the samba-cvs mailing list