[SCM] Samba Shared Repository - branch v3-6-test updated

Karolin Seeger kseeger at samba.org
Tue Jun 21 12:09:39 MDT 2011


The branch, v3-6-test has been updated
       via  11008f1 s3:modules fix Bug 8244 - Cannot copy files larger than 2 GB to Samba share
      from  8a7a3c6 s3: Fix Coverity ID 2582: FORWARD_NULL

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test


- Log -----------------------------------------------------------------
commit 11008f1c73afdd86e7fa929fe37675c57ae2c32c
Author: Christian Ambach <ambi at samba.org>
Date:   Fri Jun 17 21:54:30 2011 +0200

    s3:modules fix Bug 8244 - Cannot copy files larger than 2 GB to Samba share
    
    the time_audit module uses int instead of uint64 as return value
    in get_alloc_size so that sizes of files larger than 2 GB are
    cut of leading to wrong replies to NtCreateAndX and Windows
    clients giving up
    
    While checking the types of all functions, I found two more wrong
    return value types that needed correction
    
    Autobuild-User: Christian Ambach <ambi at samba.org>
    Autobuild-Date: Fri Jun 17 23:11:10 CEST 2011 on sn-devel-104
    (cherry picked from commit bb66504dadf56366ea30697ae73673de3df08132)

-----------------------------------------------------------------------

Summary of changes:
 source3/modules/vfs_time_audit.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/modules/vfs_time_audit.c b/source3/modules/vfs_time_audit.c
index d21542c..365e3b1 100644
--- a/source3/modules/vfs_time_audit.c
+++ b/source3/modules/vfs_time_audit.c
@@ -564,7 +564,7 @@ static SMB_OFF_T smb_time_audit_lseek(vfs_handle_struct *handle,
 				      files_struct *fsp,
 				      SMB_OFF_T offset, int whence)
 {
-	ssize_t result;
+	SMB_OFF_T result;
 	struct timespec ts1,ts2;
 	double timediff;
 
@@ -721,7 +721,7 @@ static uint64_t smb_time_audit_get_alloc_size(vfs_handle_struct *handle,
 					      files_struct *fsp,
 					      const SMB_STRUCT_STAT *sbuf)
 {
-	int result;
+	uint64_t result;
 	struct timespec ts1,ts2;
 	double timediff;
 
@@ -2216,7 +2216,7 @@ static ssize_t smb_time_audit_aio_return(struct vfs_handle_struct *handle,
 					 struct files_struct *fsp,
 					 SMB_STRUCT_AIOCB *aiocb)
 {
-	int result;
+	ssize_t result;
 	struct timespec ts1,ts2;
 	double timediff;
 


-- 
Samba Shared Repository


More information about the samba-cvs mailing list