[SCM] Samba Shared Repository - branch v3-6-test updated

Karolin Seeger kseeger at samba.org
Tue Jun 14 11:46:38 MDT 2011


The branch, v3-6-test has been updated
       via  88ed4b9 s3:net conf addshare: do not stat-check the share path.
      from  bad9f47 bug in source3/winbindd/winbindd_sids_to_xids.c

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test


- Log -----------------------------------------------------------------
commit 88ed4b9fbd2d517a3e589c104f8f3662ccdd0043
Author: Michael Adam <obnox at samba.org>
Date:   Fri Jun 10 13:51:06 2011 +0200

    s3:net conf addshare: do not stat-check the share path.
    
    Allow paths with % macros and paths that do not (yet...) exist.
    
    Fix bug #8217 (net conf addshare should not stat the share path).

-----------------------------------------------------------------------

Summary of changes:
 source3/utils/net_conf.c |   17 -----------------
 1 files changed, 0 insertions(+), 17 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/utils/net_conf.c b/source3/utils/net_conf.c
index 2c6ccda..0416404 100644
--- a/source3/utils/net_conf.c
+++ b/source3/utils/net_conf.c
@@ -585,7 +585,6 @@ static int net_conf_addshare(struct net_context *c,
 	const char *comment = NULL;
 	const char *guest_ok = "no";
 	const char *writeable = "no";
-	SMB_STRUCT_STAT sbuf;
 	TALLOC_CTX *mem_ctx = talloc_stackframe();
 
 	if (c->display_usage) {
@@ -685,22 +684,6 @@ static int net_conf_addshare(struct net_context *c,
 		goto done;
 	}
 
-	if (sys_stat(path, &sbuf, false) != 0) {
-		d_fprintf(stderr,
-			  _("ERROR: cannot stat path '%s' to ensure "
-			    "this is a directory.\n"
-			    "Error was '%s'.\n"),
-			  path, strerror(errno));
-		goto done;
-	}
-
-	if (!S_ISDIR(sbuf.st_ex_mode)) {
-		d_fprintf(stderr,
-			  _("ERROR: path '%s' is not a directory.\n"),
-			  path);
-		goto done;
-	}
-
 	/*
 	 * start a transaction
 	 */


-- 
Samba Shared Repository


More information about the samba-cvs mailing list