[SCM] Samba Shared Repository - branch master updated

Jeremy Allison jra at samba.org
Fri Jul 29 17:35:02 MDT 2011


The branch, master has been updated
       via  2049357 Added missing return. Not strictly neccessary, the following if (!NT_STATUS_EQUAL(status, NT_STATUS_NOT_SUPPORTED)) clause will catch this and use tevent_req_nterror(req, status); to set the status as NT_STATUS_OK, but it looks strange to do it that way.
      from  1d4d919 Secod part of bugfix for bug #8335 - file copy aborts with smb2_validate_message_id: bad message_id

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 20493572178ed5791806dbdb4572f595db3110b2
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Jul 29 15:20:15 2011 -0700

    Added missing return. Not strictly neccessary, the following if (!NT_STATUS_EQUAL(status, NT_STATUS_NOT_SUPPORTED))
    clause will catch this and use tevent_req_nterror(req, status); to set the status as NT_STATUS_OK, but
    it looks strange to do it that way.
    
    Autobuild-User: Jeremy Allison <jra at samba.org>
    Autobuild-Date: Sat Jul 30 01:34:24 CEST 2011 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/libsmb/clifile.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/libsmb/clifile.c b/source3/libsmb/clifile.c
index 3590350..59cdb7b 100644
--- a/source3/libsmb/clifile.c
+++ b/source3/libsmb/clifile.c
@@ -2253,6 +2253,7 @@ static void cli_open_done(struct tevent_req *subreq)
 	if (NT_STATUS_IS_OK(status)) {
 		state->fnum = SVAL(vwv+2, 0);
 		tevent_req_done(req);
+		return;
 	}
 
 	if (!NT_STATUS_EQUAL(status, NT_STATUS_NOT_SUPPORTED)) {


-- 
Samba Shared Repository


More information about the samba-cvs mailing list