[SCM] Samba Shared Repository - branch master updated

Christian Ambach ambi at samba.org
Tue Jul 26 07:58:01 MDT 2011


The branch, master has been updated
       via  749868e s3:lib change default share security access mask
      from  ac57cfd libsamba-util: Build in libbitmap.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 749868ede4cf2d3888135716d98d38dff020cae3
Author: Christian Ambach <ambi at samba.org>
Date:   Tue Jul 26 13:43:14 2011 +0200

    s3:lib change default share security access mask
    
    when there is no share SD set, the default share SD that
    is used e.g. for the output of sharesec -v defaults to a
    value that is not equivalent to the desired FULL access.
    
    This is a more or less a cosmetical follow-up for the patches
    in Bug #8201 that makes them more consumeable by printing
    FULL (that is what the user expects) instead of a bitmask
    in hexadecimal form.
    
    previous output:
    REVISION:1
    OWNER:(NULL SID)
    GROUP:(NULL SID)
    ACL:S-1-1-0:ALLOWED/0/0x101f01ff
    
    with patch:
    REVISION:1
    OWNER:(NULL SID)
    GROUP:(NULL SID)
    ACL:S-1-1-0:ALLOWED/0/FULL
    
    Autobuild-User: Christian Ambach <ambi at samba.org>
    Autobuild-Date: Tue Jul 26 15:57:55 CEST 2011 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/lib/sharesec.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/lib/sharesec.c b/source3/lib/sharesec.c
index 2f62535..11ccb42 100644
--- a/source3/lib/sharesec.c
+++ b/source3/lib/sharesec.c
@@ -293,7 +293,7 @@ struct security_descriptor *get_share_security( TALLOC_CTX *ctx, const char *ser
 
 	if (data.dptr == NULL) {
 		return get_share_security_default(ctx, psize,
-						  GENERIC_ALL_ACCESS);
+						  SEC_RIGHTS_DIR_ALL);
 	}
 
 	status = unmarshall_sec_desc(ctx, data.dptr, data.dsize, &psd);
@@ -304,14 +304,14 @@ struct security_descriptor *get_share_security( TALLOC_CTX *ctx, const char *ser
 		DEBUG(0, ("unmarshall_sec_desc failed: %s\n",
 			  nt_errstr(status)));
 		return get_share_security_default(ctx, psize,
-						  GENERIC_ALL_ACCESS);
+						  SEC_RIGHTS_DIR_ALL);
 	}
 
 	if (psd) {
 		*psize = ndr_size_security_descriptor(psd, 0);
 	} else {
 		return get_share_security_default(ctx, psize,
-						  GENERIC_ALL_ACCESS);
+						  SEC_RIGHTS_DIR_ALL);
 	}
 
 	return psd;


-- 
Samba Shared Repository


More information about the samba-cvs mailing list