[SCM] Samba Shared Repository - branch master updated

[Volker Lendecke]

The branch, master has been updated
       via  2dfc898 s3: Follow the TALLOC_FREE convention in source3
       via  6fcb3bb s3: Fix Coverity ID 2586 -- NO_EFFECT
      from  7d96a45 s3: Remove cli_errstr from cmd_posix_open

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 2dfc898d1a3927fa01de0f2afe72864f30a1ca58
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jul 6 09:39:08 2011 +0200

    s3: Follow the TALLOC_FREE convention in source3
    
    Autobuild-User: Volker Lendecke <vlendec at samba.org>
    Autobuild-Date: Wed Jul  6 11:01:05 CEST 2011 on sn-devel-104

commit 6fcb3bbdae835f513e5c539eddb437f2ae4c1c88
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jul 6 09:37:04 2011 +0200

    s3: Fix Coverity ID 2586 -- NO_EFFECT
    
    tsocket_address_bsd_sockaddr returns ssize_t, and on some systems socklen_t is
    unsigned. So (len < 0) could never have turned true.
    
    Volker

-----------------------------------------------------------------------

Summary of changes:
 source3/lib/util_sock.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/lib/util_sock.c b/source3/lib/util_sock.c
index a35bd58..867646b 100644
--- a/source3/lib/util_sock.c
+++ b/source3/lib/util_sock.c
@@ -1135,7 +1135,7 @@ int get_remote_hostname(const struct tsocket_address *remote_address,
 	char tmp_name[MAX_DNS_NAME_LENGTH];
 	struct name_addr_pair nc;
 	struct sockaddr_storage ss;
-	socklen_t len;
+	ssize_t len;
 	int rc;
 
 	if (!lp_hostname_lookups()) {
@@ -1205,7 +1205,7 @@ int get_remote_hostname(const struct tsocket_address *remote_address,
 			 gai_strerror(rc)));
 		strlcpy(name_buf, p, sizeof(name_buf));
 
-		talloc_free(p);
+		TALLOC_FREE(p);
 	} else {
 		if (!matchname(name_buf, (struct sockaddr *)&ss, len)) {
 			DEBUG(0,("matchname failed on %s\n", name_buf));


-- 
Samba Shared Repository