[SCM] Samba Shared Repository - branch v3-6-test updated

Volker Lendecke vlendec at samba.org
Sat Jan 29 07:04:06 MST 2011


The branch, v3-6-test has been updated
       via  4a17624 s3: Remove an unneeded check
      from  1772ad5 s3: inline get_uid_from_state

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test


- Log -----------------------------------------------------------------
commit 4a176246579f472d6458d46d9be8efa71dd49a73
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Jan 29 14:07:59 2011 +0100

    s3: Remove an unneeded check
    
    In many other places we already assume that if asprintf returns !=-1 then the
    result is allocated.
    
    Autobuild-User: Volker Lendecke <vlendec at samba.org>
    Autobuild-Date: Sat Jan 29 15:00:09 CET 2011 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/libsmb/smb_share_modes.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/libsmb/smb_share_modes.c b/source3/libsmb/smb_share_modes.c
index fd5f0ea..3174500 100644
--- a/source3/libsmb/smb_share_modes.c
+++ b/source3/libsmb/smb_share_modes.c
@@ -272,7 +272,7 @@ static uint32_t smb_name_hash(const char *sharepath, const char *filename, int *
 
 	*err = 0;
 	ret = asprintf(&fullpath, "%s/%s", sharepath, filename);
-	if (ret == -1 || fullpath == NULL) {
+	if (ret == -1) {
 		*err = 1;
 		return 0;
 	}


-- 
Samba Shared Repository


More information about the samba-cvs mailing list