s3: Fix an infinite loop

Stefan (metze) Metzmacher metze at samba.org
Mon Jan 24 01:59:43 MST 2011


Hi Volker,

> On Mon, Jan 24, 2011 at 09:14:23AM +0100, Stefan (metze) Metzmacher wrote:
>> I think this change is wrong because, selret is a pointer and we already
>> have this check (directly above):
> 
> Gna. I have first done this in 3.5, where selrtn is not a
> pointer. I have then just taken the same patch and applied
> it to master, wrongly assuming that this is the same piece
> of code. The patch applied cleanly, so I did not check.
> Apologies for this false assumption.

No problem, I assumed something like that:-)

> By the way, where does 3.5 handle the selrtn==-1 case?

I think we need something like this there:

http://gitweb.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=22f0e9bf00fb8a3dc02b8c4e13d05b9f7a9adb6b
http://gitweb.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=d935696bc4559fe66f3420b8bbe0d9a595b41116

> I have just pushed the revert to autobuild.

Does my other changes make sense for you?

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-cvs/attachments/20110124/27d7a451/attachment.pgp>


More information about the samba-cvs mailing list