[SCM] Samba Shared Repository - branch master updated

Stefan Metzmacher metze at samba.org
Tue Jan 18 00:11:02 MST 2011


The branch, master has been updated
       via  d5173ca pidl:wscript: don't warn about pidl gammar file changes for now
      from  1667ff7 s4-ldb_ldif: Take into account LDB_FLG_SHOW_BINARY

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit d5173ca189a080d0bb3a56200203c32a40c4b6e3
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Jan 18 07:20:26 2011 +0100

    pidl:wscript: don't warn about pidl gammar file changes for now
    
    We may add some logic that uses git diff HEAD to detect this changes
    in developer mode later again.
    
    metze
    
    Autobuild-User: Stefan Metzmacher <metze at samba.org>
    Autobuild-Date: Tue Jan 18 08:10:06 CET 2011 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 pidl/wscript |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/pidl/wscript b/pidl/wscript
index 5b3e07c..e60ca20 100644
--- a/pidl/wscript
+++ b/pidl/wscript
@@ -59,11 +59,13 @@ def build(bld):
     # Only if the source has changed do we want to re-run yapp
     # But we force the developer to use the pidl standalone build
     # to regenerate the files.
-    need_yapp_build = ('YAPP' in bld.env and (
+    # TODO: only warn in developer mode and if 'git diff HEAD'
+    #       shows a difference
+    warn_about_grammar_changes = ('PIDL_BUILD_WARNINGS' in bld.env and (
         bld.IS_NEWER('idl.yp', 'lib/Parse/Pidl/IDL.pm') or
         bld.IS_NEWER('expr.yp', 'lib/Parse/Pidl/Expr.pm')))
 
-    if need_yapp_build:
+    if warn_about_grammar_changes:
         Logs.warn('''
 Pidl grammar files have changed. Please use the pidl standalone build
 to regenerate them with yapp.


-- 
Samba Shared Repository


More information about the samba-cvs mailing list