[SCM] Samba Shared Repository - branch master updated

Andrew Tridgell tridge at samba.org
Thu Feb 3 22:52:02 MST 2011


The branch, master has been updated
       via  13470f1 charcnv: removed call to setlocale() (bug 7519)
      from  1e42aa6 replace: Try to fix broken sys/capabilites.h on Linux.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 13470f11ee47da446eb7094c29dbc8ff402aede9
Author: Andrew Tridgell <tridge at samba.org>
Date:   Fri Feb 4 16:04:30 2011 +1100

    charcnv: removed call to setlocale() (bug 7519)
    
    We don't need this setlocale() call, and it can break applications
    that use our libraries
    
    Thanks to Milan Crha for pointing this out
    
    Autobuild-User: Andrew Tridgell <tridge at samba.org>
    Autobuild-Date: Fri Feb  4 06:51:01 CET 2011 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 lib/util/charset/charcnv.c |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)


Changeset truncated at 500 lines:

diff --git a/lib/util/charset/charcnv.c b/lib/util/charset/charcnv.c
index f8aeea3..59b36e3 100644
--- a/lib/util/charset/charcnv.c
+++ b/lib/util/charset/charcnv.c
@@ -139,16 +139,6 @@ static smb_iconv_t get_conv_handle(struct smb_iconv_convenience *ic,
 
 	if (initialised == false) {
 		initialised = true;
-		
-#ifdef LC_ALL
-		/* we set back the locale to C to get ASCII-compatible
-		   toupper/lower functions.  For now we do not need
-		   any other POSIX localisations anyway. When we
-		   should really need localized string functions one
-		   day we need to write our own ascii_tolower etc.
-		*/
-		setlocale(LC_ALL, "C");
-#endif
 	}
 
 	if (ic->conv_handles[from][to]) {


-- 
Samba Shared Repository


More information about the samba-cvs mailing list