[SCM] Samba Shared Repository - branch master updated

Günther Deschner gd at samba.org
Wed Dec 21 09:24:03 MST 2011


The branch, master has been updated
       via  bfbb389 s3-dns: prevent from potentially doing wrong SRV DNS lookups.
      from  53d54f9 idl: Avoid c++ style comments

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit bfbb3893325b0a0a47d49c3a1ad83f047f42e361
Author: Günther Deschner <gd at samba.org>
Date:   Wed Dec 21 15:47:35 2011 +0100

    s3-dns: prevent from potentially doing wrong SRV DNS lookups.
    
    With an empty sitename we asked for e.g.
    _ldap._tcp.._sites.dc._msdcs.AD.EXAMPLE.COM
    
    Guenther
    
    Autobuild-User: Günther Deschner <gd at samba.org>
    Autobuild-Date: Wed Dec 21 17:23:25 CET 2011 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/libads/dns.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/libads/dns.c b/source3/libads/dns.c
index 5eae10e..39454fc 100644
--- a/source3/libads/dns.c
+++ b/source3/libads/dns.c
@@ -756,7 +756,7 @@ static NTSTATUS ads_dns_query_internal(TALLOC_CTX *ctx,
 				       int *numdcs )
 {
 	char *name;
-	if (sitename) {
+	if (sitename && strlen(sitename)) {
 		name = talloc_asprintf(ctx, "%s._tcp.%s._sites.%s._msdcs.%s",
 				       servicename, sitename,
 				       dc_pdc_gc_domains, realm);


-- 
Samba Shared Repository


More information about the samba-cvs mailing list