[SCM] Samba Shared Repository - branch master updated

[Christian Ambach]

The branch, master has been updated
       via  fac75f0 s3:winbindd fix a return code check
      from  6d2f65b s3: Fix an uninitialized variable

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit fac75f04a8577fd0eb5a3fff9914e4abffa91a1e
Author: Christian Ambach <ambi at samba.org>
Date:   Wed Aug 24 16:21:37 2011 +0200

    s3:winbindd fix a return code check
    
    talloc_traverse_dict will return with -1 in case of an error and
    might return positive values that indicate the count of found
    entries
    
    Autobuild-User: Christian Ambach <ambi at samba.org>
    Autobuild-Date: Wed Aug 24 18:09:11 CEST 2011 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/winbindd/winbindd_group.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/winbindd/winbindd_group.c b/source3/winbindd/winbindd_group.c
index 1e4ad5f..2f8ba6a 100644
--- a/source3/winbindd/winbindd_group.c
+++ b/source3/winbindd/winbindd_group.c
@@ -115,7 +115,7 @@ NTSTATUS winbindd_print_groupmembers(struct talloc_dict *members,
 	c.len = 0;
 
 	res = talloc_dict_traverse(members, getgr_calc_memberlen, &c);
-	if (res != 0) {
+	if (res == -1) {
 		DEBUG(5, ("talloc_dict_traverse failed\n"));
 		return NT_STATUS_INTERNAL_ERROR;
 	}
@@ -128,7 +128,7 @@ NTSTATUS winbindd_print_groupmembers(struct talloc_dict *members,
 	}
 
 	res = talloc_dict_traverse(members, getgr_unparse_members, &m);
-	if (res != 0) {
+	if (res == -1) {
 		DEBUG(5, ("talloc_dict_traverse failed\n"));
 		TALLOC_FREE(m.buf);
 		return NT_STATUS_INTERNAL_ERROR;


-- 
Samba Shared Repository