[SCM] Samba Shared Repository - branch master updated

Andrew Tridgell tridge at samba.org
Sun Sep 26 22:55:01 MDT 2010


The branch, master has been updated
       via  785410c s4-drs: fixed comment in getncchanges code
       via  06274bd s4-gensec: fixed a valgrind error in gensec
      from  f9ba8f5 lib/util: change tevent_req_nterror() to a macro

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 785410c49373bd9f0cb9c533809fb923ecb18b80
Author: Andrew Tridgell <tridge at samba.org>
Date:   Sun Sep 26 21:12:02 2010 -0700

    s4-drs: fixed comment in getncchanges code
    
    Autobuild-User: Andrew Tridgell <tridge at samba.org>
    Autobuild-Date: Mon Sep 27 04:54:43 UTC 2010 on sn-devel-104

commit 06274bd87080f29f0be2b49a0ea65bf98b6e0b0c
Author: Andrew Tridgell <tridge at samba.org>
Date:   Sun Sep 26 21:11:42 2010 -0700

    s4-gensec: fixed a valgrind error in gensec
    
    Pair-Programmed-With: Andrew Bartlett <abartlet at samba.org>

-----------------------------------------------------------------------

Summary of changes:
 source4/auth/gensec/gensec.c              |   14 ++------------
 source4/rpc_server/drsuapi/getncchanges.c |    2 +-
 2 files changed, 3 insertions(+), 13 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/auth/gensec/gensec.c b/source4/auth/gensec/gensec.c
index 7220d0e..7f76643 100644
--- a/source4/auth/gensec/gensec.c
+++ b/source4/auth/gensec/gensec.c
@@ -521,19 +521,9 @@ static NTSTATUS gensec_start(TALLOC_CTX *mem_ctx,
 		return NT_STATUS_INTERNAL_ERROR;
 	}
 
-	(*gensec_security) = talloc(mem_ctx, struct gensec_security);
+	(*gensec_security) = talloc_zero(mem_ctx, struct gensec_security);
 	NT_STATUS_HAVE_NO_MEMORY(*gensec_security);
 
-	(*gensec_security)->ops = NULL;
-	(*gensec_security)->local_addr = NULL;
-	(*gensec_security)->remote_addr = NULL;
-	(*gensec_security)->private_data = NULL;
-
-	ZERO_STRUCT((*gensec_security)->target);
-
-	(*gensec_security)->subcontext = false;
-	(*gensec_security)->want_features = 0;
-
 	(*gensec_security)->event_ctx = ev;
 	SMB_ASSERT(settings->lp_ctx != NULL);
 	(*gensec_security)->settings = talloc_reference(*gensec_security, settings);
@@ -554,7 +544,7 @@ _PUBLIC_ NTSTATUS gensec_subcontext_start(TALLOC_CTX *mem_ctx,
 				 struct gensec_security *parent, 
 				 struct gensec_security **gensec_security)
 {
-	(*gensec_security) = talloc(mem_ctx, struct gensec_security);
+	(*gensec_security) = talloc_zero(mem_ctx, struct gensec_security);
 	NT_STATUS_HAVE_NO_MEMORY(*gensec_security);
 
 	(**gensec_security) = *parent;
diff --git a/source4/rpc_server/drsuapi/getncchanges.c b/source4/rpc_server/drsuapi/getncchanges.c
index 5c8091a..204297d 100644
--- a/source4/rpc_server/drsuapi/getncchanges.c
+++ b/source4/rpc_server/drsuapi/getncchanges.c
@@ -1,7 +1,7 @@
 /* 
    Unix SMB/CIFS implementation.
 
-   implement the DRSUpdateRefs call
+   implement the DSGetNCChanges call
 
    Copyright (C) Anatoliy Atanasov 2009
    Copyright (C) Andrew Tridgell 2009


-- 
Samba Shared Repository


More information about the samba-cvs mailing list